Replace with gsub! in ActiveSupport::Inflector.
Merge pull request #13257 from eshira/optimize-gsub

Replace with gsub! in ActiveSupport::Inflector
Fix typo in docs, missing colon in Symbol literal [ci skip]
Merge pull request #13258 from semaperepelitsa/docs

Fix typo in docs, missing colon in Symbol literal
Revert "Rename not Ruby files to .tt"

This reverts commit bd360ad3c1d59273bf96ea01b17cf04285816dc2.

Reverting this for now until we fix the Thor related issue
Fix mounting engines inside a resources block

When a route is mounted inside a resources block, it's automatically
prefixed, so a following code:

    resources :users do
      mount Blog::Engine => '/blog'
    end

will generate a user_blog path helper.

In order to access engine helpers, we also use "mounted_helpers", a list
of helpers associated with each mounted engine, so a path to blog's post
can be generated using user_blog.post_path(user, post).

The problem I'm fixing here is that mount used a raw :as option, without
taking nestings into account. As a result, blog was added to a route set
as a `user_blog`, but helper was generated for just `blog`.

This commit applies the proper logic for defining a helper for a mounted
engine nested in resources or resource block.

(closes #8533)
Merge pull request #12699 from drogus/fix-mounting-engine-in-resources

Fix mounting engines inside a resources block
Using parallelize_me! to parallelize isolated test


As ParallelEach is no more available

related commit ec00442c10cb90796909e876fb1cc557ed7518bd
Merge pull request #13260 from arunagw/using-parallelize_me

Using parallelize_me! to parallelize isolated test
Prevent invalid code when using dynamic finders with Ruby's reserved words.

The dynamic finder was creating the method signature with the parameters name,
which may have reserved words and this way creating invalid Ruby code.

Closes: #13261

    Example:

        # Before
        Dog.find_by_alias('dog name')

        # Was creating this method
        def self.find_by_alias(alias, options = {})

        # After
        Dog.find_by_alias('dog name')

        # Will create this method
        def self.find_by_alias(_alias, options = {})
typo rectified [skip ci]
Merge pull request #13270 from aayushkhandelwal11/typos

typo rectified
Remove require 'models/administrator', Administrator is not used in secure password test
Merge pull request #13273 from robertomiranda/test-remove-require

Remove require 'models/administrator', Administrator is not used in secure password test
removing multiple check conditions to single check condition
Merge pull request #13276 from aayushkhandelwal11/change_to_key

removing multiple check conditions to single check condition
Bring back the valid_options class accessor

It is need in activerecord-deprecated_finders
Revert "Merge pull request #12518 from vipulnsward/remove_count_options"

It is needed for activerecord-depecated_finders

This reverts commit dcff027a5242b20c0c90eb062dddb22ccf51aed9, reversing
changes made to 3a2093984ff49d86db1efeff0c7581e788ecfb9f.
Mark the arguments needed by activerecord-deprecated_finders with a TODO
Revert "Merge pull request #13276 from aayushkhandelwal11/change_to_key"

This will call primary_key two times

This reverts commit d0588a2e897d33c6c12e9fc5f8680328d37a26ca, reversing
changes made to 87e1e86640fb8b5a260ff7c0044aaae58fff2bc4.