core:ovirt-engine-backend: engine.log is flooded..

ovirt-engine-backend: engine.log is flooded by Failed to decrypt Data

Excluding the key store password (keystorePass) out of the list, so it
will not be
encrypted.

Change-Id: Ife6005688a06d62a740970ea14b617010d6b9b2d
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=880978
Signed-off-by: Eli Mesika <emesika@redhat.com>
findbugs: revert unnecessary Serializable

patch http://gerrit.ovirt.org/#/c/13993/ added Serializable to
BackendAssignedPermissionsResource by mistake,
this patch remove it.

Change-Id: I659aa7f13b51a2c94dbf53f70704014a183ed0d7
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
core: initialize vds - select random host

when attempting to initialize vds, attempt to perform it through random
host to not try always through the same one.

Change-Id: If636850ba7d13b9a0be146059a9a964bb881abde
Signed-off-by: Liron Aravot <laravot@redhat.com>
core:  initVdsOnUp- remove reconstruct and host status.

*Host that runs through init vds on up shouldn't attempt to reconstruct.

*In case of failure during ConnectStoragePool, the host should fail in
initalizeStorage() only if the master domain isn't in inactive/
unknown status and the exception wasn't XmlRpcRunTimeException (which is
represented by VdcBllErrors.VDS_NETWORK_ERROR.

Change-Id: I6418b9d2826146e1e4ceff4341c6d7cd3a0024af
Signed-off-by: Liron Aravot <laravot@redhat.com>
engine: Replacing getVds() query by getVdsStatic() query in VDSCommands

The following patch will replace a getVds() query by getVdsStatic() query in almost all vds (not spm) commands.
THe reasons are:
1. A getVds() query - is a query to view, which is based on JOIN from at least 7 tables, getVdsStatic() it is a query
to single table, meaning much more faster.
2. VDSStatic object is smaller than VDS object, less resources spent on retrievening it from DB, allocatin memory, etc...
3. VDSStatic object almost never changed, it is means that when it will be cached, we will not perfrom any query during
vds commands, the VDS object contains VDSDynamic part, which is changed very frequently, so caching of VDS object is more
difficult and possible not efficient.
4. No reason to use VDS object , when we can use VDSStatic object

Also patch includes a following fixes and improvements:
1. FullListVDSCommand will never perform a query to vds object, it will be passed via parameters
2. A part of code moved from GetCapabilitiesVDSCommand to CollectVdsNetworkDataVDSCommand, this code is not relevant
   for GetCapabilitiesVDSCommand and only relevant for CollectVdsNetworkDataVDSCommand
3. Code clean up

Also, after applying a patch, a query for VDSStatic will be made only if it is required to log command, and not always in
constractor

Change-Id: Iff6fa35e25bcd895c25359ece6ba4d5ce9c8e8cf
Signed-off-by: Michael Kublin <mkublin@redhat.com>
engine: Removing date creation from MultipleActionsRunner during logging

Removed explicity date creation during logging in MultipleActionsRunner.
Logger is writting date, so no reason to write by myself

Change-Id: Id3d872e3f537be9a099260dd023802be16f7a734
Signed-off-by: Michael Kublin <mkublin@redhat.com>
engine: Fixing correlationId in MultipleActionRunner

The following patch should connect canDoAction with execute part of command by correlationId.
From now, all loggs related to command which was run via MultipleactionRunner will have same correlationId.
Removed some code which is checking if command has correlationId as irrelavant

Change-Id: I2e0ce3452af69cfde3bc5f6b1075589455ce4cce
Signed-off-by: Michael Kublin <mkublin@redhat.com>
core: broken unit test

Fixed a unit test that would break if a file didn't exist in a certain
environment.

Unit test now creates a file "on the fly" (without writing it to the
disk) and uses it rather than relying on a file that may or may not
exist on the disk.

Change-Id: I9d0627ea770a3194515b22b6d6cc5df5fe8df829
Signed-off-by: Alexander Wels <awels@redhat.com>
core: re-support broken apache proxy

apache proxy support was broken in:
I37156061cbdd, 'core: i18n splash screen.'

The changed cause invalid redirection and the following error message in
console log:
---
Exception while dispatching incoming RPC call:
java.lang.SecurityException: Blocked request without GWT base path
header (XSRF attack?)
---

Content:

1. Remove unused ovirt-engine.html (what was index.html) as it is
   superseded by index.jsp

2. Remove redundant welcome directive from web.xml

3. Rename /index.jsp to /ovirt-engine.jsp to be referenced by both
   apache and jboss.

4. Rename servlet mapping of /index to /ovirt-engine.

5. Modify 404.html pages to redirect to /ovirt-engine instead of
   /ovirt-engine.html

6. Remove reference of ovirt-engine.html from the proxy.

Change-Id: I7ac8feb720d73f0b1107b0bf0908930c525ea542
Signed-off-by: Alon Bar-Lev <alonbl@redhat.com>