virttest.virsh: Remove obsolete part of the docstring

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
qemu: virtio_console - Fix typo

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
utils_cgroup: Strip the slash from cgroup path

We have to strip the slash from cgroup path because the "join" function
takes the last element starting with slash as the root path.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
utils_cgroup: Fix regexp for cgroup controllers

On some systems the cpu and cpuacct controllers are mounted together
like cpu,cpuacct and we should count with it.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
virsh_attach_detach_disk: attach tmp disk with config option into offline guest

We want to attach the disk with --config parameter, because we have to be sure,
that the disk will be attached using all versions of libvirt. But to use this
parameter we have to at first shutdown the guest because this chagne will affect
next boot of the guest.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
virsh_attach_detach_disk: move add acpi module after attach/detach required disks

To reduce restart count and time needed to do it I've just move this code after
disks preparation. For disk preparation you need to have the guest offline and
it would be pointless to start the guest, modprobe the acpiphp and than shutdonw
the guest again to attach/detach required disks.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
virsh_attach_detach_disk: attach second temp disk for the detach_twice test

We have to attach two disks for the detach_twice test in order to run the test.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
virsh_attach_detach_disk: make the proper return status checking

It's obvious that if you are running the attach/detach config test
that you will not see the change in the xml returned by dumpxml of
a live guest.

This patch also fixes whitespace issues and typo in error message.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
virsh_attach_detach_disk: improve 'acpiphp_module_modprobe' function

Executing the 'rpm -qa | grep redhat-release' on non RHEL system or
non RPM system will cause the tests to fail. Adding few more conditions
resolves this issue.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
virsh_attach_detach_disk: resume guest before we check the xml file

On newer libvirt there is a fix for a bug, that xml file is updated
before guest is resumed. The correct way is that the xml file is
updated after the guest is resumed.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
libvirt: virsh_cmd - Fix 'acpiphp_module_modprobe' function

If the command rpm --version fails, it means this command
is not present there. Fix the test that checks this condition.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
virt.qemu.test.systemtap_tracing : make the test more robust

This patch make the systemtap_tracing test more robust.

Signed-off-by: Yunping Zheng <yunzheng@redhat.com>
virt.tests: Updates to netperf

Get netperf src package from web;
Make the script compatible with netperf 2.6.0;
Modify the method of get winutils vol;
Modify the method of start netserver in windows guest
Using wait_for  to wait until all net perf clients start to work;
Reorganize the configure file.

Signed-off-by: Yunping Zheng <yunzheng@redhat.com>
qemu.test.netperf_udp: Some modify of netperf_udp

This patch modify the method of et netperf, make the script support
UDP_RR test, also modify the temporary dir.

Signed-off-by: Yunping Zheng <yunzheng@redhat.com>
virt-libvirt: New libvirt_xml accessor generators

* Small behavior fix on XMLElementText
* XMLElementBool: Treat "flag" elements as boolean values for presense
* XMLElementNest: Allows "nesting" an arbitrary LibvirtXMLBase subclass
                  then rerooting it's XML under a parent element
* XMLElementList: Represent duplicate child elements (valid in XML) as
                  if it were a list, with values marshaled to/from XML
                  and opaque values.
* Added unittests for all three

Signed-off-by: Chris Evich <cevich@redhat.com>
virt-libvirt: attach/detach device test

Signed-off-by: Chris Evich <cevich@redhat.com>
virt-libvirt: Remove disused VM methods

Signed-off-by: Chris Evich <cevich@redhat.com>
virt-libvirt: Fixup some unittest whitespace

Signed-off-by: Chris Evich <cevich@redhat.com>
virt-libvirt: Implement libvirt_xml.devices.disk

Signed-off-by: Chris Evich <cevich@redhat.com>
virt-libvirt: Rename address device property

Signed-off-by: Chris Evich <cevich@redhat.com>