Maybe I shouldn't use word "generic" - what I meant is that variable name
shouldn't be strongly associated with the current text displayed on the
button "Classic editor" - because it might change - and itself is not very
descriptive as well - is it CK? is it source editor?


On Thu, Oct 31, 2013 at 10:21 AM, Liz Lee <notifications@github.com> wrote:

> In
> extensions/VisualEditor/wikia/modules/ve/init/ve.init.mw.WikiaViewPageTarget.init.js:
>
> > @@ -263,9 +269,10 @@
> >  	mw.libs.ve
>  = init;
> >
> >  	if ( !init.isAvailable ) {
> > +		$classicEditLink = $( '#ca-edit' );
>
> I didn't think we wanted variable names to be generic, but rather
> descriptive. In any case I changed it because I'm new to this code and
> maybe this is more consistent with what's already there.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Wikia/app/pull/1892/files#r7349043>
> .
>