I think it'd make more sense to use `isset` rather than empty. You might want to set these to be nothing in order to test that behaviour. Other than that, it looks fine.