done for reading parameters