initial master side P4() source step
removed defaultBranch argument which has no purpose. Improved API docs. Added P4:.. prefixing on logging.
added docs for P4 master side source step
address jaredgrubb's pull feedback
remove possible_methods per pull request comment since it doesn't really apply to perforce
Merge branch 'master' of https://github.com/buildbot/buildbot into p4_master_step_2012
Started adding some tests. More to be done. Added more validation of parameters to P4() in initializer
Started adding some tests. More to be done. Added more validation of parameters to P4() in initializer
fixed merge conflict
improved validation logic in __init__, and added tests to cover this. Also address comment by jaredgrubb regarding clipped comment
Added test for incremental mode checkout
Remove some code copied from SVN tests. Add comment to clarify purpose of setting property in setupStep
added test for full checkout. Added _rmdir() method to P4 needed for full command.
revised P4 step docs to match changes in code.
fix pyflakes issues with new P4 and test code
Handle skipping some config checking if either p4base or p4branch is a renderanble
removed extra tests copied from SVN's test. Reorganized tests to have simpler logic. Added tests for Renderable parameters
added test to check that specifying a revision works properly. Required setting the revision property on the mocked sourcestamp
address feedback on pull request by deleting logic no longer required in __init__ method of P4.
Remove some commented out logic