sure, I'll give it a go (later this week)


On Tue, Sep 3, 2013 at 11:29 AM, Louis Thibault <notifications@github.com>wrote:

> In ephemeral/__init__.py:
>
> > +        while self.tell() < self.size and len(lines) < n:
> > +            lines.append(self.readline())
> > +        return lines
> > +
> > +    @property
> > +    def closed(self):
> > +        if self.size == self.max_size:
> > +            raise ValueError('ambigous of closed or full')
> > +        try:
> > +            self._file.write('')
> > +            return False
> > +        except ValueError:
> > +            return True
> > +
> > +
> > +class Test_SpooledEphemeralFile(object):
>
> I just realized my test files weren't included in my previous commits, so
> I went a head and pushed those changes.
>
> Would you mind terribly moving this test to it's own file under tests/and rewriting this class to make use of
> unittest.TestCase?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/louist87/ephemeral/pull/2/files#r6128720>
> .
>