Ok.


On Fri, Aug 30, 2013 at 5:14 PM, Adrien Thebo <notifications@github.com>wrote:

> In lib/puppet/provider/group/gpasswd.rb:
>
> > +        retval = @resource[:members]
> > +      end
> > +    else
> > +      retval = @objectinfo.mem
> > +    end
> > +
> > +    retval
> > +  end
> > +
> > +  def members=(members)
> > +    cmd = []
> > +    new_mem = members.dup
> > +    if @resource[:attribute_membership] == :minimum then
> > +      new_mem = new_mem | @objectinfo.mem
> > +    else
> > +      del_list = @objectinfo.mem - new_mem
>
> We're not being consistent in naming here, it might be more readable to
> have members_to_add and members_to_remove instead of new_mem and del_list.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/puppetlabs/puppet/pull/1848/files#r6096405>
> .
>



-- 
Trevor Vaughan
Vice President, Onyx Point, Inc
(410) 541-6699
tvaughan@onyxpoint.com

-- This account not approved for unencrypted proprietary information --