working on test logic