On 2013-08-08 10:19, David Mason wrote:
> In zanata-war/src/test/java/org/zanata/tmx/TMXParserTest.java:
> 
>> +      assertThat(tm.getSourceLanguage(), equalTo("en"));
>> +
>> +      // TM metadata
>> +      assertThat(tm.getMetadata().size(), greaterThan(0));
>> +      assertThat(tm.getMetadata().get(TMMetadataType.TMX14), notNullValue());
>> +
>> +      // Translation Units
>> +      for(TransMemoryUnit tu : tm.getTranslationUnits())
>> +      {
>> +         assertThat(tu.getTransUnitVariants().size(), greaterThan(0));
>> +      }
>> +   }
>> +
>> +   @Test
>> +   @org.junit.Test
>> +   public void parseDubiousTMX() throws Exception
> 
> Does 'dubious' here just mean it has underscores (in the locales?), or
> is it implying more? A more descriptive name would help me understand
> what's happening without having to dig up and analyse
> "/tmx/dubious-tm-with-underscores.tmx"
> 
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zanata/zanata-server/pull/78/files#r5648084>.
> 

Would it help if I renamed to parseDubiousTMXWithUnderscores(), or is
the filename just below ("/tmx/dubious-tm-with-underscores.tmx") adequate?

-- 
Sean Flanigan

Senior Software Engineer
Engineering - Internationalisation
Red Hat