OdfModel and OdfFit are abstract classes anyways so I think this change is
fine. For subclasses of OdfModel and OdfFit I think it's ok if they
override the behavior of their parent classes and change the interface. I
can have a go at this if you'd like.

Bago


On Mon, Nov 18, 2013 at 3:32 PM, Ariel Rokem <notifications@github.com>wrote:

> In dipy/reconst/gqi.py:
>
> >
> >
> > -class GeneralizedQSamplingModel(OdfModel, Cache):
> > -
> > +class GeneralizedQSamplingModel(ReconstModel, OdfModel, Cache):
>
> OK - I have discovered that this entails that you can no longer initialize
> an OdfModel object without a gtab and an OdfFit object with data. This
> seems like a feature of the inheritance to me, rather than a bug, but I
> thought I would flag this.
>
> See: arokem@4fecbc4<https://github.com/arokem/dipy/commit/4fecbc451af58b5fff0a1a7c14ea44c66fcd03a2>
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nipy/dipy/pull/247/files#r7743818>
> .
>