Good point!

I'd be happy if you put the ivar(s) in the main class with a comment above
it saying something like 'this is only for the parser+streaming category'.

Thanks a lot

On Fri, Jan 18, 2013 at 4:30 AM, kenmaz <notifications@github.com> wrote:

> In MessagePackParser.m:
>
> > @@ -9,7 +9,11 @@
> >  #import "MessagePackParser.h"
> >  #include "msgpack_src/msgpack.h"
> >
> > -@implementation MessagePackParser
> > +static const int kUnpackerBufferSize = 1024;
> > +
> > +@implementation MessagePackParser {
> > +    msgpack_unpacker unpacker;
>
> In order to unpack streaming data, it is necessary to receive and store
> some data.
> For that purpose, it is necessary to hold unpacker as an instance
> variable.
> But instance variable can not be define in category.
>
> @implementation MessagePackParser (Streaming) {
>     msgpack_unpacker unpacker; /// complie error.
> }
>
> I think there is two options.
> 1) define new class and my change move. (ex: MessagePackUnpacker.*)
> 2) define on MessagePackParser (my original idea)
>
> Streaming deserialization function is standard function of messagepack.
> Therefore, I think that it is very natural.
>
> Do you have any idea ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/msgpack/msgpack-objectivec/pull/2/files#r2684173>.
>
>