Unreviewed EFL gardening.

Unskip tests added to platform/efl/Skipped, which now are passing.

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CSS Masking/Background] Position property should be ignored when using repeat: space
https://bugs.webkit.org/show_bug.cgi?id=120623

Source/WebCore:

The background/mask-position should be ignored when using repeat: space,
unless there is not enough space for two copies of the image. In that case,
only one image is placed and background/mask-position determines its position.

Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
Reviewed by Dirk Schulze.

Test: css3/masking/mask-repeat-one-copy.html

* rendering/RenderBoxModelObject.cpp: Ignored position property if space value is positive, set no-repeat otherwise.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

LayoutTests:

Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-19
Reviewed by Dirk Schulze.

* css3/masking/mask-repeat-one-copy-expected.html:
* css3/masking/mask-repeat-one-copy.html: Only one copy of the mask should be drawn, and background position should determine its position.
* css3/masking/mask-repeat-space-padding.html: Added a mask-position which should be ignored.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Fix typo in layout test description introduced in r155974.

* fast/regions/selection-direction-expected.html:
* fast/regions/selection-direction.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r149928): CanvasStyle::operator= leaks everything
https://bugs.webkit.org/show_bug.cgi?id=121591

Reviewed by Andreas Kling.

* html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::operator=): Don't leak.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
https://bugs.webkit.org/show_bug.cgi?id=121588

Reviewed by Anders Carlsson.

* DumpRenderTree/TestRunner.cpp:
* ImageDiff/efl/ImageDiff.cpp:
* TestWebKitAPI/JavaScriptTest.cpp:
* TestWebKitAPI/PlatformUtilities.cpp:
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
* WebKitTestRunner/StringFunctions.h:
* WebKitTestRunner/TestInvocation.cpp:
* WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Keep chasing the definition of QAccessibleWidget
https://bugs.webkit.org/show_bug.cgi?id=121611

Reviewed by Jocelyn Turcotte.

* WidgetApi/qwebviewaccessible_p.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121608

Reviewed by Dave Hyatt.

Add a common base class for all Element renderers. The class hierarchy will now look like this
        
RenderObject
    RenderText
    RenderElement
        RenderLayerModelObject
            ...
        RenderSVGModelObject
            ...
        RenderSVGGradientStop
                
This will allow tighter typing in both render and DOM trees.
        
The patch also moves renderer factory function to RenderElement::createFor().



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add XHR tests checking readyState transition when abort() is invoked in various states
https://bugs.webkit.org/show_bug.cgi?id=121585

Reviewed by Alexey Proskuryakov.

Merge https://chromium.googlesource.com/chromium/blink/+/2d854757576db590745cfb78e11ca428a1aac342

* http/tests/xmlhttprequest/readystatechange-and-abort-expected.txt: Added.
* http/tests/xmlhttprequest/readystatechange-and-abort.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
DoYouEvenBench: Indentations in benchmark.js and benchmark.html are all messed up
https://bugs.webkit.org/show_bug.cgi?id=121597

Reviewed by Anders Carlsson.

Fixed indentations.

* DoYouEvenBench/benchmark.html:
* DoYouEvenBench/benchmark.js:
(SimplePromise.prototype.resolve.else):
(SimplePromise.prototype.resolve):
(BenchmarkRunner.waitForElement.resolveIfReady):
(BenchmarkRunner.waitForElement):
(BenchmarkRunner._waitAndWarmUp.Fibonacci):
(BenchmarkRunner._finalize):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add a style guideline regarding spacing in range-based for loops
https://bugs.webkit.org/show_bug.cgi?id=121620

Reviewed by Anders Carlsson.

Tools: 

* Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing): Added checking that there are spaces around the colon in a range-based for
loop.
(CppChecker): Added whitespace/colon to the categories set.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_spacing): Added two tests for the new check.

Websites/webkit.org: 

* coding/coding-style.html: Added the guideline that spaces should be placed
around the colon in a range-based for loop.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix handling of top margin on float with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=121614

Reviewed by Alexandru Chiculita.

Source/WebCore:

When a float has shape outside, the top margin should be treated as if
there is no shape there, so inline content should be allowed to flow
into that space. This patch fixes two issues:

1) If the top margin is the same as the line height, a line should be
able to fit into the margin. Before this patch, that line was being
treated as if it intersected with the shape.

2) The shape should be positioned (x, y) relative to the box sizing
box of the float. While the x coordinate was being treated properly,
the y coordinate was relative to the top of the margin box. This patch
fixes this behavior.

This patch also includes a simple test for right and left margins, as
I wrote that test and then discovered the problems listed above.

This patch also removes an unused override of the
lineOverlapsShapeBounds method.

Tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html
       csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html

* rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):
* rendering/LineWidth.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
* rendering/shapes/ShapeInfo.h:
* rendering/shapes/ShapeInsideInfo.h:
* rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::computeSegmentsForContainingBlockLine):
* rendering/shapes/ShapeOutsideInfo.h:

LayoutTests:

* csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-000.html: Added.
    Test for a positive left/right margin.

* csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001-expected.html: Added.
* csswg/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Added.
    Test for a positive top margin.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CSS Shapes] Fix starting html tag and doctype for shape-inside floats tests
https://bugs.webkit.org/show_bug.cgi?id=121621

Reviewed by Andreas Kling.

* fast/shapes/shape-inside/shape-inside-left-float-in-lower-left-triangle-inline-content-expected.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content-expected.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-lower-right-triangle-inline-content.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content-expected.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-inline-content.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content-expected.html:
* fast/shapes/shape-inside/shape-inside-left-float-in-upper-right-triangle-inline-content.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
MediaStream API: update NavigatorUserMediaError object to match spec
https://bugs.webkit.org/show_bug.cgi?id=121584

Reviewed by Dean Jackson.

Source/WebCore: 

No new tests, updated getusermedia.html.

* CMakeLists.txt: Add NavigatorUserMediaError.cpp.
* GNUmakefile.list.am: Ditto.

* Modules/mediastream/NavigatorUserMediaError.cpp: Added.
* Modules/mediastream/NavigatorUserMediaError.h: Derive from DOMError, get rid of "message" attribute.
* Modules/mediastream/NavigatorUserMediaError.idl: Ditto.

* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::create): ASCIILiteral -> AtomicString. Rename constraint parameters.
(WebCore::UserMediaRequest::UserMediaRequest): Rename constraint parameters.
(WebCore::UserMediaRequest::audioConstraints): Return PassRefPtr<> instead of raw ptr.
(WebCore::UserMediaRequest::videoConstraints): Ditto.
(WebCore::UserMediaRequest::ownerDocument): Clean up style.
(WebCore::UserMediaRequest::succeed): 
(WebCore::UserMediaRequest::permissionFailure): Renamed from fail.
(WebCore::UserMediaRequest::constraintFailure):  Renamed from failConstraint.
(WebCore::UserMediaRequest::callSuccessHandler): New.
(WebCore::UserMediaRequest::callErrorHandler): New.
* Modules/mediastream/UserMediaRequest.h:

* WebCore.xcodeproj/project.pbxproj: Add NavigatorUserMediaError.cpp

* dom/DOMError.h: Make constructor protected.

* platform/mediastream/MediaStreamSourcesQueryClient.h: Make constraints available.

LayoutTests: 

* fast/mediastream/getusermedia-expected.txt:
* fast/mediastream/getusermedia.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r129451): run-safari --no-saved-state is broken
https://bugs.webkit.org/show_bug.cgi?id=121566

Undo a last minute change that doesn't actually work.

* Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
via command line, <rdar://problem/15032886>.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add SVGPropertyInfo.cpp
<https://webkit.org/b/121622>

Reviewed by Anders Carlsson.

Add a cpp file for this class to make it more hackable.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* svg/properties/SVGPropertyInfo.cpp: Added.
(WebCore::SVGPropertyInfo::SVGPropertyInfo):
* svg/properties/SVGPropertyInfo.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
JSC: X86 disassembler shows 16, 32 and 64 bit displacements as unsigned
https://bugs.webkit.org/show_bug.cgi?id=121625

Rubber-stamped by Filip Pizlo.

Chenged 16, 32 and 64 bit offsets to be signed.  Kept the original tab indented
spacing to match the rest of the file.

* disassembler/udis86/udis86_syn-att.c:
(gen_operand):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()

Rubber-stamped by Joseph Pecoraro.

Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
noreturn warning in Clang while simultaneously asserting unreachable code.

* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_mod):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[iOS] Substitute UNREACHABLE_FOR_PLATFORM() for RELEASE_ASSERT_NOT_REACHED()

Rubber-stamped by Joseph Pecoraro.

Use UNREACHABLE_FOR_PLATFORM() instead of RELEASE_ASSERT_NOT_REACHED() in
the non-x86/x86-64 variant of JIT::emitSlow_op_mod() so as to avoid a missing
noreturn warning in Clang while simultaneously asserting unreachable code.

* jit/JITArithmetic.cpp:
(JSC::JIT::emitSlow_op_mod):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Removed WebCoreSQLite3. It has been unused for years.

Rubber-stamped by Mark Rowe.

* WebCoreSQLite3: Removed.
* WebCoreSQLite3/sqlite3.h: Removed.
* WebCoreSQLite3/sqlite3ext.h: Removed.
* libWebCoreSQLite3.a: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Attempted build fix after r156114.

* Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156115 268f45cc-cd09-0410-ab3c-d52691b4dbfc