merge with attr code