let it not be said that I drive the other way when there is a way we roll.
will change, and adopt convention.


On 29 November 2013 09:12, Paul Blundell <notifications@github.com> wrote:

> In core/src/main/java/com/novoda/imageloader/core/LoaderSettings.java:
>
> > -        this.setExpirationPeriod(DEFAULT_EXPIRATION_PERIOD);
> > -        this.setQueryIncludedInHash(DEFAULT_INCLUDE_QUERY_IN_HASH);
> > -        this.setConnectionTimeout(DEFAULT_CONNECTION_TIMEOUT);
> > -        this.setReadTimeout(DEFAULT_READ_TIMEOUT);
> > -        this.setDisconnectOnEveryCall(DEFAULT_DISCONNECT_ON_EVERY_CALL);
> > -        this.setUseAsyncTasks(DEFAULT_USE_ASYNC_TASKS);
> > -        this.setAllowUpsampling(DEFAULT_ALLOW_UPSAMPLING);
> > -        this.setAlwaysUseOriginalSize(DEFAULT_ALWAYS_USE_ORIGINAL_SIZE);
> > +        bitmapUtil = new BitmapUtil();
> > +        headers = new HashMap<String, String>();
> > +
> > +        expirationPeriodInMillis = DEFAULT_EXPIRATION_PERIOD;
> > +        readTimeout = DEFAULT_READ_TIMEOUT;
> > +        connectionTimeout = DEFAULT_CONNECTION_TIMEOUT;
> > +
> > +        shouldIncludeQueryInHash = DEFAULT_INCLUDE_QUERY_IN_HASH;
>
> I'll give you a clue, every class I have seen so far, in the constructor
> the unwritten rule is to use this. . In other random places excepts
> setters with same var names, it is not
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/novoda/ImageLoader/pull/148/files#r7997436>
> .
>