client.shared.utils_cgroup: Don't fail when cgclear fails

When system utils run under cgroups the cgclear command might fail.
Anyway the test is usually not affected by this so we can just notify
user via logging.WARN and proceed with testing.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
client.shared.utils_cgroup: Remove tailing '/' from cgroup root dir

Originally the root_dir was used directly, thus '/' was appended on init
time. The latest cgroup utils changed this behavior and append the
trailing '/' directly in the functions. Follow this behavior and don't
append this '/' in init time to synchronize those behaviors.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
tools: add tool for pep8 reformatting

This calls the PEP8 linter called autopep8:

https://github.com/hhatto/autopep8

So we can make autotest to fully adhere to PEP8,
since there's a tool that can enforce the standard.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
Signed-off-by: yangdongsheng <yangds.fnst@cn.fujitsu.com>
tools: add pep8 check into check_patch

Integrate the PEP8 linter into the virt-test full
tree and patch verification process. It works by
verifying whether the PEP8 linter modified the file in
place, if it did, it means there are non compliances
in the code.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
Signed-off-by: yangdongsheng <yangds.fnst@cn.fujitsu.com>
tools: Add codespell

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
tools: Sync PEP8 and check_patch scripts with virt-test

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
PEP8 mass fixes

With the help of the PEP8 script, a semi-automated clean
of the code base was made, and effectively changing some
of the coding style rules of our code base:

 * No more 2 lines spacing among functions
 * No more combined module imports

In the end, it was going to be too difficult to take
into consideration E501 (line length > 80) errors and
W601 (.has_key() is deprecated), so these were ignored,
at least for now.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
Mass docstring fix

Make virt-test to have a docstring style mostly compliant with
the sphinx's [1] format, reStructured text. This means that
we have to trade all '@' tags to be ':', mostly.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
unittests: Fixing broken unittests with latest refactors

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
CODING_STYLE: Update document reflecting the move to PEP8

While our base coding style was already PEP8, we had some
differences, such as 2 lines separating functions, and
single line imports. This made hard to automatically
enforce coding style rules other than review.

Given the incentives to move closer to the PEP8, we
decided to go forward with the plan, so the coding
style document has to be updated accordingly.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
More docstring fixes

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
utils/check_patch.py: Fix incorrect variable reference

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
frontend/pkgdeps.py: Remove gnuplot dependency

With tko no longer around, gnuplot is not
necessary anymore, so remove it from the list
of dependencies.

Signed-off-by: Rudá Moura <rmoura@redhat.com>
Merge pull request #733 from ldoktor/framework

client.shared.utils_cgoup: Two little modifications in utils_cgroup
client/TODO: remove old (really old) file

This is a very old text file with historical notes. I just can't
believe it went unoticed for so long.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
client.shared.iscsi: Update iscsi.py

Include some coding style update and one bug fix for ignoring status for
some query command.

Signed-off-by: Yiqiao Pu <ypu@redhat.com>
Updating to the latest autotest-client-tests

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
frontend.pkgdeps: Adding python-psutil to the list of required packages

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
utils.external_packages: Add python-psutil build info

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
frontend.afe.rpc_interface: Add get_server_status() method

In order to display a dashboard of the autotest server
status, we need to know some things:

 1) Free disk space in the autotest results directory
 2) Whether the autotest scheduler and the scheduler
    monitor are up

So use the very nice, 3rd party python module psutil:

https://code.google.com/p/psutil/

To inspect system information and return it through
the RPC call interface.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>