remove unnecessary lib/sis requires

We were inconsistent about whether to require
'lib/sis/csv/base_importer' or 'sis/csv/base_importer', causing warnings
in the logs about already initialized constants (not to mention
evaluating the same file twice, though that seems to be ok in this
case).

rather than fix the requires to be consistent, i've just removed them,
as rails autoloading works for all but the sis/common require (doesn't
work for sis/common because that defines things other than a SIS::Common
module)

test plan: doing SIS imports should still work as normal, and you
shouldn't see any warnings in the logs about already defined constant
PARSE_ARGS

Change-Id: I787ee7486d967201bfb360bc95e61e48b385c449
Reviewed-on: https://gerrit.instructure.com/19190
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Clare Hetherington <clare@instructure.com>
Product-Review: Brian Palmer <brianp@instructure.com>
spec: calendar2 fixes for clicking calendar entry.

Change-Id: I88145b7dadf8731b08a10be7a1c7c3cec561a9eb
Reviewed-on: https://gerrit.instructure.com/19279
Reviewed-by: Bryan Madsen <bryan@instructure.com>
Product-Review: Bryan Madsen <bryan@instructure.com>
QA-Review: Bryan Madsen <bryan@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
remove :include => { :exclude } support in favor of except(:includes)

refs CNVS-4705

Change-Id: I579c25d536a5154be3978398ef8b938b0876ca68
Reviewed-on: https://gerrit.instructure.com/18683
QA-Review: Cody Cutrer <cody@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
Product-Review: Cody Cutrer <cody@instructure.com>
multiple due date summary tooltip

Notes:
* On index pages, assignments and quizzes with multiple due dates
  now show a summary of due dates in a tooltip when hovering over
  "Multiple Due Dates"
* The tooltip shows a max of 10 dates, and if there are more, it
  ends with "and # more..." showing how many dates are not shown
* The ticket requested that the "and # more..." links to the
  assignment page, but that would be hard to click since leaving
  the anchor link makes the hover disappear; instead the actual
  "Multiple Due Dates" anchor link will link to the show page
* Tooltip appears for teachers on the following pages:
  - Global assignments page
  - Course assignments page
  - Course quizzes page
  - Course modules page

Test Plan:
* Create assignments and quizzes with multiple due dates
* Navigate to the pages above and verify that there are tooltips for
  items with multiple due dates
* Verify that the section names and dates are correct for each item
* Verify that when there are more than 10 due dates, the tooltip only
  shows 10 dates and ends with "and x more..." with the number of
  dates not shown

fixes CNVS-2646

Change-Id: I96d12b25d6690393c942c90b8e121da6e20191e0
Reviewed-on: https://gerrit.instructure.com/18769
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Amber Taniuchi <amber@instructure.com>
Product-Review: Simon Williams <simon@instructure.com>
Reviewed-by: Stanley Stuart <stanley@instructure.com>
switch position of save profile and cancel buttons when editing user profile

Test plan:

Go to a users Profile page > Edit Profile >  Save Profile button is now on right

Change-Id: I82b95d1fd3783de6b29b9fbbfecfb43029366d4d
Reviewed-on: https://gerrit.instructure.com/18897
Reviewed-by: Stanley Stuart <stanley@instructure.com>
QA-Review: Cam Theriault <cam@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
Product-Review: Stanley Stuart <stanley@instructure.com>
refactor disableWhileLoadings that don't resolve

make it a little easier to have a form spinner that doesn't go away on
success (e.g. if you are going to change location.href or something)

test plan:
1. /register should still work
2. the self enrollment form should still work

Change-Id: I0040a64ecadea2bae2899364ef820df3d2bc62c0
Reviewed-on: https://gerrit.instructure.com/19270
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
errorFormatter support for formSubmit

just a refactor to make the password policy commit more DRY

test plan:
1. ensure that /register works and error messages show up appropriately

Change-Id: I0eea8c4107fa9ae69d45941f45edd5a9621ee3c8
Reviewed-on: https://gerrit.instructure.com/19271
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
Product-Review: Jon Jensen <jon@instructure.com>
QA-Review: Jon Jensen <jon@instructure.com>
upgrade nokogiri and libxml-ruby

delayed job workers segfault often when using libxml2 and ruby 1.9

these issues are not present when using version 2.9.0 of libxml2,
however, newer versions of nokogiri and libxml-ruby are required in
order to compile against the newer libxml2

fixes #CNVS-4669

Change-Id: I5100ba6e0f4779da49bce471cff03cb83b3c06b2
Reviewed-on: https://gerrit.instructure.com/18658
Tested-by: Jenkins <jenkins@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>
switch mathjax cdn to https

test plan:
* make sure that the advanced math editor works
when using https

fixes #CNVS-5061

Change-Id: I99e173574897498086b000b505262bb67fa2135a
Reviewed-on: https://gerrit.instructure.com/19299
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
Product-Review: Bracken Mosbacker <bracken@instructure.com>
Tested-by: Jenkins <jenkins@instructure.com>
QA-Review: Adam Phillipps <adam@instructure.com>