Add flavor-manage to core for V3 API

Adds the flavor-manage plugin to the core list for the V3 API.
This is part of the process of adding all of the flavor related
extensions to core, with the exception of rxtx, as per the discussion
here: https://etherpad.openstack.org/p/NovaV3APICore

Partially implements blueprint nova-v3-api

DocImpact

Change-Id: Idbedce5cc5936abc52235cd40573c8fe841f24fe
Nova-all: Replace basestring by six for python3 compatability

The builtin basestring abstract type was removed in python3,
use str instead, we need to using six.string_types to replace
the basestring for py3 compatibility.

Partial Implements bp: basestring-py3-compatible

Change-Id: I17e87e49e7ebf3cc9c391e9beace8c45d2d2b689
Drop auth_token configs for api-paste.ini.

We now prefer to use nova.conf to configure keystoneclients
auth_token configs.

Also, Devstack has now been update to allow this:

  https://review.openstack.org/#/c/52258/

Change-Id: I2a4b300af37eddf5010b97ca796f0552941642a8
VMware: Detach volume should not delete vmdk

During volume detach a delete_virtual_disk_spec is used to remove
the device from the running instance. This spec also "destroy" the
underlying vmdk file, this is not right, we should not delete vmdk
file when detach it from a VM instance.

The fix was remove the fileOperation field when detach vmdk volume
so as to make sure the volume will not be destroyed; but for iscsi
we still need to destroy the volume.

Also I changed the function name from delete_virtual_disk_spec to
detach_virtual_disk_spec which is more accurate.

Change-Id: Ibd218d6a8cfeede4f5ca74f28bc0c3d0c185bb14
Closes-Bug: #1241350
Rename virtapi.instance_type_get to flavor_get

Renames the virtapi.instance_type_get method to flavor_get. Updates the
directly related tests and subclass implementations of VirtAPI.

This patch does not propagate to all related code like conductor API,
that will be handled in a later patch for the blueprint.

Part of bp flavor-instance-type-dedup

Change-Id: Ic47da9aa578d449a4ce542d2d017840f1a8132a7
More instance_type -> flavor renames in db.api

Renames the instance_type methods in db.api to flavor and converts the
tests to match. Updates doc strings where needed.

Note that this patch doesn't rename anything touching the db models for
instance types, that will be handled in a later patch for the blueprint.

Part of bp flavor-instance-type-dedup

Change-Id: I397421c9b34d295368999c5d085345409945151a
Cache Neutron Client for Admin Scenarios

Store a thread local copy of Neutron client for use with admin
tokens, this will prevent excessive calls to keystone to mint
new tokens and will enable reuse of the already set up client
for subsequent calls in this thread.

Change-Id: I6346281ca3516c31b195ce71942786d724e5e9df
Closes-Bug: #1250580
replace assertNotEquals with assertNotEqual

assertNotEquals will be deprecated in Python 3.

This is part of blueprint assertequal

Closes loose ends with assertEquals.

Change-Id: I5cd5c8ceb8b0232f1218d6f445d230c8747ac327
Raising exception for invalid floating_ip's ID

The proposal is to validate the ID from the request to check
whether it is is valid for nova-network driver.
If the network driver is nova-network, the ID should be numeric.

Change-Id: I10df4f9ba2f5cfec7a6d2112cf5905944a9b5419
Closes-bug: #1078055
Merge "Rename virtapi.instance_type_get to flavor_get"
Merge "replace assertNotEquals with assertNotEqual"
Merge "Cache Neutron Client for Admin Scenarios"
Merge "Add flavor-manage to core for V3 API"
Merge "More instance_type -> flavor renames in db.api"
Merge "Raising exception for invalid floating_ip's ID"
Merge "Nova-all: Replace basestring by six for python3 compatability"
Merge "VMware: Detach volume should not delete vmdk"
Merge "Drop auth_token configs for api-paste.ini."