mon: AuthMonitor: remove dead code

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
mon: AuthMonitor: fix whitespaces

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
mon: AuthMonitor: fix some >80 columns debug strings

Give AuthMonitor a new look.  She sure deserves it.

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
mon/MonCap: remove useless 'osd crush add' perm from profile bootstrap-osd

Bootstrap doesn't use or need this; the crush update happens when the osd
starts up (see init-ceph or upstart/ceph-osd.conf).

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Joao Eduardo Luis <joao.luis@inktank.com>
mon: clarify 'osd crush add' vs 'osd crush set'

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Joao Eduardo Luis <joao.luis@inktank.com>
mon: OSDMonitor: don't expose uncommitted state on 'osd crush link'

Fixes: #4635

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Joao Eduardo Luis <joao.luis@inktank.com>
mon: OSDMonitor: document 'prepare_command' wrt expected behavior of no-ops

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
mon: OSDMonitor: don't expose uncommitted state on 'osd crush add/set'

Fixes: #4635

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
vstart.sh: s/osd crush set/osd crush add/ as it's supposed to be

'osd crush set' should only be used to update already existing items on
the map whereas 'osd crush add' should be able to 'add and update' items.

Considering at that point we are effectively adding a new item to the
crush map, use 'add' instead of 'set'.

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
PendingReleaseNotes: reflect 'osd crush set' behavior change

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Merge pull request #507 from ceph/wip-4635.master

Bunch of tidying up on monitor services & fix #4635

Reviewed-by: Sage Weil <sage@inktank.com>