On 09/06/2013 05:15 PM, Joseph Hall wrote:
>
> In salt/states/alternatives.py:
>
> > +
> > +def set(name, path):
> > +    '''
> > +    Removes installed alternative for defined <name> and <path>
> > +    or fallback to default alternative, if some defined before.
> > +
> > +    name
> > +        is the master name for this link group
> > +        (e.g. pager)
> > +
> > +    path
> > +        is the location of one of the alternative target files.
> > +        (e.g. /usr/bin/less)
> > +    '''
> > +    ret = {'name': name,
> > +           'path': path,
>
> Wait, why are you returning path? It's okay to pass it in, but I don't 
> think it's okay to return it.
>
>

Mainly, because the function above it does. If you look, install() and 
remove() in that module return their parameters, also.  I thought that 
was a convention. :-)