my first commit for my function