No, expandweights4 does not compile the way it is. I did have to change its
syntax as per the new syntax. And I understand your point now.


On Wed, Aug 28, 2013 at 12:29 PM, Olly Betts <notifications@github.com>wrote:

> In xapian-core/include/xapian/enquire.h:
>
> > @@ -1040,11 +1052,10 @@ class XAPIAN_VISIBILITY_DEFAULT Enquire {
> >  	 *  @exception Xapian::InvalidArgumentError  See class documentation.
> >  	 */
> >  	ESet get_eset(Xapian::termcount maxitems,
> > -			const RSet & omrset,
> > -			int flags = 0,
> > -			double k = 1.0,
> > -			const Xapian::ExpandDecider * edecider = 0,
> > -			double min_wt = 0.0) const;
> > +		      const RSet & omrset,
> > +		      int flags = 0,
> > +		      const Xapian::ExpandDecider * edecider = 0,
> > +		      double min_wt = 0.0) const;
>
> Hmm, I'm surprised if expandweights4 still compiles. I don't have your
> source tree checked out on this machine, so I can't easily check myself
> right now. Are you sure you rebuilt apitest after making this change?
>
> I'm suggesting we change the method as you have above, but we also add an
> overload for it with the old signature, which we mark using
> XAPIAN_DEPRECATED (so code which uses it will compile but give a warning
> that it's using a deprecated API feature). This compatibility method should
> actually work, or else we're silently breaking existing code which uses it
> i.e. it should probably take expand_k and call set_expansion_scheme("trad",
> expand_k).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xapian/xapian/pull/24/files#r6026749>
> .
>