Look at the code climate rate, it sums up how 'easy' it is to understand.


On 24 déc. 2013, at 13:23, Michael Klishin <notifications@github.com> wrote:

> In lib/hutch/broker.rb:
> 
> >      end
> >  
> >      def publish(routing_key, message, properties = {})
> > -      payload = JSON.dump(message)
> > +      handler = ::Hutch::BrokerHandlers::Publish.new({
> OK, introduction of handlers here makes the method harder to comprehend, not easier. #publish is very straightforward in nature,
> even though we have a bit of logic around property merging. I don't think we need to introduce handlers: this is not a sophisticated
> framework that is supposed to be heavily extended (e.g. Rails), Hutch is supposed to be opinionated and provide a smaller core API than
> Bunny.
> 
> —
> Reply to this email directly or view it on GitHub.