$base is the base uri of the fileset while base-uri(.) would be the base
uri of the d:file. They are both the same. I had hoped it would result in
some performance gain for huge filesets. px:fileset-filter was (and
probably still is) the main performance drag on px:mediatype-detect which
actually crashes (runs out of heap space) if you give it a large enough
fileset (more than about 1000).

I can change it back if you want.

Jostein


On 14 February 2013 10:53, Romain Deltour <notifications@github.com> wrote:

> In fileset-utils/src/main/resources/xml/xproc/fileset-filter.xpl:
>
> >
> > +    <p:choose>
> > +        <p:when test="$href=''">
> > +            <p:identity/>
> > +        </p:when>
> > +        <p:otherwise>
> > +            <p:delete>
> > +                <p:with-option name="match" select="concat(&quot;//d:file[not(resolve-uri(@href,'&quot;,$base,&quot;')=resolve-uri('&quot;,$resolved-href,&quot;'))]&quot;)"/>
>
> why resolving the d:file/@href <https://github.com/href> with $base here
> ? wouldn't it be more correct to delete:
>
> //d:file[not(resolve-uri(@href <https://github.com/href>
> ,base-uri(.))=$resolve-href)]
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/daisy-consortium/pipeline-modules-common/pull/1/files#r3010394>.
>
>