COMP: Fix unused variable warnings in vtkSlicerCLIModuleLogic

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22391 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: Fix unused variable warnings in vtkMRMLMarkupsStorageNode

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22392 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: Fix "sign-compare" warning in vtkSlicerMarkupsLogic

vtkSlicerMarkupsLogic.cxx: In member function ‘void vtkSlicerMarkupsLogic::ConvertAnnotationFiducialsToMarkups()’:
vtkSlicerMarkupsLogic.cxx:882: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
vtkSlicerMarkupsLogic.cxx:954: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22393 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix crash preventing the same color file to be loaded more than once

As the documentation associated "AddNode" method explains, in the case
of singleton node, the return node should be considered instead of the
one passed to the method.

AddNode documentation:

/// [...]
/// If node is a singleton, and a node of the same class with the
/// same singleton tag already exists in the scene, \a nodeToAdd is NOT
/// added but its properties are copied (c.f. vtkMRMLNode::CopyWithScene())
/// into the already existing singleton node. That node is then returned.

Fixes #2989

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22394 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Prevent crash when attempting to save a *.mrb in a readonly folder.

Fixes #3242

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22395 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: fix loading of double array files

The file extension didn't match that in the double array storage node.

Fixes issue #3289



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22396 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fixes py_NeurosurgicalPlanningTutorial test

Beside of memory leak and error related to the glyphing pipeline (captured
by issue #3349).
The script can be successfully replayed within Slicer or if executed
using CTest with a Slicer build without leak detection.

// ---------------------------
Errors:

565: ERROR: In /home/jchris/Projects/Slicer-AHM-Superbuild-Release/VTK/Filtering/vtkDemandDrivenPipeline.cxx, line 727
565: vtkStreamingDemandDrivenPipeline (0x957b600): Input port 0 of algorithm vtkExtractSelectedPolyDataIds(0x957b370) has 0 connections but is not optional.
565:
565:
565: ERROR: In /home/jchris/Projects/Slicer-AHM/Libs/vtkTeem/vtkDiffusionTensorGlyph.cxx, line 222
565: vtkDiffusionTensorGlyph (0xcd1db10): No data to glyph!
// ---------------------------

// ---------------------------
Leaks:

565: vtkDebugLeaks has detected LEAKS!
565: Class "vtkSynchronizedTemplatesCutter3D" has 21 instances still around.
565: Class "vtkTransformPolyDataFilter" has 21 instances still around.
565: Class "vtkInformationVector" has 441 instances still around.
565: Class "vtkMatrix4x4" has 42 instances still around.
565: Class "vtkCoordinate" has 42 instances still around.
565: Class "vtkPlane" has 21 instances still around.
565: Class "vtkInformation" has 525 instances still around.
565: Class "vtkSynchronizedTemplates3D" has 21 instances still around.
565: Class "vtkActor2D" has 21 instances still around.
565: Class "vtkRectilinearSynchronizedTemplates" has 21 instances still around.
565: Class "vtkDoubleArray" has 105 instances still around.
565: Class "vtkAlgorithmOutput" has 21 instances still around.
565: Class "vtkInformationIntegerValue" has 378 instances still around.
565: Class "vtkOpenGLPolyDataMapper2D" has 21 instances still around.
565: Class "vtkGridSynchronizedTemplates3D" has 21 instances still around.
565: Class "vtkCutter" has 21 instances still around.
565: Class "vtkInformationExecutivePortVectorValue" has 21 instances still around.
565: Class "vtkContourValues" has 105 instances still around.
565: Class "vtkTransform" has 21 instances still around.
565: Class "vtkStreamingDemandDrivenPipeline" has 42 instances still around.
565: Class "vtkTimerLog" has 21 instances still around.
565: Class "vtkInformationExecutivePortValue" has 21 instances still around.

// ---------------------------

Fixes #2808

Co-authored-by: Jean-Christophe Fillion-Robin <JChris.FillionR@kitware.com>

From: Chrystel Juan <chrystel.juan@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22397 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: fix issues causing inability to import multi-frame data from individual non-DICOM files, attempt to fix 3299


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22398 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: fix failing test

Fix the write CLI test for the markpus node by adjusting the expected number
of arguments to be 2 times the number of points, as the flag is written
separately now.

Related to fixes for issue #1910


git-svn-id: http://svn.slicer.org/Slicer4/trunk@22399 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Disable AutoRestart to workaround issue #2535

Instead of asking the user if he would like to restart, he is asked
if he would like to exit Slicer and manually restart.

The restart confirm dialog is associated with the
settings key "MainWindow/DontConfirmExit"

See #2535

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22400 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix logic checking for readonly folder in writeToMRB method

Following r22395 "qSlicerSceneWriter::writeToMRB" has been updated to
check is the MRB file to be written was writable or not, the test was
always failing since the file itself wasn't existing.

This commit implement the appropriate logic by checking if the destination
folder where the MRB should be saved is writable.

This commit also fix the test "test_slicer_util_save.test_saveSceneAsMRB"

See #3242

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22401 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: Fix unused variable warnings

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22402 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix loading of ".mgh.gz" file in py_nomainwindow_test_slicer_mgh

Method "IsCompressedFilename" has been copied from the improved fork
of MGHImageIO maintained by ITK folks (Hans).
See https://github.com/Slicer/itkMGHImageIO

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22403 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Fix "py_nomainwindow_test_slicer_mgh" allowing "mgh" to be saved

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22404 3bd1e089-480b-0410-8dfb-8563597acbee
BUG: Add ".mgh.gz" to the list of FreeSurferModelOverlay read file types.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22405 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: Exclude html extension from git hook line lengths check

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22406 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: Update Documentation to 4.3

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22407 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: Slicer 4.3.0

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22408 3bd1e089-480b-0410-8dfb-8563597acbee
ENH: Begin post-4.3.0 development

git-svn-id: http://svn.slicer.org/Slicer4/trunk@22409 3bd1e089-480b-0410-8dfb-8563597acbee
COMP: fix compiling in debug mode

A variable was removed to fix a release mode unused variable warning,
in svn 22402, remove it from the vtkDebugMacro.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@22410 3bd1e089-480b-0410-8dfb-8563597acbee