Cool. I added the StringAnalysisFunction and StringAnalysisComponent and
modified the extenders of those. I need to focus on other things for the
meantime, but feel free to do the StringSlab bit if you get a chance!

-Jason


On Mon, Jul 22, 2013 at 10:05 AM, bethard <notifications@github.com> wrote:

> In src/main/scala/chalk/slab/AnalysisFunction.scala:
>
> > @@ -19,30 +19,41 @@ object StringIdentityAnalyzer extends AnalysisFunction[String, StringAnnotation,
> >  /**
> >    * A simple regex sentence segmenter.
> >    */
> > -trait SentenceSegmenter extends AnalysisFunction[String, StringAnnotation, StringAnnotation, Sentence] {
> > -  def apply(slab: Slab[String, StringAnnotation, StringAnnotation]) =
> > -    slab ++ "[^\\s.!?]+[^.!?]+[.!?]".r.findAllMatchIn(slab.content).map(m => Sentence(m.start, m.end))
> > +trait SentenceSegmenter[I <: StringAnnotation] extends AnalysisFunction[String, StringAnnotation, I, Sentence] {
>
> Yeah, I agree we should add StringSlab and StringAnalysisFunction. That
> should at least get us down to just the input and output types.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scalanlp/chalk/pull/20/files#r5320845>
> .
>



-- 
Jason Baldridge
Associate Professor, Dept. of Linguistics, UT Austin
Co-founder & Chief Scientist, People Pattern
http://www.jasonbaldridge.com
http://twitter.com/jasonbaldridge