Lower Complexity of UsersController
https://codeclimate.com/github/discourse/discourse/UsersController#method-complexity
Added test case for nickname registration failure

* Also made a minor readability change by moving the auth.present? check
* from UsersController#create into #create_third_party_auth_records
* which is the method that relies on the check.
No more rails 4 deprecation warnings
add max_image_height site setting
Merge pull request #1382 from novemberkilo/master

No more rails 4 deprecation warnings
Merge pull request #1383 from ZogStriP/add-max-image-height-site-setting

add max_image_height site setting
Merge pull request #1381 from einarj/test_nickname_hub_registration_failure

Added test case for nickname registration failure
Merge pull request #1378 from justin808/justin808_cc

Lower Complexity of UsersController
minor style change
store honeypot challenge in redis for extra security
major refactor of auth, break up the gigantic omniauth controller into sub classes for way better extensibitily
twitter and facebook are broken unless configure, so default off please
refactoring the plugin interfaces to allow for better extensible
fix open id so it creates records properly
work in progress, get specs to work.
slowly going about ordering our middleware
Fixed all broken specs
Moved middleware config into authenticators
PluginStore for plugin specific bits of storage
Amended plugin interfaces so they work with the vk sample
yeah ... we should be installing the gem :)
correct spec