minor comments about the tests and impl