That makes sense. I have added the explicit "else" statement to all the methods.

Le 20 sept. 2013 à 18:41, declaresub <notifications@github.com> a écrit :

> In macoslib/Cocoa/NSFileManager.rbbas:
> 
> > @@ -0,0 +1,254 @@
> > +#tag Class
> > +Class NSFileManager
> > +Inherits NSObject
> > +	#tag Method, Flags = &h0
> > +		Function ContentsAtPath(path as String) As NSData
> > +		  //# Reads the contents of the file located at ''path''.
> > +		  
> > +		  #if TargetMacOS
> > +		    declare function contentsAtPath lib FoundationLib selector "contentsAtPath:" (id as Ptr, path as CFStringRef) as Ptr
> > +		    declare function stringByExpandingTildeInPath lib CocoaLib selector "stringByExpandingTildeInPath" (path as CFStringRef) as CFStringRef
> > +		    
> > +		    dim p as Ptr = contentsAtPath( self, path )
> > +		    
> > +		    if p<>nil then
> On Sep 20, 2013, at 12:33 PM, Smons <notifications@github.com> wrote: In macoslib/Cocoa/NSFileManager.rbbas: > @@ -0,0 +1,254 @@ > +#tag Class > +Class NSFileManager > +Inherits NSObject > +	#tag Method, Flags = &h0 > +	 Function ContentsAtPath(path as String) As NSData > +	 //# Reads the contents of the file located at ''path''. > + > +	 #if TargetMacOS > +	 declare function contentsAtPath lib FoundationLib selector "contentsAtPath:" (id as Ptr, path as CFStringRef) as Ptr > +	 declare function stringByExpandingTildeInPath lib CocoaLib selector "stringByExpandingTildeInPath" (path as CFStringRef) as CFStringRef > + > +	 dim p as Ptr = contentsAtPath( self, path ) > + > +	 if p<>nil then I have skipped it because it is unnecessary code. Do you want me to implement it anyway ? Le 20 sept. 2013 à 16:38, declaresub <notifications@github.com> a écrit : … — Reply to this email directly or view it on GitHub.
> I think it is necessary code because it makes the intent of the code explicit. I've traced more than a few bugs to omission of else blocks, so I think it is the usually the better practice to include them.
> —
> Reply to this email directly or view it on GitHub.
>