more work on popup