engine: Use NetworkUtils.getEngineNetwork where possible

The patch replaces same logic for resolving the management
network name with NetworkUtils.getEngineNetwork.

Change-Id: I76bd3d0de7d5d2db1656f17670d820f6384c0712
Signed-off-by: Moti Asayag <masayag@redhat.com>
engine: Some network cleanups

Some cleanup for networks related code.

Change-Id: I546f6081f285a758ea810de2b080bc2cb8c0d9a3
Signed-off-by: Moti Asayag <masayag@redhat.com>
core: rename methods to start with lowercase

Rename several methods to start with
lowercase -java standard.

Change-Id: I13d9f2ee1d107abaa78519f1714998f09317cab1
Signed-off-by: Alissa Bonas <abonas@redhat.com>
findbugs: ignore: Log interface should not be the same as the implemented class name

findbugs warns about using namespace interface 'Log' is the same name as the
implemented interface name 'Log'.
The class is deeply embedded in the code so we are ignoring findbugs warning
for now

Nm: Class names shouldn't shadow simple name of implemented interface (NM_SAME_SIMPLE_NAME_AS_INTERFACE)

Change-Id: Icef5b803ad9aacaf5f6150f3e0744ccc22ec7936
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
findbugs: ignore Unwritten public fields

This classes are GWT classes and will generated code that will write to
this fields

findbugs reason:
UwF: Unwritten public or protected field (UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD)

Change-Id: I0453d3d7e4404727afe4d356f49547969cef951b
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
findbugs: remove unread fields

findbugs reason:
UrF: Unread field (URF_UNREAD_FIELD)

Change-Id: Ied4990cd90e58e566679851b3e2c5dcde05629cd
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
core: add memory snapshot feature support

Support snapshots with memory state as from version 3.3.

Feature page:
http://www.ovirt.org/Features/RAM_Snapshots

Change-Id: I69484598af0205d043b6f0438182a20adfeffff8
Bug-Url: https://bugzilla.redhat.com/960931
Signed-off-by: Arik Hadas <ahadas@redhat.com>
findbugs: remove unread public or protected fields

findbugs reason:
UrF: Unread public/protected field (URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)

Change-Id: Ib320ef93c723bdee810fd27ebfd306c890b1d11e
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
findbugs: ignore: Unread public-protected fields

We add to ignore list fields that we do use in reflection or GWT and
findbugs fail to recognize.

findbugs reason:
UrF: Unread public/protected field (URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)

Change-Id: I7e0a285d71bbed1a9201c6a919cb57e7a8c16406
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
core: add memory volume to snapshot entity

This patch adds attribute of memory volume to snapshot.

Change-Id: Iecda4c491fe6e207386edf2a9bf2488ec81a332a
Bug-Url: https://bugzilla.redhat.com/960931
Signed-off-by: Arik Hadas <ahadas@redhat.com>
core: add memory snapshots capability to VdsBroker

This patch adds the capability of taking a snapshot with memory state to
VdsBroker project:
1. add new call in the interface against VDSM that also pass an image
which will contain the memory state when calling to snapshot verb
2. a memory image parameter was added to SnapshotVDSCommandParameters
that indicates where to dump the memory to
3. SnapshotVDSCommand was changed such that if the parameters contain
memory image, then it invokes the new call added to the interfact
against VDSM

Change-Id: Id928c76562d520acbf36ca01e074e51cbdcccaf9
Bug-Url: https://bugzilla.redhat.com/960931
Signed-off-by: Arik Hadas <ahadas@redhat.com>
core: extract general code from HibernateVmCommand

This patch extract code which is not specific to hibernate command, and
which can be used by the create snapshot command when the snapshot
contains memory state, from HibernateVmCommand to shared places.

Change-Id: I15c4f3302d26eb5d161824f8bb19ecc5dd114a20
Bug-Url: https://bugzilla.redhat.com/960931
Signed-off-by: Arik Hadas <ahadas@redhat.com>
restapi : format option doesn't exists in 'remove storagedomain'

--format option doesn't exists in 'remove storagedomain'
autocompletion options, when it passed it is working
(should be added to autocompletion options)

Change-Id: I36b5c7399bc93fa8268bf52a7c3ce8c87749ecda
Bug-Url: https://bugzilla.redhat.com/962276
Signed-off-by: Ravi Nori <rnori@redhat.com>
findbugs: Constants: dont use class name as the same as the class you implement

class name Constants change to UIConstants

findbugs reason:
Nm: Class names shouldn't shadow simple name of implemented interface (NM_SAME_SIMPLE_NAME_AS_INTERFACE)

Change-Id: Icacd4a7a57dd174e650e9bba8674241cc2847199
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
findbugs: Messages: dont use class name as the same as the class you implement

class name Messages change to UIMessages

findbugs reason:
Nm: Class names shouldn't shadow simple name of implemented interface (NM_SAME_SIMPLE_NAME_AS_INTERFACE)

Change-Id: I499a5f85a2b5c8881bf35a71d12e9a4460d5bd3f
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
findbugs: ignore: Load of known null value

findbugs complains about loading known null to a variable
in this case we are using it for equals check and its intended

NP: Load of known null value (NP_LOAD_OF_KNOWN_NULL_VALUE)

Change-Id: Ica07cdd87a3851e6efb6e2566bd87dbc2342ab7e
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
Support SSL providers

This patch adds support for SSL providers:
1. Adding an external trust store
2. Support for querying and Importing certificate chains, including UI
support for that
3. Removing the validation that the URL isn't https from the UI
4. Creating BaseProviderProxy that handles getting the certificate chain
from a generic https provider URL

To support this flow well in the add/edit provider URL dialogs, I added
the option to run an action without popping up an exception while one
happens.

Change-Id: I35343409d74a4f90aae726b46781f27ce08a981a
Signed-off-by: Oved Ourfali <oourfali@redhat.com>
findbugs: method may pass null to method that cant get null value

findbugs reason:
NP: Method call passes null to a nonnull parameter (NP_NONNULL_PARAM_VIOLATION)

Change-Id: Iec2c3225b58d8486cdf5d95c98f8b98593fb7fec
Signed-off-by: Shahar Havivi <shavivi@redhat.com>
core : update of bootable disk

when updating a bootable disk, a CDA message was always shown because of
a check that the vms that the disk is attached to doesn't contain boot
disk - this disk shouldn't be done if the disk was already bootable
before the update operation.

Change-Id: Ibc0e96274e408306d2444f8fa01a45daf38724f7
Signed-off-by: Liron Aravot <laravot@redhat.com>
userportal,webadmin: some params on make template ignored

The make template ignored some parameters.

- In UserPortal the usb policy has been taken from an incorrect place
- In both UserPortal and WebAdmin the Boot Options -> Attach CD was
  ignored
- In engine the allow console reconnect and iso path has been ignored in new
  template

Change-Id: Ibf4c0610688ae773e86190d4bd2d73cd7c74b1e6
bug-url: https://bugzilla.redhat.com/952712
Signed-off-by: Tomas Jelinek <tjelinek@redhat.com>