Deprecate land-cowboy in favor of land-cowhand
https://bugs.webkit.org/show_bug.cgi?id=104470

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-15
Reviewed by Darin Adler.

Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.

* Scripts/webkitpy/tool/commands/download.py:
(LandCowhand):
(LandCowboy):
(LandCowboy._prepare_state):
* Scripts/webkitpy/tool/commands/download_unittest.py:
(test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
also checking the deprecation message in the output of the latter.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790

Patch by Rob Buis <rbuis@rim.com> on 2013-04-15
Reviewed by Darin Adler.

It does not seem needed to initialize jpeg_create_compress struct to zero,
all that is needed is set the err field. See for instance SkImageDecoder_libjpeg.cpp.

* platform/image-encoders/JPEGImageEncoder.cpp:
(WebCore::compressRGBABigEndianToJPEG):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening.

* platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r148236.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding failure expectations for tests introduced in r147829 and r148136.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] REGRESSION(r147499): HTTP auth dialog doesn't remember passwords anymore
https://bugs.webkit.org/show_bug.cgi?id=114613

Reviewed by Carlos Garcia Campos.

* Source/autotools/SetupAutoconfHeader.m4: Correct definition of ENABLE_CREDENTIAL_STORAGE
so that the ENABLE(CREDENTIAL_STORAGE) macro work properly.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
https://bugs.webkit.org/show_bug.cgi?id=114602

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/tool/multicommandtool_unittest.py:
(CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
interface so its value doesn't leak into the following tests.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[WinCairo] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=114623

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-15
Reviewed by Brent Fulgham.

* platform/network/curl/CookieJarCurl.cpp: Added required header files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] Missing a few packages for building on stock Fedora
https://bugs.webkit.org/show_bug.cgi?id=113916

Reviewed by Philippe Normand.

* gtk/install-dependencies: add packages that are missing.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Forward userGesture when creating a new window
https://bugs.webkit.org/show_bug.cgi?id=114622

Patch by Andy Chen <andchen@blackberry.com> on 2013-04-15
Reviewed by Rob Buis.

Client could use this info to decide whether the popup should
be blocked.
PR 291898
Reviewed internally by Mike Fenton

* Api/WebPageClient.h:
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
        Flaky Test: http/tests/ssl/ping-with-unsafe-redirect.html
        https://bugs.webkit.org/show_bug.cgi?id=114616

        Land expected results for the test.

        * http/tests/ssl/ping-with-unsafe-redirect-expected.txt: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
An inline element with an absolutely positioned child does not correctly calculate/render padding and margin
https://bugs.webkit.org/show_bug.cgi?id=47554

Reviewed by David Hyatt.

Source/WebCore:

When looking for padding/margin to add from the start of a child's parent skip past any leading positioned siblings as
we don't add the padding/margin of the common parent when skipping past them in |skipLeadingWhitespace|. We
don't need to worry about the case of trailing positioned objects as we will account for their parent's
border/margin/padding when we encounter them in |nextSegmentBreak|.

Test: fast/inline/padding-before-leading-positioned-element-contributes-width.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::previousInFlowSibling):
(WebCore):
(WebCore::inlineLogicalWidth):

LayoutTests:

* fast/inline/padding-before-leading-positioned-element-contributes-width-expected.txt: Added.
* fast/inline/padding-before-leading-positioned-element-contributes-width.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Crash when favicon is requested
https://bugs.webkit.org/show_bug.cgi?id=114624

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-15
Reviewed by Brent Fulgham.

* WebIconDatabase.cpp:
(WebIconDatabase::getOrCreateDefaultIconBitmap): Added NULL pointer check.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
HTMLMediaElement::removeTextTrack should clear track client
https://bugs.webkit.org/show_bug.cgi?id=114630

Reviewed by Jer Noble.

No new tests, this is clean-up that prevents a potential crash.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removeTextTrack): Clear the track client.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WKR gets stuck when there are many merges
https://bugs.webkit.org/show_bug.cgi?id=114632

Reviewed by Andreas Kling.

Move the last revision forward when it exists in a branch.
Otherwise, we'll be stuck looping over revisions made to merge patches.

* Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[WIN] Remove remaining calls to pthread from WTF
https://bugs.webkit.org/show_bug.cgi?id=114563

Reviewed by Brent Fulgham.

Replace pthread_key_create with threadSpecificKeyCreate and
pthread_setspecific with threadSpecificSet from ThreadSpecific.h.
These functions provide a windows-specific implementation for the pthread functions,
but require that the thread has been created with WTF::createThread(),
which is the case for all threads created within WebKit.
To call this function from fastMalloc we must not call fastMalloc in them.
To fulfill this constraint ThreadSpecificWin will allocated its memory through the
original malloc implementation and use the stack for local and static variables.
Keep the Darwin implementation as it is, since it contains some performance tweaks.

* wtf/FastMalloc.cpp:
* wtf/ThreadSpecificWin.cpp:
(WTF::destructorsList):
(WTF::destructorsMutex):
(WTF::threadSpecificKeyCreate):
(WTF::threadSpecificKeyDelete):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[CMake] Add WTF_USE_*_UNICODE variables
https://bugs.webkit.org/show_bug.cgi?id=114556

Reviewed by Brent Fulgham.

WTF_USE_ICU_UNICODE and WTF_USE_WCHAR_UNICODE are used to
reduce duplication in the platform specific CMake files.

.:

* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:

Source/JavaScriptCore:

* CMakeLists.txt:
* PlatformEfl.cmake:

Source/WebCore:

* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* PlatformWinCE.cmake:

Source/WTF:

* wtf/CMakeLists.txt:
* wtf/PlatformBlackBerry.cmake:
* wtf/PlatformEfl.cmake:
* wtf/PlatformWinCE.cmake:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
After switching to another space and back, video races to catch up with audio
https://bugs.webkit.org/show_bug.cgi?id=114634

Reviewed by Tim Horton.

In Mountain Lion and previous, report that a view is "not visible" when its window
is not in the active space. This causes us to notify AVFoundation that its CAImageQueues
will not be serviced and results in not having the "catch up" behavior when returning
to the browser's space.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::isViewVisible):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Crash from null m_webSettings in WebPagePrivate
https://bugs.webkit.org/show_bug.cgi?id=114633
RIM PR 303745

Patch by Liam Quinn <lquinn@blackberry.com> on 2013-04-15
Reviewed by Rob Buis.
Internally reviewed by Leo Yang.

Speculative fix suggested by George Staikos--initialize m_webSettings first thing in the init() method.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove files related to quota and proximity events from the Xcode project
https://bugs.webkit.org/show_bug.cgi?id=114635

Reviewed by Benjamin Poulain.

* WebCore.xcodeproj/project.pbxproj:
* history/PageCache.cpp:
* page/DOMWindow.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Call directly RenderBlock::deleteLineBoxTree
https://bugs.webkit.org/show_bug.cgi?id=102761

Reviewed by Darin Adler.

Instead of implementing RenderLineBoxList::deleteLineBoxTree logic inside
RenderBlock::determineStartPosition, we can reuse the code. The commentaries added
in the changeset #86628 are not valid anymore, nextRootBox is casting m_nextLineBox
and nextLineBox is returning m_nextLineBox.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148468 268f45cc-cd09-0410-ab3c-d52691b4dbfc