maybe attr_accessor would be better