working on feature generation