Add internal enviroment variables to note message
Modifies Git Publisher note msg log
Add unit tests for existing null/empty name handling.
[FIXES JENKINS-15235]
- Trim branch name before storing it, since a valid branch name does
not begin or end with whitespace.
- Use same code for setting name in constructor and in setName().
Previously, there were no check for valid values in setName().
Merge pull request #115 from thesam/jenkins15235

[FIXES JENKINS-15235] Add whitespace trimming of branch name.
expand parameters in the remote branch name of merge options
also expand the name being displayed in the logs
[FIXES JENKINS-14321] - Do not re-use last build's environment for remote polling

Fixes, the original 'fix' in 3d9a73d26b129249c51fccfca6060280197b25eb it appears
that a crucial check on the newly implemented argument wasn't actually implemented.

I've changed the condition to test this rather than set 'b' to null if reuseLastBuildEnv
is set to true as 'b' is de-referenced later in the getPollEnvironment method.

Rather worryingly it appears that the existing code in getPollEnvironment tests at one
point whether 'b' is null, but then later (outside this test) derefences it anyway, but
this commit does not make that particular problem any worse.

Signed-off-by: ciaranj <ciaranj@gmail.com>
Fixes potential NPE if no previous build exists

Signed-off-by: ciaranj <ciaran.jessup@thisisnumero.com>
Typo in connection from 85475fd broke plugin-compat-tester.
set changeSet.kind to "git"
Merge pull request #120 from lruslan/master

set changeSet.kind to "git" in build details
Avoid some calls to "git show" in isRevExcluded

If there are no inclusion patterns, no exclusion patterns and no excluded
users, then the revision cannot be excluded.  If the revision cannot be
excluded, there is no reason to call "git show" to generate the list of
revisions to be tested for exclusions.

Provides some performance improvement in almost all cases which do
not define inclusion or exclusion patterns or users.  Will provide
significant performance improvement in those cases where the "git show"
output is very large (or hangs when being generated).
Merge pull request #122 from MarkEWaite/master

Improve isRevExcluded performance by avoiding call to "git show" if no exclusions are defined
FIXED - JENKINS-16453
added null check
finally returning flag value instead of false
removed exception handling
added a basic test
add email address properly if already known
Merge pull request #123 from richtmat/master

Fixing JENKINS-16453