I could not tell from the logs who had added the testFortran.py file, so I was not sure who to follow up with.

-Bill

On Mar 15, 2013, at 2:10 PM, njsmith wrote:

> In doc/swig/test/testFortran.py:
> 
> > -    # Test (type* IN_FARRAY2, int DIM1, int DIM2) typemap
> > -    def testSecondElementContiguous(self):
> > -        "Test luSplit function with a Fortran-array"
> > -        print >>sys.stderr, self.typeStr, "... ",
> > -        second = Fortran.__dict__[self.typeStr + "SecondElement"]
> > -        matrix = np.arange(9).reshape(3, 3).astype(self.typeCode)
> > -        self.assertEquals(second(matrix), 3)
> > +    # This test used to work before the update to avoid deprecated code.  Now it
> > +    # doesn't work.  As best I can tell, it never should have worked, so I am
> > +    # commenting it out.  --WFS
> > +    # def testSecondElementContiguous(self):
> > +    #     "Test Fortran matrix initialized from reshaped default array"
> > +    #     print >>sys.stderr, self.typeStr, "... ",
> > +    #     second = Fortran.__dict__[self.typeStr + "SecondElement"]
> > +    #     matrix = np.arange(9).reshape(3, 3).astype(self.typeCode)
> > +    #     self.assertEquals(second(matrix), 3)
> 
> If we're not sure whether this is a meaningful test, we should figure that out. If we're sure it's not a meaningful test, we should delete the code -- no point in leaving broken code around in comments as decoration.
> 
> —
> Reply to this email directly or view it on GitHub.
> 

** Bill Spotz                                              **
** Sandia National Laboratories  Voice: (505)845-0170      **
** P.O. Box 5800                 Fax:   (505)284-0154      **
** Albuquerque, NM 87185-0370    Email: wfspotz@sandia.gov **