labofsahil/github-event-dataset-2012 huggingface dataset:
Yes, we didn't know how to assert this in the unit test for provider.rb (it already had a test that said the block was passed along). The RPM provider showed the issue and had no tests around it, so we decided to add a test for the functionality that showed the error.
I've seen this statement in enough places to where I wonder if it wouldn't be worth abstracting it into a puppet utility method somewhere.
@alindeman: It is possible... yet I'd prefer the original variant because:

* The interface is clearer, as "message" is clearer than "args" in intention
* It is more consistent with the Kernel.raise interface. As when making this change, and_raise will also work with 4 arguments for example.
* Having multiple arguments is unlikely going to be used, so it seems a trade-off between simpler implementation and better interface. I'd go for better interface :)
I'm really curious: why this line?
The description is wrong. It should be ``Returns the identifier for the item``. Your implementation does not return the name of a property in the function
Yes, I saw that there is already "DASPRiD" that does the same thing and more! ... I no sabi something that already existed in Zend2, thank you friends.

We can close this PR?
Throughout, add spaces after conditional operators.
The only change I had to make to have this work as I expect is to sub this in at L120:
```
if ($useHydrator === self::ARRAY_HYDRATE {
```
oops there are 2 spaces missing. Should I fix and do a new pull request, or is there a way to edit this? Thanks!
this file should be removed as it is totally outdated. Symfony was using ``bootstrap.php.cache`` since before the stable release, which will be generated by the composer script handler
Do we need to store both the ImageSurface and the Layer? The surface is contained within the layer ...
Whatever you prefer. Notice something similar should be done with `onFlush`.
the doc comment looks copy-pasted from bindTranslation, can you update to explain that this removes an existing translation. is it an error to remove a non-existing translation?
Ooops, that's a leftover. it is done in the Prefixed UrlHandler.
object.
use `else`
is this working with care-o-bot? or do we have collisions between base and laser stl?

please use stl instead of stlb (needed for arm navigation and collision checking)
I would wrap these validation settings into a function and call it from $parsers and $formatters callbacks... like this:

function setValidity(values) {
    ctrl.$setValidity('required', required ? values.length > 0 : true);
    ctrl.$setValidity('min', angular.isNumber(minCount) ? values.length >= minCount : true);
    ctrl.$setValidity('max', angular.isNumber(maxCount) ? values.length <= maxCount : true);
}

ctrl.$parsers.push(function() {
    // ....
    setValidity(values);     // instead of repeating same ctrl.$setValidity in both callbacks
    return values;
}

Thanks :-)
Should there be a test for this function?
なんでこの内容が valid_twitter_name? になるのかよくわからないな．
See the main comment, I'm not sure :S I thought it would have been set in the prefs, I used both tabs and spaces and it doesn't seem to like either?
i think we would also need to describe the exact params that can be passed?
Shouldn't we use signals for this?
Again, while I don't think there are pages where this will make a difference, the regex is not matching what you think it is.

E.g. `"isthissimple/???".match(/http:\/\/bofip\.impots\.gouv\.fr\/bofip\/ext|simple\/.+/)` will return `["simple/???"]`

It should be `/http:\/\/bofip\.impots\.gouv\.fr\/bofip\/(?:ext|simple)\/.+/`
lockPath is maybe the field I suggested above.
I'm not sure why this class is needed. Look at how we configure sequencers, text extractors, etc: we just instantiate the class and each field in the instance is set with the value of the same-named property in the configuration. I'd much rather configure the custom binary store this way.
Delete commented xml
Same with this -- it should be public
Add comment: This function performs a recursive delete operation on the specified path
I agree but that's a job for another day.
IMO, the expected PHP value of a BLOB type is a ressource.
Оно шаблонизировано, так что вполне вне класса, на мой взгляд. Теперь оно получает номер вершины и количество вершин. Так нормально?
The other specs use a newline between `it` blocks, could you also do that?
Pretty sure the trailing slash isn't needed nowadays.
Lets rename this method to cli() as what mozrunner has, so we know that this is for the console script.
Can the "lookup + get attribute + add to hash table + free" boilerplate be abstracted into a helper function?
Shouldn't these be part of oae-tenants ?
Does this need to be a globally available variable? It looks like it could just be created in filterModulesByConfig and passed around.
Probably worth saying something about mounting a path onto all app servers as a possibility here.
They were already there, so I kept them in. There's a TODO somewhere to remove these once the UI is hooked up.
Сообщение is way better
this should be call also
Why do use "apply" directive here?
Typedef are not binded by default, you need to redeclare it to SWIG.

And why int ? Should be double, no?
I don't use to use `filter_var` actually. I guess we should fix all providers to use `filter_var` everywhere it's needed.
Anywhere there is a maaaasive chunk like this should be changed. It's not worth the few lines that it saves.

On 2 May 2012, at 10:54, Andrey Andreev<reply@reply.github.com> wrote:

>> -                }
>> -
>> -                if (array_key_exists('NULL', $attributes) && $attributes['NULL'] === TRUE)
>> -                {
>> -                    $sql .= ' NULL';
>> -                }
>> -                else
>> -                {
>> -                    $sql .= ' NOT NULL';
>> -                }
>> -
>> -                if (array_key_exists('AUTO_INCREMENT', $attributes) && $attributes['AUTO_INCREMENT'] === TRUE)
>> -                {
>> -                    $sql .= ' AUTO_INCREMENT';
>> -                }
>> +                $sql .= "\n\t".$this->db->protect_identifiers($field)
> 
> Okay, line separation works for me. But I'm not sure I could add any useful comments - those expressions look pretty much self-explanatory.
> 
> P.S.: I assume the same goes for MSSQL, SQLSRV and ODBC (other pending pull requests that do the same).
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/EllisLab/CodeIgniter/pull/978/files#r760854
Is this used at all? While cookies work, a better approach would be to look up those column settings in a table like this. It would allow a user to persist settings across sessions. What do you think?
Was this block that thing we did to fix how isocalendar handles the first week?
سلام،
ممنون.
این رو به صورت دستی تصحیح کردم داخل فایل.
به فصل یک یه تیکه به انتهای حالت مخلوط و یک زیر بخش به عنوان کانال کوانتومی اضافه شد.
این فصل از نظر من نهایی هست. حالا هر چی خدا بخواد.
اگه غلطی مخصوصا توی قسمت کانال کوانتومی دیدی، حتما بهم خبر بده.
CRLF is redundant here.
split your nav into a partial.
Just like the comment above, these tests belong on the the platform implementation of contextMenuEvent
I'm glad you asked :-)  I can't see a great deal of value in it myself.  Do you know how widely used it is in cucumber-ruby / jvm land?
Should this be `typeof res.locals === "function"`?
Handled in the [cleanup branch](https://github.com/Thynix/fred-staging/commit/bd4b4231f85181ce2180263075631b7f851d2880).
Dette tror jeg ikke vil fungere.
@codyhoag Since this numbered step contains several sub-steps, it may be best to break up the sub-steps explicitly.
@carlosmn Fixed! I also fixed some other "wronglies" in 0690be7eca2fa56231ee6a250bc13c76ebcc7e94
@marc1s Can you please modify the copied code so as to only take over the *idea* mentioned in the SO question? Otherwise we might not be compliant with the code’s license which is [Creative Commons Attribution-ShareAlike 3.0 Unported (CC BY-SA 3.0) ](http://creativecommons.org/licenses/by-sa/3.0/) according to the footer on SO. IMHO this viral license is not compatible with our BSD license.
In this context, they should all have the same time-frequency and speed tradeoffs as we see in the other filter types. However, since I allowed the frequencies to be specified as an array here, the FFT method may actually end up being about as fast as the IIR method, since all the notch frequencies get removed simultaneously. I'll have to test that once I get back to my workstation (too painful to test speed on this laptop). However, I do think it at least makes some sense to use FFT here since it's the default for other forms of filtering, and I don't see huge differences in the quality of filtering between the different types. Again, open for discussion...
I think it would be good to add a few sentences explaining what the method does and why you would want to use it (advertise the method)
These are the relevant sorts of tests. They would have failed before...
I would have done : xfm = list() ... xfm.append(digs) ... xfm.append([0., 0., 0., 1.]) ... xfm = np.array(xfm)
docstring needs update
Add javadoc comment like the good one on HttpUrl.  (also add openmrs license on file)
pretty sure this is fine. and the one below
I believe I am doing the local branch. I will recommit.

Carolyn

Sent using a mouse-sized keyboard with feigned autocorrect intelligence.

On Dec 25, 2012, at 10:38 AM, Mike Fiedler <notifications@github.com> wrote:

> In soft_skills.rst:
> 
> > +professionals are spreading themselves too thin on projects and
> > +deliverables that do not serve the organizations mission. One way
> > +to focus the efforts of Operations is to answer these questions and
> > +to ensure that the Operations organization, whether insourced or
> > +outsourced, is delivering services that provide the most value.
> > +
> > +Protection of Information and Services
> > +--------------------------------------
> > +
> > +Often the Operations professionals in an organization are the people
> > +who most completely understand the technical risk to organizational
> > +assets from an IT perspective. Senior management within an organization
> > +will usually understand financial risks, risks from competition,
> > +manufacturing risks, etc. but they often do not understand IT risks
> > +because of the deep-dive technical expertise required to comprehend
> > +threats to the organization.
> The correct way would to create another git commit, addressing any outstanding issues, and this will run it through the tests, and add the new commit to the pull request.
> 
> In general, creating a local branch to make changes on is recommended, as this allows you to make your changes irrespective of other's, making merging less of an issue. See here and here for more.
> 
> —
> Reply to this email directly or view it on GitHub.
>
@stof Ok. You're right. 

Nevertheless, I still think, that the best method to write a script that can access any component is to use:

    {
        "require": {
            "symfony/symfony": "2.1.*"
        }
    }
It's probably better to never write /A for non-commutatives.
Well, we already have $_GET and $_POST vars.  I guess, REST params are the remaining verbs (PUT, DELETE).

In any case, getRestParams() are the request parameters that are read from php://input.  How else can you call them? They are the rest REST params (pun intented)
Э, ты уверен, что `decrypt` подходит для ката?
Стоит все же как-то уведомлять юзера и дать ему возможность не подключиться и абортнуть соединение.
Пробел между интами (и на 4 строчки выше тоже).
Good stuff here!
Is this line missing a ")"?
See the changes I made to the documentation example here.
this should be instance_uuid instead of instance_ref.id
Or is the IDE playing up?
Instead of an array/list of tuples, why not use a map and traverse that? Much more sensible use of collections :)
Have a read through http://www.cs.virginia.edu/kim/publicity/pldi09tutorials/memory-efficient-java-tutorial.pdf

Given the size of these collections (wo/ virtual nodes any more, these collections should be relatively small), I'd try to use something that consumes less memory.
It does make sense to have state transfer components running even if state is not fetched from other caches (invalidation mode or fetchInMemoryState == false). But even in that case we still need to _discard_ segments we no longer own after a topology update.
`isTweetAboutFlying()` is called multiple times, so I think it's better to create the Transliterator instance once in our constructor.
The point is not how many times a var is used. It's about avoiding lines that are too long and do too much stuff.
Why not just overwrite the clone method in FileAsset?
Why not just `np.min(n)`?

Also, you don't need to refer to the issue it fixes.
Ok, I added a description of cyclic as a separate scheme
"Also its path to sys.path..." <---- there is a verb missing here
device is misleading, emulator and panda are also covered by this attribute
Aussi comme chacun des listeners ne definissait qu'une seul méthode handler, autant les regrouper dans un seul listener.
D'autant plus que les deux handlers sont liés l'un gère le placement d'un panneau, l'autre l'interaction avec.
Il est plus simple de comprendre la logique du plugin si tu regroupe les éléments par fonctionnalités. J'ai renommé le Listener, SignListener puisque c'est exactement ce qu'il fait =).
Quelqu'un qui arrive sur ton code source comprendra de suite que ce listener gère les manipulations de pancarte du coup.
I agree that this could be a little cleaner. I'll extract a method and resubmit!
Oh, n/m, I didn't notice the imported-check guarding this whole section.
@gsilver missing space before `{`
How about a more explicit option name then, something like 

```php
\PhpOption\BCOption::create($this->findSomething());
\PhpOption\BCOption::fromCall(array($this, 'findSomething'));
```

I mainly thought about the LazyOption in situations where you would have multiple options available, and the first non-empty option would be returned (``orElse`` does not exist yet):

```php
// If $optionA is non-empty return $optionA, if it is empty, evaluate and return $lazyOptionB.
return $optionA->orElse($lazyOptionB);

// This can also be chained.
return $optionA->orElse($lazyOptionB)->orElse($lazyOptionC);
```
I don't entirely like how the "force reload" and "replaceState" are compounded here into one bool, but I did not want to introduce two new parameters.
var getHtml5Data = NATIVEHTML5DATASET ? function(element, datalabel) {
      if (!(element = $(element))) return;
      return datalabel ? element.dataset[datalabel.camelize()] : element.dataset;
    } : function(element, datalabel) {
      // skipped
    };

1. You can make two different implementations (native/emulated) rather than check each time.
2. You return object `{someCamelizedProperty: value}` instead of plain value when `datalabel` is provided. IMHO when I call `element.getHtml5Data('my-data')` I just want my data back without any extra effort to extract it from an object.
No pro mě je to spíš těžší, protože já bych si od tebe právě musel tahat ty timery, abych to moh upravit. Když to opravíš ty, tak se to pak snad nějak zvládne do toho mastera zmergovat a vše bude skvělé a funkční :)
Can all the notifiers be nested in a Notifications module? Travis::Addons just feels like an odd namespace for all the notifiers
I'm not positive of this change, please review this one carefully.

It seems to me that since we're doing a checkpoint, the eviction server isn't blocked, which means any work we do here will be lost as soon as the eviction server wakes up and re-starts a tree walk for this file. 

This might make it less likely we'll have to call __wt_evict_clear_tree_walk from inside of __wt_tree_walk, should there be a collision there?
w.r.t. being lazy about getting a transaction context: I agree, that will be better if we're spinning on busy pages (i.e., __rec_review is failing), or for read-only pages where we don't need to write to evict the page.

That said, we don't want to push this too far down: it makes my head hurt to think that we might use different snapshots of pages within a merge group, for example.

I'll open a separate issue for this -- I think it's a potentially important optimization, but non-trivial.
remove space `&$middlewareTarget`
Don't think we need a resume. Play just be able to do it.
The #TODO coments can be removed now as the Rails upgrade seems to have magically fixed it.
Why has this assertion been commented out? Can we not modify it to assert the correct result?
NPE ist im nächsten Commit behoben. Der StatusService fängt eine NPE wie auch jede andere Exception. Allerdings gibt es keine spezielle behandlung für NPEs (zu allgemein), d.h es gibt einfach einen 500er Status (standard Verhalten bei nicht speziell behandelten Exceptions).
**RE: `header` key/value option**

Maybe something like this ...

```javascript`
...
if (typeof(options.header) === 'object') {
  for (key in options.header) {
    header += key + ': ' options.header[key] + '\r\n'
  }
} else if (typeof(options.header) === 'string') { 
  header = options.header
} else {
  ...
```
INSERT INTO menu ( name, cat_id, date, portion, cost)
SELECT '$name' , id, '$date' , '$portion' , '$cost' FROM category WHERE category_name= '$q'
И нам не нужен $query_c
It can probably be refactored by calling next_tick until we reach after the last read, and only then performing the check.
Again, don't we loose information if we don't pas the phpMail error along?
manglende link?
Authorization: MAC is another possible header.
http://tools.ietf.org/html/draft-ietf-oauth-v2-http-mac-01
" -> ' for consistency with the rest of the file
According to the SIP.   I'll go try it out and fix my statement if it's
working.
Sure, I understand the point. I'm just thinking in terms of simplicity and maximizing information transfer while minimizing confusion. I was just thinking that by throwing value classes in to this example, people would falsely assume that making your implicit class a value class was a requirement to make your own string interpolator. 

The copy-pasters point is a good one though- maybe this can be clarififed in a low tech way? Like keeping it a value class but throwing in a footnote or something which offers a disclaimer for those that want to read into it?
Just to clarify, you're asking me to change line 62 from:
```
if(is_array($results)) {
```
To
```
if (is_array($results)) {
```

Correct?
Part of fix for issue #9, not complete yet but part of this commit.
https://github.com/visionmedia/superagent/blob/master/lib/node/index.js#L692 :smirk:
Please name methods correctly.
Do `@register.simple_tag(takes_context=True)`.
Yes! I did it, it works, now I allow myself to go to sleep :) I will commit changes and some code style tomorrow. Should I include condition if user is not None in account/views?
No, this is one thing. To try to click, or copy-paste link. But then also copy-paste the token itself into the form.
Aha. You are using it when somebody scrolls down.. OK.
Those are partially my fault.  His initial commit was correct, but when i merge the drlg stuff from wetwlly, it also had a corrected PlayLineParams file in it and it conflicted with his PR.  He probably forgot to fix it after his fixed his conflicts.
1) You shouldn't need to use `unicode()`; you could just set `self.text` to `gettext_lazy('foo')`
2) Your old solution removed all the `_()` so the translation-finder wouldn't have seen any of them.
I don't see what those two tests have in common. This test (`SpecificationIsNotNullWhenInitializedWithConstructorWithoutSpecificationParameter`)  tests something else than `CreateWithAbstractionRequest_ReturnsResultFromDecoratedBuilder`. Why do you think it is redundant. I can change `NSubstituteBuilder` that breaks either one of these tests but not the other one.
We don't want to put html into our urls. There is no reason to do this, as django separates the url from the file that is served.
See comment below PR.
this "fun" value is meant to hold sentinel values that would need to persist for each individual pixel, such as perhaps a fade velocity or something. I haven't implemented it.
I am sure he knows more abut this than I do.  I haven't heard, and can revert the commit if it's an issue.
I just wasn't a fan personally, and thought it was the current standard.  What do I know tho :/ :)
I think that we don't need to override  both clean() and save() here...

If we just want to automatically change the week_start on save, we can get rid of the clean() override entirely. We would only need clean() if we wanted to throw a validationerror, which I don't think is the  case here.
and what about queries without a WHERE clause ?
Align closing parenthesis
Would it be better to write `$self->check_mysqld_status`?
i'd go with an alphabetic order
now that it reuses the recordreader, it should not ignore these exceptions anymore. A file with lots or errors should result in an error.
There's no technical issue with calling it the same thing, it just requires us to be very clear via namespaces which one we're referring to. We could call it `Aggregator`?
and actually, should probably be the default setting but having a way to change it and to set it to another value sounds something we want.
Two braces at the same indentation level means indentation is wrong somewhere, and maybe that code is wrong somewhere.
Fixed.
Also switched my other .js files to strict mode.
This class is purely an implementation detail.  I wonder if it would be better to call it "_PowerSpectrumRealizer" so as to exclude it from the doxygen documentation?  I don't know if the end user will ever want to use this class.
I guess you are worried about name clashes with other things in the galsim namespace?  The usual thing for that is to put them in their own namespace.  e.g. odd in this case.

I went ahead and did this, so you can see what I mean.  Feel free to revert if you don't like the change.
I was hoping to get the speed to where the 100x100 is doable in a reasonable amount of time.  So if Gary's fix does that, then I'd like to bring this back up to 100x100, since that's what a Great08 image was.  (I tried to get everything to match the Great08 stuff as much as possible, with deviations specified in the comments.)
Anyway, I'm glad we agree, will implement that (and it does indeed have the speed benefit of cutting out an `if` statement every `xValue` call, and these calls happen often).
Why are there now both a keyDownHandler and a keyPressHandler? It sounds like the same thing.
Hm. Here it works fine for e.g. CaptionedImage blocks in an Aloha editable, when you change their alignment.

This is also how it's used in the paste and undo plugins:

```
wim.leers at 94-224-97-171 in ~/Work/Aloha-Editor/src/plugins on dev*
$ egrep -rn "\.smartContentChange" .
./common/paste/lib/paste-plugin.js:202:							Aloha.activeEditable.smartContentChange( event );
./common/paste/lib/paste-plugin.js:216:							Aloha.activeEditable.smartContentChange( event );
./common/paste/lib/paste-plugin.js:230:						Aloha.activeEditable.smartContentChange( event );
./common/undo/lib/undo-plugin.js:102:						this.editable.smartContentChange({type : 'blur'});
./common/undo/lib/undo-plugin.js:122:					Aloha.getActiveEditable().smartContentChange({type : 'blur'});
```
Looks like we lose the exception stacktrace - is that deliberate? Do we not want to report it so that the user (or we) can fix the exception's cause?
This should be `GLint` instead of `int /*long*/` to be 64bit compatible.
Please remove the trailing whitespaces (maybe it's a good idea to highlight them in your editor)
(timebase / (1>>32)) & 0xFFFFFFFF
why x.name !== name is not in filter expression?
````ruby
package 'jdk' do
  version '1.6.0_31-fcs'
  action :remove
end
Would it be possible to set the service as shared=false? That way, you get a new instance of Postmark\Main when you call 'postmark' service from the DIC.
Fwiw, `db.isMaster()` returns `maxBsonObjectSize`.
To avoid this silly indentation on the whole class, can't we use a class decorator that makes every test skip?
i just ran the tests and this HTTPS invalid cert one doesn't pass

i'm ok with removing it since it can change at any time
Concordo removido
These console.logs need to go
Cheers David,

Your right that is neater. Thanks for sharing. 

Regards,
Jon

----- Reply message -----
From: "David Winterbottom" <reply@reply.github.com>
To: "Jonathan Moss" <jonathan.moss@tangentone.com.au>
Subject: [django-oscar] Managing flatpages from the dashboard (#121)
Date: Fri, Mar 16, 2012 22:07


> +from oscar.test import ClientTestCase
> +
> +from oscar.apps.dashboard.users.views import IndexView
> +
> +
> +class PageViewTests(ClientTestCase):
> +    is_anonymous = False
> +    is_staff = True
> +
> +    def test_dashboard_index_is_for_staff_only(self):
> +        response = self.client.get(reverse('dashboard:page-list'))
> +        self.assertTrue('Password' not in response.content)
> +
> +    def test_dashboard_page_list(self):
> +        fp1 = FlatPage(title='title1', url='/url1/', content='some content')
> +        fp1.save()

This is a tiny thing but I prefer to create objects with a single expression rather than two.  ``...objects.create`` is normally how I create objects.

Eg prefer::
    
    fp = FlatPage.objects.create(title='testing')

over 

    fp = FlatPage(title='testing')
    fp.save()

--- 
Reply to this email directly or view it on GitHub:
https://github.com/tangentlabs/django-oscar/pull/121/files#r567428
Hm, how does dropping a playlist on a listening room work? Just takes the tracks? Might make sense to disallow that
this is already set in key store, no need to store again
Can we replace all "assert" with "self.assertTrue(...)" instead?

I do sometimes use regular "assert" in amongst all the "self.assertTrue" statements. It tells the reader that it's not really a *test*; it's more of a pre-condition.
Maybe you could do a similar check in the RedisProfilerStorage::getRedis method to give a decent error to people instead of a missing class Redis.
you use a #{form} tag.  the inputs of the form tag get mapped to the parameters of the controller it targets.  so you get all this info that describes a controller, wrapped up in a form and submitted via a post request to a controller.  the inputs of the form become the parameters of the controller.  then in the controller you say Event e = new Event() and pass the info to the event constructor.  Then you say e.save() to put the event in the database.  Look around at some of the other controllers and html people have written.
why did we need to move the .css? Shouldn't it stay in stylesheets since it's a stylesheet?
The only issue I have with that is that order matters, though I believe that would only be an issue in ruby 1.8 which unlike ruby 1.9 does not preserve order of the keys.  To be nice to any ruby 1.8 die hards, that would mean callers should pass in something like ActiveResource::OrderedHash which feels uglier to me.  But if that is more rubyesque, I'll change it...
Аналогично с body.
А при других исключениях программа будет просто падать?
Два пробела и пробелы после ,
Происходит исключение в интерактивном режиме, и приложение прям-таки падает?
Ок, допустим. Тогда надо делать большой try .. finally.
У тебя нет тестов на аннотации ```@DoNotProxy``` и ```@Collect```. А ещё сделай тест, в котором проксирующий метод выбрасывает исключение (RuntimeException). Причём надо проверять, что в вызываемом коде именно это исключение прилетело.
Передавать как cause...
Имеет смысл ставить final для неизменяемых полей.
Would be awesome if we can do something like require_directory/require_tree for the partials but I didn't find anything.
I think there's a problem here. `toolId` is never used.
I'm not sure why needing the Bukkit API is an issue
Since adding a review and seeing all reviews are on different pages, I prefer to keep them separate for better readability.
<code>self.selenium.implicitly_wait(0)</code> disables the implicit wait and makes selenium return the result immediately.  But then you use <code>WebDriverWait</code> which is redundant. Enable the implicit wait and do not use WebDriverWait, or better yet just use <code>not is_element_present</code> in your tests.
manage_status.py:42:57: W292 no newline at end of file
既に日本語化されてる箇所にならいました。
http://grails.jp/doc/2.0.x/guide/theWebLayer.html#understandingControllersAndActions
Required: Remove this or add a comment because it's not being used.
or is this a ``..seealso``?
Yeah we don't offer that functionality in the old webui.
We not use the `ActiveSupport::Deprecation.warn`?
If you put HTTP verbs between brackets, it will highlight them (and we can link them later on)..  so, like  [PUT], [POST] [PURGE], etc..
use_sequential_strong_rule if last_alpha is not None and last_alpha > alpha and len(last_coef.nonzero()) > 0:
Yes indeed. I removed it entirely, it's no use.
Hm, can this be more refactored, so that we don't have code within the catch-block that actually controls the program flow? I didn't check the context, just the diff...
I miss return statement here. You declare it as boolean, but I don;t see what you return
Isn't this a terrible requirement?
Can't we reuse the information from the Query?
I don't think so. If I did, the key file would also need to change. But using an unsigned is valid if that's what the ECL programmer wants to do.
Shouldn't there be a corresponding change that writes the value?
Hmm apparently it does not,  I'll look into this a bit
Updated to use shared instance with [d0f39c8](https://github.com/EvanDotPro/zf2/commit/d0f39c86bf0778fd914e1c9239736940b70ad514).
Instead of this big nested if, I would do
```
if not self.user:
    return False
````
to start. Flat is better than nested :)
Aren't all tests looking for expected behavior? I'd go with `GroupPermissionCacheTestCase`
この行は要らないのでは?
If we're using a FSM, we should use it all the way - special casing just screws you up when you need to modify the logic later.
tho the helper function has if statements so I'm not sure it's that much better
Please wrap this...
I'm really curious to see how much this function shows up in on-device profiling, but that's not a concern for now.
Yes, it can.  Typically a SSH module doesn't include Tcp, so that is registered manually.  But this time we don't need it because we use tcp for check().
Don't do this. Use ```print_good``` instead of ```print_status``` to get the ```[+]```
Yeah, originally I wasn't sure if aliasing system commands was a good or bad thing. I'll just drop the comment

-Josh

On Aug 10, 2012, at 15:51, jlee-r7 <notifications@github.com> wrote:

> In lib/msf/ui/console/driver.rb:
> 
> >  	#
> >  	def unknown_command(method, line)
> > +		# what should take precedence sys commands or console aliases?  We go with aliases for now.
> Definitely aliases, otherwise aliasing a system command has no effect, right?
> 
> —
> Reply to this email directly or view it on GitHub.
>
This would create the array twice. The range does not matter for template matching which is implemented as cross-correlation.
Also note that `PolynomialTransform` defines `_coeffs` (two "f"s). Change one or the other, for consistency.
Hmm not sure, I think it looked weird with the style.
So after thinking about this, my feeling is that for tests that passed today, we should leave defer out and add it later if necessary. It's much easier to see that defer is necessary and add it than it is to see that it's unnecessary and take it out.
I'm curious, does this really need distinct? I wouldn't expect this to return multiple categories...
Can't this just be a public property?
Actually that's a good point and even there's something else if someone wanted to use new cache role other than the one that was used before what our code should do. Filed #506 to track that
its a logging level issue.  In general the build output is at a verbose log level.  The default stdout log level is only at "normal" but all levels get written to the log.
This (and the following line) are printed entirely in italics in the generated HTML, due to the `*` characters. There may need to be an additional newline delimiter to distinguish them as a list, rather than a single line.
In the case where there isn't a code snippet,  getJSCode() returns an empty string which would have a length of 0.  In that case, we still want to call eval instead of clearInterval().
I don't think  "Such as inside an array" adds anything here--just "If the application depends on the annotations being in a set order, it should keep references to all of the annotations in a separate array."
Yeah, a number of those could return null.  Since we essentially just use the 'parent' that we pass into getDefault() to create a window manager, we can just pass in any view from the activity.  We can use something similar to convertUnits():

View view = TiApplication.getAppCurrentActivity().getWindow().getDecorView();
default makes no sense here since this is a dictionary
actually, this is to try and offset network overhead for timeout.  When a timeout for a test is set I wanted to leave some room for network traffic that ideally wouldnt eat up time out of the "real" timeout.  adding a comment
Some story as with ACML, depending on whether MKL is used with the Intel compilers or GCC in a toolchain, you need to do different things.

But again, this could be factored out into the GCC/Intel toolchain compiler modules to make things truly modular.

In the `IntelMKL` module, you could then just use a constant like `MKL_INTERFACE` or something, that was defined in the compiler module.
Otherwise I get the following error :
Fatal error: Class 'Lexik\Bundle\TranslationBundle\Translation oader\DatabaseLoader' not found in /myapp/www/app/cache/dev/appDevDebugProjectContainer.php on line 1307
either you always transform from an array to an array (meaning you should not use ``$recipients->count()`` but ``count($recipients)`` or you return an ArrayCollection when reverse transforming
Sorry if my tone made it seem like I'm hurt, I'm not hurt *at all*. Thank you for your comments. I was just worried that as I on't hav a lot of time these days you would get blocked because of waiting for my answers. I'm just saying (sincerely): Feel free to get this out of my hands (= I don't really want the responsibility right now of making sure you are right).
As far as I can see (as I also said) you are more knowledgeable on this one so I would really *love* for you to be able to go further without me having to look into it right now. Plus I'd gladly come back and review it in one or two weeks time.
I was just worried you would get blocked by me not acting on your review :-)
So when I'm in this situation, where I want to keep values in a closure from inside a loop, typically for clarity I put the scoping function `(function() { ... })()` immediately inside the loop instead of only around the individual uses of the values. I think that might make this read clearer.
sp: "...rewrite the `<b>expression</b>`"
Hmm, there's certainly some merit to your argument. In particular, I might want to do something else when a section is added, and an array provides more than one way to add elements, so if I overrode the << operation, then I may need to also override push, +=, etc.

Also, changing the name to ContentPage certainly helps clarify that it's not just an array of sections. I never liked the name SectionSetPresenter, but I wasn't really sure what a group of SectionPresenters actually *was*. 

I'll go ahead and make that change.
Not fit on one line? It only goes to 79 characters if it's all on one line. The line limit for Phobos is 120 characters. If it were passed 80, then it gets debatable whether it should be on one line or split up or whatnot, but it doesn't even hit 80.
Functions like `move` and `emplace`.
I think that

> $(D popBackN) will behave the same way except that it will pop off elements from the back of the range instead of the front.

would be better. I'd avoid saying anything about the right-hand side, because ranges don't necessarily have a right and left, much as we may often think of them that way - rather they have a back and a front - and at minimum, the comma before the but needs to be removed. I think that my version is better though (then again, of course, I'm more likely to prefer my version, because it's mine).
If this comparison passes, no more need to check for empty against the needle.
```
@commit = Bugwatch::Commit.new(stub("Grit::Commit", :committer => stub(:email => "committer@example.com")))
```
These both should be `void` and prefixed with 'dispatch'. This way all of the logic lives inside of the `ActionBarSherlockCompat` class and reduces duplication in activities.
@nallar, no, I was talking about `Objects.equal(is.stackTagCompound, stackTagCompound)` because it could happen that both stacks' NBT would be null.

I just checked the google javadocs and solved my initial doubt. If both parameters are null, that would return true.

http://google-collections.googlecode.com/svn/trunk/javadoc/com/google/common/base/Objects.html#equal(java.lang.Object, java.lang.Object)
このcaseに対するelseがないね。

elseはなにも処理しなくていいのか、書き忘れなのかわからなくなるので
```
else
  # do-nothing
end
```
とかしておいてほしいです。 see プログラミング作法
I think the license header here is duplicated?
ClassNotFoundException
This is also supposed to be unindented?
FreeBSD:

<pre>
[hal:~]% su -h
su: illegal option -- h
usage: su [-] [-flms] [-c class] [login [args]]
</pre>

yeah, that will break horribly....

Yes, it needs a patch for sure.
Moved the check for Admin Group pricipal up into super class.
Oh, right, so the escaping of \' is inconsistent between the PHP and YAML files... annoying!
I did this so that if a new `.bigTimeGraph` enters, it will have everything that is needed.

We don't support this right now, so I'll limit it.
this use statement is useless
I'm all ears for a better pattern for these on DOM ready stuff in all the .js files. Let's chat.
These two are again things I will have to investigate and possibly change upstream. If things are broken or we're adding functionality that shouldn't be a problem, but if we're just changing things to fit our design it might be a harder sell. I'll investigate and we can talk about it tuesday.
Fait pour la réinitialisation de la liste.
La partie suivant de recueil de la profondeur du mot n'étant utilisée qu'à cet endroit, je n'ai pas jugé utile de le placer dans une méthode :

```java
complexDepth = 1;
while (yytext().charAt(complexDepth) == '*') {
    ++complexDepth;
}
```
It for 64bits but isn't for 32, you are right.
@alexrp: are you saying you just want a change of name? (1) I'm glad this is the only thing that's under debate! (2) Although I understand your argument, I personally think `NullPointerError` is better than `InvalidMemoryError`.
The JMX issue was when you were talking about cloning the CCF.

If you WRAP the CCF, it will have no impact on JMX; the user won't even know we're wrapping it.

I don't know all the gory details; I was just expecting to see a relatively lightweight wrapper not a new class; but I don't know how practical that is.
> Here we have thousands of points and .each can be much slower than for. Google it.

Then add a comment explaining why in this case we are using it instead of more verbose (and easier to understand) `.each`.
So all object[constant_string] can be converted to object.constant_string.
IMHO this redaction is best "The most simple way to use transport is the ``Mail\Transport\Sendmail`` class"
'will use' => 'will need to use'
Could you change these to be paths off JPATH_PLATFORM. Else this is maintenance heel when we move files around.
Yeah... I'd be good with striking this line if that's cool...
Let's go with APIInjector instead of ApiInjector (not quite proper camel case, but it's the style generally used in timob).
filter.value は Any にしたので toString.isEmpty なら書けました。
ですが そもそも空文字で例外はおかしいかなと思い、if文ごと削除します。
値の制限は DAO の toBy メソッドでやってます。
どうでしょうか。
Are the quote examples somewhere else? These are probably the most important thing on the page.
I don't get it: isn't the action_label already is a translated string in the CRUDController?
Why?  Are we 100% sure that all use cases would want it to behave that way?
ok it's clean as a whistle now
It's just a default setting. If they're not using that model, they have to set the setting.
Remove one line here
Por qué como Strings? No entiendo la motivación para esto. Quiero decir, si el atributo es un string es un string, sino, no... Cuál es la necesidad de devolverlos como Strings?
Shouldn't this be a testable=false test and use @ArquillianResource URL to inject the URL to the target webcontext
In we do that we probably don't need to push stuff into an array and join it later, just concat a string.
title should be sender?
There's a lot of Http going on.  Would not ServletHttpRequest do?
This line was causing the passcode creation flow to occur twice. The handler already takes care of popping up the creation flow.
please do not use exceptions, they are may not be supported in the future and they are slow, also see BB10 coding guidelines which recommend against not using them, use error codes instead
can you fix these to use the Json::FastWriter().writer syntax, as well?
can you say what was null?
Controller should have no logic, just translation to and from web request/response.
Oki doki...
you miss the confirm message