labofsahil/github-event-dataset-2012 huggingface dataset:
Ok, here is what I was thinking - https://github.com/hferentschik/hibernate-search/tree/HSEARCH-1045
I haven't cleaned it up yet and maybe it need a testcase. WDYT?
Note test in this commit from Chile!
No, you wouldn't need to specify an equivalent configuration in the manifest if the ```BasicLogcatConfigurator``` achieves your goal already. If, for example, you needed a different message pattern, then you would have to use an explicit configuration to meet your needs.

If you don't specify a configuration anywhere, then the ```BasicLogcatConfigurator``` automatically takes effect. This is the same behavior as the ```BasicConfigurator``` from the original Logback, which uses the ```ConsoleAppender``` instead.
嗯，记得在哪儿看过，可以在view里写成类似``` params[:contact][:phone] ```的样子，返回后，controller里可以用``` params[:contact] ```拿到这个hash去``` Contact.new ```, 不是contact对应的controller也可以的。关键在view，好像agile web dev里有类似的。
Having issues. The Ice Tomb LoS is no longer working.
Emotes: http://www.emoji-cheat-sheet.com/
Looks good. One concern I have is code duplication between the vertical and the horizontal tree/DAG layout.
work perfect, 3x!!
I just  got ahead of you:) (that is why you got the merge commit, rebase is your friend:)
that mean, when a typo is corrected, the application work better (or the function is working fine) =)
To improve record packing (not very significant in this case) it is worth putting the array before the isStoredFixedWidth member (actually before the keyedSize is best in this case).
Can you explain in more detail what you think will potentially go wrong?
This dependency seems to be a more recent version of what's in the js-engine.jar file: http://uk.maven.org/maven2/com/sun/phobos/phobos-js/0.6.2/
Hi Harald,

comments inline
> - Adding a snapshot repo is dangerous. If we forget to remove it, it'll leak into the next release version on Maven Central.
I'm not sure I follow here. Maybe I just don't see the point but how can 
a repository leak something
And without I wasn't able to do a full rebuild of the project.
> - We should also remove the ops4j.3rdparty repo
> - Any particular reason for disabling pax-url-itest?
oops, how did that sneak in there :)

>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ops4j/org.ops4j.pax.url/commit/ff3c82a269251c8b4dc947af217d3675b4ef391b#commitcomment-919544


-- 
- Apache Karaf<http://karaf.apache.org/>  Committer&  PMC
- OPS4J Pax Web<http://wiki.ops4j.org/display/paxweb/Pax+Web/>    Committer&  Project Lead
- Blog<http://notizblog.nierbeck.de/>
мне кажется я комментировал похожий код:
сейчас у тебя три роли: гость, пользователь, админ. Здесь ты выводишь линк в админку только если текущий пользователь Админ. С одной стороны вроде логично, но с другой, что делать если захотим добавить новую роль (например moderator or manager) с ограниченными администраторскими правами? Мы вынуждены будем лазить по всему сайту искать и переписывать такие места.
У тебя в абилити есть замечательная строчка can :access, :rails_admin. Так почему бы не проверять здесь по этому абилити: can?(:access, :rails_admin)
Таким образом мы будем группировать всю логику по правам доступа в одном месте (ability.rb) и облегчим себе жизнь.
Yeah, using namespace shorthands is still planned, though it might not make it in version 1.0. I think we could easily add them as soon as we see that the whole concept works out :)
First really new feature since SWIFT. In SWIFT, you could draw lines but I never really got the simplification algorithm working right - so they were really slow.
This check isn't needed BUT the block complete block have to be executed AFTER registering the plugin.

Also on using jquery 1.7 you get an js-error "$('.jquery-thead').thead isn't a function" because it will be executed before register.
This breaks the build on my system:

$ scons 
scons: Reading SConscript files ...
SCons is version 2.0.0.final.0 using python version 2.6.6
Python is from /usr/include/python2.6

Using compiler: g++
compiler version: 4.4.5
Determined that a good number of jobs = 4
Checking for C++ library cfitsio... (cached) yes
Checking for C++ library fftw3... (cached) yes
Checking for C++ header file boost/shared_ptr.hpp... (cached) yes
Checking for C++ header file TMV.h... (cached) yes
Using TMV_LINK file: /usr/local/share/tmv-link
     -ltmv -lcblas -lpthread -fopenmp
Checking for correct TMV linkage... (this may take a little while)
Checking for correct TMV linkage... (cached) yes
TypeError: not all arguments converted during string formatting:
  File "/home/joerg/src/GalSim/SConstruct", line 960:
    SConscript(script_files, exports='env')
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 614:
    return method(*args, **kw)
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 551:
    return _SConscript(self.fs, *files, **subst_kw)
  File "/usr/lib/scons/SCons/Script/SConscript.py", line 260:
    exec _file_ in call_stack[-1].globals
  File "/home/joerg/src/GalSim/src/SConscript", line 78:
    env1.Replace(SHLIBSUFFIX = '.so.%s'%version)
Really good. I Tried it and it seemed to have no issues.
Ett bra första utkast.

Nästa steg blir att inte upprepa DB credentials i varje skript (DRY)

Eftersom värdena skickas med Ajax så behöver vi meddela att resultatet godkänts enligt regler som max- och min-värden eller om det förkastats.
to make this more testable, you could weave in something like Map<NetworkType, Function<CloudStackTemplateOptions, DeployVirtualMachineOptions>

the function could then hold the logic below.

so the usage would be..

checkState(optionsConverters.containsKey(zone.getNetworkType()), "no options converter configured for network type %s",zone.getNetworkType());

DeployVirtualMachineOptions options = optionsConverters.get(zone.getNetworkType()).apply(templateOptions).displayName(name).name(name);


Test wise, you can easily test the functions without mocks or anything.  You'd weave this in by adding in something like this to the CloudStackComputeServiceContextModule:

\@Provides
\@Singleton
 Map<NetworkType, Function<CloudStackTemplateOptions, DeployVirtualMachineOptions> optionsConverters(AdvancedNetworkingOptionsConverter advancedNetworkingOptionsConverter, BasicNetworkingOptionsConverter basicNetworkingOptionsConverter){
   return ImmutableMap.of(NetworkType.ADVANCED....
So that objects that get hit by a bullet show reaction of collision.
Why do we need SetRate() in IAudioSink?
 Only TimeStretcher needs to know the rate.
only that
This change is wrong.  FileMunger plugins do **not** need to have a `munge_file` method.  They must have a `munge_files` method.  The role provides a default implementation of `munge_files` that does require a `munge_file` method, but a plugin can provide its own `munge_files` method instead.
Ooh, webhooks are shiny.
I am trying to be faster than pypy ;)

On Saturday, January 7, 2012, Olivier Grisel <
reply@reply.github.com>
wrote:
> @agramfort do you have a python interpreter in your head that scans
through any github notifications?
>
> ---
> Reply to this email directly or view it on GitHub:
>
https://github.com/scikit-learn/scikit-learn/commit/54fcfc2da3ca7a8a4e5f5fe6de60147eaa3ddf2c#commitcomment-846213
>
I am not sure whether this is correct or not. But the fix is working with XAMPP.  Please review and take accordingly.
Regards,
Dinesh
Yeah that would be my next attempt (when I get to it)... probably not a
text file though, but yeah, saving it to a binary file would probably be
the easiest way to go about it. We could then easily implement save game
functionality after that.

On 8 March 2012 11:10, Pigeoncraft <
reply@reply.github.com
> wrote:

> let me reword that cause that sounded terrable instead of saving in inside
> of the apk could you save it to say a txt out side of it.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/shawntan/minicraft-android/commit/0dc725b5def8941b51742f6cb9a7ecc98495c175#commitcomment-1056836
>
wow good job figuring this one out!
Well browsers allow it because it's not an octal literal. It's a valid decimal literal. But if we disallow numbers of the form `0[0-7]+` and allow numbers of the form `0[0-9]*[89][0-9]*`, it seems to defeat the purpose of disallowing octal literals that are not very explicit (`0o` being *more* explicit than `0`).
Oh, and BTW: The above line can be written more concisely as this.closest('.cms-content')
passing in apps as explicit array -- is that to leave room for future params, i.e. `run(apps, opts={})`  ?  or something else?
![THEY WANT TO VAPORIZE OPERA! GET CHROME.](http://i.qkme.me/3647d0.jpg)
don't touch the lowmemorykiller values.

default to vanilla CM7 (android_build's init.rc) values
If the schema enforces, that's OK.
hmmm, "All other ports use "Kernel code" to identify the Kernel text segment in /proc/iomem" look like they followed the wrong doing of other ports...
Then we run the risk of double rendering. The way it is done now will exit the `show` method if a user is required but not logged in.
I can't view this photo. I guess there is another way
Ya I know... But this was the closest alternative that I could find...
On Feb 9, 2012 5:37 AM, "hayashikejinan" <
reply@reply.github.com>
wrote:

> >> Doom
>
> I know the vision_oc
> but 2011 xperia don't have "acpu_freq_tbl" in their kallsyms ...
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/hayashikejinan/active_Th_kernel/commit/08ee97c9eee66ecf79d8709073cb7d8b1009ed00#commitcomment-947626
>
O Rails não sabe o que você quer fazer se você não disser a ele. Tem que modificar o controller, pegar o params[:periodo_letivo_id], selecionar o período letivo e filtrar as disciplinas de acordo com ele.
Cool, hadn't heard of that! Still favor the more decentralised, 
stock-WordPress approach though I think. Learning tools should be as 
close to real-life working tools as possible IMHO.
can this be JSONObject so you don't need a cast on line 59?
There is some build errors  http://pastebin.com/J8E1iGHK
About the duplication in FaultGeometry: I agree, I noticed the duplication but I expected there was a reason for it (I expected that FaultRuptureGeometry could be different from FaultGeometry in future extensions). Since this is not not the case I am putting SimpleFaultGeometry and ComplexFaultGeometry in general.xsd so that there is no duplication.
I think you should only use Markdown to format API docs in the JavaScript source files. The HTML is hard to read in the text editor.
widget._groups might be a better name
No clue. I can't think of any technical reason.
You're right. That's unfortunate. Wouldn't suggest cas-server-core. You would either have to copy the code as is, which I don't favor that much, (duplicate code, ugh!) or evaluate the current memcache integration module to explore refactoring options. I suspect that there are similar tests there that effectively try to do what you're doing here with the clearpass memcache impl. There might be an opportunity to identify reusable components from the existing tests.
I'm not sure about the naming here, these should be named as domain events, i.e. past tense
`MemberBecameUnreachable` but thats rather long
thoughts? suggestions?
Maybe be explicit about that `off-for-windows` means `on` for all other platforms.
addresses.head is scary, since that is a `Set`. We should have something like `defaultAddress` or `primaryAddress` which corresponds to the transport configured first in the config list.
good suggestion, thx
Even better, I was able to just use the various boto.exception classes to parse the response:

``` python
error = BotoServerError('', '', body=response.read())
return error.error_code == 'ExpiredToken'
```

Still testing the changes, but should have something shortly
Renamed with the move of this set of methods to a different namespace.
I'm not sure what you mean, oh, you mean put redirect_id = inside each case.

I think you could argue for either form, I like fewer tokens better.  Unless the clauses grow too big, to where they don't fit on a screen with extra code for context ...
Good point. You need mricron for this.
can we use np.linalg.norm for multiple coords, or not?
This was an issue with groups not sure if it is here I'll need to investigate more
This might not be enough.
As I said, before_view must be split into two different methods.
One for displaying a list of datasets.
One for displaying one single dataset.

Maybe we should distinguish between elaborated lists of datasets (search) and slim lists (dashboard).
In the current implementation I think anyone who is a member of more than one org can move a dataset between orgs
It was a great test. :)
Would append toList or toSeq here so we could avoid the many toList calls in added and removed
Bear with me, here's my research/evidence so far

It must be ProcessRenderLoop(false). This calls g_application.Process(). This in turn calls ApplicationMessenger::ProcessMessages(), which is where the TMSG_GUI_PYTHON_DIALOG msg is processed.

I replaced this line with g_application.getApplicationMessenger().ProcessMessages() and it was sufficient to fix the problem, so at the minimum we need this.

jmarshallnz mentioned we might need ProcessWindowMessages() too for TMSG_DIALOG_DOMODAL msgs, this function is also called by g_application.Process(), but we were hesitant to start picking the render loop apart.

However, once upon a time, I encountered reentrancy problems because an event handler called ProcessRenderLoop(false) which processed another event with the same handler, and this went 2 or 3 levels deep causing a memory leak that ultimately turned my addon into a texture. Not so good.

I can try to see if this line generates reentrancy problems. But first, I go on a bike ride :)
That's fine then.
(anything with a [] around it so for example [ticket]s or [person] signifying another model)
If you're only using this once, you can just define it as a function inside a function.

Also, for sorters we usually go for lambdas:

by_startdatetime = lambda job: job.get('startdatetime', a_default_date_perhaps?)
sorted(job_flows, key=by_startdatetime)
Good warning.
Please format like:

Args:
- x
- y
... readSchemaTuple " + type);
Looks like we're using this block instead of the configurability block I put in - should remove it from ion-defs.
The reason why I removed this as a runtime dependency is that people like me might not use it at all and the gem would be loaded for no reason. I'd say we should remove it as it will be included on the generated `Gemfile`
this should probably use the class constant to avoid issues if the values are changed
Which interface? `wcf\data\IDatabaseObjectProcessor`? You can't implement that interface and extend `wcf\system\SingletonFactory`.
Your @ya.ru entry refers to the author email you used (or I used) in commit e9d2822efbdc55373a4d83e3488bd90f1ab10812. This line makes sure that you show up with your @gmail.com address in the `git shortlog -e` command.
I got what you mean, what about something like:


`pgvm` has the following dependencies: 
* `git` in order to get PostgreSQL trunk version
* `bash`
* ...
* ...
That would be Uint32Value(), all other coercions are either signed or not an integer.
No, skip that. I guess it doesn't matter much from an end user perspective.
Always do this. If `symbol_len` does not include the terminating null, you might end up with an unterminated string.
I misread this. Please rename the inner callback variable to something like "done" or "cb" to make it easier to distinguish from the outer callback.
<samp>mode == "rsync"</samp> is better here
в имени метода должен быть глагол, определяющий суть метода. надо переименовать все такие методы генераторов
Yup, and thrown in an `attr_reader` for it.  `Rails.queue` is the "default" queue.  We (at work) need more than one queue (different emails, image processing, etc), so I'd like `Rails.queue` to be the "default" one, but something we can easily change.
This change does not break tests. ?
Thanks your sample codes.
I'll modify my PR.
I think we need a different error message when one uses `assert_recognizes(expected_options, path)`, and the path is a redirect. For example, if you have the route `get '/redirect' => 'http://example.org'`, and an assertion `assert_recognizes({:controller => 'redirect', :action => 'index'}, '/redirect')`, the assertion will fail; however, the error message is of little help: `The recognized options <{}> did not match <{"controller"=>"redirect", "action"=>"index"}>, difference: <{"controller"=>"redirect", "action"=>"index"}>`. Thoughts?
Concatting strings without an operator = :(

One-line deprecation warning is clearer than splitting the line at all.
I guess we shouldn't call `html_safe` here. This will make this code vulnerable to XSS Injections. Only call the `capture(&block)`.

Is user responsibility pass only html_safe content in the block.
https://github.com/twitter/util/blob/master/util-core/src/main/scala/com/twitter/util/Try.scala#L133
I'm unsure of removing it, mostly because I'm not completely certain why it was added in the first place. I imagine that it improves readability in some important use case at Twitter (as, in general, uses of `flatMap` can get obscure at times). Maybe @mariusaeriksen could chime in? In any case, it's quite harmless, and perhaps it's nicer and clearer to read in application code-- that merit might outweigh the mere actuality that it's an alias.
I had a little trouble following your characterization of the situation. Let me say what I think, and you can tell me if you disagree somewhere.

- A Select node should never have name NO_NAME. There should be an assert to this effect in Select.
- It is always a bug to try to create a Select node based on a Symbol if the Symbol is NoSymbol.
- It is fine for a Select node to have NoSymbol as its Symbol, as long as the tree has a name which is not NO_NAME.
- It is never correct to reify a Select node with NO_NAME as its name. (This is of course a consequence of the first point.) If it has a Symbol, use the name of the Symbol. If it does not, use the name of the Select tree.

The two buggy cases I show above should be handled at the call sites, by not calling Select with NoSymbol and dealing with the error in a way appropriate to the site. As far as I can see, after that's done the assert can be added to Select. I don't know what changes might be required in reification.
How does this differ from isHidden? As far as I can tell, this is trying to be isHidden with a different name.  Just expose isHidden.
As well as the tests ;) I just want to confirm `li3` or `lithium` as the official composer type lithium wants first.
All the Series implement get_points. Hence added the alias for uniformity.
What if it is a scalar*Operator?
You seem to have an extra space in `(amp * up )`.  (This is minor.)
Rename to `_generate_tensor_prod` to be consistent with our naming.
Not sure of what is intended, but...
```
>>> expand(((1 - c**2)**5 * (1 - s**2)**5 *(c**2 + s**2)**10).subs(c**2,solve(c**2+s**2-1,c**2)[0]))
-32
```
Ah, I see that you are using matrices. Let me instead suggest that you look into the ```Matrix(rows, cols, function)``` construction method. Search the MatrixBase constructor for lambda.
Changed naming from lambd to lamda
Pure equality checking will not be sufficient here, because they could come out mathematically the same but in different forms. You should use something like `simplify(dfdx - dfdy) == 0`
@qiangxue But if it fails it fails for a reason, shouldn't such a situation be alerting rather than "hidden"? I'm sure there's a reason that @ is/was there, I'm just curious about the reason for hiding the potential error.
Do we have a story for this?
Would be useful here to reuse the lint properties, ala `files: '<config:lint.files>',`, see https://github.com/cowboy/grunt/blob/6b320d759866f2e244c591cc888cb6878008bcb6/grunt.js#L25
Needs a "Returns" section in the docstring, as does `lst` below
I was talking to Ant about this scenario earlier on, and also about the scenario where you set a breaching limit via the config API (for which there currently is no validation). It seems that we may need that we may need to introduce the concept of limit setting and checking as more of a first class concept. I think there would classes of resources that you can configure yourself up to a certain limit, and then you have resource usage (i.e. the notion of transactional usage) that you need more of a dynamic check for. In any case, there are going to be things that are read-only for a domain, I would think. Limit settings would presumably event out notifications when they change.

Given that, do you see a more acute need to address a subsequent limit lowering in this patch, or can this get pushed out to a different ticket?

On Apr 16, 2012, at 21:14, Paul Jones<reply@reply.github.com> wrote:

>> @@ -142,8 +142,8 @@ case class PairDef(
>>   @BeanProperty var scanCronSpec: String = null,
>>   @BeanProperty var allowManualScans: java.lang.Boolean = null,
>>   @BeanProperty var views:java.util.List[PairViewDef] = new java.util.ArrayList[PairViewDef],
>> -  @BeanProperty var eventsToLog: Int = 0,
>> -  @BeanProperty var maxExplainFiles: Int = 0) {
>> +  @BeanProperty var eventsToLog: Int = DefaultConfigOption.DIAGNOSTIC_LOG_BUFFER_SIZE,
> 
> Doesn't defaulting these here mean that if the system limit is changed (to something lower), every pair will be considered in breach unless it has its value changed?
> 
> Could we not introduce some kind of value here that means "use default" - such as perhaps making this a java.lang.Integer, and therefore optional?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/lshift/diffa/pull/104/files#r691047
build old style indexes? 

    Build Indexes for 1.8 ``mongod`` instances with 2.0 ``mongod`` instances.

the filename should probably be `build-1.8-indexes-on-2.0-mongod-instances``
On Monday, December 17 2012, 15:57:50, Bob Grabar wrote:

>> +
>> +Beginning with version 2.0, journaling is enabled by default for 64-bit
>> +platforms.
>> +
>> +To enable journaling, start :program:`mongod` with the
>> +:option:`--journal` command line option.
>> +
>> +If :program:`mongod` decides to preallocate the files, it will not start
>> +listening on port 27017 until this process completes, which can take a
>> +few minutes. This means that your applications and the shell will not be
>> +able to connect to the database immediately on initial startup. Check
>> +the logs to see if MongoDB is busy preallocating.
>> +
>> +Disable Journaling
>> +~~~~~~~~~~~~~~~~~~
>> +
>
> Sam, What warning is needed here?

"Do not disable journaling on production systems. If your MongoDB system
stops unexpectedly, as the result of a system error, power failure, or
other condition and you are not running with journaling; you must
recover from backups or re-sync from an unaffected replica set member."
(Link: recovering from unexpected shutdown.)
It returns `()` (unit).

The difference is actually between the `for` and the `do`. If you changed this one to `do`, you'd get

```
rustc fizzbuzz.rs
fizzbuzz.rs:2:27: 4:3 error: Do-block body must return bool, but returns () here. Perhaps you meant to write a `for`-loop?
fizzbuzz.rs:2   do [1,2,3,4,5].each |&i| {
fizzbuzz.rs:3       io::println(int::str(i));
fizzbuzz.rs:4   }
error: aborting due to previous error
make: *** [build] Error 101
```

Maybe making a bigger note of this is a good idea here.
It gets the cache and information about the poster which allows the extension author to add buttons in the template. Same as the next one. They both do the same thing except this one is for guests, the other is for registered users.
`its` -> `it's`, same on the two lines below.
It should work though until migrations is actually merged.
I see absolutely nothing wrong with this and have no idea why you have an issue with it. What's wrong with it?
Use DirectoryIterator instead.
Also, all of these should have a doc block.
You should use `Buffer.byteLength(post_data, 'utf8')`, otherwise it won't work correctly if a string contains non-ascii characters.
We gotta work on your pull request size. They are too big and conflate too many issues. For example, changes like above have nothing to do with adding a cache, and could probably go in much faster, which is desirable for things that effects lots of files.
fixed in 1e96cd2
We can't allow self redirections, no can we?
Discussed, should be removed.
Yeah I totally agree. I've actually just been messing around with it as an easy way to test out the actual code.
You can make the `key` arg optional for `[]`, but not the value parameter optional on `[]=`--there `object[key] =` is incomplete syntax on its own.

That said, now that I'm looking at these closely, I can see that these default values act as flags in the methods so that they behave differently.  I generally prefer to make my methods do only one thing and simply make another method that does the other thing.

So, you might provide a `#to_hash` method in place of `get` (with no arg).  I think `#clear(option)` rather than `set(option)` is more intention-revealing as well.
Since a single resource can have both.common. and .client. versions, I think this needs to be done differently. I think we should first walk common version, then walk client versions, so that the metadata about client version clobbers (has higher priority than) metadata about common versions.

Actually, this shouldn't be "common and client" but instead "common and env (current runtime)".
Added a bug to ensure we (later) validate this more securely.
https://raxaemr.atlassian.net/browse/RAXAJSS-334
Style: Please be consistent in your naming ('Refer-To-Doc-Panel' vs 'labresulthistorypanel' vs 'patientlist-show'). camelCase for var names. https://raxaemr.atlassian.net/wiki/display/RAXAJSS/Code+Style+Conventions+for+JavaScript
Looks a little long to me.
See lines 204, 212, 215.  they are all invalid endpoints and the error messages have a bit more info about why it's invalid.

Not too keen on putting into functions.inc... are you saying just a wrapper function to save some keystrokes?  Maybe \Sky\Reflect is a better place.  You'll have to explain how it will be helpful with traits.
I think it may fail if one process is overwriting the source code file that another process is currently compiling.
All of the tests below would be much improved by annotating each "Insert" with a comment like "// this row will appear in the result" "// this row will get eliminated from the result by/because ..." "// this row will eliminate row ...".

As is, verifying the expected results by code review is difficult.

Also, unless there is some HSQL bug we need to avoid, there should be an HSQL_BACKEND configuration that shows the same results -- at least for the non-error cases.
Yes, it should be here. I forgot to uncomment it as I test it without "limit 1" case.
It started out life as a more interesting format string, but got reduced until it no longer serves a purpose. It's a goner.
I know that for most cases there's gonna be only one PTR per IP address but just to be safe: we need an explicit ordering scheme here to be able to explain which PTR is returned.
Update doxygen comment when adding new parameters.
would we ever would to pass in arguments to this and use apply instead?
Big Design Up Front saves you so much time later on.  So glad to see Django embrace this! :shipit:
Noted, fixed in my copy
@gibson042 Done!
So, I think I'm going to go with implementing it in jQuery.ajax. Determining the correct method from the settings is the job of the ajax handling function, not of the settings handling itself.
Also, the quotes need to be flipped around, double on the outside and single on the inside
@mikesherov Done!
Isn't the proper format for a comment like this `// supports: IE8`?
What about  adding section [Make some changes](http://meteor.com/examples/todos):

## Make some changes

* Move duplicate code from  *client/todos.js* and *server/publish.js* files to the new *models.js* file.
Is that correct to be adding MonoGame and Lidgren assemblies for all MonoDevelop-supported platforms, but only one OpenTK, Tao.Sdl and sdl library?
Before every action is made I set a new TimeTicker if true.
I want to make a random delay before using a power.
If monster is a spawner - we got the a big spawning problem.
Typo "errors".
`!ARGV.include? '--no-framework'` is probably clearer than `not ARGV` in this line. ;) An `unless` formulation would return `nil` rather than `false` so not the right choice here.
When building just with #{prefix} the command doesn't recognize netcdf as a valid format. I saw this solution in netcdf formula, for hdf5 dependency, and then the command works as intended.
doh, I copy pasted from an outdated branch. I will fix this to what was originally intended:

```
  [:autoconf, :automake, :libtool].each {|d| depends_on d}
```
Well I think I found the answer to the `openjpeg.h` mystery.  I looked at it's source, and I found openjpeg can build with configure or cmake.  We use cmake.  So I switched to configure, and let it rip.  Guess what?  We get this:

    $ ls -l /usr/local/Cellar/openjpeg/1.5.0/include
    total 8
    drwxr-xr-x  3 nibbles  admin  102 Apr 10 17:07 openjpeg-1.5
    lrwxr-xr-x  1 nibbles  admin   23 Apr 10 17:07 openjpeg.h -> openjpeg-1.5/openjpeg.h

So I think we are building a crippled openjpeg by our choice of cmake (probably my fault lol).
The source's configure file sets the default prefix value to /usr/local when using aclocal.  I will add the variable to the build command for good practice:

```
  def install
    system "aclocal"
    system "./build --prefix='/usr/local'"
    system "make"
    system "make install"
  end
```
Do I misunderstand some basic css, or doesn't `.primary` make `input[type="submit"].primary, input[type="button"].primary, button.primary, .button.primary` irrelevant?

Otherwise good initiative :100: :+1:
Ideally Vumi should be installed from PyPi, so this should actually change to '$ pip install vumi'.
Above you say that you test if the file ends with a .js but here in the if statement you do not test this .indexOf('.js') === -1
Das sehe ich jetzt erst, da müsste die Reihenfolge ja eigentlich doch stimmen. Beim Cache löschen werden aber zum Beispiel die Ordner nicht gelöscht, daher kam ich auf die falsche Reihenfolge oben. Im master-branch werden auch die Ordner gelöscht.
closures.. die kommen einfach als obj vom typ closure daher.. keine properties, nix wie man sie auseinanderhalten und somit zuweisen könnte..
You don't need a condition here since `crumbs.clear` will work event if `crumbs` is already empty.
We should beef up the javadoc.  This "Matches if the first exception in the failure matches the given {@code exceptionMatcher}"
As i discussed similar issue with David, he likes explanatory tests. Yes, logger was an example of use.
I will remove it, and then comment again if you like it more. 
Okay.
Indentation oddity?
I only use triple compares when I want to be explicit on type comparisons, it's a very intentional thing for me.
I'm assuming you're providing the result from the getValue as a parameter to _getAdapter?  A cleaner way to show this would be dojo.hitch(this, '_getAdapter', store.getValue(item, 'adapter'));
change the regex to " grep -oE 'v[0-9]\.[0-9]\.[0-9]+' " to accomodate double digit version numbers.
the current stable version is already at "0.6.17" and this will not be displayed using the current regex.
fairly sure it's lazy - but i'm all about premature optimizations when necessary :P
I think this could be stronger - i.e. `stop` and "ggplot2 does not currently support the combination of ..."
I tried that and it appears to be listing the inherited params from `discrete_scale` second, after the individually listed params, which means the params are all out of order from how they're listed in the function. I'm still getting comfortable with roxygen, though, so I may be missing something simple.
So many stars... Looks like a galaxy !
Sometimes I pull down the else so the branches look less packed.

I'm kind of an asshole of a maintainer.
The problem with including these plugins in the default config right now is that any templates using them would need the CSS pages and various editor helpers included with them.

I think it's best to leave the default config using the base plugins we have in Popcorn.js and leave it at that.
Why do we need this?  Why not just use the one in our tree?
This means 0 resolves as true. This is only false if it is null or undefined.
Quote consistency (attempt, anyway).
Ok, let's remove it. We should make it more concrete if the error property should be set on something. This is more of a hack than anything and we don't use it anymore.
Indent all the options in 2 spaces from start to subheading so it's looks something like....

<pre>
options: {
  start: {
    elem: "input",
    type: "text",
    label: "In"
  },
  end: {
    elem: "input",
    type: "text",
    label: "Out"
  },
  title: {
    elem: "input",
    type: "text",
    label: "title",
    "default": "Popcorn rules dude!"
  },
  subheading: {
    elem: "input",
    type: "text",
    label: "Subheading",
    "default": "Popcorn.js"
  }
}
</pre>
If we're going to add `start` everywhere, we should get rid of it in `createButter`, as well as the `stop` call.
Isn't `start` ignored anyway here https://github.com/mozilla/butter/pull/924/files#L3R379 ? Seems like `ignoreKeys` isn't being tested properly here anymore.
ok, then we'll just need that capabilities field and then this is good to go.

@adamsutton I'd rather do this recording profile stuff in the frontend (xbmc / showtime) and send the raw parameters based on the settings in the profile to the backend, or it'll be very messy to support both. I'm not going to add something that will only work with tvheadend to the api, so unless other backends support these profiles too, I won't add something like this to the api.
typedef's are generated automatically, so this typedef should not be defined here (not this file include`goog.provide('ol.source.TiledWMSOptions')`). @twpayne, please confirm.
Is this line trying to find the OS ? From where the 'os' environment variable is getting injected ?

May be this is what require ?

if sys.platform.startswith('win') :
This variable is not necessarily needed.
@tibbe are you gonna bring up this issue on ghc-users or ghc-Trac? If it is fixable (so that the current argument lose their weight) I think it would be worth it to help adoption of the default-signature feature
This is still wrong. 

1. Don't add lib prefix when linking with libraries;
2. TestFlight also requires libz;
so result will be:
```ruby
s.libraries = 'TestFlight', 'z'
```

3. libTestFlight is not in library search path. It can be added with the following line:
```ruby
s.xcconfig      =  { 'LIBRARY_SEARCH_PATHS' => "$(SRCROOT)/Pods/TestFlightSDK }
```
using a hard coded 'admin' user is bad because if the user 'admin' has been removed you could be referencing in this user that doesn't exist.  Switch to:

User.current = User.hidden.first

this will always get you a user that exists in the database and ensure that the oauth calls to pulp will not fail.
Did you mean to leave this commented out?
Or you can create in src/katello/client/cli/base.py new function opt_parser_add_uuid
see opt_parser_add_environment for example.
good point; check below
We do not need to persist this one (if it is being persisted currently).
I would prefer using hex codes rather than labels
设置有效期——setValidTime / setValid or just "start"
Other places on the code uses `$Model->escapeField()` instead.
Yes i realized the password field won't be unset and edited my comment but github doesn't send email notifications for comment edits :)
this is wrong. You should keep the original phpdoc for the class instead of adding a weird one
these logs probably aren't needed (which would allow the code to be much cleaner)
This shouldn't use plain `%s` positional arguments, as that makes it extremely brittle.  For this kind of more complex template rendering, the new `{}` syntax that Python allows is both clearer and safer in the long run.
> I'll change it, this is a documentation issue.

Indeed, our documentation has failed pretty spectacularly at keeping up with changes.  Right now, honestly the best docs for how to configure IPython are the generated files you get from:

    ipython profile create

Which is pretty sad.

> Likewise it took me some time to figure out that "%pylab inline" was the right thing to be doing...

This is directly a result of the non-googlability of notebooks, which we need to address. There shouldn't be a single IPython example notebook with plots that doesn't have this line, so looking at any example notebooks should have revealed it.
Think you want `git__free()`
Ah, it's missing a '}' after.
Yes, that's much neater, have implemented.
I think I would specify usernames here given that you're testing usernames later.

Sure, if not specified, usernames are randomly generated. But given that it's part of the test, I think it's better to define it in the test. e.g.

    self.sender = user(username=u'Alice', save=True)
    self.to = user(username=u'Bob', save=True)
oops, nvm. I misread the diff. need moar coffee.
Should be `firefox`?
Ditto regarding what I said in the hacking_howto.
`id` and `menuid` should have different values. It looks like this `menuid` is correct, while `id` should be something like `appMenuSimulatorItem`.
Looks like the `SuspiciousOperation` import here is now unused.
Same comment applies here. How about `is_requesting_user`?
I think we should change the text to: "You can explore ProTalk by tag, category or speaker when using the corresponding tabs below or you can search this website using the search form above"
I don't think that's portable unfortunately. I'd like to work on Mac, Linux, and *BSD if possible.
I disagree with this change. If I'm making several cylinders inside each other, I don't want the plugin moving me around every time.
This method is meant to return a driver instance. So you should throw an exception when it is not available, not returning false (btw, returning false seems weird. It should be ``null`` if you don't want to report errors, not a boolean)
Yeah I was pondering registering a failure handler automatically and calling that on failure, but not sure yet. Things have to be discussed.
should it be `$startTime` and defaults to 0 ?
Implemented this change, so there is not BC break at all anymore.
This class should probably be marked as deprecated in favor of the parent one
shouldn't you keep the old method until 2.3 for BC ?
This test is pointless.
Just more "explicitness". And it looks bad, when one property is documented and the other not.
As per the finnish weekdays, the days should not be capitalized in Swedish, even when abbreviated. The correct string is
    
    weekdaysMin : "sö_må_ti_on_to_fr_lö".split("_"),
Could you set `slidermin` and `slidermax` to prevent high < low. (see [edge detector plugin](https://github.com/tonysyu/skloupe/blob/master/skloupe/plugins/edgedetector.py) for details)
I think that the django_logout should be called in both cases, i.e. also if shibboleth was used.
Weren't we going to not have Photo extend Post any more?
Best way is to press "Merge pull request" button on the bottom of this page. Cau you do it?


If CR is complete I'll merge it and add a fee. (You can always delete a fee later if there are any duplicates.)
If the cell we're creating here is even a little different from the cell in the ContactListViewController (looks like that is the case given the absence of status, change of nicknameLabel size and change of cell frame) could we just add the ContactListCell to the view in the storyboard file and then hook it up as an IBOutlet. Seems odd to load the ContactListViewController just to nab one of the cells.
Why not use [CPVenue initFromDictionary:] instead of manual inicialization on lines 176..186?
I do not think the version could be 1.0
In corresponding to the milestone, version 1.0 should be useable to create thesis paper successfully, not currently.
А это сюда как попало?
@jtai metrics begin here, the part after "gauge" is the original ES metric.
Yeah, it's try/except/finally that's the problem.
This certainly should not be part of a review.
Personally, I'd rather stick with `^`. Changing to `is not` would do an object identity check, whereas `^` is a logical-XOR.
Obviously, this adds a new dependency...
If you hadn't done this, what would happen?
(Tu peux lire ça: https://github.com/highgroove/git_tracker#rubygems ainsi que le paragraphe "Usage" pour voir comment on s'en sert et pourquoi nos branches ont des ids bizarre :))
seeing this again, it makes a lot of sense. good call moving this to _Analyzer
Why do you copy the methods from the parent class? They are inherited.
I'm not sure this file should be merged?
this should be done using pytest's funcarg setup
Elles ressemblent comme deux gouttes d'eau à un relicat de la coding party,
malencontreusement oublié lors du commit.
Elles peuvent donc disparaitrent de la surface de Github.

David

On Wed, Oct 17, 2012 at 2:22 PM, Arthur Weber <notifications@github.com>wrote:

> In src/main/webapp/js/tatami-commons.js:
>
> > @@ -631,3 +690,98 @@ $(function() {
> >    });
> >
> >  });
> > +
> > +/*
> > + * Feed the suggestion popup container with the results
> > + */
> > +function feedSuggestions(target, results) {
>
> À quoi servent ces deux fonctions ? Je ne vois pas où elles sont utilisées.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ippontech/tatami/pull/204/files#r1865863>.
>
>
Hmm; looks like my cleanup of the recursive completeStep() calls missed this one.
sorry ... this patch number has been taken so there's a collision.

I am unclear why we need a function.  The talk comments are done this way because there's lots of chaos around admin/speaker comments and we ignore anonymous comments and ... who knows what else so we wrapped it up, with performance implications but maintainability benefits.  For the events, can we just average over ec.rating where user_id is non-zero?  If so, I'd rather do that in a normal query.
Okay, will add both.
Can't this class be extended from OAuth20ServiceImpl instead of being re-implemented ?
I think this should go in a config file. I'm ok if does not land now but should de done in the future.
nit: b -> n
Why do you switch from hidden -> invisible.
That was my mistake, there is just one handle, thanks!
The DOM order is essential to full screen mode -- since everything is on the highest possible z-index, their order in the DOM decides their visible order in that mode.

Have you test your pull req against an app that triggers full screen mode? If not then we shouldn't touch the order of DOM.
I'm glad you're combining this code here.
Add <tt>"use strict"</tt> since your code should be compliant with [JavaScript's strict mode](https://developer.mozilla.org/en/JavaScript/Strict_mode). This can lead you to fix some former warnings that now are considered errors.
@timdream 
I just want to sync the coding style with L133~152.
It was annoying to keep them in while implementing swipe, things like should the item pan when you hold click, the click area of the close button etc

I will add them back in, its easy to implement the plain way, just wanted some time to think about how to do it nicely
var nextAlarmFireTime = getNextAlarmFireTime(alarm);

and put L331 to L336 into that function, and have this function replace the `calDiffDays`

PS if you running out of vocab to name a variable, it's time to write comments to describe everything you did, like @davidflanagan do. :)
Now it's not able to look for 'number'. We should bring it back again.
Added comment into lines
import_module is just a wrapper around __import__, with some extra code to support relative imports, which the code here doesn't use. So __import__ seems like the more sensible choice, unless I'm missing something.
Probably, this isn't new code it's just indented because of the using.
This line should be the 2nd line of the method. Like this. ```return special_option unless item.html_options[:link]```. Do you agree?
Hm then perhaps we should leave fmt out for now, and look more deeply into this.
`swipeStartPosition` is a good idea. We don't have to include the X in naming since we only work with the X position.
Fixed by naming the magic number `RTMP_READ_REPORT_THRESHOLD`.
ws around binops
I think so, for simplicity.
yup if I run it directly I get that as well
Well, in this case, you could even do:

```
OpenBSD | FreeBSD)
```

because there's no real need for quotes.
Again, can pull the type from the default
Not really. They mean the exact same thing and I believe Oracle normally say List of. I know their param variables in code are always called paramArrayOfBlah, so I presume they would have the same naming for Lists :P
return null here, perhaps?
Great! I wasn't sure if automodapi had been finalized yet... I'll fix it.
OK. I'm fine with this change, but have been asked about the ability to record/measure latency manually in the past. This is a fine intermediate change though.
The whole idea of being compatible is for people to do this:
    >>> import jsonrpclib
    >>> forcesched = jsonrpclib.Server('http://localhost:1080/api/v2/schedulers/forcesched1')
    >>> forcesched.force(param1=2, param2=3)

You can't do it if you are not "standard"
I looked at results.py and decided to not include it there for that reason. Somehow it crept into base.py. Will make that change now.
Include paths should be referenced relative to the $(ProjectDir) so that developers using a custom .sln that references the existing libExtension.vcxproj file can use it without errors. I have updated cocos2d.vcxproj to use the same project-relative referencing technique.

At your request I can update cocosDension, box2d, and the others to use the same referencing technique.
Actually this is entirely correct, you confused me :P

All this does is mark the package for an update, the constraints defined in composer.json always still apply.
Fixed by removing public properties.
I think you need to change this path, too, and make sure that that js file is there, because I don't see that in /vendor/assets/javascript either
Checks for `on` as well as regular verbs.
Then ship it
The confusion in this case is because it's in the middle of a dictionary. Took a few seconds to file the remaining keys in the dict.
We can for sure. Doing this.
Not fond of this func ptr solution. I think it'd be better to have a generic "selectFP(s)" function that is called from both printfp and populatempm functions
Should this if statement use "{" (not inline) instead of ":" ?
why have two writes? Why not socket.write(syslog_msg + "\n") ?
If you set this up with something like HSQLDB, you could not only test creating the factory, but also test some actual mappings.
> As a matter of fact we use same loader
So `options.load` is equal to `require('api-utils/loader')` ?
I marked it dirty because the code doesn't live in-line with the route, so you have to remeber to look up here when thinking about communication_iframe or relay.

We could do the indexOf style, I did if/else in case in the future there are other headers we need to tweak on a route by route basis.
Does the record need to be checked for here?
I don't see why the change is needed. Still, even if kept, the `bid` var is never referenced again.
I hope that this is convincing enough:

http://validator.w3.org/#validate_by_input

Source:

> <!DOCTYPE html>
> <html>
> <head>
> </head>
> <body>
> <span id="logger" class="disabled" />
> </body>
</html>


Output:
>Line 6, Column 39: Self-closing syntax (/>) used on a non-void HTML element. Ignoring the slash and treating as a start tag.
><span id="logger" class="disabled" />
okay, already done it. returning it into name, instead of uri

2012/5/31, Stefano Ricci
<reply@reply.github.com>:
>> @@ -24,7 +24,7 @@ package org.openforis.collect.metamodel.proxy {
>>  				var langText:LanguageSpecificTextProxy =
>> LanguageSpecificTextProxy(projectNames.getItemAt(0));
>>  				return langText.text;
>>  			} else {
>> -				return name;
>
> Maybe it's better to return the name instead of the uri when project name is
> not specified. This is used to show the survey label text on top of the
> ListView
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openforis/collect/pull/2/files#r906466
>


-- 
Eko S. Wibowo
http://ekoswibowo.wordpress.com
"Be 100% and just let it flow"