labofsahil/github-event-dataset-2012 huggingface dataset:
Thanks. Done.
This aggregate will be in dt.c, which will be in another PR. I will let you know the exact PR number if we raised it.
It's very similar with the array_agg. However, we will use the fid as the subscript of the result array, and use the fval as the array element. The definition of this aggregate is as follows.
```sql
/*
 * @brief The aggregate is the same with array_agg, which will accumulate
 *        The elements in each group to an array, except that we allow users 
 *        provide the subscript for each element. This aggregate will be 
 *        invoked as HashAggregate, while array_agg will be called as 
 *        GroupAggregate. Therefore, our implementation have better performance
 *        than the array_agg.
 * 
 * @param elem     The element to be fed into the returned array of this aggregate.
 * @param elem_cnt The number of elements.
 * @param elem_idx The subscript of the element.
 *
 * @return The aggregated array.
 *
 */
CREATE AGGREGATE MADLIB_SCHEMA.__array_indexed_agg(float8, int8, int8) (
    SFUNC = MADLIB_SCHEMA.__array_indexed_agg_sfun,
    m4_ifdef( `GREENPLUM',`PREFUNC   = MADLIB_SCHEMA.__array_indexed_agg_pfun,')
    FINALFUNC = MADLIB_SCHEMA.__array_indexed_agg_ffun, 
    STYPE = float8[]
);
```
This is apparently fixed in Django 1.4 that was released 2 days ago. I looked in the django 1.3 code around the exception and it wasn't pretty. New version uses a more flexible regexp to parse the datetime. See django.utils.dateparse.
On Tue, Sep 11, 2012 at 6:37 AM, Will Kahn-Greene
<notifications@github.com> wrote:
>
> In fjord/analytics/views.py:
>
> > -    except PageNotAnInteger:
> > -        opinions = paginator.page(1)
> > -    except EmptyPage:
> > -        if page < 1:
> > -            opinions = paginator.page(1)
> > -        else:
> > -            opinions = paginator.page(paginator.num_pages)
> > +    page = int(request.GET.get('page', 1))
> > +    search_happy = request.GET.get('happy', None)
> > +    search_platform = request.GET.get('platform', None)
> > +    search_locale = request.GET.get('locale', None)
> > +    current_search = {'page': page}
> > +
> > +    search = SimpleIndex.search()
> > +    if search_happy is not None:
> > +        search = search.query(happy=search_happy)
>
> happy is a boolean field, so you probably want to filter on it rather than query on it.
>
> —
> Reply to this email directly or view it on GitHub.

I originally used filter, but then I came across a bit of ES
documentation that said

> There’s one important distinction to keep in mind. While search queries
> restrict both the returned documents and facet counts, search filters restrict
> only returned documents — but not facet counts.
>
> If you need to restrict both the documents and facets, and you’re not willing
> or able to use a query, you may use a facet filter.

Using a facet filter is normally taken care of automatically by EU, if you
specify filtered=True, but it isn't automatic when doing raw facets, so it
would have required duplicating code.
This creates an index_item_task when retrying an unindexing operation.
While I understand why this is useful, I'm not sure I'd kick up an HTTP 400. I don't think that's generally what you should do. HTTP 400 is more for "bad request" as in the client--not the user--did something wrong. We're not really expecting this to be used by non-people.
When installed with --HEAD option, additionally the installed play framework needs to run some additional steps as described in https://github.com/playframework/Play20/wiki/BuildingFromSource

So where can this be defined? Inside `install` with a:

```
if ARGV.include? '--HEAD'
      ...
end
```

?
Another example:

```
==> exit 1
exit 1 
Error: Failed executing: exit 1 
/usr/local/Library/Homebrew/formula.rb:484:in `system'
./librsvg.rb:14:in `install'
/usr/local/Library/Homebrew/build.rb:105:in `install'
/usr/local/Library/Homebrew/formula.rb:226:in `brew'
/usr/local/Library/Homebrew/formula.rb:511:in `stage'
/usr/local/Library/Homebrew/extend/fileutils.rb:22:in `mktemp'
/usr/local/Library/Homebrew/formula.rb:507:in `stage'
/usr/local/Library/Homebrew/formula.rb:221:in `brew'
/usr/local/Library/Homebrew/build.rb:82:in `install'
/usr/local/Library/Homebrew/build.rb:44
./librsvg.rb:13
==> Exit Status: 1
https://github.com/mxcl/master/blob/master/Library/Formula/.rb#L
==> Build Environment
CPU: dual-core 32-bit core
OS X: 10.6.8-i386
Xcode: 4.2
X11: 2.7.2 @ /opt/X11
CC: /usr/bin/clang
CXX: /usr/bin/clang++ => /usr/bin/clang
LD: /usr/bin/clang
CFLAGS: -Os -w -pipe -march=native -Qunused-arguments -mmacosx-version-min=10.6
CXXFLAGS: -Os -w -pipe -march=native -Qunused-arguments -mmacosx-version-min=10.6
CPPFLAGS: -I/usr/local/Cellar/cairo/1.12.2/include -I/usr/local/Cellar/pixman/0.26.2/include -I/usr/local/Cellar/libffi/3.0.11/include -I/usr/local/Cellar/gettext/0.18.1.1/include -isystem /usr/local/include -I/opt/X11/include
CMAKE_PREFIX_PATH: /opt/X11:/opt/X11
LDFLAGS: -L/usr/local/Cellar/cairo/1.12.2/lib -L/usr/local/Cellar/pixman/0.26.2/lib -L/usr/local/Cellar/libffi/3.0.11/lib -L/usr/local/Cellar/gettext/0.18.1.1/lib -L/usr/local/lib -L/opt/X11/lib
MACOSX_DEPLOYMENT_TARGET: 10.6
MAKEFLAGS: -j2
PKG_CONFIG_PATH: /usr/local/Cellar/cairo/1.12.2/lib/pkgconfig:/usr/local/Cellar/pixman/0.26.2/lib/pkgconfig:/usr/local/Cellar/libffi/3.0.11/lib/pkgconfig:/opt/X11/share/pkgconfig:/opt/X11/lib/pkgconfig
Error: Failed executing: exit 1 (.rb:)
```
`brew --prefix` is more general, since it can also work for the user on the terminal.
Should this maybe not be "if field not in fields"? And then pass in EXPECTED_FIELDS to get_field_values? The current setup just seems a bit odd.
I'm fine with either approach: the one you describe above, or the approach of storing the information as part of the config. I'll let you decide on whatever your prefer.
> С этой точки зрения «в течение» и «на протяжении» эквивалентны, и замена одного варианта другим не спасёт от ощущения медленного сливания.

Ну значит вам без разницы, а мне будет понятней "на протяжении" :)

> Слово «периодически», кстати, хорошо вписалось бы в предложение вместо потерянных «несколько раз»:

Значит надо вставить :)
Falls nicht mehr noetig, loeschen. 

Ich glaub du hast den PR nicht gegen den aktuellen Master gemacht?
Doing that said command not found in OSX!  But with spaces seems to work, yes strange but it happened so...
@dstillman, do you recall why this is necessary? I'm seeing some issues with `<object.../>` data values. Some embedded objects are not loading and I'm trying to figure out why. E.g. http://www.nytimes.com/ the video about 1/3 of the way down the page is being downloaded to federated_f9_001.dat and referenced as `<object data="about:blank?federated_f9_001.dat"...>` I tried removing the "about:blank?" part, but the video is still not displayed. At least with the "about:blank?" removed I can see it being loaded in the web console (there's no trace of it otherwise). Perhaps the video just won't load localy no matter what, but either way I can't find anything online regarding the "about:blank" part. Is that still necessary?
What if the charset is not utf-8?
The sense this makes is Kristian-sized.
Not sure if it's worth handling, but CSS Selectors have a mix of case sensitivity (id's and classes) and insensitivity (everything else), and this method ignores case.
Wrap these lines at 80 (or so) chars.
What if they're on c9.io and they have two computers attached to a workspace, and both computers have the browser in focus?

Side note: aren't we using `_self` since `self` can refer to the window?
There is no `xmlToTag` :p
This is a drive-by refactoring required by the agent/client. No need to worry.
Currently: there's {DAV:}group too, but it's hardly used. However, I've made a bunch of short-cuts in the past, and then a new rfc comes out that happens to depend on the exact feature I thought was not needed :)

So to me it makes sense to do this upgrade, but I fully understand if you prefer to not do this. In that case I'll get on this and try to have it implemented before the 1.7 release.
you should add petter
I think you did more simply with `setNames`
If these comented lines are not useful anymore, please remoev them.
Add empty line after the block.
No, this is not correct. When you get a merge conflict, you have to manually open the file and edit it to create new correct content. Don't just add the file in conflict without editing it.

So here you have to fix this. Obviously is an easy merge: simply both sections are necessary, your new (language links) and Facebook login button.
Just a suggestion here: if you do something like `Popcorn.plugin( "uiCue", uiCuePlugin( butter ) );` then you don't have to pass around `butter` on an object above. Closures are fun!
Why remove this space?
Remove this too, please.
How about "Rounds a number with an accuracy of `__timeAccuracy`."?
Note: there is a lot of strange/duplicated removed/added code in this file because I fixed its indentation and styling.
I do not remember there was a change in LIS by me. It could be from the time when we had that compilation problem with LIS. No idea why it is there. Better keep the original form.
It's generally a redirect, but otherwise could return a response object.
Yes, for some reason medistrano uses that encoding:

    1.9.2p290 :007 > d.get_medistrano_pir.encoding
     => #<Encoding:ASCII-8BIT>
you could use `unless app_instance.persisted?` here instead of #uuid, seems to be more in line with the intent here
I'll add more describe and context blocks to be more specific
What is this file for?  I don't understand what role it plays in this test.
########################
Harry this question might be better suitable for Rodrigo. It was not my addition
Sure! Thanks for pointing out the issue :smile:
Code style: `PATH`, `UTIL`, `FS`
parse = analyzovat, klidně tam ale může zůstat i to prohledávání, ale napsané správným stylem "Prohledávání souborů %s..."
Please add this when you are adding the class for mirror stream validation
It should work without it as well. I've tested it even with giving some fake names there and it was ok.
just keeping it neat :) themeoptions.php
btw, for the type, shouldn't it use the channel instead of expecting a particular entry in the context which does not correspond to any convention for other handlers ?
On 02/04/2012 10:56, Etienne Segonzac wrote:
>>       LockScreen.init();
>>       LockScreen.update(function fireHomescreenReady() {
>>         ScreenManager.turnScreenOn();
>>   
>> -      var touchables = [
>> -        document.getElementById('notifications-screen'),
>> -        document.getElementById('statusbar')
>> -      ];
>> -
>> -      NotificationScreen.init(touchables);
>> -
> It causes other issues with the test setup we have (screen gets locked just after the app is launched...)
> So `head.js` is going to need an update I think.

Ok, let's move the code then. (but i would like to confirm it is related 
to the moztelephony api or not)
Yeah, that’s what I had in mind when I asked you that for your pull request. :-)
That's not confirm, that's back so it's a key.

For emergency that's a TBD.
I like the note you added - that's exactly what I meant. I don't think we should discourage people from using the convenience functions, but just explain (as you did) that one is more for long term, and the other is just to get something fast.
Maybe the selection of the default is a good candidate for a decorator?
s/nod/node
I suggest "Disconnecting for misbehavior:".
Seems like I edited something that was wrong, sorry for that ... will fix this.
I now understand what this option is for. I'd rename it `maxIsSky`, to make it cleared that `skyText` and `maxIsSky` are related. And I'd describe as follows:

```
If set to ``true`` the label for the slider's max value will be the value of the ``skyText`` config option,
and no floor param will be set in the query string of requests. Default is ``true``.
```
refactored on 76649a0
Perfect then... thanks! =)
`content_md5_pass?` already checks for the `HTTP_CONTENT_MD5` header. Should I move that here?
This needs to check something else. I don't remember what directoryPath is going to be relative to, but it is either the working copy in git or the workspace in TFS. The workspace in TFS is (IIRC) only populated with files that are going to change, and the git working copy is not necessarily the commit being pushed to TFS.
Hm, why the changes in this file?
where is this opened?
Probably just 2011.
please add Override annotation and use inheritDoc unless there's something cloudstack specific here
I'm confused - why would you turn this stuff off?
Debug styles should be removed.
I'm confused, doesn't this close the modal as soon as it's opened?
Moved it from `ViewTests` to `DocumentEditingTests` where the login was handled by `setUp`
Wow! the lines above are nasty. Is there no simpler way to do it? E.g. using patch()
I wasn't sure what certificates the requests library knows about. We don't have the certifi package installed. I re-verified this. requests actually ships with a fairly extensive fallback list of known root certs and the ones we use at mozilla.net are in there. So I'll enable the check.
Perhaps I can change the wording of the description as test_extensions.rb tests the actual extensions.
Right. Now it dynamically collects all the data, that will work (going to QA it of course)

But, do we want to re-collect stuff that doesn't change? Everything except User-Agents is static, right?
Without packages, the locale is only added to/removed from /var/lib/zypp/RequestedLocales.
--packages will install language dependent packages for the given locale(s) or remove it from system.
We will also add a 'verify' command which checks whether all packages for the supported language(s) are installed.
They don't work on my 5.3.18 install, docs say that they are fine and always there after 5.4 ([see](http://php.net/manual/en/ini.core.php#ini.short-open-tag))
Pass the actual ``argv`` given to the Qooxdoo CLI through, so that at various points, we don't have to use ``sys.argv``; the two may be different if one this writing their own command line interface for Qooxdoo.
Why don't we break out the /reset functionality out to a separate function, like you did with suspension?
Seems like these calls to LOG() can be changed into warnings instead?
this class should not throw a BadCredentialsException
missing `()` (multiple times)
The idea was to allow async execution where the callback closes the stream later on. But since that doesn't really work properly with HttpKernel it makes sense to close it.
however, this event could have a ``setExitCode`` method to allow returning early from the command
If the dev using the helper passed ``foobar`` as ``$options['return']``, you are returning ``null`` here instead of throwing an exception because of an invalid config
Sure, but it would mean for string replacements, everything has to be marked as string, which means you lose a big part of the validation.
what about making sure that each callback `is_callable` ?
that would imply removing the possibility for `null` value.
does it make sense to initialize to '' prefix or on the constructor?
yeah should be possible. I just didn't want to optimize premature. I was happy enough the algo worked in all cases.
You are not testing anything anymore here.
I refactored it only for sake of readability. Nothing special. Will revert if you favor the `for` loop.
Moving temporary object creation into a block (the result of which is the 'flockThriftServer') might be clearer here. Also, the class doesn't really need references to all the intermediates (although usually we'd only care about that for performance reasons.
PLEASE leave it backwards-compatible with node 0.6.x or grunt will have to force everyone using 0.6.x to upgrade!
No error should pass silently. Please add `else` statement and show error using `[SVProgressHUD showErrorWithStatus:... duration:kDefaultDismissDelay]`. Also pleas consider checking error returned by API in `json` dictionary.
am scos migrarile care nu mai sunt necesare, am pus null: false la reported_for in migrare si am creat un nou schema.rb
Ah, I see.  Given they don't take specific masks, it's probably more efficient to call removeline_* once rather than once for each expired x:line anyway.
Fixed.
We used to call two functions here, one for prman options and another for oiio options. However, they both modify different sets of values, and one returns the same datatype as was passed in and only had side effects. These functions were only called from this one location. To clarify things and make it easier to change the automatic mutable parameters, I moved the contents of those functions into each branch of this conditional.
As above, this `return` needs to be outside the `finally` block.
This whole module doesn't test anything new. It is simply testing the ```image_for_domain``` api. I think this test should be removed completely.
I think this was fine on one line, it's unreadable (and not meant to be read) anyway.
Nope - that wont happen
It would mean that any code that does a numeric temperature check in the API will fail on MMQ
I've added some other code comments.
I think JSHint will nag about changing this to `cell.pending.isUpdating`
here you can use ``version_compare`` to avoid relying on array order and remove ``$this->executed``
bold. I like it
This function should not be here. It overrides the one `result_add_option` from AbstractChosen adding anything and breaks copying css style from original elements. Probably some merge bug.
Pourquoi supprimes-tu l'API Google?
Sorry, but I don't want this ExpressionResolver.DEFAULT approach used. I keep finding too many bugs when non-standard approaches to doing things are followed. It also doesn't support security vault integration and I don't want different resolution rules for different attributes.

Please pass in the context.
It most likely doesn't really do anything. I put it there only to be safe to make sure everything was committed before the write. Which now that I think about it is kind of stupid as the writeConfiguration() commits it there too.
The BundleContext is not available in a newly created Framework. It is created as part of Framework.init()
Dagnabbit... Fixed.
I always write out the full set of math, but this isn't even close to being a hot path and this is certainly fewer bytes.
According to github's diff, it looks like all of the weight/bias initialization stuff has been removed from the __init__ method, and not replaced with anything else (ie, I don't see a call to get_params here). What's going on?
понято
I think you should change the names of these CSS classes as well.  I recommend repeat-off, repeat-list and repeat-song.
I don't see any definition for error() here. Won't this code just throw an exception?

I suspect that what you want to do here is the same thing you do if the canPlayType() call fails.  Save metadata like {isVideo: false} or something, and then when you enumerate known videos, filter out these that are bad.  I think you can also pass null to the callback and mediadb will skip the file.  But I think if you do that it will rescan the file every time you start the app, so it is better to mark the known-bad files as bad somehow.

Note that there may be a similar issue with .mp4 files.  Apparently that extension can be either audio or video.
Nitpick: use single quotes please.
`region: 'BR',`
A general comment on this new CSS style:
 - Many measurements units are still "px", which is not  flexible for multiple resolution.
   Not a blocker for V1, so this could be improved in a follow-up.
I just realized 'shared' in your PR has a different meaning that the one normally in Gaia. Forget my previous comment then.
I wonder this pattern would break something but I cannot tell once.
ping @timdream to see if you have some concern on this.
Can I see the exact command that `adb shell` was choking on?
You could just use document.getElementById('tone-disabled').hidden = true to hide this element.
As the above comment, please help avoid anonymous function.
The body of the closure is now lacking indentation.
Can we get rid of the mq-context altogether?
The first local but not loopback address on debian is always 127.0.1.1 after the debian installation, so I only change this line in the file.
some of these comments can probably be removed...
The return value here should be ignored so we'll go with the agreed convention that only putting Return when what is returned should be used by the caller.
shit happens ;)
Gigantic code review so this is a low priority thing to catch, but I wanted to alert @quietbamboo about this.  This is a redundant line.  http://linux.die.net/man/5/gitignore

I will fix in my next CL
CS here (8 spaces)
I agree that it's better to be consistent with spelling out vs. abbreviation. (annulus only ended up spelled out because there was is no unambiguous abbreviation for it.) If no one suggests something better, the fully spelled out versions,

`aperture_circular`, `aperture_elliptical`, `annulus_circular`, `annulus_elliptical`

 are an improvement over whats there now. They are a little on the long side, but I suppose you can always do `import photutils.aperture_circular as aperture`.
But you know what... Ruby supports negative numbers for the year afaik (not that a negative year is a valid date but...)
Until now it did not help.
Err nevermind, that is the default for mkdir.
is it possible to make the `array_map('strtolower', $packages)`before line 754 so you can remove the `strtolower($package)`on line 772 ?
OK, is changed
Honestly the only real references I could fine in a quick Google search was Apple VNC Server. But that filter picks up VNC probes and there are many of them I see.
as an example, this would be tid = *percpu_get(init_thd)

Do you agree that looks cleaner?  Can we improve this?
Is there any way to hide this password?
don't you still have to set the trees root to the new element?
It's generally better to do structured logging; use a human readable message followed by some attributes:

    @logger.debug("Connecting to AWS SQS queue", :queue => @queue)
some kind of moseba soda....
Baby steps. I’ve got a branch based on this branch for that. This request adds tests for FRB and Collections that verify that they do not interfere with the regular operation of the rest of Montage.
That is a terrible idea, just don't call `propagate` if `observers` is `null`.
nit: Is there any particular reson why `enumerable: false` is explicitely set for `__iterator__` and not others?
If I remember correctly, all defineProperties options default to False. If that's the case, it might be better removing it and add a small comment about why we use defineProperties, something similar to:

    // Define non-configurable API attributes in order to avoid modules modifying, breaking and hacking this module
    // And non-enumerable API attributes to ensure that these attributes do not mess with __iterator__
I don't think this dependency is used, please remove.
remove me?
I don't see this used on the front end at all.
ewww.  sleeping in tests!  :P
Yeah that seems reasonable, I'll change it if @jeads thinks it's cool too? :D
Why do we need `defaultView.window`? `defaultView` is already the window we want to remove the listener from, isn't it?
> * Re: sessionstore. It should already have the name of the group included per default. Can't we simply retrieve it?

If I move these lines some line below, into the `if ... else` then getting and setting of tabGroupTitle would be in sync.
After that I wouldn't understand Your question. 
Would You mind to write some details about Your question? Because I don't really know why are You asking that.
should be an exception
i'm not sure if there is overriding convention, but it seems like it would be useful here to suggest what valid values for this variable would be, and what the default is if nothing is set.
Technically not required until we start to establish the database connection, later.
I don't understand this assertion. Isn't it just `names.should == core_apps`?
Typo from lib/rubygems.rb
timeouts are not handled anywhere in the doozer client code, so I'm going to avoid introducing an inconsistency here.
I tried with a very small solution at first, but it failed for nested describes. Do you have a suggestion?

I might not have made it obvious, but it basically turns

```
xdescribe('bla', function() {
	describe('bla', function() {
		it('bla', function() {
			...
		});
	});

	it('bla', function() {
		...
	});
});
```
into
```
xdescribe('bla', function() {
	xdescribe('bla', function() {
		xit('bla', function() {
			...
		});
	});

	xit('bla', function() {
		...
	});
});
```
I would really like to see this done in Node.js instead.

For sanity and Windows compatibility.
Ah yes you are right. Dont know why I over complicated it. 

I will make that change shortly.
Thanks.
Era nella precedente versione del manuale... Da rimuovere
Same note here as in FormMonthSelect ... Could DateSelect instead additively extend from MonthSelect?
This is located now in Zend\Math\BigInteger
I was under the impression that we had to build with 2.0 as well, so using default parameters was out of the question. If that's not the case, then I can definitely simplify things.
Missing docstring for class
hm?  why is it putting it into labels?
yes we should add the attachments updates
nice reference!
By exporting it, it is pushed to the environment of the below recipes
answering myself: it does when parsing the DQL to the expression
i was pondering this .. 
the only place where we are changing the base class is ``doLoadTranslation`` where we are trying to load the translation for the provided document. so imho that is also an invalid argument exception if there is no translation to load for the provided document.
Ok, then +1 for a configuration hash.
You are right about this one. Your approach before was much better.
pep8 would not recommend a new line here:
http://www.python.org/dev/peps/pep-0008/#imports
Yes, indeed. I put it for help me with my quick tests. But now it doesn't make sense. If you want to run the doctest, just `python -mdoctest file.py` does all we need.
effectの構成上ブログエントリーとちょっと違うので何をどう配信するべきか迷いました。良い表現方法があればなあと思います。
Another canididate for a parseUri function on Popcorn.
Pretty sure you can remove newopts.
indent error here
line 3, yeah, I see that. but this one's for the navbuttons?
I suggest pulling the ul out into a shared partial so that we don't have to maintain the code in multiple places, but we can do that later, so merging for now.
We should check the sr and raise an invalid argument if we are not in one of these cases.
ok, I'll wait for that patch before merging then ;)
Error handling is OK, thanks.
Why you changed ``source `=file` `` into `execute 'source' fnameescape(file)`? Is ``source `=file` `` wrong?
So there's no programmatic way to include auto load classes? Classes are stored in the {registry} table, so there must be a programmatic way to add and remove them from this table. If we can prevent this construct, I think we should.
Please remove this line, it's meaningless and annoying
哪里错位了？
Actually, it's probably because of the fix of https://jira.ez.no/browse/EZP-19401
And I don't see any valid reason to lowercase all attributes
While you're at it, you might as well also make the base64-encoded SHA512 hasher, though I am unsure how many people use that one:

https://github.com/fwenzel/django-sha2/blob/master/django_sha2/auth.py#L88

Just subclass this hasher and replace the encode method by encoding the hash differently.
Installation with deps are really usefull for symfony 2.0 users.
PEP8 states we need an empty line at the end of the file.
Conceptually, since it's used for a membership test, I think a set makes most sense.
getUser would probably need the Context as well, as we want to check if the current user can get that user.
It's probably better to have this test be under the main create comment test. And reword access to permissions.
We probably want to switch the order here and put visibility, locale, timezone behind displayName
I think ``ScalaLaunchShortcut.getJunitTestClasses(tpe).nonEmpty`` is better.
I'm not sure what you need then. Do you need the fully qualified name, or the fully qualified name and method signature?

At any rate, my suggestion was to replace the cast and avoid going through the package fragment by getting the full name from the enclosing `IType`. I don't know what `readableName` does, so maybe my suggestion won' work, in which case you can keep the existing code.
Do you mean the following case:

    $router->generate(null, array('route' => $route))

or 

    $router->generate('some_standard_handled_route_here', array('route' => $route))
You've right Guzzle include the EventDispatcher in its composer.json.
I see two possible reasons why this method exists. 

1. It's a fault in the codebase
2. For the extendable reasons. If someone want to create his own result class and this class doesn't handle this case.     (Because it's not mentioned in the `ResultInterface`)
no magic numbers. Use a constant
You've got an extra 'l' in libraries.
:) можно и класс метод. Задание немножко вырожденое... По науке(бизнес смыслу) наверняка пришлось бы делать отдельный класс с набором свойств и методов. А так я исходил из логики минимализма кода, на объявление и реализацию метода ушло бы больше строк, чем на прямое его использование. Тут наверное нужны какие то общие принципы, стандарты и лучшие практики,  чем руководствоваться так сказать. Их наличие и понимание помогло бы многим начинающим.
Спасибо.. По уроку думал что нужно в main..
И да, меняться должны случайные элементы. То есть, допустим, при изменении 3% из 100 элементов, должны измениться, к примеру, 0, 54 и 73 элемент.
Can you add a comment to explain what is loc.ShortcutDescription? or where this variable is defined? and also why we need ! before the parentheses?
Is it ok to double size for half scale?
Is it really necessary to use `document.defaultView.getComputedStyle` instead of `window.getComputedStyle` here?
oh noes we need to delegate these
Why not use the macros here?
Because it seems useful to have a universal scheduler to background work vs. creating a new scheduler every time or keeping one around manually.
Please consider using [cheerio](https://github.com/MatthewMueller/cheerio) instead of htmlparser and soupselect. It's a lot more clear and concise.
Slash prefix can be removed.
同上，队列用poll比removeFirst清楚一些。
As this enum is public, it might make sense to give it a more C# friendly name...

How  do you feel about `ChangeKind.Added`, `ChangeKind.Modified`, ... ?
> because it is in __init__.py.. before everything we imported here was visible as "sample.os" etc., which is not very nice.

hum ok. Put a comment then to explain why then
you want tmin and tmax to be in the times vector so I would do:

tidx = np.where(tmask)[0]
this_epochs.tmin = self.times[tidx[0]]
this_epochs.tmax = self.times[tidx[-1]]
tell me when you push an update so I can take a look
same here use assert_true
I am not too fan of adding an example that does not plot anything.
Can you put some demo of this in the other examples?
it is also pretty redundant with the raw demo example don't you think?
This still looks kinda ugly. Is there a way to make it neater?
`find_by_username` would work here.
Syntactic sugar that doesn't matter that much, it might look cleaner if you check the inputs in the beginning (no need for if {} else {}). Can apply to any functions written this way.
@kellyredding - Curiously, why did you choose to require in the included right before the include? I have no real problem, cause require's are safe to be run multiple times and all that jazz, just curious about your motivation.
Why did Typhoeus remove underscores from these names?
This should most definitely not be here. AMQP should create actors in the system that the extension belongs to.
Fixed in bb61f88aaf9c6a6226a0a35034fc963536e857bd.
Each object in Ruby has a corresponding class. An object's type is its class, the class doesn't really contain the object, more like it defines what the object can do (methods) and what it can have (state).
```$twig``` does not seem required here
change update to succes
I don't follow you at all.  What has eviction (segment size exceeded) have
to do with this?

1.  When a segment size is exceeded, the item should be removed from the
data container (this happens internally, NOT by calling
datacontainer.remove()) and it should NOT be removed by the cache store -
and has nothing to do with the activation count.

2.  When an entry expires, it is removed from both the data container and
the cache store. Again, this has nothing to do with the activation count.

3.  Activation only happens when the ActivationInterceptor can't find
something in the data container and has to load this from the cache store.
 This is the only place where activation counts come in.




On 10 December 2012 16:16, Galder Zamarreño <notifications@github.com>wrote:

> In
> core/src/main/java/org/infinispan/util/concurrent/BoundedConcurrentHashMap.java:
>
> > @@ -1714,6 +1723,14 @@ V remove(Object key, int hash, Object value) {
> >                    count = c; // write-volatile
> >                 }
> >              }
> > +
> > +            if (!isEvict) {
> > +               // If removing (and not evicting), activation rules
> > +               // require entry to be removed from cache store (via
> > +               // activation) and counter to be updated
> > +               evictionListener.onEntryActivated(key);
>
> Manik, if the removal is normal removal (i.e. cache.remove()), it's all
> fine, but there can be a removal triggered from within the container (i.e.
> an entry has expired, the segment size has exceeded...etc), so to be able
> to update that counter and if you wanna keep the counter in the
> interceptor, the data container must have access to the interceptor.
> There's not a single way in which data can be removed.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/infinispan/infinispan/pull/1455/files#r2365462>.
>
>



-- 
Manik

"Physics is like sex. Sure, it may give some practical results, but that's
not why we do it." - Richard P. Feynman
Actually, even with @bblay's fix, the data is still not put in the correct range...
This block frightens me a little, probably as I don't know tornado or much about web sockets. What is significant about the number of attempts? How does one know which port to use in the web browser URL (if you have to type it yourself rather than letting it get shown automatically)?
@WeatherGod Where do I put the double dots in your example?

I followed the example below (from `pyplot.py`):

```python

def figlegend(handles, labels, loc, **kwargs):
    """
    Place a legend in the figure.

    *labels*
      a sequence of strings

    *handles*
      a sequence of :class:`~matplotlib.lines.Line2D` or
      :class:`~matplotlib.patches.Patch` instances

    *loc*
      can be a string or an integer specifying the legend
      location

    A :class:`matplotlib.legend.Legend` instance is returned.

    Example::

      figlegend( (line1, line2, line3),
                 ('label1', 'label2', 'label3'),
                 'upper right' )

    .. seealso::

       :func:`~matplotlib.pyplot.legend`

    """
    l = gcf().legend(handles, labels, loc, **kwargs)
    draw_if_interactive()
    return l
```

I don't have sphinx, and I have no experience with it, so I'm deferring to you guys for epic sphinxage :)
Not that I know of: usually, you don't align ``}`` with the text above: there are several ways to do that. I'll change this indentation.
Does this catch and log JSON parse errors?
Hey @johnshih I did a bit of investigation and have come up with a wait.

Here's how I did it. at line 52 I put:
```
print self.marionette.page_source
time.sleep(10)
print self.marionette.page_source
```
I then compared the output of the pages before and after and I can see that the title changed.
I put 
`self.wait_for_condition(lambda m: m.find_element(*self._wallpaper_title_locator).text == "Select wallpaper")`

See how that goes for you!
describe this in more detail
Careful here! I'm pretty sure your block is going to be called asynchronously, meaning we're gonna steam right on through this block and launch cook before we've gotten a response.
If we filter out new sections, error appends and so forth, but we pass thru errors, then whatever errors we append to the audit entry, will show up under whatever section last happened to be appended to the audit .. which might not have anything to do with the current bundle being run, and may have a misleading and non-errorful section name such as "Completed" or something like that.

Would it make sense for this object to record whether it has appended anything to the audit entry yet, and if it has not, to add a new section with a generic title such as "Errors occured during '#{policy_name}' execution" or something like that?

Of course, that only works we're creating a fresh PolicyAudit for every bundle scheduled under a given policy name. Continuing to review...
Instead of checking that licenses are present lets just print them. If they are empty then they are empty. What do you think?
These changes were accidentally added when I had updated the source. I have removed these changes. PR: https://github.com/sakaiproject/nakamura/pull/722
1) Why was this added to the service folder?
2) Why is this in the model package? Is this a model? What is this a model of?
Why do the parsing in a separate place than the creation?

Why can't you reconfigure the size of a shared cache the same way you reconfigure the size of any other cache?
Big tear(tm). Fixed.
Might as well call `uv_close(handle, NULL)` here if `_detach_cb` is just a no-op.
This is an internal api. It should go into src/win/internal.h and not be marked UV_EXPORT.
Didn't recompile Physics and Sociology before regression testing. Will revise base and retest.

Sent from my iPad

On Nov 19, 2012, at 5:20 PM, Philip Schatz <notifications@github.com> wrote:

> In css/ccap-base.less:
> 
> > @@ -10,7 +10,7 @@
> >    float: @float;
> >  }
> >  
> > -.x-column-count(@num: 2) {
> > +/*.x-column-count(@num: 2) {
> This is still used for physics problems & exercises. Did you recompile ccap-physics and test before making the pull request?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Evtl. in Res.java eine Methode die das zusammenbaut?
added link to Rcpp sugar vignette
Did you mean

    $option = $input->getCmd('layout');
Thanks, fixed.

I don't understand why there is a typacast to boolean in `JSession->isActive` and I repeated the style. Should I remove these?
I already did, just forgot to remove it, sorry.
Why is `fb_sprite.png` then still in commit?
Translatable string. [Check this](https://docs.djangoproject.com/en/dev/topics/i18n/translation/#internationalization-in-javascript-code).
i think I should use objectify instead of Xpath. It will be easier then to save to database and more clear to understand?
Nja, we could redirect maybe back to the form? No?
This should probably be moved from panel code to top PiplMesh code? Probably also other panels/code will need information about current node in JavaScript?
Of course, the question is if it is really needed. This might be enough:

```
$.each(panels_with_dependencies[panel] || [], ...
```

Or does `$.each` even throw an exception, if the thing you pass it in is undefined?
`None` -> `request`.
Use `tmp_value` here.
I am positive to not said that. Because I am particularly picky about `:`. Because it is a great example to show that you have to think about that, too.

I see that you do not see the main point here. The main point is that for translations to work, catalog of strings for translation should be made and then each such string should be translated. `colllectstrings` `manage.py` command does the former. And it is quite stupid, it parses code and searches for `gettext` calls. So, if you have `gettext("mon")` it extracts this string out.

In your case, it has nothing to extract. It cannot know which all strings you will be translating.

What is common to do in such cases is to pregenerate dictionary/map between your known values and translations. For example, you could have:

```
days = {
    'open_mon': gettext("Monday:"),
    ...
}

And then simply do `text(days[day])` there, this would work.

Now, this is a general approach. In your case, because you are translating week days names, those translations are probably already existing. It might be interesting to research if Django supports such translations in JavaScript by itself, or how to leverage existing translations for days or localized date time formatting.
Seems like a weird signature... I think it should return the list of 

```csharp
public List<AirbrakeTraceLine> GetBackTraceLines(Exception ex, int exceptionCount)
```
I dont think MAKE_NEW_GUID will return a valid creature guid without the entry, does this work?
I see what you did there! COPY PASTE! ;-) ;-)
Das habe ich mir auch überlegt. Aber ist evtl. kritisch, wenn man ausversehen ein Leerzeichen am Ende des PW hat ist man fuxed. Wir haben ja auch (noch ;)) kein PW recovery oder so. Andererseits wenn einer mit Absicht ein Leerzeichen am Schluss hat ist der fuxed. 
Bei normalen Textfeldern macht meine Tastatur am Ende der Wörter immer automatisch einen Space, bei Passwortfeldern natürlich nicht. Vondaher, ich weiss auch nicht was besser ist...
Can we create a URI from secondary_id to make them resolvable? Are these identifiers stable across time?
active class on the link, not the surrounding li
The code on the lines below `as_view(` must line up with the open parenthesis.
Done in daf840c
As far as I can see, `helpers.tap` renders references inside an input. My input here is a raw `0`. Since that's a value, it gets passed straight through tap to the other end.

I might be wrong, the whole tap infrastructure seems quite confusing to me for now. Maybe I'll grok it better later.

Either way - the attached test is passing now. Feel free to fix in any other way that makes the test pass. :)
I suggest you linebreak this monster into handy chunks.

Or you make an array and then ``json_encode()`` it.
Why do we need to add here a z-index?
Aha, sorry, read that a bit quick. I see what you mean.. changing it now, maybe it's a bit hard to read, but since I need `FIRST_LINE_PART` from `cls.HTTPHeaderTokenizer.classnames`, I'll pass that and `cls.HTTPHeaderTokenizer.classnames` into an anonymous function for now.
@aclark4life: I believe it is an "HTML fragment" that is being referred to, i.e. not a complete HTML-document.
Will this grow unbounded until restarted?
wonder why not composer autoload would be enough?
What is the difference between `var foo` and `var $foo` in javascript?
I don't understand, Map is an interface, right? Are you staying something like Map map = new HashMap()?

On Feb 24, 2012, at 12:53 PM, Nima Asadi wrote:

> (that's sed syntax: substitute Map for HashMap)
> 
> Nima
I don't understand why you say that if I move "libvirt_failure" to TNArchipelLibvirtEntity I won't need to loop over hypervisors VMs. even if I do that still I need to call it on TNArchipelVirtualMachineEntitty instances so I need to loop over them and because I need to loop over VMs I think it's better to be in TNArchipelHypervisor than TNArchipelLibvirtEntity.
I think version should be 2.0 here.
This isn't really a statement on the pull request, but this approach still makes me uneasy.  Disquieted, I've done a little digging.  The Boost Mersenne Twister was actually updated in April 2005 to address an issue with precisely this sort of re-seeding (see http://www.boost.org/doc/libs/1_51_0/boost/random/mersenne_twister.hpp).

The issue itself is described briefly here: http://www.math.sci.hiroshima-u.ac.jp/~m-mat/MT/MT2002/emt19937ar.html, and in more detail for an algorithm tt880 that is apparently a 'little cousin' to the Mersenne Twister: http://random.mat.sbg.ac.at/news/seedingTT800.html

My worry is that updates to the methods claim improvements to the behaviour of close (in a bitwise sense) patterns, but I've not found ready quantified data.  I know you ran some tests on this Mike, but I think we do need to be careful with consecutive integer seeds in this way.  I'd be happier if we passed them through another RNG first, even if just a crappy one that we write but that mixes up the comparison of bit registers a bit more.
Changelogs don't belong into source code. We have version control for that.
You are totally correct that they don't harm anything - I only updated it to reproduce the existing behaviour and to make it look as close to the stock config as possible.
What is the threading model here? You synchronize on loadManualAdditionsCatalog but you access the field without any synchronize or volatile, so usages of the field could see half-initialized objects etc. Should this be volatile?

I presume it's too expensive to just create an empty manualAdditionsCatalog in the constructor rather than doing the more complex lazy creation?
I'll change it.

It is a default setting of intellij; if there (afaik) are 5 or more important for the same package, a single wildcard import is used.

Should i set n to infinite?
That would also mean the test could use standard \@BeforeMethod and \@AfterMethod, rather than try-finally.
vmc version tends to be fairly uninteresting.  this is intended as a start-simple test to make sure vmc command is running.
All references to addthis should be removed.
Wow, that was a lot easier than the way I did it.
Perhaps. I feel like that could wait for a separate patch. At any rate, it would fail early, unlike coding errors in the main body of the file. Does csv do some kind of rudimentary type handling? I was surprised to see all that float/None testing.
I guess I'm just a bit unsure about how to best do that (My apologies, still learning the intricacies of python).

Looking at the way that the patched object is returned in Mock, it appears that there are some calls to protected resources, which also seems a bit fragile to me. I'm going to try to build it, but happy to get advice for what you have in mind.
I'm on the fence about this...mocks are best used with commands, not queries (and this is a query), but given the focus of the example is on "using the configured backtrace formatter", `should_receive` seemed appropriate here.  The return value still needed to be used because `format_backtrace` could be called and then the matcher could throw the return value away and not use it.

But you're right, the use of the return value (if it was just a stub) demonstrates it is used just fine.

@alindeman -- do you have a preference?
"Any valid JSON will work"
How about "execute_check" or "run_execution_check"?


Also, I don't like the mixing of `*args` with `args`. I strongly suggest we make the signature on this function to be:
``` def run_check(fn, *args, **kwargs):```
You should revert the check and return early here
We don't need this method here. It is already defined in the OBController. Please remove it.
The Zburn proc.  Move it's definition onto one line.  E.g. "datum/gas_mixture/proc/zburn("
this seems like a useful macro to keep around for discovery f4.  if it's not being used, why not disable PIOS_INCLUDE_USART?
Can you explain why this one was commented out?
this one is a good idea, but probably needs a better default (maybe 'localhost'?), otherwise parse_url() will choke.
what's going on here is not obvious, a quick note would be nice..
Возвращать надо 1, а не -1.
если он не является валидным, он словит Exception при попытке его применить...
I think development was the only straggler that had caching disabled, maybe we'll just push this up to application.rb
There is no stable release.
Why all the escaping here? Is this necessary? Also, this matcher is finding the class anywhere in the data-context. Can we not use an exact match instead? Otherwise, we could have false matches.
At the moment none of our test accounts have over 20 apps.
Should we change the test so that it also checks that step, or should we leave it as be and when the time is right add that step to the test?
@zacc, @bebef1987  any ideas on this?
Should this be done though? any method in thor will work (e.g def z; self.var = somevar end) and I don't think anything can inherit the generator?
yeah, the h_ prefixes are right.
Thanks you for showing me that idiom. I was always wondering how to enumerate zips.