labofsahil/github-event-dataset-2012 huggingface dataset:
Yep, I missed that the send_to_airbrake method is still there and active.  My mistake.  I would like to see the message context sent as with Airbrake.
hmm, I think there is really not much need to write the variable in full, perhaps a few detailed comments should do.
This line doesn't make sense to me...is it supposed to be `cd ~/destination/` instead?
On Fri, Feb 10, 2012 at 9:32 AM, Andrei-Adnan Ismail
<reply@reply.github.com>
wrote:
> Fa commit-uri mai mici si explicate mai bine. Un commit trebuie sa faca o singura chestie (nu si imagini, modificari de cod, etc.).

ok, o să încerc. M-am gândit că era cam o funcționalitate, dar îl
puteam împărți în încă vreo 2-3.

-- 
Andrei Petre
"6=1" only makes sense here because cdrwiseHeight is zero-indexed for braindead non-reasons
See b65c01f998 for an updated version. I've submitted pull request #20.
New crash related to Unit::GetTriggeredByClientAura
http://pastebin.com/Fg2akHg8

Still having crashes due to Player::SendUpdateWorldState even with (IsInWorld() && GetSession())
http://pastebin.com/y7P7HpDS

And crashes in ObjectGuid::GetRawValue but those crashes are not related to oPVP.
да нет , вопрос то пока о малом, сделать так что бы лишние данные не лезли - было бы не плохо начать 

"исправить - можно, слегка переписать систему рассылки обновлений мангоса. кстати, там еще кое-чего кроме этого надо поправить, а то роботов в хеллфайре не видно издалека."
The right time comes for everything ;)
ye, thats what confused me too :< was just an update query, not insert/delete
tonight crashes in 7h with [mr1611], [mr1622]  and [mr1623] reverted

http://filebeam.com/upload.php
I imagine this is probably old code, but... I think Dialog is a ContentPane, so the extra ContentPane may not be needed?
These are only half done, '''davinci.ve.states''' needs to be converted to a singleton I think but I need to talk to Adam
This is going to be EPIC! Go Phil!
To me it seems like this commit is destroying the special characters (like 'ä', 'ö', 'ü' and 'é') in the german and french localisation. Or am I wrong?
See comment below - same thing applies here.
Yep, I thought it was a better idea than having to host it locally.
On Mar 6, 2012 11:58 AM, "Jrgen Maas" <
reply@reply.github.com>
wrote:

> If I'm reading this right we're not referencing/using the jquery shipped
> with Cobbler anymore? Is this what was intended?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/jimi1283/cobbler/commit/fe9d8667b593076e82c64f72136ee6deac4564b5#commitcomment-1049578
>
Where is player being defined? :P
the expected results of test_rank2() seems reversed, as in:

df = DataFrame([['b','c','a'],['a','c','b']])
df.rank(1) should be DataFrame([[2.0, 3.0, 1.0], [1, 3, 2]])
and
df.rank(0) should be DataFrame([[2.0, 1.5, 1.0], [1, 1.5, 2]]) (in the current code, however, see below)

On that note, what does it mean that something is of rank 1.5?  How should DataFrame([[1,1]]).rank(1) behave?
I have not used winpdb, but the formula looks ok. 
Is the ```--prefix``` actually needed?
And this improves things how?
discoveryrule.py L:168 still breaks the unittest. Are you really sure, the iteritems() are correct?
Interesting, I notice the Gnome docs also talk about gtksourceview-3.0: http://developer.gnome.org/gtksourceview/stable/
This is 2012 ;)
If someone could look at this issue, special last rsa comment, would be great. :)
https://github.com/mangosR2/mangos/issues/798#issuecomment-4106657
Fixed that by removing the @override annotations in the TikaProcessor

commit 83d919ad27f7823b56c57f693b22aa64eb152a54
toi non plus tu dors pas ?
I'm not sure we would need this EJB specific plugin from Maven. A plain jar plugin should do the job. But I'll leave this for Pete, Sande to decide.
@farmisen I think @ittybittydude incorporated this in his commit d81cee468e98892ff8e525556c5809dc5cf6c301 but in a different set of methods viewWillAppear and viewWillDisappear
Not sure why this doesn't work as V8 didn't seem to mind `num > null` in the console. Here are some of the strange results;

``` javascript
0 == null     // false
0 <  null     // false
0 <= null     // true...
0 >  null     // false
0 <= null     // true...
0 == 1 * null // true
1 == null     // false
1 <  null     // false
1 <= null     // false
1 >  null     // true
1 >= null     // true
1 == null + 1 // true
null == 1 - 0 // false
```

Worked previously as width was set to `0` by default.
If it does indeed slow it down,  a better solution is a function to close the connection that could be called by the user.  Might seem dirty but it would have no overhead.   I would suggest a config option but it would suck to keep checking it after each exec().
Is this a check for preliminary termination? If yes, then maybe we need to check for false at line 517 as well.
NULL and 0 is not the same. 
Try
#include<stdio.h>

int test()
{
    return 0;
}

int main()
{
  if(test)
  printf("You see NULL != 0");
}
@addyosmani Make sure not to push changes directly to gh-pages ;) I've cherry-picked the change and pushed it to master.
Yeah I just want to make sure this is always off, even if you forget the flag. We won't get 404s for deleted branches though.
damn... i didn't change $name to $ext when I copy/pasted. will fix asap
wouseover typo
I feel a little duplicate code. (timestamp.rb)

My fix 30b58a7747759f3d4362b0c35604dc4c1c412d2a used private methods.
a little difficult problem ;-)
Do you have to roll it up into one class? Could it not be two? Then we would have a _DelgatingSession_ and a _DelegatingSessionImplementor_. It think at least name wise it would be much clearer.
想少些点的。。。
这个就是判断敌人有没有“张角”，其实仅仅是判断了敌人中是否有人有技能“鬼道”
En fait ça ne suffit pas...
Le paramètre image orientation permet de régler l'orientation de la vue gil... Mais si tu utilises directement le buffer ca ne résout rien.
Il faut mettre "eImageOrientationIndependant" (comme ça tu récupères dans tous les cas un pointeur vers le premier pixel du buffer quel que soit le sens) et regarder dans l'image openfx le rowByte pour savoir le sens et ensuite régler le quad opengl en fonction...
Sachant que il peut y avoir un décalage en fin de ligne rowBytes != width*pixelBytes. Il faut donc setuper la texture opengl en fonction...

Ou plus simplement faire une recopie dans un buffer interne dans le sens désiré :).
This will soon no longer be necessary, as I’m currently merging my no-global-state commits. But it's taking a bit more work than I had hoped :)
@tips48 you think Koreans are funny...? Racist -_-
How I can remove this chat issue to characters that have already changed faction before this fix?
I don't see any changes in the above commit that should trigger such bad behavior, but I can replicate it on my phone. (I normally use phone with orientation switching off.)
hehe, no, that's not necessary :)
It's definitely confusing.  I'll try to come up with a better way.
Yes, but nevertheless the result of the algorithm could be serialized in JSON-LD.


> -----Original Message-----
> From: Gregg Kellogg [mailto:reply+c-855638-
> 6558e20b451987c07cea9faa9adfe68cb7a284eb-456407@reply.github.com]
> Sent: Wednesday, January 11, 2012 11:29 AM
> To: Markus Lanthaler
> Subject: Re: [json-ld.org] Drastically simplify normalization by simply
> delegating to rdf-graph-normalization spec. API result is no a
> DOMString. (3c8427b)
> 
> I suppose it's really an open issue, but the community wants a
> normalization algorithm that's not tied to JSON-LD.
> 
> We really needed to remove old normalization from this spec, and I
> wanted to replace it with something that basically just referenced the
> external normalization algorithm. Really, the result will be whatever
> it returns.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/json-ld/json-
> ld.org/commit/3c8427bc1b96cbc844d3850fdd4a7f74edcc0f30#commitcomment-
> 855638
Why X0 should debug it ? if you really want it, debug it by yourself. rewritting the spellsystem take time and he don't have it.
Why can't you use the `body_content_class ` to solve this? We should always be skeptical to adding more blocks since they're adding risk. 

Also, the use of an `!imporrtant` hack this early is kinda scary. There has to be a better way. If it's just one page that needs a particular fix in a particular use case then maybe I can agree to use an `!important`. 

Lastly, whatever causes the float that you're trying to put back to `none` should instead be the thing to attack. If you need to refactor a bit to accomplish it I'm all for it.
wouldn't something like this make it impossible to use utf-8 and extended ascii characters in the sql? Is there some sort of security concern for this commit?
Did you forget to add JenaJSONLDSerializer in this commit?
Why does it think that these lines have changed?
Just wanted to ask you about this, and put the TODO as a reminder, in that case I agree. 
There is some other issue though: in TreeInsertParagraph if a textnode was split at the end (Enter at the end of the text node) the split is done but we don't add to the tree the new text node child with empty string.  Could you adjust your code to do just that?
> JSON is not supported by old browsers.
Fixed.
http://stackoverflow.com/questions/5256021/submitting-github-pull-request-for-only-latest-commit

The cleaner the pull requests are, the more likely I'm to just visually check them, and click on "Merge".
I'll test it next week on my university!
It's mostly just for convenience (to save effort). Failing that, I might
just subclass the poll object myself.

I also added room support, I did this by adding join/leave methods to the
Socket, Connection, and Pool objects, then also adding a room_send method
to the Pool object.

Ideally I'd like to push this upstream too, does it sound like something
you'd be open to?

and why specifically don't you want to add emit() to the Pool object?

On Sat, Feb 11, 2012 at 8:21 PM, Viacheslav Tykhanovskyi <
reply@reply.github.com
> wrote:

> I am not very sure about adding emit method to the pool...
>
> But you can always achieve that by passing already built message, for
> example:
>
>    my $event = PocketIO::Message->new(type => 'event', data => {name =>
> 'my_event', args => [1, 2, 3]});
>    $pool->send($event);
>
> This will send an 'event message' to everybody in the pool.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/martynsmith/pocketio/commit/577b0fb301c488bbe5e51fd624eacc63e79b11cd#commitcomment-956217
>
hi Jay,
this change would not help in situations of other param names, the handler is supposed to receive the params already urlencoded so I have reverted the change. 

We should review the importhandler (which is calling the data import handler) if you are seeing the import is failing.
We could do this manually in the release script, we already have some special manual steps. The problem is that it will be fragile since it will list each path manually.

An alternative is to plug into the maven release plugin, or the maven versions plugin.
Use more descriptive test names so it's easy to tell exactly what is being tested. For instance: testGetQuizHasRequiredFields
Ahh, gotcha.  IIRC it should take the current date, shift it to the Monday of that week and pull the two weeks prior + 3.months from that Monday.  Depending on they day of the week that could pull a varying number of weeks.  Make sense?


On Friday, March 9, 2012 at 9:59 AM, Bertrand Chardon wrote:

> Note that the test on date_range was introduced by my previous commit.
> I thought that the array was always 13-long (one week in the past and three months in the future give or take) but after executing the tests for a few times I got a failure telling me that RSpec was expecting 13 and got 14.
> 
> I guess it's always finicky with dates, depending on lots of factors like odd years, alignment on week days etc. 
> Maybe something like .size > 12 would be a better fit.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/rescuedcode/StaffPlan/commit/685f7c0f5dfad1faaf5090e5e47fabdd5bdf3f5e#commitcomment-1065884
> 
>
this test is redundant.
it has the title of the following test and body of the previous test.
please remove.
serverProcessStopping() -- since that's all the
re-pushed with force
yes, ben. this code is relevant to rails controller methods, so I don't think it makes difference if you use params instead of hash but it's cleaner in the method context. 

is this variable assignment really necessary? can you please just use a one liner like `ActionDispatch::Http::ParameterFilter.new(::Rails.application.config.filter_parameters).filter hash`.

This is also not safe from exceptions, so please add the `rescue` statement. I would prefer if you added it after the `end` statement so it's more DRY. your thoughts on this? 

thank you for contributing once again
InvalidArgumentException: The object "BookAuthor_1" from class "BookAuthor" is not defined in your data file.
Why, that's not a scene keyword and I've never seen a release with it in the name?
Выкладывай PDF-ку.
Avant le cloth était plus réaliste D:
Any glitches related to PEX due to this plugin have been fixed now. Mixed-case permissions are handled fine. PEX (and all the other modern permissions handlers) no longer supports old Permissions. The warning in this code has no purpose any more.

And why the hell are you still trying to support old Permissions?!
happy you find this useful and merge it to master.
one thing - i notice that the author was changed on all files, and i'm getting git conflicts for all the modified files when i try to merge your master to my repo, which is quite impractical. it's probably related to the method you used to merge my additions?
can this crash be related to this comit??

http://paste2.org/p/1921768

uptime: 5 minutes...
Ок. учту.
TAB -> WS I missed
I found a kernel driver for the device from a different TI EVM. All it does is just gives a menuconfig option and can be loaded as a module. But in the end, it does the same thing as your patch. As for the new kernel I am having problem with i2c in general.
Judging from Wikipedia, Skowhegan, Maine only has buildings dating from ~1910. No wonder there are hardly any Clojure devs around there!

Luckily there's the internet, and if you ever find yourself over in England, I'd be more than happy to have a coffee with you :-)

Will you be at Clojure/West?
I'd like to do a bit more cleanup today and get sense data returned correctly before too many folks try it out, but it's usable in its current state. Definitely not for general consumption I'd say but ready for early testing & review by savvy people.
thanks! your commit forces administrators to know ruby language, to write :account_disabled_test function...

could be a better idea use regex? usually all administrators know how to use regexs...
but... regex certainly does not cover all use cases... :(

(sorry for my bad English)
cool, thanks!! :-)
i believe this is not always set. we have a `process :set_content_type` line in our Image model that might be the thing which does it. it might be worth checking at least... if there is a dependency on including that `process :set_content_type` line, we should maybe add it as a dependency of the set_file_extension_by_mime_type option
Should just indicate that the font family name is expected to be the "official font name", with a reference to the linked doc for more info.
movi algunos en el ultimo commit, podria hacerlo con los css de estilo.
Done. But did I do it wrong, or was it something else?
I'm not sure this is correct - it should return false if no rows have been read/are held any longer.
The return value of ```.and_return(@resp)``` is a ```Proc```. It is the ```Proc``` which will be called as the ```initiate_scan!``` stub. In this case it is stubeed to return ```@resp```.

The ```[]``` method of ```Proc``` is basically the same as ```call``` -- consequently the return value of ```subject.stub(:initiate_scan!).with(@path_to_file).and_return(@resp)[]``` is ```@resp```.

What does this mean?

It means that all of these expectations are checking these values: https://github.com/partnerpedia/mobile_defense/blob/master/spec/lib/scannable_model_spec.rb#L28-37

In no way does this code test anything else.
in commit message '_treee.scss' is mispeled ;)
It has the overhead of another polymorphic method call, I need to first perf test it to see that its ok, for now, I wanted to fix it though.
@gdusbabek As you've suggested in http://code.google.com/a/apache-extras.org/p/cassandra-node/issues/detail?id=32#c4 the drain-listener now is executed only once.

Skipping all callbacks if `shuttingDown === true` is actually done on purpous. But maybe we should call the callback and pass it an error. I'll fix that.
Msf::Config.install_root should give you the installation path.
@sminnee By the way, are you aware of any discussions or API proposals for how to solve nested connectives? Thats kind of a big gap in the DataList API :/
Nevermind.Made a mistake in the layout. Thanks!
Yes i know. I implented this commit but noticed that the Documentary Movies do show up in "Dokus" and also in "Movies". So with a small addition you could hide Docus from Movies when Dokus is shown on Home and bring them back into Movies when Dokus on home is hidden. 
If that already is the case than please ignore what i said as then something was wrong with my implentation (rip-off) of this commit.
I knew, but I had to look it up to remember -- is it refresh?  Or something with references?  `hgq` is pretty crufty at the best of times.
May cause:

Failed tests: testVirtualVideoActionInitializationCompatibility(net.pms.test.formats.FormatRecognitionTest): VirtualVideoAction is initialized as compatible with null configuration expected: but was:
Nog eentje in backend/profiles/engine/model.php, lijn 228: geen spatie tussen while & (
Ook, meer comments in die functie, wat doet de loop precies, etc
Yuck - this should have been in the constructor - fixed by previous comment.
Я бы не сказал, что это бага. Скорее это особенность использования тобой чужой функции.
Т.е. в waitForThreads нет ошибки, есть несогласованность того что она делает и того как ты её используешь.
Thanks, voy a seguir :)
Is it worth making this static, so that you're not having to create an autoreleased dict every time an icon is loaded?

See what I've done for the static tldArray in QSObject_StringHandling.m (Starting line 64 then 151)
I tried nil (which I believe throws an error), but I didn't think of false.  Good call.  Labels are still showing up for me, but no sense rocking the boat unnecessarily. I just pushed a commit that reverses this change.
wtf %)  wrong author :p
What is proposed is to stay into settings/device/advanced, so in my opinion the icon for this option is needed

Kalim
Thanks for pointing. Unsure where I got ncss: it is vimscript #2149. Maybe accidently pushed <C-S-Left>, opera is sometimes very smart about what should be taken as “previous page”.
If you're documenting code, it's up to you to find out what the parameter types are, otherwise there's no point in documenting it at all.
Are you sure w should be in eV ? The reason I divided by hbar was because w (frequency) should be in fs-1 and hbar*w (energy) should be in eV ! I see you compensated for this by removing the hbar factor in the plot command. Let's have a think about what the best way is. I'd prefer if w's were in units typical of frequency and that hbar*w was in units typical of energy.
I think I would rather support one or the other (than both).  Would you say one is more canonical?
can we have scope "test"?
August 17th commits:
https://github.com/yui/yui3/commits/v3.7.0/src/dom/js
I just copy the comment from other function around this. I 'll remove this.
As far as I know ElggBatch is friendly on memory, but wouldn't the maximum execution time still become a problem?
Yup. Super it is.
This should surely inherit from device.Solver?
Derp, it totally already is.
Yes, change both. Overloading in Scala is tricky, and often not needed.
... and this written as

    cluster.latestGossip.overview.unreachable.map(_.address) must be(others.toSet map address)
Might want to link to the JDK docs for the settings
Oops, nice catch.  Would you like me to resubmit a new pull request?
agreed.  not sure where to hold onto it, so....

RESOLVED
Now we just include all the modules in the Model directory into the base (Card)  Hope order doesn't matter any more.  Seems to be ok now.
Account.new is a User.  Account is the interface class, User is the instance that is behind it now.
I see your point with that.  Then it is just a variation on the card_id fetch.  Just translate to id first, then do the ID fetch.  If no id for the symbol, no card (nil).
Well at least this instance can be cleaned up a little, https://github.com/arokem/dipy/pull/5
I like the new name, definitely sets it apart.
Thanks Tim for the explanation, @trejkaz could you please review and update this with a new PR? Thanks.
typo should be
```ruby
# @param [String] which_build defaults to 'default'
already there
I know it's obvious, but for the sake of completion, please add a short docstring for sphinx.
`highlighted` should be `YES` while tracking. The `tracking` property seems redundant.
I suspect that you wrote this patch against an older version of the configure script. The current `compiler_version` returns triplet tuple, not a quadruplet list.
@TooTallNate The reverted behavior explicitly tries to avoid calling `listeners()` to avoid creating `_events[type]`. Is that still needed?. Regarding your proposal in https://github.com/joyent/node/issues/3425#issuecomment-6308056
I dunno.  It seems ok.  I just removed the 'binary' argument, since it's not correct here.  getPublicKey returns a buffer by default.
It's error prevention.
make this explicit too
omit 'however'
Interesting. Because the code that retrieves the value looks quite the same. Need to investigate this more. Can you provide a sample XML?
Good catch, thanks! Will merge after you address my fix above.
у этих тоже 2 таба
Не информативное название
один таб отступа лишний
this could probably be refactored with @radar's blessing to:

```ruby
if moderation[:moderation_option] && post = Post.find_by_id(post_id)
```
@rafaelfranca Thanks for the feedback. I made it public due to the existing `fragment_name_with_digest` being public. My reasoning was that, because `fragment_name_with_digest` is public, it must be useful to be able to get the fragment name for a given key. Given that, it would also be useful to get a fragment key given a name and set of options. Let me know if you'd like it changed and/or covered with further unit tests.
what do you think about use a uniforma name to the value? In one methods is `val` in other is `value`
> I think, doing it this way, we don't need a mutex at all - because we add to the `@@compiled_delegators` set before defining the method, so it will never be the case that `super` is true where `@@compiled_delegators.include?(method)` is false, but should in fact be true.

This is not thread safe, because `Set` is not thread-safe. You can't access a `Set` while some other thread might be adding/removing elements.
@NZKoz yep agree but I'd leave that for another PR :)
Why not just ...

```ruby
assert(value.bytesize > entry.size, "value is compressed")

```
Disregard my previous comment
> in this function's body, and all the subsequent ones, references to the symbols in `from` will be replaced by the corresponding tree in `to`

Dated comment?
No, these are only created from the unpickler.  Calling staticClass you should just get NoSymbol as before.  These aren't intended as "user-facing" classes, they're intended to put some slack in transitive relationships so people don't experience needless failure.

They don't need to be distinguished in API because they should fail if you try to use them.  Without this patch, you would have failed the same way, just earlier.
Since I wrote it I can't dispute that it is a national treasure. Moving it to docs is a failure though, then it just rots. I'll rescue it and use it in a test case.
I added a link to http://www.doughellmann.com/PyMOTW/doctest/.  For the rest I think it makes more sense to fix this in the NumPy "How to document" guide I think; it's hard to fit something useful in here.
should we make suds optional and check for it on import of net module? it is currently not needed if you do not plan on using the vso or hek. many folks don't.
This docstring should really be the docstring of `Delta`, not of the whole module.
I have removed another reference to hints being applied in arbitrary order in `function.expand`.  I have also looked through the doctests there and I have seen no particular examples that would be particularly related to hint ordering.  Did you refer to those doctests or did you mean something else?  Sorry, it seems that I'm lagging behind your trail of thought.
"the" after "in"
I *think* you should be using double back-quotes...not sure. You do in some places but not here, for example.
@smichr, what does defaultdict do?
what is purpose of this test? I expect that you should test result of serialization or write againts some test data and not test two internal methods
Thanks, will make refix.
I'll update the other files and push the changes.
It is - there's one subclass instance of AbstractMapJoinKey for a set of join keys, MapJoin(Single/Double)Key for 1/2 keys, MapJoinObjectKey for >2 keys.
Declarations go at the top, split up the declaration and the assignment.
Ну если блок с информацией о создателе и денежных реквизитах лишняя, во всяком случае у меня болтается
run is the wrong verb.
see the positional operatior (i.e. `$`)
Spaces between list items.
re: truthy
for consistency, want to change these to url('') and apply the parameters appropriately? :)
Can we add a conditional around this so we don't monkeypatch if we don't need it? I can't think of a sane way to test the copy_metadata method's behavior, so probably a check for ruby version is the best we can do.
Also, class should actually be made abstract instead of just saying so in the comment.
Those are old functions which stem from a time when code quality wasn't exactly valued in phpBB. Readability is more important than saving a few bytes.
Comment about what the combined statement does. Something like "Reset attachment category to none if attachment is an image or thumbnail and user does not have the permission to use images."
If you did not intend to change them, please put them back.
This should be renamed to `http_kernel`
Ahh, I had just defined it, figuring the global within append_sid() itself would recognize the variable. I didn't realize that global worked before the variable was defined. I guess I need to read up on the global keyword some.
Give me a chance, I am not going to push every time I add a character when I'm still fixing other things. I'll push when I'm done later on and yes, I've fixed the other instances.
No! Delete the call rather than faking it :-/
I should not be commited :) Sincerely, this line.
Actually it's fine for this to be just `withClearanceP p (colClearance col)` I added the glb because of the bug you ran into
Neat. I am assuming that there's no way this can fail the cast (perhaps add a comment as to why - unchecked casts generally make me nervous).
Cool thanks. I'll add this.
> never be removed again

They would seem to get removed in `removeEventListener` below. I see your point though, there's no point in binding this for non-touch devices.
Test giving the xy_range a ```ccrs.Geodetic()```.
Can we avoid using actual data at all?
Would be tidier (perhaps) if this took ```cube```, rather than ```cube.data```. See later comment.
remove references to cravetix
We seem to think this comment is not technically accurate now?
Is 0644 the file permission on the remote host? File permissions should probably be preserved.
Display links to the duplicated devices
probably should go at top of file.
I don't really know what's going on here, but if there is a uniqueness issue, should we consider using:

`uniqid('', true)`

?

http://php.net/manual/en/function.uniqid.php
Let's put these up top, preferably before their usage.
https://github.com/rails/rails/pull/7851#issuecomment-9175762
Actually, this is not the right thing to do and will give the following warning on PostgreSQL 9.2: `warning: embedding a directive within macro arguments is not portable`.
For some additional context, the database has a function srandom() that it calls during backend startup to provide a random seed.for the process as well as functionality to allow users to set random seeds.  It is not appropriate for you to mess with the random seed value in this way.   If, for some reason, we were to want to set the random seed directly it should be done via the database porting layer and call srandom() instead of calling srand() directly.

To that end it is more appropriate to use the random() function supplied by the database porting layer than to call rand() directly.
i'll probably steal this for sumo if we don't switch to responsive/adaptive whatchamacallit layouts
Ok, thanks, fixed it.
Use a list here (to avoid quoting issues on the off chance some path contains spaces).

Also, technically README.md is in `HOMEBREW_REPOSITORY`, which is not guaranteed to be the same as `HOMEBREW_PREFIX`.

```rb
system "#{sbin}/logtail", "-f", "#{HOMEBREW_REPOSITORY}/README.md"
```
Ich meinte 200er bereich, aber !=200..
This causes a change in behavior where if no `links` have `sr_id == sr._id`, a `StopIteration` will be raised instead of the expected fallthrough to the `raise NotFound`
Done.  These are fake poms anyway - just used in tests, and never deployed, but it's better to correctly self-document.
This seems to be a private method, thus prefix with an underline.
I placed sys out into beginning of the loop.
The loop is interrupted randomly. Sometimes after 3rd, 4th, 7th iteration. Depends on thread scheduling of the OS. It's normal because the main thread is waiting for join in the test thread, and then it's interrupted. So this must be non-deterministic which is normal in multithreading.
Will there ever be a case when the last frame on the stack could refer to a parent frame and not this frame?
I improved the comment to explain it a bit more :)
why is bind needed?
Should this be `highlighted = this.elements.slice(0)`?
Ok, I think I got you. I will do those changes, remove the query argument in ```_showSearchResults``` and pass the query string through the templates. 

As you are having a UI Freeze today, I can still add a commit to this pull request right?

```--``` Thank you for finding this useful! I am new to this process :)
I understand, but the current check is good enough. I don't think any other type of attribute value hint will have values ending with '/' and still want to keep the code hints open. Until we have a conflict from other types of attribute value hint we should be ok with this logic. Otherwise, we have to introduce a new member flag to distinguish between url hinting with not-yet-known attr hint type.
This code is getting triggered if you run c9 locally and inspect stuff in Firebug, sadly. Kind of a bummer for developing c9 addons, at least in my experience.
CSB
Hey this line looks copied from somewhere else (the "Unknown [%s]" part). Is there a way that it can be refactored?
```ruby
    def read_yaml(base, name)
      begin
        self.content = File.read(File.join(base, name))

        if self.content =~ /\A(---\s*\n.*?\n?)^(---\s*$\n?)/m
          self.content = $POSTMATCH
          self.data = YAML.load($1)
        end
      rescue => e
        puts "Error reading file #{name}: #{e.message}"
      rescue SyntaxError => e
        puts "YAML Exception reading #{name}: #{e.message}"
      end

      self.data ||= {}
    end
```
Use createContextualFragment instead; then you don't need to worry about removing this wrapper div
Also, can you add linting for the HTML, CSS, and possibly JS in the public directory again?
Is there a reason to keep it?
Looks like there are a few indentation fixes to make in this file.
Does this need to be inline?
Do you need to specify `font-style: normal` here or is that the default?
Instead of `../Login_form/`, just `./` will be fine (if target is within the same directory).
This should probably be an exception object.
The output stream interface does not emit any events. The only reason why the output stream implementation emits events is because it is also a ReadableStream.
Harry, could I do something like this instead?

if !session[:cas_user].blank?
      CASClient::Frameworks::Rails::Filter.logout(self)
end
referring to `@db_with_snapshot` here doesn't really make sense.  It should really be just `@db` or `@database` or something similar.  The step doesn't specify that it's a database with a snapshot.
I think the shell can be made unaware of "wait", but instead just always interpret the wait flag on the response message. That seems like a much more general strategy.
这里的require nginx version 有点歧义。用户可能会跟nginx的版本搞混了。我一开始以为是错误信息。

搞成"dso module version"?
Is entry an array? Can't you just `entry.map &:to_i` if so, or does it contain more than the first two elements?
I would name it `foreman_create_environment`. `set_environment` may be confusing in `KTenvironment` after this is included or it could colide.
You should add 
  Provides:     katello-headpin-cli = 1.0.1-1
What if you get redirection (300)? You probably want to use OpenURI intead.
True. I will fix that.
why removing all these spaces after ``:`` ?
Nothing can be global, it needs to either be done by the caller or we do it automatically as part of the call. TBH I don't see a problem with doing it on demand, nobody is going to call this in a loop, and if they do then they deserve what they get :smile:
When you have parameters that take a bool or you pass in null, use the optional parameter syntax:

```csharp
Stop(connection, notifyServer: false);
```
Yap, for escaping createTextNode is a better way to do this, this related to the issue that above mentioned, I will try to apply this technique in a following up.
1. Size bloat is not about RAM, it's about storage space and CPU cache size. On devices both are more limited than on desktops.

2. Do you always build with -O3 on desktop? I do it if a) it is CPU-intensive application doing some heavy math, where -O3 is really going to help; or b) if I compared -O3 with -O2 and there's improvement
Not a huge deal but I would do this:
{{{
def _trace(func):
    if DEBUG:
        def run(...):
            ...
        return functools.update_wrapper(run, func)
    return func
}}}

In other words, if DEBUG is False just pass through the original function instead of a wrapper.
}}}
Let's deal with this in its own pull request. We'll need to check this won't cause validation errors in cases that we can't get it.
Will revert ...
Funny whitespace here.
I thought only the assertions needed to change.  Why are these changing as well?
could you name it ``namespace`` instead of ``ns`` ? It would be more readable
Add a line space before this line.
Same applies to the other controller actions like this.
Should be Size instead of BaseSize. SizeF is not applicable.
Ten dvojstlpcovy layout je povodne z kiosku, aby sa zmestil zoznam co najviac hodin na obrazovku, pri vyhladavani hodin je potom viac detailov, ktore sa daju vypisovat v podrobnom vyhladavani (+ dalsie veci ako napr. https://ne.st.dcs.fmph.uniba.sk/issues/118). Pri zobrazovani volnych miestnosti je tych informacii podstatne menej. Ak by sme to chceli zjednotit, bolo by treba znovu navrhnut ako by sa tie podrobne vysledky (searchSuccess) mali zobrazovat (btw, to bude treba aj tak, hlavne aj zadavanie na nieco s lepsim UI ako vyhodnocovac vyrazov)
Weg it.
channelInstance doesnt get set any where either
Is this needed? When you use ```File.open``` with a block, it closes it for you.

http://www.ruby-doc.org/core-1.9.3/File.html#method-c-open
Add a comment above this block saying something like "Here we handle manually selected modes".
A couple of minor things. I've learnt something, I didn't know about overriding `__dir__()`.

It's OK to return wrong names if they're wrong in the module, but we should make sure it doesn't crash IPython.
move this assignment to field declaration
all copy paste here but seems to work as expected.
Laravel 3 and Laravel 4. Laravel 3 uses mostly snake_case while Laravel 4 being PSR compliant follows camelCase.
Женек, верни файл и сделай коммит, а то удалю этот пулл реквест
This is meant to be a proper comparison, no? It should be telling us how it compares. This would most likely lead to wrong behaviour. I'm also wondering whether using a binary search is worth it when we're only really going to have three or four entries. Using `git_vector_foreach` and breaking when we hit the one we want would be simpler to read IMO.
See if we are doing the only the selected layers.
Yeah. I actually left that in thinking it would be an easy refactoring for someone coming to OSS and Anita to work on.
Relying on globals like this is generally bad style.  But I don't mind too much if it's hard to refactor away.
Oh, that is for jslint. keep : remove?
This should be indented to the same depth as the `</div>` above it. And the `</div>` on the next line should be removed (one too many closing tags).
Actually we used to do product= and we still do the same thing. But I posted to the forum anyway about the s/tags/topics/.
s/storeage/storage/
This code isn't covered by those tests because an existing review doesn't exist. You could duplicate that function and add an existing review before you `post()`.
тут використовується:
https://github.com/webkmua/fwdays/blob/701f4d2c29ea7a29644b2e50ce17c087a91d747e/src/Application/Bundle/DefaultBundle/Listener/MCDoctrineUpdateListener.php#L28

при проведенні платежу мені потрібно перенести юзера в групу оплативших, для цього я маю знати хто саме оплатив і який саме івент. $entity->getTicket()->getEvent()->getSlug() | $entity->getUser()->getEmail()

я вважаю що це не зайва інфа, знижка можливо і зайва, а зберігати для якого саме квитка цей платіж логічно.

як варіант можна дописати функцію в лістенері, яка буде повертати квиток по платежу вибіркою із бази.
I've removed the .rvmrc from the project. It does not belong in the repo.
Your assumption is that you will never make a mistake. This is a wrong assumption. Everyone messes things up eventually, and when it happens I'd like to mitigate the problem. That's why there is a strict_variables mode in twig, not because you don't trust your data, but because you may not notice problems at development time if they only happen in weird conditions, and you don't want to have a blank page for a strict warning while things would otherwise run fine.

Similarly, we have escaping by default, not because we don't know which data to trust, but because when people have to mark dangerous data by hand, they mess up eventually and end up with XSS leaks.

To sum up, I think this is a great feature for writing robust apps, and I don't think generating broken links or empty links matters much, I just want the page to show up, and an error to end up in my mail box so that I can go fix it when I have time and not at 3am when a cron job imports data and blows up the whole site.
wouldn't it be easier to inject the logger through a setter to avoid having to duplicate the constructor injection here ?
I know that setter injection is not supported by MonologBundle to change the channel of the logger but I'm planning to add it in the coming days
You should also use an annotation here.
I was wondering but:

- the component requires php 5.3.3 because of issues w/ 5.3.2
- 5.3.3 seems to have bugs w/ apc,
- reading annotations has bugs before 5.3.8,
- current version is 5.3.13,
- sqlite is no more the default storage.

Should I revert ?
The file is called `hiddeninput.exe` all lowercased
scaffold 投げ捨てたい
I'm concerned that this code is too functional at such a low level. I can imagine it being a hotspot. Obviously we will see when we do performance testing but usually you want C-like code when doing operations like this one to avoid a lot of CPU and memory overhead.
man inja comment dade boodam !
chi shod
bebin dige nib ina ro nemikhad
khdoesh dare
ali.md/nib ro ye dor bekhoon hatman
Precompute this value, which can be stored in a static member.
Does `if groups[0]:` not exclude the `None` case?
I wondered as well though if we should use `groups` inside the `if` in those cases.
Here's the cause of the crash: this should be

roi.xbegin += blocksize;
Minor point, but Python ```library``` or ```package```? 

In the Iris INSTALL file, we describe Cartopy as a package not a library.
This should be public, not internal
Couple nits here ...

1.  `\d` is unneeded.  it's a subset of `\w`, which includes [0-9]
2. Technically I believe charset names can include any US-ASCII printable character. See http://www.iana.org/assignments/character-sets, so should probably use RegExp that allows that. `\u20-\u7f` (??? No idea if that will work. http://en.wikipedia.org/wiki/ASCII#ASCII_printable_characters)

Also, slightly simpler implementation (?):

    var charset = /charset=([\w-]+)/.test(mimeType) && RegExp.$1;
    return charset || 'UTF-8';
Should we attempt to create an instance of the same class as the original?
This is a seriously well done test & mock setup. Nice work.  If it feels like it's too much goofiness to test this, let that push back against the code design as you see fit.  I know we're kinda bound to Express 2 for now in our other libs, but take the liberty. :-)
Actually it is keeping the attribute - however instead of this attribute-def it registers a read-attribute handler, just returning the address element value.

Not sure if that is what Brian was referring to though.
Nope!  Actually no idea how I even committed that.  Good spot :)
Dunno if this comment is necessary, but at least its wrong, as this isn't an array anymore.
Only `.htaccess` is needed. The rest are covered by the directory protection further down. Any files outside `./config` can be viewed, no problem.
Yes, if we are planning to build strings like 'Francisco Jordano (2)' that must be localised.
In my work on #808818, I've discovered that device storage does not set the type property for .m4a and .mp4 files, and that it uses the type video/ogg for .ogg files.  So maybe using file.type isn't the right thing to do here.  Instead, I suppose you could look at the file extension yourself and map that to a reasonable file type.  But it looks like the bluetooth transfer app opens up even when type is not set, so maybe it will work okay as it is.
the `data-l10n-id` is incorrect.
Can we add another `this._popup.addEventListener('load'...` here instead of doing the _ready_ custom event trick?
This way the popup will be loaded and `this._popup` will be set when we call `this.postMessage`.
DEFAULT_TIMEOUT var is not defined here, (function scope)
this is not consistent with the `data-type="edit"` we use for `edit_mode.css`
we really don't use it anymore, I just forgot to delete it from the repo :) removed now.
using the BB <progress> where viable.
It wasn't there previously :D, look the line #58
you can use `event.application` for the 2 previous lines as well
could probably use &@@handlers
@stevenbristol I mistakenly typed `inline` before, but corrected this shortly after. I agree that it's generally not used, but this might be useful to cover the edge cases.
rake works on Windows. Why wouldn't it?
Rather than stubbing this (which is potentially brittle--i.e. the `squish_descriptions?` method may not actually exist), can you just set the config option?

``` ruby
RSpec.configuration.squish_descriptions = true
```

(And this same comment applies to your other example below, too).
因为类型和serverTime nowTime不是一个东西，最好换个名字，
endTimeAttrName之类的
Typo: resulting
maybe this should be separated for linux and use `ldconfig -p | \grep -i yaml` to find yaml?
Like before, why define `keyslices` to only re-initialize it a few lines later.
Ah crap, a beginner mistake :)
Will fix these up on Monday.
If the `colors` array changes, then `radioGroup` binding will no longer work properly for any of the radio buttons.
groupString.length==0 might be a more reasonable query to make here.
I think the default ``gain`` value should not be None. When I do aperture photometry in the far-infrared or mm, the gain and poisson noise is irrelevant.
I think you wanted 'tag=t' here?
Hey, did you find that after removing 'resize(w,h);' in 'Create' method, the created window's height and width are both zero before invoking 'setFrameSize'?  The touch and display area will be wrong.
I fixed this by make the width and height to 100 by default. But I don't think this is a good solution. Could you check this issue?
I wouldn't even print the warning, it'll create more confusion than anything I'm afraid.
I thought you abort the build if `VERSION_TAG` is not set.
Must have been drunk when I did this... I completely missed the - existing - getters/setters :D
It actually was model, but I messed up the docs. Fixed.
TBH, I just used the simple stupid approach. I have no idea what actually works or not on current firefox version.
This would be a valuable simplication, but I'd prefer doing a dedicated context-menu cleanup. There is many stuff to simplify in this module.
It sounds better to keep a safier patch if we want to take it for an hotfix release.
I just realized that I have made a mistake. This version of `promised` hasn't even been proofread and should not have been included in this pull request.
limitTo is the white-list of file to accept in xpi file, used to implement strip-xpi feature.
I've added comment on top of all write* functions.
Missed this in the conflict resolution. I see set_password.ejs uses domain. Thanks! Removed.
> Does this rpm install /service/browserid-*?

Yes

> Does this rpm install /service/browserid-*?

I don't believe so, we discussed this point in IRC.

> Are there already %requires entries for whatever rpm installs /usr/local/bin/svc?

No. We discussed this. Using `%post` is a temporary solution. Please feel free to fix this, I don't know enough to make that change.

Gene was okay w/o that dependency and moving this solution out into puppet once a long term solution is settled on.

> Is the order of restarts important, such as static and browserid before router?

I don't think so. @gene1wood @jrgm ?
multi-line strings shouldn't be used as comments, just use a multi-line comment instead (start each line with `#`)
Yeah, there are/were lots of these in the code from Google. Some I had to wipe out to get the formatting correct. A re-thinking of all that old markup probably wouldn't be a bad idea.
What do you mean with restored? The length doesn't get changed with write actions.
You may want to add an assert for the page title, using ```Assert.contains``` because the tag name may be different for different test runs.
this is suppose to be like this. @nvcWilson said so.
extract method `uncomment`
have updated this pull request with warn level logging
A lazy coder would have typed hw_help here and been done. Thank you for the cleanup!
This can replaced by `abs` if #1630 is merged
removed the default value
Since the array structure expected is flat, we can simply do an iterator_to_array() here. (and elsewhere).

I'll take care of this during merge.
@hardythe1  @jayparikh111 Please comment on this line as it is not self explanatory.
I dont know what should be in the properties fields in HTML storage. So I just keep the XML form. And the XML form of Multiple Choice have <label> field. Actually, I forgot to add the key field for "Multiple Choice", will fix it
I don't know, I guess not. I think it will depend on whether or not every cursor uses the same color set. If you want, I can make these static values in the BaseTool class, perhaps.
I've always thought that playing the hurt animation for zero damage was a bug or an oversight. :P
Ok. I'll remove it, but, is there a reason not to include it? 
I'll also make a pass back through the code to make sure it adheres to the formatting advice on idiomatic.js
They were moved to SpeciesViewTests
Tämä order by ei vaikuta queryyn, koska myyntipvm ei ole selectissä ja panttitili-rivejä groupataan. Mitä tässä haetaan?
you should tipehint the first argument if it is really a ClassMetadataInfo
Awesome! That's basically all I needed :)