labofsahil/github-event-dataset-2012 huggingface dataset:
this is easier with the new org auth stuff but that's not in yet.  maybe just add a fixme for now till that branch merges
:) this makes me happy
There's no need to unlink that file yet because it doesn't exist yet. It's
just a pointer.
On May 29, 2012 5:55 PM, "Tim Santeford" <
reply@reply.github.com>
wrote:

> > @@ -146,7 +147,7 @@ function install() {
> >      }
> >
> >      # Remove tempfile
> > -    @unlink($source_package);
>
> What is the reason for removing the @? I believe this is needed to prevent
> the script from halting it the source_package does not exist.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/phpfog/pf/pull/10/files#r897281
>
I had forgotten about updating pulp-dev.py. Does the RPM need to be updated as well?
Probably worth noting in here how changing a schedule by adding/removing a recurrence will affect the remaining_runs value for that schedule.
excellent point. It does not return anything, and I'll make a note of that.
And 1 here
This one is copied from how Debian has been building for GNU/kFreeBSD for the last year or so. I'm not really sure what the implications are of using a different string here - can we just change it to kfreebsd (both here and in native/Makefile)?
This kind of change is always scary...
commit 60aaf044f3fdbeb1cf702b144cb0597ce4988020
Author: Marton Balint <cus@passwd.hu>
Date:   Sun Oct 2 16:28:36 2011 +0200

    audioconvert: add av_get_default_channel_layout public function


its been in ffmpeg releases since 0.9; libav happened to pick it up only a few days ago.

IMHO its better to call avcodec_guess_channel_layout in case its not available instead of copying this.
This is most likely the full path to the media file and not the path to it's parent directory so you are missing a URIUtils::GetDirectory().
Would a m_data.array.reserve() make sense here as we know the size of strArray?
Hoe bedoel je precies? te veel indenten kan toch niet echt lijkt me? :P Wat zou ik in een class moeten zetten?
Do you propose to have a separate jobset for testing this? An alternative would be to drop the "minimal" function argument and have a tests_minimal attribute set within the same jobset.
why do you remove "use strict"?
Both solutions are strictly equivalent:

```php
if ($name instanceof Twig_SimpleFilter) {
    $filter = $name;
    $name = $name->getName();
}
```
@CodaFi Because turtles wrote AppKit and I copied AppKit headers. I should have copied UIKit headers, knowing that lemurs wrote UIKit. /cries in corner.

English: Yeah, go blame AppKit headers as I fix this issue.
@maxgoedjen Ah, there we go! Time to switch to this syntax then! :)
I'm not entirely sure what exactly the problem is. Definitely I see an issue with moving cells between different sections in the current demo, but I also do not see much of a difference with these changes in place. What exactly is the issue here?

In the demo, there are always 25 cells in each section, but in a real application there will probably be a variable number. Does your patch resolve the problem in a real use case?
preg_split("/\s*,\s*/", $openOnString) is more performant than array_map('trim', explode(',', $openOnString))
This is in the prldgd scope already!
Good point! It turns out this is error-prone for some time zones e.g.:

```js
var d = new Date(0);
d.setFullYear(2012, 0, 1);
d.setTime(+d + 100 * 864e5);
console.log(d);
```

```
$ node tz.js 
Tue Apr 10 2012 01:00:00 GMT+0100 (BST)
$ TZ=America/Scoresbysund node tz.js 
Wed Apr 11 2012 00:00:00 GMT+0000 (EGST)
```

Rather than fiddling with offsets directly, it turns out there's an elegant solution: simply pass the full day-of-year to setFullYear and it will automatically wrap to the correct month and day.
I think that $name would be int only if both $name and $default are ints. Imagine:

```php
/** @persistent */
public $lang = 'cs';
...
$class::getPersistentParams(); // [ 'lang' ]
...
foreach (...)
$name => null, $default => 'lang';
$name => 'lang', $default => 'lang;
$params['lang']['def'] = 'lang'; // instead of 'cs'
```

Would be better to pass $default value to $defaults[$name] if $name is not int, wouldn't it?
Use CharsetUtil.US_ASCII instance here..
Пустая строка нужна
Why begin..rescue..end? if an error happens here we'll never know, the test may be failing...
Renaming these tests doesn't add anything.  Can you please revert these?  I'd like the pull request to have one topic, which is "updating the documentation".

Thanks.
Yes, my bad. I have just pushed a new version.
Great, I just think you don't need the `else` condition at all, because you're returning in the if case, so the else block could just be after the if. Sounds ok?
Oh, I was wrong, sorry. My example will works fine with non-destructive version of this method https://github.com/rails/rails/pull/6060/files#L0R58. In ruby you can't change value of self, so you need to do something like this:

```ruby
def deep_stringify_keys!
  stringified = deep_stringify_keys
  self.clear.merge! stringified
end
```
What you think about this refactoring?

```ruby

def rewrite_extension(source, dir, ext)
  source_ext = File.extname(source)[1..-1]

  if !ext || ext == source_ext
    source
  elsif source_ext.blank?
    "#{source}.#{ext}"
  else
    find_in_sprockets(source, ext)
  end
end

def find_in_sprockets(source, ext)
  pathname = asset_environment.resolve(source)

  if pathname.to_s =~ /#{Regexp.escape(source)}\Z/
    source
  else
    "#{source}.#{ext}"
  end
rescue Sprockets::FileNotFound
  "#{source}.#{ext}"
end
```

Maybe you can find a better name to `find_in_sprockets` method.
`namespaced_path` is consistent with `namespaced_class_path` and `namespaced_file_path`.
The line
Also, the following test does not give me any warning (though, I think the error is due to some other thing being broken in the compiler, not your changeset). But I think it should give me the correct error (type not found), instead of silently compiling:

````Scala
class TailRec {
  Some(new AnyRef) map { phooie =>
    @tailrec
    def inner(i: Int): Int =
      inner(i + 1) + 1
    
    inner(0)
  } getOrElse 42
}
````

(I forgot to import `scala.annotation.tailrec`).
Why not just strip margin afterwards? I see this avoids calling stripMargin on interpolated data, but is this intentional? And, if so, wouldn't it be better to state so explicitly, instead of relying on "safe" to relay that information?
Why this line has been removed? Why there's no impact on test output?
`ifelse()`是一个函数，它和if-else语句（`if (cond) x else y`）是不同的。
The token '{filter}' is recognized and it will be replaced with the grid filters selector.
I suggest remove this private method.
Da der Owner nur bei UserCamps gesetzz ist, würde ich den Owner immer
setzten... Auch redundant... Um so die Logik, den Creator zufinden, zu
sparen.
Am 23.06.2012 06:23 schrieb "Urban Suppiger" <
reply@reply.github.com
>:

> >               $camp->setCreator($me);
> >
> > +             // New UserCamp
>
> Brauchts das hier? Der Owner ist ja bereits im Camp selber eingetragen...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ecamp/ecamp3/pull/103/files#r1037817
>
`sleep()` but I didn't see `uv_sleep()` exists.
scan-build is mistaken here, it thinks req1 can alias req2. But a request should never be in the queue more than once (if it is, it's a bug) so there is no possibility of a double free.
I would change this to this:

> You are receiving this notification because a topic you bookmarked, "{TOPIC_TITLE}" at "{SITENAME}", has received a reply since your last visit.
This expects locate_source_files() to return an array, but it only returns a string containing the path to the first file it finds. That behavior should be changed as I suggested in my comment on that method.
this is not longer supported
not 8666?
Alternative suggestion for name: environment_project
I'd change this to type "Accounts"
Why isn't this on the FormsAuthenticationConfiguration?
Agreed- there must be a valid user account  with sufficient permissions in order to login
Can you break that long line?
should be in the for loop
ещё надо создать файлов для каждого умения вирусов в папку lib/essence/virus. Там часть умений уже есть. Возьми за пример любое, например, lightning. Только методы main_turn пока пустые оставь, без логики.
The text of this error message was (and is) wrong. It's less than 0, not 0 or less.
true but for me it makes the flow easier to follow
Sure, that's what ``except Exception`` is for.
Wil redact comment possibly, but probably not method or name. It returns an array of aggregated values from each model in the collection.
Does tox support pypy? if yes adding it here might make sense.
I did `git checkout upstream/master -- django` and it does raise a runtime exception for me: https://gist.github.com/3934659. What's your default locale?
Is exec actually used anywhere besides in this file?
This seems like a step backward in error message quality.
Those kind of tests are not good ones in general, because they are unrelated to the problem being solved. What if IE10 has this problem as well? Some test that checks for the broken condition is best.
Interesting, I'm curious what it might be.
15 days to change this part lol
check your indentation here, doesn't seem to match what this project uses, looking at the diff
An easier way to do this:

    pizzas.extend(read_data())

Just a helpful tip :)
Initially, my solution is quite similar to your suggestion above. During internal review in Beijing, we think it is not appropriate as the used formula is not fully validated in various conditions. So the short form statically call the parallel classification.

I will check with others to see whether we should add this again. Thanks.
Jiras for known issues remaining
Though we haven't been very consistent in the past, SConstruct files are python code, and should follow PEP-8 style.

conf.env.Replace(CXX=GetOption("cxx"))

Note where whitespace has been removed.
Ideally this should really just be ``self.playback = playback_provider`` imo.
You could maybe get reuse across the different core controllers, but you'd get more code everywhere you would call it, which I believe would be a net increase.
Please consider using 
```rb
args << '..'
mkdir 'itk-build' do
  system 'cmake', *args
```
per the cmake man page on constructing the command line (even though it may work otherwise).
Thanks for doing an out of source build.
This should be cleaned up a bit:

```rb
system "scons",
              "-j #{ENV.make_jobs}",
              "V=1",
              "optimize=1",
              "debug=1",
              ...
```

one per line makes it easier to see what is going on.
new_domain instead of newdomain
Agree. Iĺl change it.
вот тут: "вы можете использовать любой из клонов на любом из клиентов, для того чтобы..." , по-моему, ещё надо запятую передвинуть к "чтобы"
Your typo correction is correct. Good (bad?) thing this function is never used!
You don't need to require should unless you are doing:

     should.ok(true)
8 spaces indentation?
[ so now github email integration no longer works ... :-(]

Using --continuation-indentation to solve the qw/ / issue results in a
different formatting of these types of sections too:

    $params{'-input'} ||=
        Pod::Find::pod_where( { '-inc' => 1, '-script' => 1 }, "$bn-$command" )
        || Pod::Find::pod_where( { '-inc' => 1, '-script' => 1 },
        "sqitch-$command" )
        || Pod::Find::pod_where( { '-inc' => 1, '-script' => 1 }, $bn )
        || Pod::Find::pod_where( { '-inc' => 1, '-script' => 1 }, 'sqitch' )
        || Pod::Find::pod_where( { '-inc' => 1, '-script' => 1 },
        ref $self || $self )
        || Pod::Find::pod_where( { '-inc' => 1, '-script' => 1 }, __PACKAGE__ );

Note the less-indented rows:

        "sqitch-$command" )
        ref $self || $self )

Find one thing worse than the other?
As stated before I do not think its good practice to not use { } on single-line statements in conditions and loops. This is C-style and I do not care if Uncle Bob does it as well. But thats just me ;)
This is everywhere in code.
That's exactly right. I'd have to be programmatically adding/removing scrollable regions on orientation change, and ideally also saving their state, which would probably take me all day. (They really shouldn't scroll independently on landscape—in addition to making no sense, this is also what was breaking the layout before.)

On Friday, May 18, 2012 at 11:42 AM, Dan Imal wrote:

> > @@ -17,6 +17,18 @@
> > .region.google-map {
> > border-bottom: 1px solid $border-color;
> > }
> > +  
> > + .region.child-list .inner {
> > + @include flex-column-container;
> >  
>  
>  
> It seems odd that the two columns don't scroll independently in portrait. But I suppose to do that would require that they scroll independently in landscape too, or require a lot of shenanigans in the capability to rearrange the dom on orientation change.
>  
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Toura/mulberry/pull/460/files#r845869
>  
>
Also, since this both creates and inserts the menu, maybe it should be called `addMenu()` instead. `createMenu()` sounds like it will create a Menu object but not necessarily do anything with it.
Ah nice. Fixed.
Okay, lots of no nos here.
- Help text should not be in a label.
- if you want help text to be on a new line, don't use help-inline, use help-block. Please familiarize yourself with bootstrap forms: http://twitter.github.com/bootstrap/base-css.html#forms
- Be consistent with label background colors. Absolutely no background-color modifications in the style tag. http://twitter.github.com/bootstrap/components.html#labels-badges
- labels are either span or div elements, not small. put the small tag inside the label if you wish to make the text inside the label small.
Initialize extra_data to None in an `else` instead of unconditionally.  Reads better.
I think this would be better as a `format` method.  Also you need to export all S3 methods with a roxygen directive like `@S3method format rel`
This is controls, filter contain only the final values that launch a search job
In this modern age of typography, it may be good to distinguish between hyphens (-) and the various dashes: en dash (–) and em dash (—). This code here appears to be dealing with a hyphen.
So there is no difference, because I just moved the </div> tag  at the end of the JS code.
OK. We give registration form class in registration view, if I use it in view piplmesh runs but language still isn't displayed properly.
Could make this a bool as well (=true)
Don't call functions before you declare.  Move function definitions above callers.  See same issues below.
hahaha my bad, I'm retarded. Carry on.
Yeah, that's a lot nicer. I'm curious about why is this an issue to fix up here though? Should we always ensure that lengths are cached in loops during review? I like being speedy, but catching all of these seems more pedantic than necessary imo.

Happy to change it regardless.
As much as I appreciate the decoupling effort here, it's probably easier to just use `butter.editor.openEditor( "share-properties" );`.
These will just cause silly export errors. Let's remove 'em.
Thanks for cleaning up :)
10 is magic number here
We're writing tests for the Deployment class here, but we're also stubbing methods on the Deployment class that we're testing.  This is usually a dangerous thing to do - your stubbed methods can easily change the behaviour of the object you're testing in a way that hides a bug.

As a rule, I would strongly prefer to leave the object I'm testing intact, without stubbing anything on it.  This can sometimes be quite tricky, and if you find that you're having trouble testing a class without stubbing some of its methods (ie. using partial mocks) then that is often an indication that your code would be improved if you refactored the class and split it up.  Then you can test each new class independently, mocking the other classes as required.  This can be a controversial topic - there is plenty of code out there to help people write partial mocks so obviously there are lots of smart people who think it's fine.  I'm not one of those people, though! ^^
Corresponding, not according.
Převážně čerpám ze stylistické příručky vydané Microsoftem pro oficiální překladatele Windows a Office. Vzhledem k tomu, že byla připravena ve spolupráci s Ústavem pro jazyk český a zabývá se převážně stylem a ne konkrétními překlady považuji většinu těch doporučení za obecně platné
Any reason why these two iterations over the same object can't be done in the same loop?
I would pull the exception outside:
```ruby
raise "Please test request.uuid with Rails 3.2+ ^^^" if Rails.version.starts_with? "3.2"
def thread_locals
  # ...
```
Thanks for the review.

I'll check in to this when I return on Thursday.  If it's not too much will submit an update to this request; otherwise, we can probably merge in the current functionality to make it available and I can add another pull request to refactor it.
These should be given better names (like KB_PIN_WIEGAND_0) and declared with the others in kegboard_config.h
We can't post via ajax to another host so everything is sent via the query string w/ jsonp.
So if there's no type where do hub instances come from? What other part of the system overrides that behavior?
In [Backbone-Require-Boilerplate]http://github.com/gfranko/Backbone-Require-Boilerplate they are doing the same thing. Instead of declaring `lodash: '../../../aura/lib/lodash'` they are dropping-in lodash as underscore replacement in this form `underscore: '../../../aura/lib/lodash'`.
These blocks should be ordered as the [CSS styleguide](https://github.com/alphagov/styleguides/blob/master/css.md) outlines.
Yes, it is the same with Zhuyin. If non-bopomofo key is pressed or the input is two long, the first candidate will be seleted automatically.
Maybe? I am not an Astronomer, so I don't know what all the coordinate systems are that you care about.  What about Euler angles, or do you just use quaternions instead?

This could be changed to something like `Coord(*angles, format1=....)`  but that would have the downside that if an arbitrary number of angles are allowed, then all the remaining arguments *have* to be expressed with keyword=value syntax.  Alternatively, you could take @wkerzendorf's idea of allowing a tuple.

Also, Not sure how I feel about the format1, format2 thing.  Why not just require `Angle` objects as the arguments?  Or is that too Java-ish?  As an alternative, I might allow each "angle" argument to be an *optional* tuple.  If it's not a tuple, then the default format is used.  If it is a tuple, then a 2-tuple of `(angle, format)` is also allowed.
It looks like this doc page didn't get the `logger` => `log` change mentioned previously.
Yes -- but does that mean it can't be overridden by a subclass?
I think we should fix up post-merge.
@laanwj Will this interfere with status bar warnings or do they only work if there is a connection?
maybe clarify the message to "detach the database"
Yes it shouldn't happen during bake.
is there a https url as well? we should also check for that if there is one; in fact, we'd prefer it.
We're not using 80-character line limits; this is ugly.
This is just a matter of taste maybe, but can we have a newline between the closing bracket and the next docblock? I kind of depend on Ctrl-Arrow Down for navigating the code :-)
Am 27.10.12 20:35, schrieb David Buchmann:

> if you render piece by piece, you are still free to not render all in
> all places. if you specify the class here, i think this adds no
> flexibility as to what should be rendered, in the contrary. you could
> have 2 RDF types that map to the same class.

sorry, I was a bit sloppy when writing my reply: I only used classname 
since this is what we used in some earlier discussions, in my own 
createphp installations, I use completely made-up strings as 
identifiers. So e.g. I have createphptype1 that uses storage_class_a and 
rdf_type_a and then I have createphptype2 and a couple of others that 
use the same storage class, and/or the same rdf type, or something 
completely different for both. It's sort of how the property names do 
not correspond to either the rdf property names or to the fieldnames in 
the storage backend. They are just internal createphp identifiers, not 
meant to be used somewhere else.

>
> but before, the controller was a RDF type name, not a class name, so
> using the class would change things. expanding the namespace also
> changes things to some extent, but i think it is the only possible way
> to properly support namespaces (somebody could need to map a NS to a
> different prefix for namespace collision reasons - this is the reason
> for the NS vs prefix stuff)
>
> when we use the RDF type to create new objects (with the VIE type
> stuff), i think there is no sane way to have multiple classes mapped to
> the same rdf type (which would be the only reason to use class and not
> type here)

Well, it works to a certain point, but it breaks down for the create 
case. You can solve that easily in a project-specific context (f.x. by 
saying that everything you do uses partOf to point to the parent), but 
you can't write a reasonable and generic solution to a problem where 
every piece is variable. So the solution involves taking away some of 
the flexibility, in this case by deciding that you can only have one 
configuration per RDF type. Like I wrote earlier, I guess this is 
inevitable, but I wanted to point it out nonetheless (and we should 
probably add this to the readme somewhere)

>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/flack/createphp/pull/28/files#r1960131>.
>
Also cleaned up the test suite, so the styling of the tests are the same, and no longer a big mess of different styles.
Je to vzdy pismeno. Toto konkretne je male L. Jeho vyznam je urceny v rozvrhovom xml-ku (a kod sa pouziva na jeho referencovanie).
> nulltoken authored 16 hours ago

Man, I can't get away with any ugly hacks with you guys. By time I figure out a hack, you've already implemented the feature I wanted. 

Woo! :beer:
Although, all the configurations are set to build x86 - I might be wrong.
I think we also want to disable building the manual here too
That would stop the whole command if only one package is missing. Here I am using next() to skip the missing one and still proceed with the rest.
OK, will add __repr__(). I'll test wil file:// appended to the beginning.
above block, define a mode that start on `open`(%%xxxx) and close on `%%end` (otherwise it is raw-text)
since this method is called once per node in the group, it should be ok, right?
see response above :)  but I should be concentrating on the texi.  The C++ is like a siren calling the docuemntation guy onto the rocks!
That is shiny.
So, the behavior as implemented appears to be to call `creat()` on each file in the head tree. It would probably be nice to let the user specify options that chose between `creat` (which is actually `O_CREAT | O_TRUNC | O_WRONLY`) and exclusive overwrite (i.e. `O_CREAT | O_TRUNC | O_WRONLY | O_EXCL`).

I'm curious to hear @tanoku's opinion also, but I wonder if we might want to allow other parameters, such as: bypass filters, checkout to something other than workdir, checkout something other than HEAD, etc. If we were to add these things, you'd just pass an options structure in where NULLs would set the various options to their defaults. I just don't know if anyone would use these options...
update comment to reflect whitespace
Right, but PHP urls should be generated with:

{{ php_url('/firefox/foo/bar') }}

The reason is so that it handles locale direction correctly, and anything else that we need to do to the URL. If none of these URLs are translated, and there's lots of them, you can leave them as is though.
Probably don't want to commit this.
It IE8 and older, the text isn't rotated, but I think it's a reasonable fallback. It looks odd, but it's still readable. Here's a screenshot: http://labs.silverorange.com/files/mozilla/screenshots/ie-sign.png
Go for it ;)
Not sure yet but, this should be the latest 5 posts from, I assume, the privacy blog. Not sure we have a template tag yet for the feedparser.
Why isn't this a context manager type class? I can't see where the self.conn.close() is ever called. 

If you instead used something like:

```python
with PostgreSQLManager() as db:
    ...
```
then you can assure that the connection will be closed. 
(you'll obviously need the `__enter__` and `__exit__`)
You implemented this? Awesome! :D
Ah, that's interesting. Fine to leave it as is. But why not add it into the error object?
Tomuhle moc nerozumím, předpokládáme, že vždycky bude kód pracovat s želvičkou?
"$this->fields" remains even if " $CI->streams_m->get_stream_fields($stream->id); " return an array ( or object ) of  fields... This is because the parent class ( Driver.php ) "__set" method prevents the affectation.
YOu left out the changes I did in examples/001-standard/arrays.sf, please merge and combine those ;)
$matche -> $match
@Tobion Do you have better naming suggestion? Otherwise I'll correct the english :)
you don't need this variable as you don't use it
same as comment above
Missed one here...  Also, I believe the other case statements in PS are not indented from the switch.
By habits, use the visibility private[this]
So it is ... that makes more sense :-)
Rename all test cases to be TestXYZ.  So BasicContains would become TestBasicContains
now in add_new_set_item() in str_list_set.h
alternatively we could use cascades here too: `new StringBuffer()..addAll(_items)..toString()`
good catch.. fixed
Being explicit again? Or did indenting stop working?
Inconsistent indentations in this file
This is from the "DIALOG" building block which I thought was already in the system app so you might be able to get rid of some of this.
Why are you checking if the target is a 'LI"? I think the card can still be removed if the gesture start on the card but finish outside.
OMG. That's been an awful debugging session, sorry.
This methods are pretty similar to L#191 of this file:

copyNames
DoSetFacebookUid
mozContact.init

mozContacts.save

Guess we can refactor.
nit: indent seems odd.
AFAIK (please someone correct me if I'm wrong), we don't have secure storage, and don't know what's the best place to store this information.

Someone with access to the physical device could get the access_token and perform the operations the apps is allowed to do (as far as I remember we ask for permisions for posting into the wall?). 

Also we could have an XSS attack in the contacts app (what if a contact has a surname like '<script>alert("BAD")</script>' ... we didn't pass the security review for contacts yet, but I'm afraid this would need to be taken into account as well.

Pinging @AntonioMA for some security insights about this.

Not saying that is not the solution, maybe is the only one, just raising that could be a security problem.
That line doesn't do what you expect. `locales` will be `{"GAIA_DEFAULT_LOCALE": {}}`.
You end up reseting `locales` here, so you can just set it to `{}`.
https://github.com/fabi1cazenave/gaia/blob/4135a31fe889052b6cb96e7cd81795e830b720dd/build/webapp-l10n.js#L191
Hmm, this is more a ORM language thing that I picked up on after years of writing (:gasp: php) (also common in java/ruby orms)
_createModel is essentially what its doing if that makes it clearer.
Callback `windowOpened` is calling inside the function `handleInitLogo`... Which callback do you mean?
like this.   very explicit what you are catching and handling!
Where does "DEBUG" string come from? Something returned by the root of the site when you hit it?
Rebase(string branch) to be consistent and flexible
Can't we use the HashCodeCombiner thing? /cc @davidebbo
Given that it's really just assembling other (tested) stuff, I never bothered to bite off the complications of testing this either. Eventually it should be, but IMO it's not a catastrophic omission for now.
Should work okay for back, but not for snapping forward.
This might not be a kosher change from an aesthetics perspective, but it recursively matches all files underneath this directory.
Can you please make just test that the item status is correct. ie


    order[role].done?.should == true

or
   
   order[role].status.should == "done"
I tried to use equalizer but since it uses adamantium too many things become frozen and the code breaks badly. I will try again though.
HTML element ids have dashes instead of underscores :-)
`error-screen-view`
Here's what I would like to implement: https://github.com/fatfreecrm/fat_free_crm/blob/master/lib/fat_free_crm/dropbox.rb#L146-164

I'm not sure if / how Mailman handles unmatched emails? We use a `discard` method, which either deletes the message or moves it to an `invalid` folder.
I would actually argue that doing

```
pipe.mapTo(fields -> ('key, 'value)) { t => (g(t), t)} (implicitly[TupleConverter[TupleEntry]], Tup2Setter) 
```

reads better here.
But of course. Added
setting the variables should be done via environment file which is created by `rvm_create_flag=1 __rvm_use` - you can have a look on the rubinius flow: https://github.com/wayneeseguin/rvm/blob/master/scripts/functions/manage/rubinius#L202-212

You should update the environment file to include `export NODE_PATH="$NODE_PATH:"` and the ruby wrapper would be just:

    exec "$opal_node_path" "\$@"

rvm will take care of setting the proper environment when you run `rvm use opal`.
Instead, I would recommend: "An object that logging messages can be sent to."
Capital 'F' here.
To try to address this issue, I renamed the "associations" app to "enhancement_tracking" in addition to renaming several functions and variables with the app.
Snapshot copies should only happen as part of the main thread (during snapshot copy).  I am not sure exactly what you are aiming for here?
Yup you're right. Leave it as is.
the more typical approach is to use `defer.maybeDeferred` for this sort of thing.  Your `inlineCallbacks` example would need someth	ing similar.
`if (c.value && c.value.charAt(0) === '&' || input.charAt(i) === '&') {` is enough.
I don't mind adding underscore as a dependency as long reference it with `underscore` instead of `_`.
Thus, it is not consistent with the coding standards used by composer everywhere in the codebase
ah sorry, in the return statement, we indeed don't need to reassign
either align all ``=`` signs or none of them, but not half of them (I vote for none as it avoids doing big diffs to maintain the alignment)
check http://www.lispworks.com/documentation/HyperSpec/Body/m_w_open.htm
I'm sorry, I'm missing how this is used and why it exists.  What am I missing?

Can you add a comment at the top to describe its use?
rename to raw...
Nit: the 3rd parameter is optional, can be omitted and will be `false` by default
I would prefer `getScheme` util function that returns `null` on exceptions over try catch here.
I'm wondering if we can use a generic example instead of a slightly complex concrete one.  Imho the places api example is adding complexity that isn't necessary, and it also raises the question why haven't we implemented this api yet?..
(That would apply to `claim_rows` too; `claim_objects` might be better.)
Both of these callbacks are wrapped the same way, so just create a local callback and pass that into this.rebuild or timers.setTimeout.
Or better directly try to import 'resource://gre/modules/AddonManager.jsm' and put a try/catch around. That way we can kill the other two functions.
ya. it works
I'm totally happy to make this provider-specific as long as we have a sane method.  I'll chat with @ahpook
Multiline issues resolved in 6b6550b.
如果上面已经确认不需要rotate，这里就没有必要拼接rotate。
As in, this should be done higher up in sequelize and not be individual connection managers? Definitely! :-)
I've found the initial problem and just removed the silence operator. But thanks for the hint.
Same. Remove space after !.
I'm assuming this was an accident while playing around with git. Since this directory doesn't do anything, I'd remove it.
@jozef as @stof stated, this migration is not useless.

We don't want to convert anything so the migration class is ok.

I have also now made the note on readme.md to update all bundles.
?? Was hat das mit der PHP Versiopn zu tun?
DamageCause is already an existing enum
Looking at the code below, it seems you are always using key as an integer from here on. I guess you probably want to store the result of parseInt(key, 10) back into key?
dont like this, if we changed the format (<strong>) later, the behavior can break
@harjis Korjaisitko typot!
@vesak Mä ottaisin tähän mukaan tuote-taulun

FROM tuote
JOIN tuotteen_avainsanat
JOIN tuotepaikat
and the error handling for invalid values is missing
Sorry, that comment wasn't very clear.

I don't think the signature needs to change to `Request.__init__()`, I just wasn't sure if the way I was doing things was the right way to do it, or the way it was planning to stay.
I'm the last person that should weigh in on this. :-)
Ok then. Fix it, please, as you think it's right, but do not name all the deps in libs/, that's not nice.
I don't think this is the right thing to do.  We probably want to call the WebGL deleteShader function here.  I'm not sure if we want to remove the hashtable entry.  Although your program can't access a shader after it's been deleted, this will change the behavior of the program in an error condition compared to a regular C application.
You unintentionally downgraded the druntime and Phobos submodule in this commit.
Oh gosh, duh. Thanks for pointing that out.
If not a big trouble, please use 4 spaces indentation to match the rest of the file.
Ah. Usually I'd do `.rtl` for `<html class=rtl dir=rtl>`, but mostly just because `.rtl` is faster to write in CSS and probably faster to select.
We should rename this method to something like " is_edit_user_page_present" so that it reflects the actions in the method.
Nope!  It started out with some local state, but I slowly factored that out.  Will change.
Why ` Module.const_get(:Sfx4).const_get(:Local).const_get(:AzTitle)` instead of the straightforward  `Sfx4::Local::AzTitle`?
yep, however I cant merge your current pull request, either you create another one, or I'll cherry pick the commit from here.
Don't need the callback here.
I see, it is explained below. Sorry.
Typo "rue" for "run"
This would invalidate the entire reason ``TradeManager`` was created. User's can change the accessibility of ``Trade`` object if they want but we shouldn't encourage them to do bad things =]
don't need to use the hash brackets {} in the get function call for the outermost hash
Well, in my intents, no since the javascript code I suggest reads
```javascript
alert(xhr.responseText);
```
So, the ajax helper should just print out the error message as is.
Let's not block this functionality for this. We'll put Guava in place when we merge bundles.
Also, don't touch other locale files apart from en -- we'll get merge conflicts with translatewiki otherwise...
size_for_tags should not be defined in the ApplicationHelper. How can I define it in a more specifc helper?Or where should it be defined?
How come metadata is indexed with symbols while frontmatter is indexed with strings?
`| InMotion Hosting` is automagically concatenated to all page `<title>` elements so there is no need to repeat it here
We can always r- commits with DS_Store in them; I'd rather a one-time education for developers (use a global gitignore in your `gitconfig`) so they're constructing better commits/pull requests for _all_ the projects they're on that use git.
Probably better to build these up as lists or dicts and then flatten to strings later. Also, this lets you avoid some repetition.

Perhaps something like this:
```python
style_attr_bits = {}
for style_key in ['width', 'height']:
    if style_key in config:
        style_attr_bits[style_key] = config[style_key]
style_attr = "; ".join("%s: %s" % item for item in style_attr_bits.items())
```
I can't find anywhere this is actually used, and it's a pretty hairy, specific function if it's supposed to be generic.
Should this be addressed as part of this PR? Not sure what needs to happen here.
The Content API doesn't seem to be used here.
Please use `availableModules` instead.
Yup, had planned to do this, but for this checkpoint :)
There are no side-effects. Can I keep it? :)
I strongly disagree about `if(`, however (and `for(`, for that matter). It's not a function call, it's a keyword expression. Minification removes it, as it is of course strictly unnecessary, but we aren't writing minified code. (This is also why the "strictly legal" space between function names and parens when called drives me batty)

That being said, I'll let you make the call. I'm just a guest.
can't this just be a link?
@a-bashtannik где использовать? В передаваемом параметре? А ничего, что в задании чётко сказано, что методу mutate передаётся параметр x типа int?
@emerald-wizard вы несколько неправильно сказали. Метод работает не правильно, так как не удовлетворяет условию "должны быть изменены СТРОГО х%". Во-первых, нет проверки на значение процента (об этом сказано выше), во-вторых, не отслеживается **изменение** элемента - замена на самого себя в конечном счёте заменой не является.
Тогда и на меньше нуля нужно проверять
Ну все, значит разобрались со взаимным недопониманием.)
не очень понятна логика, перебор элементов массива идет по нарастающей, а здесь откат на предыдущий элемент - почему?
Do we really want to leave this endpoint in here? It seems... unwise.
Oops, I _should_ read the full commit message. Still, this seems like "overkill"..
Now that I think about it, is it desirable to have this function? People will use it to downsample and simply taking the mean over a few neighboring time points is a very crude way to do this (it will create aliasing artifacts, as we are essentially a lp filter that has a sin(x)/x freq. response).
On 19.11.2012, at 22:17, Eric89GXL <notifications@github.com> wrote:

> In mne/connectivity/spectral.py:
> 
> > +    for m in method:
> > +        if m == 'coh':
> > +            accumulator_fun.append(_coh_acc)
> > +            normalization_fun.append(_coh_norm)
> > +        elif m == 'cohy':
> > +            accumulator_fun.append(_coh_acc)
> > +            normalization_fun.append(_cohy_norm)
> > +        elif m == 'imcoh':
> > +            accumulator_fun.append(_coh_acc)
> > +            normalization_fun.append(_imcoh_norm)
> > +        elif m == 'pli':
> > +            accumulator_fun.append(_pli_acc)
> > +            normalization_fun.append(_pli_norm)
> > +        elif m == 'wpli':
> > +            accumulator_fun.append(_wpli_acc)
> > +            normalization_fun.append(_wpli_norm)
> Hah, I didn't mean so say it like "I will only work on it if @dengemann won't use it" -- I meant that, if you weren't going to work on implementing it currently or soon, then I could (so that we wouldn't both be working at the same thing, duplicating efforts) :)
> 
yes, got you right;-) i just wanted to encourage you and share my enthusiasm on this!
> —
> Reply to this email directly or view it on GitHub.
>
I went through the code and this is a much simpler problem. DEFAULT_INDEXES only specifies one index so it should get renamed to DEFAULT_INDEX. I think I named it DEFAULT_INDEXES to match settings.ES_INDEXES. The latter is a dict of mapping type names -> indexes, so it's correctly named, but I shouldn't have tried to match that when naming DEFAULT_INDEXES.
double spacing "The  internet", "you   already", "the  internet".
You don't have to mimick the square braces. Those were only there before because we were doing a toString on a list object.
Maybe rename this chapter into "Configuration management" to follow the same lines as the tutorial from Salt  website.
It would be good to enable overriding this value with an environment variable, so non-puppet labs users who want to build & sign their own apple packages (and have their own signing key) can still use this.
name gives it away, but worth documenting (esp. noting that body is consumed)
变换
the function docfields.index(d.fieldname) will look for the first instance of d.fieldname, and hence will be the same for all instances having the same fieldname. Hence, this does not solve the problem.
maybe there is a pattern that would avoid code replication here. let me think
You bet ! :)
Ты уверен, что не нужно потом обновить `PrevAccountId_`?
You don't need to put the parameter array into an instance variable @array because you are not using it anywhere outside of this method scope.
You should format your message a bit more. Appending a boolean is not good practice.
This is identical to `HookDefinition`. I'm not sure I see the need for a new class here.
Wouldn't that break https://github.com/felixge/node-ar-drone/blob/master/test/unit/navdata/test-UdpNavdataStream.js#L46 ?

Have you run the tests?

Why is freaking travis not reporting pull builds ? : (
LOL! Since the tests pass I guess that field isn't needed anymore. I'll kill it as part of this PR.
Maybe this means we should do a manger/impl w a flag for the implementation. So we can start up things w fake values but it only requires a config value change (a test config so to speak like the one already in this PR). 

Sent from my digital shackles. 

On Mar 30, 2012, at 6:56 PM, Tim Simpson<reply@reply.github.com> wrote:

>> @@ -46,3 +52,17 @@ def create_nova_client(context):
>>         service_name=SERVICE_NAME)
>>     client.authenticate()
>>     return client
>> +
>> +
>> +if CONFIG.get("remote_implementation", "real") == "fake":
> 
> I tried Monkey Patching for most of yesterday only to find that doing it for the lifetime of the code was nearly impossible. It's just too hard to change all the functions you need to before they're used by anything else, which ruins the effect. If you think about it Mox and other tools are written to be used in unit test scenarios not in eventlet driven apps.
> 
> On the plus side the non-patched code is far easier to understand and reads cleaner. The only real blemish is the patching must happen here, which is really no different than a conditional import.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/hub-cap/reddwarf_lite/pull/53/files#r629167
you should remove these annotations IMO
Why are you including this individual file?
The default case should also be mentioned first.
This isn't a public interface.  The public interface is in `SymmetricalLogScale` (though most users use it through `Axes.xscale`/`Axes.yscale`).
@nelleV I think the thing to do here, after you have had a good rest, is to remove faceted from the listed kwargs.  Then
```python
faceted = kwargs.pop('faceted', None)
if faceted is not None:
    # raise the deprecation warning...
    # and set edgecolors as is already being done based on the value of faceted...
```
Sure, Jason Smith asked it to be 10 seconds, so perhaps you should speak with him about it? I would prefer it to be 30 seconds as well
You will need to include the manifest.ini from the contacts directory.
Test is failing here on today's build, maybe locator has changed?
Why is this superglobal set?  It dosn't seem to be referenced anywhere else.
I'm leaving this, as it works perfectly ;)
Yes and it is. I forgot to change this part
Could the 16 lines above have been factored in a function ?
This is cool, I'll see whatupskies with wip7. Weird! I don't think anything's aot compiled... probably some bullshit's pulling in different versions of cascading? Welcome to version hell :)
`role === false` -> `!role`
@bp323 Do we need the `if` in here?
Can't we just use the remove selector?
We can probably just remove this?
Thanks, I have removed this. :)
pls indent with 4 spaces
Well, that's kinda tricky. IRC servers can't even agree on that. If we were to base it off the timeout times for an IRC connection, that's anywhere from 2 to 5 minutes depending on the network. I got connection times of just under a minute on a server I used a few years back on worse days. So that leaves us with something greater than 1 minute, but less than 5 minutes.

Assuming the repercussions of the bot giving up after 5 minutes would be lower than or the same as it sitting there for ages _(would they be?),_ then I guess we could always go with 5 minutes (300 seconds) for now, and it can be adjusted later if anyone feels it is necessary?
Consider `@completed_at = connection.get_experiment_completed_at(@id)` instead. (I copied that from `complete!`, which I feel should have some least common denominator code with this method)
There is no moar no extra friggin line.
Can you put SDK/DDK definitions in winapi.h?
Are you sure ``$options`` has the correct type as ``string|array|object<Zend\Config\Config>`` is not a sub-type of ``array|object<Traversable>``?
I've done the changes to send multiple commits in a single HTTP call

2012/6/12 rick <
reply@reply.github.com
>

> > @@ -0,0 +1,27 @@
> > +class Service::HubCI < Service
> > +  string :token
> > +
> > +  def receive_push
> > +    http.ssl[:verify] = false
> > +    payload['commits'].each do |commit|
> > +        http_post hubci_url, commit.to_json
> > +    end
>
> Is there any way your service can accept a bulk payload of multiple
> commits?  I'd love to lower the number of HTTP calls if possible.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/github/github-services/pull/347/files#r966334
>
`and` returns a boolean as is.
I'm setting up a build order,

1. install node_modules
2. minify the js
3. test
You need to put a spacer line after @return just like after the @param group.
Bibliographies are a good example of "text" that is terminated by a period yet not forming a proper sentence.  If consistency is the issue, my votes goes to using periods.  That is my practice and it's an easy rule for the developer to remember.  Anything less falls into subjective territory because punctuation rules vary even between English speaking countries.
That is our code style in the manual.  A noun+adjectival phrase do not make a sentence.
Níveis
This is not good, we learned that `%B` does not work reliably. Parsing based on locale does not really work. You should parse it manually, similar to how you do it for Slovene.
It is ?!
> get_dependencies event

Event? Which event? How event?

You just override `dependencies` field in your Python class with a name of the panel (or panels) your panel depends on.

In your case:

```
dependencies = (map_panel.MapPanel.get_name(),)
```
No space around last `=`.
CharField, already has min and max length validators included, so that wont be a problem. We just need to decide minimal length.
How about 5 ?
`:` at the end. *Pritisni* -> *Klikni spodnjo povezavo*
Oh, and I haven't use "with" tag because it doesn't work with the URL and the old way works just fine?
Use `"` in Django template tags.
Forgot `\` at the end here.
This is a little perplexing. The functor itself is intended to be an RPC of sorts and you're acting on a call to one called "configure" but you have a nested function as named by the client? Functors can handle multiple things, so handles could be: "function/configure function/update_password" or something like that. So, while what you have here isn't "bad" it breaks the general convention. You could also just create separate functors for each individual "function" you want to run. There are definitely examples where I have tested which handle was used, but this is checking nested data sent by the client and not relying on the socket routing system explicitly.
Yes, it encourages others to not care about SSL.
this looks over 80 columns wide...
One possibility is to have ``compute`` throw an exception by default if the dendrogram already exists, and have an ``overwrite`` keyword argument to override that?
The service should be private as it does not need to be retrieved dynamically from the container