labofsahil/github-event-dataset-2012 huggingface dataset:
trees: Min leaf cherrypick

Cherry picked the "min_leaf" parameter from PR #522 by @ndawe.
Also added a test.

I'm not sure if we should keep the "min_split" parameter, since I feel "min_leaf" makes more sense.

I know the ExtraTree paper uses "min_split" but I haven't found a reason why.

How do you feel about that? (expecialy @glouppe, @bdholt1)
Long path support and Nuget Fix

Hi this is a path to support directory creation over 260 char. 

I also fixed the reference to the Nuget.Core, to point to the packages folder, which was invalid and causing the project to load the Nuget.Core from the GAC
Api

Allow impersonating by query string or Auth headers
Branch reescrita

Tentando equalizar a branch e o trunk
BackupBuddy plugin update support

I've added `_wpr_get_backupbuddy_plugin_data()` to `_wprp_get_non_extend_plugins_data()`. Needs testing.
Updated composer to user official TCPDF repository

As TCPDF now has an official package on packagist, this should be used instead of the current repository definition, as this allows for proper versioning of the dependecies.
Fix a bug that would cause g.line.js to display an erroneous y-axis

Fix a bug that would cause g.line.js to display a y-axis from 0 to .5 when the maximum value is very small (< 0.001). In this case, t < to could equal true which would correct t to larger than .5 which would result in a drawn line that is basically on the x-axis.
This fixes #6334 (BTW MM IS LAZY!)
Update Development

Updating Dev line
Added bounding box information and fixed coordinate system to head_color_camera_l_link

...o head_color_camera_l_link) and added bounding box information
Indentation using tabs (both HTML & JS)

I guess most people prefer to set indentation width by themselves in their IDE. I think it is also more readable now. No functional changes, just whitespace.
Fix typo: fomratted --> formatted
adding Austin Redd to site supporter list

Signed-off-by: Michael La Plante <michael@michaellaplante.com>
build: detect tracker-sparql-0.14

Tracker changes the .pc file not only when the API changes but actually with every version (versioned .pc files).

As such, currently, tracker-sparql-0.14 is not detected by configure. Simply adding the detection seems to be sufficient to support tracker 0.14 (tested with tracker 0.13.0
add demo for development

I forked to try something, but I soon realized that its hard to develop in the dark, so I added a demo page by copying the homepage, and adding all the necessary assets, and making it use the local js/css.

Should make development easier + new demos can be added for all edge-cases that are found.

The only problem is that the datepickers do not pop up, there are no errors on the page + the init methods are called (I dropped a few console.log to see whats going on), it feels like its 99% there, just one small nudge in the right direction missing :)
Fix proximity sensor.

Thunderg uses interrupts.
Update to work with Gnome Shell 3.4

Patch provided by @pentie in kagesenshi#21. (Fixes #21)

I did not write this. I just made it into a commit and a pull request.

I tried it, and it's working fine as far as I can tell.
small oversight in README.txt
Next device

blackberry-webworks/WebWorks-API-Docs#131
Performance fix for redmine_git_hosting.

*Note that the following patch is subsumed (included in) the resilience patch, issue #124*

This prevents a ridiculous number of calls to update_repositories caused by the fact that redmine saves to the repository model for every commit that it examines.  This patch also prevents multiple calls to update_repositories when adding groups to the membership of a project.

After applying the patches, you must migrate the plugins:

    rake db:migrate_plugins

Restart afterwards.
Many changes.

- For rails 3
- Added optional jquery support.
- Added rake tasks for jquery libraries
- Added multi recipient send
- Added "don't save in send"
- Added new documentation and howto for install and setup
Added some margins to solve bad visualization on Frisco Theme
touch index.html, to work on later

So this is what the "pull request" thing does
Les deux derniers fichiers
Ch12 relecture

Ce chapitre avait une "mise en page" différente de celle des autres (9, 10 et 11), ce qui fait que mes modifications sont un peu lourdes pour être comparées.
Néamoins ce chapitre à besoin d'une autre relecture.
looks like this was cut&pasted 3-4 times.. use helper?
Then vector test should be reworked. It requires 0) luvit (which is fixed by mangling PATH); 1) luvit-config (which also can be put on PATH); 2) luvit headers, which we collect only when installing. I personally would have them under luvit's root in include/luvit, as part of make all.
good point. i just fixed that. thanks for the feedback, @Jae.
this looks dangerous in combination with https://github.com/quite/alot/blob/2367c7c68b7db42bde14c475308e0f65c4ab03f3/alot/widgets.py#L595

iirc: you must not display widgets with 0 width in Columns at all as urwid dies otherwise. i think we must check if tagwidget.width() != 0
every time we actually display one..
This doesn't need to be a mock; it's just a `messages.DeviceInfo`.
Extra `,` would be handy there. Not critical though.
The url http://<d2rq-host>/vocab/ is not always the best name for the vocabulary info. We have names like http://domain1.data.company.com/systemA and http://domain2.data.company.com/systemB. Multiple D2RQ systems are all put behind an Apache gateway doing the forwarding to certain D2RQ instances... It just was practical to be able to rename "vocab" to something else.
Looks like there is aleady a See Also at line 185. Also just say 'lists other settings that can be used for IPython' (no period)
I was searching for that commit, but the stupid search function of Git didn't return that … :-( 

What exactly is broken? The transitions work here. What is the difference in his work? (i'm at home, can't diff that now)
Make that 'Stable'. There are a couple of warts in the API, like how the `.send` callback receives a pointless `length` argument (it's all or nothing, there are no partial sends with datagrams).
Ja som nato prisiel, ked som teraz migroval na Nette2 a testoval som cachovanie stlpcov. Spravil som preklep v nazve stlpca a vratil sa mi null, tak som chvilku to typo hladal, kym som nato prisiel, to bolo zakerne :)
Yes, but master is 1.9+, so we should use the default rubygems that ships with 1.9+.
@joshbuddy Yes, he definitely got a lot of attention for the problem this way, and that's absolutely a good thing: more people should know about vulnerabilities caused by Rails mass-assignment attribute protection defaults, and people should definitely know a site the size of GitHub had such big and obvious vulnerabilities.

I just think it was a bit of an assholeish/childish move to do it like this. In the end I prefer it happening this way to it not being seen by the public and it being covered up by GitHub or whatever, so I guess ultimately I am glad this is how everything turned out, but I don't like that @homakov did it like this. I'm aware I'm not doing a very good job at making myself clear.
I follow the [RubyGems Rational Versioning Policy](http://docs.rubygems.org/read/chapter/7).
Using `QString' isn't required. For matter of consistency both `import sys` and `import site` should be written the same way.
After copious (liberal? welcome?) amounts of beer, and various other Japanese fermented beverages....
Shared strings is easy - just another xml file and a relation, and a small re-write to how Cell.rb does to_xml.
(read: around 10 hours of work all together but probably worth it if people want to use Numbers, etc. )

Ill start picking at this as I move forward with encryption / password protection. I think the harder part will be managing column widths once repeated strings are extracted to a separate object. I've had enough trouble with that as it is. Regardless of MS's spec. 

Can you post the test failures? Anything short of a 'cant write that file because I don't have permissions' is frankly unacceptable. Even across versions.

 .16 is still all 1.x.x so nothing should break.
You don't need to export them for this. You can just write `fun change_name_in_clause/2` and the local function will be referenced anonymously.
Uh, *now* I see! Thx for the clarification. The more important I consider this check to be. 

One *might* consider returning an empty dict in that case, assuming the user wanted to disable highlighting. Then again, if there are `thread_highlight_components` specified, maybe he tried to configure highlighting and just forgot to give that key.

I still tend to believe that enforcing the presence of that key on average is the straightest, least ambiguous approach.
Removing these entries should have been in their own commit. Don't lump together separate changes into one bit commit.
I actually replaced the read-write lock with a simple lock, as suggested by Dan.
I do *not* want to acquire the lock for the first 4 methods, as they're mainly called via JMX (jconsole), and I can live with stale values here, e.g. for size().
NRW.compact(), however, should be locked (good catch), even if it is triggered via JMX (e.g. via a user). I changed this.
Thanks !
Yes, well observed, I did it wrong.
Could the max/min value be set through xml? If not ,why don't use variable instead of number?
Tag did not exist... corrected tag to one that actually exists.
Note that, while it is possible to specify a character set using a meta http-equiv tag, doing so disables the lookahead downloader in Internet Explorer 8.  - http://code.google.com/speed/page-speed/docs/rendering.html#SpecifyCharsetEarly

::troll:: Problem? -- IE8
Is this only because of the need of return HttpMessage ? We could break the API in 4.x but I would like to understood better the "whole picture".
This line = bad. :)
ok, this one is for @bjorn
you should also mark the root
furthermore, when doing a union, the root should *stay marked* also when finding the root of the second tree (so we don't forget it...)
[you can do the marking in the union method]
A 2nd regular expression is not needed for this change; Use `(\d{4})-(\d{2})-(\d{2})(?:T(\d{2}):(\d{2}):(\d{2})(?:\.(\d+))?(Z|(-|\+)(\d{2}):(\d{2})))?` instead.
I think that here is an error with '#' symbol
The latter approach would be better. I'll merge this fix in for now. Wrapping with a try/catch would be good when better error handling is implemented (in the 0.3.x branch).
sounds good. disregard this comment in the most recent review (I was unable to find these commits, so basically did the review over again on the new code).
I have to admit I don't remember. I just remember that it took me a while to figure out how to get a hold on the addon's ID so maybe it was a "finally got this sucker" kind of comment (which can obviously be removed) but it originally belonged to a different part of the code. Will get rid of it.
Also, I think you should rename the `bio` field to `about`. It's more generic, which is good, because it also applies to teams. When displaying the labels, you should use a `if profile.team_profile?` check and show either "Bio" or "About". Ideally, wrap that decision in an `profile_about_label` helper in `ProfilesHelper`
` &nbsp;` -> lame!
@danikov @grkvlt note please merge this before you merge your other changes, as this broke the build
We removed all the un-necessary files from the repository. Thanks!
KR indenting...
Sorry, but how do you define an EntityUserProvider from doctrine now ?

```yml

# This do not work : throws undefined key entity error.
providers:
        users:
            entity: { class: Plemi\GuardBundle\Document\User, property: email }

# This do not work : service is declared abstract in the service definition.
providers:
        users:
             id: doctrine.odm.mongodb.security.user.provider
```
what about this instead? ;)

    xargs -P NUMBER_OF:PROCESSES ./my_exe
Why include this?  There's always a link on the side to the source of the current file (and the suffix here is .txt).
What is meant by "back" of the current container?
git://github.com/onmyee/Flashtool.git
Pensé en ponerlo ahí y desp lo termine poniendo donde quedo =/ OK 

Lee el comentario del commit (abajo) por favor.
sure - we should try to add most reasonable things here as well.
my script currently expectes each line to be of format "map tile rest" - is this ok for maintaining, or need I to add other things (like // comment support?)

Also I noticed that TrialOfTheCrusader does not work well anymore. I assume this is related to the floot being a destructible GO.

Maybe add meshes for this area manually?
I think it was just left over from the time abstraction / cleanup and should be removed.
is it possible to use [this](https://github.com/mozilla/zamboni/blob/master/apps/amo/models.py#L209)?
Updated in 533e63c for both 1.8 and 1.9 modes. Thanks.
don't build a list. you can just access `webapp.device_types.all()`
I believe you've switched findtime and bantime (previous two lines).  findtime should be shorter than bantime.  In the example given in the original issue 19, findtime is 1 day (86400) while bantime is 1 week (604800) ... they are switched here.  May also want to include the comment that they are 1 day and 1 week, respectively, since many people don't multiply seconds in their heads. =D
Lets leave it alone for now. The pre-requisits in the readme are descriptive enough.
With the passenger with apache environment since bundler tries to locate the gemfile, it crashes as gemfile is not found in the directory from where passenger starts.
Was the shared eagl patch rejected? Shouldn't it still be on our develop branch of sparrow if not?
If you're going to do that, you might as well work on an alternate implementation, because we need to move away from XStream.
you could to `count + ' character' + (count != 1 ? 's' : '')`
changed to ng-pluralize
users, которые не приносят никакой пользы, не учитываются вообще, даже как people :)
Just

```rst
The repository for this software is on GitHub, under the name `sagecell
<whatever>`_
```

is better than

```rst
The repository for this software is on GitHub, under the name
`sagecell <whatever>`_
```

if the word wrapping happens to come out that way. There's no need to keep ``` `sagecell``` and ```<whatever>`_``` on the same line, is what I'm saying. It looks like GitHub's syntax highlighting in this comment actually has it wrong, as both are equivalent in the rST spec. But as I said, this is almost too trivial to mention :)
oh my fault i thought we were all build an emulator of the official i must be in the wrong place 8P
Do you mean that we shouldn't let them customize the package name themselves? I figured if we had them use their preferred nation's abbreviation and their user name that would make for pretty unique package names, I got the idea from the way Hinchy makes his packages. What should we change about the package names?
I know but the formatting somewhat changed and the display sucks. I don't know the spec for the right format and it is not in the docs...
This should remain, my bad cleaning up everything :D
You might find this interesting too:

http://www.natontesting.com/2009/07/21/add-assert_false-to-rubys-testunit/
No I didn't - it's already incremented in the previous `substr()`.
yes -- that is a convenient service github offers for code/changes review/commenting -- could be done online or via email
IMHO worth reducing number of "WARNING" words and placing into a '.. note::' environment
恢复域名映射文件
I would like to switch the explicit exception raising to either `Debug.Assert` or `Contract.Requires`.
That's one too many rrrs in there...
Ah okay, I got the order of the commits reversed! :)
Oh, may be you're right...
Now will deal with commits...
Yes, yes it should be....
I know, I'm nagging but I'd want to configure, how many spaces are used for a tab.
I had the same thought, initially. But the framework behaves different in some situations, depending on the targeted API level (e.g. there is some very weird logic of how the themes are selected and what default values they use). That's why I would like to take it in small steps and with at least some testing. :)
method javadoc/
Thank you a very much! :-)

---
Gesendet von meinem Windows Phone; ich bitte etwaige prosaische Unzulänglichkeiten nachzusehen ;)
________________________________
Von: Lorenzo Stanco
Gesendet: 08.02.2012 17:32
An: Adrian Föder
Betreff: Re: [FloatingTips] 2.4 release (220c337)

Fixed in 2fa444c :)

---
Reply to this email directly or view it on GitHub:
https://github.com/lorenzos/FloatingTips/commit/220c337f6e9e1b8d6ed9c04afe66233de07d4a8a#commitcomment-945791
slight changes will need to be made here in accordance with the removal of exactCurrentTime
No problems with SEO ?
app/views/common/_share.html.erb 这个那个tw的老是卡住，被我一怒之下删了～～
English isn't my first language :( I'm always afraid of saying colon when I mean period, so I use full-stop because I can't mess that one up.
Yes, but not without switching back to
function showElementCommentlist($where, $limit) {
;-)
But maybe this was not an accident...?!

Am 03.01.2012 20:01, schrieb Grischa Brockhaus:
> it should be
> $comments = serendipity_fetchComments(null, $limit, '', true, 'NORMAL', $where);
> instead of
> $comments = serendipity_fetchComments(null, null, '', true, 'NORMAL', $where);
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/s9y/additional_plugins/commit/ae2a583689d02b6cdfe8956b48b70c88be8e83b8#commitcomment-834456
@mroderick I think the documentation is fine, it's a nice library too. The issue is that unsubscribe() modifies the messages array directly using splice(). And unsubscribe() can be called by an event handler (for example in the case of one time callback mentioned above). Iterating over the messages loop is _syncronous_ so it's possible to unintentionally modify the array being iterated.

For [example](http://jsbin.com/avusog/2/):

```js
// This callback should only be called once then unbound, a common pattern.
var token = PubSub.subscribe('my-event', function () {
  console.log('Callback One');
  PubSub.unsubscribe(token);
});

// This is another callback.
PubSub.subscribe('my-event', function () {
  console.log('Callback Two');
});

// Now we publish the event twice in quick succession.
PubSub.publish('my-event', 'hello world!');
PubSub.publish('my-event', 'hello world!');

// You would expect this to output.
//
// Callback One
// Callback Two
// Callback Two
//
// But instead you get.
//
// Callback One
// Callback Two
// Exception Thrown.
```

Now it's great that the exception was caught and did not affect the second publish call. But my point is the exception was caused by PubSubJS not handling the unsubscribe() call in the way I expected (unless this is the intended behavior and the developer should not call unsubscribe() in handlers).

I hope that all makes sense… (@AaronAcerboni sorry for hogging your commit)
UPDATE conditions SET SourceTypeOrReferenceId = 13 WHERE SourceTypeOrReferenceId = 17 AND SourceGroup = 17465 ??
fucked up db... got many db errors in conditions
flawless work :-D
Awesome dude! I can't wait to see it!
It's probably not the same, but *args is unused by _step, so it's largely superfluous.
I would say make all but `-ks_normalizedURL` private. My inclination for those who want more control would be to have a `-ks_normalizedURLWithOptions:` sort of method, rather than asking them to string together all the individual components.
Well, attr is already fixed, I just forgot ;)
Love is in the air baby! (?)
nope
i think boss Auriaya and after horror spell someone in texture....
why? We already have atomic_add_exchange (see next line)
Nice! Thanks for fixing this
Damn, Private/Public... this policy killing me! Ok, We have SkyFire Core, and AT LAST SkyFire DB! Keep up good work in open source project,guys, One Project - One Repo!!!
Please write descriptive commit messages, describing the actual change.
I love how you add a space to all of my debug thingies!
No, i actually thought about it. It is consistent with Spring where XML wins over annotation, so the fact that it was checking the ref (where it would look for annotated methods for release and correlation etc) first before checking corresponding xml attributes was a mistake IMHO. But now you can have a bean that has all 3 annotated methods but can be overridden with corresponding XML
Ste1s, go on an account and make like 10 characters, delete them, and make 10 more
 it will eventually crash, i promise you. (if your using the rebase emu. It doesnt happen in the older core.
This commit broke the druntime unit tests.  There's a pull request that touches that part of the code base:
  https://github.com/D-Programming-Language/druntime/pull/164

The auto-tester does pass for that pull (it's the ONLY thing passing the builds right now).  Was the breakage from this fix intentional and expected?  I don't want to pull in a fix for code that shouldn't be broken.
Code-complete ;)
Estoy en eso!!!
------------------------------------    Eloy



2012/3/1 Oldani Pablo <
reply@reply.github.com
>

> ok entonces. haces el cambio?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/BlueLemon/representaciones/commit/fd529681d8faa04b4443246b4e39616fb1e7cc0c#commitcomment-1032787
>
This replaced three test cases I introduced... was this intentional?
Unfortunately the SOPA laptops do not work. If you try setting it to sopa it returns successful but it doesn't actually change your laptop. However you can provide an empty string which will result in a broken image as your laptop.
Ja, deinen letzten Vorschlag finde ich sehr gut (und mit "Roman als Überschrift" hast du natürlich recht).
Great, exactly what I needed :)
Ну это и имелось в виду. Врят ли программа начнет падать из за коментариев :)
This is the new change.
I think in Controller the sub should be an Action (http://search.cpan.org/~hkclark/Catalyst-Manual-5.9002/lib/Catalyst/Manual/Intro.pod#Action_types)
in this case, it could be a Private action.

Though, if it's not suitable for Action you could also create something like an image utility module outside Controller.
yes, thats true. the right change is in my personal fork, which is not merged yet:
https://github.com/schmidsi/django-facebook-graph/blob/structured/facebook/modules/base.py#L219
https://onmyee@github.com/onmyee/Xperia-X10-Kernel-2.6.29.git/scripts
i'm telling you the thruth i don't know it it work or not i've not tested yet 'cause i'm stuckin at some RIL errors tath i don't have with older device folder and i must resolve it (anyway problem it is on my thread...it is needed for old binary blobs for sure...it is like camera)
I had quite a bit of trouble with this, until I figured out that the Nokia Phone Manager (the old version) ignored all the vCards I threw at it because it wanted \r\n as line separators. The vCard spec specifies \r\n (section 5.8.1 in http://tools.ietf.org/html/rfc2425 ), so you might want to keep it that way unless you have software that ignore the standard.

...nice to see it forked, by the way :)
do we need an additional switch --version for compatibility reasons?
Most event are defined in BCommonProperties but are not used. Rather delete them or use them in some widgets.
Yes, it's good to have the class. We'll expand on it eventually, but even for initializing the subtype, it's good to have.
I'm glad we can get rid of this -- it was a hack at best.
Should be `if ($admin === false)`
You're right. Right now I am using a debugger to see what is going on (non-multi-jvm setup). Will do proper debug logs next.
This probably will risk shadow "self" in Actor, right? Is that intentional?
Strike ByteStringStrict - it's still not a strict collection, behaviour-like, just compact as it is.
everything that should support Serializable should have `@SerialVersionUID(1L)`
that also includes case classes that are sent over the wire or need serialization for other reasons
yes, if possible for the different ExecutionContext used for withSyncCircuitBreaker.
Perhaps the sync/async mode should be decided on creation of the circuit breaker. Mixing is perhaps only confusing?
Sure we can do that. But then I think we should add it to the top of the file. So they can find it there themselves.
Or possibly, you have a typo in more than one place :-)
Only sysadmins can create activities directly through the API, but anyone can create them indirectly by doing things in the web ui, that's what those are for
Docstring needs a first line saying what the method does
Again I wouldn't bother
This doesn't mean which legs are recorded, but which media direction (what the caller produces or hears).
Shouldn't this be "system.h"? Obviously "xbmc/system.h" will also work but it confused me for a sec as I had to check if there's a second "system.h" somewhere.
тут можно использовать метод у формы. form.as_p например
This looks a vestigial remnant of something else, consider removing just in case this method signature changes or something.  Also the kwarg to positional arg translation could be an issue.
Get the index of the first non-nil match group (after the first two), then get the class and range from that.
It was being a pain and not fetching it. Didn't you have this problem?


On Sunday, November 25, 2012 at 1:24 PM, bigs wrote:

> In examples/main.go:
> > @@ -1,7 +1,7 @@ > package main > > import ( > - "github.com/bigs/goober"  
> probably best left as it is. use go get -u github.com/bigs/goober to update your library (be sure to have GOPATH set)
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/bigs/goober/pull/2/files#r2217037).  
>  
>  
>
I fix this for the tileset view, but for the map view we need to keep the check there.

I do not know exactly why, but I guess is due to the fact that on OSX, on a trackpad, we drag two fingers vertically or horizontally to scroll, and Qt consider this a PinchGesture (without the ScaleFactorChanged flag set), so if I swallow the event here it will not go up the hierarchy and the wheelEvent is canceled, thus the view return to its initial position where it was before the scroll begins.
CernVM File System Repository Traversal
No, I didn't delete it - it just got moved lower down in the function.
It doesn't really matter - this.swiping is supposed to hold the index of the row that was last swiped, and it gets set in down(), but I actually think there might be a better way to do this. Let me take a look…

On Jul 24, 2012, at 6:46 AM, Ben Combee wrote:

>> @@ -55,6 +57,7 @@ enyo.kind({
>> 		// stop animating if we reset.
>> 		this.$.client.getAnimator().stop();
>> 		this.$.client.setValue(0);
>> +		this.swiping = -1;
> 
> when does this.swiping get reset to undefined/0 or does it matter?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/enyojs/onyx/pull/61/files#r1224869
Can you revert these changes? Thanks.
Casting should be a big warning flag that you're doing something wrong. In this case, the return type should be `NSUInteger` instead (as mentioned above).
I moved wrap_int and truncate to util in order to use it here. Done.
i think you don't have to do a trim, parse_ini_file already do it for you if think
Made a new commit to fix those.
Some code style things:
- Don't put a space before the ":"
- Don't put types for local variables like this unless it's not obvious what they are
- Use longer variable names (I'd just call these threadGroup and parentGroup)
- Limit lines to 100 characters (applies below)

In general we've been trying to use the Scala style guide (http://docs.scala-lang.org/style/) with some tweaks (http://spark-project.org/docs/latest/contributing-to-spark.html).
Added. Not sure why GitHub didn't hide it as outdated.
Ale do PHP 5.4 není.
the loop isn't reading or writing `tab`, why would I check the same thing over and over again? can you maybe post to gist the change you're describing?
I have a branch with what I am proposing here: https://github.com/moloney/nipype/commit/ff10dc7a09c3cc9a6640d0ab73ff7c24fb2f032e

This also addresses an issue where the original exception gets lost (and the crashdump does not get written) if an exception occurs within the try block but before importing savepkl. Let me know if you want me to open a separate pull request.
Is spkstr_cleaned ever freed?
You can probably use `each_key` here and remove the `_` arg.
Perhaps the option could be `add_classes` or `css_classes`? Not sure what's the best name - or if there are other better possibilities.

Lets try to move this forward so we can get it merged, thanks.
I removed in the other places. We can remove here now.
In this context it kinda seems ok, since it's checking the `type` attribute for `array`, I guess.
I think it's the [test that you added](https://github.com/rails/rails/pull/7251/files#L57R563), that's trying to also [set the option to AC::Base](https://github.com/rails/rails/blob/dde7d83eafe0f405687781542b9fa57955feb0f9/actionpack/lib/action_controller/railtie.rb#L47). If you remove it, the option does not exist, which will raise an invalid option error.

Is it possible to use `delete` or something like that with the [parameters initializer](https://github.com/rails/rails/blob/dde7d83eafe0f405687781542b9fa57955feb0f9/actionpack/lib/action_controller/railtie.rb#L22)? Then that option wouldn't exist down the chain.
Are you using tabs instead of spaces? Might be the case, otherwise I have no idea :D
Yes, you are right. Sorry, I got confused what is allowed and what is not in universal traits.
Yes, then it needs to stay. I thought this has changed in distributions.  (I'm not able to build scipy, so I cannot check the latest code.)
why did you get rid of these properties?
This error message could be improved by telling the user the expected input. "Please enter a list of lists of integers" for example.
@SaurabhJha, what is your opinion on this?
my basic C knowledge tells me there is close() missing for this open() call
As for new checking SQL:

```sql
mysql> SELECT NULL FROM logTableName LIMIT 0;
1146 - Table 'test.logtablename' doesn't exist
mysql> SELECT NULL FROM tbl_recipe LIMIT 0;
Empty set
```
sometimes I really hate php for what is possible :-D looks okay for me then ;)
not sure if it makes sense to list here possible types as it gets too long (problem could be later in displaying those values in the api doc property tables)...

I would leave here "mixed" and than later in the description list the possible types.
self.links.append(link_object)
This is the only bit I'd question and the bit that I was trying to avoid. There's 2 avoidable costs here: the check for the timestamp scale and the call to `now()` which is going to end up with an additional call to `performance.now()` on browsers that have it but use epoch-based timestamps. Doing an up-front feature-detect and reassigning helper functions ought to lead to better performance, particularly since VMs should be able to inline the simple helpers (perhaps).
**But**, it's not a huge cost and it certainly fixes the problems so perhaps we should settle on this for now and see if we can come up with a better solution for a later release. I might tinker a bit more with my version and see where it leads. It'd also be nice to find a way to benchmark the costs involved.

:thumbsup:
I largely prefer just `search`. Besides, `GitHub` uses caps all over the place, it reads `Explore`, `Gist`, `Blog`, `Search…`.

`tree` reads `test/`, `create`, `default`, `search`, and I just love lowercase so much.
check to halt setup if user setup fails
Looking at how it's structured now, I guess this could be a do/while loop. This is fine too, though.
`QUnit.init` is called from `QUnit.load` which is called from `addEvent( window, "load", QUnit.load );`. Maybe a more efficient solution can be made based on that.
:data:`version`
maybe we need to introduce the new index type before the notes on conversion.
I'm with edna and rlr on this. I wish it were less tightly coupled, but it's good for getting things done now, especially if there aren't grand plans for adding a lot more of this kind of thing. Also tastypie++. 

ship it!
Ah, it might have happened in IRC, then. I was specifically told that using the accept header as a fallback is not acceptable.
lower case variable names. those variables are not global or constant.
Can you explain that? Are you now suggesting we test our tests to check that they test correctly? That seems a bit over the top.
After the front controller PR is merged, you can use the $symfony_request global variable, which is a Symfony Request object that has a getPathInfo() method. This accounts for when mod_rewrite is used to remove the filename from the url (i.e. ./api/blah/foo instead of ./api.php/blah/foo), whereas PATH_INFO does not exist when that is done normally. It is what is used in the controller stuff for when app.php is removed from the URL.
Might be more appropriately called "enable avatars if upload dir writable" or similar.
Small small point, but so far the "dependencies" have been sorted alphabetically.  Might be nice to maintain that.
@mridgway we should move these statements into its own .sh file (arrow.sh maybe), just like we did with yaf-develop branch under the ./travis/ folder. In my mind, .travis.yml should be simple enough, just having references to scripts we want to execute.

We can also create a ./travis/travis.sh script for anyone who want to run these tests locally.

I wonder if we should have the .jar file as part of our repo.
slight performance gain to cache expanded_modules[name] as 'slot' or whatever rather than reaccessing it repeatedly through the [] operator.
If `staticPath` is used for URLs, it should not use libpath (which will create weird URLs with \ in them if the server is on windows).
That's probably due to me squashing commits. There was a previous version of the constructor, which took the reason as a string rather than an enum, before I thought that I'd better not be lazy, and I took it out. I'll get that fixed up.
http://www.ecmwf.int/products/data/software/download/grib_api.html
Done, but that's like having a starter and a main on the same plate.
I seem to remember this function takes a desired extent. (if not, we could make it.)
These are default sequel connection options, it's probably a bit overkill to put a whole configuration file in. Just refer to the sequel docs.
'local_log_softmax' instead of 'sotmax'?
Please try to restrict ``except:`` statements as much as possible. For instance here, would the following work?

```
try:
    from mpi4py import MPI
except ImportError:
    mpi_enabled = False
else:
    comm = MPI.COMM_WORLD
    mpi_enabled = True
```
Why save 2x?
Здесь должен быть код про вычисление зависимостей через `deps.js`, который сейчас написан в `BemBuildMetaNode.make()`
This has to be cast because only the Model class and its derivatives have an enterSimulation function. This also doesn't neccesarily call the Model's enterSimulation function. To do so, one would have to write:
```
dynamic_cast<Model*>(clone)->Model::enterSimulation(this);
```
If total == 0 for some reason this logging function will fail. Could you just add a guard (something like,  if total == 0 set percent_complete to 0)?
`jsonProp` is pure brilliant!
Can you find another way to do this? There should be zero new API exposed.

I'm going to work on removing the IIFE wrappers this week - which might ease this.
I assume ordered aggregates are the only unsupported feature in GPDB 4.0. We thus could omit all rank-based tests, or we simply omit all hypothesis tests. Alternatively, we could leave them in, but the user would still have to ensure that the aggregate is seeing the values in order (which may or may not be possible using workarounds).
Maybe I should rename "Parent" to "Container"!
I wasn't worried about it because those tests use a separate db (empty one or those from fixtures attr), so there is no way to hit a real server. 
But, if you think we should change them, I'll have to change almost all of the tests. So I think it's better to do it in the cleanup branch to ease this review.
When passing a quoted list, this is sufficient:

```rb
system "python", "-c", "import keybinder"
```
@jacknagel It only builds a 32bit binary.  I think it's a Quicktime limitation.
Will this even work? `build` is defined in the context of the class and the instance.
I don't think that the module-level docstring is right.
The same thing that happened before, the dispatchFuture/notifyCompleted are still used and still catch exceptions. They are just moved below into bindDispatch(), i.e. the closure that used to be created here is created "in advance" because we need to capture the executor in onComplete rather than capturing it here.

(I reworked this a bit in the follow-on branch I mentioned in comments (not in this pull request yet), the rework may make this clearer but isn't intended to change the behavior. This patch makes the more minimal and straightforward change and avoids the potentially more controversial rework.)
Is there a scenario where multiple transports would be needed?
Oops. Deleting.
Yes we should (and we already do for some such as jasmine-node), but newly added ones are a very good place to start.
This shouldn't be a constructor it should be a factory like every other connect middleware. That will spare you of all that `getHandle` magic inside *server.js*
If you want your comments to be taken into consideration you should stop these mocking statements.
Yep, that was the idea - in those cases we're not going to be able to not connect anyway, and it saves having to pass the icanhasall flag through.
I think the problem is here. 
The cookie should send on every request, but the `connect` method will call one times.
use example hub id from docs. this should be a global constant in this test suite.
Thanks, I really appreciate the docs
Here's the OpenJDK version of CopyOnWriteArrayList:

http://www.docjar.com/html/api/java/util/concurrent/CopyOnWriteArrayList.java.html

Note that the locks are only acquired on the write operations; the read operations do not use locks, and instead rely on volatile semantics.

Yes, I do realize this pull request was closed and replaced with another one; it's just easier to continue the conversation on these threads :-)
I think putting these in an object will be marginally slower than having them hang out on the stack. I think it does look nicer however, but whats wrong with a POJO? Can you confirm it isn't that big a hit with a watson or two?
yep they're used in the tests where they just to process as valid, there's no way to synchronously generate keys anymore which breaks this pattern
usually we only specify only throws for each exception and combine the message with `or`
I thought this change was supposed to be in standalone mode only? That was the only reason I was concerned about the flag name.
I would change from "Обновления" to "обновлен". This phrase is a bit difficult to translate to Russian
indeed is tedious 
but using lm the problem is that you dont have access in the id of the elements
which can cause errors
yes. and at the very least catch Exception so you don't prevent things like KeyboardInterrupts from not firing.
We don't use apache commons in this project.  Please copy the method into this project and remove the dep.
why is this if here? doesn't errors cover this condition?
Also start the comment with an upper case letter.
Just habit, really. I'll change up.
Technically I suppose there isn't anything wrong with using alt this way but as far as I know it isn't intended.

Why not just use your own attribute on these like, data-iframe-url or something instead? That way it's more obvious what the intent is.
store a reference to `_messageContainer.parentNode` and `_messageContainer.parentNode.style`
Might want to combine these three lines into a single function since you have to run this twice, right?
I was just thinking leaving the update at line 362 instead of having it inside the callback would be better, since `colorCallback` is only handling the UI state for those other editor elements anyway. But this is fine ^_^
How could assigning editorElement.type to manifestEntry.type every throw an error? Can you explain what was going on here?
There is `pdfPage.getAnnotations()`, so my feeling is this feature can be part of the core PDF.JS library as well. Do we have some proper definition/sense of what goes into "core" and what parts go into "viewer"?
no, you can't just do that. 2011 is Willow !! for 2012, add IPI. You need two lines
Hmmm does this code read the whole file into memory? Wouldn't it be more effective to use a buffer or something like that , maybe using `progress()`?
Does this sizeof actually work? Why not `sizeof(struct toc_data)`? 

What's up with `0x0`?
On 05/08/2012 08:51 PM, Baiju Muthukadan wrote:
>> @@ -117,6 +117,10 @@ def run(self):
>>                   ('share/man/man7',
>>                       ['doc/man/salt.7',
>>                       ]),
>> +                ('/etc/salt',
>
> This should be `etc/salt` (no `/` at the beginning) ?

I don't think so... that'd make the files end up under /usr/etc or 
/usr/local/etc or /opt/etc or something of that sort, wouldn't it?
`(1- index)` じゃなくて `index` そのままで良いんではないでしょうか。 `(1- index)` を `index` にしないと highlight 位置がずれるようです。

jedi-vim でも index はそのまま使っています
https://github.com/davidhalter/jedi-vim/blob/99cb1d6f12c71daa19e0d4caba75e88f52f903c7/plugin/jedi_vim.py#L188
typo? mem_str instead mem_stir
really? comment to pastebin?
The current implementation added prettyprint to pre \ code tags whereas now you're adding it to the parent. Was this intentional?
I think it should be: 
```validates :shift, :inclusion =>  {: in => Unit.shifts }
```
Gaia currently use an 8px grid, this should be either 152px or 150px. (same apply to other changes)
On 02/04/2012 05:52, Ben Francis wrote:
>> \ No newline at end of file
>> +  },
>> +  "permissions": ["mozbrowser"]
> Is this a proposed addition to the apps manifest format?
>
> I like it and I always assumed this would be added, but there's no mention of it here https://developer.mozilla.org/en/Apps/Manifest or here https://people.mozilla.com/~anarayanan/webapps.html#app-manifest
>
> Does this need submitting to the webapps mailing list? It's similar to the current "required_features" proposal and I'm personally not convinced we need both, I actually prefer "permissions".

This is not final at all and this probably require some discussion on 
the mailing list to finalize the details. I have landed that so we can 
start prototyping from Gaia and I assume the decision at the end will 
still use the manifest, even if the name is a bit different so that's OK 
for now. If you want to lead the discussion about the detail I will be 
more than happy :)
yep, you're right - the first part should be fixed now.  

``u.Unit(unit)`` doesn't understand the plural forms, so I left that in, but it now tries the regular conversion if it can't find one of those three.
To be safe, let's make both gen_server calls have infinity timeout. If node watcher goes crazy for some reason, we don't want to be stuck failing on default 5s timeout when trying to disable it.
I've changed this to be a cast/fire-and-forget.  However, that now has the problem of being lost and not actually being killed.  The other thing I need to do is have the vnode mgr on the target node (which initiated this call) kill any incoming repair xfers.  The problem is this data is not available for incoming xfers because of the way the handoff mgr and handoff receiver are implemented.  However, I can make it work.  In fact it might be easier to just kill the receivers and not even worry about sending this msg, although it will look like an error on the sender side.  Perhaps I could trip a flag in the receiver and send back a special ack msg that tells sender to shutdown.  In any case, this call is going away.
i took a look and I believe I was wrong above. It looks like we can safely remove queu from the payload. When a failure happens, it automatically adds the queue that the job was being tried on
The point is that we currently cannot distinguish between *no fds* and *a single fd, 0*. Which is wrong. If you make hSocketMax to be max(hSocket+1) this is easy to detect, as the value will be 0 for no fds and 1 for the single fd 0 case. And as a plus, we then pass the correct nfds on UNIX in both cases.

(also, if you do that, you could decide to skip the select when hSocketMax==0. You cannot do so right now, as it has two meanings and thus is ambigious)
sure - but right now only this way the tests currently pass. I didnt get the change to look into it any more. somwhere a long the road the App class must return the false path.
Why not use ObjecCollection::attached() instead of the try/catch ?  Plus I don't think needing to modify the setting array on the fly is common enough usage to warrant a method for it.
Uh?! I really start doubting Harmony implementation correctness.
Reasoning on the full URI is wrong, for example, the algorithm should take the query into account.

I'm very sorry for having made you waste your time, but we'd better go with the Sun implementation.
commit in bfb0108
I prefer call signature as well.  The wording was actually taken from the `%pdef` docstring, for consistency:

```
In [1]: %pdef?
Type:       Magic function
String Form:<bound method NamespaceMagics.pdef of <IPython.core.magics.namespace.NamespaceMagics object at 0x2fb7250>>
Namespace:  IPython internal
File:       /usr/lib/python2.7/dist-packages/IPython/core/magics/namespace.py
Definition: %pdef(self, parameter_s='', namespaces=None)
Docstring:
Print the definition header for any callable object.

If the object is a class, print the constructor information.

Examples
--------
::

  In [3]: %pdef urllib.urlopen
  urllib.urlopen(url, data=None, proxies=None)
```
Should this not be `validate_after()`?
Can't we define our own replacement `addrinfo` instead of adding a thousand fields to the struct?
This has been fixed in the latest commit
@whimboo as discussed on pull #81, with this here the screenshot is being placed in the temp directory, regardless of what's specified on the command line.
yeah, agreed.  I put it in my personal to do list instead.
oh right, I forgot you can do that.  very cool!  fixed.
as discussed in IRC, I use the request.user.username to find the user in our model.  There wasn't an easy method in ApiKeyAuthorization to override without basically copying all the logic of the class.
i don't suppose you have a pep8 command line variation that will enforce that?
gotcha.  ok, I think I got it fixed this time...  :)
Sorry. I was referring to the `_dump_names_from_pathnames` method. It's all that prefix this, length that, substring those.
Sounds like these should be fine as an enum then.
Have added commits to change the Inventory item symbols and the dialog text color symbols to enums, which make sense as enumerated types.

I checked http://wiki.scummvm.org/index.php/Coding_Conventions and http://wiki.scummvm.org/index.php/Code_Formatting_Conventions for guidance on whether I should change any of the other case of const symbol values to enum... Only the Code Formatting Convention mentions this as "As a side remark, we recommend avoiding #define for creating constants, because these can lead to weird and difficult to track down conflicts. Instead use enums or the const keyword." If I recall correctly, the rationale for ensuring to use enumerated types where appropriate was because it results in far more readable debugger output, as it is annotated with the symbols?

If this is correct, I'd suggest adding this as a note to the end of that "side remark" as I think in some cases, we might be overusing enum types by "cargo-cult", when a "static const <type> kXXX = <value>;" would be more appropriate?
the phpdoc should be removed from private properties
The one that was buggy ?
Indeed it should :)
You need to mention the static method removed in FormUtil as it is a BC break (even if most people are probably no using them directly)
please add an empty line before the return statement
What about hInclude implies Twig templating?  That shouldn't be an issue for Drupal (I hope), but it seems odd to tightly couple hInclude to a particular rendering engine.
[List of character set names and numbers](https://github.com/jeremycole/mysql_binlog/blob/master/lib/mysql_binlog/mysql_character_set.rb)
We should make this PLATFORM_VERSION, not PRODUCT_VERSION - we'll also need to change the instances of this in ocaml/idl
Why do you ignore stderr?