labofsahil/github-event-dataset-2012 huggingface dataset:
this link doesn't work - the correct one is http://www.itu.int/net/ITU-T/sigdb/speimage/ImageForm-s.aspx?val=10100803
Just update the comment here and we are all good to go.
Only really an issue as this is open sourced code
should we rename this to ModuleLoader or something?
No need to mix strong with note... notes already stand out a lot
Shouldn't this be moved to initialize?
Can you add a `@throws` declaration for this here?
I kept going back and forth on how much I should put into the docs. On one had, the documentation for a class isn't the best place to put usage for other parts of the framework. OTOH, this will probably be where people come looking for all their routing knowledge for a while.
What version of PySide do you use? I have a setContentsMargins method on the QVboxLayout object :

In [15]: layout.setContentsMargins?
Type:       builtin_function_or_method
String Form:<built-in method setContentsMargins of PySide.QtGui.QVBoxLayout object at 0x1f844e90>
Docstring:  <no docstring>
@everbird 我在这里直接加了一个变量，没有在`.h`文件中声明，感觉也挺方便的。不知这样ok不
Nice. When you just want the apartment to exist, signing out afterwards is definitely the way to go.
Is 5 secs enough to avoid spurious failures?
As you have tested for `$cl` as noted above, you don't need to recheck it here, I think?
My preference would be to have the doc comment and the function it belongs to without white space but there's not a sniff for that right now.
Also adds this. Without a way to tell the user they are looking at the duplicates, there's no other indicator. This should be used on other generic membership lists as well.
лучше в контролер всунуть, я завтра новый патч накропаю
The show_delete_button property is a special-case feature for the camera app. It make the gallery display a delete button but also a camera button that returns to the calling app.

If the ability to delete a transfered file is not part of the spec, then just leave that property out.

If you do want a delete button, I can change the gallery app.  But note that the gallery app does not do the delete for you... You have to look at the return value of the activity and delete it yourself.
Before this line, can you describe a little what this file is in charge of?
Wow this was not clear indeed.

Talking about the `querySelectorAll` with a `#something`.
Ups! Damn it, you're good!... :-ppp
I would suggest you use `SettingsListeners` to track the settings but not to update the preserved value if `this.isFlightModeEnabled` is true.
I'm wondering why this is not a list and in that case why the data-type attribute is being used, instead of the role attribute
If I had to pay you a beer for every mistake, I would certainly stop commiting this stupid mistakes :D
Once we have DB Ready we render again ThreadList with pending messages retrieved.
nice shot :) I miss this one ... thanks a lot :)
Looks like you might have to modify this comparison a bit.

````
irb(main):027:0> build.branch_name
=> "fi/testing_pr_build_status"
irb(main):028:0> prs.last["head"]["label"]
=> "otherinbox:ma/google_mobile_authorization"
````
before this changes, we have 4.5.9 and 4.5.10 of Json.net.  I think we should have only one Json.net version in Kudu (consistent and build faster with one nuget).   i picked 4.5.9 to be consistent with MVC4 and AuxPortal.   Json.net is backward compat as far as I know.   Just to be safe.
@dchelimsky should comment, imho you don't want any permanent comments or pending specs
Can we use standard naming for this file, ie: `pre-commit`?
don't you need the epsilon here? ( beCloseTo(aVal, 0.0) )?
Since we use -> for fields so often in the scalding DSL, I tend to prefer to avoid it here.

Can I suggest you pick either: insert(f: Fields, value: A) or insert(f: Fields)(value: A), giving either: insert('a, 1) or insert('a)(1). Your choice.

I'll merge the one you pick.
"quickly" is spelled wrong.
Rules like this are very slow in CSS. https://developers.google.com/speed/docs/best-practices/rendering
Why not use `getById`?
OK. Get it.
The compute formula is added in the head by comments, I would add it to the documents
again indentation, copy/paste anyone?
Ich würde eher zu "'Ähnliche"  oder zu "in Bezug auf" tendieren, normal bezieht sich Text auf etwas ist aber nicht mit jedem verwandt. ;)

http://dict.leo.org/ende?lp=ende&lang=en&searchLoc=0&cmpType=relaxed&sectHdr=on&spellToler=&search=related
Personally I would just use a reverse loop, but that’s probably micro-optimization ;)
In my quick test the absolute path didn't work too well, so a relative path might have to be used.
@pborreli If you have time, send me a pr to till/composer and I'll include your fixes.
Maybe rename it to `mark_correspinding_notifications_read` to reflect what it does now?
so no laziness happening?
no description?
Really? I thought I had checked that and it didn't work. It would certainly be clearer that way!
So you want me to redo this lot? It may take a little time to get around to but I guess there is no rush.
This change would break backwards compatibility, which we can't do without a deprecation period. To get this change, I think the right thing to do is to add a new function, exti_attach_callback(), instead, which takes a pointer to a user-allocated callback. This saves space for the common situation where the user just wants function pointers.

We can then modify struct exti_channel so that `.handler` is a `void*` instead of a `void (*)(void)`. We can then add an extra byte to tell regular functions apart from callback pointers. The IRQ handlers can then check that byte and use it to cast to either `void (*)(void)` or a callback. That lets us keep `NULL` as the invalid value.
"not return a string value an exception"
It's still used in line 120 for `exports.testPrefRemoveListener`, though that use should be removed too, I'd like to do that in a separate pull request.
I agree that this is the worst part of my code. I'll investigate how to improve it.
I agree but that is what context-menu does right now so it'd be breaking compatibility to change it.
> Should I move treeView() out of paneTitle() and add it an Array[] parameter? 

There is no need to define a new prototype for it. Just move the var declaration out into the global scope.
Did you mean to add an assertion for this in the test?
Thanks for the explanation, I won't press it then. :-)

2012/5/19 aipp <reply@reply.github.com>:
>> @@ -0,0 +1,19 @@
>> +package org.openpixi.pixi.physics.solver.relativistic;
>> +
>> +import org.openpixi.pixi.physics.ConstantsSI;
>> +
>> +public class SolverRelativistic {
>> +
>> +     protected double c;
>> +
>> +     public SolverRelativistic(double c) {
>> +             this.c = c;
>> +     }
>> +
>> +     /**gamma = sqrt[1 + (u / c)^2]*/
>
> your new commits in your branch "relativistic&boris" are automatically added to this pull request. You can see them on this page "okapetan added some commits".
>
> If you press the green button "Merge pull requests", all your commits will automatically be merged into the master, so this should only be pressed by someone else ;-)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openpixi/openpixi/pull/19/files#r849676
instead of removing the tests entirely it may make sense to check that other values (including numbers) will raise an exception now. Something like (untested)

    it "should not allow numbers" do
      expect { file[:recurse] = 10 }.to raise_error(Puppet::Error, /Invalid value/)
    end
To do this "right" we should also remove the `require 'facter'` from the top, but this cascades `NameError`s to a bunch of other places.
y u no space `runner.stats = stats`
Good point - adding this to the unit test
second parenthesis is not neede and just confuse reader. it should be:
```
if( issubstring(oldname, "-bus-") || issubstring(oldname, "-id-") )
with your implementation $container can be a string too
Ah yes, I see...  I was indeed missing something.  As branan points out, this really is an awful mess -- there are much better ways (e.g. using properties, or storing params in a private var and actually calling the parent __setattr__ when a match isn't found).  But I guess if it works, there isn't much point in poking at it.
This is bad, you should do it another way
Oohh. That actually looks like the best route.
This try-catch adds perf impact.  Do you have a benchmark?  a better way would be to publish handleError method on the $interpolate and then have the $digest see if the getter has handleError if so call it with the exception. This way we are not adding any erros.
hmm, it fact, the tests are using the ConnectionMock which has the setter
You cannot use preg_qoute here, if you do so, ```$filter``` will not be treated as a regular expression (which was the intention of this pull request).
`quote do: unquote(binary)` is the same as `binary` :)
Moze byt. V principe na toto nemam nejaky vyhradeny nazor, lebo som v pythone takto velke este nic nepisal. Len som si daco precital na stackoverflow ako to moze byt.
Este celkom nie som stotozneny s viacerymi triedami v jednom subore, ale vyzera to ako standardna python vec.
This pattern seems to be occuring quite often.

It's probably useful to hoist this into a function somewhere that is simply called with a list of files to copy. 

It would significantly clean up these easyblocks. Maybe a generic easyblock that does this should be created, and the list of files to copy should be defined in the constructor of the deriving classes.
Put the closing """ on it's own line. Reduces the number of lines changed when you need to add text in a new paragraph :-D
Ok. I will leave it as it is =)
Maybe a comment here about how `http_parse_host()` will fail for empty hosts? Otherwise it's not clear why we think we're going to be able to correctly fail this condition.
I'm not sure what you mean? I do use that syntax in the code. Or do you mean that omitting the braces for one-liner ifs is not allowed?
This line gives an error on my Gentoo system. Looking at cmake 2.8, the module is named FindCURL.cmake. I had to rewrite the line as `find_package(CURL REQUIRED)`. Is this a problem on other systems, too?
Well they are functions, the syntax should take care of that on it's own, it's C like functions. So we don't really need that. Will check it by trial and error on the server.
Would this be clearer if this was imported with the rest of the imports?
This is a no-op.  Shouldn't it be the commented out line?  Otherwise, why call it at all?
I think load`` is enough, a calendar is just a collection of events with a title.
http://www.w3.org/TR/html-markup/table.html#table.attrs.border
Indicates that its table element is not being used for layout purposes.
という意図で付けたんですか？

例え前者であっても、
http://www.w3.org/TR/2011/WD-html5-20110525/tabular-data.html#table-descriptions-techniques
thがあれば non-layout table である意図は表明できるらしいので、いらないんじゃないかなあ。
something as simple as https://github.com/theforeman/foreman/pull/134/files#L0R11 ?
Adding "History"? I am confused because I have to many "History" things in this project. :)
I think you can just do

    return [key, String(value)];

The reason I had the check for `key.length` in the original code was that the replacer function would be initially passed an empty string for the `key` when called on the entire function, and that has to return a non-primitive (except a fn) in order for `JSON.stringify` to continue calling the replacer function: https://developer.mozilla.org/En/Using_native_JSON#The_replacer_parameter
This could actually be replaced with a slightly more efficient line:

    return document.getBoolean(QUERYABLE_FIELD,true); // by default, documents are considered queryable

This looks up the value in the document only once, whereas the pull-request's original code actually looks up the field twice. Considering this method is called so frequently, we should make it as efficient as possible.
Just to play devils advocate, why are angles special then? Why isn't `Angle` just a subclass of `NDData` if you want it to support arrays? I think we should think about this a bit more and see if we can make it fit better with the other objects we have, since it'll have much of the same functionality. Will `Angle`'s support uncertainties? They certainly should, right? If that's the case, the distinction is starting to blur...
![screenshot](http://i.imgur.com/kdfkY.png)
Get rid of the break tag and put another new line in.
Any particular reason why this was removed ?
I think we should make this configurable (in registerShutdownFunction maybe?)

Just concerned bout 500k being too high for some people, though I also dont know how much memory it takes to build a standard sentry message
= default
Same comment as for addition - if we can avoid the IF - especially the 'inverted if' that would be great
Sorry for not making this clear enough. Why would we remove urllib if we're still using it? Given that urllib2 uses unquote from urllib itself, I don't see urllib2 as a direct replacement for urllib.
seneca.fail( ..., cb )
Hey, can you jump online on chat for a second?
not needed externally, so doesn't need to be in the header file (also the i2c include is not needed then)
Nothing any more, removed.
Is it possible to write a test that ensure valid URIs work properly? At the least we could verify a 200 response code. One for same-tenant and one for cross-tenant access would be good in retrospect to the cross-tenant user issue.
Can you add an after() block which does this as well?
If for whatever reason the test fails between line 101 and line 113 the config won't be enabled, breaking close to every test
Logging implemented here.
The user should just be redirected back to /
That's coming in an upcoming pull request. The plan is that every check will implement it's own `#success?` method. I can then feed that into `respond_with object, status: whatever` in the controller. The collection of checks would also implement its own `#success?` which would only return true of all its checks return true.
There should be asserter::set_failed_assertions().
No hang on you're right, I'm just seeing something strange.
короткий и понятный алгоритм с использованием уже написанного метода. 
хм, что вам не ясно? 
1. self - Родной Cell
2. MutableDNA - копия днк
3. до тех пор, пока различия (hammingDistance) не достигнут нужного количества повторять мутацию

алгоритму плевать, будет ли мутация на уникальный нуклеотид, алгоритму плевать была ли мутация до этого. Просто будет работать дольше :) 
как говорится на 100% мутация будет работать ооооооочень долго (если представить двойную мутацию на исходный элемент), но работать будет.
просто вы закоммитили с одинаковыми, потому я подумал, что вы не нашли решение.
по поводу arc4random - в своем проекте я как раз его и использовал - минимум манипуляций)
Да, только что поменял.
The check is done in MarkusConfigurator. So do I just get rid of the "if AUTOMATED_TESTS_ENGINE_ON ... " statement here? I will change the name of the constants too.
do..while, don't see that around much these days :)
might want to assert that this is a non-empty string instead.
This and the method above are basically the same. we can unify them.

```
def self.request(http_method, url, options={}, apikey=nil)
  options.merge!(:apikey => apikey || DynectEmail.api_key)
  result = case http_method
  when :post
    post(url, :query => options)
  when :get
    get(url, :query => options)
  else
    raise "Invalid HTTP method"
  end
end
```

Or, something like that.
See the latest version of  [ORM's FilterCollection](https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Query/FilterCollection.php). If the filter has already been initialized, we should just return it immediately rather than reinitialize.
I agree. My mistake that this was left in. I've been using the lib in a larger project.
These tests are apparently pretty similar to those for `+interval:`. Can you please try to share more code between them?
Right, I realized that after writing it, but it couldn't hurt to also have this test in there.
I'd rather include this in the loop, and just do an early return. It'll simplify the code and make it easier to understand.
this is where my replacement library will eventually go. I'm leaving the empty file here in case someone else feels like contributing this.
I am just feeling uncomfortable with calling `rm` and `mkfifo` every time on start. Let's see what @hwhw think.
Do you want to encapsulate these calls inside of a using(ThreadAffinity()) block? I think we come to the conclusion that it doesn't actually do anything... but it is a pattern that most of the rest of the proxy class uses...
I would have said it was the note object oid (the one returned by git_note_oid), but now I'm a bit lost..
> @agramfort you mean so you could do arbitrary layouts, e.g. non-circular or with variable-angle gaps (but still circular)?

yes. We could have a gap between groups of labels coming from different lobes.

> If so, @mluessi what do you think about making a node_layout = mne.viz.circular_layout() function that would use node_order and start_pos to return a node_layout layout that could be used? The node_layout could then basically just be a set of positions.

set of angles I guess you mean. I like that.
Could you change that to PyroCMS, because the capitalisation is a bit funky.
exception and below availability
If you do `pip install salad` it installs your fork. Or do you mean Django-users will need the unforked `lettuce`?
JS linting reports: "Unsafe character."

This is probably something like ZWNJ. Use a Unicode char code instead, and make sure that there's a test for this in test/jquery.ime.test.js .
What about skipping the `j` variable:

```javascript
for (var i=0; i<length; i++) {
```
Prolong the time.
Shouldn't this go into scala.util.control?
Я уже привык у к unique
Охуеть, и потом ловить дабл фри?
Тут, по идее, и forward declaration'а хватит.
Esto ya estaba hecho para el fin del Sprint 3, no debería estar en el backlog.
Oracle conventions I believe.
Feedback on this method --- it's a little long. I strive to keep methods down to 3-5 lines if possible. An easy'ish way to achieve this is to move all methods inside a loop to a method. Helps with maintaining boundaries too.

Also: not a fn of `v` and `w` for variable names. Is a bit hard to tell what is what.
Please use lower case for options, ie `tty-log-level`
sure, should I delete the line or revert this portion of the commit?
According to PyLint, as a constant this should be all caps.
Hmmm, I think a call to check whether preload() is enabled is missing here?

If the index is not shared, it's only local, and the cache store is shared and no preload() is enabled, then there won't be indexing done in memory. Preload() is required here to load data into memory and index it, cos there's no state transfer and the index i not clustered. We discussed this in an email thread.
Nitpicking: The comment is too long, it should be on its own line.
In the current test environment there are no available "migrators". Once we have a test migrator, I will add the appropriate asserts here. The rolling upgrades stuff is sorely missing tests (as you pointed out)
We should rename this to `-noparents`, obviously.
I know. This is why I'm not calling it rectbin XD. I'm not very familiar with manipulating matplotlib primitive types though.
Ah, by range you mean the x/y range, not the "z" range.
Looks like you have since fixed the training white spaces.
I believe these should be absolute imports (i.e. include the "matplotlib").
Don't sleep here. Instead, I'd do a wait for condition clause here to wait until you see the + in the view of the phone number.
Plutôt que d'avoir  ce message defini a trois endroits différents autant le mettre dans une méthode que tu appelle en lieu et place.
Ca aurait très bien put être mis dans une constante de classe aussi :
```java
public static final String NO_PERMISSION = ChatColor.RED + "Vous ..."
```
good point will make the change
Better to do this since we don't need regex:

```clojure
(.split x ",")
```
rename conditionallength to just len - easier to read
also, the lenrule is about a "len"
Can we prefix this with oae-list as well ?
Disregard the above comment, I just saw this method needs to be synchronous for the validation plugin.
I don't think so, this action is specific to the html button with the ID specified, which is outside the form tags. Hence the need to find the active form in the previous elements.
This is deprecated in order to preserve backward compatibility. All calls should use the other method in this interface which severs the search logic from the Servlet classes.
all this memory stuff can be simplified with SGVector business with automatic reference counting etc
The second error message wont be printed since shogun exits after the first :)
also: return SGMatrix<float64_t>(); is fine (0,0) is not needed
This must be fixed, as mine seems to have the right indentation.
@mateusz Can we extract this into an individual commit then to give some context? 
@clarkepaul That's a lot of CSS for fixing a visibility bug, do you have more details on what visuals it affects? (given that I can't find any `class="fieldgroup"` declarations in core)
Agree on a separate template file.
An extra space snuck in here it seems.
I will look into helpers.py and remove this.
Kann entfernt werden wenn der Statusservice gemerged ist...
Here and a few other places you have  GitHub not mediawiki
Stray </h3> at the end of the line
Correct.  It just checks to see that we have an instance of a Model, and not an attribute.
Fixed the indenting- Thanks for pointing that out.

Yes, the `msg` object is a Sidekiq interface. I have added an additional test to verify that we correctly read the `retry_count` out of the `msg`.
Fixed in all three.
should be `$qb = $this->dm->....`
Yeah, I understand how this works :) I've bumped into this issue more than once, too, but I didn't find an existing solution, and it wasn't frustrating enough for me to invent a fix myself. I'm fine with this one.
I would write validation error messages in past tense.
How "it fails"?
This is of course not a correct way to construct a translatable string, also much better would be to have strings like "2 hugs, 3 runs".
Oh, I didn't uderstand you there. Will fix it.
OK, this is getting ugly. :-)

I would suggest, that you change code of this whole processor so that there is something like:

```
context = {
   ... static values always defined
}

if request can be mocked:
   location_form = ...

   context.update({
       'location_form': location_form,
   })

return context
```
Ah, yes, I didn't notice that you haven't yet done this. Use `$(document).ready(function () {` syntax, I prefer it over above because it is more verbose and even people unfamiliar with jQuery will understand what are you doing. Otherwise good, just wrap.
Button is disabled after submit.
Thank you, think I missed the compile warning.
If the attributes are in a FreeRADIUS dictionary, we should just switch our code to use them instead of having people change files on their systems that will be overwritten at every FreeRADIUS update.
You're right, on the config side that's redundant. However, I think in the code, in the get_arbiter, that's needed to specify that these hooks are the hooks for the watcher and not for the arbiter itself.

One example of other hook would be a hook for the arbiter, like a hook when the arbiter finished starting everything for instance.
Grammar: not "returns", "return".
We should define this, so I can learn it. I guess here it's to show that the two if blocks have no relation, will do that.
I didn't, but a Google search later I believe it's the Boltzmann constant: https://en.wikipedia.org/wiki/Scale_height
I would prefer ``x_noti`` instead of ``X_j``
put a limit on LOO loop for large data sets, large nobs, subsampling ?
Right on, this looks excellent, less dependencies == more goodness  :)
in this case we are providing a queue name
Please do not use `#` for inline comments, but instead use `//`
Can make a FontUtil function and add this function to that? We can add the other ones like isSpecialUnicode later.
Please use the same version than all other archipel stuff.
Are these changes correct?  We are going from a parameterized type to a hard coded value.
It's an easy change to strip them out.  I'd say, might as well do it on this branch.  I don't think we need a special issue for this.
Right.  "Analytic" in the SBProfile sense just means that it can directly return the value without using the full 2-d fft.  So a lookup table counts.
Yeah - if it's a Nexus Pro then you need to check for a License.

Is there a REST call to check to see if the server is licensed?
Haven't read into this cookbook in quite a while. Where is `rbenv_root` and `rbenv_binary_path` defined?
might there be some validation needed here?  like make sure the id is in the right course, etc?
Yeah, honestly I would just do it right rather than rely on what we currently have, the connection manager has lots of problems. ;)
Typo when changing javadoc
No reason really, I'll fix that
not

``` ruby
value.to_f.send(final_from_units).to.send(final_to_units)
```

?

(You changed the test below to use unit name as method name, so I figured Alchemist didn't support the `.to(:kilograms)` format.)
Asked her to do so.
You have duplicated vi header here.
is Conf an integer here?
This will cause the full tuplization to run even if the event does not pass any of the skims, and will not be written to the output .root file.
That is correct. Not everything needs to be reversed.
What is this doing in addDefaults? You cannot do that.
It will return `'yay'` not true :)
А как? Если такой тайм-зоны нет, то getTimeZone просто GMT возвращает.
Как в клонированный репозиторий вытянуть изменения, которые произошли после клонирования?
А чем тип boolean не подошёл?
I will update all the files
what is RTComTelepathyQt4-1?
Is that necessary once this is all hosted on OME site? The documentation will then be available from the top menu while you're on this page anyway.
Can all four of the dependencies here have proper links?
Should be `SVHTTPRequestMethodPOST` here. Other than that, looks pretty good to me. Is it tested? Does it work? :P
Sorry, debugging code slipped in. This is how I set breakpoints ;)
This line deserve a comment on such as: we use the first bit of the hash function to compute the sign and use the remaining 31 bits for hashing the index in a 2 ** 31 dimensional space. This makes it possible to do a single call to the hash function instead of two.
Spelling - it should be `peek`.
Yes, we need it. Added
Don't think this needs protecting, the only thing that resize rows ptr table is 'addRow', spilling can't.
Either the comment is wrong here or the code is ...
not quite sure what you mean
You could move this to the lines above:

    tmp.append(INTERNAL_SCOPE).append("::");

since it's always appending that.
Agree - shouldn't be in side a if !superfile block. Otherwise won't do anything if superfile != NULL ...
If you want/need an example of how to do all this properly, check out puppetlabs-mysql. In an ideal world puppet-postgres would be more-or-less drop in compatible with it (in cases where the same features are implemented)
一般的なネーミングルールでは、パッケージ名に大文字は使いません。言語仕様上は問題ないかもしれないけど、お作法として。
ESLoginService is singleton, so we should come up with something thread-safe here. We can create the client during service startup, for example.
I set up QtCreator to assist with debugging, and it dropped a webkit_server.pro.user file with my IDE preferences in the root.
I'm not sure if this is the proper way to express "no branch" in the db. I think we might have both NULL and '' there, whereas this will only pick up one of them

In any case, it might be clearer to use an explicit sentinel class, rather than None to represent any here, particular since some of the fields accepts NULL.

On the other hand, it looks like [here](https://github.com/buildbot/buildbot/blob/master/master/buildbot/status/web/console.py#L622) we are throwing away a list of branches. It seems like it would be straightforward to instead match against anything in the list. This neatly avoid needing to distinguish between None as no restriction and as NULL.
Not sure it is up to the locator to assert if an instance has to be validated against an assertion...
Exactly, so that just confirms my position that there is no determination in PHP between the two, which is what you alluded to by saying:

> Unsetting a value from inside a numeric array changes it to an associative - that's by PHP design.

So, because we are making our own definition within the framework, then we need to make a decision on which definition to go with.

* Any array with at least one string key is an associative array (before your change).

or...

* Any array with keys that are anything other than sequential integers (0 to N) is NOT an associative array (after your change).

Another example I could see your definition being a bit unexpected would be with something like:

``` php
<?php
$foo = array('foo', 'bar', 'baz');
krsort($foo);
var_dump(\Zend\Stdlib\IsAssocArray::test($foo));
```

Mainly I just wanted to point out that there was an actual behavior change in this commit, since the purpose of the change was motivated by performance and not to actually change our definition of an associative array. If everyone agrees that we want to go with this new definition that is more based on lists in other languages, then let's do it. However I think we should figure out if that is indeed what we want.

I'd say at the very least we should consult Ralph on this, as I know there's at least one place in DI where he distinguishes arrays with integer keys from those with string keys... A quick grep isn't showing it though, so it's possible he has his own function in there for it.
@Flukey please fix CS here, then I can merge it
I like the idea of passing either connection string or explicit credentials. The only suggestion I've is regard using `EMULATED` env. I left it's feedback in early comments
I just noticed this file is called LogInResponse.java ?? Is that a mistake / will it cause problems
@christianv Fixing...
@shacker Can we make sure to only have 1 space after the `=` ?
const ref here too (sorry) :)
indentation of the spaceship is wrong here
@robertstarmer same as above, can you remove this trailing comma
Why do we need this in the group show view?
Probably not necessary but it keeps it inline with the rest of the tests and readable and prepared for any future test cases to be added. I don't really see the downside aside from a few extra lines used.
We should prefer `function` over `method` throughout, right?  This is JavaScript, not C++.
So this code can switch to stream, but not back to static.  Was this an issue in the billboard collection too?  What exactly does the CZML look like?  How often were the updates?

Shouldn't we change the billboard collection too?  Instead of shying away from the static optimization, why not keep a longer history, say 90 frames, or use the wall clock (is that too much overhead?), like the `PERFORMANCE_IDEA` alludes to?  These are very minor changes; all the infrastructure is there.

At the least, clean up the logic in this function, and update the PERFORMANCE_IDEA to say that it never switches back to static, which can be significant on some drivers.
could it be `loadJson(source).then(...).always(widget._setLoading(false));` ?
You know the size of the array in advance, you can construct it with that size.
i was taking a queue from the 3DMatrix update you made recently, where you moved the code sample from iOS/3dmatrix.yml to UI/3dmatrix.yml only

I will place the line of description in the doc, in the next update
Can't we just have this be the implementation of resolveFilename instead of wrapping some local function?
It will still compile (on node < 0.7.9) and will just ref and unref the event loop twice instead of once, but it has the same effect in the end (prevents node from quitting).

But on >= 0.7.9, the API changed to require a `uv_handle_t` instance to pass to ref()/unref(), and there is none when working with `uv_queue_work()`, so you can't apply this new API to that. Thankfully, libuv does what we expect it to anyways in this case.
I tend to use both. Depends on whatever comes to mind.
I reckon it would be a good idea to just put that huge list you made into a dedicated page on the website, but keep it on the wiki as well.  The wiki page will be like bleeding edge content that is copied to the site when it is updated.
Should we throw an error for an argument of an unsupported type/form?
All this could be simplified:

```php
<?php
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $configuration = $this->getMigrationConfiguration($input, $output);
        $patch = new Patch($configuration);

        $this->outputHeader($configuration, $output);

        if ($path = $input->getOption('write-sql')) {
            $path = is_bool($path) ? getcwd() : $path;
            $patch->writeSqlFile($path);
        } elseif ($input->getOption('dry-run') || $input->getOption('no-interaction')) {
            $patch->patch(true);
        } else {
            $confirmation = $this->getHelper('dialog')->askConfirmation($output, '<question>WARNING! You are about to execute a database migration that could result in schema changes and data lost. Are you sure you wish to continue? (y/n)</question>', 'y');
            if ($confirmation) {
                $patch->patch(false);
            } else {
                $output->writeln('<error>Patch cancelled!</error>');
        }
    }
```
Nice, I'll add that in there for next pull request
I corrected it in this diff. Since this was new code anyways, I thought it would be better to do it now.
Actually, I'd be tempted to just remove these assertions entirely. It's quite common for `popFront` and `popBack` to assert that they're not empty, and asserting in here on top of that is just extra overhead. True, it's only in non-release mode, but it could still be costly. On the other hand, there's no guarantee that `popFront` and `popBack` assert, so I don't know. If we _do_ have assertions here though, `dropOne` and `dropBackOne` are inconsistent , because they don't assert at all. I say either assert in both cases or neither of them (and I'd lean towards neither of them).
And, when you do that data structure checking (in `SyncConfiguration`), give a nice comment about how we're matching desktop.
Rather than invert this, you can use forall and invert the return type of the case statement for less code and a one-expression function :)

Up to you, I prefer one-expression implementations.  Also, with a method name of `isReported` I think that makes more sense... filters forall {! applicable)
I wonder if this is the right way to go... I don't even know. This basically deleted annotations as comments (as objects). For now it works fine since there is no extra code for annotation delete than deleting an object, but if ever we'll have special things around, specific to annotations removal, this won't work anymore.
Everything I mentioned in the previous block goes for this block too.
no then just moving it to utilities class and keep the name as is `getGuid`
I think so. I se no difference on how third country measures are rendered for Pure-bred Horses.
simulated `click()` here
No torrent support, although since TypedArrays it would be feasible to implement.
Patches welcome ;)
Anyway, these metaurls aren*t regular mirrors in either case.
Can you please use real attributes here? They're not important, but I think using something syntactically valid is a good idea.

It might also make sense to add an example with an explicit class, like:

```objc
@property (nonatomic, strong) NSObject<Protocol> *object;
```
This sorts in decreasing order (I think). Is this desired?
I think this is consistent with other types.

In our use case, we have to be able to set any property to null (Modifying whatever is returned by the DoctrineObjectConstructor).  We use the Symfony validator (elsewhere) to validate entities (eg the Valid constraint) before persisting.
can we default this to the current locale? and could we make this a choice of all currently locales of doctrine orm?
Хуй с тобой, золотая рыбка. Тогда переименуй, не знаю, `hookTabFinishedMoving`.
Missing space before `val`
I'm fine with that, but let us do that in a separate pull request.
Never mind this one
Oleg, show, please, when the `BeanDefinition` of this class is registered as **bean**.
Thx
Sorry, I don't understand how it works with context aware abilities, like `InitializingBean`, without bean registration.
@pulse00 I see. I still think, however, that things like e-mail address generation should not happen inside the writer. Instead, they should be done while converting the data item. That may become easier when PR 2 is implemented.
@davehunt although this isn't actually true at the moment, we can change it so that every project has these details in the README.md
please fix the CS here too
For FreeBSD, it may be `apm -b` or `sysctl -n hw.acpi.battery.life` or `acpiconf -i 0`.
I think we can probably assume this step :-)
Can you prefix the test methods with "test" instead? Because that is what I'm using everywhere.
That's easy enough to add a test case for.  Let me try it out.
I agree, that would remove unnecessary cruft
I believe this was here, like the other dflist.kill, because there was no control over the files cached, and that might have fixed some deadlock that shouldn't have happened in the first place.

Consider a transaction where you add a file and then add sub-files to it. Both actions are added to the transaction, but the second removes the first file from the cache. The action still has a lock on it, but other lookups will create a new lock in the cache and deadlocks will occur. We still haven't seen this because transactions were not supposed to be used that way before (ie. they were wrong).

About removing the ```clearFiles```, not yet. Or, at least, I could remove, but would probably add later in the future, when DFSAccess will have more control over the transaction's cache.
update file?
Fixed. Please review.
Depending on the implementation in iOS (whether or not this directly queries `-[UIView frame]`) this may be inaccurate. For views with non-identity transforms, the `frame` property is invalid:

https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIView_Class/UIView/UIView.html#//apple_ref/doc/uid/TP40006816-CH3-SW5
throw an illegalstateexception if size > 1
Not sure how important this is, but should $form_state be passed by reference?
Is the unset and rebuild necessary? I haven't tested, but I'm wondering if just
return $form['wrapper'];
is enough?
Ah I see. Nice catch!
I think it should always say "Dragonfly".
I think this should print to STDERR
make this a static function on the Memory object, not a global function
Nevermind disregard my comments, it's probably good enough
good catch, fixing it.
Also an indentation problem here