labofsahil/github-event-dataset-2012 huggingface dataset:
We already discussed this and we'll hopefully find a better way to signal server for the end of the testcase. For now I think this line also needs some comment on why we fake a test result and hold onto it until all test methods complete.

We may even consider to give this a better method (name), we hardcode "run" in other places and it may make explaining easier if it was some method name indicating the end of a test case run.
What was the plan behind removing this code?  Facebook applications are limited to 500 test users, so if you're running the tests live against the FB API and don't delete those users here, you'll end up running up against the limit and having all the tests fail.  It's not the most elegant code, and I think I'll replace it with an after :suite call to delete all test users, but we can't eliminate it entirely.
Wanted additional args for focused specs. Will handle this in my own spec opts
why reflection?
nextRDD = converter.convert(predecessorRdds, physicalOperator)
Die local.conf.php sollte nicht eingecheckt werden. Bitte vom pull request löschen und Forte mitteilen, dass er das ins .gitignore aufnimmt.
I would use composition here instead of inheritance.
Can you please document this class' purpose?
should have parens here
Done,

Question: When should we use constant, when should we use params?
What is the invalid constraint here - is 2012-03-10T10:05:12Z supposed to be a date or a datetime?
s/sh/none/
mongod instances do this also.  They also have connections to all the other shards, for use in migrations.
Let's change 'Website' to 'Docs%20Platform' ?
You are comparing a UTC time with local time. I guess you'll have to do something like:

`var utc_end_date = new Date($('#datetime-tip').data('date-end'));
var local_end_date = new Date(Date.UTC(utc_end_date.getFullYear(), utc_end_date.getMonth(), 
                                                                              utc_end_date.getDay(), utc_end_date.getHours(), utc_end_date.getMinutes()))`

and then compare

`date_now > local_end_date`

I suggest that you run a couple of tests with events to make sure that this is working OK. Working with timezones can be tricky.
Fixed, as well as unintentional white space change.
We should only enable it in order to create the request from globals, then disable it again.
No, that's good.
S_MULTIPLE_ATTACHMENTS
Great!  I will look into that.
Since we return early here, can't  we remove the `if (!isFunction) {`?
That’s right, and there’s more. I can go through it in my IDE after the merge
The previous approach was trying to get in the way by doing app.on('connection'), then adding the "end" event. Apparently, it didn't play nicely with mojito. In many cases, specially when using a browser to hit the page, the connection never reach the close or end point, but using curl does it. I guess it was the way mojito is ending that connection.

After moving it into this low level hooking, everything works perfectly.
Not sure how these are used (yet), but it might help avoid confusion of the YUI_PREFIX is `$y_` :smile:  (The MOJITO_PREFIX could be `$m_`.)
cc @dominictarr
Same comment here as for _modulePath_
Document the type
don't commit commented code
prefer more specific naming than temp
This, the other tests, would benefit from different X and Y resolutions.
@mrocklin: I don't think it is well documented, but you can define a "do_constant_folding(self, node)" in your Op, this will determine if (and when) constant-folding should apply. In your case, if you simply return "False", I guess that would disable all constant-folding for your Op.
For an example, you can have a look at Alloc.do_constant_folding in theano/tensor/basic.py:3207.
Get it done.
Drop initialization -- variable is always assigned before use.
For relation in relations
I see that this has been cut-and-pasted from another module, but it seems like it's possible that this might some day be called with `ReplyNow` as `undefined`, which will blow up in the call to `timer:now_diff/2`. Is there a reason that will never happen? Should it be documented in case other things change?
Mikhail/Mark,

  I will try to catch up.  I am now busy with programming/re-organizing our central user administration system (cluster of LDAP servers).

Must is still to another pull request.  I made an error in my master branch and it was propagated to the parser branch.  I have to improve my git skills ;-)

I will give some inline comments on the category thing,   People on the mailing list find the category errors confusing because in the docs it is called promises and not categories.


On 28 nov. 2012, at 12:06, Mikhail Gusarov <notifications@github.com<mailto:notifications@github.com>>
 wrote:


In src/cf3lex.l:

> @@ -113,77 +124,191 @@ qstring    \"((\\(.|\n))|[^"\\]<smb://]>)*\"|\'((\\(.|\n))|[^'\\])*\'|`[^`]*`
>
>  class      [.|&!()a-zA-Z0-9_\200-\377:]+::
>
> -category   [a-zA-Z_]+:
> +/*
> + * declare a token for each catogory
> +*/


Common understanding by both Mark and me is that it is a step in wrong direction: making lexer/parser know more about promise types makes it less flexible (e.g. makes it impossible to add dynamically-loadable promistypes).

Did not know that this is possible. Is the also supported in the cfengine core or is this enterprise feature.   How are dynamically-loadable promise type defined?  Is this at runtime?


The better approach to take here is to add/improve validation in mod_*.c layer, so particular promise types would be ultimately responsible for validation, not the centralized parser (it would require passing enough information to validators in promise type implementations).

If we switch back to the old previous category statement for the lexer is it still possible to detect the syntax errors in the lexer/yacc? Or must we first parse everything and then later use C-functions to see if its valid syntax.

If we can use to return a token CATEGORY and check if it valid with a C-function and the C-function returns a pointer to a struct(s) with which types are valid. It has my preference.




—




DID


--
Bas van der Vlies
mail: basv@sara.nl<mailto:basv@sara.nl>
SARA - Academic Computing Services , Amsterdam, The Netherlands
Wouldn't be it better to remove the ~ to leave the full path to django.contrib.auth.get_user_model() visible (we have no  refeence docs for it yet)? This would ease the adaptation process for interested readers. Also, it is a function not a method.
Use `or` here, not `any`, same for all the other places.
Hmmh, won't this change what is passed into the post_sync signal? This is a (minor) feature change,  and this could mean the contenttypes and permissions aren't created for this model. (Haven't verified this).
I have just modified this function to make it generate geographical locations (as default)
Is it configureapp or configure?
Since @dcoutts also wants to keep the `install` function, I'll solve this differently.
I used a for... in loops for the sake of optimisation. Everything that is in the code path to create a Deferred or in $.when, I'd like us to treat more from a performance point of view : this code can quickly become a bottleneck in applications using Deferreds without any way for the dev using them to optimize anything.
Good point.  We should document and not install the unsupported module on GPDB 4.0.
It is obvious that you missed \f$, which prevents from generating document for this block.

<pre>
textfex.sql_in:122: war
ning: reached end of file while inside a f$ block!
The command that should end the block seems to be missing!
</pre>
What if the email box only appeared after the box to allow collecting the email was checked? Since this page is already hilariously dependent on JS, it wouldn't be a problem.
Yeah, we don't want to suggest sudo unless it is absolutely necessary.
Does this mean that `MacOS.xcode_version` will now be an empty string on CLT-only installations?
These lines are not needed anymore, since we've added homebrew's include and lib in #10510.
The python pull request is older. I remove the lines \o/
Preferred style is

```rb
cd 'src' do
  system "make"
  system "make install"
end
```

Same goes for below.
Why don't we emit the 'pressed' and 'released' signals here?
This line should still have an ending `.`.
Avoid empty lines at the beginning of a method
Can't this be autoloaded too?
Extra line. :)
I prefer the verbose output, as you have post_ids in your logs to check against if you accidentally typed in the wrong parameters, etc. The final count would be useful though
First, you need to check to see if anything is selected. If nothing is selected, then return. Otherwise, event.preventDefault() will be called (below) and the Return or Tab will not get inserted into the page.
No specific reason, just want to be sure that this is not set to non Boolean value by anyone. I'll change it back to ``!this.closeOnSelect''
Is it ok for any random code to call this?  Or is it intended only for internal use by modules like CommandManager and Menus?  We should document the answer.  Ditto for removeBinding().
Console messages starting with "Uncaught" make Bracket's inspector pop up, which is very annoying. That is why we remove the undesirable "Uncaught" prefix here.
No, it is used on debug start to load debug with the debug sources info - So, it should exist
Why not do this inside the if above?
`class(x)` can be a vector so you need `any` here
Bwaaaaaaaaaaaaaah copy paste!
I moved it out to UtilOs_cmake.cpp.inc because we have to configure this path via cmake (only cmake knows, where the data files are installed and how)
No space around `=`.
What is this `~`? Remove this? No?
this sounds angry
Again, no changes
This is to recalculate trackEvent left/width values whenever the zoom level changes. I'll try out using the method you suggest.
Can you add one more `\n` to the end of this?
Two lines please
Any suggestion on the naming here? tmpRetVal? Or just CDateTime wakeuptime?
where is the png?
Rajoute une taille limite (genre length=1000), ça devrait suffire pour un commentaire. Ca permettra de passer le type de TEXT à MEDIUMTEXT. Ca va pas changer grand chose mais j'aime bien limiter les champs à des valeurs "cohérentes" pour ce qu'elles font.
If this happens a third time somewhere else, I will have to insist that we give tandem some kind of meta-programmed paths helper that does this check automatically :)
@omaciel I made a small change to better catch internal product names starting [here](https://github.com/Katello/katello/pull/1063/files#L0R41)
Right now we use touch-and-hold to uninstall apps.  I've been assuming that we'll want to copy Android and use hold-and-move to rearrange icons on the homescreen. A contextmenu event from the platform could work for that.  Do we need a native contextmenu event for compatibility with existing web content?  What do android and iOS do?

I can take the hold events out of this library; I'm not using them in the gallery.  But if you define a native contextmenu event, I'll have to modify this library so that it understands it.  Imagine a 2-finger pinch gesture, for example where one finger stays still and the other finger does all the moving.  If the still finger triggers contextmenu I'll probably have to cancel it so that the pinch gesture can continue.  This will make things more complicated than they are now.
这个get方法挺好，不过刚发现这样会造成一点混乱。
比如很多时候我们会修改url->get_data，就像route里面做的那样，然后用get是直接get不到这些变更的。

其实应该是全局只有一个request，这个get是取出request->url中的get参数的。
这样我们可以对request做点什么了。不然每个地方都直接用get，或者$_GET去取请求参数可能会乱掉。
param要默认值的话，[]会比null更合适吧？
There are some implicit assumptions here. It would be helpful to note here that `xfer_complete` will always be called on the origin "node-under-repair" and that the transfer target-partition (which you call `Partition`) is always going to be a local primary of this node (which, again, is the origin).
In this case, the `Ring` says that the `Node` supports nothing, yet we favor the local view by returning `StateAcc`?  Did I miss something?
Better in what way? Less overhead/work?  Since this isn't in a tight loop I'm not sure how much it matters.
Ah thanks. both of the issues in this file were 2i copypasta. Fixed.
My point was less of doing something in one session and more of doing it it multiple "sessions" that are really recursive calls that are very non-obvious.  This is especially a problem with cs_main, which covers multiple, largely unrelated data structures.  Yes, if Bitcoin were designed properly and if the switch to using shared/upgrade/unique locks were instant, it likely wouldn't be an issue.  However, take, ProcessMessage, it currently takes a cs_main exclusive lock, however it is conceivable that many of its branches only need a SHARED or UPGRADE lock.  Take, specifically, tx processing.  It is conceivable that tx processing will only need a mempool exclusive lock, and only a shared lock on cs_main.  However, once the tx is accepted and the wallet is called to process, the wallet may end up taking a cs_main lock as a part of one of its routines (even though it may only need a shared lock, but the old code only knows exclusive).  Debugging such issues and tracking down each case where this may occur can get very complicated in the current bitcoin codebase.  The idea behind providing shared->exclusive upgrade is to take away one more thing that would otherwise have to be audited for when converting to shared locking.  Yes, such things /should/ be caught, but there is no guarantee and it takes away just one more failure mode.
Missing `{` and `}` as per the [coding standards](http://book.cakephp.org/2.0/en/contributing/cakephp-coding-conventions.html)
See docs for details? if you are not giving an url i think this should be removed
When noReports, isSuccessful is also executed, no difference.
Think you probably don't want this line here... Firstly it's page specific and secondly it doesn't return anything. Here's a possible alternative:

    def handler(...):
        self.object = self.get_object()
        return self.handle_object(object)
Insufficient indentation. 4 spaces are needed here.
Writing the message or checking the package?
In fact, I think the behavior is correct if this is just: `var text = json.text`, with no other changes.
Sorry for the delay. I was getting on a flight when I saw the email, and didn't have network access for a while.
These need to be `var pre` `var html` to escape the 'strict javascript' mode.
this should throw a skip exception vs swallow
I'll change it to `git_branch_type`
Add `fxp.close();` above this line.
Scope isn't an issue because this is contained in another function. Even functions declared with `function blah() {` are still assigned to their local scope (not sure I'm using the best terminology here).

Example: http://jsfiddle.net/GCLf2/
trailing comma here. Some browsers are ok with it but it shouldn't be there.
Nit: I generally prefer to include trailing commas in object literals these days, as they minimize code change when adding name/value pairs in subsequent changes.
The output from templategenerator.js was unparsable by the import routine because all "\" chars had been removed by this line. That mean that htmlblocks that contained escaped quotes and line breaks were now malformed JSON.
aha. i didn't get what you meant---that what ends up in the deliberation accumulator is not the result of the block but the result of `@@logger.info` (typically, `true`)
Can you give me an example where we only have a key but no value? This shouldn't bepossible :-)
than (if != null) will do the right thing
please add this in the composer.json files too
Well, what I'm sayign is that you are storing non-empty strings, so the ``if`` will always return ``true`` as soon as something is stored, whatever it is.
And btw, accepting only strings is the expected behavior for localStorage AFAIK
Ok, I meant why not use $statusCode in there then?
Then, it's probably better to avoid a condition there.
The examples are wrong: the second argument must be an InputInterface instance.
I must admit I hadn't look at the details of this PR, now I understand your point. However I still think this is not the right solution (to a real issue)

How would you differentiate the path "/path;k=v" (URL = "/path%3Bk%3Dv) from the path with parameters (URL = "/path;k=v).
This PR has been merged ;)
This was causing errors (user interface testing), so I took it out.
yep, I was not sure how exactly these jquery functions work in the background, I'll need to look at the jquery api more deeply
yadet nare inaro ya inline koni ya tag img
khodet bebin ba kodoom rahat tari
age moshleli barash badan pish nayad img behtare
You probably want the full traceback in there (http://docs.python.org/2/library/traceback.html#traceback.format_exc)
make_texturemap reads through the src ImageBuf, which may come from a user-allocated ImageBuf where ImageBuf::m_clientpixels is true. Return early with success to perform a NOP and just use the active in-memory representation of the image.
> I'd hope the interpreter would optimise out the lambda.

I think that is optimistic - I'm not aware of the cpython interpreter doing that kind of optimisation, though of course, I could be wrong.
`If the "img" field is not present, a text link will be shown instead of an image.`
Aren't there cross-platform filesystem manipulation commands, that would save the trouble of shelling out to "mkdir -p" and such?
I' ok with that...
From the jboss-remoting API client point of view, like you say, there's not much that can be done about. I haven't looked at the implementation, but I guess the remoting implementation will decrement the count asynchronously once the stream is closed?
The previous style was correct: unassigned vars on the first line, assigned vars one per line after that. I'll manually remove this part when landing.
why don't we put it directly in the markup?
It is not compulsory but I realized that appending nodes in a asynchronous way the UI works better during the load. Although if you are not comfortable with this change I can remote it
I tested it with exactly that command:

<pre>
/sbin:/vendor/bin:/system/sbin:/system/bin:/system/xbin
</pre>
jn -> joinNetwork.
I am trying to maintain the consistency of `window_manager.js` instead of write the code with Gaia coding style.
In fact I meant here: https://github.com/mozilla-b2g/gaia/pull/4877/files#r1640928 ;-)
why not defer?
nit:

``` javascript
case 'blur':
case 'change':
   this.refreshSnoozeMenu(this.getSnoozeSelect());
   break;
```
`#screen.fullscreen > [data-zindex-level="system-overlay"],` same below
typeof(window.Calendar) here too mayhaps
I forget to mention that I have changed the seeking behaviour in last patch.
Now the music player only seek audio (set currentTime) when the user's finger is away from the panel, that means the seek indicator will follow the finger but the audio will be seek until mouseup fires. This is something like the video player did, but without pausing the media content, and users can still listen to the songs when they are seeking to their favourite part.
the comment has not been adressed
yeah, perfect!
That will throw a warning. Please remove it.
After https://bugzilla.mozilla.org/show_bug.cgi?id=793329 lands, we should send an "errorMsg" parameter here.
Re-reading the code I wonder how this use case can happen?
This is cool, I wasn't aware of this pattern before.
Puppet Forge here has no spce but in the line below does. I think it's supposed to be two words, but double check.
Thank a lot, this patch work fine

Just a little remark the "&" is not necessary because curl stays attached to the script and the os boot process still continue only when the curl finish (here the famous 2 minutes timeout, but now we don't care about it :) )
This worked out nicely as a separate class, but what do you think about moving the code back into the original `base_text_formatter` file?  Every additional require statement adds to the time it takes to load rspec (particularly on 1.9.2, which has well-known perf issues with `require`), and I think this could live in the other file just fine.
There is a typo in the end of the line. Please fix.
I would prefer more padding ...
Actually there's a reason why I can't use case. Case uses eql for comparison and (eql "a" "a") evaluates to nil since both arguments are two distinct objects (with the same value, coincidentally :-)).

I could write a case-equal macro or something instead though.
What if coGroups is empty?  This code still works, but CoGroup doesn't make a lot of sense.  I think we should:

assert(!coGroups.isEmpty, "coGroupBy requires at least one other pipe to .coGroup")
You are incrementing once in the for statement and second time  in the else branch. Is this really ok?
Would be nice to know where these numbers came from
Space these defs properly, throughout this file.
It would be nice to remove this comment block.
`%(src::revsion)s`
Just db and not mq? Also, wouldn't it make more sense for `wantData` to simply imply `wantDb'?
I was just confusing this with `JabberStatusBot`.
We just don't need the interface IMO. The file dumpers are one thing,
the array dumper another. Different things, different purposes.
@naderman old PHP functions indeed do this, but I still find it a bad choice.
Now where did that come from? :/
You’re right, thanks for notice. I jush pushed fix commit.
Hmm you're right, I think Login would work for any case, I just noticed we do some customization depending on the app to brand the login string. This is where it's used http://cl.ly/image/0h1j0j3v2T1a . I'm tempted to remove all checks here and just return @"Login".
Would security be sufficient without them? Are there other ways to be more secure?
This is an undocumented behavior for the `fields` option: Apparently objects with a `display` parameter are also allowed in addition to strings.

Recommend removing this special behavior unless there is a particular reason for it.
there is a missing comma at the end of this line
`font-size` is declared twice right here.
We've run into this problem a few times, when trying to declarative capture concerns like these.

Maybe we have a library that wraps express' API?

    app.get('/foo', function (req, resp) ...

could be come

    routes.get('foo', {db_mode: 'ro', cache: 'NEVER'}, function (req, resp) ...

Then you can can get this list of routes as well as metadata about those routes.

This would capture metadata near the code that runs, would avoid repeating code.

Aside: A pythonic or java way to do this would be annotations

    # cache(never)
    # db_mode(read_only)
    def foo (req, resp): ...
why comment?  delete!
You don't need to submit another pull request, if you just fix it in a new commit on the branch and then push to that same branch on github, the new commit will automatically be added to the pull request.
Something is wrong in this sample layout - It looks like `ref_data` and `values`  are in two separate dictionaries that each have one key, but that doesn't really make sense, and isn't even possible unless there's an additional list wrapper or something. More likely they are actually sibling keys in the same dictionary?
Note: I get the argument that a tab can be customized for users, but then you can't align things predictably, default editors make tabs huge, and lots of people mix them with spaces. History has shown most projects, especially open-source web projects, can't handle tabs. 2 spaces keeps things readable, doesn't nest stuff to far right when doing callbacks in JS, and is consistent with the JS community. Plus forcing the size of indentation allows us to line stuff up.
Ok, makes sense in this case. Thanks.
you want to ensure a comment, so change `#*` to `#+`
As noted on the proxy class, something needs to mangle the function `*` to `function_*` before it gets invoked on the scope.
Thanks for the pointing out.
I have tried to use the matcher `be_computed_by` in new commits.
Looks like this could be simplified too, looking at the header:

```
vendor/llvm/include/llvm/Function.h:  void setDoesNotCapture(unsigned n, bool DoesNotCapture = true) {
```
I think we can drop the cases besides the `mock()`. Specs about whether eg `#to_str` have historically shotgunned a few builtin classes that don't implement the method, but I'd prefer to limit that to just Object, which is what a mock is.

Also, please use `should be_nil`
i feel like statsInterval belongs in the cache
No, it is the AsyncDatabase that actually is cached.
It doesn't really matter because it's a link and changing this might change functionnality. Maybe we can look for next version
Much better is remove the default values (=null) for the arguments and remove this exception and the above ifs.
Here you should use the constant defined in AbstractMessage
The same of lines 236 & 238.

To be clear. I don't say if it's bad practice or not, there is no rules about this. My concerns are about to make code with a predictable style and widely supported along the time. What do I mean? I mean even being a valid syntax of the code that can change with in some future release of PHP simply because is a weird syntax. Something similar like the other day where a contributor proposed `!!$var` instead `(bool) $var`
( and ) are not required in coffee
I'll look into it asap
@igorw fixed but i can't still manage to update the info for the bundle, weird
This is needed for PGB, and is probably not generally useful for all plugin users.
It is actually in seconds. I set 10 just for testing purposes. But in real world we would get loginExpiry: 1800 from the payload and logoutNotificationTime: 180 (or close to this number) which means that User will see a logout notification 3 minutes before the expiryLogin time. Which is in 1800 - 180 = 1620 seconds.
I think you are right. The main thing we want is to use package: from outside of src/ (e.g. for any samples for instance). I'm ok to leave it as it is.
Koska ollaan if ($toim != '')  else haarassa.
yeah, think that would be good to do right away. also if the user does not want to ignore them, he might still want to catch specifically.

do we have any way of logging yet? if so, we really should log what we ignore.
ah, ok makes sense then.
newline please :)
@emodric Please add a `use` statement here
small CS issue :-)
I'm also wondering if we shouldn't have a dict rather than a list of settings like this, so we can avoid to repeat SITEMAP_* everywhere. What do you think?
What do you mean here?
run_cmd will fail to create a shell if you're in a directory that has been removed.
Maybe you could fix run_cmd to check if this is the case, and let it do a chdir to 'startfrom'?
Use Object.defineProperty to setup getters/setters for this, so you can use it like so:

playerTypeLoading[ "youtube" ] = true/false;

var youtubeLoading playerTypeLoading[ "youtube" ]

This way you remove the need for set/isPlayerTypeLoading.
Example: http://jsfiddle.net/nC62g/1/
It's not directly related, and in no way affects your pull req, but if you wanted to be thorough, mumble, would you like to change the :message to use the translation function ts?

(It means removing the first parameter, in this case 'invalid_url', and only keeping the string 'does not appear' etc. from the second one; the :default => bit not used any more.)

*offers bribecakes*
I don't feel comfortable with the or name part , as it would mean anyone could do a token=hostname, while uuid might be harder to guess.
I didn't try it, but wouldn't calling ActiveSupport::Dependencies.hook! again after puppet load is better?

I think its wrong to undefine the unhook method as this will bite us later on (where we need to do some name space searches).
OK, here is my attempt to address the issue. Basically I loadData function is now responsible for handling 'route' events (since it actually has hooks to ajax request and can unbind on ajax.complete, unlike bindToRoute).
Is this method specific to http://sickbeard.com/api/#episodesetstatus ? We could use a boolean in the enum to limit the statuses to wanted, skipped, archived, ignored
Can you move this to the `TargetDefinition` class?
from what i see in code, if these two are not set, the following runs:

```js
else {
        pasv.listen(0);
        pasv.on('error', normalErrorHandler);
    }
```

pasv.listen(0) simply can't be good - but there's no default set in the initialization.  Is there something i'm missing about listen(0)? Is it random port?
Parens can be omitted.
Could you please update the PHPDoc comment for this method ?
Not sure if an array is really more intuitive & readable than the previous algo. I let the others give their opinions. Anyway, there are some CS issues :)
он сказал: "какая гадость эта ваша заливная рыба, но продолжал ее жрать"
Also make this
DriverManager.getConnection("jdbc:sqlite:Project2.db");
sorry
rv doesn't seem like a very descriptive name ?

what is the significance of using `rv === false` below? (is there a case where triple equals is needed?)
Please add the doc node describing what this module does.
Did you try running this? `@user` could be nil.
I need to setup `/team/about` in addition to the `/about` page to show that without the fix, `Refinery::Page.find_by_path("/about")` returns the page at `/team/about` instead of `/about`.
This returns a RestContext, not a Context.
It might be good to document how a flattened login id looks like.
``GlobalIndex(Nil)`` should be changed in ``NoIndex``
I think the formatting is a bit awry in here, though I think the JS files may have been reformatted by @xhaggi so possibly don't match the rest of the code.
good one! fixed.
You could do pretty much all of this in one line:

``` js
  , callback = this.req.query[app.get('jsonp callback name') || 'callback']
```
No they don't. Most of them return an integer and forthose that return a string, it's because of additional manipulation like the one for PostgreSQL above.
<% if tag_for.object.try(:persists?) %>
the argument should be a ``Imagine\Image\Color`` instance IMO
Is this the only difference between this version of declare and the normal `dojo/_base/declare`?
It has been removed because it does not belong to an architectural overview, which is what this chapter is supposed to be.
It is already part of the GETTING STARTED doc, so no need to add it somewhere else (for now)
This can be simplified into:

`[disposables makeObjectsPerformSelector:@selector(dispose)]`
These need quoting so people can copy straight into package.json.
I can change it to catch it that way if you think it's cleaner, though...
test_XXX.py should test the content of XXX.py

can you move this test in a test_make_eeg_layout.py in mne/layouts/tests/

?

I'll do it now
Just test that the command you expect will be sent to the system
Every single messagequeue has it's own settings? hideously wasteful
Strictly speaking this isn't correct right?  I mean, you can boot windows off a `d:` drive right?  I understand this is MVP, just want to make sure I know we might need to come back to this some day.
`None` seems like a better magic value (compared to "").
А почему off?
Да. Или по лямбде, если функции мелкие получаются.
Ну, конечно же, если ты когда в это упрешься.
¿Por qué el prefijo en cada AppKey?
switch `1 < tmax` to `tmax > 1`
The method returns the jobid for a corresponding job name that already exists in the queue (i.e. not first creating it). I don't know how to do this using drmaa.
You folks are right, it won't, as MAS noticed already. My mistake. I blame lack of coffee, and emanuele by default. (nobody needs a reason to blame Ema.)
I'm saying this line is being executed every single time the user hits a key. You are effectively evaluating every single time someone clicks any key on the keyboard for this element. Is there any way this can be moved outside of the keyup binding like it used to be?

*You* are referring to line #69 which is an additional evaluation.
Missing a semicolon after env.
same answer :-)
I think if you remove the tx from the globalToLocalTransactions map first, you don't have to double-check here: you know that any tx that's in globalToLocalTransactions is in localTransactions as well. 

Actually the transaction might be removed from localTransactions but before you actually use the local tx anyway, so maybe it doesn't matter...
From a user perspective, does it make sense to set this property to false? If so, when and why?
I don't like this big `try`/`except` block. Is there a better way of doing this?
Yikes.  Thanks for the careful review.
@jsloane We should make sure that we can i18n this.
int32_t
better make that SG_DEBUG
I'd prefer to keep customizations to this file low, as it'll make upgrading the library an absolute pain.
We've already converted the whole thing from CSS to SCSS, so will need to look over changes manually anyway,
but any customization we add causes us more of this manual work. Cna you describe why its necessary?
Is it the same aproach as in sealed case? Make everything non public what don't need to be a public and publish it when needed?
I publish by default all that can be public (every method that can be invoked not causing internal inconsitency of object). I see no reason why this method should not be public. It is well defined and commented. It can be used by outer objects with no risk. There is risk that when some developer will need command name, he will parse ToLine result insted of publishing this method, because he will not be sure if he can do that. The same aplies to CollectArguments.
does it not wrap around to the next line?
The closing bracket for an object declaration needs to be closed with a `;`

see http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml?showone=Semicolons#Semicolons for details
Idk, I'd say a tour is pretty descriptive. Also, idk what that bridge looks like. Some kind of suspension bridge, maybe. Also, you can't see anything in the plaza because of all the MIST.
I believe this should be:

import 'package:js/js.dart' as js;
Is there a particular reason for this implementation over against the one in getSalt?  Many of the hash types support 64 bit digits and this implementation only supports 62 bits.
Yup, it was a little mixed up due to the cstruct changes, but I've released ocaml-xenstore-1.1.0 that uses the old cstruct and has your changes (and is suitable for use with this pull req). Testing now...
Included in my pull request update.
Extract these 4 lines of so to a common method like `findUnusedTcpPort`?

Also, there isn't a good reason to use `Integer`, so `int` would be better.
i'm becoming old.
Solved! I forgot to update ```is_authenticated``` in ```models.py```.
Simply set context in a way that template will display an error. So you have three states:
 * we have daily horoscope for today in a given language for a given sign
 * we do have a provider, but no data (it is too old, or none)
 * we do not have a provider
Maybe cache. :-)

So yes, this is often a problem. When you add hack on hack and then you miss that bug is somewhere completely else which would made all those hacks obsolete.
HTML5 doctype? This is needed?
Update spec to indicate it can return `{{error, Reason}, State}`
I find unless/else a little confusing, if/else reads clearer, what do you think?
You are talking about making it inline right?
They have other pay products, so I called it PayGateXML to distinguish it
My bad, fixing that ;-) Thanks for the catch
sorry @petebacondarwin I had `grunt watch` crashing on me with your changes. On top of this it:
* wasn't watching partials
* wasn't watching less files
* was watching `grunt.js`, don't know if this can even work (I'm not sure that Grunt will pick up changes to its config files)
I know that the above change is not DRY enough but I'm sure that we will be going over grunt.js many, many times...
GZipStream from Microsoft has random deadlock issues, they are rare so we could ignore it in the console tool.
This will not solve the issue of the narrower scope, as you are still retrieved a request-scope service when building Twig. You simply avoid the detection done by Symfony. This will not be merged as it makes it impossible to use Twig in the CLI.
My coding convention is to use e.g. `@page` for 'instance variables' and `this.foo` for method references.
Well, it seems that they are not pairs anymore.
I'm all for private constructors in situations where users are not supposed to instantiate objects directly. Let's keep it.
remove this extra blank
Does this test pass? "4f86ca..."
Now either ```bundle exec thor cldr:export --components Plurals CurrencyDigitsAndRounding``` or ```bundle exec thor cldr:export --components plurals currency_digits_and_rounding``` works.

All the comments are very useful. Appreciate your time. I'll get them fixed soon!
You may want to use a Lwt.task () here so that the thread can be cancelled (by a timeout, most likely). Lwt.wait () is more lightweight but doesn't do that.
This can never be non-null.  JAXB populates upon call.
> I did have one question: what happens if max_extra_noise is 0?

I'm not sure why this is confusing.  It means don't add any extra noise, so use the full number of photons (from either flux or n_photons as appropriate).  This is the default behavior.
merged and pushed
ok, thanks, that explains it.
Uh... I suspect you didn't test this. You've created a local variable that is then never used. This stuff is too important to just assume it'll work. You need to guarantee it.
file is old, comments more update in javadoc and on web -- so deleting this file
Is the cast to `(List<? extends V>)` really needed? It looks the same as in the method signature.
This `class RootUrl` looks like a weird thing to have at the end of WebAppServiceConstants.java
Does this compile?!
We should presumably extract to its own file, and make it public.
oui, je couperais en 2 phrases
Those lines contained trailing whitespace and I removed it.
> there's just no reasoning with you.

I am perfectly malleable to a given point when presented with valid and applicable arguments.  If we were to only follow ES5 specification, and not verify behavior by real world example, so many things would not work cross browser.

Since you have provided the example of RexExp, I will change this line back, and instead provide a mixin replacement for this function that is high-performance, but aimed at modern implementations / people who are looking for all callable things.
I'd be tempted to have private methods to make accessing the logger and collector shorter.
This is the java that is installed on the baseline, it is not installed via yum so you need to use the rpm_package.  it bombs if it is already removed.

There a better way?
Won't this and the explode() above it have problems with files containing `.` in their name?  Like `jquery.1.8.js`
either... or what?
why are you using the ~ notation here? I don't know that. What is it made for?
Is this really needed? After all CustomUser won't be imported if `from django.contrib.auth import get_user_model` already fails.
Doh! Will do.
Whats kbd?
ok, i'm willing to do that - but in a separate pull request, plz
http://docs.puppetlabs.com/guides/scaling_multiple_masters.html - now that
I think about it, you will just set the $ca param to false and then can add
the ca_server directive to puppet.conf.

On Fri, Aug 24, 2012 at 4:36 PM, Ewoud Kohl van Wijngaarden <
notifications@github.com> wrote:

> In templates/server/puppet.conf.erb:
>
> > @@ -4,6 +4,7 @@
> >      reports        = foreman
> >      external_nodes = /etc/puppet/node.rb
> >      node_terminus  = exec
> > +    ca             = <%= scope.lookupvar("puppet::server::ca") %>
>
> How do you configure CA delegation?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/theforeman/puppet-puppet/pull/9/files#r1454036>.
>
>
The URL is incorrect, it should end ‘.git’.
Paul Irish way ++
Uh.. what is this used for?
This is duplicated code in install.php 
I've added the missing folders to that script.
I can't repro this warning. Perhaps it has to do with different versions of autoconf? In any case I'll remove it.
Actually that bug should be fixed too. That may create another PM window even if PM windows should be reused.
У тебя скобка в прототипе на новой строке, а у всех остальных на прежней. Хорошо бы предерживаться одного стиля.
I believe if I set it to anything else, the post won't be automatically scheduled for the appropriate date. It will just have a post_date of that date.
А что за extension-то incorrect?
Так нельзя делать. Нужно использовать конструктор с Throwable
補足したい例外を具体的に書いてほしいですー
Yep I agree! Alin's draft looks good.
s/sort_filers_sort_filters
Copied from contrib.comments.
this trailing , will cause the define to fail on 2.6.x
improper docstring
f7863fa
ты уверен что там так должно быть? я просто псевдокод написал )
Why keep this…
This path is also wrong, it is specific to your machine.
We'll likely need to list all the files under assets here, like images and other js files.  For now a todo comment will do
Récupère la légende d'un document
Actually, how so? I need a key per row if extracting, how can u pre-allocate (unless u pre-allocate a # of them or something fancy)
the critical block protects physical changes to disk, not internal members of a class, so it's ok for it to cross class boundaries.
Sorry, this needs to use the new licence.
>I don't understand your comment regarding "rowsToSort expansion (inside CSimpleSorterBase::addRow) is unprotected", It never was protected and I don't see why it needs to be. Its not protected in Roxie either.

Yes ignore this comment, it's (rowsToSort) is safe/already protected by RoxieOutputRowArray's committed rows strategy
The string above is for JSHint
What about using uuidtools, since that is a dependency of Chef?
The body should not contribute parameters for the request signature if it is not form encoded. Multi part is not form encoded and the logic handles that.  (http://tools.ietf.org/html/rfc5849#section-3.4.1.3.1)

extract_params will yield None if the body is not form encoded, however there is a slight chance it might work even on non form encoded body that just happens to be a valid form encoded string. This guess serves us alright in most cases since x-www-url-formencoded is quite a common case and people sending oauth request using another encoding will simply have to supply it themselves.

This prevents us from having to add the content type header 

oauth = OAuth1(....)
requests.get(url, auth=oauth, headers={Content-Type: 'x-www-url-formencoded'}, data=[('hello', 'world')]

and just go with 

requests.get(url, auth=oauth, data=[('hello', 'world')]

which makes for a much nicer interface.

Hope that answered your question =)
Very pleased to see this bug fixed!
We should probably either drop the second 'run' or as mentioned above change this to 'To manually test the extension'.
Should be 'Traits must have a "Trait" suffix.'
@christav : Just a question for my own education: why use the **if** construct here? As both branches are  calling the same setter, it *could* be written like this:

```java
result.setContentLength(blobContentLength == null ? 0 : Long.parseLong(blobContentLength));
```
Or, could just skip the setting of the default value and eliminate the **else**, which has the double benefit of less code and is clearer about the intent (if server doesn't give a length, we don't set the length).
there is reason behind using xpath: This is the direct and efficient way to get the values from cell and there is no way to use counter within css locator. If I used chained css then driver is locating the element which I want locate. so xpath is best way to achieve the target.
Kun jostain arvosta ei olla kiinnostuneita, idiomaattinen nimi on usein `_`: `(let [[x _ y] v] ...)`
not sure if we need a specific exception for this. i think i never created one for DI and this will not be something the user is going to catch anyways. if anything, it should be an exception in symfony2 core which afaik does not exist.

@stof is there any best practice for this?
Actually I'd prefer a method named `existing` - see above comment.
The username url pattern doesn't allow for a trailing slash.
that's pretty nice. I didn't know about the createSpyObj. It makes the test a lot easier to read.
Are you sure you want to do this?  This is a shallow copy.
Shouldn't this be   -- >   since: { iphone: "1.8.0", ipad: "1.8.0", mobileweb:"2.1.0"}
I think it's for MW, but there should definitely be a comment here.
I'm not sure the description is really telling us anything we don't already know -- maybe overkill :)
yes!

2012/4/13 denlab <
reply@reply.github.com
>

> > @@ -4,38 +4,45 @@
> >
> >  (defn group-by-count
> >    "Takes a seq and return a map of {values, count}"
> > -  [s] (reduce #(assoc %1 %2 (if-let [cnt (%1 %2)]
> > -                              (inc cnt)
> > -                              1))
> > -              {}
> > -              s))
> > +  [s]
> > +  (reduce #(assoc %1 %2 (if-let [cnt (%1 %2)] (inc cnt) 1)) {} s))
> >
> >  (fact "group-by-count"
> >    (group-by-count ["a" "a" "b" "a"]) => {"a" 3
>
> useless function `group-by-count`, with just have to use the `frequencies`
> function
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/clojure-consulting/twitalyse/pull/5/files#r682843
>
У функции много аргументов подумай как можно уменьшить их число.
`require( "./config" )` ?
You're right. Thanks for catching this
This would probably always throw an error as I interpret it; which is not necessary in certain situations. The following business rules apply:

    * If the first DocBlock in a file contains a @package tag, it documents the file unless it precedes a class declaration
    * If the first DocBlock in a file precedes another DocBlock, it documents the file

Thus a file-level docblock does not need to contain it (to be honest: with the advent of namespaces I am pushing towards removing packages from namespaced files since they only make sense in very specialized use-cases)
Yes it does but I'm curious about skip_migrations case where it doesn't install any migrations but still runs rake db:seed - seems a bit weird behavior.
$codeGenerator
> A robust idiom...

"robust "? Probably you aren't aware of the fact that dmd doesn't align stack data properly.
> If we are to fix anything here it should be inout(ByCodepoint) save() inout { return this; }

`inout(ByCodepoint) save() inout { return this; }` was indeed my first implementation, and I'd agree with you 90% of the time. However, it turns out that since the contents of ByCodepoint can all be implicitly cast from const to mutable (`int` and `const(uint)[]`), this is on of the rare cases you can copy an immutable to a mutable.

I figure that if you can tag the function as const, rather than inout, then that's better...?

The real question, is "do we want a const range to return a non const when saved", while still keeping in mind that a const-range isn't a range... I don't have an answer to that.

> And a minor unittest that it at least compiles...

`ByCodepoint` is a non-template substruct of the non-template `CodepointSet`. The code is in conditionally compiled here.

Also, 2 lines under, there is already the test `static assert(isForwardRange!ByCodepoint);`, which validates the range still conforms to `isForwardRange`.
Let's put this inside the unittest as `static struct`.
This transitively pulls in `stax:stax-api` which isn't need as StAX is part of Java 6 anyways. That version caused problems in my IDE (some constants missing), so I created https://github.com/gunnarmorling/hibernate-validator/commit/55471cd7871f588cdb323d004e9d1a0c69ded996 to exclude that dependency.
To be consistent with other quickstarts, I would propose we use jboss-as-negotiation-toolkit. WDYT? AIUI the toolkit is only relevant to JBoss AS anyway.
こういうのはclass定義のすぐ下にしたほうがいいよ。ぱっとみて、このクラスがどういう属性をもっていて、どういうメソッドがあるのか、混在していると把握できない。
Better:

    it "produces the bundler configuration for a group when converted to_s" do
See #63 for a sample table, though without the id columns.
I almost feel like we should be able to iterate through a bunch of ordered presenters that are generic, then.
Clarification: this is ok as is, just noting the end goal we should try to hit.
I can't test it currently, but if it's the case, it should be ok with the last commit?