labofsahil/github-event-dataset-2012 huggingface dataset:
the loadData() methods added here broke 32-bit and 16-bit image display in the AdvancedImageLoading example. i'm not completely sure why. maybe the ofPixels were being converted before?
Tpruvot
Many thanks for your reply.
Ignore that no used files in  your build but i still got this error as below:

build/core/Makefile:36: warning: overriding commands for target `out/target/product/jordan/system/lib/libOMX.TI.JPEG.Encoder.so'
build/core/base_rules.mk:523: warning: ignoring old commands for target `out/target/product/jordan/system/lib/libOMX.TI.JPEG.Encoder.so'

No private recovery resources for TARGET_DEVICE jordan

host Executable: mkbootimg (out/host/linux-x86/obj/EXECUTABLES/mkbootimg_intermediates/mkbootimg)
host Executable: acp (out/host/linux-x86/obj/EXECUTABLES/acp_intermediates/acp)
host Executable: minigzip (out/host/linux-x86/obj/EXECUTABLES/minigzip_intermediates/minigzip)
preparing StaticLib: libc [including  out/target/product/jordan/obj/STATIC_LIBRARIES/libc_common_intermediates/libc_common.a]
true
target StaticLib: libedify (out/target/product/jordan/obj/STATIC_LIBRARIES/libedify_intermediates/libedify.a)
host SharedLib: libESR_Shared (out/host/linux-x86/obj/lib/libESR_Shared.so)
true
true
host Executable: aapt (out/host/linux-x86/obj/EXECUTABLES/aapt_intermediates/aapt)
host Executable: zipalign (out/host/linux-x86/obj/EXECUTABLES/zipalign_intermediates/zipalign)
host SharedLib: libssl (out/host/linux-x86/obj/lib/libssl.so)
host Executable: clang-tblgen (out/host/linux-x86/obj/EXECUTABLES/clang-tblgen_intermediates/clang-tblgen)
host Executable: tblgen (out/host/linux-x86/obj/EXECUTABLES/tblgen_intermediates/tblgen)
preparing StaticLib: libnativehelper [including  out/host/linux-x86/obj/STATIC_LIBRARIES/libjavacore-host_intermediates/libjavacore-host.a]
true

make: *** No rule to make target `out/target/product/jordan/obj/lib/libcamera.so', needed by `out/target/product/jordan/obj/SHARED_LIBRARIES/camera.jordan_intermediates/LINKED/camera.jordan.so'.  Stop.
make: *** Waiting for unfinished jobs....
preparing StaticLib: libfwdlock-converter [including  out/target/product/jordan/obj/STATIC_LIBRARIES/libfwdlock-common_intermediates/libfwdlock-common.a]
preparing StaticLib: libfwdlock-decoder [including  out/target/product/jordan/obj/STATIC_LIBRARIES/libfwdlock-common_intermediates/libfwdlock-common.a]
target StaticLib: libfwdlock-converter (out/target/product/jordan/obj/STATIC_LIBRARIES/libfwdlock-converter_intermediates/libfwdlock-converter.a)
target StaticLib: libfwdlock-decoder (out/target/product/jordan/obj/STATIC_LIBRARIES/libfwdlock-decoder_intermediates/libfwdlock-decoder.a)
true
preparing StaticLib: libnativehelper [including  out/host/linux-x86/obj/STATIC_LIBRARIES/libfdlibm-host_intermediates/libfdlibm-host.a]
true
host StaticLib: libnativehelper (out/host/linux-x86/obj/STATIC_LIBRARIES/libnativehelper_intermediates/libnativehelper.a)
true
target StaticLib: libc (out/target/product/jordan/obj/STATIC_LIBRARIES/libc_intermediates/libc.a)

Could you give more instruction on it.

Best regards,
Jeff
this gsm fix is specific to the photon. i believe it still works with the atrix but would be unnecessary
BTW, I am on ubuntn 11.10 64bit
I'm no big fan of `org.hibernate.validator.internal.constraints.validators` as this would give us the empty intermediate package `constraints`. But `constraintvalidators` sounds good to me, I'll change the name to that one.
Confirming that this fixes the "Uncaught TypeError: Cannot read property 'options' of undefined" error, thanks
again; try one neat paragraph instead of the @param annotations.
Nice work;)
I think you should keep the notice file as it has the open source licenses .
why are you removing it? it will break bluetooth tethering as a client :/
`injectSubArch()` зовёт `link()` рекурсивно?
If Tag.collection_to_string doesn't give the desired output, it should be fixed there.
Why are you removing the "designRoot" when unbinding modelUpdated?
Say you have to construct temporary objects that have complex dependencies. You'd want to lean on the DIC provide them, at least partially. Example, ElggEntities could be created by the DIC, or some other service, that auto-injects the (currently hidden) dependencies like DB, Hooks, etc.
I didn't even consider the effect of that parameter.  I got the above code from OpenSAML unit tests and thought it was sufficient for all cases.  Not sure I understand your suggestion in any case.
Is that needed, can you not just declare target dependencies?
I think we can just put $wf->msg('msg') into the template directly if it doesn't involve any data.  that way there is no need for all those temp vars.
all these should be Durations
Ok. I'll do that :-)
I love how you saw this and made it happen, good times!
Any reason why this is done prior to creating the CEA?
this needs the same treatment as the corresponding `catch` in `systemInvoke`.
Well, I guess buffer is the word that we normally use, but the `cap` built-in function works on channels as well as slices: http://play.golang.org/p/9CKD5Q_oSe
I've been meaning to do this... good call.
It means, before it reads the declared annotations to create beans. This is no different than it was before.
I don't think we need both of these masks, and they should probably be attributes rather than methods.

How about just ``mask_non_b0`` or ``mask_signal``?
should the ignore_auth be in the context?  I don't like extra params on the actions
why is this not like the following ones?
Could be a matter of taste, but it might be simpler to do:
```
if kwargs.get('str-eq', None) is not None:
```
if you are concerned about whether 'str-eq' will be in kwargs.
Same as below with the log.exception, you could have simply done:

_log.exception(error_message)

and you get the message and traceback.
Method is now const
what does this method do?
I have been bitten by this before, and now i get to pass on the pain! Bwahaha.

Python 2.x has 'new style objects' all of which must inherit from 'object'

class JobFilter(object):

There are also 'old style objects' which you have defined here.

We want new style objects for consistency.

Some more info: http://stackoverflow.com/questions/54867/old-style-and-new-style-classes-in-python
I'm not bitter.

Okay I'm kind of bitter.
So if there is no parent, you are not checking any Ventures anymore? Why?
This was in 1b7fea70b490c2e2ccf0d9b7b1f21955a2b7ccb1
Should that be:

```
values['DEPRECATED'] = '"%s"' % ((deprecated[0] if deprecated[0] else 'TRUE') if deprecated else '')
```
We use … / &hellip;
Yes, I'm  not very comfortable with this. I think in practice will always use an absolute path as the parameter. AFAIK lsb scripts hardcode /var/run, shall we do the same as default path?
It is also possible that HandlebarsJsProcessor can extend the JsTemplateCompilerProcessor (which is a base class for HoganJsProcessor and DustJsProcessor).
An example of what a non-zero value does here would be nice.
Please set `mError` instead so that this error can be reported to the user in a proper way.
This header is still the old one.
Where are those constants (`COMPOSITE_OPS`, `CHANNELS`, `EVALUATE_OPS`, `IMAGE_TYPES`) defined?
Style: spaces between operator.
Sorry, don't know - not use terminal with 80 char line width :)
Using the PHP `self` keyword is discouraged in Kohana due to the Cascading Filesystem.

Because the `self` keyword always refers to the class it was written in (in this case `Kohana_Feed`) that class will always be instantiated, NOT the extended version of the class (which is just `Feed`). So if you wanted to extend the Feed class to add some functionality, you wouldn't be able to use the `Feed::create()` method, as it wouldn't create an instance of your extended class.
I would prefer to group delegates by visibility, so that users of the library will be able to see all public delegates at a glance.
Good idea, Thanks!
Even though I don't see a big improvement from begin..end vs the other way, I'm fine either way in this case. I just cannot guarantee someone else won't change later on :smile:
You can use the debugger ...
My first version was more explicitly.
But in only sqlite testcase, we need to pass Rails.root ...

What do you think about the following signature ? 

```ruby
def structure_dump(configuration, filename, root = Rails.root)
```
There seems to be no need for `instance_accessor`, right?
Wouldn't best :: Nil be more readable?
It seems that `time` is in fact required to be a `FiniteDuration`, because e.g. `isOverdue` fails if `time` is not a `FiniteDuration`; if so, this should be checked statically by making `time`'s type `FiniteDuration`. Consequently, you'd have to move `fromNow` into `FiniteDuration` to make it typecheck.
If instead `Inf.fromNow` is supposed to be legal, then `isOverdue` is buggy.
I didn't realize that it yielded the dict. That is definitely not safe.
Generic MatrixExprs don't have `.inv()` so having it here wasn't really consistent. Also the distinction between `.inv()` and `.inverse()` was confusing.
Sometimes SymPy is awesome.
Here and elsewhere, underline the words with exactly as many characters as are in the word.
Kind of reflection. Reflections are relatively slow, so removed it at all.
Add 

```
You can configre this property same way as a component:

<pre>
array(
  'class' => 'MyPagination',
  'pageSize' => 12,
)
</pre>
```
OK.

I've never done any C++ development, so I don't know the conventions.  I wanted to achieve better separation of concerns, so that the main source wouldn't need to know which compilers have `asprintf`.  

I'll change it.
sounds like it's widely used. and [bleach has a tight regex on the attribute values](https://github.com/jsocol/bleach/blob/master/bleach/sanitizer.py#L54) that should prevent javascript exploits.
Why are we upgrading to an older version? The latest is v13. Shouldn't we upgrade to that?
Are we using phpbb_db_tools?
This does not fix the issue. The problem, as I understand it, is that a founder (and I'm assuming any administrator) without m_approve or f_post cannot set that forum as a parent forum of another forum.

In my opinion, moderator and user permissions should have no affect on administrator tasks. Instead, this should bypass those permissions and as long as the user is an admin with forum management permissions, or founder, they should be able to set the forum as a parent.
Please create your own exception class.
CompilerPass?
This is called from mcp_main for moving and forking topics and therefore my previous comment should equally apply here.
I'm guessing you should cast to int here since I suspect user id is user input somewhere in this diff.
spațiu în plus după import
Formatting changes done.
Originally I thought use of the static function String() for type casting converted `undefined`, `NaN`, etc to `""`... It doesn't so I added the `||""`.. so yeah the function call doesn't really do anything except in the unlikely case that `al` is a number. I'll update.
Да, для даты что-то не увидел нормальных средств форматирования, но уж лучше перепиши в виде 'yyyy-MM-dd'.replace('yyyy', today.getFullYear()) и так далее, хоть поприятней будет смотреться.
Also: I believe it should be 
```
var docStore
```
PLEASE PLEASE avoid global variables if not absolutely necessary.
note that nothing about this particular view file makes the drug order form appear on the right side. Instead, this is just the "drug order form". It could be on the right, above, left, below... that is all determined by the container that hosts this view (in this case, see src/screener/app/view/PharmacyView.js).
Or maybe `GradZero(var.type)()`, to indicate that this Op is tightly coupled to this grad mechanism and not necessarily useful out of that context.
Use TODO instead of XXX
How about further refining the schema as follows

<!-- <procedures> -->
    <xsd:complexType name="proceduresType">
        <xsd:sequence>
            <xsd:element name="procedure" minOccurs="0" maxOccurs="unbounded">
                <xsd:complexType>
                    <!-- a "statement procedure" specifies a single sql statement -->
                    <xsd:sequence>
                        <xsd:element name="sql" minOccurs="0" maxOccurs="1">
                            <xsd:complexType>
                                <xsd:simpleContent>
                                    <xsd:extension base="xsd:string">
                                        <xsd:attribute name="joinorder" type="xsd:string" use="optional"/>
                                    </xsd:extension>
                                </xsd:simpleContent>
                            </xsd:complexType>
                        </xsd:element>
                    </xsd:sequence>
                    <xsd:attribute name="class" type="xsd:string" use="required"/>
                    <xsd:attribute name="partitioninfo" type="xsd:string"/>
                    <xsd:attribute name="groups" type="xsd:string"/>
                    <xsd:attribute name="roles" type="vtb:RoleNameListType"/>
                </xsd:complexType>
            </xsd:element>
        </xsd:sequence>
    </xsd:complexType>
    
    
    <xsd:simpleType name="RoleNameListType">
        <xsd:list itemType="vtb:RoleNameType"/>
    </xsd:simpleType>

    <xsd:simpleType name="RoleNameType">
        <xsd:restriction base="xsd:token">
            <xsd:enumeration value="sysproc"/>
            <xsd:enumeration value="adhoc"/>
            <xsd:enumeration value="defaultproc"/>
        </xsd:restriction>
    </xsd:simpleType>

</xsd:schema>

so that you may define roles as follows

    <procedure class="pkg.foo" roles="adhoc defaultproc adhoc">
        <sql></sql>
    </procedure>

I know no commas ...
activeNumOfEndKeys should be declared inside the "if block" or just replaced with m_numOfEndkeys.
Comment cut and paste error. Also, below, pn spelled np, isReplaceable argument is not documented, isMultiPart is not used.
This is valid C (although not very sensible, but that's beside the point):
for (i = 0; i < 10; i++) do { i++; } while (i < 0);

So how could you clearly see that it doesn't work inside a for() loop?

And no, adding the 'else {}' to your macro *doesn't* fix it, because if someone then uses the my_free macro and puts a semi-colon at the end of it (which is natural, because it looks like a function), then that semicolon will end the if() clause and leave the other else-clause dangling, which leads to a syntax error miscompile in code that looks just fine.

So..

if(x > 3)
  my_free(lolvar);
else
  do_stuff_with_lolvar();

would, with your version, expand to

if(x > 3)
  if(1) { if(lolvar) free(lolvar); lolvar = NULL; } else {};
else
  do_stuff_with_lolvar();

which is in no way legal C.

If you want your patches in the core, rebase them interactively onto some recent version of 'master' and remove all cruft so I can sanely review them without spending all day at it. Then I'll pick whatever patches measure up and drop the ones that don't.
<network name>
two blank lines between the import statements and other code
Why not use a defaultdict or setdefault?
Why 2-space indent? We use 4 spaces in python.
I agree, it's only possibly interesting to a developer. I was presenting it only
for the sake of completeness. I've hidden the effect setting behind the
DEVELOPMENT_MODE #define.
Thanks, I always end up half-writing my docstrings :P
ah yes - I forgot just how much I had changed to actually cook that particular chicken and scramble that particular egg in the app-loading branch.  Looks like promoting the convention of explicitly referring to the setting is unavoidable for now then.
Unfortunately, the dynamic cache is also needed in the SQLite schema backend - because SQLite doesn't support altering tables, it uses temporary models to create new tables with the new layouts. Otherwise, I would have left out all the cache changes in this patch.
Awesome. I will fix this.

On 2012-07-18, at 11:30 AM, Claude Paroz<reply@reply.github.com> wrote:

>> @@ -266,6 +266,10 @@ def test_decr(self):
>>         self.assertEqual(self.cache.get('answer'), 32)
>>         self.assertRaises(ValueError, self.cache.decr, 'does_not_exist')
>> 
>> +    def test_close(self):
>> +        self.assertEqual(hasattr(self.cache, 'close'), True)
>> +        self.cache.close()
>> +
>>     def test_data_types(self):
>>         # Many different data types can be cached
>>         stuff = {
> 
> assertEqual(..., True) -> assertTrue(...)
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/django/django/pull/218/files#r1188827
1. Your code => ` env.cpp:122: error: no match for ‘operator++’ in ‘++id’` (without any flags or with default cmake falgs)
2. `for (size_t id = static_cast<size_t>(llvm::Intrinsic::ID(1));` => error in my previous message.

If i change the line with error to `new IntrinsicSymbol(module.ptr(), Identifier::get(identifier), static_cast<llvm::Intrinsic::ID>(id)));` in compiles, but I don't think that it is better than the approach in the current commit
Ah, you did.  So you don't have to care about NULL.
Since node_modules is a special folder (namely a symbolic link) we need to handle this carefully on Windows, as removing it tends to wipe out the Meteor folder we try the different delete commands in the right order (such that depending on the type of terminal the right one gets called). Furthermore, we need to stall the deletion (due to virus scanners) until the file is gone or further steps in the process will fail.
I think we might want to look into using Bootstrap instead of hard-coding these, but we can leave that for a later pull request.
Ah good. I searched for this and found it in the list command. Formula.installed is a much better name.
fixed along with tests to check stderr
Doesn't getSourcePath only work for files in the root folder of they current user anyway, getting the mount point and check if that is the shared folder seems like the best option to me
Can we get a ticket for this too?
It's not storing the list of column specs, though, so this description should still be updated.
The remove note minus sign is not aligned with the add note plus sign above it.
Errors are added when there are bad indices.
This should fix the aforementionned tickets (SFBZ #444 & #445)
We can get rid of this. It's a trick I use when working on JS objects, but it shouldn'
That's goofy. And wait, why are you using hitch anyway?
This is weird. The ``htmlContentLoad`` module is referenced from ``brackets.js`` and ``SidebarView.js``. Maybe a better way for ``htmlContentLoad`` to initialize would be on ``document.ready``. The existing ``document.ready`` handlers could be deferred to a new event that we fire after the templates are evaluated.
var ``i`` is shadowing ``i`` from line 1426.
Same as above comment. I am not sure this case can be hit
`!document` -> `!doc` too
`grep -oE 'v[0-9]+.[0-9]+.[0-9]+` would be even more consequent.
Why remove this from the default config? Our basic template will overwrite this anyway.
missing closing bracket?
I am not seeing a click event being created with the trackEventClicked function.
same as above for urls.
In the beginning of coincod develop, we decide to put recaptch for security purpose. 
But Coincod beta seems like no need for that when we discuss in meeting last week.
It is because the meeting didn't come to a conclusion state that recaptch should be remove, so I just keep it there. So is it I should remove it?
what is that struct ? comments. Thx
this should be executeSelect, isn't it? we should not maintain 2 equivalent versions
This should be a short description.
again this argument can be tobeCommittedPaths
Yeah, gcc does this as well.
hah, why this change?
Ha! I am imagining a package of food with a warning for people with food allergies...
True: it would look something like this:
``` python
import tempfile

#...

id, tmpf = tempfile.mkstemp(suffix='.png')
plt.savefig(tmpf)

#...

os.remove(tmpf)
```

I'd prefer changing it to this before merge
I'll add a note about this - I think it is not a hard-and-fast rule, because sometimes the flexibility is more important, but I see what you're getting at.
Ah, sorry, this comment should probably have been removed - I hacked the line parser further down to not ignore blank lines.  If users add blank lines, they should also probably add comments in front of everything irrelevant and just use the normal FixedWidth reader.
Would it make sense to have this as the last entry (before "Other") since it's kind of a catch-all?
Be careful, sometimes schema() returns null when $useTable = false.
I think I see, so by adding the local sequence into the encoding, we can then use a `MinSeq`[1] here that potentially a lot smaller than `LastSeq`. This would happen if lots of updates occur after the one of interest.

[1] https://github.com/cloudant/fabric/blob/master/src/fabric_rpc.erl#L108
'callback' :) I think that one is clear enough
you should use 4 spaces per level for the indentation, not 2 spaces or tabs
totally right, this runtimeexception use statement should read ``use \RuntimeException``, we create a needless dependency on a symfony component otherwise. and additionally it would be wrong to throw this. if any we could use this idea of extending a base exception for createphp to allow catching it specifically. don't think we need to, but if then it should be a separate PR.
Good suggestion, thanks.  I have fixed the comment.
You are correct.  I've remove that if-block.
I think it might be a bit confusing that the recurrence expansion works on a toplevel vcalendar component, i.e. what should happen for vcalendar components that have multiple unrelated vevents in it?

In Lightning the calIEvent implementation and its friends bundle an item with all its exceptions, which is also why we have calIIcsParser. Maybe we need to either change the parser to do that (this means a bigger API change, and also introduces problems like what to do with parentless items), or at least have some other prototype object that can bundle them.
I left this test as-is in the interest of separating changes, but I'm not sure why these lines and the following `assert_equal` are present. It's just testing that the endians array is equal to a copy-pasted copy of itself. Am I missing something here?
This example should be updated with the `PageRoot` class.
Heh, good point (I think you mean `if kwargs.get()`), but I'm actually explicitly testing for False because kwargs is also passed through to the template context. So if someone passed it intended for template context, it could collide here.

It looks bad though, and is worth making cleaner with your suggestion.
I don't use it explicitly, but the javascript uses the id of the element to make the key for localstorage.
Ah, interesting. wfm
The original syntax will only enable controls that have already been rendered on the page. When the queue data is being loaded through polling, the latter syntax adds a handler to any element with `[data-confirm]` that is currently on the page, or is added through JS after the fact.

I've gotten into the habit of writing everything like that now, but generally helpful for heavy ajax or pjax driven interactions.
Forgot I'd made this adjustment.  If I remember correctly, this was a workaround for an issue I was having.
не. не required
Loading with `?w=0` shows no diff, so whitespace I guess
Seems like you missed this one =)
I agree with @fabpot
The difference with your demo is that you don't have the link, because you have not configured the IDE in your configuration. Force link to any value and you will see what I have on my computer.
$logger can't be null. because you will have error on `$this->logger->alert`
I'm going to fix that right now !
We should keep an eye on the ENV variable here during deploy.
Will this hit Google in integration tests that use a headless Javascript browser? A bit of a hack, but maybe easiest to wrap whole thing in `unless Rails.env.test?`
在没有被充足的理由说服之前，我不会同意任何字体字号相关设置介绍的merge
I don't know if, for our purposes, we'll actually end up needed XML serialization.  We should be able to accomplish what we need do by utilizing the Java Serialization API.  http://java.sun.com/developer/technicalArticles/Programming/serialization/
Indenting en lijnlengte.
a comma too much?
What does this error message mean?
I could not reproduce this bug do you still have it ?
Ok I will look more into it, at least the static handover example confirms that a list of records written as payload are written as an ndef message, i.e. there is no point in looking on the payload.length and compare to the consumed length when decoding.

So the ErrorRecord probably is part of the same ndef message and does not get its seperated ndef message. 

On the other hand, it does not hurt to fool-proof the decoding.
This allows both ways of overriding a ``GNU`` ``make`` variable:

- ``make PREFIX=/path/to/directory/ install``: using internal ``make`` variable overriding
- ``PREFIX=/path/to/directory make install``: using contextual environment overriding, a shell feature.
This reversion should also mean that we don't need 50f1107 - if we ensure that JSON-serializable types are always sent back for each control, we don't have to deep inspect anything.
idem, tu as commité ce fichier par erreur...
Should this be `packageGetVisualizationResults` instead?
I noticed that the other test execution (tests-osgi.surefire) was configured to use standalone-full.xml. I guess I should change that one to use standalone.xml as well...
Is there anything we need to do for non-modal dialog to provide context?
paypal页面不能显示中文和日文名字阿？
Thanks Kevin, I'm not sure what I was thinking there when I wrote that a week or two ago.

I cleaned this up with a couple of followup commits, including switching the map keys to keywords which I think looks a little cleaner. Note that I also replaced the map with an array-map since the order that these elements are drawn in is important (this assumes that unify will iterate through the map in order).
The main reason why this code was here is to avoid spreading it on multiple place when it will be removed.
Same that above
Use addEventListener instead of onclick.
`// Store the current active channel; change with 'audio-channel-changed' mozChromeEvent`
sync the style here, remove the trailing whitespace

`id = "shadow"` -> `id="shadow"`
@asutherland : I'm not sure if this is the correct way to undo an operation here. You can uncomment this line for testing if undo function did work. Nothing happened after calling undo for my testing and it will even force email app unable to launch next time with such error:

Problem in configCallback
Error: Unsupported op: 'modtags' (mode: local_undo)

throw new Error("Unsupported op: '" + op.type + "' (mode: " + mode + ")");     gaia-email-opt.js (line 31213)

asa_runOp@http://email.gaiamobile.org:8080/js/ext/gaia-email-opt.js:31213 MailUniverse.prototype._queueAccountOp@http://email.gaiamobile.org:8080/js/ext/gaia-email-opt.js:32476 mu__loadAccount@http://email.gaiamobile.org:8080/js/ext/gaia-email-opt.js:32221 MailUniverse/<@http://email.gaiamobile.org:8080/js/ext/gaia-email-opt.js:31948 MailDB.prototype.getConfig/folderInfoReq.onsuccess@http://email.gaiamobile.org:8080/js/ext/gaia-email-opt.js:15347 

That's why I comment out the undo function now.
(non-blocking comment)

You don't need the lazy getter if the script is being loaded with `defer` attribute.
Remove this line. UI should be updated with `SettingsListeners` above.
Once https://bugzilla.mozilla.org/show_bug.cgi?id=769347 lands, this fix should be removed. Could you add a comment about that, please?
group this with the `for` loop otherwise it's hard to read.
XD I just deleted them cause I thought that we had to put only cases related to the related language.
Ok, putting them back again :+1:
Yes also permission dialog.
In HTML5 /> is >
s/vi/vim/ ?
s/vi/via/ maybe?
Didn't knew we could have one without he other. good to know!
// need to setAppSize or for the first time, or, from FTU to homescreen
     // the dock position would be incorrect.
And here: "Password Recovery Request"
please remove parentheses ...
`removeOldestNotifiaction` is called by a notification since only the notification knows when it should be removed. That's why it has to be public.
This would probably be better as:
``@post('/mock_server/<type')``

So that as a resource you can later get a collection of all mocks (``GET /mock_server``) or all mocks of a given type (``GET /mock_server/http``) etc
Saying "you won't forget" is not acceptable. Just make this a TODO and open an issue for this, so that Jovan or Tyler or I can potentially look this over in case you get busy.
Add  ``@see theme_textfield()`` and a short description about why we replace this theme function.
The presentation characteristics need to be separate from the storage ones. Perhaps we should have the stored value be 6-decimal places always. The presentation formatting can be 2 or 3 decimal places based on currency. Again I really like the idea of encapsulating all this mechanics in a single mixin or class

From: Sakshi Jain <notifications@github.com<mailto:notifications@github.com>>
Reply-To: PrimeRevenue/tent <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Monday, December 3, 2012 9:13 AM
To: PrimeRevenue/tent <tent@noreply.github.com<mailto:tent@noreply.github.com>>
Subject: Re: [tent] Amount widget refactored (#83)


In lib/coffeescript/view/amount_field.coffee:

>
> -  getFormatPattern: ->
> -    '(' + (@get('formatPattern') or accounting.settings.number.pattern) + ')'
> +  centisimalVal: (->
> +    #More currencies need to be added whose cent value is not an idea
> +    if @get('currency') && (@get('currency') in ['JPY', 'KWD', 'OMR'])


Added a currency mixin. All currency related computations can happen in the mixin. For now, it just has a property called centesimalValue, which returns 3 for a few currencies and defaults to 2.

—
Reply to this email directly or view it on GitHub<https://github.com/PrimeRevenue/tent/pull/83/files#r2289089>.




***This e-mail message and its attachments are for the sole use of the designated recipient(s).  They may contain confidential information or other information subject to legal restrictions.  If you are not a designated recipient of this message, please do not read, copy, use or disclose this message or its attachments, notify the sender by replying to this message and delete or destroy all copies of this message and attachments in all media.  Thank you.***
Worthwhile allowing a user to specify an optional icon (bootstrap class name for a glyphicon)



On Aug 20, 2012, at 7:02 AM, Niall Fallon <notifications@github.com> wrote:

> In test/unit/accordion.coffee:
> 
> > @@ -0,0 +1,40 @@
> > +require 'tent'
> > +
> > +view = null
> > +appendView = -> (Ember.run -> view.appendTo('#qunit-fixture'))
> > +
> > +setup = ->
> > +	view = Ember.View.create
> > +		template: Ember.Handlebars.compile '
> > +			{{#view Tent.Accordion id="testaccordion"}}
> > +	          {{#view Tent.AccordionGroup}}
> > +	            {{view Tent.AccordionHeader title="Title1" target="collapsible1"}}
> The ID is sorted. Concerning the header, I considered that we may want to add further content to the header bar at a later date, in which case we could just do a yield. But there are other ways of implementing that when needed, so I'm inclined to agree and reduce the markup for the user up front. I'll remove the explicit header tag.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Looking at it again, I see what you mean - the existing unload pattern does seem more than a bit inconsistent (between reaping, which requires no observers in order to happen and is more of a garbage-collect, and going observed-to-unobserved, which seems to be treated as an urgent need to be unloaded promptly).  Concern I still have with a cancellable unload event is both that it is more expensive (since it needs to be a call, versus delayed), and that unloading isn't necessarily cancellable (unless you want to make Chunk.unload, Region.unload, etc all able to fail due to a cancelled unload).  Point of the reap event was to offer the option to control the unload when it was and could be optional, while the unload event was for monitoring the fact that the chunk had, indeed, been unloaded (which is good to know, and a problem if it turns out the unload was cancelled by a listener after you in the priority chain).
I'd say be careful when you use list's index directly. the regex search would not work well every time.
1- yes that's what I meant

2- AFAIK ```com.acme..*``` is not legal, but we'll have to ask @bnd or @njbartlett to be sure

3- right. some more code is needed :-)
Thanks! PR updated.
why you decided to replace short syntax with long?
We'll work on this file later after deadlines.
Responsibility!!! Move the computation right up next to the data. Like computation and data have fallen out of the nightclub and are up to mischief. It happens at data's house, okay.
please use parameters without namespace. The namespace only is added in the launch file, see https://github.com/ipa320/cob_robots/blob/master/cob_bringup/components/lwa.launch
@jordansissel sure it is, wrong assumption from me to leave event untouched, but is there really not a perf gain to use DateTime.iso8601 instead of Time.parse now with ruby 1.9.x ??
ya3, use named routes
Yeah, that's fair enough. I'll change this to be more explicit that we won't immediately be able to issue these warnings. If you remember to remind me to update this when we do start issuing warnings, that would be great!
This code could easily break with call order changes. 
Could you use a safier code like this one ?
    on(type, function callback(event) {
      off(type, callback);
      listener(event)
    }, false);
@lloyd @seanmonstar this gets ride of logging email addresses and keeps regex reusable.
So I didn't mention this the first time through, but I don't really like having this function do double-duty with the claim/not-claim thing. If you have a function with a boolean parameter, and pretty much the entire function is an if/else that does one thing or the other based on the value of that parameter, it's a pretty good sign that you should just have two functions instead.

And now with the refactoring you've done, that's even clearer - because if you pass `claim_rows=True`, the function does nothing but defer to `self.claim_rows`. So why not just remove the `claim_rows` arg here, have this function do what it always used to do, and just have your `process_objects` function call `claim_rows` directly?
With this method you will not get any other information why the Cu.import() could have been failed. So the code I'm talking about here should be:

'+  try {
+    Cu.import("resource://gre/modules/AddonManager.jsm");
+    AddonManager.getAddonByID(ADDON_ID, fillContributorsCallback);
+  } catch(e) {
+    ExtensionManager.getAddonByID(ADDON_ID, fillContributorsCallback);
+  }
While this is tracked under a different ticket numbet, it is not safe to assume that `ifconfig` can be found in `/sbin/ifconfig` as recent versions of net-tools install the binary in `/bin`, not `/sbin` (https://projects.puppetlabs.com/issues/13396)
That sounds good... I'll file tickets about that, but would prefer not to tackle that for this pull request.
Right, thanks. I just copied from other specs.
It will be listening to both events - but it's the only way I could see to match native behavior. E.g. As you click and you let go on another item it registers a click. And also work as it currently does on mobile (if I listened for touchstart or something, the behavior would have to change).
good idea, fixed
The route match object should not be altered.
This statements must be removed
This one causes serious troubles for now. I am working on it, but it causes lots of `->setSomething(null)` in the generated code.
@ralphschindler I stripped it in the last commits, yet I am unsure it is correct. What is the correct way of finding out if a setter/method has to be called?
The class is freshly instantiated after each test, thus it is *always* clean.
This import is not used in the code.
You should replace 255 for $maxLen
We should be able to get rid of some packages that are deprecated names of packages.  AspNetWebPages.Core, AspNetMvc, AspNetRazor, etc.
Pass this info via the Model (if Model.AllowUserRegistrations).
It was simply for future consumers, since this is a public class in Pinta.Core.  Without it, consumers always need to handle the case where we return null and store the surface themselves.  If they don't want to handle that, they can do force and always get the diff, even if doesn't save at least x%.
This has been copied from Zend/EventManager/ProvidesEvents trait... whatever is there I'm going to keep as it will be replaced by trait once PHP5.4 become min requirement of ZF2
The adapter is not required in the below "if block" so would it be worth moving this underneath so you're not making a call that is not required if the if block returns. Minor optimisation?
This part is with wrong indentation
Isn't there an indent issue here?
>
> Probably the reason for failing Visitor tests :)


Surprising, tbh. All it does is store the status code that is set so that
it can be provided to Symfony later on... I don't see why this would *change
* the status code...

--
Bertrand Dunogier
Lead Engineer Extensions
eZ Systems AS | skype:bertrand-dunogier | http://www.ez.no/
---------------------------------------------
Freedom to Create Your Experience - Join us at this year's Conference
http://cologne2012.ez.no

eZ Publish Enterprise 4.7 Available
http://ez.no/About-eZ/Events-News/News/eZ-Publish-Enterprise-4.7
Please read commit notes on permissionSet, as it is pury temporary structure, there are two possible fixes for it to return strongly typed objects instead.
Please see: https://github.com/ezsystems/ezp-next/commit/12a4f256da223e3af54ca750a0dfd8d217eaa462
Add module docstring, e.g. 

```
"""
EasyBuild support for building and installing MUMmer, implemented as an easyblock
"""
`
Also, ordering of eleements doesn't follow conventions
Perhaps a `:` or `.` at the end of this sentence? (not a big deal, but thought I would mention, for consistency)
Spacing between selectors and their descendants, please.
If they're visible, doesn't that signify that they're present?  Do we need 1st check, in light of that?
As Giorgos said on the other pull req, it's probably worth doing

```python
return redirect(urlparams(reverse('profile.edit'), fragment='services'))
```
So people come back to the same page.
filed https://webmademovies.lighthouseapp.com/projects/63272-popcornjs/tickets/1030-extend-various-soundcloud-options-available
Copying my reply here for the record/any interested parties who want to know why this was merged anyway:

The Join/Leave here is just for non-challenge collections -- there's a Join/Leave option for challenge collections in the challenge/shared/challenge_navigation_user partial that gets called on line 69 above. The Join/Leave option for challenges can't be taken out quickly and easily, since that partial also provides the Join/Leave links for collections/_header, and having Join/Leave only for challenges and not plain collections would be confusing, so we're leaving it for now.

We can modify that in the future, as we get more serious about caching.
This is fine for now, but we may want to reduce the amount of history this test uses to create just enough events to create condition we are testing here.
Yeah, but you only get the password in the creation call, and I wasn't sure where to store it,  so I made it install a ssh key instead.
sorry, that was an accident - I forgot to change compatibility from the template translator I was using.
Yep, there are more similar issues. When we get forms into converge-ui, I would like to go through variables and clean that up.
Okay, I've looked through the file, and it seems good. The configs that it's missing (but I can't say if they are actually used elsewhere) are

`listener_max`: self explanatory. We stopped using this a little while ago since we have relays.
`self_host` and `base_host`: both contain `'r-a-d.io'`. I guess they aren't used anymore, no idea what they were for.
`icecast_server`: it seems to contain "http://r-a-d.io:8000"? If you didn't find it, I guess it's not used.
Some old password strings were missing, no need for those.
`max_listeners`: uhh, this seems to be the same as above? Why did we have two?

And that seems to be it. If you have any other questions, just ask.
=> “to <tt>Gemfile</tt>”
Attempting to get a class: `pyfacebook.models.<module>.<class>`
`__import__` didn't do the trick since the classes aren't importable from the models' init
No need to export the addEvent & init methods..
A good API gets stuff done in least possible number of end-points
I think it would be better to have the same spec as string in here, so that we assure it really is working with integers
Does 7140d77 soothe your woes? There is still some suggestive notation in that conclusions of proofs are written underneath the trees but it is easily justified by our exposé of ->Npi and the propositions about the conclusion/type of terms/prooftrees under `F`/`F^{-1}`. If you want I can add a note making this explicit.

Overall removing the assumption classes was beneficial because it makes the equations easier to digest since less is going on.
I still find the TitleCase filename weird but it's a nit I suppose.
How does this affect tracking? We're pretty much guaranteed that the `uuid4()` next time around is going to be something completely different and perhaps therefor useless. Doesn't Django give us a cookie to work with anyway - why not use that exclusively?
so we are only supporting debian for acceptance testing?
But you would have thrown an exception if it had had too many results. Which means it must be exactly the result set you wanted.
Maybe make the above ``final``, since it's a constant value definition. (it's a small detail, but since we are at it :-))
Can it happen that `currentBehavior` is called between the execution of those two lines?
I have that in mind. But not as of now, the node_reference module is far from being deprecated it will take a while. Moreover I need to get a even deeper understanding of the module.
As I said before, as of now I want to make it with node_reference module ,but for the next release and the kind of issues with "feature requests" I would make it using entity reference module.
hmm maybe do a `new Route` here so we're passing all of them through the same point, but do a path of `*`
вопрос любопытства для. а почему unsigned long? у нас в массиве 100 элементов, хватит byte, inta за глаза. даже со знаком если он.
Ох уже эти безнаковые переменные в С-подобных языках, да вы праву лучше NSUInteger. Исправлю
Вообще говоря, такой формат не удобен, да и если им пользоваться, то скорее делать по-привычному: 

`NSLog(@"%i: %@",i,_DNA[i]); `

Такой формат ведь гораздо логичнее: сначала показываем индекс, а затем то, что скрывается под этим индексом.

Но на деле удобнее, когда последовательность будет в одну строку, без указания каких-либо индексов. Вот, например, у класса NSMutableArray есть instance method (метод объекта класса) componentsJoinedByString:(NSString *), который вернёт все элементы в одну строку, соединённые с сепаратором, указанным в передаваемом параметре.

Тогда можно ограничиться лишь одной строкой:

`return [DNA componentsJoinedByString:@""];`

И ещё одно, что рассматривалось в сегодняшней лекции. Если ваш метод переделать в description, что возвращает строку, то тогда выводить вашу ДНК будет значительно проще:

`-(NSString *)description {
    return [DNA componentsJoinedByString:@""];
}`

А выводить можно так:

`Cell *myCell = [[Cell alloc] init];
NSLog(@"%@",myCell);`
Не знаю будет ли так быстрее, но можно попробовать действовать от обратного: сначала создать массив чисел от нуля до kLengthOfDNA, а потом брать оттуда случайный элемент с последующим удалением. Будет своего рода рандом уникальных чисел. Но как-то это все громоздко выглядит. Может я просто не знаю о какой-то возможности языка?
Не подскажите, а метод @throw - это к чему относиться - поиск по библиотеке ничего не дал почему-то
Пауза на клиенте - что делает? Останавливает соединение? Останавливает мою змейку, оставляя остальные бегать? Останавливает игру?
All players should have the custom slots, not just spout ones :P
bcm_host_init() has to be called "early on in the program", and the vagueness is left at that. While the program currently works if it's called right before all the video code, I have no guarantee it will continue to work.
used to bust the cache
it will appear in the web site even without a function in viz. I feel this visualization code is not what you put in a paper so I would not consider stable enough to have it in the main code base. In theory every piece of code we put the main code base will stay and be maintained.
`header-gradient.png` isn't in `media/img/`, it looks like it still lives in friendlycode.
if (error.getCode....) then notFound = false; break;
Formatting is funky here.
Thanks, should I carry over the whole `update` method over to `admin/pages_controller`? or is there a way to narrow it down to when it's an xhr request?
Obviously this would need to be removed, no?
this is wrong. For the PHP template, you should document ``getVar()``. If you want to use the same way than Twig, it would be ``->getVars()['prototype']``, but this only wokrs on PHP 5.4 with the array dereferencing
This bit, though, is completely wrong.

First, it breaks style.  I'm using && to chain the functions in this project, so as to match the English of the spec more closely.  

Second, it's adding an unnecessary reconsume().  I'm not sure what that's for.

Third, it misses the actual bug in this line, which is that I should just be appending code, not consumeEscape().  Check the corresponding line in the spec: <http://dev.w3.org/csswg/css3-syntax/#url-unquoted-state>

So, I can't accept this pull request right now.  If you change this line to just fix the one bug in it and not do anything else, I'll accept it.
block是块的意思，要翻译出来
"Know what vendor prefixes are, why they are used"
whoops, glad we're deleting this :)
Use Akkas Logging facility instead of SYSOUT
Yes, sorry, I stupidly lost some work and that was the resulting brain dead copypasta
А пользователю уведомление ты выводишь?
Окей. В трей и в Tools.
沒有要用特效就不用再加額外的 attribute 了 ` "data-toggle" => "tab"`
Here you should use the ActiveRecord query interface... 

```
shows = Show.where(day_of_week: answer)

if shows.blank?
  shows.each do |s|
    puts "#{s.name} at #{s.hour_of_day} on #{s.network}"
  end
else
  puts 'No shows found'
end
```
/dog/ :)
Does this need to be a method, since it's called inline?
I'm not sure if we need six at all. distribute has a "use_2to3" option that automatically runs the 2to3 tool and I'm currently working on better Python 3 compatibility too and made good progress with 2to3. Mainly the __unicode__-related functions causing some troubles at the moment, but we get pretty far by using just the 2to3 tool with the same code base.
You meant 

```objj
[self _validateVisibleItems:NO];
```

Or do I miss something?
They're not implicitly static, they're implicitly with internal linkage. Marking this static ensures that it's initialised as a static object and if it's a POD then it's static value-initialized, meaning no runtime overhead. Also its lifetime is ensured to be valid before main() is called and until std::at_exit is called (and when other threads exit).
I agree we should be consistent with our types. In general we have been using strings as the type of arguments into the vms management, so I'll ensure that target remains a string.
but that's a pretty minor concern .. we'll see the error, ask around, and update the packages! so i'll take out the check if you're OK with it
`.keys()` is redundant for looping over dictionaries
I don't like that "mount_volume" lives in MySqlApp, a class that exists just to manage MySQL. It should be in its own class just for working with the volume stuff.

To mount the volume in prepare, you'd simply make an instance of this new class, call mount_volume, then make an instance of MySqlApp and call install_and_secure like before.
mmmmm copy pasta!
Hmmm, if you need this kind of logic, why not build the put command with Flag.FAIL_SILENTLY ?

That should give the same result without the need to code the try/catch, shouldn't it?
Fixed as you suggested.