labofsahil/github-event-dataset-2012 huggingface dataset:
Cool, but I'll be pulling this, but It'll have to be rebased, you used tabs :(
Doesn't pass the dmd unit tests.. at least one of them has a protection attribute that needs to be removed.
So this is a lot of commented code, what is the intention here? Are you coming back to this later?
Contributor should be listed using the following convention:  Firsname Lastname (Org1. Org2)

Andrey Fedorov (SPL, BWH)
Steve Pieper (Isomics Inc.)
Ron Kikinis (SPL, BWH)
No, the source is not available. It is a prebuilt module from ZTE, they
have never provided working source for the wifi. I do have partially
working source, but it has some fairly serious issues and I haven't had
time to look into it further. I thought arcee had the z71 wifi working
fairly well.

On 26 February 2012 21:27, Ricardo Pinho <
reply@reply.github.com
> wrote:

> Hey Tom, noticed you also an updated wifi driver for the zte blade on CM
> gerrit when you submitted these changes. Currently I develop for the
> commtiva z71 witch uses a similar (if not the same) wifi chip but the
> current drivers have some serious problems. This new driver you uploaded,
> is the source available somewhere?
>
> Thanks in advance, keep up the good work on Blade (brother has one, very
> happy with it)
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/TomGiordano/kernel_zte_blade/commit/f4c15a5f8363cbb5400445c2b43ea464b6930a18#commitcomment-1012116
>
Oh man, it kind of sucks that we need to go out and retrieve the story just to get the type.  Think it's worth changing this method to take a StoryType as well?
hey max!  can i ask what issues or problems/additions your additional code addressed--i'm using the plugin and would like to see if i need  to upgrade?  thanks!
hello;
genres, cast, director, country, languages  not work
I had moved it to the authentication stages, but good point, it should be https even before that, including creating an account.
my trinitycore repo. there ive aded the script to the core
I'll make sure to forward that to your boss.


Github supports [Jekyll](https://github.com/mojombo/jekyll) if you intend to do something more advanced, like a blog.
Yup, all fixed!
Oops. Need to set this to NULL. This is a conversion artifact from whem this class used only references.
Now **that** is a good idea!
Also, re: my previous note, don't use deprecations to workaround build issues :) For now, just clone Bukkit, `mvn install` and the new events will be fine. I sense an RB on its way soon and then we won't have to deal with these shenanigans.
I think it might be a bit cleaner/simpler if this destroy took the command to call on the connection as an argument. Thoughts?
I reread your post.   

just curious why you see what I was doing as monkey patching?
- the InstallRequirement  constructor was initializing self.set to None
- then Requirement.add_requirement() was setting the "set" property on the requirement to the RequirementSet object.
where is the monkey patch in that?
I tend to use that phrase mostly when patching methods on classes (usually in libraries I don't control)

I do understand your maintenance argument in wanting to keep InstallRequirements ignorant of sets and their properties.
This is the definition of an username, but in the upgrade is NULL DEFAULT NULL for backwards compatibility.
This is not backend-specific, right?  Should we pull it up to sequential.py?
Shouldn't we validate the max-tries value?
Of course, I meant that it might warrant a comment stating why it's done?
Ummm, this won't work as advertised wrt remoting. Also, an ActorRef can exist as an entity long after the actor is dead.
getCamelContext is thread safe
It should be compiled when you run "test:compile" in the parent project.

You don't need to make it a verified test if it's too much work, but remember that it is an example that should demonstrate something that does work.
I always get that wrong! argh
That seems like an API win since that is the most common case.  Would make it simpler and faster maybe too.
Again are we replacing groups with organizations or are we adding organizations alongside groups?
Let's move this entire section to the configuration section's subsection on how Apache's SSL affects Pulp.
s/server/serves/  I make the same mistake all the time.
Theses two imports seem useless 

- scala.Some is implicitly imported 
- You should avoid to import scala.collection.mutable.Map or anything that overrides a collection that is implicitly imported.
You can probably still remove this import. Would make your kitten happier.
It's just a cheap protection vs unnecessary StreamDetails queries.

Note that checking streamDetails.HasItems() only tells whether stream details exists in the class. If there are none, it could mean that none exists in the DB OR that they have not been loaded yet, so, normally, is not sufficient to tell that GetStreamDetails is not necessary.
Why this has 2 slashes?
I would want to name this "notify_observers"
I added this so we would have some idea of how often the original race condition happens by getting it in our inboxes. Is that not necessary?
This class does the exact same thing as `SandboxedTestCase`, except:

* It doesn't patch `mrjob.conf`
* It calls the tmp dir path instance variable `root` instead of `tmp_dir`

I can fix/rename that stuff now or later, doesn't matter to me.
use form instead of button, 
because this is an action actually, 

like
\<form action="control/send_me_password.php" method="POST"\>
\<input name="username" type="text" \>
...
\<input name="email" type="text" \>
...
\<input name="submit_btn" value="send me password" type="submit" \>
\</form\>
Order in the grid is not the same as the order in the MiPlanEditor dialog - they should be in the same order
This has to go in WRITABLE_ATTRIBUTES, we don't want it appearing in the JSON/XML output
Is this the type of change I should make an incremental branch for early integration?
More options here, add and remove as needed for debug context.
I think we should also change this to be `delete(counters[key]);` as it is in [the gist](https://gist.github.com/3625157). I don't really see the benefit of storing it as `undefined` and graphite will record `None` anyways it it doesn't receive a value afaik. So this is more or less just wasting memory. Or am  I missing something here?
Temporary comment, I'll change the content of this function in the next pull request anyway (once `multipart/form-data` works, files will be uploaded to `/tmp`, and when they're finished I'll move them into tree).
This initializer should be removed. Frames given during initialization will almost never be correct, because layouts haven't been updated.
This would read better as
> The default state of a control. It is enabled, but not selected or highlighted.
This early return might still be valuable.
Oops copy and paste fail.
V Nette Frameworku odsazujeme pomocí tabulátorů. Opravit a forcepush ;)
That would be difficult, because in that case the iterator has already stopped before starting. Even if you would return an empty index in that case, which should be special cased (hacked into) in the iterator code, it still cannot work in the ndindex case, because it needs two iterations -- one to return the index and one to raise StopIteration. I tried to use 'zerosize_ok', but ran into these issues regardless..
Long isn't reliable, for indices use NPY_INTP.
They're tabs instead of spaces. Eric, you need to fix your editor.
и тут пустую строчку не надо
не хочу пока удалять, возможно пригодится для фикса бага с перетаскиванием выделенных нодов и линков.
I meant this as a comment for developers, not to show in Rdocs.  Maybe i can move it down into the class body with a "NOTE:", what do you think?
I think there's no need to break the line here, can be a one liner.
I think the word `middleware` does not have a plural (so yes, the code below seems wrong).
it is nil by default
```
  def cattr_reader(*syms)
    options = syms.extract_options!
    syms.each do |sym|
      raise NameError.new('invalid attribute name') unless sym =~ /^[_A-Za-z]\w*$/
      class_eval(<<-EOS, __FILE__, __LINE__ + 1)
        unless defined? @@#{sym}
          @@#{sym} = nil
        end

        def self.#{sym}
          @@#{sym}
        end
      EOS


```
I like this approach. It reminds me of how I wanted to scrap `tpe`/`tpeHK`(and `tpe_*`) on `Symbol` altogether (leave `info`, of course) and provide a smarter `TypeRef` constructor (perhaps one that takes an expected kind). This overload of `appliedType` that takes a symbol and a variable-length list of type arguments would be the TypeRef constructor (supplying dummies when necessary, emitting a warning for non-empty dummies when in debug mode).

The other would be `TypeConstructorRef`.

Both should have overloads that take a Type (the prefix) as their first argument.
At least when delegating to clone, the user has the opportunity to wrap it in something that actually _is_ clonable.
That's just my 2¢ of course.
If you didn't understand the compiler or Scala all that well, just learned about AnyVal classes and decide to try them.  Then you run into this error message, would you have any idea what you were dealing with or how to fix it?

Since we have the opportunity to offer a specific suggestion or just say "don't do this", can we alter the error message?
typo: is -> of
So, as I mentioned in the original PR message, spsolve() should be used when the result is relatively sparse.  In certain cases, when the result is dense it makes more sense to just use ``scipy.linalg.solve()``.  However, it is up to the user to identify what kind of system they have. 

A sample use case which demonstrates need for keeping this sparse is as follows.  Say you have a 4000x4000 matrix which is bi-diagonal.  Taking the expm() of this matrix is also going to be very sparse.  Performing this same operation would be much much more expensive for a matrix which is only 0.05% filled.  The ``X = X + A.__class__(...)``  operation is going to be much more efficient due to a vastly smaller number of floating point operations.  

There may be an underlying BLAS or LAPACK function that could be used to avoid this loop, but I don't think that this would reduce a lot of computational overhead relative to the work it would take to implement.

So to answer your original question, while this doesn't necessarily *expect* sparse output, it is *suggested* to expect sparse output.  Maybe we can put some of this info in the doc string?
this line isn't needed.
For private instance-specific methods like this, I prefer to pass the `kapi` instance (or whatever Object is being processed) as the first parameter and reference that instead of `this`.  Personally I'm not a fan of functions that require the use of `call` or `apply`, because it masks the intent of the function (at least in the context of this library).

If you change this, you'll also need to remove the calls to `bind` in `gk.prototype._contextInitHook.canvas`.
use "ConcurrentMap" on the left hand side?
I think it's weird :) I've change them, but it sure is deeply ingrained, will see whether it grows on me.
s/graph-theory based/graph theoretic/ ?
can this be wrapped as

```
            f = s._eval_rewrite_as_sincos(s.args[0])**q * \
                t._eval_rewrite_as_sincos(t.args[0])**r
```
Tests should have been added for this.
`s` isn't actually used, it seems.
I guess it could.  These are public functions, so they could be called with any kind of argument.  

Perhaps it would be better to just let them fail, though, or at least give an error message.
We should probably raise an exception in all but a few cases. It seems odd that this function works on any input. Perhaps 
`if not isinstance(point, Point) and isinstance(point, Expr)` 
or something along those lines?
I would suggest renaming this. My first reaction was "Oh, cool, finally a vector valued function implementation in sympy". Maybe `LazyMatrix`? Is this related to `DeferredVector`?
I'm not really a fan of this; we made an conscious effort to not have the measure numbers of vectors show up; only the entire vector, and leave it to the user to get the measure numbers.
If you wanted to write a function that took a vector and frame and returned the measure numbers, that would be better. You could then use that within your code. Something like:

>>> measure_numbers(N, 1*N.x + 2*N.y + 3*N.z)
[1, 2, 3]

Also, I would consider using the dot product a better way to get the measure numbers, rather than getting the values from the args:
[pos_vector & N.x, pos_vector & N.y, pos_vector & N.z]
bu documentation ters.

bu kodu hic compile etmediniz mi?
Understand :) Maybe @qiangxue knows?
https://github.com/yiisoft/yii/blob/master/tests/framework/db/data/postgres.sql#L101
I think we could remove that function, didn't I removed it in my latest push?
ah, forgot about that issue... you're right then!
According to our decision to not support Ruby 1.8 this line is completely irrelevant. RUBY_ENGINE is always defined in ruby >= 1.9.
Oh! I tested `1/0` which raises a `ZeroDivisionError` but didn't try `1/0.0` which seems to return `Infinity`. That's a second possible bug which should be circumvented by checking `#infinite?`.
Yes, it still should run the initializer so that the rest of the attributes (e.g. lat, lon, scale, precision) get set in `__init__`.  If the `return self` line were indented then the `replicate` case would return `None` as the new Time object.
This category's header shouldn't be included in a target unless an application would want to import it. Since the functionality is just private to the framework, it would probably make more sense to be excluded from the Copy Headers phase.
I recommend you to use modular pattern to organize javascript code. The problem with your implementation is that everything in this file is defined in global scope. For example, one of the potential issues here - it's too complicated in this case to use another JS library that uses $ as jQuery does.

To do that you usually define function that executes immediately after JS interpreter parses it:

```javascript
// all the external (global) variables are passed as parameters (this is just for exmaple)
(function( $, ko){
// "use string" says javascript interpreter to use standard javascipt engine http://stackoverflow.com/a/1335881/444630
    "use strict"

   //... your code goes here

})(jQuery, ko);
```

I think you can easily move everything from here into `CommunityIndex.js` without any issue and then delete `Community.js` - I don't see any point in splitting logic into two files.
if these are in the js['mdn'] MINIFY_BUNDLE, we shouldn't need them here.
This may be a silly question, but the comment here made me think of it: is there any mechanism enforcing uniqueness of IDs within the document? What happens if IDs end up colliding?
Nit: These commented lines can be deleted altogether, no?
εμένα μου αρέσει.
Printing a debug line here with the cookbook order would help if there was an issue and the run didn't complete, and be generally clear.
Please remove editor-specific modelines.
Each post has a subject, and it should stay that way. The topic title is the post subject of the first post. So what this should say depends on whether you display the last subject or the topic title of the last added post. The two are different things. Since we are displaying the subject of the last added post, it should indeed say "subject" in the explanation too.
Evaluation is unclear here IMO. Add braces around `$refresh || empty($post_data)`
Conflict wrongly resolved
its the function name
@bantu are you talking about the current code? If yes I would hope postgres does not update any of the rows if any of them fail (implicit transaction around the update), mysql I expect to update all rows that it can.
This line should be `$back_to_post = '';` No space between the ' and the ; and add a space between the t and =.
If this list changes then the test will stop deleting files and old files will stick around forever.

At the same time you don't want to accidentally delete files not created by this test, which is why I said to put everything into a subdirectory that nothing else should use.
What kind of structure do we want then:

- agents/monitoring/lua/lib/...
- agents/monitoring/collector/lua/lib... ?
We use the same style as Cassandra, can you reformat?
Space after comma : (0, 99)
Please rename it to something like: `get_room` or `get_room_or_none`
If-ul de deasupra se asigură că nu crapă
this->attr vs attr also should be discussed in #9.
that --temporary note is on all lines with setcost, so i just followed the coding standard .)
The leading _ here would imply we're violating encapsulation and removing a private property. We should probably request a way to clear this data via a public function call, or provide the YUI team with a pull request and augment YUI.Env with our proposed function if it's not defined in the interim.
Do we need to watch for simple 'en' or 'de' here?
What about using [fakeroot](http://docs.openembedded.ru/fakeroot.html) for that purpose?
> so what will we do if that is not only None's but mix with str etc?  

We will throw TypeError with a cryptic message. The solution, if any, would be to do ndarray->list->set (or maybe ndarray->set if it works as expected...
any way we can share more controller + model logic between the Sencha Touch and the ExtJS4 implementations?
http://www.sencha.com/forum/showthread.php?181599-Relation-between-SenchaTouch-2-and-ExtJS4
there's a store already present with name Patient with different model so i gave it raxacorePatient
Optional: You could make all of these loops simpler to read and reason about by using for/in loops instead for loops 
```
for (item in Ext.ComponentQuery.query('ListView #sortName'))
{
  item.setUi('normal');
}
```
why are these new lines all commented out?
We should use tensor.discrete_dtypes instead of enumerating all dtypes.
Yes, Thanks. I have made the change accordingly.
This used to pass and the new one passes because I changed the behavior of
the ResourceBuffer class. setCapacity will now always set the capacity to a
new value. Previously, if the capacity was "unlimited", using setCapacity
would not change it. I.e.:

Old:

> ResourceBuffer buff;
> buff.makeUnlimited();
> buff.setCapacity(5.0);
> buff.capacity(); // returns -1.0


New:

> ResourceBuffer buff;
> buff.makeUnlimited();
> buff.setCapacity(5.0);
> buff.capacity(); // returns 5.0





On Sat, Oct 6, 2012 at 11:47 AM, Paul Wilson <notifications@github.com>wrote:

> In src/Testing/ResourceBuffTests.cpp:
>
> > @@ -118,7 +118,7 @@
> >  TEST_F(ResourceBuffTest, GetCapacity_UnlimitedEmpty) {
> >    store_.makeUnlimited();
> >    EXPECT_NO_THROW(store_.setCapacity(cap));
> > -  EXPECT_DOUBLE_EQ(store_.capacity(), -1.0);
> > +  EXPECT_DOUBLE_EQ(store_.capacity(),cap);
>
> If this used to pass, then why does this new one pass - is this a change
> in expected behavior of ResourceBuffer? I don't really see why the old one
> ever passed the test?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cyclus/cyclus/pull/402/files#r1779632>.
>
>
I thought that readonly_fields were added in Django 1.2.
could you please remove this blank line?
could we not simply use itemAt here as well?
the long name need to be change for a better name.
The `upgrade` command is disabled. `upgradeAction` calls `upgrade`, which just calls `die`.
I also had to modify `loadDependents` for my `issue272` branch—let me merge that so you can get it working with your repl code.
And @gibson042 strikes again. You're right, of course. My only excuse is that I didn't get enough sleep.
Could you please describe these steps in these configuration instructions?
As a side note, the admin stuff is Django templates.
this line could then be just `if mecab_support?`. Other formulae usually do it this way.
If it's running autoreconf, this may need autoconf and/or automake deps for Xcode 4.3+.
The message needs to be better

In order to remove cartridges, you must confirm the operation.  Removing a cartridge is a destructive operation and cannot be undone.
Given comments yesterday in chat, let exit code default to nil (if necessary change the parent exception) so that we begin reducing the number of exit codes and this one becomes 128
This was supposed to be a drop-in replacement for `.dispatch()`, so it needed to behave the same way. I'll take another look at how it's actually being used, though.
As the TODO says.
^Return a permalink to the comment.
Und die Reihenfolge ist falsch, es müssen erst die Blätter des Baumes kommen..
Yeah, I guess it should actually test the thing that it's supposed to be obeying. Yours looks correct, I'll update it.
This method still feels like a big hack to me. I don't think you should create another `abort` method to pass the data you need. I'd recommend creating an exception class (similar to [`ForbiddenError` here](https://github.com/reddit/reddit-public/commit/d221a058c3f8b0457fdd4b112e63c803fb7aad0e#L2R161)) that encapsulates the info you need to pass, and formatting it in the error controller.
While it seems convenient, ```arguments.callee``` is deprecated and will throw a warning in ES5 strict mode. It's better to use the function name.
Serialization is a problem when it's of a document that is being kept in memory in the cache, since another thread may modify the document while we are serializing. However, we can be sure that this is a passing state, so we just retry until we're done.
We use `==` almost everywhere else and again I would argue that using this syntax nicety actually introduces net cognitive overhead since fewer people are used to seeing it and many more people are used to seeing `==`.
Dude, you need to averate more!
I'm not sure what this comment means.
The ``result_path`` string is just passed to ``SpecRunner`` to handle. Maybe it didn't get decoded or ``brackets.fs`` can't handle tilde. I'll investigate.
Can we give this a more descriptive name, like "syncTextFieldInput()"?
I also found this stray console.log and removed it.
The vertical positioning of the icon is slightly off. Is this something you are going to fix, or will Garth fix it?
How about a more generic name here like closeRenameInput()? I could see this function being useful in other cases once we support file/folder renaming.
There are currently no project panel context menu commands that operate on the current selection, so we don't need to do this now.
There used to be, not anymore though. Fixed.
Is it safe to decrement length here? The function hasn't been run yet and it could be asynchronous.
if you want the user to provide the path to a stylesheet, this should be ``InputOption::VALUE_REQUIRED`` or ``InputOption::VALUE_OPTIONAL``, but certainly not ``InputOption::VALUE_NONE`` (which is a simple true/false flag whether it is here or no).
This is probably the reason of the exception you get btw if you were trying to pass the path
I think http://docs.python.org/library/urllib.html#urllib.urlencode does this, but escapes it correctly
I just added this so stuff doesn't break for people with couch 1.0.  It's not actually used, so I hope hope hope that means we can avoid preindexing.
You can't split a string with this function. The source code parser don't reassemble strings.
As per @nidico 's commit, the default should be None, shouldn't it?
Don't forget to include it in `index.rst`. You can preview documentation by running `make html` in the `docs` dir and then open generated `index.html`.
is this the default in the manifest for this property (10 that is)? If it is, then we should access it here so if it's changed in the manifest it gets updated here.
At the moment no - but you never know....
Nit: the line break looks kind of ugly and you have lines way longer than this.
Should be called "processNick"
Out of curiosity, what generates the .env file?
Well, actually it's wrong, probably some left over from older versions.  How about `Data type representing a response of server-sent events.`?
Locally removed. 

Please check the manual, there's something about windows environments and logging. I think we should add a global setting to enable/disable dyndns. Disable means we can silently drop the packet early on.
Tomas did the cli part, @tstrachota could you comment, please.
Yes! Closing and fixing.
I like Bryan's suggestion
I didn't know one could do that fruitfully. Thanks.
oh, scratch that, you're just using this as an array index, right?
`deleteMessages`. No reason to save that 3 characters.
@taldcroft: I think here's the deal: Let's not worry about memory limits - if you have 10^10 sources and use the coordinate class then things might break, but let's hope that's less than 1% of our user base ;-). But this got me to an important other point: These transformations should be accessible without using the coord objects. I'm not saying easily, but accessible. We can then put in the documentation saying that you can use the raw transformation and use it on your terabytes worth of data.
Luke suggested this at some time and as the application is named Bitcoin-Qt ...
Variable names without a prefix break coding style standard I think ... somethimes I really would like to have mandantory rules, that I can use while coding. I don't insist on that rename, but if you use buffer, you simply don't know what type it is.
I simply splitt the if(case 1 && case 2) into 2 if(case 1) { if(case 2) } as this is likely needed, when adding more proxy options. I remember you learned me to split a pull like this off from a new feature pull :).
I find regex's in bits hard to understand as I can't 'talk them out' while reading them. I'm fine with the change as it stands.
Do we need to call this method for each rule? Or would once beforehand be sufficient?
Just the methods
SITE_TITLE_SEPERATOR (which contains a typo anyway ^^) is removed in favor of hardcoding the dash. If people really want to change it, they can do it in this file.

Putting this in globals was wrong imo. If users should be able to change it, it should be a core module setting.
Hashie officially supports 1.8.7. I don't recall `#tap` being available? I could be wrong
Ah, I didn't realize this was *inside* of a method called for interactive help, sorry.  For some reason I thought it was in the constructor itself and that it would thus affect everything all the time.

Yes, I agree that if it's only invoked interactively at help time, it's OK.  Sorry for the misfire.
Well, given that this is an internal operation, we could simply increase the refcount for the object before returning it. I'd rather do this than add a public `git_object_dup`.
let us decide if we should deprecate the old tests or keep them sync.

If we deprecate, lets then move them out

if not, we need tests updated in both places.
hm, yep it is. Needs to be fixed.
Can you enclose that string in an l10n call please?
I looked at this method side-by-side with `search_with_es` and didn't see anything obviously wrong.
No need to do this map every time this method is called.
括号都是多余的
Within the dev vm from the top-level project - it's built as a dep that's loaded into the vm.  erlang version R15B01 

When I compile it from the host (also R15B01) in chef_wm, I  receive the  error you did. 

As far as tests passing - turns out that the old .beam was still in oc_chef_wm.
The words "mysql" should not be anywhere in any methods.
Haha no problem - can you put this in a new PR? Once it's removed I'll merge this puppy in! I'm also making a note to take a look at the newsletter module.

Adam
Is there a way to completely undo all my changes on this file, or do I just have to put the values back to what they were and push that?
The message should be more descriptive. It should explain that the underlying stream of this HTTP request has a problem. Or just forward the exception.
The convention is that function names start with an uppercase letter.
What's intended here? I wonder if it was meant (u32)(raycastint * 1000000000.0) instead? Note that the current precedence splices off decimals in the double. Also note that the max u32 is 4,294,967,295, so an interval of 5 or more already overflows. Is this a potential problem?
I'm confused...what use is the if-test if right after that, the same thing is done again?
Is this no longer used?
Added another commit to resolve this
the phpdoc site really uses an uppercased name for built-in types ? This will break autocompletion in some IDEs (which will consider it as a class name)

Btw, I don't see such format in the doc of [phpdocumentor on phpdoc.org](http://www.phpdoc.org/docs/latest/for-users/anatomy-of-a-docblock.html) or in the doc of [PHPDoc on phpdoc.de](http://www.phpdoc.de/doc/doccomments.html) (from the PHP4 times). Which site are you talking about ?
The indention is wrong here, you must use 4 spaces not tabs.
And a little lower there is a space after the comma.
ah no sorry, the 2.0 Size was not about the size of an array
Actually the SVProgressHUD setup we have needs to change since the longer dismissWithError:duration methods have been deprecated by Sam in newer versions of SVProgressHUD we should update to. That change will make SVProgressHUD dismiss far sooner than ideal for any length of message other than 'Error!' or something like that.

Going to check with Ryan for change in wording on the alert as this is what we'd come up with while working on the job.
Problem is that this is programmer's error: `if (self.selectedIndex = 0)` and compiler won't catch it. You are not comparing, you are assigning. So this:
```
if (self.selectedIndex = 0) { ... }
```
is equivalent to:
```
self.selectedIndex = 0
if (0) { ... }
```

It is really easy to write `=` instead of `==`.

If you write this: `if (0 = self.selectedIndex)` compiler will throw an error. And there is no way to create this kind of bugs.
This entire bit of `NSAnimationContext` should be removed. Please import `NSView+BTRAdditions`, and use one of the animation methods in there.
exampleConstImageAdapter has been renamed into testConstImageAdapter.
It's still useful when we create an event, to have something to identify the instance that is down.
No go! At least create a getter for it. Also when you do that you should make it Singleton, which is probably not liked very much.
We should really provide a way to help accomodate filling this backtrace, for example something like: https://gist.github.com/3899233
This structure is private to the modminer driver, and not for outside use.

To show the highest temperature in the RPC API, please edit the modminer driver where it updates the temperature. This way the behaviour is the same for both RPC API and Curses UI.
It'll explode the mail notification feed since it's the a huge changes feed. - pumping to couchlog is the right way forward, but on local debug, logging that goes to a file breaks/hangs pillowtop due to file i/o contention
You're using .get() here but not checking for None. What happens if we configure 'interface "None"'?
Okay, got it. So moveToTop is called three times: Once when opening a dialog, where it should be silent, as we trigger the focus event after the open event. Then when trying to open an already open dialog, where focus should be triggered if it wasn't focused already. Then when `mousedown` occurs on the dialog wrapper, where it also should only trigger focus when it doesn't move.

As far as I can tell, its correctly implemented.
@judofyr mnemonic - an apostrophe pretty much always means something is missing `let's` => `let us`. So `allows` => `lets` is just the regular 's' for the 3rd person singular. Sorry I missed the whole proofreading party, btw; just got home.
Thanks for the tip @steveck-chung ! Ive included your suggestion ;)
Actually, I think you can just remove this code, since the music app won't be launched as an activity.

@andreasgal: your comment applies to my gallery code...  I think the underlying platform bug is already fixed
You don't need to launch yourself if you are using attention screen.
> Will be "simulated" when the phone boots up, and the app frame cannot get this existing "popup" by calling this window.open itself.

To check: You agree that's how it should work, right?  The namespace of window names is deliniated by (among other things) mozapp boundaries.  Does that mean we can close bug 766873 (which still don't fully understand)?
Oh right, I haven't landed that yet!  :)
it is actually ok in the real file. please check. thanks
as this `.filter` class is defined in another BB, and in order to avoid cross-BB dependencies, I suggest we merge the `tabs.css` and `filters.css` and make two HTML pages:
* shared/style/unstable/tabs/index.html (or …/tabs.html)
* shared/style/unstable/tabs/filters.html
"showResults" ?
Instead of creating a whole type, you can use the DisposableAction we have.
同样，把下面的测试代码提上来，最后再调用 drop 形成闭环
Tests were failing without this line.
This looks a bit complex (as well as the 2 others further down).
The map + flatten can be converted to flatMap. And the whole thing might look better using a for comprehension.
I'll give it a try.
I prefer to use `toHaveBeenCalledBefore()`...
looks like you're missing a space between the colons after the variable options
please follow the comment style in the rest of the document
We'd like to avoid unnessesairy info-logging
Like in the previous diff's comments, document what these globals do.
``print t('available');``
Lines are a bit long and hard to read, better break to several lines.
& here too
A `__construct()` typically returns the class.
@cordoval you were saying that this is the description of the update command. But the description here corresponds to the behavior of the new require command (as expected), not to the behavior of the update command. so your comment ``I mean this is the description of composer update not of composer require package/package`` was wrong
But the library itself is a component now, too. And since the purpose of this project is to wrap it for use in JS...
Same again as above
Now your `event` has suddenly become an event object. Reusing names like this makes it more likely that you'll miss a bug.
yes, i can handle the forward-port for this.
Why sleep 1? Use #wait_until instead like done in here for example https://github.com/jarmo/RAutomation/blob/master/spec/adapter/win_32/mouse_spec.rb#L16
Do we still want to create an instance here?
Maybe add a comment why that is need could be useful. Just reading the code someone could wondering why `top = content.top` is not working if `window.top` is equal to `window`.
I can also see why you would not want to refactor all other such code, but at least refactoring these common validators into it's own module would make reuse in a future a lot easier.
That's bit hard to understand, especially when you see uri.js before this code.
If you don't know loader very well, it isn't obvious that `path` is the only one mandatory option to pass in order to have a working loader.
And then you try to come up with a valid path for your fixtures.
I'm wondering if it wouldn't be better to compute the uri here, without this `uri` module,
something like `let uri = module.uri.substr(0, module.uri.lastIndexOf('/') + 1) + "fixtures/"`.
You can keep the current scheme, but please put a comment.
This creates an outgoing request, right? Slow servers could make this much slower. Not sure if there's an answer to this, though.
Tests added, [fixed](https://github.com/mozilla/browserid/commit/28c275b34af4b93a48a7474e4afb94d8ac587ac1)
`$whiteListOfDeclaredClasses` instead of `$whiteListOfDeclaratedClasses`
IPS pkg would upgrade the package if I try to install a version that is latest , and would complain if the version is lower. So two versions can not coexist.
@haus I've fixed the `Puppet::PUPPETVERSION` issue in this diff.

This is a slight change in the convention of working with Puppet version.  I'm establishing the expectation that the Puppet version should always be obtained from the `Puppet.version` method and not the `Puppet::PUPPETVERSION` constant.  

This is better because we don't need to monkey patch things or `grep` the source code.
Yes, first I though I schould add the same description as the one on top of the file, but then I left it like that.
Ah, good catch! e6a4e22 fixes this. There have to be two separate return statements because of an odd issue where IE8 doesn't return the correct child element after appending arbitrary HTML unless the appending and child-locating calls are chained together.
domready inception
might want to add a test with multiple threads, given some concurrent operations being done above.
Lowercased it - like I said, however, it's irrelevant since all functions using it accept either case.
this param don't exists in the method signature
I like the look of this a lot.
Why don't you send msg as an argument to the hook (esp msg.payload should be interresting to the hook)? Also, why isn't there an "else" right before the hooks.callAll?
Any particular reason? The wrapper commands are quite useful, particularly the ability to associate your project with the virtual environment.
@seandowney @svizion 
I have this 99.5% done, but for some reason I am getting a 

**Fatal error: Call to a member function find() on a non-object in I:\My Web Sites\ootp_web\html\ootp_online\bonfire\application\controllers\admin\home.php on line 59**

error on this line. Any thoughts?
This is used in rebuild()
Just a question. Does this mean we can add multiple performance data, like a, a_critical, a_warning, b, b_critical, b_warning ?
i'll look into it (but not all months have 30 days)
how fast is this? (that's a lot of days)
use copy paste friendy print_environ function here aswell...
Those are typedefed (differently) in the file earlier.  Just search for u_int64_t.  I was getting compiler errors on the Mac.  Not sure how it works for others.
I don't think you should suggest ``dev-master`` explicitly as this version will change. You should either use a constraint targeting releases (if there is any) or ``*`` IMO
i think we should leave out the filter stuff for now ..
`$(function() {` would be equivalent and more concise. </nitpick>
Just  a though to make sure that this is your intention: Maybe you alter `P3P` header only when not available?
I was trying not to introduce multiple new concepts at the same time. But good noticing it.
oh right, nevermind

On Tue, Apr 24, 2012 at 5:09 PM, Owen Coutts
<reply@reply.github.com>
wrote:
>>      url('^groups/search$', views.search, dict(searched_object=Group), name='group_search'),
>>      url('^skills/search$', views.search, dict(searched_object=Skill), name='skill_search'),
>> +    url('^groups/(?P<slug>[\w.@+-]{1,50})$', views.show, name='group'),
>> +    url('^groups/(?P<slug>[\w.@+-]{1,50})/toggle$',
>
> Cool on the alphanumerics but I see a limit of 50 here no? https://docs.djangoproject.com/en/dev/ref/models/fields/#slugfield
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/mozillians/pull/227/files#r728674
More description of "why" needs to be added to this comment.
Note: despite the claim that the difference "should" be negligible, IIRC this is what will cause DOM exceptions when the media isn't ready and currentTime is set
Is that really what we want to do here? When on Unix, the path separators will already correctly be '/'.
never-mind, I've rewritten this, see https://github.com/theforeman/foreman/pull/95/files#diff-1
Why + two static strings?
That would break existing functionality. Presently the this is set to the view's instance.
These constants are now being defined on `Pod`, whereas they should be on `Acknowledgements `.

You can define them in `cocoapods/generator/acknowledgements.rb` like so:

```ruby
module Pod
  module Generator
    class Acknowledgements
      autoload :Plist,    'cocoapods/generator/acknowledgements/plist'
      autoload :Markdown, 'cocoapods/generator/acknowledgements/markdown'

      # ...

    end
  end
end
```
nit: use double quotes in JS
where does `data.results.tests` come from?
Added more documentation. Evaluating better naming next.
This seems a bit like a hack. It looks like you've gotten the handle from ```GearmanJobRequest.handle``` and want to check on the status, but for some reason you don't have the ```GearmanJobRequest``` anymore. 

My main objection here is the 1 connection limitation. I think you should try and rewrite this to poll all the connections, but maybe it'd be better if you kept track of the ```GearmanJobRequest``` objects, unless you have some external requirement to not store python objects, but only handles ?
I tried to keep it like [DboSource#L1044](https://github.com/cakephp/cakephp/blob/master/lib/Cake/Model/Datasource/DboSource.php#L1044)
Move all comments to above logic, everywhere
It didn't start again from scratch. Also, this will be wrapped onto one line if you don't put another new line in there.
Delete this line and the next line
From the [redis documentation for keys](http://redis.io/commands/keys):
> Warning: consider KEYS as a command that should only be used in production environments with extreme care. It may ruin performance when it is executed against large databases. This command is intended for debugging and special operations, such as changing your keyspace layout. Don't use KEYS in your regular application code. If you're looking for a way to find keys in a subset of your keyspace, consider using sets.

This is also unrelated to the purpose of the pull request.  A pull request should focus on fixing one thing to make it easier to get merged.
might this run endless, in case the minutes/seconds/milisecs of the date do not match?
great job on making tests work for 1.3 *and* 1.4, you rock!
Hm, so the only existing code which makes use of this method is: `print 'Downloading build: %s' % (urllib.unquote(self.final_url))`. I  don't think we can get around it. So it should be fine to leave it in for now. But if you have an idea...
Actually, I stand corrected, MessageComplete is *not* called back regardless.  So it would totally seem possible that a request could be started, disconnected, and thus left in an incomplete state.  You then require the application developer to inplement a timer to handle these cases.

So in this case, we set the failure of the current request, if the message parsing never successfully completes.
I wouldn't be opposed to refactoring this stuff into another function, like `@processPeriod`. If we generate another string of params somewhere, would be nice to not have to copy-and-paste these three lines. Cut it down to two, and add a function below `@processPeriod` called `generateParamsString`. This is nicer, I think:
```
params = @processPeriod date, period
params = @generateParamsString params
@events.url = '/users/' + Gandalf.currentUser.id + '/events?' + params
```
Maybe rename this to `puppetdb-foreground` or something more descriptive of the intent?
Sweet.  We should probably make a card to port some of the other parts of the code over to use it.
There is one general fix through out this file to make it more readable. There are some commented out lines to disable a specific setting which don't match with other lines' indentation. Also use 2-space indentation throughout this file.
There are a couple of methods that are missing jsdoc
I don't think there's a need to keep track of the timestamps (keys) here, as we shouldn't be needing them anymore. They're only used to ensure ordering, the UI shouldn't be using them.
I don't think specifying other parameters than the error would be a good idea. Maybe attach the tenant to the error instead, and document the error appropriately? Whatever is done, it should probably be consistent with how a duplicate alias reacts as well (just above).
Moved it out of the `exists` check.
I used to have `Value` as type parameter with Manifest. It was to return a more specific type, but it was a bit overkill for now.
Add Red Hat, SuSe?
This code was required to dispose of the Win7 integration. Why is it removed?
I think I overengineered this since it is only for the spell check feature at this stage. I'll simplify it a bit.
Это вам зачем?
не вижу проверки того, был ли уже заменяем данный элемент. а так же проверки того, был ли элемент, на который мы хотим изменить уже использован
@Buxxter но опять же, таких требований не было, да. Так что это только в рекомендательных целях
It was removed because git could not recognize the db/data folder I added. I didn't realize that the data folder was being used elsewhere. I might have to rename the folder with the scripts to something else then.
Same as above !
Yep thats cool. Would you like me to do it? Any other changes?
Is it not valid for a Given to assert that a required precondition is present?

The point of this environment variable is to provide the base path for matching the uris to features which in cucumber.js include the full path to the file.

If there is a way for cucumber.js to know where it is installed and so be able to provide this information to make the match without use of an environment variable then all the better and I am open to suggestions.
Continued from a collapsed thread:

```objc
[[[signal1 deliverOn:RACScheduler.backgroundScheduler] sequenceNext:^{
	// blah
	return signal2;
}] subscribeNext:^{
	// blah
}];
```

Any two execution points needing to be synchronized will need to know about each other in some way anyways. Requiring that those two signals both be known in one scope seems reasonable.
We should probably clarify "deleted" vs. "overwritten" (since we make a distinction in the implementation).
Our collapsed discussion around this guy wasn't done yet.

I'm ok with making it work from within any scheduler. I'm not totally sure how that'd work at the moment but if it's really essential I can give it a shot.
Why not name this self.write_file
undeclared variable divider?
stop < 10
What about


def copy(self):

    return cp.copy(self)


On Thu, Dec 6, 2012 at 4:01 PM, Denis-Alexander Engemann <
denis.engemann@gmail.com> wrote:

> I'm somewhat reluctant to suclassing, let's weigh costs and benefits. What
> about simply improving the epochs.copy method in a way that it doesn't copy
> unnecessary stuff?
>
>
> On Thu, Dec 6, 2012 at 3:57 PM, Christian Brodbeck <
> notifications@github.com> wrote:
>
>> In mne/epochs.py:
>>
>> > @@ -463,19 +493,30 @@ def __repr__(self):
>> >      def __getitem__(self, key):
>> >          """Return an Epochs object with a subset of epochs
>> >          """
>> > -        if not self._bad_dropped:
>> > -            warnings.warn("Bad epochs have not been dropped, indexing will be "
>> > -                          "inaccurate. Use drop_bad_epochs() or preload=True")
>> > -
>> > -        epochs = cp.copy(self)  # XXX : should use deepcopy but breaks ...
>> > -        epochs.events = np.atleast_2d(self.events[key])
>> > +        epochs = self.copy()
>>
>> Yes, hence "eventually" :) If you have a NewEpochs class that initializes
>> with data, then the current Epochs could be transformed into a function
>> that create such objects to keep the api backwards compatible (or subclass
>> to make type-checking work as well).
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2335632>.
>>
>>
>
>
If the locale was en_GB or en_US, see if we have a preferred or fully specified name in en since this what concept.get name does too.
What's the point of having the to_i rescue 1 in the conditional? Won't that always return truthy?
默认情况下，nginx按加权轮转的方式将请求分发到各服务器。
That's because the piecewise evaluated to 0, which had a True condition.
Золотое сечение шоле? Няшно!
Picking nits here, but I think it'd be better to declare these separately, so that it's explicit what their keywords are.
What part?!
Since you're only testing this one simple thing, you can make the test input a little simpler.
desc should be wrapped in a __() call.
It's not only that this adds many method calls into a chain, it also violates the encapsulation principle by making the view publicly accessible. That is a bad smell on its own, so this should really be refactored.
Is this bit upstream?
case insensitive added and using \s+ rather than literal space will make the keyword matching more robust.