labofsahil/github-event-dataset-2012 huggingface dataset:
Vladimir, I didn't look at the rest of the commit, it's just this comment that caught my attention. But I think you can copy the way AggregatingNotifyingFutureImpl does it (I don't think you can use AggregatingNotifyingFutureImpl as it is): you know that you will have a future at some point, so as long as the future is null you should behave as if there is a future but it's not done yet.

At the very least, if you can't make it work I think you should make it clear in the javadoc that the executor passed in must not execute tasks in the caller's thread (e.g. a JDK ThreadPoolExecutor with a CallerRunsPolicy would have problems as well).
You get ambiguity between identifiers and string literals.
It's still there for backward compatibility. IMO it should be removed.
Ask @tclem :trollface: 

I do think all the tests could do with a once over. We should just move them all to specta. Ill open an issue.
I'd suggest moving this out of this test and into a separate python file (similar to the python to JS classes that exist)
+1 tearDown is not needed here
Why does this property exist in three places, including main.qml?
space after if and before { to match other code. Also, you use fileToOpen.isNull() below, so you should do the same here.
The payload check is done automatically by WCF, so no need to verify that manually.
Because the "usual" is syslog, and at some point we should move beyond
the 70s and the old fear of too many characters.
Using parens after assignment is unusual.

/pedantic
How about a note explaining why there's a random 1 in here
Can we drop the `else if` here? If not we should drop the `imgSrc = data.picture`.
please always call base constructor in sub-classes
I think the cause and effect are reversed here - if you look in standard 3.0, there's no border styling for `.fieldgroup`, so no need to remove it like in your screenshot. In fact, there's no margin/padding/border styles applied to any `.fieldgroup` at any nesting. Checked your "settings visbility" example in 3.0, looks fine. So even with your updated code snippet my questino remains: Why is this necessary in the first place? :)
Minor point: Please keep whitespace to a single empty line, there's excessive whitespace before and after this definition.
Copy pasta, no problem
Is it possible to define the element type for the array of parameter ``$options`` (using ``array<SomeType>``, or ``SomeType[]``)? I also found this on lines 241, 242, and 346.
Are you sure ``$req`` has the correct type as ``*`` is not a sub-type of ``object<Symfony\Bundle\Fr...equirement\Requirement>``? Please also check line 75.
It's because it's still polished and tested =) forgot to add `[WIP]` tag in title of PR =)
Why is this needed?  that could be a bug
Cool, i missed the original check.
Is it JS or CS?
you left a console.log
let's remove this
yeah, running this test https://github.com/mootools/mootools-core/blob/master/Specs/1.3client/Element/Element.Style.js#L19-36 shows that the result is actually `blur(strength=50)alpha(opacity=40)`.

Technically it's another bug, so should be a separate pull request.. but because it's so tiny, a separate commit would be fine by me too.
here message not messge
messge is not defined.
Indent the `when`s. I like Github's style guide: https://github.com/styleguide/ruby, though this seems to be fairly standard as well: http://en.wikipedia.org/wiki/Switch_statement#Ruby
Main idea is that we do not have too many different ways (patterns) of doing things. So currently we have two ways:
 * list of classes in settings (like middleware, authentication, ... is done)
 * a pool of classes and registration to it (like panels are done)

The last one is useful when you have multiple Python modules/Django apps contributing automatically together. Nothing is done automatically, so that it is clearly visible from the code what is happening. (You see register function in the panels.)

Now, the best thing would be to implement a similar pool for horoscopes. So that some third-party modules could also add themselves. But this is probably overkill here because we will not probably have much of this.

So I am proposing that instead of listing classes in settings, we do this in the module itself, as this is not really something configurable.

Yes, we could do some smart and crazy thing, but this would then leave other developers wondering ... do I have to register this somewhere? Do I have to configure settings. How do I "enable" this thing. How I "disable" if it is just temporary. So ... Do it in a simple manner with a tuple of references to classes.
See, here you are then mixing `cols` and `columns`, where first are really columns, but the second is just number.
Structure imports.
Ok. I got it working.
If you replace the catch (URIException e) { fail(...) }   with a throw RuntimeException("", e);   you'll notice Commons HttpClient is throwing a URI exception apparently before making the call because it seems to want the request to be URI encoded before hand.

java.lang.RuntimeException: org.apache.commons.httpclient.URIException: escaped absolute path not valid
	at org.xwiki.test.webdav.DefaultWebDAVTest.testMakingAttachmentFile(DefaultWebDAVTest.java:275)
	at org.xwiki.test.webdav.DefaultWebDAVTest.testMakingAttachmentsUnsafeChars(DefaultWebDAVTest.java:227)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at junit.framework.TestCase.runTest(TestCase.java:168)
In fact, not needed at all. after the sources are saved, the client exits and the value is lost.
It would be like reseting local variable at the end of function.
One liner: `(prefix+'etc/bash_completion.d').install 'contrib/bash_completion' => 'hg-completion.bash'`
delete this line. :)
you should inject this as a constructor paramter, using `%kernel.root_dir%/../web` for example.
Or use a Time object instead of Date LOL:D
It could be - is this a style or correctness issue?  Can the stored context
become stale while this object is still accessible?  Not sure I totally
understand the rules here.
On Oct 7, 2012 6:20 PM, "Moxie Marlinspike" <notifications@github.com>
wrote:

> In src/org/thoughtcrime/redphone/util/CallLogger.java:
>
> >    }
> >
> > +  public static class CallRecord {
> > +    private final Context context;
> > +    private final Uri uri;
> > +    private final long startTimeMillis;
> > +
> > +    private CallRecord(Context context, Uri callRecordUri) {
> > +      this.context = context;
>
> Shouldn't this be context.getApplicationContext()?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WhisperSystems/RedPhone/pull/19/files#r1781475>.
>
>
> The CacheStore is enabling passivation, which means that the entries which are evicted are stored in the filesystem.

The CacheStore is enabling passivation, which means that the entries which are evicted are stored **on** the filesystem.
Also, I'm fine with making this Rails 3+ only but it's still a valid point with new versions of Rails...
I'm not sure, I started with find_in_batches but opted for this so we can exclude users who don't have the required fields easier.
I guess I forgot to push the update to 'cite_details'.  I just did it.
s/fabrice/Fabrice/
What's the reason for the outer parentheses? Is this ever being generated in statement position?
Where is log coming from?
Should this be something along the line of

from logging import getLogger

logger = getLogger(__name__)
logger.warning(".....necessary.")
Could you fully-qualify the name? I don't think Haddock will find it otherwise.
notation: ndarray, (N, 1) instead of ndarray (N x 1)   or do you just need 1d, i.e. (N, ) ?

standard would be nobs instead of N,
I don't know whether we want to change K_i and G_i to the corresponding neqs_i, ...
Yes, descriptive 2 is the most updated version of descriptive.py in the 
el_desc branch

On 08/14/2012 12:52 PM, Skipper Seabold wrote:
>
> In statsmodels/emplike/elregress.py:
>
> > +Empirical Likelihood Linear Regression Inference
> > +
> > +Included in this script are functions to conduct hypothesis test of linear
> > +regression parameters as well as restrictions.
> > +
> > +
> > +General References
> > +-----------------
> > +
> > +Owen, A.B.(2001). Empirical Likelihood. Chapman and Hall
> > +
> > +"""
> > +import numpy as np
> > +from scipy.stats import chi2
> > +from scipy import optimize
> > +from descriptive2 import _OptFuncts
>
> I'm just going to assume this is similar to the descriptive.OptFuncts 
> in the repo until we have the other changes merged in and you can 
> rebase. You're still going to need to remove the stuff that's in 
> el_desc from git before we merge this, but we can worry about that later.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/statsmodels/statsmodels/pull/406/files#r1374276>.
>
предлагая предлагай
100 char wrap
`baseName` from std.path would be more appropriate here.
Another stylistic point, but I think this would be clearer as
```
if not isinstance(gal_mask_image.view(), galsim.ImageViewI):
```
Thanks, good to note that.
Weird that this wasn't there already
why leave the commented-out line?
Tricky. This restart() behaviour breaks shutdown of the NginxController. For example, the resize-cluster test sometimes left nginx running because there were concurrent calls to stop and reload (the latter because its cluster resize meant its config should change). The stop put the state into SERVICE_UP=false; the reload restarted the server.

But I guess my fix of not allowing reload when !SERVICE_UP was too extreme...
I will find and replace boolean in all files.
You should not call `super` here. You should instead alias in the method from the super class. This is due to the different scoping rules of Java and D. So add:

    alias Control.createString createString;

In the beginning of the class declaration.
Great idea. I'll get on that.
See upcoming note, but we should be able to append to a list, so this would be: `--extension=/path/to/ext1/ext1.xpi --extension=/path/to/ext2/ext2.xpi`
For HTML5 stuff to work.
Esses dois testes (nave B e nave C) pode deletar. Aqui um teste ja valida se o metodo com filtro funciona
Not sure that's appropriate in this case. The .logout() call is purely informational to the browser. There still may need to be additional actions that the site needs to take to clear cookies, close files, etc. that would be associated with the "logout" process.
oh right :(
Basically I just reverted the previous regression. If you feel it should be `#sub` instead of `#parameterize`, both works for me as long as my test case passes.
I am not sure what the reason is for that. It came in with a merge. It came with commit 57f46a8103f5f29cfa4fb6314dafa18f118e5d47 as it seems.
You can achieve this by setting a ``context_object_name`` on the class
Doesn't this break the Exodus?
Mmmmm I'm not sure this makes sense.
I think it's clear what using a keyPath means for the API side: when parsing the JSON, you can extract something that is *buried* various levels inside of the dictionary.
When talking about the "local key" I don't see how using a keyPath would make sense.

So I would only offer the posibility to pass a keyPath in the methods that let you use a different string for local and API keys. What do you think?
Почему вектор здесь?
Sorry, I don't understand the logic behind what this method is doing. A couple of questions:
- why is it splitting strings that are length <code>256</code> and above?
- when strings are greater than 255 why is it putting text into <code>first name</code>? This seems out of place for <code>def address():</code> to be doing.
I agree with `input`, and `supports()`
何回もゴメンナサイ

次に基本的な手段は、
↓
次の検索の基本形は、

「検索」という単語は入れたほうがいいかと。
you shouldn't need the  ``1. *`` because of the c-division declaration at the beginning of the module
I tried too with :

import numpy as np

A = np.random.randn(10, 10)
B = A + A.T
A += A.T

print np.max(A - B)

and it indeed seems to work but I am almost sure to have had a bug
like this 2 years ago when we were writing the sparse covariance
estimation with gael. It only works with a recent numpy maybe it's
safer to write "noise = noise + noise.T"
I don't really see why you moved the imports and created such a helper function. It would be simpler and better to have a module-level import.
я прибрав, в мене не працювало, при завантаженны фікстур в БД вносилися не всі поля
Wow.  Maybe we need a couple of fail cases too.
Updated. 
Wiil it work correct if args[0] is StringObject?
not a typo but shouldn't say argparse
if someone dont use standard error and wanna use own 401 page - here he can declare it
I can't say for the rest of EDIF how Unicode-compliant it is - there's still a lot of work and checking to go for that. I tried not to add anything to make it less unicode supportive.
also here the example code is rendered badly because of whitespace.
You have to imagine how it gets rendered: all characters enclosed in <programlisting> are included in the code box.

So you should start with the _double_ word immediately, without any space, and in the subsequent lines add spaces only if you want to indent the code _more_ than the initial block.

Also, try to indent as less as possible (so keeping the code simple) as the page with in which the code blocks are inserted are quite narrow, especially when the documentation is rendered on PDF it looks terrible.
memmove is safe on overlapping ranges
This must always return an object.  Any reason is was changed from a reference to a pointer?
I suspect this needs more work - but requires us to define the serialized dictionary format first.
why is this added only here?

shouldn’t all the methods have a verbose option?
`./manage.py` is better since the hashbang is likely to have a better opinion about which exact version of python to run.
The migration code keeps a version identifier in the db. When you run db sync, it checks if it has any migration scripts that are newer than the version identifier found in the database. If it does, it goes through with the schema upgrade. These migrations are supposed to be safe. However, the Nova code only knows how to deal with the latest schema. I.e. we don't have any code in Nova supporting older schemas, so once the first node is upgraded and you've run a db sync, you generally need to upgrade everything else.

I guess it's possible that you could experience some data loss if code that expects one db schema is run against an entirely different db schema.

Generally, upgrades are entirely unsupported, as far as i can see. With the current state of OpenStack, upgrades need to be carefully orchestrated across the entire infrastructure. Are there any best practices on how to achieve something like this with Puppet?
As of #794 I'm not sure this should be type preference anymore.
@ralphschindler should this be a shared instance instead?
It surely do make sense! We may take some time to think about `require` in content scripts, as it is very very close to that.
This event emitter API looks like an helper module instanciated by default and automatically exposed in --`self`-- `addon` global.
I don't need your public key
Sounds good. Too many of our pulls have been held due to complexity. I'd like to ship sooner and gauge the response from the Erlang community.
I added a new file so I could run just the site tests. Probably don't need it. Will delete.
@shacker totally but I think this should be OK for the PoC.
It's probably useful to open a separate jira for this.
In all other files, but not "test_thresholding.py", right?
Why not use:

```ruby
def allows_all_values_in_array
  @array.each do |value|
    allows_value_of(@attribute, :inclusion)
  end
end
```
Good Point! I don't have a problem with that.
Could add a nested list here.
This name is pretty general.  Consider calling it something like `enableWebGLDebugging`, and it will come at a significant performance cost since it calls `getError` after every WebGL call.
Yes, define them not on the prototype and pass in `this`.  Fair point about overloading.  Most explicit conventions I can think of seem ugly, though.  Double underscore for internal seems odd, since an internal dealie is less hands-off than a private one, so why more underscores?  We could flip that around I guess, but then we'll have lots of double underscore things.  I heard you love Hungarian notation, so let's just prefix all our non-public stuff with p for private or i for internal, it'll be great!  The problem with the "`_` means private or you better know what you're doing" approach is that the author of the code generally knows what they're doing.  It's the person trying to read it (or change it) later that's in a world of hurt when they don't realize that someone uses the field they're about to rename or refactor-away.  Allowing that kind of uncertainty leads to a tendency to not make those kinds of changes, which leads to code rot.  But then, I can make the same argument about dynamic typing in general, so I should probably just get over it.
有吧，都是ogre::light，而且哪种灯没衰减的属性？
MAKE_SYSTEM_PROP(AnnotationDragStarting, MKAnnotationViewDragStateStarting);
placed outside of any method would be an example
@Raynos is one of *those* JSers ;)
Where is semicolon? ;)
Another goal (besides the quickstarts) is to make an integration test for Hibernate OGM, to run in Jenkins.
GeoDjango can handle reprojection natively and should be easier to handle.
For an example, see https://github.com/lonvia/waymarked-trails-site/blob/master/django/src/routemap/views/routeinfo.py#L209
Duplicate call of with methods for $section and $page were removed
Isn't this already a string?    if not let's cast it to string from inside the class rather than in the test.
As I wrote:
> You can call it *extended static array* if your want.

But you are probably right here, so I *have* to call it *extended multidimensional static array*, not just *multidimensional static array* or change the functionality...

But this pull is for practical needs and in practice when I dealing with *multidimensional* static arrays I always assume there is a zero-dimensional static array or it will lead to unnecessary logic branches and I see no reasons to deal with *non-extended multidimensional static arrays*.

By the way, are you sure you are really right here? Because you are assuming that any *multidimensional static array* has to be *static array*. Is such relationship of these terms stated anywhere?
Honestly, I'd prefer that this just got merged in soon rather then messing with it further. I think that the main reason that it hasn't is that Andrei has been too busy to look at it again. But whether such a change is included or not wouldn't really affect it much, I would think.

I agree that `isRandomAccessRange` should be changed as you suggest, but if you do that before this is merged, I'll have to rebase this pull yet again, so I'd kind of prefer that you didn't make such a change. I may just add it to this pull this evening if it doesn't get merged in first (which I assume it won't be), since I don't think that such a restriction is particularly controversial, and it is related to these changes. But we'll see if I have time or not (or maybe I'll get improbably lucky and this will get merged first).

What I'd _really_ like to see is [issue# 7177](http://d.puremagic.com/issues/show_bug.cgi?id=7177) implemented so that we can just require that `$` work, as we could then increase the restrictions of `hasSlicing` all at once. But that requires convincing a compiler dev to do that, and Kenji didn't seem to think that it was a good idea when it came up in a pull request discussion recently. So, maybe a discussion on that should be brought up in the newsgroup or something.

But there's no reason that I'm aware of to delay this pull request at this point other than Andrei being too busy to look it over again.
Use spaces :space_invader:
ここの条件、通ることあるんですかね?
test_emit d3のケースで通過します。
・replaceが設定されているが、同じkeyに対してのruleで、append_to_tagが設定されていない場合

コメント書いてて気づきましたがコレはapply_ruleのところに書くべきですね・・・
maybe giving this a shot? https://code.google.com/p/filter4osgi/

Am 2012-10-22 17:52, schrieb Andreas Pieber:
>> @@ -232,9 +259,9 @@ private void updateAttributes(String domainType, String connectorType, String id
>>   
>>       protected ConnectorInstanceFactory getConnectorFactory(String domainType, String connectorType) {
>>           Filter connectorFilter = FilterUtils.makeFilter(ConnectorInstanceFactory.class,
>> -            String.format("(&(%s=%s)(%s=%s))",
>> -                Constants.DOMAIN_KEY, domainType,
>> -                Constants.CONNECTOR_KEY, connectorType));
>> +                String.format("(&(%s=%s)(%s=%s))",
> rather not :-) A small labs project?
>
> On Mon, Oct 22, 2012 at 5:49 PM, Christoph Gritschenberger <
> notifications@github.com> wrote:
>
>> In
>> components/services/src/main/java/org/openengsb/core/services/internal/ConnectorRegistrationManager.java:
>>
>>> @@ -232,9 +259,9 @@ private void updateAttributes(String domainType, String connectorType, String id
>>>
>>>       protected ConnectorInstanceFactory getConnectorFactory(String domainType, String connectorType) {
>>>           Filter connectorFilter = FilterUtils.makeFilter(ConnectorInstanceFactory.class,
>>> -            String.format("(&(%s=%s)(%s=%s))",
>>> -                Constants.DOMAIN_KEY, domainType,
>>> -                Constants.CONNECTOR_KEY, connectorType));
>>> +                String.format("(&(%s=%s)(%s=%s))",
>> This sounds like a great idea. So great that I actually doubt we are the
>> only ones needing such a thing
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/openengsb/openengsb-framework/pull/785/files#r1905254>.
>>
>>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-framework/pull/785/files#r1905281
>
5.3.3 now
What happens if $weeks is set to 0?
7c9b856
Why don't we just have a Content CTOR with a byte array as the paramter?
Need a unit tests for this. In particular, should make sure it works gracefully for interesting inputs of `$objectInstance`, as that is input that comes from the user. For example:

* null
* scalar type (string, int, bool)
* array
Why not? It appears to work; the unit and functional tests pass and the STRICT warnings are gone.
On one line please
Hey, it's not my code, I'm just patching it enough so that it builds without breaking it.
I think we can remove this for now
Зачем она тут такая пустая?
у меня на нее аллергия
Good point: yes, they're "intentional" but they're not part of the requirement. Extra whitespace makes for easier reading sometimes.  I'll remove them and see how it looks.
Can just be `.hide()`
Because it behaves differently in the main function. In `runAll()` it looks like this:

    if (runModuleUnitTests())
        tryExec(&runMain);

    else
        result = EXIT_FAILURE;

In the `runAll()` function I need to know if the unit tests run successfully. How can I transfer that information from `rt_ini()`?
callback function for sort block
I think you are missing my point; we CANNOT hard-code an Executor - regardless of whether exposing an attribute might be considered an improvement.
Actually i just realized I don;t need to add any tests since they are all there
Look at GatewayWithPayloadExpressionTests.gatewayWithMapThatIsNotHeaders
Again, not your change but since this is not a reference to the entity, lets remove the line "The reference to the JPA Persistence Entity"
and change this to "The fully qualified name of the entity class".
no problem, ill do that in the next PR
This cast leads me to believe that checkstyle hasn't been run, since our checkstyle rules state that
there should be no space after the ending parenthesis of a cast. Please run the checkstyle:checkstyle target.
Can you fix the alignment here. Also, we don't need all these fields.

Can you try to match the field return up to other fields? Return separate names if you can, ignore follows and things, and make sure `profile_picture` is the right key.
why is it being removed
Should be a ctor param
Just to signify that it's the parentName of the function... so it stands for 'function'  I guess.  I didn't know the convention to name local function variables, so if there is some other name I should be using I'm open to it =)
`this->BgObjects[BG_WS_OBJECT_A_FLAG] == target_obj->GetGUID())`

Do we use that `this` on cases like this one?

I'm just asking, I know nothing about the use of `this` on TC codestyle.
Since the corresponding property isn't settable, I don't think it's necessary to be able to pass the image map to the constructor, either.
Types with a `GetEnumerator` method should implement `IEnumerable<T>` and the return type should be `IEnumerator<T>`.
Ben justement je pensais l'avoir trouvé, je croyais que c'était avec l'option `git config --global core.autocrlf false`. Mais du fait que ça n'a rien changé du tout, je pense c'est pas ça...
NO! 2.6 :)
Maybe something like this would work:
<pre><code>
    expected_args = [ \
            'client', 'status', 'name', 'flavor', 'account_id',
            'created_at', 'databases', 'users', 'volume_size'
        ]

    def __init__(self, **kwargs):
        with Check() as check:
            for arg_name in kwargs:
                if arg_name not in self.expected_args:
                    check.fail("Unknown argument: %s" % arg_name)
                setattr(self, arg_name, kwargs[arg_name])
        for arg_name in expected_args:
            if not hasattr(self, arg_name):
                setattr(self, arg_name, None)
</code></pre>

Maybe in the next PR.
Oh man, totally forgot that line
I kept the old code so that if we wanted to reinstate the delay, it would be easier.

When multiple messages are passed simultaneously, yes, they are all displayed simultaneously. The messagewidget handles it fine; I tested it.
GT4O, not GT40?
you don't need this method. Simply do it in ``rawRoute`` (which could be renamed to ``getRoute`` and then use ``getRoute`` in ``generate`` to get the route
Using reflection here is not the best way. Override the constructor, it uses entity manager as an argument. Loading the listener itself, well theres no better way I guess
Best example ever, lol
These return values should specify that `nil` is returned if the image is not available from the cache (and needs to be loaded remotely).
Should it be 'node_vardir' or 'puppetconf_vardir' (or something mentioning puppet) ... its specific to puppet right?
Seems like we would want to provide overloads to each of our plugin methods, too, to allow developers to call the plugins with their own version number designations.
This should throw an InvalidArgumentException if the method doesn't exist.
It is the point of my main comment. When a message is sent, the type is used not the queue. That is why the ``--queue`` option should be renamed to ``--type``.
Only this line was changed. I do not know why git diffed also other lines. I uploaded install_mod.xml to online MOD creator, added author notes and downloaded it. Nothing more.
Please, verify if I am describing it right (I just guess according to code).
the same - I do not like it does not use language file (if it can)
@stof fixed in new commit
Алсо, получаю

Ошибка: TypeError: fn is not a function
Строка: 3388
Suggest we launch ICS viewer card to confirm event details
If we're going with add/remove do we want to keep once?
should be assert(0)