labofsahil/github-event-dataset-2012 huggingface dataset:
Oops, it has gone missing in the last commit (due to placing it in the scripts directory), it will be added in the next commit.
Uppercase S for string.Format
Use the constant in constants for getting the module type ID.
Should be fine, as im not using the innerHTML or innerNodes but copying the entire body Object including its attributes
~~~
Rundeck ジョブの webhook 通知が起動されると、サーバは1つ以上の URL に POST リクエストを送信します。
~~~

→

~~~
Rundeck ジョブの webhook 通知が起動されると、サーバは 1 つ以上の URL に POST リクエストを送信します。
~~~
nesting may be an issue if we have the same var name
Yeah, I had a feeling there was a much better way to do error handling than my makeshift solution. I'll do some research into those other methods.
flash[:notice] = "Video successfully uploaded. #{"Your video will be published after moderation." if current_user.admin? }"
Ha, nice :-)
I think you should assert that you are actually getting back the same connection. You can store the connection in a variable, and then assert equality instead of instance_of.
you should add the parenthesis even if there is no arguments
It isn't done by default. See Qt Creator qbs files!
I don't see how else I can implement this new editor without this inline javascript.
not all trailblocks will have images - first 6 in sport, 5 in culture

next task is to allow this customisation of the trails
aka `common.$g`...
Will fix soon!
Add 
```
<div class="clr"></div>
```
This page also lists a few idioms for handling default options: http://blog.leshill.org/blog/2009/06/10/default-options-with-ruby.html
This should be called `eventName` to be consistent with the other classes.
Please comment why or remove.
Adding a helpers.log message that prints to the browser's console if the console is available.
We aren't trying to shave bytes in the backend code, passing `null` instead of `err` would be clearer.
this query will likely need chunking eventually
We use it across our projects to be sure to not break code due to unwanted type changes. Also wouldn't we save some cpu cycles when no coersing has to happen?
Again, You should read the code more carefully! :)
Or I missed something.

<del>`manageCompatPrefsSetting`</del> `setCompatPrefsHelper` does the following:
__IF__ there is AddonsManager then:
1. do something
2. call `setCompatPrefs`
3. do other stuffs
__ELSE__
1. call `setCompatPrefs`
2. other stuff


Please clarify Your question!
Please readd blank line.
what's the preferred way to test this then? I know some people believe not to test private methods but the complexity here certainly warrants it
I've been writing the tests that use temp files in such a way that they don't remove the temp files if the test fails; that way you can log into the machine and debug.  That's a stylistic preference, though; if you don't feel that's necessary then I don't have a problem with this commit.
Now It is in the right branch
While you can just push to my branch, I don't think it makes sense to target development from here.

I suggest you reimplement it based on development and submit a new PR. Sorry for the trouble.
What I have here and what you suggest are two different things.   Consider a case like this:

``` ruby
class A
  def b
  end
end

describe A do
  specify do
    a = A.new
    a.should_receive(:b).and_call_original
  end
end
```

`a.should_receive(:b)` has the affect of defining a singleton method on `a` to do the mocking.  This method is what your expression above would return (which is not the original method).  In contrast, the expression I have above gets the `b` method as it was defined as an instance  method on `A`, and then it binds it to `a`...which is the original method before `should_receive` defined the singleton method.
Just create this in the class body. Otherwise you need synchronization, which you don't want, nor do you want that test every time. You're never not going to want this object.
'n' is not really needed
If you're not using this, strip it.
Yes, it's a BC break, as anybody implementing the interface on their own will now have code that does not work until they implement the newly added methods.
actually, the above is valid phpdoc notation, and is used to specify a docblock template for all values until a `/**#@-*/` is found.
Sorry I thought that it would be more clear
The same with RuntimeException here.
If this is used in the code anywhere, import it. If not, it's fine. :)
See comment in label.rb
Better than `&nbsp;` would be css usage IMO.
activemq expects it in the format 'macosx' where ohai reports it as 'mac_os_x'
use `self.settings.get(setting, '')` instead of `or`
@vesak Pupessa ei ole tapana pitää kommentoitua koodia. Vois siis mielestäni poistaa.
Left over @param for $request in couple of controllers.
This is the important bit that was missing, causing the bot to spam the channel
Use -v to change the version of the software package, not the toolkit version.

Only provide long option names to avoid confusion between --version and --toolkit-version (?).

Add an option to provide names of patch files (and make sure you don't add the patch file to the list, if it's already there).
mention what versions?
It makes a little magnifying glass icon on the button.
Is there and advantage to using `options.popcorn.media.play()` over `options.popcorn.play()`
Should fire this inside the fetchDuration function, and only when it succeeds, and only let it fire once.

Much easier to only fire once if it is only called from onReady and not inside a getter, as I explain in the next comment.
That's why I am glad that sb who understands it is reviewing the code :-)
Added try + finally (base.shutdown) to the Main.main
No need for colons in any of these heading
based on the test batches i asked the customers to perform, a good improvement here would be to get these settings out of the class, into the php.ini file, with some comment about increasing the values in little steps, since  the results may vary depending on the dfs server(hardware, network latency, whatever). 

and ask them to change values in a kernel file is not nice  :)
Yeah, I am currently not all that sure about how to call this field in Date/DateTime. 

It seems to me a bit verbose. How about calling dayOfMonth simply a date?

Roland

On 25.11.2012, at 11:40, Diego Coronel <notifications@github.com> wrote:

> In source/ceylon/time/base/PeriodBehavior.ceylon:
> 
> > @@ -0,0 +1,78 @@
> > +shared interface PeriodBehavior<Element> given Element satisfies PeriodBehavior<Element>{
> > +
> > +	doc "Returns a copy of this period with the specified amount of years."
> > +	shared formal Element withYears(Integer year);
> > +	
> > +	doc "Returns a copy of this period with the specified amount of months."
> > +	shared formal Element withMonths(Integer month);
> > +	
> > +	doc "Returns a copy of this period with the specified amount of days."
> > +	shared formal Element withDaysOfMonth(Integer daysOfMonth);
> Ooops.. Sry it was because copy and paste from date behavior Em 25/11/2012 05:10, "Roland Tepp" <notifications@github.com> escreveu:
> …
> —
> Reply to this email directly or view it on GitHub.
>
Again, just a confirmation for my own understanding here... we're not trying to coerce a potentially non-numeric query into a numeric one here, right?  That was done on the terminus side and mapped to the operator portion of the query, which we checked earlier... and that's how we ended up in this branch of the multimethod.  Yes?
@simong is the `appid` specified in the URL or is this a parameter that needs to be passed along? If the former, the `appid` could be added in the `endpoint`
I think this is a good candidate to start using a named parameter object for optional parameters. In my ID Management PR, I've done this with `PrincipalsAPI.createUser`. Maybe we can exchange notes and settle on a good format for the method.
I'm not sure why you would be doing this. This will cause the request to go through if no files are provided?
Can we confirm that this now works when no target folder is available? I can't confirm yet myself.
One more thing to consider is that the ``run`` method may terminate while the ``eventActor`` is still processing messages. Is that ok? Maybe this is worth a comment ;-)
These are not subtypes ... 
Perhaps rename to "Maps of named values" or something like that
__Suggestion:__ 

```ruby
self.included(base) do
  base.class_eval do
    def self.create(attrs)
      new(attrs).create
    end
  end
end
```

Just to keep it consistent with other modules that are doing the same?
@dan-nl Rather than doing this you should probably style the margin-top of the h2s instead - this will then make the headings also aligned with the back button/logo.
So

```<?php

$array = array(
    'item'
);

or 

$array = array(
        'item'
    );
У вас hammingDistance возвращает что-нибудь, кроме значения CAPACITY?
Вот тут лучше так не делать. Лучше всего "вытолкнуть" ошибку с помощью `@throw` или NSAssert.
Работать не будет, но пару инструкций все же можно было б сэкономить, или?
Role.find_by_name(:other).build_user
"Arhitekti Laud" is correct.
Sorry for that ! :-/
Because `subscriber` is going to serialize sends anyway? I left the synchronization because without it the zip could possible send error and completed, or next and error, at the same time.
Not having that behavior allows `+currentQueueScheduler` to not depend on `+currentScheduler`, so like `+immediateScheduler` it's safe to call from anywhere, but **unlike** `+immediateScheduler` scheduling recursively on it won't overflow the stack.

It could behave that way if it detected a `+currentScheduler`, and fall back if it didn't, but that would complicate both the implementation and the semantics.
This is another comment on that line
`metashare.db` doesn’t exist, so this command fails. Perhaps you have accidentally not committed the file as `*.db` is on `.gitignore`?

Aside from this, it would be nice, if the database would be generated automatically as it frequently changes. It could be generated for the first node semi-automatically on `./mserv.sh start` and then be copied to all other nodes.
@mluessi can you confirm that you agree?
Moved to requestDaemonToken which is called by refreshApplicationContext. It guarantees that the token will be passed before ModuleActivator.contextRefreshed and ModuleActivator.started.
Not sure if there are other consumers, but would things be easier if `parse_file` returned nil if given nil?
Please not that `null` is the default value for the `$default` argument.
“在<link doc="ngx_core_module.xml" id="user"/><link doc="ngx_core_module.xml" id="user"/>用<link doc="ngx_core_module.xml" id="user"/>”
有两个user，其中一个user错了
OK, so let's reduce what it does.

In fact, now that I think about it, why do people have custom interpolations? Is there a default we can use that people will just go with, unchanged---perhaps per storage backend?
on a related note, API docs talk about `Lata` not `InLata`
Here the message should be given to ValueError, rather than in the warning.
indent this line and the following 5 lines
Ты уверен, что оно здесь нужно?
Поэтому имеет смысл делать `reply->deleteLater ()` вот прям здесь.
This is the target file which is used by MSBuild and Visual Studio to run NuGet.exe to update referenced assemblies. I think you can leave it if ripple is able to download references.
I suggest making it just one function

```(defn remove-package [name {:keys [packages package-groups]}] ... )```
If there is only 'normal' and 'minimal' intended, then a boolean is simpler. i.e.
```php
function loadMemberData($users, $is_name = false, $minimal = false)
```
If you're validating the presence of "Company", it might make sense to move it out of the template.
please cast with `(Boolean) `
Doh! Of course you are right.
Right. Forgot to set the formatting after changing to Juno
"All caches" is more suitable. I'll edit it.
I haven't checked yet, but the XML parser should be able to handle all values and throw errors accordingly...
We should first check that `repo` is not `nil`.
Just noticed this.  This changes the API of this class.  Backends are used by other projects and are not considered to be internal-only, IMO.  It would be better to put image_dpi at the end of the call signature with a None (or whatever default value that makes sense).
Wow.  This is serious voodoo.  Well written, well commented and no complaints about the code -- just impressed by what's involved to get text metrics.
Your parameter is named *theta* instead of *rad*.
I'm not a fan of the inconsistency of some colormaps being available this way and others not.  On the other hand, I don't know if we want to pollute the pyplot namespace further by adding more colormaps there.  It might be nice to have something like:

```
colormap('hot')
```

work.  What do others think?
With the change below, it looks like set_label accepts virtually any python object!  So, perhaps change the docstring to reflect that?
It means that there is none Prefix already found (it's Option[Prefix])
`:as` is used only in `:require`like in `client.clj`.
Can you please move this back? It's not used here at all, other than a TODO for an unrelated feature that *if* we implement, we can do where it belongs. Splitting pieces across files makes the code hard to understand.

The comment explaining why a timer is necessary was lost in the process, too.
I'm in agreement here. The isValid() or isAvailable() are much closer to what I'd expect from the proposal. @tedivm can you please update your PR to make this a true check rather than a false check?
Don't override this base-level element.  Let the webapp styles handle it.
Fixed in 265b716
Dumb Q: what are the cases under which thread_name can be nil, now that we have released 4.1?
widgetData.canManage
Can we bring back the old switch view icons? I think some of Sam's old photoshop files specify a third icon as well.
if this is creating a diagonal matrix please use CMath::create_diagonal_matrix
ok, I will fix it
One goal of this refactor is to make friendlycode an embeddable widget that can be instantiated multiple times in a page if needed, and IDs must be globally unique within a page. Aside from that, though, a number of best practices and tools like [CSSLint](http://csslint.net/) discourage the use of IDs unless absolutely necessary.
Can you rename this module `Transloadit::RSpec` in order to keep the module name and filename in sync?
I think a better name should be found to avoid the confusion with ``Application#before``
You shouldn't need to overwrite this as the default API definition should be sufficient
Larger than normal diff here is because of bad indentation.
Sorry, but i don't see it done
This shouldn't be changed to all platforms, size property is the output property once the control is layed out, while height and width are the input properties.
note to self: don't forget to test for institutional author export,
currently broken:
http://forums.zotero.org/discussion/26847/brace-mistake-by-exporting-to-bibtex/#Comment_141968


On Fri, Dec 14, 2012 at 8:06 PM, Aurimas Vinckevicius <
notifications@github.com> wrote:

> In BibTeX.js:
>
> >  			}
> >  		} else if (field != "pages") {
> > -			value = value.replace(/[^\s-\}\(\[]+[A-Z][^\s,]*/g, "{$0}");
> > +			value = value.replace(/[^\s-\}\(\[]+[A-Z][^\s,]*/g, "{$&}");
>
> Any clue what this is for?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/adam3smith/translators/pull/4/files#r2427898>.
>
>



-- 
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
Actually, at the moment, not possible to reduce down to a single request. The existing Work Market API doesn't support a batch payload, and commit messages identify specific entities that they need to be attached to.

Current usage is purely for internal tests at the moment. Is this something you're completely against or think it could fly with low volume?
enums are fields for annotation purposes.  not intuitive but gets the job done.
Resolve a naming conflict under GCC 4.6.x stricter scoping rules.
Ok. It's certainly not something I very insensitive about. My main concern (besides doing too much in a method) is that this will fall flat when there's more than one directory to be created (i.e. the path passed is /var/www/images/collection/thumbs but the folder /var/www/images/collection doesn't exist)
typo in the variable name
If you just include the "`#`", you don't have to add it again below. Not sure if matching it and getting a certain group is faster/better practice, but I don't really care about that :-)
Doc in CHANGELOG
`buildCommentURL`

Add TODO that this should not be hard-coded like this. We should retrieve this from Django (similar to how other `URLS` entries are done).
i dont understand which lines should i move to the left?
Checking for `None` value should be always done with `is`:

```
if value is not None:
```

Anyway, wouldn't it be better to test this in `limit_date` function? If `value` is `None` it returns immediately?
No need to do it like this. You just go over all horoscope providers and if you get out of the loop (you have not found any), you just raise the exception.
Is this ok? 

language = mongoengine.StringField(choices=settings.LANGUAGES)
No inline JavaScript. Move this to external JS file.
I'd prefer the map version, it's more generic and if somebody needs the package version values in the future we do not have to add a new key and duplicate the list in a different data structure.
Is there a way that we can determine the selected screen from the radiobuttons? RadioButton's `Group` property might be needed, but that way you don't have to select the screen via the listbox first (since the radiobutton does NOT trigger listbox selection)
Please  document
Must be changed back to Apc, or include options for FilePath. This is a broken example.
Can get rid of this too if we just use the PayFlowLink notifcation class.
Dammit, wrong PR!
Same here, extract the common behavior to a common `Collection` class. See https://github.com/codegram/hyperclient/blob/uri_templates/lib/hyperclient/collection.rb for an example
Shouldn't this be
```php
$this->em->persist($setting);
$this->em->flush();
```
instead?
păi e mai scurt să zici direct ``url_for('printouts.home')``, macro-ul ``_url`` era doar ca să fie template-ul mai citibil.
I would create an abstract class GroupMeasures with the two different implementations:
* EventSourceKey(GroupMeasures)
* HierarchicalClustering(GroupMeasures)

In giving names to classes try to consider also the package/module name, as a guideline I suggest to have a look here:
http://sourcemaking.com/implementation-patterns/simple-superclass-name
http://sourcemaking.com/implementation-patterns/qualified-subclass-name
Could you add some comments about this `endsWith` operation? Looks like tricky :)
'map' name may be problematic. e.g. following line results in an error : 
```a = load 'a.txt' as (map : [chararray]);```
Add a docstring, also ;)
The resourceinfo could copy `error_in_current_response` over, so it would use the same condition.
Nitpicking, but no `;`after the `return` ?
Okay, I misread the !IsFloating(), that's for this widget not the container. So why don't floating widgets need to it?
good point! I think I was just trying to be careful at first. I'll do a few tests and update the code accordingly.
add def imse with NotImplementedError ?
I'm going to do that. There is even pending [test](https://github.com/twitter/twitter-cldr-rb/pull/33/files#L3R37) for that. I'm trying to move forward with TDD approach and as there were no test for that at the moment, I used default locale directly. Otherwise, do you like the implementation? I'll add days and quarters and seems like that's it for calendars.
Yeah I know. I thought it may be a good idea to get this param from some kind of config and pass it to the `writeZeroTerminatedString` method. Just ignore it if you wish.
This raise an error for me: ```__init__() takes exactly 2 arguments (3 given)``` did you change the Console __init__. I just checked and the version I just got from apt has only the proxymodel argument.
In my opinion, what the loader is doing here is clearly wrong and broken. It makes no sense to walk the list of base classes and re-add tests that the child class explicitly said it doesn't want. It is a no-op in the vast majority of cases, but makes the code more confusing through superflous use of __bases__ and recursion which is immediately scary. The only case in which the code actually has an effect is when it does something you don't want by re-adding tests that were explicitly filtered out for a subclass. In this case, that affects the attr plugin, but it could cause the same problem for any plugin that wants to filter out certain tests.

Nose's test coverage is good (especially around the attr plugin, where I added functional tests covering all the cases I could come up with when I fixed all the other issues with the plugin) and the fact that this change doesn't affect any tests makes me more confident it is the right thing to do.
add a test for this to make sure a user with one of the privileges has access. e.g. make sure a user with the second permission in the list can still access the resource.
why not isTargeted |= isTargeted(targets);
under-construction.gif
All the `_GenerateFrom` functions either return False or propagate something from a lower level (as this one does).  The only thing that returns True is the simple value (the first two branches in `ParseValue`).
Done.  I reworded this in a way that I think should be clearer.
It prevents from subclassing. This class was not designed for it, so it should not be allowed.

If there is some use case for extending it, we can always remove the final tag.

Perhaps a better question is: are we defensive programming against concurrency issues or not?
Should the SetFromFlag be defined in AmqpServer? Then don't have to re-declare the field here?
Same as above. The code was in os_custom.c.
I may haven't correctly understood that code.
Hmm, I though I converted all line endings. I should be Unix line endings. But regardless of line endings, there shouldn't be any extra blank lines. Is it just on github it looks like this?
Ah OK cool, just wanted to make sure it wasn't a typo.
Don't think Django's i18n works like this.  You need to use named placeholders::

    return _(u'Notification for %(user)s - %(email)s) % (self.user or _('anonymous'), self.email)

See https://docs.djangoproject.com/en/dev/topics/i18n/translation/
Super nitpick: one is plural one is not :)
The choice of the mail command to use is intended to be left in the configuration file. Setting it to `mail` in the conf file don't do the job with FreeBSD? Do you encounter errors due to the end of the command called by the script (namely `-- -f ${EMAIL_FROM}`).

Just wondering if there is a way to keep the possibility for the user to choose which mail sender to use even with FreeBSD, and more generally minimize the use of OS distinction with "uname".
Well, I’m not sure either, though it does make the wifi-scan icon more visible…
the comment should be removed.
Ah, that is just a warning actually, the real error was because this tries to invoke the actual call to conductor, and I did not have conductor running.  Trying again with that on....
I kind of feel like we should be using Time.zone.now instead of Time.now pretty much everywhere, unless known issues might arise.
Ah whoops. I see this is within the User class now.
Разделителем слов может быть не только пробел.
If you check ServiceBus API, you will understand why. OAuthRestProxy is being used by OAuthFilter which will be plugged into the Jersey pipeline. It is the same design as WrapRestProxy and WrapFilter for service bus.
change in 7th line
I think you should remove this from LoginPage and merge it into Base or some other area. 

This is because I am going to suggest that otuside of this pull we remove LoginPage entirely. There actually is no login page on marketplace so it should be removed (in a separate pull!)
Use single-quoates:
<code>'div.brform.island.swagger.c.devhub-form > a.button.prominent'</code>
could that minor difference be added in /lib/platform in that case
support/env.rb uses RHC_RHLOGIN, this uses RHC_USERNAME.  Different?
delete extra coffeescript file
__docformat__ is no longer needed
You should add LDA and QDA instead of removing SGD.
"where memory is tight" already implies that, I was trying to avoid a tautology.
when I create the documentation the subplot titles are truncated - you can fix that by making the figure one inch wider::

    fig, axes = pl.subplots(2, 2, figsize=(9, 8))

and using tight layout (just before ``pl.show()``)::

    pl.tight_layout()
цю менюшку було б прикольно через KnpMenu зробити. по аналогії з меню в http://frameworksdays.com/event/zend-framework-day-2011
This is in contradiction with CLI convention where extra arguments are simply ignored and it doesn't stop execution.  I think extra args should just be ignored as that's what the expectation is in those cases.
Yeah okay i just stole that from the session() helper. "Retrieve client object of the current session (or null)" would be simple and correct.
No newline added at the end of the file. Please update and resend
`null|object` ?
By "number of spill files" I really meant the "number of occasions rows were written to each spill file".
I am not overly concerned by false negatives. It's okay if hash lookup fails, because hashed to remove element.
The HT will still be acting as a filter for positives

However, I also don't need an exact # to spill, so could spill other, not linearly, so I could as you suggested, spill up to next null or something,  to avoid this situation...

I will take a look
It doesn't matter. Ignore me :)

A more pythonic solution would be to not make it a variable at all. ie.:

```python
return {'crashtrends': formatted, 'total': len(formatted)}
```
This and loop below can be merged into:

```
$i = 0;
$tweets = array();
foreach ($combineData as $tweetData) {
    $tweets[] = $this->createTweet($tweetData);

    ++$i;
    if ($i >= $limit) {
        break;
    }
}
unset($combineData);
TypeError isn't a file not found
please replace your data provider with this one. This will give you the flex to run against any env that has data in the shared data file. 

	@DataProvider(name = "dataDriven.valid.creds")
	public Object[][] dataDrivenValidCreds() throws Exception {
		return TestDriverFactory.getPositiveCreds();
	}
Don't reuse ```form```.
I don't think that ifndef belongs there :-p
missing const &
Why so pessimistic about the versions?
Would be a good idea to report that the user exists and is logged in with report_note
The first question that pops up is what the size of the first layer would be.  Does it contain ``1 - n`` layers where ``n`` is the number of layers in the pyramid?  Is the difference that between downsampled and downsampled + smooth or, like Tony suggests, rather between the original layer and the downsampled (but rescaled)?

We are probably all able to figure out what these functions do, but we have to document them so that even a high-school student can make sense of it.
I don't understand why you need to pass `format` here`, especially as a local. Could you please explain?
Can you put spaces like so: `expect { matcher.matches?(model) }.to_not raise_error`? Also - what about `not_to` instead of `to_not`? It's nitpicky, i know
This doesn't make sense, looks like a copy&paste error from accordion.
Ah ok, that was a bad merge.
Does cronjobs take arguments?
This also isn't precise.  The `update` function doesn't know about a "current" pass; it is told about _all_ passes that will be rendered for that frame (which are just pick and color now).  Only when we call render then there is a "current" pass.
Neither of these will realistically have zero in the denominator.  Actually, I don't think getLevelMaximumGeometricError can even in really crazy circumstances.
Object literals are slow and should be avoided unless necessary.  Since the type is publicly usable because it Is returned by getTextureCoordinates, exposing and documenting it seemed like a good idea.  I can't think of a good reason not to do so, unless I'm missing something, which is entirely possible.
The number four is appearing in a bunch of spots.  There should be an explanation, better yet a "constant".
Yeah. This is the sticky wicket. Transport is not the time we can really make the decision to include only production or non-production; some people want to test after transport, some people might want to use transport to hand off the result to the client for them to make a production build (codesigning and all that). I'm hesitant to say 'all', and allow the detector to not filter when that's passed, but can we even do that? Will a transported project allow for the filtering at a latter time?
Actually ///
I don't think you want to do a substring here.  If you do that, you'll only get the first bytes of an IPV6 address, which may collide with other hosts.  Instead, just replace ":" with empty (or something else).
Why are all progress bars set to the same value? That doesn't seem to make sense.
I would rather make this a c++ header file and define the version there. Than it can also be used in the code and shown to the user.
you may want `Logger#pretty_backtrace` here
couldn't this just be a simple function in driver.js?
Heh, I actually did this first but then I changed it to instanceof since I thought it was vice-versa :)
@va1en0k Вообще, это не столько неймспейсы у жкуери, сколько теги. Потому что повесившись на просто `click` мы всё равно получим `click.foo`. http://api.jquery.com/on/#event-names
duplication.

Make a helper method that returns the right function (either _contains_variable or _contains_keyword )
nitpitck: `to!V2(v1)`
So you failed to document `move` properly and it is already used as *unsafe* and *working everywhere* function.
And you can either create second `safeMove` or make `move` safe, create `unsafeMove` and inform people about breaking change. Personally I dislike breaking changes, so current `move` can be deprecated and both `safeMove` and `unsafeMove` can be created.

I suppose you do understand that you can not just go and remove moving function from *phobos*.
I want to try to build using: default::file:../distribution/snapshots/ as the url at some point.
Print some log output before this warning that this test will fail if migration takes time!
This isn't quite right.

If the first cursor callable takes a year, then the second will return records long after `end`.

I suggest two things:

1. `fetchHelper` should take a timestamp generated by the caller (i.e., wherever the cursor callables are created), and
2. those callables should use queries which have an upper bound, which is that timestamp.

That is:

```
final long sharedEnd = now();
…
// Regular callable…
BrowserContract.FormHistory.FIRST_USED + " >= " + (1000 * timestamp) + " AND " +
BrowserContract.FormHistory.LAST_USED + " <= " + (1000 * sharedEnd);

…
 
fetchHelper(delegate, sharedEnd, callableCursors);
```
shouldnt we use the maven-dependency-plugin to retrieve the weaver instead of using the direct path? this could be non-existing if you do it in the wrong order; if it's not build the error would make more sense
That is very weird..deleted
This is within onload, meaning it will be called after the script so whatever is defined in origin.html is overwritten?
this doesn't feel safe, because the cwd is global and anything could happen in between (including another chdir).
Do we need to modify npm to support targeting a different directory?
I'm not sure I follow fully -- since this is implemented in both JsvTypeSerializer and JsonTypeSerializer, with different values. Or am I missing something?
ActiveSupport overrides Object#blank?, so NullObject#blank? or empty? will actually return false and that will break functionality in the views, where there are lines like:

```erb
<%= render additional_code %>
```

It will think that NullObject is something it can render (ActiveModel like object) and call #to_partial_path searching for partial. So to prevent that I just overridden those methods.
ahh, right.  of course...
Wow, you're right. All the *examples* have Vendor\Package, but the actual "Mandatory" bullet point only says "Vendor."  Good catch!
Are we using 2 or 4 spaces for CSS indentation? The above files use 4, but this is using 2.
minor nit, but since you're already refactoring this so completely, would be nice to excise finishRender from loadAndRenderExercise so that the control flow is even more obvious and less cluttered, then you can proxy `this` back into it along with passing `exerciseName`, `problems` and `userExercise` as arguments. unless there's something i'm missing that makes it critical for it to live in this context.
Oleg, don't hurry up. I may find something else ;-)
And sorry: I'll try to be more verbose
I've just pulled your changes.
Now I see, that has 'updatedDate' is redundant: your are using everywhere (except debog) only 'createdDate'
Or let it be just 'createdDate' or it should be renamed to something more appropriate
can this be left empty?
you fix a bit too much ;) 

here you should have 4 spaces less ...
The following exception is already thrown if the pageId given does not exists:

```
Unable to find the page : id = 4444
404 Not Found - PageNotFoundException
```
rename reportBase to report?
Nice use of the inline `while` here!  Reads very nicely.
These two `it` blocks share the same assumptions; I would put them under one context:

```ruby
context 'time-based passwords' do
  let(:time)   { Time.parse("2012-08-07 11:11:11 AM +0700") }
  let(:secret) { "test" }
  let(:code)   { 472374 }
  before { Time.stub!(:now).and_return(time) }

  specify { GoogleAuthenticatorRails::time_based_password(secret).should == code }
  specify { GoogleAuthenticatorRails::valid?(code, secret).should be_true }
end
```
@apex13 Can we change this to `update`? It makes it more consistent with the other current paths

http://guides.rubyonrails.org/getting_started.html#editing-posts is also a good read
I'm no regexpert, but this seems to work fine. Perhaps someone could review this? I'm wanting to extract the "slides_0" from _s502ba48c99af2_slides_0".
This actually goes back to what I was commenting on re: private methods. For now, I'm going to leave this as is; the reason why is when we drop support for Rails 2.x (which will be for the 3.0 release, coming soon!) I'll be able to use ActiveSupport's `extract_options!`. We can't use `extract_options!` currently because Rails 2.x defined `extract_options!` to check if the last item in the array was a `::Hash` - which means it doesn't work correctly with `ActiveSupport::OrderedHash` (which was another requirement because of Ruby 1.8.7).

I'm not horribly opposed to changing it, but I figured it'd be unnecessary shortly so I didn't change it.
I am. I actually think that this patch is not that usefull currently, and would require more work. Perhaps the way to go is to have 3 options, script, wrapper-script, java invocation. For me, I don't know what the wrapper script is, and when it's used, and I had severe problems using the gradle.bat script on windows in combination with gerrit-plugin.
Could you still remove this class?
This creates a strong reference cycle between this and MSClient classes. One of the properties must be made weak.
Yeah, it's not much different in German either. IMO "no parameters" sounds slightly better. But I admit that this is sort of nitpicking :)
No attribute name here too
should be "event.request" here rather than just "request"?
it seems the JMS bundle does not know the available locales, so i decided to take the cheap way.
could also do 'esc = (lambda x:x) if autoescape else conditional_escape'
Good point Ryan, I will fix this today.  Is there a way to update my
current pull request or do I need to issue a new one?

On Thu, Feb 16, 2012 at 9:17 AM, Ryan Bigg
<reply@reply.github.com>
wrote:
>> @@ -252,7 +252,7 @@ def order_opts(order, payment_method, stage)
>>          credits_total = credits.map {|i| i[:amount] * i[:quantity] }.sum
>>        end
>>
>> -      opts = { #:return_url        => request.protocol + request.host_with_port + "/spree/orders/#{order.number}/checkout/paypal_confirm?payment_method_id=#{payment_method}",
>> +      opts = { #:return_url        => request.protocol + request.host_with_port + "/orders/#{order.number}/checkout/paypal_confirm?payment_method_id=#{payment_method}",
>
> This would break if Spree was mounted at another location, other than root.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/spree/spree_paypal_express/pull/37/files#r457728
why? what is this method about
"this" activity
"this method" sets
"the" current activity
add a comment about what this does (e.g. changes where the webview stores the DB and removes it from iCloud)
Can we just have

```
public ClientsDataDelegate getClientsDelegate() {
  return this.clientsDelegate;
}
```

instead of passing through?
Code analysis in VS IDE with default settings does not complain about single-line properties. It did complain about double closing pattern for streams/readers, which I fixed.
Will chat with you about what we want open by default.
btw, instead of adding an abstract method here, a better solution is to add the method in the FilterInterface
Webworks does not differentiate its whitelisting based on origin. Without introducing logic like that it would be impossible. 

To be honest what this fix does is expose an inconsistency in our implementation. You'll note the unit test that goes with it has an identical test above, simply without a local uri in its accesslist (which never happens in real life. I simply made the behaviour consistent in both cases.
In switch cases 2 and 3, result is not defined.
Tehtävä piti tehdä vain yhdellä vertailulla. Pitää siis tehdä jotain tämmöstä:
~~~clojure
(<= jotain kamaa tänne näin)
~~~
why you need rewrite all templates?, by default it's null, I tried it and works well