labofsahil/github-event-dataset-2012 huggingface dataset:
I hate it when long lines are split, since all modern editors auto-wrap nicely, and it makes the line harder to read for me if it's split.
Does it make sense to fire global events on a sync operation, public or not? Since it's a sync operation, the user has the xhr returned to them and can examine the success/failure. The ajaxStart/Stop aren't useful in this case for maintaining an activity indicator on the screen.
I doubt it's the same when there's an error, but I may be wrong.
Lerne**n** Sie einige Tipps ...?
Comma goes before "or", not after.
It is better to use COALESCE() to avoid unexpected NULL element in the array, unless you're sure classify.value never be NULL.

Also, IIRC array_agg is not supported in GPDB 4.0.  You may need to wrap it with m4 macro, or you have to disable bayes module entirely in GPDB 4.0.  If latter, take a look at src/ports/greenplum/4.0/config/Modules.yml.  In any case, you'd better to run install-check in GPDB 4.0.
I assume this is a typo, grp_textfex?
Last but not least, make ./meteor work on Windows... :)
Okay. i now just left the Minions needed for the Heroskills.
no changes to PowerContext.cs
This change ended up requiring some rather far reaching changes to how the ElasticTestCase works. It should be done, but I don't think this is the right place to do it.
typo `vlue`
I tried this and it fails because `mpicc` was not found. I suggest to try `env :userpaths` such that the executables from homebrew are found. (I have not tested that, though).
changed it in my branch. Tested. Works for me on Lion. Cool stuff, @jacknagel!
The preceding four lines can be better arranged

    line.chomp!

    raise RHC::PermissionDeniedException.new(line) if line =~ /permission denied/i

Also, if RHC:: is not required in this scope, don't use it.
Why? The sender should not get any reply about you get the message
Is the indentation odd on this line?
I translated 'With' to '置換後の文字列'.
https://github.com/shumpei/brackets/commit/1b3f0caa8d0286a6acdf693fd10757a1812f20db

I'm sorry for my mistake and thank you for your robust review!
Should use the constants from KeyEvent here.
Could you reorder so this follows the same pattern as the other unit tests in this file?  Move cursor first, execute command, then init `lines` & `expectedText`, then check result.  Also, note that because we use JSLint we don't strictly keep all vars at the top; so it's unnecessary to declare `expectedText` initialized to "" and then immediately overwrite it with another value -- just move the var statement to where it's initialized for real.
I'm happy to do it that way, though I'll register an opinion that it's always a good idea – especially with lots of developers in the kitchen – to declare your vars at the top of a function/method, both to pre-empt any hoisting issues and to establish expectations.
As is, every mousemove event on the .sidebar will create a new DOMElement instance. Instead, you could move this out of the event handler so it only happens once and reuse the same DOMElement for each resize.

```
function initSidebarListeners() {
  var sidebar_resizer = $("<div/>", {id: "sidebar-resizer}).addClass("sidebarResizer"),
    resizerInstalled = false;

  /* install event handlers on sidebar_resizer ... */
  sidebar_resizer.bind("mouseup", function (e) { ... sidebar_resizer.remove(); resizerInstalled = false; });
  sidebar_resizer.bind("mousedown" ...);

  $(".sidebar").mousemove(function (e) {
     if (!resizerInstalled) {
      /* compute sidebar_diff, append to .main-view, update resizerInstalled=true */
    }
  }
```
I meant explicit and in px (as opposed to percent or em).  The size can change at runtime as long as EditorManager.resizeEditor() is called each time.  Want me to add a comment saying that?
Darnit, sorry about that. Saw you fixed.
Looks like we compute the option each of two ways? If you want to keep this in place, could you hide it inside <REMOVE_FOR_COMBINED>...</REMOVE_FOR_COMBINED>? I imagine this is bad for performance.
FYI, relative imports without a leading . are deprecated since 2.6 and may result in unwanted log output depending on our setup: http://www.python.org/dev/peps/pep-0328/#timeline

I find only one instance of "from models" in the codebase.  Might be better to do 'from .models import *' and 'from . import sms'.
I think this is what .FirstOrDefault() does. If there are any, it returns the first, if not, it returns null.
User type an integer, but the core need the precision of a double, the setScaleDenominator take double.
Whenever doesn't load your rails app so `Rails` would never be defined.
If it can be done in one `li` and it works great and it is a standard way and it was also recommended by teacher :), then why not, why complicating with all these nested `ul` for such simple thing? I don't like to use html elements that aren't really necessary.
It is not XHTML valid. Also check in current main repository how to get better `next` value (called `next_url`).
If you're removing the media-view, remove the property for it too
rename to .disable-select
yes - once that project is published on production, i can then publish it myself and include a link.  will need a follow up ticket for that
Same as above. These are useless here and will just give us errors.
i.e. I think you can just stick with `appendChild`
And I love your Gravatar pic.
The test title is incorrect here too. `addTrack returned expected track target` might be better.
This logic won't quite work, since you need to check calledErrorBack when xhr.onerror is triggered not when the code is first trun.  You'll need to add a wrapper function around params.error. e.g.
xhr.onerror = function errorBack() {
  if (!calledErrorBack) {
    calledErrorBack = true;
    params.error();
  }
};
There's some old Cassandra references here that I assume can be safely removed
Remove commented out
Fixed in 	729df15
It depend case by case like for add new element to nil list it is reasonable to have it here.
From my POV reduce is similar case like e.g. sort ( just return list with different order ), so it make sense for me to not have here error message.
@mvidner Can you bring some light here?
You should add a license, otherwise (in most countries) people can't safely use it.
https://parse.com/about/terms
Are you sure about that? Can you give an example?
Yeah, I thiiiiink it just avoids a Clojure var-lookup for `EBIRD-ID`, which would happen for every record without the `^:const` form.
yep this was for demo purposes.
Won't this capture exceptions twice?
I'm pretty sure I fixed #1036 with 4ac48bf79dae6f43123d8c630fda76434a5d4096. Had I known about the issue, I would have closed it. I think you should raise the error at least once before longPolling enters the reconnecting state.
I have taken off the `v` and `V` from the unpack formats. What about `json_is_anynumber`, `json_is_anyinteger` and `json_is_anyreal`? I think we also _should_ take them off in order to keep on consistency in the code.
Would it be worth showing:

    >>> c.ra

and

    >>> c.dec

to show these are ``Angle`` objects?
Perhaps this should be a sub-section (i.e., replace ``-`` with ``^``)?  It seems like it naturally fits in "building and installing"
Sorry :relieved:
CodeSniffer will complain with `Code after RETURN statement cannot be executed`, which is maybe just a CodeSniffer issue but this silences the warning.
What don't you set `actionTarget` to `null` in the `prototype`? That would lead to a safer test. We've done that for the [print plugin](https://github.com/camptocamp/cgxp/blob/master/core/src/script/CGXP/plugins/Print.js#L163).
bunu su sekilde yazsak semantik olarak daha anlasilir olur mu?

```
params = goog.array.filter(this.properties, function(property) {
    return property.propName === 'id';
};

goog.array.forEach(params, function(param) {
    param.parentClassName = tart.string.decapitalize(scope.className);
});
```

ya da daha iyisi; direkt built-in filter ve forEach fonksiyonlarini kullanmak;

```
params = this.properties.filter(function(property) {
    return property.propName === 'id';
}).forEach(function(property) {
    property.parentClassName = tart.string.decapitalize(scope.className);
});
```
this would work if we would split getType and getEntity methods. the $object parameter is optional so that you can get an unbound type. we could change this to getType(string $name) and getEntity($object, $name=null) - would be more obvious and less typing. wdyt? if we do it, we should do it now, we do not want more BC breaks than necessary afterwards.
Upper case should be left for static fields, AND you misspelled guard ;-)
What is "skript"? I can't see it used anywhere.
Minor nitpick: since `groups[0]` is now used multiple times for this dispatch, it might be a good idea to create a local `g0 = groups[0]` and do the whole `if/elif/elif...` dispatch on `g0` instead, to avoid the cost of multiple lookups on the `groups` object...
My logic was so that one could write

%R plot(X,Y)

without getting anything returned. With the default converter,  I don't think this will have an interesting return value. Also, if one writes

%R print(summary(X))

we would see this twice.


In [1]: import rpy2.robjects as ro

In [2]: ro.r('X=rnorm(10);Y=rnorm(10)')
Out[2]: 
<FloatVector - Python:0x16ba8f0 / R:0x1d9ed00>
[1.071279, 0.025186, 0.039147, ..., 1.327266, 1.170248, -1.618695]

In [3]: ro.r('plot(X,Y)')
Out[3]: rpy2.rinterface.NULL

In [4]: ro.r('print(X)')
 [1]  0.3627821 -1.4308813  0.9440119 -0.6366898 -0.2184715 -0.8679497
 [7]  1.7329615 -1.0536063 -0.2401217  1.1920242
Out[4]: 
<FloatVector - Python:0x17309b8 / R:0x1d9eaa0>
[0.362782, -1.430881, 0.944012, ..., -1.053606, -0.240122, 1.192024]


In [6]: ro.r('print(summary(X))')
    Min.  1st Qu.   Median     Mean  3rd Qu.     Max. 
-1.43100 -0.81010 -0.22930 -0.02159  0.79870  1.73300 
Out[6]: 
<FloatVector - Python:0x1730940 / R:0x41d0638>
[-1.431000, -0.810100, -0.229300, -0.021590, 0.798700, 1.733000]
Sorry, my verbosity tends to be inversely proportional to the actual significance of the issue at hand.

I pinged cython-users, and they recommended IPython's own dir.  This could be per-profile, or even top-level IPYTHONDIR/cythonmagic.
Another option would be to special case repr_json to include the *everything* - outputs, pyout/err, stdout/err, execution_count, etc.
Can you move things around? All these loops nested in loops nested in loops with gotos are giving me a headache.

Refactor until the `goto`s are gone, try adding conditionals on the loop header (instead of `while (1)`). You can flush the socket and return from inside the loop.
I removed onComboBoxTouched, onRadioAll, and onRadioSelected as we can just check what layer the user has selected when we go to process.
Hm. Right.
The normal pattern here is:

result = Compiler.Report.ShowMessage (...) AndAlso result

ShowMessage will return False if the message is an error and True otherwise. This pattern works for both warnings and errors (have in mind that warnings may be turned into errors by /warnaserror, so when you're showing a warning you don't know if it'll actually be a warning or an error).

The AndAlso part is only required for warnings (otherwise you may turn a false result into a true one), but for consistency I've been using it everywhere.
billboard? why/where is this used?
definitely!
I'm going to move in the other branch (and remove from here)
The content type here should be ``application/json`` (read http://stackoverflow.com/questions/477816/the-right-json-content-type ).
This type doesn't seem to be used anywhere...
It is a better practice to use `src="//html5shim.googlecode.com/svn/trunk/html5.js"` to be compatible with https
entities should not reference logic
Incidental change. When I was first implementing this I was initially considering putting all the health data retrieval in this object, before deciding on stand alone objects for the health.

I'll revert this back.
And for the record, you cannot say that we don't have complicated plural messages in the core validators, as any message needing plural is complicated in some languages (a message is never complex by itself, but the translation for some languages are complex).
``callable`` should have a lowercase ``c``
The return value of a method should be consistent. Otherwise, it makes it really difficult to use it. Creating a crappy interface is a bad idea.
I renamed it back to $resource to avoid further confusion.
This was a constant-time algorithm before while after this patch it is not anymore. I'm not if this could be exploited somehow.
let's keep this commented out for the time being— i do'nt want to publish artifacts just yet.
I think I'm going to keep this as the magic string, only because the content contains very relevant and clear information on the state.

I'd also be wary of removing `null: false` validation, but that could just be paranoia.
да, да имено в это цель рефактора
argc/argv aren't command line arguments here, they're arguments to the action.  argv[0] should be "--over".
Can this be ```os.path``` instead?
I think this whole file needs looking at again. I'm not convinced it is all necessary (and its not even using the imagetesting decorator).
This makes a good argument for adding a `should have discarded their hand` step, or similar. Not that important, though.
yeah, I know, it's better for debugging the app, but less clearer for reading the code :)
I am not sure about this line.... i think an ordering is needed here. If you want the same order as you inserted it in the test try: order_by('tree_id', 'lft')
Shouldn't this execute appropriate property setter and set the instance value?
Fixed up the ifs here too.
I'd suggest capitalizing the beginning of these sentences.
Use `<span></span>` for non-empty elements.
Shouldn't it be safe to always access `within.offset.top`?
Sure, but then everything would require tab indentation, even non-js files. You still want me to do the change?
делай как считаешь лучше, я тогда нового патча жду
I thought that transformations should work faster but they are not - I achieve about 8 with transform and ~15fps with margin, what is still awful.
thanks, I really appreciate your comments and will be addressing them tonight and tomorrow morning.
`DaysOfWeek` will be a reference of `DAYSOFWEEK_DEFOBJ` object, not a copy of it. Is this intentional?
The exact same code about the |request| with just the difference in the error message exists in set/setSnoozeAlarm. Create an helper function instead of duplicating this code.
I didn't know that was possible. I'll try that soon.
Do you intend to load it all the time? If no you may want to set the src only when it is needed.
You don't need the disposition for the moment.
nit: only one 't'
I believe the functionality you are trying to achieve here is built-in to mozL10n library. You should use that instead.
I just feel its readable for me. I'll revise it.
and then `if (this._lastKeyPressed && this._lastKeyPressed == key)`
`git svn init` produces an error when both `--rewrite-root` and `--no-metadata` are specified
Just to be clear - the timestamp added is the time of export ... but if it already exists as a key then we use the existing value ?
I don't get this ...
Not sure this applies
I don't think it should be global.
I was too lazy to setup the MySQL. You can remove it if you wish. :grin:
Random nerdy ideas:
```scala
for {
  i <- 1 to n
  p = future(processor(i))
} p onComplete (_ => doneLatch.countDown())
```
You could probably use the same thing here as I mentioned above in `build_node`.
This sounds more generic than it really is. Is this not just for abstracting out a bunch of methods on Grouped and CoGrouped?
Can you rename resultNotOk to isUnsatisfiable or something? The issue is that resultNotOk sounds like !resultOk, which it is not really the meaning.
This might be a bit pedantic, but you could you also add a test for the implicit, i.e., call join on the list directly?
same nagging logging comment as above
@Zidane it doesn't really matter, Proxy extends Server anyhow.
Do we still need to handle queues differently?
At this moment Benoît and I do not see any use case where codebase could be used as property. The codebase is configured and not modified from within the step.
md5 is an alias for new and importing md5 avoids the "as".
pTarget == TARGET?

For example, 

bool HelloCocosBuilderLayer::onAssignCCBMemberVariable(CCObject * pTarget, CCString * pMemberVariableName, CCNode * pNode) {
    CCB_MEMBERVARIABLEASSIGNER_GLUE(this, "mBurstSprite", CCSprite *, this->mBurstSprite);
    CCB_MEMBERVARIABLEASSIGNER_GLUE(this, "mTestTitleLabelTTF", CCLabelTTF *, this->mTestTitleLabelTTF);

    return false;
}

pTarget is "this", TARGET's type is CCObject*.
Through they pointer the same object, but their value is different.
When it is passed in as a pointer off CCObject, its value is adjusted.
It is LSP violation. Every instance of DumperInterface should return array or every should return void.

As DumperInterace client how would I know is result available or not? Instanceof check?
For my defense though, escaping the backslash would make it a bit more clear what the intent is. I realize php doesn't treat this as an escaped *, but it looks like one. I fixed this while merging though. Thanks again.
I agree, this is just noise and a pain to maintain.
also, maybe you want to use active model to do real validations™
モデルまたはモデルのリストをセットから取り除く。silentを指定すれば
Might be worth adding an example that does that then to avoid confusion.
For whatever reason, it doesn't well without these two lines of code :\
Fixed locally: just `return;`
You don't really need the 'release' property any more, you can simply set the package.filename appropriately as properties are immutable.
`enum_for(:each_line)` should give the behavior we want on 1.8.5 of returning an Enumerator. You may need to `require 'enumerator'` first.
forgot to backport the comment associated with this

i've now pushed that up.
The `_yz_vtag` field is not needed here.  No?
Yes. These driver changes were a failed experiment. I didn't mean to check them in.
I agree. It's an unnecessary check - although it makes sure it only ever returns true or false and not somethings else (like a Ripple::Document).
I did it this way so that all the dependency errors can be displayed before exiting. Is that a reasonable thing to do?
please follow our code style
indentation is all funky here
there was some reason this didn't work, but I can't remember why now. Might have been rendered not important after Liat's redesign. Will check in on this.
Per previous note, and conversation in IRC, add the label-oriented accessors and mutators to this interface as well.
Add whitespace around the else keyword, please.
IIRC there is a config file for cs-fixer with the possibility to add a whitelist
Typehinting?
"showTitle" does not really make any sense in a remark - we should drop it completely.
Put this after the `public EnumBedResult a(int, int, int, boolean)` and drop the 1-line comment
I ALSO HACKED THE FUNCTION CALL. THIS IS SO UGLY.
I think this code could be moved to naming strategy.
Though about that case, but I decided to not consider it. I can add it again though :)
Please keep the spaces. They are part of the Doctrine CS
@lolautruche Yeah, I know, he is OCD ;)

Added use statement!
Perhaps we can get the same effect by only creating the `iframe` once and then using it as a factory for objects that inherit prototypically from a stripped object.
Because this determines the language that they see the app in, so we want to ensure we've got their up-to-date locale data before they view the app.
Through SocialShare, presumably Facebook uses the [full power](http://ogp.me/) of open graph data. For tweeting it seems to use the format: <title> <url> via @<data-tweet-at>. No idea what it does for google+.
url as well
you should also hasOwn the prop on old options.
The only time `_` is used as a prefix is in plugins to note user definable methods that are special
My bad, must've missed it after reverting the commit with broken diff
I think, ideally, this would be a generated link, in the form of invite_requests_path (so it would point to test on the test archive, to beta on beta etc.)

<%= link_to ts("the Request an Invite page"), invite_requests_path %>
sure, fine, i'll add the name
I have no idea, I blame json.dumps

I can remove it by hand but since these are created automagically what would that solve
yes I agree, it's turned off, see line 66 :)
These could look much cleaner and would be easier to maintain if you used relative paths. What I mean is that you can first select the table e.g.:

```
var table = ZU.xpath(doc, '//table[@id="tbDetailInfo_Basic"]/tbody')[0]  //this will cause problems later if the table is not found, but I think that's the kind of error that you want to be informed about anyway
```

and then select select title, series, etc. relative to that table:

```
var title = ZU.xpathText(table, './tr/td/label[@name="Title"]') //though you can probably get by with just './/label[@name="Title"]'
```
This is also less resource intensive (though I can't say that it's very important in this case)
cool thanks - I'll leave that to @aurimasv - I'd still push Koha out
as is, though (unless you see any other problems, of course)

On Tue, Jun 19, 2012 at 11:03 PM, Simon Kornblith
<reply@reply.github.com>
wrote:
>> +             var marcurl = marcURL(url);
>> +             scrape(marcurl);
>> +     }
>> +}
>> +
>> +function scrape(marcurl) {
>> +     Zotero.Utilities.HTTP.doGet(marcurl, function (text) {
>> +             var translator = Zotero.loadTranslator("import");
>> +             translator.setTranslator("a6ee60df-1ddc-4aae-bb25-45e0537be973");
>> +             translator.setString(text);
>> +             translator.setHandler("itemDone", function (obj, item) {
>> +                     //fix the odd MARC quirk that sets editors=contributors
>> +                     if (item.itemType == "book") {
>> +                             for (var i in item.creators) {
>> +                                     if (item.creators[i].creatorType == "author") var t = "author";
>> +                                     if (!t) {
>
> Modifying MARC is fine with me. There is actually a subfield for [700 tags](http://www.loc.gov/marc/bibliographic/bd700.html) for a [relator code](http://www.loc.gov/marc/relators/relaterm.html) ($4) but it doesn't look like edited volumes ever use it.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zotero/translators/pull/391/files#r1015490



-- 
------
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
I realize this will take some code restructuring, but it would be nice if you could write things like:

> In this statement, the hypothesis is "it rains today" and the conclusion is "soccer practice will be cancelled".
>
> Thus, when we take the inverse, the hypothesis becomes "it does not rain today" and the conclusion becomes "soccer practice will not be cancelled".
>
> The inverse of the original statement is, "If it does not rain today, soccer practice will not be cancelled."

(Including the actual answer as the last hint is particularly important.)
This is going to sound dickish, but I assure you it isn't meant to be. 

At one point someone told me that, in-general, I should avoid claiming authorship on code because its a shared project / open source / whatever and we shouldn't need to flex our "I'm the author of such-and-such code" muscles.

Am I off base here or just showing ignorance towards a perfectly good reason to attach authorship to code?
Will check it out.  But as a tip - its a big document, what are you
objecting to?

On Tue, May 15, 2012 at 5:06 AM, Karl Skomski
<reply@reply.github.com>
wrote:
>> +    // special case as some strings seem to cause a seg fault, so return the name
>> +    return scope.Close(title);
>> +    break;
>> +
>> +  case HeapGraphNode::kObject :
>> +    {
>> +      // see if dominator has name system / FunctionTemplate or system / ObjectTemplateInfo we skip this
>> +      const HeapGraphNode* dom = node->GetDominatorNode();
>> +      Handle<String> domName = dom->GetName();       // get the name of the dominator node
>> +      v8::String::AsciiValue dstr(domName);  // get ascii rep of dominator name
>> +      char* dname = *dstr;                   // make it easier to play with
>> +      if ((strcmp(dname , "system / FunctionTemplate") == 0)||
>> +       (strcmp(dname , "system / ObjectTemplateInfo") == 0))
>> +     ok = 0;
>> +      else
>> +     ok = 1;
>
> overall formatting for C++ - please follow this guide http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Skomski/v8-profiler/pull/2/files#r821975



-- 
Seth Copen Goldstein
FlashGroup: Connecting people through intention
412-818-1192
Is there a way to reproduce the weirdness?
t() on view
Minor point: `/[ ].../` is marginally better than `/( ).../` as it doesn't introduce a capturing group. This regular expression could be written `/[ -]/g`.
Comment for what d is
Yeah you're probably right. In the DateTime property the internal values are protected. Evert?
`") use (...) {` > `") use (...) {"`
It's "rewritten" ;)
abc_qwe_hfd_orp_fgt_yup_adl())
Replaced the delimiter by a regular expression.
Rails probably do something with those modules and wraps them in classes. Maybe you could just use a variable from inside the method for now and add a TODO to clean that up. We should do a cleanup round before releasing 0.2.0 anyway. Opinion? I just don't have much time and I am about to leave for a few days...:)
Fair point regarding Internet Explorer, and I take your later point re: not writing the original test. I'm just trying to help make it not flakey at all rather than just a little less. :)
{} please.
@user and @ticketed_user can be nil which makes your validation useless
I think it's better to do

```
* @param  {Object}                 additionalOptions             Additional optional parameters that need to be passed.
* @param  {String}                  additionalOptions. visibility             The user's visibility setting. This can be public, loggedin or private.
* @param  {String}                 additionalOptions. locale             Additional optional parameters that need to be passed.
* @param  {String}                 additionalOptions. timezone            Additional optional parameters that need to be passed.
```
I don't think we want to push it down, because _updateLibraries is invoked when content is updated/created as well, even when there wasn't a change in membership.

Re: not sending out if an error occurred, we don't have sufficient information to tell if an update was actually made (i.e., the Cassandra update may have happened but the updateLibraries may have failed), in which case we should probably just push out the updates to ensure they synchronize with Cassandra.
The order is wrong on this one. Passport should be above oae modules.
Perhaps improve the naming here a little bit. There's a module.exports.telemetry and a Telemetry. The latter is a function, not an object.
This is not an array of rest contexts if you do _.toArray on the first line of the function.
Looks like BBQ is already in. Not sure what this function is doing then.
Breakup sentence - "customize metadata about the web content. The fields can represent anything you like, such as the web content's author or creation date."
Помоему здесь всегда будет сравниватся nil ( или что там в пустом массиве ) с r_number
Плюс нет никакой гарантии что в uniqueIndexes цифры будут уникальными.
Я бы еще сохранил длину цепочки ДНК в приватном свойстве, так как ориентироваться на длину массива везде — не надежно.
Я имею в виду, что например меняя индекс 10 получим новое случайное значение А, а старое значение тоже А. Получаем, что значение не изменилось.
Can you set $title = null as default and remove the first if?
If this fires 4 times and the callbacks don't fire you get a false positive here.
Good catch -- done
Does it make sense to say "public facility" and "private facility"? Also, translations.
`DocumentNotFoundException::documentNotFound()` expects `$identifier` to be castable to a string. If I'm following this closure correctly, it's an array at this point.

Since it may be a simple `_id` (MongoId or scalar), we could cast that value as a string. Otherwise, it may be an object (associative array), in which case JSON encoding is probably best.

Elsewhere, this function is called using the identifier value, so I think we should pass in `$identifer['_id']` here (`_id` can come from a method call for its field name if we don't want to hard-code it). We should also fix `documentNotFound()` to properly print identifier values that may be associative arrays -- I've created #446 for that.
Can you please [add spaces around this block's return type](https://github.com/github/objective-c-conventions#blocks)?
@dahlbyk Sure. As a consumer of the API, I sort of don't care what the backing storage of the properties are. As it stands, I have my own extension methods that do this, but it seems like a no-brainer to have it in the class as part of the API.

Another option is to implement the serialization constructors for the exception type per FX Design Guidelines: http://msdn.microsoft.com/en-us/library/ms229064.aspx
I assume this is just a debug statement from development time. Can you please remove it again? Similarly for some other places in `
metashare/sync/management/commands/synchronize.py`.
Excellent catch. Of course this was added as a test :-P
the only reason why we have minifcation (and commonJS module support enabled) so users who do not want to use requireJS can go back to the old behavior (.min files and commonJS)
`.intern` is just an alias to `.to_sym` so why change away from `.to_sym`?
We can shorten this stuff up with the alternative syntax:

    Add a method call with::

        $definition->addMethodCall($method, $arguments);
I have copied / pasted the TransportChain definition. See the beginning of this page.
Is there a place that you remove this class?
Hi Jerome,

I don't agree with this. 
In http://platform.xwiki.org/xwiki/bin/view/DevGuide/VerticalForms we have also defined standard size values for the inputs, but those values were not heavily adopted. 

Having full width on input has the secondary effect that makes the forms field look consistent, since we have all kinds of values for input size in the platform. This change alone will break the look of our forms and then will also remain the select, textarea sizes.
il est préférable de récupérer le vrai selector, par un $DaoId = $sel->toString (); . le module peut être omis dans un selecteur, et si c'est dans un module différent de celui qui a récupérer le record, que le save est appelé, le dao ne va pas être retrouvé.
所有的`<a>`都用 link_to 吧
There is no problem with the constructor, I wanted to keep separated the built of the Assertion and the date setting. I thought it was easier for readability.
Obviously, I was wrong : I will fix this by using the constructor and remove th setter.
no need - you only need that if you're planning on add your own variables with our namespace to the xml (ie in addition to android:id, you want to add something like quranandroid:pageColor mathalan).
maybe reduce line length
I am inclined toward that direction. But my opinion is biased as this is how things are implemented in pywcsgrid2.
Ah didn't spot that. Will take a closer look.



On Apr 10, 2012, at 12:04, dgradl
<reply@reply.github.com>
wrote:

>> @@ -0,0 +1,13 @@
>> +package cucumber.runtime;
>> +
>> +import gherkin.formatter.model.Tag;
>> +
>> +import java.util.Collection;
>> +
>> +public interface StaticHookDefinition {
>
> Not identical... the execute method does not take a ScenarioResult, because the StaticHook does not run within the context of a Scenario.  The bigger difference also comes in the Java implementation of the StaticHook because it does not need an instance of the StepDef to execute.. it invokes static methods.   At the level of a feature where this is to be executed.. the "worlds" have not been built.     Indeed there is much the same in processing StaticHooks,  but because of when they execute and how they execute I thought it was worth making them a distinct entity.   Maybe I could've overloaded the execute method... but I thought they were distinct enough.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cucumber/cucumber-jvm/pull/293/files#r664745
Hmm... Could we rename Partition to something else?  Technically, a
partition is a division of a set (
http://en.wikipedia.org/wiki/Partition_of_a_set), so a clustering solution
finds a set of partitions.  (Unless it allows soft clustering, in which
case it finds covers).  The current name is pretty confusing in that
regard. :(

On Wed, Sep 19, 2012 at 11:09 PM, Keith Stevens <notifications@github.com>wrote:

> In src/main/java/edu/ucla/sspace/clustering/PairedFScoreComparison.java:
>
> > + * NO REPRESENTATIONS OR WARRANTIES OF MERCHANT- ABILITY OR FITNESS FOR ANY
> > + * PARTICULAR PURPOSE OR THAT THE USE OF THE LICENSED SOFTWARE OR DOCUMENTATION
> > + * WILL NOT INFRINGE ANY THIRD PARTY PATENTS, COPYRIGHTS, TRADEMARKS OR OTHER
> > + * RIGHTS.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program. If not, see <http://www.gnu.org/licenses/>.
> > + */
> > +
> > +package edu.ucla.sspace.clustering;
> > +
> > +
> > +/**
> > + * Computes the Paired F-score value between two clustering solutions.  The
> > + * Paired F-Score is similar to the F-Score except that intead of operating over
> > + * single instances, it considers pairings of instances.
>
> This might be due to the funky naming for Partition. A Partition holds
> groups of data points, which themselves could each be described as separate
> "partitions", In my terminology, a Partition is a way to separate a set of
> datapoints into any number of distinct points. So any Partition comparison
> is comparing the set of data groups within each Partition.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/fozziethebeat/S-Space/pull/19/files#r1647723>.
>
>
I think the DB was added but nothing in RDL ever needed to make use of it.
you know i thought the same thing when i read over this code but was not sure what to say about it.
@galderz,  since you've removed the new method in TestingUtil, I think you should remove these imports as well.
The 5.1.x branch also has some extra imports.
I thought about that but it seems a bit ridiculous when the whole point of the method is to get a thing. The more typical case of wanting to get the tracking branch without caring about success/failure is nicer than the less typical case of wanting to know success/failure but not actually get the tracking branch.
Can you please use `forRefspec:` here, to match the capitalization of the method being tested?
strange, my line comments got applied to the wrong lines.
Added 

"The base colormaps are (with the exception of `spectral`) derived from those of the same name provided with Matlab:"
You need to do a frame switch here - that's why this test is probably failing
Didn't see this quickly on merge. I guess it's a style choice (I'm used to using one word). Might get this in a future cleanup patch.
Is the url from app.src property trustworthy and could we use it implicitly in this wait loop?
правильно. ООП-шно. но hasError не имеет, более, смысла в контексте этих изменений, ибо если err !== null вернуть err иначе вернуть null =)
shouldn't we show the new way instead so not pretend this is an Array?
Please take a look at Actor.lame_shadow in the lua code.
Depending on the argument, a shadow actor is created or destroyed: this shadow actor causes the dumbshadow actor to be added.
With the previous code, this costume then takes precedence, making Guybrush invisible.
So not a hack, but necessary for code to work.
@jsloane Can we use single quotes?
@dooremont Could you remove the English sentences or translate them into French in all of the files?
Basically if the sentence is the same in English as in French, it should also be removed.
Cool, didn't see it in the diff
If trying to stick with JS Doc standards, maybe we should be specific about the type of array? :

`@property {String[]}`

as shown here http://code.google.com/p/jsdoc-toolkit/wiki/TagParam#Parameter_Type_Information
This helps out tools like the jetbrains IDE's
ooh yeah good point, I'll do that.
Oops. Missed a equal sign.
It should be `and not parent == self`.

I'll write some specs and fixed it later today.
$this->stats is initialised as an empty array in the class definition. Because $this->stats is a class property and not a function-local array, I have not checked which other methods mess with $this->stats. So we skip row counting only if it is still empty.

Defining $this->stats = array() in get_stats() would require reviewing which other methods mess with $this->stats.
Are you sure the class "Zend\EventManager\EventManagerAwareInterface" actually exists, or did you maybe forget to add a USE statement?
logger_email should already be the dev's email automatically, this is how Symfony works, please discuss with GB
**This is pseudo-code for incoming commits**
```javascript
    if (!_.isEmpty(dr) && arguments[0].id && model.id === model.cid) {
        model._deferredRequest[1].set({id:arguments[0].id}, {silent:true})
    }
```
Should you report the exception message for all warnings?
Alt should be some translatable string ("Search users" maybe?).
This two comments are not really useful. Now we have really verbose code: `crypto.get_random_string(77)`, it is quite obvious that it is a random string of length 77. ;-)
`userList` != `userlist`
I think also other more drastic CSS features disable button behavior. I do not know for IE but have experience with Safari. There it uses native buttons (you have problems styling) until you really style them in all possible ways (overriding even defaults with same values). Then it switches to your version.

So I am not sure if `position: relative` is really needed, maybe also some other CSS styles would trigger that. Search for Google on how to disable "native form element rendering" and so on in various browsers.

BTW, why are we using sprite image? Why not create our own image? I thought that we are using sprite because we are using official code. But now it seems that we have hard-coded they button, so we can also hard-code the image?
Write out variable names (`coord`).
Put around here all one big try ... except and print any exception you get. Probably it throws an exception and this is why authentication fails.
GET.
But do you change messages on its own? I doubt. I would go for this only if we would have same message in multiple places. But we do not have. (Initially, I thought this is why you are defining a mixin.) Because if do not duplicate code, we also do not duplicate messages as a consequence.
Ehm, boolean is not OK? :-)
One `)` here goes to the end of previous line.
Remove `bundle` here.
Rename to `displayComments`. If I understand, this is what it does?
I already removed that in latest commit :)
Testing the right position on page..
Now I am confused. Do I create multiple forms or extend the registration form ?
Configure other fields read-only.
Same, use `render_to_string`. ;-)
I think just a warning works, and is consistent with what we do for other warnings in the tools (e.g., large Java apps, if scp momentarily fails).
no idea, checked it, it's not a good one... wonder if you can reject this one line/file
NPC casting it (seems dumb, but people DO dumb stuff) -> bang crash.

Add this to Load():

```c++
return GetCaster()->GetTypeId() == TYPEID_PLAYER;
```
I'm referring to the comment

    // Reused from VoldemortDatastoreProvider
s/profil/profiles
Imports must be at the top of the file, one per line.
What's the error? I'm using 1.8.2 on osx and don't have any issues.
Seems like this method would be good to have protected and non-static, so people could override the combination algo.
left over from debugging, ill update the PR in a few
Can you make the class name more generic? It seems odd to pass `Get` options to `Delete`. Perhaps just `DeploymentOptions`?
So is anything using `runScript:` now?
Some words to use:

This might be desirable to check that your image size (i.e. its resolution dk in Fourier space) is large enough to prevent innaccuracy of your image by "folding."  SBProfile may not always guess correctly, especially when multiple profiles of similar size are being convolved.  

On Jun 19, 2012, at 2:48 PM, Rachel Mandelbaum wrote:

>> -
>> -        TODO: describe dx, wmult.
>> -        """
>> -    # Raise an exception here since C++ is picky about the input types
>> +    def draw(self, image=None, dx=0., wmult=1, normalization="flux"):
>> +        """@brief Draws an Image of the object, with bounds optionally set by an input Image.
>> +
>> +        @param image  If provided, this will be the image on which to draw the profile.
>> +                      If image=None, then an automatically-sized image will be created.
>> +                      (Default = None)
>> +        @param dx     If provided, use this as the pixel scale for the image.
>> +                      If dx <= 0. and image != None, then take the provided image's pixel scale.
>> +                      If dx <= 0. and image == None, then use pi/maxK()
>> +                      (Default = 0.)
>> +        @param wmult  A factor by which to make the intermediate images larger than 
>> +                      they are normally made.  (Default = 1.)
> 
> it might be good to give some motivation for why one might want wmult !=1.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/194/files#r1012310
>
Yes, it is possible for programmers to cause trouble by deleting Interpolants while they are still being used (at least in C++ - I don't know the python story).  For the Interval, this is not a problem because no user code will ever access them, in fact the Interval could be made a subclass of OneDimensionalDeviate.  

The motivation is that there is a lot of overhead in using an Interpolant for the first time (calculating its FT, and doing integrals needed for photon shooting).  You would not want to do this afresh every time you have another SBInterpolatedImage.  So I've set it up in a way that requires the coder to keep their Interpolants around long-term and reuse them.  Of course this is open to mis-use.  There are ways around this, such as creating a single static copy of the lookup tables that is shared by every Quintic interpolant ever made.  As Jim suggests, this might be a good thing to address when/if you choose to reassess the permanence of everything in SBProfile.

On May 21, 2012, at 4:17 PM, Rachel Mandelbaum wrote:

>>     class InterpolantXY : public Interpolant2d 
>>     {
>>     public:
>> +        /**
>> +         * @brief Constructor
>> +         *
>> +         * Note that the referenced `Interpolant` is not copied, it must stay in existence.
>> +         * @param[in] i1d_ One-dimensional `Interpolant` to be applied to x and y coordinates.
> 
> Could this "Note that the referenced `Interpolant` is not copied, it must stay in existence" be a problem in practice for realistic code usage?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/156/files#r856119
>
Please add whether this price is monthly/quarterly/yearly ...
Confirmed not a new runtime dependency
`if (!quiet)`
Fair enough. I do think there's merit in having the variable being assigned on the left, so I'm still not totally convinced that `--a` is better.
My issue here is that I wasn't able to save this object because I didn't have legitimate credentials for this. I'd really like the ability to have a stub implementation of this in development. I'll just leave a TODO for now.
Can't use `_.result` here because his implementation allows passing additional arguments (`args`).
If we remove the preprocessor directive (see comment on line 187), we can remove this exception.
Remember to homakov
“Page don't can move to own branch” → “Page can't be moved to its own branch”
pegar todas as exceções é uma má/péssima prática... se levantar um erro de IndexError em row[2], será tratado pelo seu except que levantará o mesmo erro depois..
The append flag does not seem to exist on OS X:

cpio: Option --append is not supported
What does `pp` give you over just typing the variable name?
I will prefer find-dependencies

On Wed, Oct 10, 2012 at 3:43 PM, Felix-Johannes Jendrusch <
notifications@github.com> wrote:

> In node_modules/webinos/README.md:
>
> > @@ -1 +1 @@
> > -webinos module
>
> I'm fine with renaming and moving it to npm, but I'm not sure how to name
> it: path-resolver, dependency-resolver, find-dependencies?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/webinos/Webinos-Platform/pull/197/files#r1807320>.
>
>
What about `peek`?
Couldn't this `jasmine` be replaced with `j`.
See below comment too.
missing spaces around the ``:`` of the ternary operator
I don't know.  Invisible formatting I think.  I deleted a blank line at the end, but I don't know what those -blank line + blank line pairs are.
Readd the occupations 2 var, and do not shuffle the occupations var.  It messes with latejoiners.
Open an issue? Cool, didn't know we could do that. I'll poke around and try to find it.
IMO this assertion as well as comment are useless, because assertion should be done on lexer to verify that "a-" not parsed as identifier.
Should these all be h4's you think? looks a bit odd as just text.
lol, why the original uses a new instance?
А если pattern - null?
Тут лишний dict.get()
А если равен?
Не понял комментарий. По-моему, названия переменных в соответствии с Code Conversion, начинаются со строчной.
В случае ошибки ненулевой код надо возвращать.
This isn't true, infinispan-core and prettyfaces-jsf2 are included. Would be nice to call this out.
s/From/For/ ?
See how it's done with requirements for instance.
Info: Moved this above App create so it can be used for application view too, might we need to.
Bad copy-paste job... will fix it
Except by using  it can be overturned by --with-internal-ffmpeg
The comment here could state what problem this may solve, e.g.

    # To connect to your S3 host region, you may want to set this to avoid a BrokenPipeException
    # e.g. for EU, 's3-eu-west-1.amazonaws.com'
Added short descriptions to all the `_em_X()` functions.
Usually we prefer ``(...)`` to ``\``.
I have a hard time understanding how this bunch of numpy magic works. Isn't there a more explicit / readable way to do this without sacrificing the performance? If not it's ok for me, I will just trust the tests.
I could link to the scikit-learn doc on this or a wikipedia page? Else I'll have a look if I find an article that mentions this
Seems I was wrong. A bit strange, though.
-- 
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.



Gael Varoquaux <notifications@github.com> schrieb:

In sklearn/linear_model/stochastic_gradient.py:

> @@ -449,7 +449,7 @@ def partial_fit(self, X, y, classes=None, > ------- > self : returns an instance of self. > """ > - if class_weight != None: > + if class_weight is not None: 

I am not sure what you mean by your remark, @amueller . 'foo is not None' is the right way to ensure that the test is not triggered only by the 'None' value.

—
Reply to this email directly or view it on GitHub.
Unless this value is calculated by hand (is it?) this test doesn't really check much except that the implementation stayed the same as when you wrote the test.   Also isn't the test below in `test_common`? and if not, shouldn't it be?

Given this, I guess the PR needs more tests.  Maybe some toy examples on which the averages can be computed by hand?
видимо нужно убрать https://github.com/stfalcon-studio/wallpaper/pull/50/files#L6R40
Is it useful to have this setting for each bundle ? IMHO a single setting in the CoreBundle would be sufficient.
Alternatively, the call to `error` that ends up displaying `__error` could be changed to use the original expression instead.  I think most places only check `e->tok`, so only changing `e->type` risks a broken expression slipping though.