labofsahil/github-event-dataset-2012 huggingface dataset:
The `getTextContent` function looks up the `spaceWidth` of the font. This triggers the `get spaceWidth()` getter function, which then makes the `spaceWidth` to become a real property on the font (that's what shadow is doing).

The problem is now if the font gets send to the main thread.

In the `Font` object constructor, we have the code:

```
  function Font(name, file, properties) {
    if (arguments.length === 1) {
      // importing translated data
      var data = arguments[0];
      for (var i in data) {
        this[i] = data[i];
      }
      return;
    }
   [...]
```

As the `spaceWidth` is a real property on the font-data sent from the worker- to the main-thread, the `for (var i in data)` loop will include the `spaceWidth`. But for this font instance, the `spaceWidth` is not shadowed yet. Therefore, it tries to set a value to the getter function `get spaceWidth()`, which is not possible, as there is no setter.

So, to solve this, we can either remove the shadowing OR implement a setter function for `spaceWitdth`. Happy to do the latter (just came up with the idea while writing this comment...).
Do you really need `code`?
Thanks for the advice. I updated the code on commit 85c8fa0.
@kellyredding - oh your documentation explains the callbacks later, not so much an issue
You're right. I've changed all the unless/else/end in database.rb
I moved ```set_initial_status``` to an ```after_initialize callback``` like this:

    after_initialize :set_initial_status

One of the lines of ```set_initial_status``` copies the app name from the app to a app_name field in deployment. Factory Girl throw an error saying that app was a nil object in this line:

   self.app_name = app.name

This error only happend in testing mode. I googled it and it looks like factory girl doesn't like the after_initialize callback: http://stackoverflow.com/questions/5916162/problem-with-factory-girl-association-and-after-initialize
>>> r = urllib3.PoolManager()
    >>> r.headers
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
    AttributeError: 'PoolManager' object has no attribute 'headers'

In fact the code coverage is still 100%. However, I don't think it's a nice fix because parent class should better not know whether any attributes in its inheritance exist.
the method does too much for an implicit. It's ok to call that explicitly until we have a typeclass to handle that
According to comments in struct cred ( http://lxr.linux.no/#linux+v3.2/include/linux/cred.h#L131 )
shouldn't we change every crgetuid with crgetfsuid, as we are always checking for permissions related to filesystem? (same applies for gid).
I mean in the entire ZoL codebase (possibile exception: delegations) not only in this patch.
Does their api have a way to test the credentials in test mode without sending a notification?
I'm on board. But are the various Linux OS's being exposed as a consistent name? We'll also still need a hierarchy of names to express those functions that work on both OS X and Linux.
I didn't realize that UNARCHIVED was really only being used to address the difference between the sync history report and a task status.  After looking at the code for it's usage, it can definitely be removed.  Will remove and test to verify.. but expect a commit with an update soon... :)
I just moved it to the super class. We need it for both promote and delete.
I don't see a spec test for the controller .
I'm not satisfied with the singleton name, either. I originally changed the name to Launcher, then changed it back to WindowManager.  Nothing seems right to me, and I think that is because these are such fundamental parts of the homescreen that trying to break them out into a separately-named module doesn't seem right.
`while (this.checkDayUpdate());`

(nice code pattern!)
I don't understand; can't you just call `disable_warnings_logging` and `disable_exception_logging` in the test to resture the original showwarning and excepthook settings (or, to be safer when people run `test` in an environment when  they've changed the  defaults, only do that if these settings are True)?
Maybe it sees a performance decrease of ~70µs out of 5ms, which would make it unnoticeable?
If SHGetSpecialFolderPathA() fails we HAVE to guess (our fallback) or GetSpecialFolderPath() fails ... there is NO environment variable that points to the autostart folder and MS changed the folder in Vista an higher in comparison to i.e. WinXP.
You are right, providing it per command-line won't change it in the options, but as this is for the GUI client, we can be sure that OptionsModel::Init() was called, which leads to to a consistent state, right?
Ah indeed you are right. My mistake :)
I agree that the textarea class makes sense, my only worry is removing the text class.
The indentation is off for lines 77 through 82 .
Please use `===` instead of `==`
in chains of multiple proxies this code is weird, can you remove get_parent_class() ?
Agreed, I'm just being 'extra friendly' here with errors. It's fine if it stays as-is.
The `"%s"` here looks like I missed something. I think it should just be the constant `HOME`.
I think the rebase didn't go quite right.  This now gets double-fixed, which results in escaped HTML in the notebook output.
This would cause a performance regression.
I wouldn't worry about checking the page size if I were you. Originally this code was just using 4k all the time. The page size query was kind of a "because it's there" type of optimization that is probably not very important. Just using a modest sized constant is fine.

At some point, I'd love to survey ignore and attributes files across a number of GitHub projects and try to tune these allocations for pools to a real world 80% case size. It would just be interesting to know if a single page allocation is typically sufficient for storage of attribute/ignore information or not. Of course, the same code gets used by the diff API and that is clearly going to need to store a lot more data...
If you want to be consistent with const-ness, you should consider to move the casting away the const-ness of the to-duplicate object into `git_object__dup`, even though it is not public API and not really relevant to this topic.
To answer this myself: No, we should not probe it here. Since on Windows it is expected to be set to `false` during git-clone or git-init, @nulltoken already states that this part has been run successfully.
Feels good man.
A mutex for progress is asking The Gods of Computing for extra contention where we don't really need more. This could be refactored to use atomic operations. It's a progress indicator after all...
Hmm, actually:
Transfer-Encoding Header

Starting in Windows Vista and Windows Server 2008, WinHttp enables applications to perform chunked transfer encoding on data sent to the server. When the Transfer-Encoding header is present on the WinHttp request, the dwTotalLength parameter in the call to WinHttpSendRequest is set to WINHTTP_IGNORE_REQUEST_TOTAL_LENGTH and the application sends the entity body in one or more calls to WinHttpWriteData. The lpOptional parameter of WinHttpSendRequest must be NULL and the dwOptionLength parameter must be zero, otherwise an ERROR_WINHTTP_INVALID_PARAMETER error is returned. To terminate the chunked data transfer, the application generates a zero length chunk and sends it in the last call to WinHttpWriteData.

Sounds like this could be trouble for our Windows XP support, unless we buffer the data into a file and then play it back on that platform.
Just like when it comes to the original code, this does not work when the next token starts with an escape sequence (cf. #420).
There is no need to test two whole strings, just the last character of the first one and the first character of the last one.
I know this isn't well documented, but there shouldn't be any hardcoded mozilla.org URLs. Please use the url helper: https://github.com/mozilla/bedrock/blob/master/apps/mozorg/helpers.py#L212

{{ url('collusion') }}

The argument is the name of a view. Usually it's the path with slashes replaced by dots, so /firefox/new is firefox.new.
I changed the ``./manage.py esstatus`` command slightly so that it shows all the indexes you have in your ES. I think this'll make it easier to do development work. In order to do that, I needed the ``all_indexes`` argument.
I didn't notice anything applicable in pep8, happy to go with what you are using elsewhere.
We're still *inside* the LegacyThrottler class aren't we?
has been re-written without the deletes.
yes, if you wanted to use hbase, you'd have to add the 'socorro.external.hbase.HBaseCrashStorage' to the list of storage schemes in use (most likely replacing the file system entry).  Then you'd either make a new include for the HBase connection details OR change the "primary-crash-storage.ini" to reflect HBase settings rather than the file system settings.  However, if you take the latter action, you're telling the collector to write directly to HBase, too.  If that's not the behavior that you want, then I'd suggest doing the former rather than the latter.
perhaps you mean `('update_adu',)` otherwise this will be a string and then `in` won't work as intended.
I could have added that as a note. it first writes the length of the array as a byte and then the actual byte[]
Ah, nevermind. That's Android-specific. Could pull its sources in. Or just allow boxing and use `Integer` in the map.
@bschussek will it be ok with empty collections ?
``if (!extension_loaded('posix')) {``
> Or just drop the defaults...?

yes
btw, why switching from include to render ? there is no real logic in the controller
I've removed the manual query string. For the host, my point was that we don't need it anyway.
what is the point in generating empty URLs? I don't see a use case.
IMO it should rather generate the URL with these invalid parameters because that's what could be useful (you probably don't care it won't match this route).
I agree that `&&` is wrongly placed but should I really revert (vs fix):

> Symfony follows the standards defined in the PSR-0, PSR-1 and PSR-2 documents.

But If you prefer being hard, I'll execute, tell me.

> There MUST NOT be a hard limit on line length; the soft limit MUST be 120 characters; lines SHOULD be 80 characters or less.
Hm I don't think any implementation would need it. The generation will work as before. Custom implemention might only break if they work with the parameter as you did. But then they won't need this conversion. You won't need it either.
The FormConfigInterface::getBefore says, it returns a string only. So null is not expected here.
great addition!
move `^(NSURLRequest *request, NSHTTPURLResponse *response, id JSON) {` on new line and decrease indent of whole block
Why is this in a separate block from the `config.before(type: :request)` above? They run at the same time - I'd combine them.
Indentation off here. New hash syntax preferred.
most plugins end up as unstyled garbage in the admin preview anyway, especially the more involved ones.
Shouldn't this always be `"1.0"`?  The rest of the `tornado.auth` code is pretty much hardwired to handle either version 1.0 or 1.0a, and if we always need to send 1.0 in the 1.0a case, all cases are covered.

This also makes the `_oauth_version_to_send()` method unnecessary.
Non le code HTML ne va pas marcher, supprime le et je vais le mettre dans la page HTML moi-même
Why do you need this? It does not look like it is actually used?
I think we need to put a copy of the license in the LICENSE file.

See http://www.apache.org/dev/release.html#distributing-code-under-several-licenses
This one changes the string without changing the key, please make sure to check for that across this patch. The changes below are harder to read than this one, so I'm not sure if this pops up more often.
nit: use `gHotspotSettingsSection.hidden` instead for code consistency.
ok I'm going to change it, thanks
don't load busytimes, that is on demand by nature and handled by the time controller.

Honestly .load is evil but there are so few accounts/calendars it made sense to load those up front.
In the past (3-4 months ago) we loaded all events/busytimes on load which was crazy slow.
Don't forget to open an issue!
Remove `-moz` prefix on `calc` please
This code does strange things. It listen for a click and the function is named nm_hashchange. And then the block of code target an iframe that does not exists :)
we don’t need this CSS rule, but I did a mistake in the JS part.
Did these get moved down so they're not cleared when `poll.get_next_question()` is called? Should these maybe not be done in `.get_next_question()`? That will require an audit of where get_next_question is called though.
there needs to be a way to express names with underscore, e.g: `write_graphite` is a valid plugin.
typo: "unders" -> "under"
priorVector.getRow( /* whatever index you used */ ).write(Tsv(...)) should work (and return the column.
So why does it matter if it is serializable or not?
like it - changed
looks good, i would move this fn() call to `var html = fn(...` though so you dont have the weird parens there
Well in that case you might also consider removing those cryptic INFO
messages that appear when a deployment resource is processed:

2012-11-19 10:11:24,127 INFO  BpmnParse - XMLSchema currently not supported
as typeLanguage
2012-11-19 10:11:24,130 INFO  BpmnParse - XPath currently not supported as
expressionLanguage


On Mon, Nov 19, 2012 at 10:29 AM, frederikheremans <notifications@github.com
> wrote:

> In
> modules/activiti-engine/src/main/java/org/activiti/engine/impl/bpmn/deployer/BpmnDeployer.java:
>
> > @@ -66,6 +66,8 @@
> >    protected IdGenerator idGenerator;
> >
> >    public void deploy(DeploymentEntity deployment) {
> > +    LOG.info("Processing deployment " + deployment.getName());
>
> We'd like to avoid unnessesairy info-logging
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Activiti/Activiti/pull/3/files#r2164178>.
>
>
NOOOOOOoooOOooOOOOO!
This gets a new array from the string command, so ti doesn't have the variables replaced
Technically, does it scale with ``subpixels**2``? (just curious)
Including some comments on the existing code, not just the refactoring, while we are in here:

Should this be an error, or just a warning and break out of the loop here?
Instead of all these specialized `za_submit_*` functions, which introduce quite a bit of boilerplate code, just use the `za_submit_derive()` directly. E.g.:

```c
za_submit_derive ("mutex_operation", "miss", value);
```
delete me if I dont have anything :)
why do we need the respond to?  shouldnt reshares always respond to root?
I've choosen the first solution because in my opinion multiple files will use more flash. I've tried too add some #ifdef's. Please let me know if this is OK.
@kungpochicken @ahume Do we need to take this up with Sharath? It sounds like we are selling adverts that nobody is looking at.
.el is a reference to the DOM element. .$el is a cached jQuery selector. It is indeed an idiom.

There's no such thing as a private field in JS.
Maybe I misunderstand something but with your proposed change: `resolve('./foo/bar', 'bla/baz.js') -> bla/baz.js/foo/bar` instead of expected `bla/foo/bar`.
`version` doesn't seem to be used.
Maybe we can change `harnessOptions` to `metadata` ?
in fact, I'm rather curious what is actually going on right now for un-authenticated api calls.  req.session.userid would be undefined and we'd be passing that into `db.lastPasswordReset()`
What about these tests?  If they really are not needed, take them out.
Does this leave room for an assertion for a domain labelled as a proxyIDP to come from a source that is neither BigTent, the HOSTNAME or the domainFromEmail?  

Say the ultimateIssuer is ``nefarious.com``` (somebody there created an assertion and passed it to us), the HOSTNAME is ```persona.org``` and the domainFromEmail is ```gmail.com``` - does that mean the assertion is validated?
indexOf returns -1 if a value is not found. The index for this text in IE8 was 0.
Nit: do `function() {` not `function(){` -- especially as the previous and next instance have spaces.
Awesome, thanks! That was better than my suggestion anyways. We'll try to get this merged in soon. :)
It isn't clear why this was done.  Please explain?
Yep, my mistake. I meant to grab the non-nested one.
Do not use `should_not raise_error`. Compute a value and make an assertion on the value. Or compute a side-effect and make an assertion on state somewhere.
Also, I'd rather see the specs not rely on StringIO -- none of the other specs in that file use it.
No, duplicated code sucks. I hope we can remove this file completely in favor of `test_inst_client`.
Populate an object and then JSON.strinify(). Stringbuilding JSON is dirty.
It's an implementation detail of the concrete EventManager instance -- basically to create a convenience for passing values by reference. It should not be in the interface.
Sure, I'll do it
I prefer if you can StorageInterface without alias
Since the effective date is not that important anymore, shouldn't it be moved away from the 'default' schemata or maybe even be hidden?
maybe add newlines for all files in this PR?
No worries, have removed that.
I would check if summarylist exists first, otherwise (if it's not there) you will get an Error when accessing imgThumb of undefined.
@anti t-funkkarit läpi linjan?
This property does not exist in the annotation
HOT I didn't know about this.
can't we use `check_block_arity` for this one aswell?
That is, you are testing for None already, so the `.get()` is redundant.
remove for now, implied by copyright statement
`pass`
It's not only problem of Flickr, it's problem of most resource owner. Maybe you could open an new issue about this, as it's not only related to this PR. Thanks.
the phpdoc is wrong as the default value is an array
Same as above re: inheriting from the kitchensink project
I don't think we want to keep those commented out sections
A shorter version:

```python
try:
    offset = int(self.request_data.get('offset', self.offset))
except ValueError:
    raise BadRequest("Invalid offset '%s' provided. "
                     "Please provide an integer.")
```
This approach was discussed earlier on, but I was under the impression that we agreed against it.
Looks pretty constant. Why reset it here?
It seems like the real fix is to alter the show action to handle documents
that don't exist in the system. We still haven't answered why
this implementation is different from articles.

Todd


On Tue, Nov 20, 2012 at 11:55 AM, Sky Hu <notifications@github.com> wrote:

> In app/views/katas/_kata.html.erb:
>
> > @@ -26,7 +26,7 @@
> >    <br><br>
> >    <% unless kata.source.blank? %>
> >      <div class="entity-source-url">
> > -      <h4><b>Source: </b><%= link_to kata.source.truncate(130),"#{kata.source}", {:target => '_blank'} %></h4>
> > +      <h4><b>Source: </b><%= auto_link(kata.source, :html => { :target => '_blank' }).html_safe %></h4>
> >      </div>
>
> Also, if user puts mixed string in the source field:
>
> "http://www.example.com from Clark Kent"
>
> auto_link can still nicely handle it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/professor/Hibiscus/pull/31/files#r2185859>.
>
>
it looks like you want to use ```merge``` instead of flatten, that is more expensive operation and doesn't make much sense here, as you want add new services to it.
can we edit the other fields ?
I don't think anything has been pulled out.  I've ran truncate_utf8() as a transform on datastream_label so that I don't have to call the function twice.
Is this layouts/org an asset of the master project?  I think we could effortlessly change this to be more generic, whereby you can include an interstitial piece of content that the master project defines without interlocking it to specifically the concept of an organization chooser.
I agree that we shouldn't be changing from our established color schemes but that doesn't mean the option shouldn't exist.  Nothing irks me more than when I go to use an open source project and need to configure it but the option to configure elements is not present.
also, this could be renamed, i'm not married to that, it was just the most convenient name at the time.
Pink seems a bit... bright here. Perhaps a slightly darker color? Also, they sometimes overlap with the object, so maybe the radius should be a bit larger as well.
please make filename in lower case( + rename the file)
so sweet.
I'd prefer getters and setters with the rest of the methods.
We discussed setValue/getValue a bit here https://groups.google.com/d/msg/sabredav-discuss/50vPtm8MgT4/SDj_MmBy-0EJ
скобки не нужны
и как видно тебе нужна не вершина а расстояние до нее, поэтому логичней передавать именно его
строчку покороче бы
As far as I can tell, there is no way to support both. You can either start logstash pointing to the shipper.conf file or start it pointing to the conf.d directory.

I might be missing something but I couldn't find a include/import directive that I could put in shipper.conf.
I think I was confused for a second. You're right. This is not relevant. I forgot we changed the API so that the function doesn't just pick rows, but rather alter them.
Quick question though - in the ticket, I had specified that it returns false if the row should not be changed. I see this is no longer true in that all rows get queued up for an update. Do we still feel like that makes sense?
I used the same name as AMO, but it make more sense to use <code>pagination</code>, so I changed the name.
`from django.conf import settings`
It's picky, but remove the space :)
Just curious--how'd you choose these defaults?
It could just be an init function in search.js that is called from here, which would better group functionality.
We should be using IO.getFileListForFolder here. It does a lot these checks for you already.
I've made the `properties` object optional on the `LoginId` docs. I think properties does have to be optional as most loginIds won't need it.
You could use underscore.js _.map for this, but I'm not sure if that makes it more readable.
SOE... you should have that call in tail position ;-)
I tried hard to keep only one, but I couldn't find a way. So I decided to keep things simple, and iterate over when we need more flexibility. This will crystalize as the editor progresses.
Would prefer a switch statement.
Is nt sorted always false here? can you remove the variable?
combine above 2 lines?
Maar nogmaals: waarom een global variable `spotted`? Ik zou het gewoon locaal houden en alleen de global variables `spottedRight` en `spottedLeft` hieronder zetten.
This isn't compatible with PHP 5.2.4, which is a must.
Also, unless you put the ternary expression between parenthesis - `$code` and `$text` will only be appended to the fallback HTTP/1.1.
нет проверки на различие заменяемого значения с новым.
Мутация с шагом не является случайной мутацией т.е. это явное не соответствие заданию
+ если мы захотим промутировать 30% то 30% от 100 это 30 ячеек, в вашем же алгоритме будет промутировано около 34
В общем перепишите в соответствии с заданием.
та же ошибка с %3
insertObject желательно заменить на replaceObject. В противном случае будет не мутация, а "размножение", т.е вы увеличивает длину массива dnaarr  на mut элементов.
Перепроверьте, пожалуйста :-)
Она так работает только тогда, когда i == 0 (и self.genomeLength == 100).

Если i > 0 и t >= 0, то r = i + t >= i > 0 - строго больше нуля (и даже больше, чем (i-1)).
А arc4random()%k >= 0 - может запросто обратиться в ноль.
Being closer to CefShutdown() is definitely a better place for a generic OnBeforeShutdown() handler in case we ever need to put anything else in there. Moved.
Why clone? If we passed current resource, wouldn't it be possible to reserve each layer modification in current image?
NEvermind read this comment wrong
We use em-synchrony.

For example, here: https://github.com/crowdtap/promiscuous/blob/deferrable-06/spec/integration/defer_spec.rb#L57
around 20 mongodb connections are used (I checked).
this should be CREReader:showMenu() right?
Totally right; I had some confusion over that.  Also, whenever you're doing a redirect_to, it's apparently 'better' practice to use _url instead of _path.  It's got to do with complying with HTTP specs.
Should the target of the note taken into account as well?
Should the same textual content created at a different moment pointing at a different object be considered the same Note or not?
Yes, wrapping around os.environ['MNE_LOG_LEVEL'] from within python or just
setting it from the shell.
Like that.



---------- Forwarded message ----------
From: Martin Luessi <notifications@github.com>
Date: Wed, Oct 31, 2012 at 12:57 PM
Subject: Re: [mne-python] ENH: Adding verbose options (#167)
To: mne-tools/mne-python <mne-python@noreply.github.com>
Cc: "Denis A. Engemann" <denis.engemann@gmail.com>


In mne/__init__.py:

> \ No newline at end of file
> +from . import viz
> +
> +# deal with logging
> +set_log_level()

It would be nice to be able to use environment variable, e.g.,
MNE_LOG_LEVEL, to set the default log level, WDYT?

—
Reply to this email directly or view it on
GitHub<https://github.com/mne-tools/mne-python/pull/167/files#r1991006>.
yes, also thought of that. would be more self-explanatory

On 26.12.2012, at 14:33, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/preprocessing/ica.py:
> 
> > @@ -146,14 +155,16 @@ class ICA(object):
> >          >> ica.exclude = []
> >      """
> >      @verbose
> > -    def __init__(self, n_components, max_n_components=100, noise_cov=None,
> > -                 random_state=None, algorithm='parallel', fun='logcosh',
> > -                 fun_args=None, verbose=None):
> > +    def __init__(self, n_components, max_pca_components=100,
> would make more sense to have first n_pca_components and then max_pca_components in the list
> 
> —
> Reply to this email directly or view it on GitHub.
>
But wait alex, this was about the titles we have in the topi plots....
What will happen then?
Also see 619 in viz.py

The idea was to be abled to write custom titles on passing custom data....
It was formerly hardcoded.


On Sun, Dec 16, 2012 at 10:20 PM, Alexandre Gramfort <
notifications@github.com> wrote:

> In doc/source/whats_new.rst:
>
> > @@ -90,6 +102,9 @@ API
> >
> >     - The artifacts module (mne.artifacts) is now merged into mne.preprocessing
> >
> > +   - Epochs objects now aldo take dicts as values for the event_id argument. They now can represent multiple conditions.
>
> fix it + the mysterious titles param and I'll merge
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/221/files#r2430661>.
>
>
Make this return void
Okay, so _do_ get rid of it instead of putting @Ignore. :-)
Any chance we can link to a video?
Style: It is uncommon to delimit bulleted list items with trailing commas
Why do we need this branch?
*Revert to* what? Please give some clue to translators by providing a comment.
why are these objects required to be created?
You should to remove this line (ad the one before this) and replace the `:` with `::` (at the end of the sentence)
From what I can see, this should be:

    <!-- app/config/config.xml -->
    <?xml version="1.0" ?>

    <container xmlns="http://symfony.com/schema/dic/services"
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xmlns:acme_hello="http://www.example.com/symfony/schema/"
        xsi:schemaLocation="http://www.example.com/symfony/schema/ http://www.example.com/symfony/schema/hello-1.0.xsd">

        <acme_something:config use_acme_goodbye="false">
            <acme_something:entity_manager_name>non_default</acme_something:entity_manager>
        </acme_something:config>

        <acme_other:config use_acme_goodbye="false" />

    </container>
"lots of messages"?
Why exactly `xit` ?
Lining up the ':' everywhere? I don't see it down below (var languages = )
This logic should be in the ChildrenContainer.
Why is this needed? newMemberSet is immutable right?
Если ты пишешь реюзабл-класс, то все равно имеет смысл инициализировать предка QObject. Просто правило хорошего тона и задел на будущее.
Почему бы просто не написать `FilesWatcher_->Release ();`?
Порядок инклюдов в этом случае будет, думаю, stdexcept, потом sys/*, потом кутишные, потом уже utils.h.
Jaja, la edición no me llegó al mail así que no entendía nada
Since dbSNP and everything else requires SNPIDs in string, you might as well leave this as a string as well.
no need to localize
Probably a RESIZE_MODE_OUTBOUND is better here
... and should add at least 3.1 and 3.2 too.
Is this better than `scope.$watch(attrs.uiCodemirror, ...` ? Just wondering if it's more efficient to use the $parsed value or the original expression.
Valid integer must be valid.
Curious to why we are going to a loose dependency?
Have you looked at <thread>? You don't need to change this now but I am in the process of moving to std::thread and std::mutex everywhere instead.
Can you remove this comment? Then we can merge.
I was going to say we didn't pass that back but it looks like we did. Committed the change.
This was updated! :)
are we returning a static value for used storage???
@mmarkus I agree with you, but this did cause errors that were very hard to track in the past.  I.e., there may be edge cases where it is valid that a non-owner attempts to unlock.  I.e., we originally did throw a runtime exception but this was, for various reasons, commented out.  Now, we log it at least so that we can track it better.

@danberindei Good catch.
why do you use "unquote", was it tricky to define the quotes in the grammar?
No :D

You can add simple message.
By MEP10 I hope to replace this with a regular Makefile (the newer Sphinx way of building things), so these changes might be short-lived.
PEP8, again with the extraneous spaces...
I don't think all visual detections are supposed to have widths and heights ... maybe visual field objects?
ah ok :-)
Jordan, can you throw a comment above this option:

# Virtual ram to physical ram allocation ratio (default: 1.5)
@jsloane is there a way we can avoid browser detection and use feature detection instead?
I think this can be moved to AbstractContentSearchQueryHandler and also used by the original ContentSearchQueryHandler.
@pluskid i thhink what @sonney2k means there is that he doesn't like std:: ;) so you try to implement it without using STL....
Are you sure ``$validatorMock`` has the correct type as ``object<PHPUnit_Framework_MockObject_MockObject>`` is not a sub-type of ``object<Zend\Validator\Csrf>``?
代码是用cloud9 web在线coding的。cloud9上面node版本较低，只有path.existsSync 。 所以这样写，做了下兼容。
It would be good to know how that's handled by TeX - it would be much
easier if their sentence casing just didn't affect non-English letters.


On Fri, Dec 14, 2012 at 12:42 PM, Aurimas Vinckevicius <
notifications@github.com> wrote:

> In BibTeX.js:
>
> >  				//protect caps for everything but the first letter
> > +				/** TODO: non-latin letters. Also see below **/
>
> Right, that's what I was referring to. I guess also cyrillic alphabet,
> etc. The only reliable way I can think of is by building a list of many
> many capital letters supported by Unicode. Or we can just do it for the
> most commonly used languages.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/adam3smith/translators/pull/3/files#r2424545>.
>
>



-- 
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
should this be set higher up in the message hash? even if that is set at false by default?
Hmm, interesting. So you are saying this should work?
```ruby
MongoMapper.connection = Mongo::MongoClient.from_uri(env['uri'])
```
That's correct. Escaping percent causes really bad things to happen since we're adding a bunch of other %'s to the string in the process.
Shouldn't the `flush()`/`close()` operation be in the `finally` block to ensure that the stream is closed in any case?
Does order matter here? I wrote a test that ended up returning `4 3 1`. Either we should state the expectation that order matters, or re-write the assertion so it doesn't :)
Nit: Spelling: supported
Instead of having some partial duplication with the other `add_data` method, let's just modify that one to return a list of tasks as well. (i.e., replace that method with your new one)
You have to rerun messages collecting every time you change a translatable string in templates. For example, here are now `"` missing around usernames.
(BTW, form should be accessible also without given token.)
OK. Comments mixed. But you still have to fix those translations!!!
No, don't check. Maybe the new update has some new information (new user image, for example)?
Why newline?
Some additional feedback would be useful to the user (like background color change of notification, similar to how Facebook has) and counter change. But this will probably come.
Use `$` instead of `jQuery`. No need for portability here.
Ehm, `return current_path.startswith(url_path)` is not enough?
I must say that I find this ugly. Attaching some external information to the field. This is OK if there is no other way, but in this case there is: you can retrieve this information ad-hoc in `clean` method. And in template you could simply provide additional data, like dict, which would map between field name and dependencies.

But OK, let it be like this for now. Let see other things.
This will then be just radio buttons to choose from.
Easier would be to simply create a set:

```
for latitude, longitude in {(node.latitude, node.longitude) for node in nodes.get_all_nodes()}:
```
Why does it print Field7 and then actually print's Field5's value?
Better to check just:

    if (where) {
NormalizeOrientation(o - GetOrientation()) ?
Move to the top of the method
# Returns an Array of Subscriptions.
What you say is 100% true, but I would still leave the else, mainly for two reasons :
First, for the clarity of the code : if there is no else you need to compute yourself all the possible outcomes of the previous block and understand what's going on, while it's obvious with the else.
Second, because you never know if the function will be refactored : if a future programmer modifies something here and for example puts the return in a if block, then bad thing could happen. This is not possible with the else.
The potential leak already existed before in a slightly different way. Do we expect someone to call interrupt() on this thread?
One declaration per line.
Well, in that case can use change all `||=` to `=` in Railtie, because Railtie is only "executed" in present Rails environment. What do you think?
After talking to Matt W., it was discovered that the relatesTo element is the correct element to correlate off of.  Matt T. also pointed out that the relatesTo element is a repeatable element.  So I added the logic to check the for multiple relates to elements and see if they have a transactionID.  I also allowed for multiple transaction IDs to be logged for a message that has the multiple relatesTo messages with multiple transactionID correlations.
I guess RealGalaxy needs this too, as it has a bunch of extra things that wouldn't get properly copied by the standard copy methods, right?
ditto apostrophe comment in demo10.py
Yes, I felt that too... So I pushed this: https://github.com/GalSim-developers/GalSim/commit/152b5024c016078c4b2357b8949236b4c28b81f9

I think it covers it.
You can probably remove this method in favor of DomUtils.getChildElementByTagName(Element ele, String childEleName)
Might as well make is_video a boolean
I think we can and should move to using guava's Files etc as much as possible for this kind of thing.
But for now, you could use something like:

            File tempFile = ResourceUtils.writeToTempFile(src, "sshcopy", "data");
            try {
                finalSrc = new FileInputStream(tempFile);
            } catch (IOException e) {
                throw Throwables.propagate(e);
            }
Ok, I didn't realise that happened automatically. I think there are many other entities that do this superfluously then...
it the old newAveragingEnricher which also had to be changed to support the new newAveragingEnricher which accepts a default value to use for sensors which haven't published yet.  default is 0 which is old behaviour but now explicit default value of "null" can be supplied to mean to  exclude sensors which haven't published yet.  however we can't supply 0 of type N because we don't know N yet (at least i couldn't figure out a way) so we supply (int)0 which is Number.
please don't use 4 space tabs. we use 2 spaces (it's also true for scala, btw. but in scala there are old files that are 4 spaces based)
Shorten things up for readability by changing:

    billed every 1 month

To:

    monthly
it is optional, but it's needed if you want to keep cornice compatible with the previous version. Also, I want to make cornice pyramid agnostic, there is still some little changes to do to accomplish this but then it would be possible to plug in any framework.
It's because `isExpired` is set asynchronously via `updateIsExpired` so we have to observe it. There is already an observer on `Ember.ResourceCollection` that does a similar thing (`autoFetchOnExpiry`), but there is no such observer on `Ember.Resource`. Which is why it's a new observer.
There's no difference really except that the ``is_authenticated`` method will error if you load a user directly from the database (without any authentication).  Hence, I was thinking that it was better to not use attributes that depend on authentication.  However, I don't really think that's right - forms are always used from views so the passed user will always have been adjusted by the authentication components.

I'll change it to use ``is_authenticated``.
for consistency purpose, please move this to webinos/test
can you make your editor stop putting in trailing whitespace!?
Arg, nitpicking, I know, but can we have this raise a more specific error? I don't like RuntimeErrors.
Updated ;)  Thanks man! I wasn't sure if we're still keeping track of the changes in that file.
So..... is it alright to keep it as `gfortran` then?  As far as I can tell, the `$(MPIF77)` environment variable _should_ be set to whatever `$(F77)` was set to, with `$(MPIF77)` acting as an override, but for some reason it doesn't.  That being said, I could be wrong.
I don't want to keep the global `module` since it provokes name clashes (e.g. with node.js), this is why I added lively.module now.
this should be done in willDraw
Bitte Tippfehler noch korrigeren und dann bin ich wunschlos glücklich :+1:
`from *a* test` perhaps?
> potentially of only a fragment of a file. 
I would agree if it wasn't the file for exception class, which are usually just this boilerplate and nothing more.
I'm a bit concerned with this.   I don't think the scala maven plugin should be compiling java, since the maven-compiler-plugin does that....   Have you seen any issues with this?
Equally: 80 80

ÐÑÔÎÉÃÁ, 23 ÎÏÑÂÒÑ 2012 Ç. ÐÏÌØÚÏ×ÁÔÅÌØ Dmitriy Komanov ÐÉÓÁÌ:

> In src/ru/fizteh/fivt/students/yushkevichAnton/parallelsort/Tester.java:
>
> > @@ -0,0 +1,29 @@
> > +package ru.fizteh.fivt.students.yushkevichAnton.parallelsort;
> > +
> > +public class Tester {
>
> òÅÚÕÌØÔÁÔÙ ÉÓÐÒÁ×ÌÅÎÎÏÇÏ ÔÅÓÔÁ ÂÕÄÕÔ?
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/dkomanov/fizteh-java-task/pull/249/files#r2210545>.
>
>
If WebConsolePanel, DebuggerPanel, StyleEditorPanel and InspectorPanel are called at parse time, we have a problem. This should not happen.
i was going to suggest using the Sorter page region, but it appears to have a different set of sort criteria.
When you will build intree, you shall be able to cope with those flags passing them to the addon
We probably want to say "Chef 11" rather than chef-11 and perhaps only give a warning on a version of Chef that actually has the new resource?
`x.zlim(zmin=0., zmax=1.)` as dependence is bounded by 0. and 1. if I understand correctly.
You are right. I renamed the variables.
`# initialize weights to 1 / n_samples`
I didn't add this, just document it. I can rename it but not sure this is related to this PR...
I don't know where I picked up this style, but you are right, a ``[0]`` is better. I always use that for ``np.where`` for example.
мейбі зайве?
Rewrote this section based on your suggestion to remove duplicate code.
please use explicit here
As discussed, we'll leave it for now and refactor if needed
Since we should ideally move to `Doctrine\Common` and eventually extend the features here with more specific/optimized logic, that's why I suggested to use `find`
public IndexReader openIndexReader() {
		log.debugf( "Opening IndexReader for directoryProvider %s", indexName );
                ...
        }


Not changed by this code, but should there be an if statement around the logging or is this not required w/ _debugf_? Or is there no benefit in general anymore?
String concatenation is terrible for performance, but String formatters for which you pass the format again for each use are likely worse.. looking at the patterns it seems to me we should use a plain string concatenation.
It is increasing the dependencies between the different bits of the system, and will slow down compile times.

Not a disaster, but worth trying to avoid if we can.
Now I remember, data[] seems to be always pointing to the local non-const "byte *" buffer, and is only const because of its return type.

I agree the const_cast doesn't make it nicer, but it looks safe enough.
Yeah I agree :/ I think that there are better ways to do this kind of layout w/ jinja actually, I'd like to study that more.
That should be `http.HttpResponse`
good call. curl is a better choice in this case.
Platform is set above at line 26 and line 30. This is done this way because activemq expects the platform to be formatted "macosx" when chef provides it as "mac_os_x".
We have decided to rename `newFrame` to `open`.
'last_name' -> 'bdate' видимо.
кодировка сейчас как будто и одна и другая косячит, посмотрим что с ней попозже.
Why the function returning a function, when you don't use the external closure for anything?
@christianv I like having that front-end flexibility too, and had actually cried a wee bit when giving this responsibility up to the back-end via date_string. So for consistency should the other dashboard widgets do the same? Or is it that the calendar needs more precision than Tasks/Notifications, so it's an exception?
Yep, forgot to get rid of that from the sample module.
failback → fallback
Using re here is a bit sucky, we can swap this block just for a straight assertion. Here is Addon-tests example:
https://github.com/mozilla/Addon-Tests/blob/master/pages/page.py#L36
Well spotted @bebef1987. You'll want to change your username/password too as it'll appear in the commit history, although I suspect this was a disposable account.
How can this ever happen given the check in `fromExtentMorph`?
It's a shame that we had to move from properties to getter / setter functions.  Since the collection needs to know when these are set, I don't know how we are going to get around it until get/set properties are fast enough.
Should this be is_admin?
Internal implementation treats HYBRID and SAT as different types in regards to how we setup the actual MapView.  There is some discussion regarding setStreetView being deprecated but I have seen no official documentation supporting this.
Shouldn't we mention what is the new event's name ?
I pushed 0.0.5, please see if that sorts it out for you
Do you have a radar explaining why this workaround is needed? We also need some kind of test case that we can use to determine when it is no longer needed.
Rather than passing an anonymous function, it might be better to put a named function onto the view class itself (e.g. setReallocateTarget), and pass it in. This also reduces the memory footprint, since the function is only defined once, rather than each time startReallocate is hit.
Another option for inter view communication here would be using the MangroveValidation.bus object, although this might actually be more code than the view decoupling is worth.
А что по твоему такое класс? Это набор функций this -> args

В общем, принято с большой буквы писать всё, что я могу инстанциировать и константы, а не с большой всё, что не могу и не константы. Это очень просто правило, мне кажется.
Храбрая несовместимость, дабы избежать `=> @upload.apply(this, arguments)`?
The first is wrong and I forgot to undo. The second is just spaces. I'll undo both.
Don't change annotation of deprecated functions. (Actually these ones will be removed in the next release anyway).
Thought more about this and a type `InnermostType` that goes all the way through static and dynamic dimension may be marginally useful and generic enough for inclusion in stdlib.
Definitely comment it if you're trying to do anything like that, and yes, any overflow would have already occurred when `1UL` was reached.
It's second nesting level and another variable.
I'm confused. Much of the comment above refers to copy(), whereas the function definition is copyInto(). Also, what is the difference between copy and copyInto? Can't we make copy accommodate the functionality of copyInto?
this double check to raw_session.loaded feels like it's breaking the abstraction layer of loadFromCookie(). I suggest more:

     var didLoad = raw_session.loadFromCookie();
     if (!didLoad) return null;
nitpick: escape the . in sbt.version
You need to alter this comment if you're changing the behavior. Previously it was the caller's responsibility to hash the username if desired.
`AtomicLong`.
comma missing( if sentence)
Sounds strange( it is possible if its possible)
Unnecessaray format-change
Use akka-testkit’s AkkaSpec instead, sending replies to testActor and asserting off that with expectMsg() and friends. Also solves the ActorSystem issue.
@Seldaek why turning ``null`` into an empty string if it was the default ? What if I want my RequestParam to default to ``null`` ?
Please remove this property. It is not needed as the user manager has a ``getClass()`` method returning it
I'm not sure I like how this is being organized. It's just one giant block. I think we need to start doing event binding in a consistent manner. I'd like to go into more detail, but I can't formulate it right now, so let's talk about it in person.
It seems like you're just adding random URLs to the top of files.
No reason. I copied that line from <http://jqueryui.com/dialog/#modal-confirmation>. You can go ahead and remove it.
(Incidentally, is there a reason we aren't just using a standard Javascript confirm()? Seems like that would be a lot easier.)
Тут, пожалуй, шаблонные параметры можно и не указывать в скобках.
:+1:

For the enforcement of single quotes.
Should we initialize this to 0?
...and category... previous implementation said no. We can now.
Ok - This all makes sense. I will make the change this morning - This is, however, a slight change of existing behavior, just something, I originally wanted to prevent.
I thought I just copied it as is, but will look again. The only thing I changed is copyright and moved private method to the bottom
Yeah, maybe I got a bit obsessed with code coverage here...However, at the same time I am not a big fan of simply having Strings as header names (Theoretically I would favor enums for better static typing). Thus, just in case (slim chance but still) that the header name does indeed change, this test will break and the developer has to think at least once more about the change :-)
To make them immutable.
It is necessary in order to properly render `show.md.erb` - the template uses the `puzzle_url` url helper method and when we render it, we bind it to the context of the current `PuzzlePresenter` instance.

The only other way I could find to make this work was a fairly heavy-weight solution that would require to inherit from `AbstractController::Base` and include a bunch of modules. See details about that approach in [this blog post](http://amberbit.com/blog/render-views-partials-outside-controllers-rails-3). I felt it was better to just implement the same interface where it mattered.
Do any of these new computations not require the yaw angle calculation? If so, we should move them in the ``computedSignals`` if possible.