labofsahil/github-event-dataset-2012 huggingface dataset:
People should not be running the tests as root, it's dangerous.

I think it's a better idea to build an `if (is_root) die("don't do that, silly");` check into `test/runner-unix.c`
It's about ordering of A + 2 B versus 2 B + A. I fixed it in https://github.com/sympy/sympy/pull/1166
of not run in the background then:
   param_str: this is a string
would be used as 'this is a sting'
But if you use background then parms_str would become '\"this is a string\"'
Would it affect the usage of this param? if the string will be used for comparisons for excample..?
```
<dependency>
  <groupId>com.typesafe.akka</groupId>
  <artifactId>akka-actor</artifactId>
</dependency>
```

(i.e. without the version parameter) will do the trick - the idea is that the dependency management section of the parent 'locks' in the versions of all of the dependencies declared by any of its children.
we should make a glossary term for dot notation in any case... I think we can probably do better than the wiki page for dot notation, and that probably should go on our list...
I'd vote track… simplify it down to "all (adjectives) instances" and I get “track” rather than “tracks”.
did we fix whatever was causing these errors?
A tweak to the error display. I hid the word "error" (because it never changes) and stuck an emdash between the error type and description to make it easier to read. Needs lots more work yet
Blank strings do not return true. Take U_MCP for example: https://github.com/EXreaction/phpbb3/blob/ffe7f76b90bd24c4c2f2c8bf24c34df69f2def52/phpBB/viewtopic.php#L604
That is an empty string if the user does not have moderator permissions in that forum, and then in the template, the MCP link is only shown if the URL is given (i.e. <!-- IF U_MCP -->..<!-- ENDIF -->
`$null` is a useless variable here.
Obviously $request is hiding inside phpbb_config :p 
Yes, it's  a copy/paste fail.
Available includes enabled so yes, this perfectly correct.
You can get rid of sprintf by using `$user->lang('EXTENSION_DISABLED_AFTER_POSTING', $disallowed)`.
well "to append" is a  verb right? and we agreed on verb-noun, I'd just use append_sid.
But if majority agrees on override im okay with it
This string is parsed by plupload internals, using %1$d and %2$d would likely break it.
`$forum_id` is undefined
...hmm. I'm really not sure what happened there.
As you said in the previous comment, I'm not sure there is a need to translate this.
Revert this one please
Instead of which part of the sentence?
streams don't have a destroy :(  I couldn't find a decent solution with maintainable code.
Just a note:   before release we should make sure this works w/ windows.   I'm sure Stefan can try it out.
this is very confusing, should be `my_yui` but that one is also confusing. In theory, yui-sandbox.js will be the proper way to require YUI, and that one should be smart enough to figure out which version of YUI to use (the one bundle as a requirement of mojito) or the one installed at the app level, or the one the user specify somehow, but we are not there yet ;)
My bad, could undo, I first had something else in that else.
Instead of three `_set_protection_methods(protection_level)` invocations, use an ensure at the end of the method (`def ... ensure ... end` is valid ruby)
This means that the actual number of element in array_buffer should be N ? N : 1 then we can check that N and the actual size are different.
@grumpydev added it
consider a shared constant that equals 400, so you just have to set it in one place
can use Util.dateTime(new Date());
This seems to suggest that ```array``` can be a cube, but this function cannot accept a cube due to the call to ```numpy.broadcast_arrays```. Cubes have ```shape``` and ```ndim``` attributes but the call to ```numpy.broadcast_array()``` would need to take cube.data. Could this be modified to take a cube rather/as well as a numpy array like object? @ajdawson - which is preferable in your view?
Module level docstring.
typo. will fix, thanks.
doesn't cause an error in *make html* or *make extest*,
which is the current focus, but should have been spotted.
``adds`` and ``commands``
Isn't this expensive and mostly redundant with the column width calculations below? Would it not make more sense to calculate the tuple widths first and THEN if there is a heading, adjust those widths in the case that the heading column is wider, and THEN calculate the format string and then if there is a heading, output the heading and separator before outputting the formatted tuples?
Fixed it already this afternoon. I also fix it for PushdownLimit optimization.
When doing equality comparisons, assertEquals is better than assertTrue because it prints out both values when it trips, making debugging easier. Usage tip: put the expected value first to make the default message make sense.
Spurious empty lines.
"changes without an author" = "system changes".
Normally you should do
<pre>
if x10sion in url:
</pre>
but in this case you *really* want
<pre>
if url.endswith(x10sion):
</pre>
except you don't even want to do it on the whole URL, but parse it into parts with urlparse and then check just the file name.
This is a more useful critique: more about the quality guarantee of the returned value could be useful
It's not in the [Django specific terminology](https://docs.djangoproject.com/en/dev/internals/contributing/writing-documentation/), but it seems to be used throughout the docs as two separate words.
I would say "and advanced testing topics." rather than calling it a "document"
cursor.execute("CREATE EXTENSION postgis")
    cursor.commit()
Woah. Fragment cache gone just like that. Amazing.
I see no reason to expect that the middle of a selector would be independently reused, but there'd be no need to retokenize anyway since we've already got `match`.
I noticed "MADLIB_SCHEMA.logregr_cg_step" is marked internal but still generate documents. But I think it is still not "true internal" functions. The author still wants users to see it.

Please study the function of "MADLIB_SCHEMA.internal_logregr_cg_step_distance" instead. For this function, it has no comments at all. I think this is a real internal function. Our functions with a prefix of "__" belong to this type. How do you think of that?
From conversation with Mark my understanding is that these results where validated against matlab, which gives me a little more confidence than otherwise in terms of simply having the raw numbers.

That said, a comment to that effect including the results from matlab would be of assistance in terms of the maintenance of the test and your suggestions of having an example query using the learned coefficients is a good suggestion for additional validation.
The options are just happy and sad.
Let's leave them in forms.py for now, and if I think it's too large, I'll mention it then.
I'm not sure, I wanted to be on the safe side.
This part can be removed - if Erlang depends on openssl then it will automatically be used, and if Erlang doesn't depend on openssl than the keg-only openssl won't be linked against even if it's manually installed.
Is it possible to build Ghc without any binaries i.e. a full bootstrap?
Was im backend angezeigt wird ist ja immer der name. Das sollte ja was user lesbares sein. Der code ist ja dann eher mit technischem hintergrund, daher ist sowieso gut dass wir das hier getrennt haben.
Fixed (also in the get method).
Sorry - forgot about the extra object creation there.
rawTypeToString appends ```<...>``` onto the end of the type name if it is generic. We need just the type name in order to look up the type via the processing environment.
That's real fast
All other references to hintProviders is done as hintProviders[mode], but "all" is referenced as hintProviders.all . Since the "all" list is created the same as the other modes, I think it would be easier to understand the code is you used hintProviders["all"] instead of hintProviders.all .
Fixed this case and 2 others.
Still confused about the logic here even after your exchange with Peter. It seems like we're conflating the Document's notion of "dirty" (which means the user has unsaved in-memory changes) with the notion of a file having been modified on disk. If the Document is dirty, then we should get the in-memory (unsaved) version, and not look at the disk version at all (if the timestamps are out of sync, then the user must have already made an explicit decision to ignore the disk version). If the Document is not dirty, but the file's been modified on disk, then we should get the disk version.

I *think* your logic is handling most of these cases, but because it's using the term "dirty" to refer to both dirty documents and documents that have changed on disk, it's subtly different from the notion of "dirty" that's already in Document, so it makes it a little hard to reason about when looking at this code. Maybe we should change the name of `DirtyDocumentTracker` to something more like `ChangedDocumentTracker` or something like that.
two spaces before comment
mu can be built for windows using cygwin although I haven't managed to figure out exactly which packages are required.  I do know that last time I reinstalled cygwin and tried to build it I had to include several `-dev` libraries and not just the current versions.  I ended up including them all to ensure I didn't miss any.
The stack of functions calls to find where the error is thrown
Wouldn't it be faster to revert the IntegerUnion and then to use an iterator ?
Because we need request context for auth (and args in a different view). get_redirect_url only messes with the url string and **kwargs. I'm not sure how python and C work together so I don't know what **kwargs actually does at the moment.
I'm all for simplifying things!
spppppacing.
Move this into `routes/index.js`
Unfortunately we don't store the instance in any form. Nor can I use information from the trackEvent being passed in.

Right now this is our only editor that makes use of a popcorn instance. I could change it up however to pass the popcorn instance ID from our editor helper by doing something like....

<pre>butter.currentMedia.popcorn ......</pre>
lets not declare these vars in an if, move them to the top of the if with the others.
remove extra space at the end of line
How about ``{'errors': ['Empty response from server']}`` or something like that
In principle, there's a very small race between this and _get_conn, but it causes a crash rather than leakage:

1. _get_conn() sees that self.pool is not None
1. close() sets self.pool to None
1. _get_conn() tries to modify self.pool and crashes
This line will explode if `ssl` is `None` (see try/except header up top, not all platforms have Python compiled with SSL).
可以少写#if
no bigs, but this is totally a time for case/when. in addition, i'm thinking this method is going to be exactly the same as the one below, so it may be better to create a data structure once, e.g:

```
LangException = Struct.new :platform, :platform_code, :getloc_code

LANG_EXCEPTIONS = [
  LangException.new(:ios, "zh-Hans", "zh-TW"),
  LangException.new(:ios, "zh", "zh-CN"),
]

def astrid_to_getloc(lang, platform)
  exception = LANG_EXCEPTIONS.find { |le| le.platform == platform and le.platform_code == lang }
  exception ? exception.getloc_code : lang
end
```
... etc
richard/context_processors.py definitely gets loaded. While this isn't a context_processor, that's a closer-to-better place.
ino dige hazd kon
这部分组织到框架部分是否更好？
rm line and throughout? or do you want this here?
I'm not too familiar with AMQP, but shouldn't the issue be the composer channel that's in `$record['channel']`? I guess it depends if that's just used for information or if it's a machine-level setting.
Lock screen update is the function responsible for painting, I prefer leaving the switch here instead. Or we should come up better place for all these.
There is an algorithm in indexeddb that generates the name.

I don't know how permanent this is. Currently this is a dead end because of the xulrunner and xpcshell issues.
There is no plan in adding xcpshell to the smaller xulrunner build again.
Yup. I'll clarify that.
Since the purpose of all of these overrides is to modify the record, it's simpler to just override `makeRecord`:

```
    def makeRecord(self, name, level, pathname, lineno, msg, args, exc_info, func=None, extra=None):
        if extra is None:
            extra = {}
        if 'origin' not in extra:
            extra['origin'] = 'foo' # find_current_module(2).__name__
        return Logger.makeRecord(
            self, name, level, pathname, lineno, msg, args, exc_info, func, extra)
```
I just merged this PR - @taldcroft had previously approved, and I had just forgotten to merge it.
Sometimes I feel like I'm the bad guy that did something wrong. Well in a patch some weeks ago, we introduced a limit for the URI length used in generation of QR Codes, which is the same as this one here. I indeed SEE a problem, the QR Codes which would get longer would not be valid for Bitcoin-Qt, so why not use the same limit?
Okay I will think over it some more and try to refactor.
the idea was to allow a subclass to skip it since it might want to call _inputOptions themselves, adjust $options,  call parent::input().

any better way to achieve this?
Correct. I always use tabs, but I think they're sometimes (probably my fault) translated to spaces.

Thanks for the heads up.
Yes but I'm not seeing anything in the code for this one :-)
That's a weird test. And there's no `return`.
how about something like:

```ruby
if discussion.has_activity_unread_by?(current_user)
```
The problem is that there is no client side image at this point.  And we can't predict what client side images we will need.

I can see an argument that the ImageView should maybe delegate the response to the Image itself to handle, but with the simplified messaging, the only thing it can talk to is the client-side version of itself, which doesn't exist yet...
Alright, but I think using 'name' here is actively misleading.
@sc68cal Beware that current version of of LibGit2Sharp detects the bitness of the current hosting process. If git-tfs is always delivered in a x86 flavor, that should work. If this is not the case, you might be willing to consider doing something like [this](https://github.com/libgit2/libgit2sharp/blob/vNext/LibGit2Sharp/LibGit2Sharp.csproj#L190-195).
curious why this is needed, same comment as above: links already copys-in the elements as a new set
https://github.com/kaltura/mwEmbed/commit/df3a0a7886e0ad7617bb5d653085ae79edcf4719#diff-0
AFAIR `dummy-marker.txt` files are only placeholders to cope with empty directories.
They should be removed before running the tests against a repo containing them.

```c
cl_git_remove_placeholders(git_repository_path(repo), "dummy-marker.txt");
```
Awesome that this worked! :+1:
This is not on Josh's list either. To be removed.
what date gets passed here? the postgres functions expect "yesterday" (UTC)
``PERFORM`` instead of ``PEFORM`` I suppose.
I like the straight forward and simplicity of this!
Don't comment out code, just remove it.  That's what git is for.
置顶操作仅管理员可见和操作, 使用了图片 http://cnodejs.org/images/star_fav_empty_icon&16.png 和 http://cnodejs.org/images/star_fav_icon&16.png 放在 分享到微博 这个按钮后面. 即同样是管理员可见的编辑删除按钮的前面.
In order to match the endpoint in OPC, this needs to be a root-level resource, so we want `["authenticate_user"]`.
we often use the idiom: return callback() instead of callback(); return;
Instead of the global sys.argv array, use the argv array that was actually given to the command line.
What's with the `Scruct.new`?
не зовсім впевнений, але  так працює, без цього зворотній звязок "payment->ticket" не працював.
можливо чогось не вглядів, але логічно що "квиток і платіж цього квитка" поєднані звязком один до одного.
string ? seriously ?
oups, forgot the setter
You should add `{@inheritDoc}`.
Symfony does not use multiple arguments for ``isset`` anywhere AFAIK
why this case ?
You should also add `@` here and below, to prevent errors throws when permissions are insufficient.
If we write `FormBuilderInterface::add()` as
```
function add(FormBuilderInterface $builder)
```
*any* class implementing this method must accept *any* other implementation. There's not really anything to discuss here.
i guess it's only for coverage
I think option.user should be removed, because using config file for getting this value is much comfortable as for user as for developer. The main reason - dynamic links and templates for URLs. Just looks how URLs created in old version
Is the name of the variable ```pk_id``` correct? The method ``` create_eula``` calls this variable ```patch_id``` .
Can the go-menu* go-button* images be deleted from the repository now that they are no longer used?  The section File Changes did not contain any deleted files.

I am new to doing code reviews so I am getting my feet wet by commenting without doing an official code review.  Sorry if it comes across the wrong way.  Any effort that produces a quality app should be advantageous.
I think the `group` can be `build_stubbed` here, but not the `event`.
Remove brackets - reads strangely.
I feel like this shouldn't be here. Defaults should be set in one place. Possible?
uh maybe it changed just before I commented lol
Sinon rien ?
is C: needed?
Ok for the ``help_text``, but what kind of validation do you want? As it is, we can use them for pixels only.
You want to change this to a CharField which validates the regular expression ``\d+(?:px|%)`` and default values to ``100%`` and ``400px``?
If so, can I remove the last two migrations? I guess this is an horrible-move-one-should-be-strangled-for, but since the pull request hasn't been merged…
For the record, this was an enable tool that reacted to right-click *up*, while the events are triggered by right-click down. Also, it did not consume the event.
got~
Can this be a cookbook file? There doesn't appear to be any variable injection/ruby logic.
Done. Thanks for spotting this.
I've add the suggested change, rebased, and pushed my topic branch now.
Shouldn't this be != ?

Seems like this while loop will almost always just drop into the else clause and terminate.

AFAICT this whole thing should be done with a CountDownLatch that each runThread counts down in a finally block.

I may be misreading, but isn't the semaphore only acquired 20 times? The for loop runs 10 times, each loop creates 2 threads, each thread acquires once. So PERMITS = 100 is wrong; the CountDownLatch should be set for 20.
This left some whitespace.
This method name is a bit misleading (so was the previous one). It suggests that it returns a UAParser instance, but in fact just the array with parsed information for the current user agent. Could be revisited later.
typo? should be `function calculator_clear`.

Our debuggers, etc... are now smart enough to give this function a name but we should keep this convention for now (as the rest of the file uses it I am sure).
I don't see any call backin within `onsuccess`
If I am not wrong, 811222 would let me know the status of calling, too.
So yes, this is also a workaround.
nit: editButton
var classes = element.classList;
We are using `data-type` in the BB to differentiate and isolate styles, maybe could sound weird in an input, but as we a re using it in another kind of elements we need naming consistence.

Thx for the review!
This is the only things that worry me. I thought the path should be absolute?
I don't see any place where the input parameter is used. Is that changed really needed?
Sure! Thanks ;-)
if () {
}

Don't forget the space between the 'if' and '('
Not the that I use it, but others would need the vim header. Copy it from other files :)
What’s the point of these empty images?
UX Requirement. Once you fill all data about Wifi you have to come back to the list of Wifi networks available.
botio won't let this one pass :)
Do you need the `div` selector here?
Should we delete etc/automaton.conf completely (since we switched to using 3 config files)?
But here we are working with everything in english, it's not like redu :wink:
Yes, we shouldn't leak the expectations of the data store through the code.  We should enforce them independent of the store.  Doozerd may get more lax or strict whereas visor needs to communicate a clear interface to its consumers.
~~~
好きなフォーマットをクリックするとダウンロードがはじまります。
~~~

→

~~~
好きなフォーマットをクリックするとダウンロードが始まります。
~~~
I can see getting an implicit Semigroup with that approach, but how do you define zero? You need to know the total length (and maybe the sparse threshold).

For the same reason, you don't have an implicit HyperLogLog Monoid either, do you?
Wait, why is there a type parameter here? Is is not max of Ts?
ah, k
Would these benefit from a factored assert like the other schedulers (which makes me wonder if those can be factored too).
the update of the lock file should be a separate PR so that it can be merged quickly, without waiting for the end of the review on this PR
I don't think this is clear, I mean this is the description of composer update not of composer require package/package etc
you can remove the extra braces around the expression: ``$isInstalled = isset(...)``
this is a hidden field, so it should always say the english string mobie, and we should traslate it on the front end.
Use `user_project` helper
Why are we supporting bare pointers here? I would rather this not be implemented and make normalize actually mutate an existing path.
just remove this! :)
2.1 will require EXTENSIBLE_CHANNEL for the StringExtItem constructor; are you able to take care of the forward-port after merging?
I think this sounds little more complicated than it needs to be. For example following works fine:
```js
// Jetpack scratchpad

let { PageMod } = require('page-mod')

PageMod({
  include: "data:text/html*",
  contentScriptWhen: 'start',
  contentScript: 'new ' + function() {
    document.documentElement.addEventListener("addon-message", function(event) {
      console.log(JSON.stringify(event.detail))
    }, false);
  }
});

var uri = "data:text/html,<body>demo</body>" +
"<script> new " + function() {
    var event = document.createEvent('CustomEvent');
    event.initCustomEvent("addon-message", true, true, { hello: 'world' });
    document.documentElement.dispatchEvent(event);
} + "</script>"

let tabs = require('tabs')
tabs.open(uri)
```
Circular dependencies really suck!! Please consider moving bits you need from `globalPB` here and then access / call them from `globalPB` instead.
nit: may be a note to tell that it will unregister the listener thanks to the weak ref pattern?
Since this was rebased, shouldn't this commit have disappeared? It's [landed on dev](https://github.com/mozilla/browserid/blob/dev/lib/configuration.js#L96).
the only line in this patch I can't understand is this one.  Was this css overlaying some catchall lower down?  redundant?
the check is actually there to accomodate the "bcrypt work factor has changed so we're going to re-hash your password for you in the background" case, which delegates to update_password (with old==new). The unit test for that case expected the sesion to remain valid, plus it seemed a bit gratuitous to expire the user's session immediately after they log in (which is when the work-factor-has-changed check occurs) when they aren't actually changing their password.
nit: always use a space after a comma. It applies to a couple of instance in this file.
This relates to issue #13.
@pcarlisle yeah ... that about sums it up. How's that different than flush?
The convention we've been using for errors in PMT has been:

    Error: <Failure> <What you asked>
      <What went wrong>
        [<Additional context>]
        [<Next steps>]
Wouldn't this end up ignoring an improperly formed `hiera.yaml`? It should probably error in that case.
ZeroDivisionError?
I won't merge any code with "rescue nil" in it.
oh, I didn't know that. But I guess it is too early to completely drop 2.6 compatibility
```js
this.options.cache || this.$element.find('.modal-body').load(this.options.remote)
```
is shorter :)
There is no test check for test this logic yet
Would be better to ask:

 if not isinstance(value, basestring):

See:
http://docs.python.org/library/functions.html?highlight=basestring#basestring
Sorry for disappearing from this discussion. Multi part does work fine - `get_message` returns an array of parts which are then splatted, so the interface for receiving is:

    pull.on(:message) { |part1, part2|
      p [:part1, part1.copy_out_string]
    }

Or if you don't know how many parts to expect:

    pull.on(:message) { |*parts|
      p [:parts, parts.map(&:copy_out_string)]
    }
@anti Tässä taitaa olla vastaus tohon mun edellisewen kysymykseen!
Your line breaks here are flipped.
`partials` isn't very descriptive. Also since this is related to comments it can probably live in the `comments` directory. So you could have a file named `app/views/comments/_form.html.erb` and `app/views/comments/_list.html.erb`.

When we do have common partials that aren't related to a specific resource, I think most of us have standardized on using a `app/views/shared` directory. I feel `shared` is a little more descriptive then `partials`.
code is about Alice and Bob, comments about Alice and Alice
You're right, all ``shutil.*`` calls may raise an exception. And these exceptions will be caught later by Pelican, so it's fine.
I am now wondering if this try/except block is not useless: the except clause is only used to log a message which does not really correspond to the actual failure (os.makedirs has failed, nothing to do with copying yet).
As an exception will be raised anyway, I think I would simply remove this try/except clause.
Any objection?
minus type
"viewPort**Heigh**" - that looks like a typo
Wibble: alignment here
It's not related to a login method. `possible_keys` are representing posible attributes which can be used to find a model object. It tries to call `.find_by_id`, `.find_by_name`, `.find_by_login` if the method is present.
I couldn't figure out a "right way" to determine if choosing is enabled, so I cheated by searching the dom and seeing if the choose option exists in the actions dropdown. Kind of a brittle solution... so if you know a better way to achieve this please do so.
Why have you chosen such an awkward name for this method?
I do not see it clashing with any other names and I do not see the original name "withDays" in any way amigos.
Hmm, true. I needed a id to point at from the aria-controls attribute. Maybe it's better to change back to class and loop through all .share-options on the page and give them a unique id, like #share-option-x
lines redundant?
probably meant to say 'user context objects'
I don't think this can ever work now that we have test.js. these tests won't init the ColumnFamily's or anything, right?
Since you're in here, can you remove this statement?
It looks like it isn't being used and it creates a cyclical dependency.
Hmm, no sure if I want to go this path.
The real problem is that Scala is binary compatible only on at the minor release level (2.9.x are 2.9 compatible, 2.10.x are 2.10 , ...) and this method tells more 'is the version mostly 2.10 compatible'
Maybe I should use `is2_10OrLater` and drop the `< 3.0` check. It is just that I don't expect most of the custom calls to still be valid when we get to Scala 3.0, but they might be in 2.11.
@willdurand That's true, then is this check useles https://github.com/willdurand/Geocoder/pull/134/files#L3R49, because the $apiKey can't be `null`.

@toin0u This is not needed, because `PHP` set the variable automatically to `null`.
I'll fix that :)
В других блоках в таких ситуациях используются одинарные скобки.
Agreed. Removed in 537332b.
Ok. Just looks like there's a lot more changing here than the Settings Provider.

@JakeGinnivan is it possible to simplify this PR to just the Settings Provider change?
i.e. maintain API compatibility initially when switching libraries and then clean up the code in a second PR?
Spaces must be put around each occurence of the negation operator (in this case, just add one between it and the variable).
Same goes for line 857
для uint да. Но по заданию же x должен быть переменной int!
У вас корректная программа. Я стараюсь не просто выставить оценку но и что-то предложить. Относитесь к комментариям (к моим как минимум) как к предложениям, способу поделиться знаниями.
это же сколько итераций
Не ошибка, но для понимая советую прочитать http://stackoverflow.com/questions/1292862/nsstring-isequal-vs-isequaltostring. Я сам не знаток но умные люди пишут... :)
аргумент. стиль пострадал, функционал - нет :)
Родительский init нам нужен, чтобы создать базовый объект - NSObject. Но наш объект - Cell, у него есть свои переменные которые нужно проинициализировать (такие, как массив: под него нужно выделить память и проинициализировать). Поэтому нужно переопределить конструктор init, вызвать в нём родительский init, и проинициализировать в уже созданном базовом объекте NSObject свои переменные.
Да, вы правы )
do not force order (could be tricky, especially when using non bulk async add functions)
Using `+deferredScheduler` will have the same result with or without this scheduler, since they both follow the "current, or else main" logic.
This should verify that at least the specified interval has passed since the last value was sent.
This is a little misleading, since it's not uniformly `interval + leeway`.
Who would this email end up being 'from'? Is it the unix user @ the hostname of the server it is running? Should that be configurable?
It's true that it requires extra tests, but for me a speedup is always worth it :) 

These lines of parallelization code are almost verbatim what's used to parallelize raw.filter()---and they usually get called alongside it when computing projectors---so whatever problems this parallelization may cause, should have already been occurring due to raw.filter(). In other words, it at least shouldn't add a new problem.
FYI, you can also do the shorter and also idiomatic 
```js
[].slice.call(arguments)
```
since slice always returns a new array.
Nit: you should limit line length to ~80 characters. Reading the diff is hard otherwise.
Use getRelationshipTypeByName(), this takes in a combination of aIsToB and bIsToA just like you are doing here
You need to add the @Component so that this can be looked up by spring
Its a shame we don't just have a Program(String name) constructor!
Is it really a problem, it's just another option. As long as it's not mandatory for the user to set it, that should be fine IMHO.
```www`` is not the web folder of the application. When using the built-in webserver, you could use directly the appropriate folder (and symfony 2.1 has a command launching it for you)
you could change it to ``if (!container->hasDefinition()) {`` instead of ``false ===``. It would follow the Sf2 CS and save 9 chars in the line
and remove the space between `rendering` and `;`
@NZKoz sure, we can work on something else.. but it's one of two pull requests that have been opened to change this code.. it's no work to merge it but it's work to keep rejecting the pull requests :-)
Ох, костыли-костылики. Но сойдет.
Fail, c is not used at this position and this line (313) can be removed.
We have to find a new name
In German this is written with "-".
@kevinprince but you can't with this one because in the end this should be read as

```ruby
response.status.should(be(401))
```

which if you write it without all the ()'s could also be read as 

```ruby
response.status.should(be, 401)
```

So to resolve ambiguity you add 1 set of the ()s
I traced the code and load_paste_app wasn't reading the configuration file values by the time the start up code is run. So the conditional import code would not work, since at that moment CONFIG.instance was an empty dictionary.
Yes, I think your assumption above is correct
This should not be removed in any case.
Why is this targeting `NSTemporaryDirectory`? Wtf?
Seem to have an extra space at the beginning of this line.
These can probably all use your new method with a couple tweaks, like TB13 does:
TB13_DEFINITION = _build_definition(13, firefox=False, fennec=False)

but I can change that in my next patch so it matters not, just for future reference.
I intentionally left this out as we agreed we'd only disable it when we need it disabled. It's kind of an intensive task turning it on and off for every test that needs it so why expose yourself to the risk?
```
processapp: ...
bootlevel: 30
```
This is where I'm getting stuck.  I can't put the image in the link. As I said, I'm not a JS guy.
@elicochran - Could you make sure that there is 1 space after each colon `:`?
@bp323 don't want this to be delayed because of this issue, so as discussed, I added it back in.
Can this be an `if ... else`?
Sean reverted this in 74d444cf. I've improved it to actually use the localized name rather than just a class name which happens to work in English: 21beb86.
Changed to "You look great in Suspenders"
I've stared at this for a while, and I think you're right -- with split pages, there isn't anything (left) on disk that we can dirty.
This field got moved to the parent class, shouldn't the selfCoreScript also move there? I don't like referring directly to fields in parent classes and since BasePlugin is also very Clojure aware, might as well handle the selfCoreScript from there too?

Just a thought
At some point after these pull requests get pulled in could you add a space everywhere before the open-brace? (I should have put it into the CSS style ; (
异常直接callback(e)吧。
You could also use `${modulename}` instead of `collectd`.
why checking "is Exception" here?
Again, let's remove implicit.
The IF is not needed as it is redundant, if the OPTION is set to ON, it is ON.
меня смущает новая загрузка библиотеки - так будет загружаться установленная в системе версия, а не так что в папке
For the new add method, please change the since tag to 12.2
I will revert this `explode()` back to `strpos()` for the following reason: see the benchmark code on https://gist.github.com/365af63a41797d9cf705, but `strpos()` gives me the loop in 0.4±0.01 seconds while the `explode()` costs 1.1±0.2 seconds.

I know there is a use case where you have a route name starting with "admin" too, but I don't think this is a frequent enough use case to use the `explode()` instead of the `strpos()`
good to do `"Open Sans", "Helvetica Neue", sans-serif;` I think. Just in case.
Don't change this in my repository please :-)
Not used anymore in the app. Thanks again for noticing, I removed it.
It's needed to do function compilation for speed in the html5shiv. Eval isn't always evil if you know what you're doing with it.
Fixed. Test needs to be extended, but at least runs for now.
Ok, I will make this method check if value is either male, female or "". Would that be good ?
Don't mangle anchor. We could have some information stored there.
Aaaagh. Again it shows a lot of changes in this file. I am not sure what are you doing! ;-)
Yeah, I struggled with figuring out a better way to do this. I'm still not sure of a better way. Maybe a dictionary that maps the localized name of the protocol (displayed in the menu, "SFTP", "FTP", etc.) to the constant ("TBSiteProtocolSFTP", etc.). Not sure where that would go, but it'd be an improvement.
I'd suggest defining an object named `r.timeago` in something like `fuzzytime.js` (to match the class name). Since the fuzzy time behavior is being provided by a library, I'd leave it as is in the lib dir.
callback про fail можно писать третьим аргументом к `q.when()`
* What's going on here? Three different autoload files? If one gets required (the first one, with no assertion) shouldn't the second one (with vendor) also work?
* I think you misplaced the @. 
* Also could you strict check? ``` if ((@include_once __DIR__ . '/../../vendor/autoload.php') === false) ```
Mix them up  and pass the 50% to the constructor, with defaulting to the effect value if no pct is given.
No, the API changed in JB.
On Nov 10, 2012 2:02 PM, "Moxie Marlinspike" <notifications@github.com>
wrote:

> In src/org/thoughtcrime/redphone/call/LockManager.java:
>
> > @@ -112,4 +193,11 @@ private void maybeEnableKeyguard() {
> >        keyguardDisabled = false;
> >      }
> >    }
> > +
> > +  private boolean keyguardLocked() {
> > +    if(Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN) {
>
> You mentioned incompatibility with Gingerbread. Should this be a compare
> against Honeycomb then (to include Honeycomb, ICS, and JB)? Or maybe to be
> more specific, it should be <= Gingerbread return true?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WhisperSystems/RedPhone/pull/60/files#r2091543>.
>
>
please use dashed in XML to be consistent
thanks for the PigServer test. 
being able to inject a in-memory relation would be nice (a case for TestPigServer). I would be very surprised if that is possible now.
will check if it is available. 
also, does EB show up to external projects as depending on thrift-test? It should not, since it is required only for our tests.
Added comment explaining this, see here: https://github.com/zsimic/linkedin-utils/commit/16234ccfdf0462d978c24413c79db434e65bb501
Maybe add this already when the variable is created.
Done: f4677a8
`MessageHandler* handler` here and below
After this, copy the `.txt` file over to the new folder, rename it to `bookid.filetype`
Lagrange multiplier ?
delete line, not relevant ?
I'd like to avoid introducing spurious whitespace / blank lines like this.
We should spell out what is accepted for PERM. Also wondering how hard it would be to support a comma separated form to set multiple perms in one call:

knife acl add OBJECT read,update group NAME
Also, why don't we need the OBJECT type here? OIC, we do :)
Not sure if this was intended to be checked-in, if so we should just remove it instead of commenting it out.
I agree with removing them.
But, if you're busy, I can do it?  (probably without breaking anything :)  Let me know what you prefer.
This is a bizarre method. Nobody in Java wants a method that returns false if it didn't do what you asked it to. That's File.mkdir() ridiculousness.

I think you might want to just set the size and then enqueue a worker to do any necessary trimming later:
  executorService.submit(cleanupCallable);
opened as #1455
Why remove this comment about slf4j version?
Recommend splitting really long lines, particularly if there is a nice split point such as the new sentence.
128 char max line length is a good guide.
Yes, there are still some incompatibilities regarding properties vs. getters/setters.
JSB uses mostly setters/getters while ChipmunkJS uses properties.

Let's use properties where it makes sense, like this one.
For this particular case, I already added `maxForce` as a property. If it doesn't work, let me know.

https://github.com/ricardoquesada/jsbindings/blob/master/src/js/jsb_constants_chipmunk.js#L299
Why not just AgentsHealthService?
Note BaseIdentity already extends NameIdentity, so ExtendedIdentity is not taking on additional functionality (namely getName()) by extending FirstLastNameIdentity (which extends NameIdentity).
그리드 리스트로 바꾸겠습니다.
Also, shouldn't this end bracket be down around line 262? We don't need to reinitialize the factory contents on every request, right? Or does WCF do something idiotic like reset the factory after every channel is created?
What happens if verification fails? Exception out to the Powershell host?
Setting the refcount by hand should not be necessary ever. What's the reason here?
I don't have a node called wisky...
Not all names split up cleanly into first, middle and surname (and the meaning of these isn't even clear across cultures). It's generally considered better practice to have a single name field and then something like a shortname or nickname field. This error is so common though feel free to leave it unchanged since people are so used to working around it.
I prefer to reserve message expectations for cases where any side effects or state changes happen upstream. In this example, a stub would tell the story just as well since the literal `"formatted-backtrace"` appears twice in the example. Subtle, and subjective, I realize. Don't change it if you feel strongly about it.
Deixar a url para o static dinâmico
You should always use their namespace rather than the service's, no? Otherwise we are going to cause some bad things.
Remove `print`.
What problem does this change solve?
That's possible, but enabling it for every block on testnet, will cause the current testnet chain to become invalid. I prefer switching testnet somewhere in the past, but after roconnor's tests.
Erm... can we de-derp the wording?
And here too for both top-scope variables.
ja die allarmierung ...
Feedback = komme ja/nein .. ?! finde ich nirgendwo da wieder ...
Ooops, sorry... dammit
Yes, sure - how can I comment that one in the pull request?
Or do I need to push to my master with a new commit?
Первый параметр в assertEquals - это то, что ожидается.
Странное условие. Если заменить все предыдущие на if () {} else if () .., то здесь должен быть просто else с ошибкой.
Order of operations should be fine here without nesting parens.
a% ;)
Same here with $mobile-landscape-width
Not bug, it just does take in consideration your other code that you trying to push in and is not part of dev therefore no reason to do what you ask since I work only with person that was forwarded to me by calling activity. As I said do with this commit as you wish
「利用することもできます」を「利用することも可能です」としてみましたが、いかがでしょう？

次のコマンドは@SimpleController@という名前に対応する全てのテストが実行されます。ワイルドカードを利用することも可能です。:
does this render ok when you just call the example on the command line?
and it's also wrong since it should be max_iter_strong
I would move the above to the constructor parameter section.
IIRC the lack of spaces here is intentional.  There isn't much point in changing a just single occurrence of this expression.
please rename to blackberry_ndk here as well
Fewer memory allocations
I think this file should be renamed to start with Native, to keep with the current model
should be blackberry, instead of 'backberry'.
Also say for method appendRow, since we don't implement it mark platforms as [android, iphone, ipad, mobileweb], and so on for others.
variable name, please use either the past tense "bSucceeded" or the name "bSuccess"
should `.gitignore` it
Some reason the valueForKey check gives an array back, with one value containing: <null>. eventough the result itself has no issues. Have to look into this. so do not merge.
Maybe, somewhere, check if there's actually anything to rollback.
ok.  I'll also add the getExpectedFootprint() function.
I'm assuming standalone are the ones started on command line, normally for testing, so no speed issues. But it does look like a far-fetched assumption.

Does ```runOnce``` get all cases where it's ok to use dynamic files?
Do the tests really require this to be installed? That doesn't seem quite right.
Note the above is removed from expected output because it's expired (to test that expiration detection is working)

I think we could do a much better test here, but I'd rather leave that til we get rid of currentversions.
{filename}~ is what emacs uses for files that are currently open, while vi/vim use .{filename}.swp
In case the signature is used for other things, you could make this test into:

```python
ok_('value="myFunctionIsCool"' in response.content)
```
@wbamberg I think I misread / misunderstood it when I wrote my comment. Feel free to ignore this.
It would be usefull to add a link to `display-a-popup.md`, as it show a complex usage of this.
yeah, that's good, don't be sad! I actually submitted the patch to fix this in less :D
sure... i'll do that in all occurrences in this file....
(not modified)
oh well i guess it should be compared to EmailMessage.objects.filter(creation_time__lt=start)
doesn't really matter i guess, mainly talking style
is this the correct creds? In today's test this account didn't work on your ci system. 

would you please use a data provider for this as well. Following our checklist we want data parameterized so that in the next test for this same test class you can reuse the data and when you need to make changes you will only need to make it in one place.
Can you try using `lookup_value` instead of `value` or `entity_value`?
leave it if you want  - but I think it is unnecessary - it is so basic construction
this is not related to any search functionality, only to (personal) style preferences, should not be a part of functional patch
It's a USER cmd overflow and [\x20\x09\x0d\x0a] are allowed? crazy... and doubtful
86992 : PhpTax drawimage.php icondrawpng() Function pfilez Parameter Remote Code Execution
oh wait... now I see the problem ^^  thanks.
._matrix ?
I based my code on this existing piece https://github.com/thoughtbot/shoulda-matchers/blob/master/lib/shoulda/matchers/active_model/ensure_inclusion_of_matcher.rb#L99

In there, only a blank value is checked. I'm not sure on the original intentions, but it looks like that is expecting one to be explicit about what values to allow. Any thoughts?
You're doing `slice(1)` twice here, which allocates two new arrays. You should move this to a local variable:

```javascript
var autoExpand = this.store('autoExpand') || false,
    additionalRecords = records.slice(1);
```
I'm not sure that replacing `[]` with `undefined` is the right design decision.  This removes a check in the renderer, right?  What other benefits does it have?  The downside is it forces primitives to either allocate an empty array or keep an empty array around to return.  From a primitive-implementation view, it is less painful to return `undefined`.  Given that we will write a lot more primitives than renderers, we should move the pain from the primitive to the renderer, right?
This is a bit awkward. It makes our "main function" look like a method of Raphael.
It's a solid idea but there isn't a strong advantage in using fstatSync in the way described.  Setting the file handler to undefined is simple and faster than exception handling.
Missing comma,  should be "For more details, see"
Links to the guides should use /latest/ in place of the version and omit the "index.html". The API doc build will fix up the link, but in case people use it in other forms, this should keep it working. 

I've added this to the style guide:

https://wiki.appcelerator.org/display/pe/API+Doc+Style+Guide#APIDocStyleGuide-Links
always open braces in the new line
should this version number come from somewhere (i.e. not hard coded)?
lets also validates that translator can have only one translation per key
We can always mitigate the long names by using closures, although the dot natation would still be needed.  So:

```javascript
(function (o) {
  o.tick();
})(Really.Long.Nested.Namespace.Goes.Here);
```
I believe the way JS works to by having separate modules pre-processed together.  There are many options.  One that I know of is: http://js-preprocessor.com/  I guess since we are both learning more about all this building API/library business, this project will be improved via step-wise refinement, instead of preplanning all this stuff.  I think this pre-processing step is worth looking into.  

I'll commit my changes sometime during the day.  I have to get to work, before my bosses call me out, hehe

Let me know when you've finished refining so I can take a second look.
I thought hosts.defaults was the 'new' way, correct?
s / if_header_firefox_logo_visible / is_firefox_header_logo_visible
Theoretically it might make sense that all OutputRanges should be reference types. But the new std.digest ranges are all value types. std.digest is designed to avoid allocations where possible, so you'd want to have those ranges on the stack. And as allocating classes on stack is cumbersome I've used value types / structs.

AFAIK there's no clear statement anywhere that OutputRanges must be reference types. I'm not sure what's the best solution in this case, but currently 'copy' can only be used with a pointer to a Digest struct and that kinda sucks.
You meant: `ParameterStorageClassTuple!emplace[1]`
Probably a good idea to move this to DimesnionManager not MinecraftServer
パターンにマッチしておらず、fallbackが設定されていない場合に適切なエラーメッセージが出力するかどうかのテストです。
VERBOSE=1 rake testで確認しました。
Согласен. Будет время - поправлю.

А overkill я тебе в следующем коммите покажу - надо мне ещё одну штуку прикрутить.... :))
upsi :-)