labofsahil/github-event-dataset-2012 huggingface dataset:
It's funny. I did use single code in my first version of this (somewhere in the same file) and Peter F. wanted me to strictly follow the coding policy (and no exception here). So I don't think we should revert it back to single quote for readability or  avoiding the escaping.
Having a promise for each resizable panel is an interesting technique. Logically it makes sense, but I am wondering what are the memory and performance implications? Most people will never resize panels. Of those that do, I suspect most will resize them once and never change the size again. Can the promise be created on mouse down and then resolved on mouse up?
Add a default ``return`` case here?
Do we want to get emailed? If so you can use notify_exception from dimagi utils
you can use {% empty %} for this construct: https://docs.djangoproject.com/en/dev/ref/templates/builtins/?from=olddocs#for-empty
keep trailing commas (for diffs)
Even if you didn't write it, I'm pretty sure you can explain what it does. Would you mind to write some javadoc ? :-)
Where does this class come from? Some comment as above about copyright.
Huh I actually never used lambda before so I haven't taught about that. But it's good idea and it works. So i fixed that. What about updated_time?
How do you consider this idea: http://www.b-list.org/weblog/2006/nov/02/django-tips-auto-populated-fields/#c2650
Indent. XHTML valid?
Be more verbose: *Invalid upper_limit arguments.*
OK, leave as TODO for now.
Well since it is ``default function``, probably not, right? :) So i can remove that function.
https://code.djangoproject.com/ticket/18034
Why set this to false?

Is the checkbox deselected? If not, is there a reason for this?

You can make it so this value only gets changed when the checkbox is clicked.
That's frustrating. I thought just changing the bindIP to localhost was enough.
This `else if` looks like it hides a bug.  Above you check if innerDiv is there, and if status is OK.  Could you have a case where status is OK, but innerDiv is null?  If so, you'll enter an infinite loop, I think.  Probably you want to separate your innerDiv check from the status checks.
We do not, but I thought it made a lot of sense as a form of documentation.

In retrospec, it probably is a bad idea because we then have to support it.
is this line necessary? includes the `return false` below too
Should this be `// A vertical scrollbar may be added....`?
Should not be a space between the exclude and the >
Very much agree about making the erchef cookie something set in config.

Please change the node name for this script to be `reindexer@` or similar. I tend to use `me` when connecting and don't want to see that getting used by scripts and such.
Fair enough, it would be quite easy to swap it back to a non-extension method. Just figured that in this case it was more descriptive if used in such a way given how it would be used in practice.
Will definitely keep that in mind when adding stuff in future ;)
could -> can
So I haven't written a lot of JS code, only from time to time over the years. But I've seen so many different styles, and people seem to be passionate about many style things (e.g. semicolons).

That beeing said, I'm fine with both ways.
I would feel safer with 4096 in that case, even though that is not the greatest. I can't think of a way to get this except to compile a C program and have it print the value. Perhaps there are better ways.
Did you mean to leave this console.log ?
I think isnot takes 3 arguments, doesn't it?

I'm doing this test in an if statement because I don't want to generate extra passes.  But I do want to generate a failure if it fails...
They were incorrectly indented... I fixed it while adding the lined prior.
Why are you doing this? This is unnecessary code.
Same thing with `with` here.  To use a with statement with a one of a number of different objects here, one might need to break out this `if` block into a function, and then use `with get_file(table) as fd:`
Hah, I like this part of the test
Same as above. Cross-node call here that defaults to 5 second timeout. Is 5 second timeout reasonable? When this call fails or times out, is throwing an exception and crashing acceptable? Or better to catch and return some error?
Oh - good catch, this case was also unnecessary … but it was the one above that should have been removed. ;)
bidder_id
The very top section is specific to the CLI - the rest discusses task types, packages and recipes, which focus on the main library.  

My view is that the CLI should be self documenting when you use -h so I opted not to add a further section dedicated to the CLI.
Rather than defining an explicit test subclass and removing the constant after, you could create an anonymous subclass:

```ruby
let(:subclass) {
  Class.new(Hash) do
    include Hashie::Extensions::TrackChanges
  end
}

subject { subclass.new }
```
Thomas,

I have made some new commits which introduce the beginnings of windows
support. I decided to check sys.platform and handle env activation
differently. Haven't tested on windows, since I don't have a windows box
handy, but the Linux part is still functional and passes all existing tests.

As per your suggestion I have also added the programmatic creation of a
test env just for running the tests which gets deleted on teardown.

I'll appreciate any comments as usual.

Flávio

On Sat, Jun 9, 2012 at 12:28 PM, Flavio Coelho <fccoelho@gmail.com> wrote:

> I think you are right, but I am going to have to remove the dependency on
> bash anyway, to make it work on windows.
>
> cheers,
>
> Flávio
>
>
> On Sat, Jun 9, 2012 at 10:35 AM, Thomas Kluyver <
> reply@reply.github.com
> > wrote:
>
>> > +    =====
>> > +    To activate this magic just write at the top of the cell:
>> > +
>> > +        %%virtualenv my_env
>> > +        import sys
>> > +        print sys.version
>> > +
>> > +
>> > +    """
>> > +    if not os.path.exists(os.environ['WORKON_HOME'] + '/' + line):
>> > +        print >> sys.stderr, "Environment {} does not
>> exist.".format(line)
>> > +        return
>> > +    env_activate_cmd = 'bash -c "source {}/{}/bin/activate && python
>> -"'\
>> > +    .format(os.environ['WORKON_HOME'], line)
>> > +    cmd = shlex.split(env_activate_cmd)
>> > +    p = Popen(cmd, stdout=PIPE, stderr=PIPE, stdin=PIPE)
>>
>> You're effectively recreating `shell=True` by using `bash -c`. But the
>> vulnerability the docs mention is about untrusted input injecting shell
>> code - which we don't need to worry about, because the notebook exists to
>> let the user run arbitrary code.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/ipython/ipython/pull/1891/files#r955665
>>
>
>
>
> --
> Flávio Codeço Coelho
> ================
> +55(21) 3799-5567
> Professor
> Escola de Matemática Aplicada
> Fundação Getúlio Vargas
> Rio de Janeiro - RJ
> Brasil
>
>
>


-- 
Flávio Codeço Coelho
================
+55(21) 3799-5567
Professor
Escola de Matemática Aplicada
Fundação Getúlio Vargas
Rio de Janeiro - RJ
Brasil
well, str(foo) will equally fail for `foo = u'é'`.

`print` is tricky - unicode strings seem to be special cased that it doesn't call `str()` on them. So you lose the ability to send it directly to `print`, but that doesn't seem like a particularly big deal for the innards of the prompt system.
switch to guava eq/hashcode
small nit, but emptySet is mutable?
listAttachmentsOnServer
can you take out the commented line here?
We don't use it on Windows at all. We use Windows' http library
Hmm, now I am confused. Shouldnt this one be `question_num_votes__lte`?
Oy. I think I switched it to selected, then undid it by accident when I undid some other code. Bah.
I would prefer an expect.throws here so that we have results from the last expect.ok call too.
the changes to this file belong to the next PR and were inadvertently included here.  Rather trying to correct the commit, I'm going let this change stand.  The next PR will expand on these changes,
Test ???? :)
Why does it have to be a tuple? Are you afraid it might be changed?
To je docela divoke zarovnani.
I suggest renaming this, since `Exception` is a reserved word.
`SparseArray` + `hashCode()`?
and you should register the listener lazily as this is supported in DoctrineBundle for 2.1
And you should use `url` instead of the `path` function to also include the host and scheme.
what about 
```
$width = max(array_map('strlen', array_keys($heroes))) + 2;
You could also do like this :
``` php
$renderer = $this;
$set = function($key) use ($renderer, &$themes) {
// ...
}
```
``0 === $n``
It should go into the CHANGELOG of the FrameworkBundle in the 2.2 section.
As done with the event dispatcher code, let's ask the original authors if they are willing to let us release this code under MIT.
Newlines around the `expects block`
这个数学公式我觉得已经十分简单了，不能再减了吧...
should probably mention that if it's NOT set, it will simply render JSON
Да удалял бы уж, чего там мелочиться)
`preg_match()` seems overkill here. How about `stripos($tmp, 'http') === 0`?
Perhaps my celebration was premature ... these aren't really unit tests. 

Let's pair on these tomorrow, and get you fully indoctrinated ;-)
It's set to the context when the template is rendered, see http://jsfiddle.net/pangratz666/Snd6n/
Good and simple ;-) 

Only one small thing - these DUPs can be added in the same step
We need to figure out a strategy for dealing with this managementSubsystemEndpoint thing.
An expression and ModelType.LIST are not really compatible.
That will need to go into a separate pull request, this pull request is just adding the dependency.
`uniqueId()` call isn't necessary here, as menu already does that for each item.
Looks like you're nesting multiple if-statements without else-statements, could just merge those with `&&`.
Don't align operators.
Look this too. This is why app fullscreen prompt is not shown.
Also, I just tried to click a folder item which it already selected, but seems no highlight effect (blue background) on it, please also handle the selected item.
Do you mean change 875 to false rather than true? I tried that but unfortunately the withAnimation argument is overloaded to mean other things too. As you point out, the logic in line 729 is weird and means if withAnimation is set to false, the icon doesn't get added to the right page.

So the question is do we want to re-factor this completely or leave it roughly as it is?
We could reuse some info retrieved, @fcampo is working on it for the next PR! ;)
IMHO this should be loaded from a JSON file
Doh you are right, sorry for missing that
Nit: I liked the comment and the former function name
Please use `shortDateTimeFormat` instead.
Do you need the `a` bit?
@filipewl, modified to span. ec44b4d279
Updated version and other information in new Info.plist.
Perhaps change this to more useful output?
The test doesn't call your new method. Was that intentional?
because i want to let it rasterize in two phases?
I don't understand the Fields type param here. Are you using or contemplating using Sortable in some context where cascading Fields aren't used?
You don't need them.  We are not consistent about requiring them in code review.
I think it's better to name this just "html" for simplicity, since there will be no `outerHTML`.
A title would be nice to explain wtf does that "Error" mean.
I suspected that was the case, but I bet future you and future me may not make the connection, I think using 'git' and 'zen' would be much more clear.
Might be worth adding a pre-amble to these virtual functions:

```c
assert(NULL != self);
assert(NULL != self->class->writev);
```
This looks like you have tabs instead of spaces here. Also further down.
this `addChange` call still passes `category`, but you've removed that argument from the function itself.  The tests don't catch this because you didn't remove it from the same function in `fakedb`.
I don't like the ```isinsance``` too. 
The other possible option is to have another set of filters for the multiple values attributes. I don't like that either.
Ok I had that request from multiple developers.

The problem is, everybody is using different aliases. They are personal and specific to the project we are working on. I undersand this is useful though.

The cleanest way to do it is through oh-my-zsh integration, and the usage of plugins. I will find a way to integrate it to our dotfiles, but for now, we won't integrate these to the dotfile.

I will try to find some time this week to integrate oh-my-zsh to our dotfile config.
nope, it's in post.haml, seemed crazy to me too, should I just move it to the header?
script functionality has been embedded in config.in... fixed
Ok. that's something I can work with, thank you. Will look into that :)
Currently I only keep the file->peattrib allocated if the file is a PE.  Looking for a non-null value is the condition for whether I log the PE header info in pescan.log later on.  I do free it in file as well when its non-null.
This change would break backwards compatibility, which we can't do without a deprecation period. To get this change, I think the right thing to do is to add a new function, exti_attach_callback(), instead, which takes a pointer to a user-allocated callback. This saves space for the common situation where the user just wants function pointers.

We can then modify struct exti_channel so that .handler is a void* instead of a void (*)(void). We can then add an extra byte to tell regular functions apart from callback pointers. The IRQ handlers can then check that byte and use it to cast to either void (*)(void) or a callback. That lets us keep NULL as the invalid value.
It would be easier to understand for 99% of people by using `event` as argument name and then: `event.subject.wrappedJSObject` and `cleanup(event.data)` (or `let unloadReason = event.data; cleanup(unloadReason)`)
That's not a documentation about destructuring.
I could swear it worked earlier. I judged `instanceof` to be more proper than checking `name`, but you're right that it doesn't work.
Please use `CfxError.prototype = Object.create(Error.prototype)` as `new Error` is not quite right.
This is something that already exists in context-menu, I decided to leave it to avoid breaking any potential consumers. We can remove it in a follow-up if it makes more sense though
No main module is defined by CommonJS.
I think you misunderstood my suggestion, I was suggesting to make up a stack from `Error().stack` if thrown error had no stack. So this else clause should no longer be necessary.
Is the parsedCert['public-key'] || ... to deal with both old and new public key formats?  Is there a sunset period on old certs and this code can be removed eventually?

If the code can be removed eventually, a // BEGIN TRANSITION CODE, // END TRANSITION CODE have been helpful to @lloyd and I to keep track of code that can be removed.
I say put it before the body close tag after the footer just like doing it in index.php
This is fine, the lock file just specifies exactly which versions of all the dependencies have been installed. I guess lock files may/should be ignored for libraries though. The main benefit is really for applications and teams working on the same project. In this case there is little value to it, and it can be in .gitignore.
That is a totally viable solution, provided we update all our own applications.
Ah.  I don't mind; I wanted to give the extra context, and let you decide if the comment should stay, go, or change in response to that.
No, it is public to mirror the API of the YAML terminus, and the general policy of Puppet, which is that we don't use the weak public/private distinction in Ruby.

I have no idea what you mean about "it being extracted out" in a way that allows testing alone.  Can you explain?
You should probably use Forwardable and `def_delegator` to provide these direct delegations.
Seems you got the wrong branch for the fix. Please rebase it to the code-style branch for merging.
Waiting for PR to be merged.
s/Default/Custom/
The changes in this file are backwards *incompatible*  and cannot be made in ZF2.
even better, just
```ruby
labelIds.split(','),map {...}
```
because split of empty string returns empty array, and map on empty array returns just the same empty array
Looks like a GIT derp.

It still compiles, still runs, just GIT thought the '}' moved...
Unnecessary parens?
Why new line here ? It don't increase readability...
Mis-spelled. I'll take care of this when I add my changes in top.
A+ for doing it in one line, but it's not especially readable
I think the name of this method is not so good, because there is nothing "true" about trueUnits. Or is there?  Alternatives that come to my mind are "isCollectableUnit" or "isSelectableUnit"...
Here, you can rewrite the entire `if/else` block this way:

```php

if ($options['persist'] && is_array($data)) {
	$data = array_intersect_key($data, array_fill_keys($options['persist']));
} elseif (is_array($data)) {
	unset($data['password']);
}
```

Do that, squash the commit, and re-point this at **dev**, and I'll get it merged right away. Good work on the test case!
What is the point of this loop?
I guess that will probably fine, I was just figuring that if I had the extra piece of information, no reason not to pass it along.  As right now I forget what additional pieces of information is passed with the response, I will have to take a look to see if I think it might be useful to have those pieces of information or if it is never going to be useful.  Any other reason not to pass the extra data besides the response data (was just of the mind that it is better to pass that data if I already have it and not need it then to not pass the data and need it)?
C'est le phénomène vendredi soir, sûrement


Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Friday, October 19, 2012 at 7:00 PM, Sébastien Saunier wrote:

> In lib/passbook/pkpass.rb:
> > manifest = self.createManifest > > # Check pass for necessary files and fields > self.checkPass manifest > > signature = self.createSignature manifest > - return self.createZip(manifest, signature) > + > + if options[:as_file] > + return self.createZip(manifest, signature) > + else > + return self.outputZip(manifest, signature)  
> Je ne vois pas trop comment ça peut marcher, tu passes 2 arguments à outputZip alors que la signature de la méthode en prend 3. J'ai loupé quelque chose ?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/applidget/passbook/pull/1/files#r1892213).  
>  
>  
>
En tiedä mikä se iffi on. Muissakin iffeissä oli sama, joten jätin sen osion copy pastesta.
is it really a failure case ?
What am I missing? https://gist.github.com/2380007
shouldn't this be ```$value !== "regex"``` instead ?
which line=
add docstring: """Custom sanity check for MrBayes."""
We should be doing it everywhere... 

Let me fix that as well.
Wrong indentation (should be 4 spaces).
Did you want to use `#profile-info dd` instead of all `dd`s? (I'm thinking yes?)

The headers use Open Sans Light? Interesting.
Instead of `reverse('profile.edit') + '#services'` you should use the `urlparams` filter:

```python
redirect(urlparams(reverse('profile.edit'), fragment='services'))
```

Depending on indent, you might need to use temporary vars to keep the line length requirements:

```python
url = reverse('profile.edit')
return redirect(urlparams(url, fragment='services'))
```
My bad, i'll fix this. What is currently happening with our players is that we remove the widget itself, so I'm planning on doing that
1. This won't work - model/typefmt.py is used by all backends. If SQLAlchemy is not installed and, for example, MongoDB backend is used, Flask-Admin won't work
2. In PyMongo models are ``dict()`` objects, that's why it is doing ``model.get()``
Fix indentation (4 spaces for a tab) and number of blank rows.
Leftover from Wordpress?
Pro-tip on github flavored markdown - you can make something look like code by just doing backticks:
`if content_for?(:interstitial) .card_container .card = yield :interstitial`
General convention check, and the answer may reflect an established rule we should add to documentation.  But, in some places we uses 'px' sizes to denote a specific sizing, in other we use percentages for a relative sizing.
If you only have one element in a hint, you don't have to wrap it in a `<div>`
I don't think these casts are actually required.
No braces here, please
Use $uid as string
I'd move all the css to bootstrap_and_overrides
Again - I think you can use a table,merge to avoid the sort - sort(,number) will be particularly brutal on a big machine if you have relatively few fields
Well that works now ! I updated my pull request... A space was missing.
On Jun 12, 2012 9:39 PM, "Jean-Philippe Boily" <
reply@reply.github.com>
wrote:

> > @@ -1,5 +1,7 @@
> >  module Monologue
> >    module ApplicationHelper
> > +    #NUMBER_OF_LABEL_SIZES = 5
>
> Rails probably do something with those modules and wraps them in classes.
> Maybe you could just use a variable from inside the method for now and add
> a TODO to clean that up. We should do a cleanup round before releasing
> 0.2.0 anyway. Opinion? I just don't have much time and I am about to leave
> for a few days...:)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jipiboily/monologue/pull/83/files#r973094
>
This glob might need to be changed to configure.*/* if it supposed to glob over directories and not files.
Awesome. I was thinking that once this was simplified to this point, `Template` becomes sorta useless and could be merged with `Page#render` in a `Render` module that gets mixed into `Page`.
You should remove "text"  and the method call for text in this property.  

You can then remove the method "license_faq_click" and change the text so that you call the property then click license_faq.text or license_faq.click in the test.
can we make this file 2 space indent since the rest of the files are? :D
These should be `g_warning` calls so that the application can intercept them with `g_log_set_handler()`.

(In the long run we need error reporting through the API, but for now...)
The description itself wouldn't influence experienced developers .
This is something that other, well established, API docs tend to do as well.

Having `@param  {Content[]}   callback.contentObj   Retrieved Content objects` is clearer than `@param  {Content[]}   callback.contentObj   Retrieved Content`.
Maybe this method can use something like http://underscorejs.org/#extend to perform all the extending?
``private``
It's in a separate commit :) I still think we should not wait for the indexer when asking for completions.
this line should not be used. sorry
I'm a bit uncomfortable at how untidy this method looks
А почему он остановится на нуле, а не продолжить уменьшаться в -1, -2 и так далее?
ты - это хорошо. Но контроллер будет другой :)) потому что vote я бы делала отдельной моделью с полиморфной ассоциацией к вопросам и к ответам. Со своим контроллером
Filters are controller specific by nature, from Rails guide: 'Filters are methods that are run before, after or “around” a controller action.'  Other than namespacing the filter 'Tim::Filters::UserKeysFilter' I'm not sure there's much that we can do to prevent it from being "App Wide".

I'm happy to revisit this later.  In fact I'm hoping that we can remove a lot of this code when we do two things:

1) Represent the Template XML using ActiveRecord Models (rather than storing the full XML)
2) When either:
   a) Rails supports users keys
   b) We add in strong params in Rails 4.
hehe :D I still need to find the source of these damn blanks
I had to switch the two signals around to make the test pass because of how it handles errors now. Should I just delete it? I'm not sure it makes much sense now.
Agreed. Change made.
I'll get rid of the default value, this makes sense.
Pull up getByUuid, getById, delete, saveOrUpdate to a new OpenmrsObjectDAO interface. Make OpenmrsDataDAO and OpenmrsMetadataDAO extend it.
Would we care to error on duplicated entries? I think that might be a good sanity measure. Since you're building a hash already, should be too much additional code.
This should be:

    return array(
        array(
            'data' => array(
                'test' => 'test',
                'test2' => 'test2',
            ),
        ),
        array(
            'data' => array(),
        ),
        array(
            'data' => array(
                'test' => null,
                'test2' => null,
            ),
        ),
    );
请求体
请求正文
Can you pull `::BCrypt::Password.create` out into an `encrypt` method to keep compatibility with the protected (but mixed in) methods defined on `SHA1` and `Blowfish`? This way the user can call `encrypt` to encrypt strings no matter what the current strategy is.
Do we relly want to prolong the tests 30 seconds? That's adding 50% to my test time. no like
case `expected` => //All good
Should be a FIXME
BTW why do we need the default? Doesn't SPM have it's own default?
All products should automatically be cleaned by database cleaner.
Открой iinfo.h и посмотри в самый-самый низ, там дефайн с циферкой.
При изменениях API ядра надо ее увеличивать.
Написал бы хоть `auto thisItem = !item.isEmpty () ? точтощас : 0;`
Gracias, en la próxima versión de MomentDatepicker lo arreglo.
Referencing `ply` but unwrapped as `ent`
can you replace (map list ...) with what it evaluates to, since it's a constant?
I'm pretty sure it's the same lock.  In other words, you can have at most 1 [promotion|deletion] at a time.  I think the way you coded it, you would be able to do 1 promotion AND 1 deletion at the same time.  I don't think that is the case, is it?
Yes, for now
Probably. How would I commit in a way that would not mess up everything and lead to a good pull request?
You have to use the dialog object like this : 

```
                {% set alert_message %}
                    {% trans 'prod::thesaurusTab:dlg:Acceptation en cours.' %}
                {% endset %}

                var alert = p4.Dialog.Create({
                    size : 'Alert',
                    closeOnEscape : true,
                    closeButton:true,
                });

                alert.setContent("{{ alert_message | e }}");
```
please use expected !== $result, and remove extra parenthesis
Why is this nested like this? Just link to the spec for Bank Accounts
Please take care of the unused imports.
Mircea, the main thing I need here is fail safe iteration. Most Lists have fail fast iterators unless we sync access to that list. Hence CopyOnWriteArrayList to make things simpler :-)
Pls wait for removal first - this is noisy and pretty silly!  :)
I would like this to be `weak`, which would obviate any need to explicitly clear it (and therefore also to expose it as writable in a private API).

Is there any problem with pushing ObjectiveGit to 10.7+?
We still actually need to add the service hook, correct?  You're just writing this from the point of view of after this PR is merged and the service hook has been added, right?
I don't think it aids readability for a comment to cause an otherwise short statement to be split like this.
Alternatives: put the comment on a separate line (below, indented), or shorten the comment, e.g., "width, height of unrotated string".
Do you need to clear the lock after this step? 
(not fully understanding the settings API myself but just noticing the difference between this and other pulls)
@masv What are the implications of this for chef-solo? Is `search` a no-op? What are the advantages/disadvantages of this approach vs. using a data bag?

Thanks so much for the help!
So this is still 4 because it's a binding error. Shouldn't this maybe equate to `default(T)` (in this case `0.0?`)
Done in the latest commit. I am not too sure about the naming conventions and all though. It ended up in app/assets/stylesheets/_flash_mixin.css.sass

If you'd like something else let me know.
Agreed, and this is a good example of why we don't want two copies of the file in the codebase. I'll add another commit to fix the search/impl mistake.
I imagine we don't actually want `alert` ever getting through. This can be handled by the `devel` option anyways.
```C++ 
float64_t choose_feature=time->cur_time_diff();
timer->start();
float64_t t_optimize = timer->cur_time_diff();
timer->start();
compute_pred();
float64_t t_compute_pred = timer->cur_time_diff();
```

and then the printing
You don't need to pass in `{}` as well since blocks passed into methods are not really considered part of the method's parameters.  It's better if you don't pass in `{}` so that the method's default arguments will be used.
Can we fix that in a later commit, since this is just a fairly constrained refactoring?
Michael, I don't think these two lines of code are necessary: I think reconciliation returns EBUSY in this case, and I don't much like checking __wt_page_is_modified again, although I can't see any reason it wouldn't work.

Anyway, I wanted to call  out the change.
Ditto "the last half of the file", we could make it configurable, or we could change it.
Why not simply `serialize($this->file)`?
Line 43 says "if question_form_action", so checking that question_form_action isn't nil here is repetitive (you're in an if block where you know it isn't nil).  You should just be able to say :checkbox_options => {}, right?
Removed in 7fa43818723fe037819bc09eff8a9cf8a93320fb.
No, Game Maker does not believe in for fancy stuff like shortcut evaluation. It would be nice if you could test your changes next time.
also. thanks for your email on all the ruby code-analysis links. i added codeclimate and it inspired me to find and add this too!
He's not using `console`, he's using `concole`. Whatever that is.
Defining this as an slist is a bit dangerous - if, for any reason, the script got modified to remove the "if down" line, then ONLY that line would be re-added, but at the end. I think it would be best to provide this script as a single string variable, and to use insert_type => preserve_block so that it's added as a whole.
by leaving off `var` this creates an implicit global
```php
<?php
if ($pass1 != "" && $pass2 != "") {
?>
```
load would load the proxy the same way as load_from_database. The new, would end up setting the _new property to true, which would be wrong.

We truly are loading it from the database, just not evaluating what we received from the database right away.
I think that works and follows the rest of the syntax. Updated in b5a80e7
hm, do you use this bundle anywhere?
It should be because we should strive to follow best practices when writing jQuery code, even for simple functions.
You can see the pattern used here described in the jQuery documentation:
http://api.jquery.com/jQuery.noConflict/

Also one small comment regarding the documentation, I see those TinyMCE examples merely as a proof of concept on how to do things, not necessarily the way to do it.
That example used a bunch of onmousedown which are old dom level 1 events, something that is clearly suggested to not use in modern javascript.
Also they had no consideration for writing defensive code, and they just used $ on it's own expecting it to be the jQuery that is probably used on their page.

To this matter in any documentation, I feel that the thing to follow is the code that directly deals with the framework that the documentation is for and any glue code should be up to the consideration of the user on how to write it best, or if it's meant for a collaborative environment then it should meet the criterias set by that environment.
should be `DocumentNotFoundException`
Can you suggest how should i referenced it otherwise? Comment doesn't have id field.
Better, but you always have to define variables with `var`. And you do not really need aSoLongNamedFunctionHereAnyway. It is just one line. And you use it just once. Don't use a function here.

And `post_initial_state` is not a good a good name. You do not save any post state. But input box for creating posts displayed label to the user.
Here you should translate based on the number `CONFIRMATION_TOKEN_VALIDITY`. If `CONFIRMATION_TOKEN_VALIDITY` is 1, then there should not be *days*, but something else. See how this is done.

Also, end a sentence before *if it expires*.

*Confirmation token will be active ...*
Too much code then, I think. I would have to call super in accountform's init to pass the user.
No spaces around `=` in call arguments.
Add all arguments callback function receives.
This should go out of the base class. Make functions in this modules. So then you can import module and do:

```
horoscope.get_all_horoscopes()
```
this test title is wrong for what it's testing.
Actually I have no idea why it's done this way. Looks like some kind of a fail-safe mechanism. In all my testing I didn't encounter a scenario where this code actually gets executed.

Since this bit of code is getting rewritten in Python anyway, I wouldn't worry too much about it.
I vote for no semicolons but new lines or `then` instead, but otherwise yes good recommendation @burke!
This is a good example of unreadable Haskell, please stick to 80 chars, as suggested by [haskell style guide](https://github.com/tibbe/haskell-style-guide/blob/master/haskell-style.md).
Nope,  but if you want I can do it  that way
Defining ProviderWithProfile struct and SetOfProviderWithProfile class after the private keyword is misleading. It has nothing to do with private because they are globally accessible names and should not pollute the ProviderSelection::Base class. Please move them to a separate file/files.
*-to-One !? Or just to-One!?
This is indented two extra spaces.
Style here is:

    int rc;
    ngx_event_t* wev;
    ngx_connection_t* c;
    ngx_http_core_loc_conf_t* clcf;

And it's fine to define them when you use them for the first time.  For example, I think `ngx_connection_t* c = r->connection` is a bit better than what you have.
Yeah that is the change I made the day you left.
If you pull the latest it should work.

On Sun, Oct 7, 2012 at 2:49 PM, Ze'ev Klapow <notifications@github.com>wrote:

> In src/robot_dashboard/widgets.py:
>
> >      def _show_console(self):
> > -        if not self._console:
> > -            self._console = ConsoleWidget(self._proxymodel)
> > +        if self._console is None:
> > +            self._console = ConsoleWidget(self._proxymodel, True)
>
> This raise an error for me: __init__() takes exactly 2 arguments (3 given)did you change the Console
> *init*. I just checked and the version I just got from apt has only the
> proxymodel argument.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zklapow/robot_dashboard/pull/9/files#r1781151>.
>
>
These two lines (ctx.lineWidth = 1, ctx.strokeStyle = color) are repeated many times and could be incorporated into the RegularShape_ function.
I don't understand why you are doing this

Please make a comment inline
${runDir} looks wrong.
t'y vas un peu fort la. quelles industries? (pourquoi au pluriel) et qui produira le contenu si elles meurent?
Thank you David. Yes, I thought of that after the pull request ... LOL. I will add them.
You've defined `message_must_be_a_string` on `RSpec::Expectations` but here, `self` is `RSpec::Expectations::PositiveExpectationHandler` -- so I would expect this to raise a `NoMethodError` (note that your specs could still pass below due to the fact that it just specifies that an error will be raised, but says nothing about which error).

I would recommend defining this method in a module and extending it onto `PositiveExpectationHandler` and `NegativeExpectationHandler`.
Where did `appcollection` go?
const :)
i'm not actually sure what does the update function do. For the moment, this is just a fix of the old implementation so actually, it requeres a lot of work to move it in that function. In phase 2 we could do that, even if i'm not sure on why this would be better.

Let's just move it at line #50 for the moment.
Why 101 and not 100?
typo:  == b.set()
(d)arf typo, you right
i only fixed that section of code
*SHOULD* be 80 characters or less, I think readability trumps that.
Возвращаясь к разговору о переписанных на питон функциях. Переписал src_files и header_files на VimL. В принципе избавился от внешних зависимостей. Получилось вот что.

``` VIml

function s:cmake_project_find_files()
    let currentdir = getcwd() . '/' . g:cmake_project_build_dir
    let dependencies = globpath(currentdir, "**/DependInfo.cmake")
    let internals = globpath(currentdir, "**/depend.internal")
    let result = []
    for depend in split(dependencies)
        if filereadable(depend)
            for line in readfile(depend)
               let filename = matchlist(line, '\(^\s\+"\)\([[:graph:]]\+[.c|.cpp|.cc]\)"')
                if len(filename) > 1 && strlen(filename[2])
                   call add(result, filename[2])
                endif
            endfor
        endif
    endfor

    for internal in split(internals)
        if filereadable(internal)
            for line in readfile(internal)
                let filename = matchlist(line, '\(^\s\+\)\([[:graph:]]\+[.h|.hh|.hpp]\)')
                if len(filename) >1 && strlen(filename[2]) && match(getcwd(), filename[2]) != -1
                    call add(result, filename[2])
                endif
            endfor
        endif
    endfor
    return result
endfunction

```
all these should be boolean nodes.

and you can use ``defaultTrue`` and ``defaultFalse`` to be shorter
world scroll accessors?
Ar trebui verificat intai daca exista name si value si apoi sa le pui in dt.
Map here ? (e.g. like in HttpRestProvider.java)
Функция очень перегружена. Есть такая практика, что обработчик события должен быть максимально разгруженным буквально пара строк.

```
addButton.addEventListener('click', function(event) {
    doFirst();
    doSecond();
});
Oh - you did it here :) Cool!
@klrmn are they long days? :P
0.1.1 maybe?
Your model is still learning?
Please add support for scipy sparse matrix input as well by using `sklearn.preprocessing.norm` with `copy=True` instead of expressions such as `(X ** 2).sum(axis=1)` that only work on numpy arrays.

New tests for `scipy.sparse` inputs are required too.
On Sat, 2012-10-27 at 11:25 -0700, Olivier Grisel wrote:
> In my opinion, it would be worth stating explicitly that the score is
> not very sensitive to the regularization strength alpha on this
> dataset hence this fluctuation of the CV tuned alpha is expected.

I agree with you. Should I change this and submit a new push request or
will you push it directly to the main?
1/n_features will be equal to 0 if n_features is an int which it should be
One point - I am not sure that we really need to keep manually concatenating Strings to create URLs that are IPv6 compatible - generally the URL and URI constructors that take the different components of the URL will handle the correct wrapping of an IPv6 address when assembling the complete URL.
This one doesn't really need to exist.
Yeah I can document it better, but the reason I've kept it short like that is to avoid the text wrapping to the next line (some terminals might even hide the text if it's longer than some hardcoded limit like 80chars). If that's not a problem I'll add the full explanation.
Instead, the body should be:

    return Type::toCtype();
`internalData_.size() - 1` is a valid offset (ie the last character). Either take out the `-1` or change the `>=` to `>`.
Trivial: Date type in js is with a capital D so the message should reflect that, can be done at merge time
use const_iterator
Flag name is too vague. What about these deps? Could mean many things. How about "check-missing-intransitive-deps"?

Also, can you add a comment that this flag my be removed once codebases are in compliance, so we can make it always an error?
I agree with you. A strcpy() fits better here.
The first iteration of the code did that.  However that is confusing because if you say

myModule.sharedSymbol

you get an error sharedSymbol unknown, rather than invalid access to sharedSymbol.  So I changed it so it would return shared symbols all the time if the module was explicitly given, and then complain if it was illegal.
Found it, in thcsvread.cpp.
Not sure why you're iterating here.. 
why not just :

> INode *node = nodeGroup->queryNode(slaveNum);
Judging from how you name your variables, do you perhaps want to do `date = datetime.date(2012, 1, 2)` here?
Also test that the file was sent to the storage system, right? Not just that it got deleted. Your code could have been a LOT simpler and still passed this test :)
I think what @ochameau suggested is to have file path for this snippet of code be displayed somewhere on top of it.
add a description to this line for appointment box. so appointmentRequest could be appointmentRequestBox or appointmentRequestDialog
We should make `/insights/` redirect to insights, for search engine reasons. Find if InsightsOverview or InsightsDetail does that, but technically we shouldn't serve off both.
Oh, and the result of get_by_key_name will be None?

On Wed, Oct 3, 2012 at 12:03 AM, Kunal Mehta <notifications@github.com>wrote:

> In datafeeds/datafeed_usfirst.py:
>
> > @@ -103,6 +106,21 @@ def getEventRankings(self, event):
> >          url = self.EVENT_RANKINGS_URL_PATTERN % (event.year,
> >              self.EVENT_SHORT_EXCEPTIONS.get(event.event_short, event.event_short))
> >          return self.parse(url, UsfirstEventRankingsParser)
> > +
> > +    def getEventAwards(self, event):
> > +        url = self.EVENT_AWARDS_URL_PATTERN % (event.year,
> > +            self.EVENT_SHORT_EXCEPTIONS.get(event.event_short, event.event_short))
> > +        awards = self.parse(url, UsfirstEventAwardsParser)
> > +
> > +        return [Award(
> > +            key_name = Award.getKeyName(event, award.get('name', None)),
> > +            name = award.get('name', None),
> > +            team = Team.get_by_key_name('frc' + str(award.get('team_number', 0))),
>
> I think this was intended for some awards that technically aren't
> associated with a team, like Volunteer of the Year.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gregmarra/the-blue-alliance/pull/233/files#r1747197>.
>
>



-- 
http://grgmrr.com
860.263.9018
Yea it's calculated from alliances. Good point. No way to see 254b Wlt but
oh we'll.

On Sunday, December 9, 2012, Eugene Fang wrote:

> In datafeeds/offseason_matches_parser.py:
>
> > @@ -31,9 +31,22 @@ def parseCSVMatch(self, row):
> >          for i in range(len(row)):
> >              row[i] = row[i].strip()
> >
> > -        red_teams = ["frc" + red_1, "frc" + red_2, "frc" + red_3]
> > -        blue_teams = ["frc" + blue_1, "frc" + blue_2, "frc" + blue_3]
> > -
> > +        red_teams = [red_1, red_2, red_3]
> > +        red_team_keys = []
> > +        red_team_strings = []
> > +        for team in red_teams:
> > +            red_team_strings.append('frc' + team.upper())
> > +            if team.isdigit():
>
> Would it? WLT should be calculated from the original team number and
> ignore all "alter-egos"
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gregmarra/the-blue-alliance/pull/346/files#r2359918>.
>
>


-- 
http://grgmrr.com
860.263.9018
`(= (get author :death-year) nil)` is sufficient. Or you could do `(contains? author :death-year)`.
I only learned about Draper through this project, so I'm curious: why does `PersonDecorator` not inherit from `ApplicationDecorator`? it seems that remove the need to use `def_delegators` and to extend the `Forwardable` module.
Style inconsistency? Do you want to use value_dict['params'] = {'reverse': reverse} instead?
Its an existing production network - probably take 50 minutes to enumerate all the DCs as netenum takes about 20s to return each time.

The actual DC I'm joined to probably takes 3-5 minutes to try each of the policy dirs... 95%+ of the other Domains I cant actually find a DC for or cant connect to that DC when I do.
Nitpick, but can you use `done` instead of `complete`, for consistency with other todo implementation.
Can you use "goog.object.forEach" instead?
@mramato as you mentioned before either you or @kristiancalhoun will have some doc changes depending on what branch gets into master first.  I suspect, the doc branch will go in first.
IMHO we should add link in the template, maybe a short version like

    <dd>{{ term.definition|safe }} {{ term.url|urlizetrunc:15 }}</dd>

If there is a description, it will be add after. Else, it will be the only content.
shows up fine, it's just the github preview messing it up. Python didn't report errors wrt indentation and it looks fine in my editor, so no worries.
please add:
**since: "2.1"**
Could you remove the "is" from "is begins"?  (I know you probably didn't put it there originally.)
I'm not sure about how best to handle the lesson numbers. It seems like having them as full numbers, increasing by one for each lesson, is the most obvious and intuitive thing to do. However, the actual internals of the current lesson structure treats lessons as characters to teach, and does two lessons per set of characters, one for just those characters, and one for those characters plus all the previous characters. Thus, as far as the internals of the lesson structure are concerned, having half values is simpler.

Another lesson implementation could have an entirely different lesson structure, without the concept of "half-lessons", so it might be best to keep the external API using whole numbers. On the other hand, this could be a case of YAGNI. We'll have to talk about it in person.
Я еще пункт "обратите внимание" прочитал перед тем как делать pull request ) поэтому и не увидел библиотеку с реализацией всех штучек)
this description is wrong. It transforms into an array (which is inconsistent with the ``transform`` btw, making it likely to cause some issues)
Я бы строку вернул. Не си ведь.
нормальный аргумент после аргумента-функции - и функцей невозможно пользоваться в кофескрипте
the `.less` extension is optional
Actually, in line with getting rid of `ret`, all of these if statements should be reworked into return statements. So, this should become something like

    index += n;
    return c1 == 0xC2 && (p[index + 1] == 0x85 || p[index + 1] == 0xA0);

Most of the `if` statements inside this switch statement should go away and simply be part of a return statement, since there's really no reason to check a boolean condition and then return true or false depending on its result. Just return the boolean condition.
It's very rare case but i'm working hard with FragmentTransaction.replace() method which is a little buggy.
This looks awfully similar to `Jasmine::RspecFormatter`. Two questions:
* Does their license permit such copy-paste?
* Could you inherit from their class?
Index based queue
TTLs are not returned by the server, so this can go.
not a big thing but curious why the brackets were dropped down a line?
just `src` ?
Just a slight improvement:

    if (($_appath = realpath($application_folder)) !== FALSE)
    {
        $application_folder = $_appath;
    }

... avoids calling `realpath()` twice. Plus, you don't need to append a slash if you're going to trim it 3 lines after that. :)
Can you explain what is happening here?
Do you have a config file to setup intellij in order it formats correctly?
Isn't it better readable with two ifs? (line of code will be very long if I'll use one if)
small change to use the enhanced checking
Yes, empty arrays are allowed in C#. Their Length property will return 0.
:)  We can remove parentheses

Only use: var delta = (aniProps[scrollDir] - $scroller.scrollTop());

I wrap the value in parentheses because, for me understand that: it is one value.
`git://github.com/openmicroscopy/snoopys-sandbox-2.git`
you can remove the 'has'
if you're using `for(var i in ...)` make sure to use `.hasOwnProperty` or use `jQuery.each` instead.
I have thought to add asynchronous invocation methods (when BeginGetResponse(), EndGetResonse() used) in some future version.
It whould be awesome to add Rx versions of methods into the YapiService (Reactive Extensions for .NET).
Please add comments about why these methods are here.
I figured something like that would probably fit better in the allocators design.
Might as well, they may change over time and it's no hassle. Doesn't dirty examples too much. (Fix Submitted).