labofsahil/github-event-dataset-2012 huggingface dataset:
Also, same ambiguity around "range" here...  I suppose we could make it a bit more clear using slightly longer names: get/setSelectedRangeIndex().  Is that worth doing?
duplicate ``activeSuite``, conflicting comments
Being able to exclude a set of tests from being run in the UI would be a nice feature!
You don't need to define an empty function here. Use null instead.
Might be good to add an accessor for this to ColorEditor (e.g. getRootElement()) instead of directly accessing the variable. (In general, all the cached UI elements in ColorEditor should really be considered "private".)
Actually, I was referring to the "Live Preview Base URL" label and textfield. Do you think people will understand what it means? Is it clear that the Base URL maps to the project root?
I thought the same, but I updated the specs to reflect the changes.
You mean stub the database and test that an empty Mysql2::Result correctly gets turned into NotReplicating?
Very questionable whether it's worth memoizing this, but I guess it doesn't hurt.
Rather than require the user to use a different method to add subtitle handlers why not use the plugin.activate functionality and a plugin type. A good example would be the screensaver plugin which is a subsystem like the subtitles and uses plugin with a specific _type set during init.
See src/plugins/screensaver/__init__.py
why not also change 'organisation_unit_group_header' to 'location_type_header'? also, i think we should continue to use 'facility type' (or at least 'location type') in the survey export file, as that's the language that's used in a non-technical/real life context.
My use case is that if I'm developing and I don't have internet, trying to ping the hubs throws an exception. I'm totally open to another way to solve this if there are better ways...

I could just as easily also ask "What's the reason for pinging hubs in development and test?" Why should we be sending localhost:3000 stuff to superfeedr?

Rrrr some keyboard shortcut closed the issue when my fingers slipped....
I couldn't find a description neither for P, nor for L. Consequently, I decided to keep them as is. I just found them in some places... and decided it was important to keep the same behaviour as before.
Use either a switch with an enum or the else if syntax, for performance reason. The first solution would force you to change the management of the method value.
The second argument to ```g.insert``` must be a selector. Change ```rect``` to ```'rect'```
And don't hard-code next, use constant variable, `REDIRECT_FIELD_NAME`!
For lower limit create a constant at the top of this module, and just hard-code the year, like 1900. Not years.
Actually, I put them like that on purpose. Thought it made it easier to read which params belongs to which calls.
Don't declare these here, they are down in the image.onload function.  Keep them there.
mapType -> type. Then we could do this in a for loop ( with the exception of zoom as you say they have different zoom values for different maps )
still here too
There's no real reason why. I can make it a variable to save the extra lookup though.
space before <code>{</code>
When manifestEntry.type == "number" and editorElement.type == "text", IE9 doesn't automatically convert number to text.
Hmm verstehe nicht wie das gegen xss helfen sollte.
Oh and on the topic of 'one expectation per example', I have tried to follow that principle here.  I think it's a good thing to aim for.  I wouldn't be too militant about it, but it's a good idea.
The module name string manipulation that was occuring on L527 and L547 was really awkward. I feel this is easier to parse and will be reused further down.
Why? Remote web content should not live in the same process than the main process. Have you encounter an issue with that?
En fait il n'y a pas vraiment de raison de le désactiver... sachant que si le navigateur supporte pas HTML5, Angular passe automatiqeuemnt avec les URL avec le hash. M'enfin effecitvmenet on peut le rendre cofnigurable.
@DomKM Not sure you're question, thats what its returning with [@]popular_set (brackets around @ because github thinks its a user).
Do we need this check at all? This changes the current behavior, that you can specify the template before the first synchronization.
When merging master into a branch with conflicts I have recently found that you have to be careful due to the way the hash gets put in.  If you fix your conflicts and just 'git commit -a', the hash will be committed as it was from the branch and not from master.  
The solutions I have found thus far are: 

a) 'git submodule update' before doing a 'git commit -a'

b) Probably more proper, individually git add the merge conflicted files
it's now e with the other try/catch gone
Then the assembly locator needs to be mapped here.
This is something that will be fixed with Notifications + Background Services. Sadly I can't find a bug for background services, you should ask mounir on IRC.
Do you really need to add recentCall as a parameter to bind? It seems that it is already accessible.
It's not an execuse. Code copying should be avoided.
Nit: the exception's message sounds funny... "must be informed"? Perhaps you meant "must be provided"?
How is zip and camlzip different?
1) Format:  Unix time (number of seconds since epoch)

2) Yes, there should be a check.  See main pull req discussion, querying the best time window.
I think this should be an object rather than an array, having trouble deserializing an array of different types. And this makes it match the output of every other command better.

            Object addressInfo;
            addressInfo.push_back(Pair("address",       address));
            addressInfo.push_back(Pair("balance",       ValueFromAmount(balances[address])));
            {
                LOCK(pwalletMain->cs_wallet);
                if (pwalletMain->mapAddressBook.find(CBitcoinAddress(address).Get()) != pwalletMain->mapAddressBook.end())
                    addressInfo.push_back(Pair("account",       pwalletMain->mapAddressBook.find(CBitcoinAddress(address).Get())->second));
            }
            jsonGrouping.push_back(addressInfo);
Why are there two very similar tests?
You don't safeguard against the duration becoming 0.  If for example the duration and jitter are the same, or the jitter is greater than the duration, you could end up with 0 or fewer seconds as the duration.
casting would probably help here.
Suffixes, in my mind, are to identify the purpose of a class not its
nature. If the trait was a behavior then I would call it LogBehavior, not
LogBehaviorTrait

On Tue, Oct 2, 2012 at 9:44 AM, ADmad <notifications@github.com> wrote:

> In lib/Cake/Log/LogTrait.php:
>
> > + * @copyright     Copyright 2005-2012, Cake Software Foundation, Inc. (http://cakefoundation.org)
> > + * @link          http://cakephp.org CakePHP(tm) Project
> > + * @since         CakePHP(tm) v 3.0.0
> > + * @license       MIT License (http://www.opensource.org/licenses/mit-license.php)
> > + */
> > +namespace Cake\Log;
> > +
> > +use Cake\Log\Log;
> > +
> > +/**
> > + * A trait providing an object short-cut method
> > + * to logging.
> > + *
> > + * @package Cake.Log
> > + */
> > +trait LogTrait {
>
> You and others voted to keep file names suffixes for classes stating its
> easier to identify files in editors. So I am a bit surprised you are
> suggesting the opposite here.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cakephp/cakephp/pull/885/files#r1736281>.
>
>
You could also make it clearer that for grouping to work the records received from the text service should include layer_name fields.
this should be ``@return array``
I'll have a look and see if there was a way I could do this. Last time I checked discussion didn't have the group_id because it was just a parameter getting passed through the url that gets added to the discussion inside the create action.
I think this should actually be `put` instead of `post` since it's just updating an existing record (not creating a new one).
type? It's the type of the ship, not it's name.
Shouldn't this be a callable? `control = self.custom_control()`
ahhhh, gotcha.  Much better.  Will push in a sec
For now you're hardcoding png here.  If that's all R produces, you could skip the dict altogether and simply fix `mime = 'image/png'`.  But if R provides both svg and png, then you may want to make the format a user toggle.  The easiest way is to make it an attribute of your magic object, and add another magic that could be called `Rformat` which lets users set the value.
Shouldn't 'svg' be listed in this line?
It's missing an `import time` here.
Gotcha, will do, thanks.
This will set it globally, which might be inconvenient if the user is also using rpy2 directly in the same session. Can we set_writeconsole temporarily while we're evaluating the code inside the magic, and then put back what it was before in a `finally:` block?
Leave this as 2011.
Strikes me as a waste of a header. Do you think you could move this to `util.h`?
This is gonna choke our documentation parser. You should get it out of here, typedef it and document it there.
Let's try not to carry error codes around after the error handling rewrite.
Apologize for the delay..
I am curious why the ({a} + {b} == 3 ) && ( {a} *{b} == 2) does not solve the purpose.
Updated to `criteria.embedded? ? count > 0 : criteria.exists?` -- you still have to do something different for embedded documents.
definitely, should be more than one thread :-)
(Though to be honest, I'm uncertain if that's indicative of anything, really. The funfactory tests all pass as well, but I don't feel confident that the diffs aren't affected.)
nice! Smart!
But surely you can just do a search-and-replace of the `jds` with the full module name.
only checking the exit-code,  the user will not see the output (yet)
I prefer keeping all .rst files (apart from README.rst) in docs/ folder to keep noise level low on the root of the package.
Hey @RyanThompson, this just needs to be a language variable instead of hardcoded. Thanks!

Adam
Yeah that's how the schema's defined - RateV4Request / Package / @ID
This should still be there, as page=-1 is only an alias to the last page.
(see line 181 :read => /models/page=5"
mostly off topic, but Date is a lousy choice here. Use nanoTime ?
таблицу платежей вобще не нужно трогать. думаю скидку лучше добавлять к билетам или не добавлять вобще
це так phpstorm радить )))? імхо вже зайве
Agreed, the String name might be dangerous if it is turned into a
reserved word at some point.
@nomack84 ? You mean `else if` instead of `elseif` ? If so you are wrong, according to Symfony2 CS, look at other parts of code.
Maybe this block should be rewritten to be more clear. Feel free to make suggestion.
ah, sorry, I read too fast. That does answer my question.
another typo: ... like the following (no comma) if the parameter which handle__s the__ locale value ...
you can omit the parameter when it is 1 level
instead of break-ing just return maybe ?
Can you not remove this method from the interface if is deprecated? And only implement it in the sub classes until 2.3.
I don't know if we should. I think suggestions for tiny features like that don't make much sense, if you always end up with 20 suggestions you won't read them anymore.
this is the option name, not the variable name
Aah yeah that makes sense. Can you install maven 3 somewhere, and use the newer maven version to build?

I appreciate the pull request, but would rather not support maven 3 unless it affects a lot of people.

Good catch with updating the hdfsdu.pig version number. Actually, pig supports wildcards, so I'll change the register to "hdfsdu-pig-*.jar" to be future proofed.
This file adds a new entry in the main control panel (the webyast home page). It contains the icon, description, URL etc...
Seems like it's not testing the `@event.name`.
Right, but the test needs to be performed against the library itself -- this code catches an exception because the exceptional library isn't getting loaded, and thus throwing a NameError when the `Exceptional` name is encountered. You can replace this with simply `require 'exceptional'` (assuming it's added to the gemfile) and everything should work correctly.
What do we do if it is blank? Make one up? Reject the connection?
Remove the space before "?"
This name "linear" should not be hard-coded (nor any other color space name for that matter). When using OIIO with option OCIO build support, the name for 'linear' can actually be something different.   What is the intent of this check here? Is it to see if the conversion is a no-op?  If so, there is a simple way to query that directly from the processor.
Yes indeedy. 
Even better, you can use the path to clip images too!

:smile:
Was the code written in 2010?
```js
return QFS.isDirectory(...).then(function(isDir){
    return { name: i, dir: isDir };
})
```
Maybe put <b> bold tags around %album for visual emphasis.
Don't think this is wise.
ok ^_^
блин. Может, грохнуть тип и заново создать?
Please drop the comment and move these lines to the `# Connectivity :: Cellular & Data` section.
Does the code there need to set `this.currentOrigin`? If so, `this.currentOrigin = ...` should move to `show()` itself.
We will need to add `z-index: 1;` here for recovering the drop shadow in the search box
no need for the parameter finally. (and ns_ -> br_)
Instead of having this `clone` function could we make `MockContactsAllFields` a constructor (like `mock_call.js`) ?
Using an `<a>` make a lot of sense, as is it used to go to another view in the application, and almost all the applications that already are using this kind of lists in their markup uses `<a>` instead of `<button>`.
Can we add this kind of comment next to the function call?
aren’t we supposed to use MozTT now?
is there really no other way?
Any reason why we need to wait for fb.contacts.init for start listening the activities?
querySelectorAll ?
And I would rather do an early return.
We need a check for a false filter here, so we dont see 'Search for "false"'
please do new Error(message) so we can a stack trace; only python 2.x likes throwing bare strings :)
When we start the homescreen, the landing page is visible but while panning it will be none because of we change it from Javascript code in a specific function (I guess that you implemented this part). It is visible only the first time, after that, the behavior is the same than before
Because I want to test if the element is actually a <tt><section></tt>. But I think I can use getElementById and then test tagName. I think it should be faster.
I'll have a look on this line, we can ask the widget template to dynamically load scripts for us :)
Actually, I just changed it to use Janky::Notifier. Correct me if that isn't necessary.
to more directly answer your question: i had wanted `not self.reverse.get(h, None)` to be None when the key  did _not_ exist in the dict. i should have written `if self.maintain_reverse and not h in self.reverse`, but as i say above, that behavior isn't necessary anyhow.
The table_for_collection uses the PG::Connection.quote_ident method. 
It's my understanding that it produces a name that is safe to use as a 
table name. But perhaps I misunderstand your comment?

On 2012-10-24 18:26, Daniel Pittman wrote:
>
> In lib/project_razor/persist/postgresplugin.rb:
>
> > +        if @statements.add?(statement_name)
> > +          prepare_on_collection(statement_name, collection_name, 'SELECT value::bytea FROM ' + table_for_collection(collection_name))
> > +        end
> > +        exec_select_on_collection(statement_name, [])
> > +      end
> > +
> > +      # Returns the entry keyed by the uuid of the given object_doc from the specified collection
> > +      #
> > +      # @param object_doc [Hash]
> > +      # @param collection_name [Symbol]
> > +      # @return [Hash] or nil if the object cannot be found
> > +      #
> > +      def object_doc_get_by_uuid(object_doc, collection_name)
> > +        statement_name = "one:#{collection_name}"
> > +        if @statements.add?(statement_name)
> > +          prepare_on_collection(statement_name, collection_name, 'SELECT value::bytea FROM ' + table_for_collection(collection_name) + ' WHERE id = $1::uuid')
>
> You should probably be using |escape_identifier| on the table / 
> collection name here.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/puppetlabs/Razor/pull/224/files#r1930507>.
>
I forget about interpolation in coffeescript and just copied how it was in loadMessage, I'll fix it now
Please look at the commit message in 0978e5b.
Reworded.
On Fri, Nov 16, 2012 at 9:31 AM, Chris Bunch <notifications@github.com>wrote:

> In lib/god_interface.py:
>
> > @@ -0,0 +1,77 @@
> > +# Programmer: Navraj Chohan
> > +import logging
> > +import os
> > +import subprocess
> > +import sys
> > +
> > +import file_io
> > +import misc
> > +
> > +"""
> > +This file contains top level functions for starting and stopping
> > +monitoring of processes using the god framework. Each component is in
>
> This isn't true. Each component isn't in charge of creating their own
> config files. The AppController is in charge of this for everything except
> for App Engine apps, which are the responsibility of the AppManager.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/AppScale/appscale/pull/99/files#r2154294>.
>
>



-- 
Navraj Chohan (Raj)
PhD Candidate @ UC Santa Barbara
http://cs.ucsb.edu/~nchohan
http://appscale.cs.ucsb.edu
http://nlake44.posterous.com
I gave some thought to this and think it's better if there is no default password. Default passwords are annoying, don't add any extra security, and it clutters the interface. If a user wants to secure access to the server, they can supply a password, but I don't think there should be a default password.

Anyone else have thoughts on this?
What happens if a user fills out both forms? Would they be surprised that it only processes their password change?
You'll want to pull this up as a constant string template.`ZENDESK_TICKET_REQUEST_TPL` or somesuch
so if you have 100 pages , you will only say `Pagina de 100`
Emm, I'd say please use implicit line continuation. :p
And, Checking the cmd output is not a good idea, the output would change some day.
Thinking about this more -- I think we should come up with a policy about what profiles are allowed to be.

I think None should not be allowed. Instead an unset profile is indicated as '' (the empty string). All profiles are strings.

We should audit the pull request to make this rule across the board, which I think makes sense given that profiles are not objects to Autotest, but are XML-RPC parameters.
This is a bit similar to `findUser` - find an existing ID, or add a new one if it's not found.  So perhaps `findTagId` would be a good name?
Oups.. this was my previous design. I figured out this was too slow for reconfig, and its much better to do it at upgrade-master time.
s/calculate/resolve/
Not sure if these default settings have any interest at all. I think you should remove them from this file, and put a mention back in the documentation.
@vsizov  +1
Unfortunately not at this current moment of time, until there is a greater discussion with commercial to be made aware that their stats will dramatically reduce.

As requested from @kungpochicken
Please stick with the convention in this project which is that `from a import b` comes before `import b`.
This should be consistent with the parenthetical spacing in CMakeLists.txt
I have not looked into implementation yet, but this makes me feel that context menu will require sync message channel with content script, which intentionally was avoided in previous implementation, presumably for E10S.

If that's really a case we should recognize the fact that e10s compatibility will be broken. I also wonder if sync message API can even be provided for a fennec. @erikvold do you know if that's possible ?
I think more complete examples would help a lot:


```json
{
  "command": "install-xpi",
  "options": {
    "path": "/path/to/addon.xpi"
  }
}
```

Maybe also note what the path format will be for windows.
Renamed to dash-delimited. I kept long names as they are explicit.
what is the point of this change?
I am unsure of how the browsers handle running code while parsing. javascript_parse may in fact not be the parse time, but the amount of time it takes to run all the statements in between the top of the script and the bottom. I need a better understanding of how browsers handle this.

At first glance, the NavigationTiming (https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/NavigationTiming/Overview.html) API does not seem to offer any solutions for this either.
nit: Declaration right before the NetUtil.asyncCopy call? So it's bound to the block of code where it is used.
https://github.com/mozilla/i18n-abide Seems to think so, but it doesn't say what it does :-/
We need to make sure that we update the gemspec appropriately with any new dependencies.
@daniel-pittman It used to be that Puppet::Util. execute required an array, but in commit cb53870a8546216a170db4c21b090d76d10361cb, it was relaxed to allow either an array or string. I don't quite understand how the old test passed using a string, unless something was automatically converting it to an array that the execute method would accept. But in any case, changing it to an array seems like the most correct way of specifying a command and its arguments to execute (as opposed to a command whose path contains spaces and must be quoted)
What about

```js
var props = Properties.own(spec); // we just need to get the keys once
function matches(aMorph) {
  return props.all(function(prop) {
    return aMorph[prop] == spec[prop];
  });
};
```

A more sophisticated version would be:
This was causing a stack overflow before I added this conditional because I'm marshalling inside `Gem::Specification.load` which is called when something is required. As it happens, `fix_syck_default_key_in_requirements` calls Gem.load_yaml and kicks off the infinite recursion.
That depends, I made it 404 emulating github's behaviour.
Could we use `parent_builder` method and fallback (using respond_to? check)  to this hack if it's unavailable?
As for "association not found" error, it could be possible due to incorrect association in #link_to_add method, so we have to handle such errors in that place. I'll try to get this done this evening.
s/info/calculating? and perhaps a more useful message?
Should use single quotes
Also, since when is the dot a valid character in a ticket ID?
it is pushed below, can you please check the proposal?
With better I meant a native Dpxygen command without using HTML-Tags.

I've just taken a look to the doxygen command reference. ```<tt>...</tt>``` is the right way to to it.
@bradleywright Yeah, agreed that slug is better. Thanks for changing.

@floehopper Went with a regular migration as I believe that this type of data lived on all the boxes consistently -- but that could just be a co-incidence.
well, you're deleting the content of the directory. "the contents" can be confused with the articles that were translated to html (which are the contents of your blog), thus my proposal to change this.
As above, should use ```os.path.join```
I think this might increase the coupling between this part and the sources. Maybe we should design an API so the sources can provide their own lyrics if available?
Joini laskuosikkoon liian hankalasti kirjoitettu. Korjataan: and lasku_ux.tunnus = tilausrivi.uusiotunnus.
whoops, thought i removed all the printouts
you miss a return here i think. otherwise you just fall through and remove the other translations as well
ok, afaik we currently lazy load all of them: references, referrer, child/children and parent. correct, lukas?
Not sure. You can drop the braces, so I often do. I don't think we have a style rule about this (nor do I think we should).
Idem etc etc.
@Raynos: quote choice is purely stylistic while the two equals have distinct behavior.  @michaelficarra: I don't much care.  Would the patch be more acceptable if I just switched the quotes?
lisp leak! :+1:
Space again.
I think the preferred syntax would be
<code>InviteRequest.order(:position).page(params[:page])</code>
since the .order returns an ActiveRecord relation, whereas .find(:all) with conditions returns an Array and is less efficient.
Yes... I tried to do this the first time I updated examples and have given up since... wasn't able to fix anything within out code... cos all we are calling is the json prettify stuff, don't want to spend the effort digging thru that.
Do we need to keep these prints in here?
this adds an additional cleanup to keep the `tns` namespace definition one place (similar to `namespaced_type`)
opus C library will raise invalid argument if using any other value.
wow that's so much better. I knew there must be a way to do this...
@jpoppe Why remove :config_templates and not just add :os_default_templates? Maybe somebody is using :config_templates?
Actually, Zotero should not care about these fields evaluating to null, false, undefined, or otherwise. The only fields Zotero will care about are title and itemType.

Now if you do something like line 54, you should first check that you did get something back from `ZU.xpathText` call
Argh yes obviously the problem is with m_bInitialized on reinitialization. Let me see what to do.
Still it shouldn't trip an exception later.
If you wanted you could change each problem array to instead be an object like:

```js
{
    original: "...",
    converse: "...",
    inverse: "...",
    contrapositive: "..."
}
```

then not have to deal with the indices.
Does nothing else use Protractor?
Aren't your loaded classes destroyed/unloaded between TestCases ?
Good point. In which case I would probably expect two methods: expand_developer_comments and collapse_developer_comments, each with appropriate clicks and waits.
No, it wouldn't, because a Notification is just a data container and doesn't know how that data should be interpreted. Only "NotificationListModel" interprets the data in a way that notifications of class "system" shouldn't be shown. When I implement "display notifications on top of all applications", that implementation WILL show notifications of class "system".
Since `applied-migrations` is now returning a set, you no longer need to wrap this in `(set)`.
Good idea.  Do you think we should go ahead and do that before we add a few more complex queries in?  Or come back around and do it after we've got a little better handle on what the other queries are going to look like?  I'm fine with either approach.
Is there any reason why this wouldn't be part of the admin UI ?
`pagedRows` renamed to `rows`
In my opinion handing off the parsing of rows to a function is a better way of dealing with this. That way when calling you just need to pass it the rows instead of having to write a loop every time.
Shouldn't the Scala version appended to each dependency be parametrized?
These should be enums, not strings. Each mob that has a subtype category should have its own enum, even if it only has one value in it.
agree on the idea. but i think you need to put a use statement for the symfony core route or put the FQN here. it can be any symfony route
This one should go.
This is redundant. The `if` above has the same condition.
`elseif` instead of `else if` please. :)
Можно magic number (100) превратить в константу или еще как! Цифра повторяется в коде несколько раз, следовательно возможна ошибка при необходимости изменения размера массива (не поменялись цифры в каком-то месте)
1) пусть это лучше будет скоуп
что-то такое: 

    scope :by_tags, lambda{|ids| 
        return scoped if ids.empty? 
        Tag.where(:id => ids.split(' ')).questions
   }
Need to alter this line to ->
#2 "then \{player addWeapon "ItemMap"\};\(findDisplay 46\) displayAddEventHandler \["KeyDown", "altstate = _this select 4"\];\(\(findDisp"

U need to use the escape characters, since the brackets have a regrex feature...
http://www.pythonregex.com/
http://docs.python.org/2/library/re.html
Should document the NO_FETCH option here.
Let's split this mess into some understandable methods (e.g. `get_db_session`, `get_connection`, `get_channel`).
I don't think it's possible to get line numbers from the AST. I would need to cross-reference with the source file. Could be done I suppose, I'll look into it.
Don't create functions.
文档漏了loader function，建议写个for example。
There are definitly cases where there is a referenceName byt the msg is empty. In fact, this appears to be the normal case when pushing a reference (without any issues) - In this case where there is no message, I think it makes sense to pass along the empty message. 

I am not sure if there would be cases where this would be called when the reference name is empty - will have to investigate that possibility.
How about : "You cannot save data to the same file. Please use a different filename."

Otherwise +1 for merge
down :
use in1d from fixes.py as np.in1d is too recent
I like the name types so +1 for channel_types and fine with sorted(scalings) although I find sorted(scalings.keys()) more explicit.
a comma is needed after each require statement.
please add the response section like that:
```
response: {
    representations: ["application/json"]
}
```
Or require_refinery_user!
shouldn't it be ``without`` ?
Can you plz remove the console.log here?
Потому что я не знал, будет ли оно работать после закрытия и не решил
рисковать
when deleting, Repos, Errata, Packages I am passing a second key as 'content ', but when deleting Products, we don't require the second key under the content.  

[true] {:products (map :name custom-products)}   ------   this case it would be false

[true] {:products (map :name custom-products) 	
           :repos (apply concat (map :repos custom-products))}  -------  here it would be true.

Not sure if there are better ways of doing these stuff.
http://nathanhoad.net/git-amend-your-last-commit

You will need to do "push --force" instead of "push".

Although, it doesn't matter that much.
remove this license block
Let's keep imports ordered, general to specific
In the merge into a new version could you please remove the extra space so that additionalFields lines up with consoleString please?
ya thats not perty. whats up w/ it?
This todo can go, since we now have the deleted column, lets use that instead
awesome dude. good security catch
I am serious - I didn't write this class!  :)
This is the same code in FileCacheStoreConfigurationBuilder.

Would you want to define it in a super class and return self()?
This should be `mode_t`.
```Gcf``` is a singleton (actually it is simply a namespace...). Creating an instance of it does nothing (and should probably raise an exception when trying to instantiate one).
These ports are actually for the entire web server that Tornado creates, including the main web page and the static content.
Note this is a line that was *removed*, not introduced by this PR.
we should at least make this configurable (I am also not sure how this works in other WPS implementations)
This was also my finding, so I removed it.
right_link is public domain, so why are we putting the confidential and proprietary headers on all these files?
Should these `copyField` directives be removed? I could be behind the times on these but I thought they were still being used. It looks like they're still being used in the code but they might be populated by some other means.
Double comments here.
yes, good idea, I will do this.
Why is this height unset? I can't see anwhere that it would be defined again.
What happens if the tree is 30+ items long - does it show all of them without scrolling?
There's a reason this was height limited :)
changed to Newscoop\EventDispatcher\EventDispatcher
this should be moved to Assetic instead and the configuration should be a separate PR (you are mixing 2 different stuff in your pull request)
No idea; as I mentioned in the commit and my last comment, I just translated this from the old JS and made no changes to the actual style. In particular, the formula for `.cm-s-jsbin span.cm-comment` was `(base font size) * 1.125 - 1`.
Why VERIFY_NONE?
> did you miss the part about this feature not working properly if this save is here

I did miss that; where is that specified? Why would the code break if you save multiple times in a row?

Ok, it seems that you did some digging and determined save was already called. I'm fine with removing it. Just bring it up in the pull req to the main fork.
Are you sure ``$guestGroup`` has the correct type as ``object`` is not a sub-type of ``string``?
Are you sure ``$this->viewData`` has the correct type as ``*`` is not a sub-type of ``string``?
Are you sure the class "DoctrineModule\Service\MappingDriverChain" actually exists, or did you maybe forget to add a USE statement?
This is fine by me (probably an overkill, since we can work with normal services, and peering SMs are useful only when messing around with services).

By the way, the reason it cannot stay here is that it is not serializable -> renders config uncacheable :\
I'm not sure how much earlier I could make it, but I refactored and made the logic a little easier to follow.
It's not clear to me where `./etc` will be. If you want to use the default self-signed certificates, they should be copied into the generated node's `etc` directory when generating, then use the fully-qualified path to that directory.
I felt that this was the right balance.
And I think you'll find that it perfectly conforms to the published CMTools coding conventions
throw new NotFoundException()

I implemented this just in the master as well, it was undefined behavior before.
Старайтесь избегать описания стилей в html разметке. Плохой тон. Выносите в css классы
да и processData() не должен больше вызываться
`count` is costly, better use `(not (empty? ...))`.
The literal `true` evaluates to to boolean value true.
Please don't make assignments inside conditionals. We want to move away from that kind of style since it's a source of bugs and confusion.
this licensing header is completely unacceptable. you don't include the license text it refers to.
Unfortunately, it really is kind, since it expects things like tcp and splunktcp. kind and relpath were separated by the REST API.

Documented and renamed the parameter to kindOrRelpath.
Please change variable names to lower_with_underscores, here and everywhere.
Ok, I asked scorpio why he added this line. He read on the internet that mongodb sometimes creates .log files. He also said that we can delete this line.
Just saw it :)
Combine those two URLs into one. URL resolving will then do better. And user will not have to decide to use `email_confirmaton_no_token` or `email_confirmaton_with_token` when creating an URL. Simply make the confirmation token part optional.
Please be consistent. We are using "login" everywhere. Not "log in".
```
    google.maps.event.addListener(
        marker,
        'click',
        function (event) {
            infowindow.open(map, marker);
        }
    );
```
Like this?
`shop-overrides`? What is this?
`$("button").click`?
Luckily, it was not exposed before. This function existed, but we never did a CREATE FUNCTION.
`"\\"`
Here's some test `ruby` code:

```ruby
def something
  puts "something"
end
```

Cool!
above note about time applies here too
Neat, I was wondering how to do this.
`OpenApplicationCommand`
Hah, found it. The `$` is matching the end of the line and not the end of the string. Will fix this shortly.

Thanks @zenspider!
Added in most recent commit.
Please fix CS
yes, agree the bundle should not provide but it should at least provide abilities to do such modifications.
Lovely change!
whatever happens, never swallow "Exception" as it might contain quite critical information: log it at least.
Is this section in the book? If so this should be a link to the book. Otherwise, it should be a link to the docs.
Ya, I agree. If you nail the EvalFunc, the Converter would just be icing. I'd leave this out until the EvalFunc is complete.
just double checking-- this artifact is commonly used only for testing?

for consistency may want to swap ordering of <scope> and <version> elements here.
We should find a way to do many tests in parallel, to make atomicity tests
Woops, yep. Typo there, will fix that.
what's this for ?
i can probably only have `Queue.__init__(self)`
I suspect you don't want to set cls.controller everytime here. That's probably leaking.
Nit: on mozilla-central, we generally write

   if (pending) {
     ...
   } else {
     ...
  }

This makes it easier to patch the code or add debugging/logging support without introducing errors.
according to Pascal case naming standard, this actually should be Etag instead of ETag. because ETag is a single word, only the first letter should be capitalized regardless of the convention. For example, BLOB is called Blob instead of BLOB by convention.
"associated"
I don't really get what this does atm, but since it's recursively called you could have the `const`s outside of it (and make them `var`).
This dependency step was committed by mistake :(
https://github.com/vincentarelbundock/statsmodels/commit/e47978d5910fcd24906a0ad1e64b090afb3bbfce
result of estimation with trimmed observations, run OLS on the sample of "inlier" candidates (``iin``), dropping/trimming outliers.

I think main contrast was to WLS with weights=0 for outliers as we get with RLM. In some parts it wasn't clear to me whether it's better to work with the reduced dataset (OLS) or with the full dataset with weights=0 (WLS).
are you using ``alternateName`` here just to illustrate the possibility?
I see it now. The currency symbol is per locale, and the locale that uses ```S/.``` is ```es_PE```.

But in twitter-cldr-rb, we don't have ```es_PE```, we only have ```es```.

This currency symbol per locale is really new to me. I never knew that before!
Ah ok, no worries!
No query, I just want to say how clear and helpful this bit of documentation is.
Worth mentioning that this is kind of a kludgy way to include these effects, and eventually GalSim may have a module for including camera shear, detector defects, etc.?
"each of which has 20 galaxies"
Hmmm, I think you're right, never mind.
Yes, that's why that was one of my proposed to-dos for the future.  I think it would help tremendously to be able to have just a few kwargs, and it should be pretty easy.
Who was the change?, Thanks.
¿Cual fue el cambio?, Gracias.
Perdona mi ingles, sorry for my english.
campaign.video_link should be deprecated in favor or campaign.video.link
${summary} needs converted
Is it possible to share this?
natürlich bezogen auf css
あー、なるほど。そういうことか。理解できた気がします。
けれど、すぐあとで GithubProject もこれの対象に加わることを考えると ID だと限定できなくなってしまうと思いますので、(面倒ではありますが)パラメータでちゃんと受けて処理しておいた方が良いと思います！
What is the %s:%d? servername:port?
If not, then it looks wrong
also use `if post.categories.any?`
"PHPUnit/Extentions/Database/Autoload.php"
should be
"PHPUnit/Extensions/Database/Autoload.php"
If you have a global or application namespace instead of a user namespace, some of those the fields will be null, but you don't want to fill in the values from the service in that case.
Why do we need this prepopulated <span class="wifi">?
This is some tricky and confusing code.  Since it's not obviously correct to me from reading it, would you mind putting in a few unit tests for it?  An implementation like `[x for x in X if x not in set(Y)]` might be slightly slower, but would look much more obviously correct. (Is it really slower?)
same thing.. NatProtocols interface w/known protocol values, unless they are static, then consider enum
Yep, there should be a class called .vertical. This is to identify tables where the <th> tags run vertically as apposed to horizontally. The styling in this case needs to be handled slightly differently but, there is still enough in common so I can avoid creating another bunch of styles called vertical-data-table. Does that answer your question?
what does the '1' after the '?' do?
By the way, should we change 

@ With(Secure.class)

to 

@ With(OBSecure.class)
rcb cloudfiles?  also i wonder if it makes sense to put up a pre-installed devstack box somewhere.
I don't like functions that do more than one thing! I would like to refractor the logic into it's own class.
т.е. нам же надо в ковычки обернуть строку?
I think the name is right, but the implementation might not be. Hmmm. The trouble is that there are sort of 2 targets for each tab, I think.
Silly, but "Registering", in case someone things it means something else.
Thank you for your reviewing.
`kString_toupper` is called only in `String_toUpper` function that includes case checking code.
Therefore `thisString` will not be copied when it is already UPPERCASE as you have pointed out.
test_developer_hub.py:173:19: E225 missing whitespace around operator
Btw, if it's not used yet, don't expose this method.
maybe rename it to `doParse`
hiddenの後改行。
h4. が消えている。
thanks. それにします。
確かUnit Test は用語ではUnitテストじゃなかったけ。それ以外は反映しました。
does form_for @session work here?
Combined the two functions in one, with a small performance decrease.
yes, yes I will....
seems like I haven't been up to speed yesterday...
`feature_extraction` kind of violates our flatness rule. I personally think functions from `feature_extraction.image` shouldn't be visible here, but one level lower.

At the moment this is inconsistent. Part of `image` is exposed (except the patches stuff), none of `text` is exposed.
take out scale_C
add the ref to the paper that explains the implementation you use.
`for` attribute: https://developer.mozilla.org/en/HTML/Element/label#attr-for
Yes, because the only time you'd want to actually hide current contents is when navigating from NearMe view. Other cases (you click a link in an existing article, for example), you'd want current content to show till new content is available
+1. That class also has the enhancement for dealing with environment variables that Scott Stark added to jboss-dmr. I don't believe that is in jboss-common-core unless someone added it and did a new release.
and again a dialog...
This queryBuilder is never used.
What will happen on non-Ubuntu systems? On OSX? On Non-Unity Ubuntu systems?
needs to be rm->getExpectedFootprint() also calls below.
Actually I think it's almost backwards... The version that uses the workunit listener is using dali, and the other isn't I think.
Need to quote strings.
Convert Qstrings to real strings.
etc.
Also need to think about what encoding the output is in. ascii? utf8? strings/unicode need treating accordingly

I'll be more explicit...
This function is generating a string, but what kind of string.  Is it ascii, utf8?  (I would vote for utf8.) It matters because when you convert a string or unicode string containing characters > 128 they will have different encodings.  You need to make sure they all are consistent.
Shouldn't that be done by dropping the value that  maxHeapSize() returns though?
Before, the default behaviour was to ignore completely, now, apart from attributes, it's to process the selects. Seems a big assumption, given that there are hundreds of node types... Will 'processSelects' bail on invalid nodes?
PS: Not that it's really a big deal, but I think it's "Javadoc" (with a capital "J"): http://en.wikipedia.org/wiki/Javadoc
@doda touché :) http://docs.python.org/2/faq/design.html#how-fast-are-exceptions is pretty compelling for this particular case, I think it's pretty uncommon.

The only reason it happens for B2G is because we're not doing aggregate reporting, they aren't up and running on all expected channels yet. So this should be a pretty extraordinary condition (new product, or a new Socorro install that someone has not fully configured yet)
You can just do:
```javascript
if (!$.trim($('input[name=date]').val())) { ...
```
Also, since line 25 is a line of code it should be indented with 4 spaces.
OK, this whole thing *is* wrong, but not for the reason I thought earlier. What we want in order to make sure we always match properly is:

    /0../7: 0 bytes (all addresses match)
    /8../15: 1 byte
    /16../23: 2 bytes
    /24../31: 3 bytes

I believe ` num_quads = 4 - (mask / 8)` is the correct solution here
Бүлгэмийн хэлэлцүүлэг дээр хийвэл илүү олон хүнд хүрнэ шүү дээ.

2012/4/9 Unurjargal.Ts <
reply@reply.github.com
>

> >
> >      ```Ruby
> > -    # bad
> > +    # муу
>
> Энэ орчуулгын хэллэгүүдийг ярьж тогтох хэлэлцүүлэг хаана хийвэл зүгээр вэ?
> github дээр форум маягийн юм байдаг уу? Бүлгэмийн мэйл листээрээ ярих юмуу?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zolzaya/coding_conventions/pull/2/files#r659172
>



-- 
Best wishes,
Zolzaya E. - Developer

"USI" LLC
Building of Enkhuud center, 4th khoroo, 15th khoroolol
Bayanzurkh district, Ulaanbaatar - 51, Mongolia

Mobile: (976) 88001963
Phone: (976) 70151145
Fax: (976) 70141146
I think I've seen this function in multiple places already. In any case it would be nicer if you could move it to the separate helper module.
This image looks buggy as it is displayed at the same level than `Specifying the Icon` header.
This image shouldn't be part of the next part, so that `Specifying the Icon` paragraph will be really distinct from the introduction paragraph.
I should look better if you move the `<img>` before `The widget is added to the "Add-on Bar" at the bottom of the browser window:`, and if put `<div style="clear:both"></div>` before `## Specifying the Icon ##`
Yes, it is I'll update examlpes.
It should not exist users without profile. I thought only admin did not have profile, but there are others. This is awkward.

I'll take a look on this later.
Ok, then I think just "Console" at the end is fine.
in camel case, the name of the variable should be readTimeoutMillisecond.
('this' being the entire contents of the switch)
You can use different projects on the Winlog Server and the offset depends on the project path. I have generated two working offsets but if there is an other project we have to fix the offset values.
Do you want to continue if RememberPassword isn't set? Just asking! not sure if both cases are interesting or only the case where RememberPassword is set. If you're interested only in the case where RememberPassword is set, an else with a print_error and return would be needed.
Yes, that definitely looks better. I additionally added a binary closing to make the different labels more distinguishable.
I think this (and the following line) might be simpler as

```javascript
encodeURIComponent(ZU.xpathText(doc, '//input[@name="__VIEWSTATE"]/@value'))
```
This should be `typeof command.shaderProgram === 'undefined'`.
Why not an `@example`?  In general, why not an `@example` throughout for all non-trivial calls?  Readers will look at the `@example` before reading anything else I promise.
I attempted to order them by how fast they are to compare.  The only properties before text are bools, numbers, and objects compared with reference equality.
The default texture and cube map are white. (0 = black, 255 = white)
@bagnell sounds like we should put back `return undefined`.  I'm with @shunter.
Can we get rid of the uniform maps and create one for `u_morphTime`? Otherwise, `this._pickUniforms2D` is never used. The command for picking sets the uniform map to `this._pickUniforms` which is always `undefined`.
I see we are not culling this at all right now.  As we continue to design the DDR, we will want to render these in a separate pass after all the frustums.
Honestly, I forgot to remove this function object.  Having said that, I will remove it.
I believe I actually ran into this when I initially set up anvil.  If you don't have ANDROID_SDK defined, anvil doesn't report any useful errors to stdout.  I was finally able to track down the error via the logs.  Is there a reason why the sdk error is in the logs, but not stdout?
Yeah, basically I wanted to send folks to the new page, rather than include a sample using a deprecated API.
Yes but the questions is whether the default behavior of one platform or the other be changed to achieve parity?  Has this been discussed or are we keeping them different in order to not impact existing apps?  If so, should we change this to be consistent down the road and perhaps mark the default for one platform as being deprecated in a future release in favor of a parity approach?
This shouldn't be a blocker, but while I'm thinking about it, it'd be nice to have this iOS locale issue mention that this is an iOS bug-- IE, Apple's fault.