labofsahil/github-event-dataset-2012 huggingface dataset:
Hi, how about change Client2._split_url_string to non-staticmethod.
Some site return JSON content instead of query strings.
The static _split_url_string method was hard to override or replace it in a Client2 instance.
Thanks.
Hehe. I must have been a little absent minded
Thanks for sharing!

[MSBuild docs](http://msdn.microsoft.com/en-us/library/ms164311(v=VS.100).aspx) is not clear about this, but the [examples found in the net](http://stackoverflow.com/a/3209492/66629) uses "" for values with spaces.

Did you try to just use AnyCPU (without spaces) ? Take a look [here](http://stackoverflow.com/questions/2957672/anycpu-vs-any-cpu-in-tfs-2010)
ok, sounds great :D im looking forward to it
Shuffle is never grouped (although theoretically it could be implemented).  Its implementation is currently in terms of a grouped operation.
Hi Julien,

I believe that when a submodule is removed in the github repository, you'll have to delete it manually in your own repository.

Cheers,
Trond


On Feb 27, 2012, at 12:34 AM, Julien Rabin wrote:

> Oops, you're right Trond. I forgot about this. 
> 
> I am not sure why do I have it here as I did a fresh clone quite recently. Anyway, thanks.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jamoma/JamomaFoundation/commit/37709265c5966237bc0278b7b54e8539cc1009fa#commitcomment-1013215
This becomes an endless loop, if there is no GreaterChar in the remaining buffer.
These "while LCh <> xxx do" loops need to check for EofChar too: 

while (LCh <> xxx) and (LCH <> EofChar) do
Mais ce sont quoi ces heures? xDD
Grid system broken after @megamage  transport and corpse fix,  #3953 was returned and has not fixes 
and now you fix core db layer? its real....
anubarak need fix: http://pastebin.com/jLukAfnj
Thanks! Yeah, there is a great deal to learn from contributing to Mocha.
И еще тут заметил: как пользователю добавить 50 картинок к альбому? Похоже надо 50 раз октрывать альбом на редактирование, а это не очень удобно (для этих целей можно использовать гем cocoon)
嗯，我这里本地测试可以，应该是 readthedocs 搞的鬼，可可可。
I did indeed comment-fail and F is in fact acceleration (dunno why I didn't see that last night).
Gah, must of made some mistake when merging this. Sorry, I'll double check the other branchs that's currently in progress to make sure this doesn't happen again.
Only problem is the niche case of events that start at midnight. 
Potential other problems could be caused by lack of timezone normalisation.
I have an issue because of this commit. I have a Text object with some text, and then, if I replace the text (using setText method) with other text containing a space on it ("a text", for example)... result is weird...

If I comment "if(!letter.isWhitespace())" works perfect

Thanks
Я что-то не очень понял роль install_generator.rb в этом расширении... В принципе можно оставить для примера, если он понадобится в будущем, но надо хотя бы взять в комментарий 

    =begin
    методы генератора
    =end

На данный момент в расширении нет ни стилей, ни скриптов, ни миграций, поэтому смысла в инсталляторе нет никакого.
Also, selected people are now persisted between the new entry and select people activities.
I was unfortunately unable to test this because I wasn't sure of the external libs you were referencing.  Would you mind posting names and download links in a README for the java prototype directory?

Then either I can take another whack at this (I doubt it works yet since all I really did was rename some methods) or you can work off of this to get a working prototype. @KyleCartmell
``$match &&`` is useless as you know it is true here
avantages:
* c'est plus lisible
* c'est plus proche de ce que l'on est entrain de faire, sémantiquement. Je veux dire par là que notre shared_ptr n'est partagé avec personne (or c'est le but d'un shared_ptr), c'est juste un moyen (on pourrait presque appeler ça hack...) de passer le pointer et de ne pas recopier tous les objets lors du return, etc. Or c'est exactement de que permettent les boost ptr_container. Quand on accède au contenu d'un ptr_container, on le manipule comme si il contenait des vrai objet (on reçoit des références).

Non, un ptr_list n'est pas une list de shared_ptr. Le contenu du ptr_list n'est partagé avec personne. Mais quand on return un objet ptr_container, on peut transférer le contenu pour qu'il n'y ait pas de recopie. Derrière ptr_list<Toto> est implémenté comme une std::list<Toto*>, mais tout est bien géré pour interfacer ça et que cette liste contienne vraiment les objets Toto.
This should be pushed to lumbar-loader as well.
Most libraries use Modules for namespacing classes. Why did you switch this?
Check this, it's my first time using MySQL databases.
Perhaps you meant `substitute(a:n,'\*','.*','g')`?
substr fails with plain html in utf8.
use instead this class http://pastie.org/3084080
with length of 500 chars.
Fixed: 49224e8
thanks for the update. ah can you workout the edit notes if there's the same title of the note and delete notes with same title note?
Error.
Undeclared "WHITE_BALANCE_CLOUDY"
Hope so : ), my bad for keeping changing things and not double checking - I've double checked all the code under the if statements now
Awesome thanks. It's certainly non-trivial. I tried to take a crack at the jsonreader code and could not source the issue other than to say it does not like the trailing double slashes :-P
FYI, Fixed in https://github.com/shanx/django-maintenancemode/commit/52b3e5ef2334a059b076f1de860a97ea42e39546.
wrong commit xD
@GeekShadow @ilikenwf built version of this commit at sourceforge: 1.11.0-Release/Nightingale_1.11.0-2223_windows-i686.exe
I'd like to thag this commit and roll the release, on Windows there are no visible issues left after a short test.
Tested features:
- Firstrun (issue: first-run add-ons weren't downloaded, but this is caused by urls missing in the recived xml. We have to remember to insert them!)
- Firstrun without internet connection
- Music (mp3) import
- Music Playback
- Add-on download via -temp wiki page
- Feather switching
- Media view switching
- Display panes
- Smart playlists
- Regular playlists
- Synchronization
- Playlist folders
- Profile manager
- Restart behaviour (only known SB 1.10 issue: volume slider progress bar not properly displayed until the volume is changed)

Note to others: the file is not publicly visible, you can download 1.11.0 after the official release.
Also need to revert a bug fix :

<dimen name="key_preview_backing_height">160dip</dimen>
it's just next line checks if conditions isEmpty and throws Ecxeption. Maybe smth like hasEmptyFactorFactorValueCondition
I guess you meant deleteTermsFromMatchingPropertiesForAllExperiments :)
`WARN` debug message would be informative here. 

Also, I'd suggest to do the `isEmpty()` check before constructing the `attribute` object. Less GC.
I removed the line here that manually set the response status code.
I think it's faster to ask all first, then await all.
That documentation comment is an implementation comment, and should not be visible in public API docs.
This should be pulled out of the trait since it is a constant, put in some object.
Link to the script or even better, to a doc section that explains the script.
the resume is not the cause of the failure, so I’ll go with `causedByFailure`
with the new constructor you don't need = null here, do you?
Nice job fixing it without the trunk_id reference.  I sensed there was a name based way to do it correctly.

There are some available efficiencies in using the db id's in some specific use cases, and we may want to actually fix the fact that the db fields are missnamed from a semantic standpoint.  Those use cases amount to operation strength reduction.  like doing 2*x as x+x.  Not very important now, but there was a time when there was an order of magnitude speed difference between them.  We have the same thing here, sometimes we can avoid db/cache lookups by knowing the id we might fetch for it, or avoid additional joins in the sql whether direct or through wql.

In any case, we can do those changes later as incremental changes now.  That's the right way if we end up wanting any of it.
How about this:

```python

def sdef squared_radial_component(x, tol=0.01):
    result = (2 * x * np.cos(x) + (x*x - 2) * np.sin(x)) / (x**3)
    x_near_zero = (x < tol) & (x > -tol)
    return np.where(x_near_zero, 1./3, result)
```

With this you can take out the line,  `H=np.vectorize(squared_radial_component) `. Vectorized should be used sparingly, it can be useful in some situations but often it makes things quite slow.
Yes, that's a reasonable name.  I was trying to capture the idea of 'axis_id' being an integer or string but maybe that's not important.
My thinking is that a plugin might want to know whether a resource is on the same domain or not. They might need it in `can_preview` and `setup_template_variables`. Have a look at the json preview.
Ya know, I thought about it. The headache becomes the return statement. I'd have have to see if the return value was just an os exit code and abort or if it's a key/metadata where I can continue. The difference in message is also a bit of a headache. I figured it was so small I'd run with the duplication instead of addressing that, unless you have a better idea.
Typo in "not".
Can we be certain that nativeWindow is never NULL or do we need a check here?
At least no easy way otherwise I would have used that. Maybe one has to dig deeper into paplayer. The only other way would be to try and open the file directly in the codefactory which wouldn't be clean.
On phone, only responding to first line: doesn't Object.protoype and
thus getProtoOf(item) have all the necessary fundamental traps
defined?

-dave


On Mar 28, 2012, at 2:01 PM, Joe Walker
<reply@reply.github.com>
wrote:

>> +      if (startMatch === -1) {
>> +        return value;
>> +      }
>> +
>> +      var before = value.substr(0, startMatch);
>> +      var after = value.substr(startMatch + match.length);
>> +      var parent = document.createElement('span');
>> +      parent.appendChild(document.createTextNode(before));
>> +      var highlight = document.createElement('span');
>> +      highlight.classList.add('gcli-menu-typed');
>> +      highlight.appendChild(document.createTextNode(match));
>> +      parent.appendChild(highlight);
>> +      parent.appendChild(document.createTextNode(after));
>> +      return parent;
>> +    }
>> +  });
>
> I'm not 100% clear about this.
>
> It seems that I could follow the letter of this comment with this code:
>
>    return Proxy.create({
>      get: function(rcvr, name) {
>        // ...
>      }
>    }, Object.getPrototypeOf(item));
>
> But I don't see how that would help because the prototype of `item` is {}, so it can't help with enumeration.
>
> The advice is unclear to me:
> * https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Proxy includes the scarey "To make sure no error is thrown when your object is used, you have to implement at least all fundamental traps.", which I'm certainly not doing, but then it's got several examples where the code does just what I'm doing.
> * http://soft.vub.ac.be/~tvcutsem/proxies/ has examples of both what I'm doing an of using getPrototypeOf
>
> My gut reaction is: Yes: this will break if you try to alter/enumerate/throw/etc the Proxy object. So don't do that.
> I accept that this isn't a great answer however, but it does seem better than a false sense of security from adding getPrototypeOf or the huge expense of implementing all fundamental traps. I have a feeling that there could be option 3 that I'm not aware of.
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/campd/gcli/pull/25/files#r617811
This is a very interesting fix in the sense that it's so damn simple and didn't occur to me. I mean, I read the code that actually reads a proto, a file or a class and I haven't thought about loading the class and not the file. Silly me!
Maybe `SEARCH_QUERIES_ORDER.find { ... }` here instead of `for/break` ?
Exactly, I forgot to remove that parameter
To prevent highlighting on labels as an option.

On Wed, Sep 19, 2012 at 7:38 PM, Justin Spahr-Summers <
notifications@github.com> wrote:

> In lib/UIKit/TUITextRenderer.h:
>
> >  @property (nonatomic, assign) BOOL backgroundDrawingEnabled; // default = NO
> >  @property (nonatomic, assign) BOOL preDrawBlocksEnabled; // default = NO
> > +@property (nonatomic, assign) BOOL drawOverflowEllipses; // default = NO
> > +
> > +// Don't become first responder.
> > +@property (nonatomic, assign) BOOL shouldRefuseFirstResponder;
>
> Why was this added?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/github/twui/pull/78/files#r1647146>.
>
>



-- 
Aditya.
These `if` statements should have braces.
This should be two lines, within braces.
`volatile  boolean` -> `volatile boolean`
Shoudl be final
здесь должно быть
mkdir ../../../bin/template/; cp -r template/* ../../../bin/template/*
пробелы заменить на табы
I think it's ok. Actually *shrug*
shouldn't acc.isMethod here be dropped as param accessor will always be a method?
Oh, really. It's kind of weird, though, because `reverseIterator` somehow suggests that there is an order involved. It's good to have a note there, but wouldn't it be better to use the reverse order of `orderedIterator`?
Oh, yeah, this is wrong, it should be:

``-sourcepath src``

Looks like you missed [this commit](https://github.com/dotta/scala/commit/bf3cff6f2b2115944a2bb6f72f96193e58a9508e) when merging my branch.

How did I miss it :)

Anyway, if you merge that commit,  then it works fine.
Here are the four tests which fail, and stack traces for the two places which attempt to make a selection of NoSymbol (that of course is how they end up selecting NO_NAME.) Line numbers are master.
```
test/files/neg/valueclasses.scala
test/files/neg/anyval-anyref-parent.scala
test/files/run/lazy-traits.scala
test/files/run/inner-obj-auto.scala

at scala.tools.nsc.transform.Mixin$MixinTransformer.scala$tools$nsc$transform$Mixin$MixinTransformer$$accessedReference$1(Mixin.scala:1015)
at scala.tools.nsc.transform.Mixin$MixinTransformer$$anonfun$addNewDefs$2.apply(Mixin.scala:1043)
at scala.tools.nsc.transform.Mixin$MixinTransformer$$anonfun$addNewDefs$2.apply(Mixin.scala:1033)

at scala.tools.nsc.typechecker.MethodSynthesis$ClassMethodSynthesis.mkThisSelect(MethodSynthesis.scala:53)
at scala.tools.nsc.typechecker.SyntheticMethods$$anonfun$hashCodeDerivedValueClassMethod$1$1.apply(SyntheticMethods.scala:215)
at scala.tools.nsc.typechecker.SyntheticMethods$$anonfun$hashCodeDerivedValueClassMethod$1$1.apply(SyntheticMethods.scala:214)
```
The location in Mixin is
```
// sym.accessed must be NoSymbol
val selection = Select(This(clazz), sym.accessed)
```
The location in MethodSynthesis is
```
// sym of course is NoSymbol
def mkThisSelect(sym: Symbol) = atPos(clazz.pos.focus)(Select(mkThis, sym))
```
Good question.  I suppose if we could expand `(A*B)**-1` as `B**-1*A**-1` it would work.  But the way, this looks like a bug:

```py
In [26]: expand(A*B*(A*B)**-1)
Out[26]: A⋅B
```
So,  sometimes, `__print_Boolean(self, e, char)` accepts `e` as expressions, and sometimes as a tuple of arguments.

I think that it would be better to do not mix types, and just to add the additional parameter to the  `__print_Boolean`, e.g. `sort=True` which is True by default , and then call it with this control parameter if it needed. We can don't care about this necessary changes  of function parameters especially as `__print_Boolean` is helper function.
Same comment about S(0)
actaully, shouldn't this be defined in Set as `sort_key`? and then the function can be deleted and the places where it is used would use `default-sort_key` instead.
center -> c if change is made above
ah ... C deviation ... I love curly brackets ;-)
It's not consistent with the other provider. Instead, move this to the end of your doc file.
Which would let you move the `uv_async_send()` out of the critical section, it seems.
Why a loop here? Setting these on the `mdn` logger will cover everything. You only need to add handlers or formatters to the children if they're different. You also don't use the `log_name` var anywhere.
Need to use `"` (double quotes) here.
These lines are necessary to have the user's permissions shown on the forum page when they have the ability to post a topic but not read the forum. I couldn't see a reason to not have permissions shown and felt it would add clarity as the user would see a message saying they were unable to read the forum but the permissions list would show clearly that they were able to post topics and/or replies. I am unaware if this addresses another issue.
unset $auth_admin?
Actually there is space in an empty line here as well. Please make sure that you never add any trailing whitespace, best by setting up your editor to do so for you. Otherwise this extra whitespace results in unecessary lines changed.
Dunno... I didn't change that file.
Maybe something happened with the rebase.
Unneeded global, there is no global `$config` in the tests.
I think you should remove the bg_header.gif image, and use CSS3's Grandinet property, if we already use borderradius. Dump the images etc, and do everything that can be done with CSS3.
We don't use upper case develop anywhere.
There should be a global instance of phpbb_php_ini that should be dependency-injected via the constructor.
minor point and not worth changing now, but use \@ when referring to the thing you're defining and \' when referring to anything else (this way it turns them into links)
Why does this `ac.partial.compiler()` method exist?  Where/how might it be used?
The lack of a '$' caused the compiler error for me. Adding in type signatures helped narrow it down. Is this pull request missing a commit?
Will eventually put this back in, but back end resources not yet complete. Commenting for now
I think this might be more readable:
```
data_path = tests.get_data_path(('NetCDF',
                                 'testing',
                                 'test_monotonic_coordinate.nc'))
cubes = iris.load(data_path)
```
Another very long line.
With which witchery will I switch as wished?
that tests
we need 3 different urls:
s_start
d_start
w_start
line 109 is complaint with pep257. Stop drinking.
There is no "in between". `insert` and `update_tree` are both top-level functions that operate on a hash tree. You put a hash tree in, get a hash tree out. You have two options:
```erlang
B = hashtree:insert(Key, Hash, A),
C = hashtree:update_tree(B).
```

or 

```erlang
B = hashtree:update_tree(A),
C = hashtree:inesrt(Key, Hash, B)
```

The behavior is clear in either case.
@rchavik: and I think we were looking for some third-party libraries (more classes!) to prettify the JSON, which I didn't want in the end and the settings.yml was never converted. but here I see everything is self contained and adding one more function only.
Fair call. I'll move it.
likewise ...
You're right, it could - I had to do this to stop the tests failing (the unmanaged models in the schema tests tried to create themselves when they shouldn't have), but I can probably fix that in the test wrapper.

Thinking about this code, though, it's possible we fire post_syncdb on every run for unmanaged models. I'll check.
To get Oracle working properly, you probably also need an entry for "int_used_for_boolean" or some such
@beberlei what is expected exactly here ?
Can't do chunked and not be 1.1 :)
can you paste the timestamp portion of the vtt file in your comments? it would nice to see the actual testcase portion of the vtt file in the comments without having to look for the file to see exactly what kind of timestamp is being passed.
Primitive implementation is a bit diffuse unfortunately—searching the compiler dir for `PRIM_` will give you a sense of where everything is. `loader.hpp` defines an `enum PrimOp` with identifiers for all of the primitives, and `loader.cpp` contains a function `makePrimitivesModule` which populates the `__primitives__` module with these symbols. The actual behavior of the primitives is implemented in `analyzer.cpp`, `codegen.cpp`, and `evaluator.cpp`. `analyzePrimOp` performs type propagation for primitives. `codegenPrimOp` generates LLVM code for runtime implementation of primitives. `evalPrimOp` evaluates primitives at compile time.
This comment should be cut too
This is a nice and solid cross-browser / cross-window compatible way of checking whether a value is an object.

...as alternative for `obj !== null && (typeof obj === 'object' || typeof obj === 'function')`

But it isn't related to ensuring the object has no inherited (enumerable) properties. Which is what this function is supposed to assert, right?

For a while now we've had the "own `isPrototypeOf` property on constructor prototype" check that is implicitly taking care of this already.

Either way, my point is that replacing it with  `obj === Object( obj )` seems random/pointless, what is it supposed to assert that is both relevant to isPlainObject and not already a given at this point in the function's execution?
good call here, this is even still readable.
Postgres doesn't support auto cast when do the equal comparison. Add the explicit cast ```unnest(string_to_array(pre, ','))::BIGINT```.
Same comment about user supplied arguments and alemenets
Unit test for format function.
I'm not wildly excited about this. Seems like it'd be better to do it in a macro or to expand it out. But... we can push that refactoring off until later.
Just to get some spaces from the other elements.
If this wasn't in an ERB formatter, it should be a Ruby HEREDOC:

    say <<-APPLICATION
     Framework: ....
          Creation:
    APPLICATION
formatting... :-P
Oh, I see -- the corresponding code is going directly into the manager. I think the change is still worthwhile doing -- the branch should be correct when it lands (and the redis manager stuff is closer to what's in vumi.utils.redis_config that what's being done in this branch currently). Not sure concerned though about this though.
`validate_server_type` should really just be a block since it's not really a condition, as there's no else in all cases.
Preconditions is an antipattern forced by a lousy style guide!

You can probably just do this:
  if (linker == null) throw new NullPointerException("linker");
caps + punctuation
Use a time based seed, then we get more test coverage (with the fixed seed we always get the same random numbers) e.g. something like:

```cpp
srand(static_cast<uint32_t>(time(0)));
```
What happens in this case if there is an error from the ontologySource?
Do we want to continue to have the testme documents in the repository? If so, what do they actually test? And should they go somewhere specific?
I believe that deleting the no-args version of the method will break binary compatibility, since client code will need to be re-compiled to reference the varargs version.  I think the cost of removing it is higher than the cost of keeping it.
True story. Changed it.
I've always found these variable argument patterns cause more problems than their worth, it looks easy enough to just have all of the calls to customFreq pass in the flag?
May as well delete this
Please give a more usable name to the image.
Why you would like to close the hintlist here? If you do that, then as soon as you type the very first letter the hint list will get closed. Try with ``<h`` in a html page and you will see what I mean.
Logically, it seems like you should check for property name before property value.
reuse externalized string ``Strings.JSLINT_NO_ERRORS``
Good catch, I'd spaced that. Fixed and thanks.
I think this old code handles the case where the user canceled the dialog.  I think with your changes, the method would return a Deferred that never finishes.
three small things
doesn't work with `for in` loops is it intentional?
highlights wrong range for `setTimeout(function()...)` i tried going back from `this[1].getPos` but that too, isn't accurate

also this line is really long and `getPos` isn't a very simple function
maybe use `var pos = this.getPos()` instead?
Ok. Feel free to rename to whatever. I was just removing the bootstrap styles.
@igorw This is more about clarity of configuration rather than whether or not it will display correctly on this debug page. IMO the configuration clarity is more important.
must use octal instead of unicode here.
(Almost) the same thing as `First_Name` (not actually occurring because the variable in this case is `Member_Type` vs. `Member_type`)
Yes, and I have no idea which is better. Move this discussion to #552.
Right, I agree. Your implementation is much cleaner :) I'll try to find some time in the next day or two to tidy this up.
By making EventTest abstract and having MapEventTest and ArrayEventTest extend it, all of the EventTest tests are performed on both Event types.
It is not anymore model backend.
Shouldn't be `fields.EmbeddedDocumentField` instead of `EmbeddedDocumentField`?
Ok, I will leave it.
Set the base font size on the container so all plugins can make use of it
Mind picking a better variable name?
I'LL NEVER TELL
Was this supposed to be still using test.conf?
Variable spacing is still not implemented, right?
Couldn't this also just be shortened to check `_uiConfig.value( "ui" ).onLeaveDialog` seeing as it's going to return true or false
Two small corrections here: `a reference to a popcornWrapper object the wraps` -> `a reference to a PopcornWrapper object that wraps`
"eq" test?
I still don't think you need `def pending_modified_values=(value)`
Arch info comes with ```platform.uname()``` in ```os_data()```
3 lines normal comment only //
this is key to runtime support
Путь лучше сконвертировать в абсолютный
Do we have this css file in our repo?
What is this?

    User.find_by_username 'admin'

This is not gonna work on empty database. Did you try to build RPMs and install it on a clean machine? Because we migrate database first and then pouppulate with "admin" user. And during the initial migration, there is no such user "admin".

Can you describe in more detail the motivation for this migration? Thanks.
That is fixed. Api calls wont create any notices. Hypothetically if api calls were creating notices they would have same organization set as in UI-created-notice. Organization is set for delayed_jobs by model (this is same for UI-calls and API-calls).
i assume we should be checking for both promotion and deletion in the 'if'
Leerstelle hinter "\xf000Ă\x0001\x0000" vergessen, bitte korrigieren.
Could we revert this to return only the `MULTIPOINT (...)` string? The function is only supposed to return a valid wkt string (see name and docs). Including `ST_GeomFromText` breaks tests. We could fix that, but then the function goes beyond that orginal, simple, specific scope. A simple wrapper could add `ST_GeomFromText`, and be called [in this function](https://github.com/MapofLife/fossa/blob/d0474cbd7d2955c342d20e0a1ec5ed6063ebee81/src/clj/fossa/utils.clj#L302-311).
if you use the composer autoloader, you can remove the custom autoloader below
Yes, I could see console.warn's output from device.
(via adb logcat)
To clarify a bit more, the point of these configuration options is that they be used directly in the code, rather than just as the defaults for the function.  That is, you would remove them as parameters entirely, and instead just replace everything in this function that says ``use_numpy_fft`` with ``USE_NUMPY_FFT()``.  The key point that you may have missed (because I now see it's not in the docs...) is that these can change at runtime, so you should check them whenever you use them rather than just once when the module is imported.
Neither, but haven't been very clear (clearly.) The keys in folsom (the actual stat names) are tuples. But you must pass a list to this function.
How about adding `riak_core_ring:chash(Ring)` that returns the chash and not directly reference the tuple here?
done!
On Aug 20, 2012, at 8:33 AM, jao <notifications@github.com> wrote:

> In bigml/api.py:
> 
> >      FAULTY: "FAULTY",
> >      UNKNOWN: "UNKNOWN",
> >      RUNNABLE: "RUNNABLE"
> >  }
> >  
> > -def _is_valid_remote_url(value):
> > -    """Says if given value is a URL
> > -        with scheme, netloc and path
> > -        or not."""
> > -    url = isinstance(value, basestring) and urlparse(value)
> > -    return url and url.scheme and url.netloc and url.path
> > +PROGRESS_BAR_WIDTH = 50
> > +
> > +
> > +def get_source_id(source):
> You could have something like
> 
> def get_resource(regex, res):
>     if (isinstance(res, dict)) and 'resource' in res:
>         return res['resource']
>     if (isinstance(res, basestring) and regex.match(res):
>        return res
>     raise ValueError("Cannot find resource id for %s" res)
> 
> def get_dataset_id(dataset):
>     get_resource(SOURCE_RE, dataset)
> 
> # the same for the rest
> and avoid the cut-and-pasting. I'm not sure if the format string in the ValueError above is correct, i just made it up.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
You could use just: <pre>return (nBestHeight >= GetNumBlocksOfPeers());</pre> or even just use <pre>(nBestHeight >= GetNumBlocksOfPeers())</pre> directly, as you currently use <pre>CaughtUp()</pre> only once.
This is a minor change in behaviour as `'0'` is no longer an acceptable value.  However, in the above cases I don't think its relevant.
This is a 1:1 not 1:many
"decided on this proposal" is a bit unclear. Probably "stated their position on this proposal". It's a shame we don't have an elegant verb to use in replace of "voted"!
don't need the braces if the the hash is the last argument to a method call
Fixed.  Sorry, I should have checked.
Following up with the previous line: if it's awkward for this to pass as a doctest, I'd rather just remove it from being a doctest (leave it as an example, mark it with `@skip_doctest`) than paying the price of a dict sort in the bottom-most class behind *all* our configurables.
Oh yes, that makes sense.
Hard-coding this is a bad idea. We need to figure out if there's a configured remote with the `.remote` name and apply its refspec for the ref to get the remote-tracking branch we need to return. We also need to make it work if `.remote` is `.` (a dot) for branches tracking local branches.
Https here as well.
Actually, this should be taken out of the `{% if grant.break_down %}` given that we have the same line in the {% else %}`
Any reason to not use `models.SlugField` other than you didn't know about it?
I just moved these out of `__init__.py` to their own file
nope, most likely it will be a TypeError raised here when None is returned.  It is conceivable that in Index error is possible.  Rather than limiting to these errors that I can think of, it is easier and cleaner to react to all errors the same way.
The 'except Foo as e' doesn't work on Python 2.5, so I have indeed used the more portable syntax
in the code already. The original patch contained code that was simply commented and replaced.
I will remove this commented section of code.
Shouldn't all of this better go to tony.dat?
I could try to set the data like that but I dont know if applyPhysics will work then and apply physics is needed to update the redstone around the lever correctly.
форматирование

	use Behat\Symfony2Extension\Context\KernelAwareInterface,
	    Behat\MinkExtension\Context\MinkContext;
таки працюэ, зараз поправлю.
А я все пробував через:
<target><![CDATA[/^элемент "(?P<element>[^"]*)" должен содержать "(?P<value>(?:[^"]|\\")*)"$/]]></target>
@aerialls and @stloyd are correct. Plain English must be used for the source.
no need to join them. The ``Output::writeln`` method accepts an array too
To separate the las statement, just like if the method finish with a return.
Either I got it all wrong or doing ``` {{ something|e('js') }} ``` will just break anything in that variable.
Thanks for the feedback, guys. This was a pseudo-port that was originally meant for my own specific use case. I don't think I was clear enough about that when it got rolled into the overall project. I'm now going to work to fit the more general needs.
+1 / Ship It! for @benpence's latest revision. It is clear and accurate regardless of whether maven-finagle-thrift-plugin is open sourced yet (the binaries are available right?)

@stevegury We can work on open sourcing maven-finagle-thrift-plugin separately.
Yeah, I wanted to have the leading `<li>` outside of the if block, then the closing ones inside.

I couldn't find another way to accomplish it.
这里我之前也困惑了好久，
好像是因为lstset中的texcl的问题
就是注释的部分会按照latex语法来解析
所以如果不加斜杠就会报错
我是是直接input文件看看能不能解决这个问题吧
This function name is not clear, what does 'deal_with' mean? It gives me no indication what's going to happen.  How about process_valid_request instead?
heh, so i put `newln_pos` as it indicated the offset of the current line we are analyzing.  I'll change it to `line_pos` for better clarity... sound good?
If you subclass and override getHostLabel(), it works as expected.  Subclassing is the only way to do this as the class is written, so the original commit is correct.

On Aug 28, 2012, at 8:02 PM, Kim Altintop wrote:

> In metrics-ganglia/src/main/java/com/yammer/metrics/ganglia/GangliaReporter.java:
> 
> >                  .addString(metricName)// metric name
> > -                .addInt(0)// spoof = True
> > +                .addInt(hostName.equals(getHostLabel()) ? 0 : 1)// spoof = True/1
> sorry, but this can't actually work: the equals condition is always true. this line should be changed to:
> 
> .addInt(hostName.equals(getDefaultHostLabel()) ? 0 : 1)
> —
> Reply to this email directly or view it on GitHub.
> 
>
I think you meant wait?
@kabir this is the code that adds "name" attribute as operation handler...
This whole helper method approach is not really necessary, ShrinkWrap already has a quite compact fluent API for adding resources.
Can we start putting together a list of steps for merging this to master?
I had to change this to 'smallint' to make it work
The solution is not universal because the dash is optional, PHP version format is [major.minor.release[extra]](http://us3.php.net/manual/en/reserved.constants.php#reserved.constants.core).
Suggested implementation:
` substr(PHP_VERSION, 0, -strlen(PHP_EXTRA_VERSION))`
лучше этот Exception выбрасывать на верхний уровень или обернуть в RuntimeException если не хочется его везде прописывать. Т.к. его возникновение это признак нарушения целостности БД или программной ошибки.
hidden / style="display: none" is the same.
I know it is not directly related to this bug, but this line bugs me.  delay is only used if we're on a call, but I don't think that _longPress will ever be true when _onCall is true, so I think delay is always 100 and we don't even need the variable.  But at the same time, I don't even know why we delay the call to telephony.stopTone() by 100ms.

You don't have to fix this to land this patch, but you could :-)
yep, changing that
baout -> about
Then I can land #5680 first so then you can rebase your patch and remove the additional `<span>` elements.

PS: please log on IRC…
`setTimeout(function nextTick() {` ? ;)
I might even argue for a small comment.
omg, tabs! ;)
I have to say this is pretty cool.
Since Airplane mode is the only case now, I suggest we don't do over design on it. 
Moving the switch disable code above to `airplane_mode.js` will makes the code more readable.
Could you try to modify `settings.js` as little as possible? because it's responsible for the *general* setting logic.
Perhaps we should video chat, so we can synchronously figure out what's going on here?  If we're going to have technical discussions via text, I'd rather do it in the open (irc, e-mail list, bugzilla, whatever) than over private e-mail, if that's OK with you.
Hmm. But if you only register the handler on visiblitychange, then you'll also have to do the stat() call each time the app becomes visible, too.  Shouldn't be hard.
@daleharvey is our contextmenu expert if you have questions :)
See

https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Date/parse
https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Date
ThreadUI will have it own 'header' and it has different structure compare with ThreadListUI (check visuals). Next pull will refactor ThreadUI as ThreadListUI.
I think we should always flow the settings. e.g. you may not be using a custom build script, but you could still have custom msbuild logic that relies on environment.
eu 服务暂时不发布，请删除相关代码
Debugging isn't the general use-case, especially now that it works ok - in general it just clutters the screen.. maybe having a DEBUG flag would be useful, but I think for the rare occasion, we can remove the '@' when debugging.
As noted on IRC, I would elect to call this something to the effect of ``failures``, since you are tracking restarts due to failures.  Verbose as it is, ``restartsDueToFailure`` would convey this unequivocally even better.
テンポラリジョブをつくるためには、まず Rundeck の画面にログインして "Jobs" タブをおしてください。

→

    テンポラリジョブをつくるためには、まず Rundeck の画面にログインして "Jobs" タブを押してください。

押してください
pretty nice :+1:
Don't use `APPSCALE_HOME` - use "/etc/appscale/my_private_ip".
PRC doesn't have any requirement to maintain compatibility, but it might still be useful to try an int fallback if the string lookup fails.
I changed that elif statement so it should catch anything not in the exact format "gh-#" where the "#" is a whole number.
I think the introduction as a whole could have a little more love. A agree with Ben that it is a build system, but it'd be good to mention that gyp is different from other build systems in that it can be used as a module system to some extent.
Should this return Sburb?
Please no one-liner ifs. Add the braces.
Is there a reason for rendering a template here as opposed to just redirecting to the target.  It means we're effectively serving a redirect with a 200 status code.
I'm not particularly familiar with bzr or bzrlib. Does this give a remotely accessible URL? Having the repository value is probably most useful when it is, so I'm slightly reluctant to add code that sets it to something that isn't, by default.
I meant specifically in the changelog.  When people go to pypi.python.org and try to see what changed in version X.Y.Z, it's very nice to have a clickable URL where you can read more about the bug (why it happens, how it's fixed, *does it affect me?* etc.).
yea, tried this. does not work too
I'm not sure I understand composition. Some use cases (+ deprecating subviews in master)  would really help for me.
I think he's talking about the `create` action here, most of that code should probably belong to the model :grin:
It looks like [Hixie isn't too hot on having classList added to the SVG DOM](http://lists.w3.org/Archives/Public/www-svg/2012May/0000.html). That shim also only adds it to `HTMLElement` (if it exists), not to `Element`, so I don't think it would work without changes.

What do you think?
A symmetric method to the existing `preordered_each`.
Maybe the :zeus => true should set the :bundler to false?
Is there a test for this endpoint?
Exploring escaping search term further leads to few answers:

1. http://stackoverflow.com/questions/3446170/escape-string-for-use-in-javascript-regex
2. http://stackoverflow.com/questions/3561493/is-there-a-regexp-escape-function-in-javascript (this is also recommended by Simon Willison in http://webcache.googleusercontent.com/search?q=cache:http://simonwillison.net/2006/Jan/20/escape/)
3. http://xregexp.com/ 

Solution 2, seems simple enough to use. I also simplify 2nd regex to do just what is needed atm.
remove this comment if not used
Can you comment why tab-firefox if that's intentional.
I don't understand comment about `sourceURI` what do you mean ?
border-box is already set on *
Comments lost here :(
@daniel-pittman Since windows paths contain ':', I think you want to split from the right instead
If you are going to have a multi-line function call like this, please enclose the arguments in brackets.  Much less confusing on first glance. :)
Agreed. I think the rules we have make sense for most applications which have at least visitor/user/admin, but if the guideline makes no sense for an application, don't follow it.
`getElementsByClassName` returns a *live* `NodeList`, so iterating over it with `for` will break. Using `querySelectorAll` would return a *static* `NodeList` that could be iterated over with `for`.
ehm ... indentation ... please don't punch me ;-)
Why this test?
This class is only referenced in the DocBlocks.

IMHO I don't see any reason for use PHP's instructions for something that is only a comment.
use a getter here for the dateTimeFormat
`*/ `must be have his own line.
I wonder if we should do this, or provide an alternate layout view model instead?
It's a Java class for reflection : java.lang.reflect.Type
These usings were left by mistake.
This could be skipped as this variable is used only once.
```java
public Class<? extends LivingComponent> getComponent {
    return component;
}
```
It was the easiest way to get the styling to be like the other buttons here.
Prevent multiple instantiation by having a private property
yeah. or 
```
context_dict={}
context_dict.update(site_config)
```
``copy`` looks nicer.
but I'm not sure if it's an issue at all in this case.
outside try?
Please change it to simple (without `if`):

```
$extraParameters['scope'] = $this->getOption('scope');
And this caused an extra periodic update loop after each resume from sleep.
What happens if there is no user agent given? Does this property even exist in the dict?
no i didn't
Capital M.
I think this should be 
```python
def add_profilepic(args, user, **kwargs):
    client.login(email=user.email)
    photo_path = os.path.join(os.path.dirname(__file__), 'profile-photo.jpg')
    
    with open(photo_path) as f:
        r = client.post(reverse('profile.edit'),
            dict(first_name=user.first_name, last_name=user.last_name, photo=f))

    if not settings.ES_DISABLED:
        get_es().refresh(settings.ES_INDEXES['default'], timesleep=0)
    client.logout()
````
Shouldn't this be

<pre>
nodeName.toLowerCase() === "video"
</pre>
Feel free to do so, I'm not ennoyed by long lines :p
I removed the unneccessary pointer receiver and added implementation for wde/win LockSize()
I couldn't figure out how to get the `source_location` from a `CookbookSource` though. I figured this was the best start.
Now I know I'm being really picky, but there's no need to set this explicitly, since **NSNormalWindowLevel** is the default.
Private methods have __ (double-underscore)
There's two requests happening here to Github.  One is when the new repo page loads, another is the VCR cassette.  Although in this test the first request isn't made (the user is not signed in), when I first started playing with it the cassette needed moving otherwise it would fail on unrecognised requests.

Generally speaking I only try and wrap the relevant event in the cassette in case anything else is going on
For each image in the query, the algorithm goes like:

* Get the image's serial number. If it's missing, give it a serial number and register a `$(document).unload(...)` callback that will free up all of the event handlers on page unload to avoid memory leaks.
* Populate the passed-in `options` object with defaults.
* Unbind any previous `"breakpoint"` event handler for the image.
* Bind a new `"breakpoint"` event handler to the image (see notes below about how the handler works)
<i>small nit</i>, use single-quotes - <code>'ul.personas-grid div.persona-small'</code>
okay, it seems that this is also done in other parts of the test suite, I'll change this in a later commit.
Yeah, I noticed that you made a commit about that.  It's not obvious from the code, however; can you add a comment, or a docstring, about why it's implemented this way?
Maybe pass the other types along to Vimeo, if we know they're supported?
I can see why you want these, but wouldn't these be better placed outside of the api?
Making the function synchronous would involve changing `readdir` and `exists` in `io.js` to be synchronous as well because of the call to `IO.getFileListForFolder`. I don't think we necessarily want to do that?
In theory, this function should be able to use _.extend.
`isGlobalAdmin` can be reused, fixed.
I was thinking about it, and couldn't make my mind what's best. I thought this could be easier to test, but in the end I tested it through the ScalaProject anyway. The thing is that this trait needs only very few things of the full `ScalaProject`.

I am slightly against self-types when there are alternatives, but maybe in this case it's ok.
Should be moved to the companion object.
s/error/errors (still my fault :-))
I would reorder and reword these recommendations slightly to the following:

1) When starting a new project always start with the latest stable version available. That is, the latest available GA. So, at the time of writing, you should be using Liferay 6.1.1 GA2
2) Always update to the latest maintenance version available for the functional version (major or minor) that you are using. For example, if you started your project with Liferay 6.1.0 GA1, it is recommended that you switch to GA2 to take advantage of bug fixes found by other Liferay users. If you have a subscription you can benefit from the fixes faster by requesting the support team for Fix Packs and Hot Fixes.
3) You are very welcome to use any preview, beta or release candidate version. .....
So if 'exact' is specified, it will no longer be an index-file-only read, correct? - Yes
In this case, don't we still need to control the rate at which hasKeys shall be used? - define "control". Do you mean throttle? If yes, then "exact" being false is precisely what the user would want to use for quick lookups. Unfortunately the current format of read-only files does not permit us to do exact matches without looking at the data file.
lets stringify once to avoid multiple calls to it
`Host.Filename` is always null xxx, so local images are never shown as this returns null. The filename of the displayed document needs to be passed to the host when it is selected.
Согласен, но в данной задаче если различная длинна массивов то это бы противоречило условию задачи, следовательно где-то что-то не так работает. Следовательно если различная длинна массивов то дальнейшая ее работа не нужна.
dna заполнится только 3 символами, а не всеми 4.
...

i see what you did there @brentlintner.

Shame!
Shame!

and mad kudos if this fixes it ;)

so we don't need to add ripple to the node_modules anymore?  #awesome
Make capitalization of 'Ruby' consistent across the doc.
What if top already is documentElement?  I.e., if you're passing documentElement.
Are you retrieving errors about this change ?
Thanks for the explaination - will update.
These comments should match up with the tests given below.
I'm not talking about the module. I'm talking about the whole file "task1.js" it's not used anymore.
dear haddock: amit hates you :)
check GHC version for consistency
These two I don't understand as the whole body is evalating when #'encapsulate executes it, but otherwise arg-list and basic-definition are undefined.
The above 2 lines should be removed and a file comment should be placed at the first line
this should use the ``:class:`` notation to link to the API doc
Pygments (used by Sphinx for the syntax highlighting) supports ``apache`` as format to highlight the syntax of apache configuration files
Typo. Could use form 2012-09-21 for easier machine parsing.
What's up with all this wasting developer time?
Needs careful documentation since it is a mutable class with non-threadsafe members. Also RichMessage doesn't really say anything.
What is it's usecase?
@vals would probably say to use string.format() instead when building strings, i.e. "dispatching command: {:s}.{:s}".format(func['controller'], func['label'])
bin-root will eventually be a helper to determine if someone has a configured value. In my opinion its a good thing when the chocolateyInstall.ps1 has less and less lines and still achieves the same result (and better as chocolatey functions are built up).
Ok, I'll change it. I wasn't sure about the best way.
Thanks for the suggestion.
Does this file (instance/status.py) not fall into the models.py concept?