labofsahil/github-event-dataset-2012 huggingface dataset:
Hi, what is this supposed to change or what is it supposed to improve?
Thanks! I have taken care of this and pushed the changes
Derp "when calling the LevelUnload Event"
Updates committed in c81e01fc2dc06ee87392bffa80a2852b437aa768.
Yeh, I think this needs its own thread :)
I prefer moving it to controller_Items.t since the test relates to Item Controller. And I will move the login part into controller_Login.t as well.
Have you solved the problem of the driver complaining that the URL is invalid?
dit is geen bugfix jo :P iig zorgt het ervoor dat als je done klikt de map ontvangen van de server wordt weggegooid (maar niet de teleports... die zitten in game.teleports). dus als je tussen twee sets rondes de map bekijkt maar geen veranderingen maakt, raak je de map die voor het spel wordt gebruikt kwijt, want bij geen veranderingen zal de map niet opnieuw worden ge-aired. in de editor blijft de map nog wel staan.
wat was de bug die je probeerde te fixen?
That's a good question
What is supposed to happen when `fields` doesnt contain any of user, status, or task. It seems like we should have a set of fields and add user, status, and task since issue #55 says they must be included in the view.
dac (:
You have to put the tarballs in the repo?
auch nicht mit Youtube HD videos ?,

Ton beim Abspielen von HD videos ?

Front Kamera ?

das waren, glaub ich, die Probleme in der Vergangenheit mit zu aggressiven Einstellungen,

ich werd das jedenfalls mal eine Zeit lang testen

Danke !
Not sure about all the specifics, but we may want to expand on this to update mock data (so that image lists will contain the newly created image).
I checked for Y.Lang.isObject() because that is the only type that should be passed to Y.QueryString.stringify.  Anything else (string, null, undefined, etc) should be passed straight through.
This sort event is quite similar to that of the sortable function in composer.js. We can define a common a function for it, or event better, extend the sortable plugin so that both composer.js and outline view can use this new plugin.
add trailing `/`. :)
Just a minor remark on this : I would prefer the method name ```getExceptions()``` instead of ```getErrors(()```...
Typo: should be Canonical
next time i ll code in french :P
Maybe. I thought the symmetry of bindClient/unbindClient was nice.
This should be probably in some trait instead. One responsibility is getting the capacity values, while another one is assigning weights. WDYT?
Yes, but if you keep interrupting a thread, then I think you should be punished.
a @ _ ?
What happens with messages in the mailbox between the Failure message and the Start message being processed?
Not too keen on `diffRaw` any other suggestions? Calling it `diffRest` or any such nondescript thing just for the sake of it feels wrong.
Added:
You can access the ``CamelExtension`` inside a `Producer` or a `Consumer` using the ``camel`` definition, or get straight at the `CamelContext` using the ``camelContext`` definition.
it can't be correct to not keep them together, do you mind if I place them in a Tuple2 instead, or did I misunderstand the suggestion that one drives the other
the question is not about “allowing”, the try-catch here is just for robustness.
Do we really want to add this setting to the GUI? This option is an advanced setting, you really have to know what you are doing and what it does to enable it. I can see this causing a plethora of bug reports due to people setting this when they shouldn't, as the majority will not want this enabled.
We can just import matplotlib.pyplot -- matplotlib.pyplot.cm.hot is the colormap we use later.
Ah now I see why you used goto. Sorry I read the code wrong. Yeah we should bail out on the first error so I guess the goto is needed nonetheless. It doesn't make sense to run CleanupAlbums() or CleanupArtists() if CleanupSongs() already failed.
Sorry about that. Hope you can get your previous work back with "git reflog".
do we need this ifdef? m_ImonConflictsWithDInput should never be true on other platforms?
also, please name it m_bImonConflictsWithDInput
Ah I just noticed - you should be calling _set_value, rather than set_value here.
Nee klopt. Ik zal voortaan meer gebruik maken van .gitignore
I appreciate the rigorous docstrings. FOH REAL.

No need to specify "returns nothing" though.
inputSchemaTupleFactory = TupleFactory.getInstance() here?
this information could be a boolean field in GenContext
I removed the merging with `CFG` because it is merged again in spawn_process which makes the merge superfluous as long as spawn_process continues to merge configurations.
I think dataFormat is enough :)
Same goes here, please include "Berker Peksag" as an author too.
I think it's necessary since you have to use the compile script to create the phar.
Try : 
```ruby
try += 1
```

instead ;) Looks better.
The indentation is a bit wacky in this method. Can you make sure it's all tabs?
I just experimented with this, and it seems like overkill to convert the string to a `CTLineRef`, truncate it, then convert it back to draw. This method is simpler, acting on an attributed string. Until I figure out how to ease this transition to/from `CTLineRef`, I'd prefer to leave it like this.
Fixed it using `note.object`! Do I get brownie points for using a roundabout but concise way?
> Could you expand on what a http error is?

And that too ;)
What do you think about making the timeout configurable ?
I'm not sure that it makes sense to create a parent output class if something as minor as the description string breaks it...  It breaks the proximity rule and IMO makes the code more confusing.
What's going on here? Remind me whether the `PyArray_MapIter` API has been merged into 1.7? Because we can't change the numeric value for `PyArray_MapIterNext` after it's been in any release; that would be an ABI break.

Also, didn't we just decide to export a simplified API that doesn't have all the weird rules that New/Bind/Reset do? Why is that changed here?
The ```+\```'s are unnecessary when within a list or tuple (the strings will concatenate automatically). A small detail, but important because we're trying to remove these from QIIME as we come across them.
Should this function (and _quantile) be moved to qiime/util.py? In the future, if any other script needs to compute quantiles it makes more sense to be in util.py...
файл заменился скорее всего при решении конфликта. попробую вернуть.
Just use "Content-Type" instead of ActionDispatch::Response::CONTENT_TYPE
Now I'm wondering whether this part of the migration make sense here, thought?
I think we can remove a lot of duplication splitting this method in `column_spec` and `prepare_options`
I was thinking just simply `hash` or `other_hash` Anything is better than `h2` honestly
I don't really care that much, but I hate stuff like this just for the sake of saving one object allocation. To me:

``` ruby
Hash[o.map { |field, dir| [field, dir.downcase == :asc ? :desc : :asc] }]
```

is way cleaner and easier to read.
Shouldn't we override `initialize_dup` (or copy) instead? [More on @jonleighton's post](http://jonathanleighton.com/articles/2011/initialize_clone-initialize_dup-and-initialize_copy-in-ruby/)
Yeah I agree, `middlewares` is used everywhere, not that big problem, but perhaps we can avoid adding more. I remember seeing the rack discussion yeah :).

I think `the middleware` is good enough, but we can wait @vijaydev to review it later and give his opinion on the subject :)
Thanks!
I think you can give a block to `assert_file`, to receive it's content as argument, and assert against it ([more](https://github.com/rails/rails/blob/master/railties/lib/rails/generators/test_case.rb#L88)). Something like:

```ruby
    assert_file "app/controllers/test_app/account_controller.rb" do |content|
      assert_no_match /^\s+$/, content, "Don't indent blank lines"	
    end
```

Could you give it a try? Thanks.
@josevalim thanks.

Yes, i'l add `index_name` setter.

This generates index only for attr if `index` option passed, if not, it will be skipped. But the approach you proposed more clear.
The quote changes are completely unnecessary imo.
I'm thinking scala/tools/nsc/package.scala.  Why punish ourselves by hiding it in partest.
Conformance to `scala.annotation.Annotation` gives exactly nothing except for a few hardcoded cases: http://groups.google.com/group/scala-internals/browse_thread/thread/22fa25dca37db40d. I'd remove the reference to it from here.
Can I definitively assume that names coming out of reflection APIs are supposed to be decoded?
Needs also ``import matplotlib.pyplot as plt``.
Please remove the ``requires matplotlib``.
typo, "spectral"
it's an exact duplicate of a test a few lines away (that I kept)
yeah that is unnecessary i will change the code right away
Does `from sympy.unify.rewrite import blah` work without it?
(unless rep is a global.)
The "magic" is, I believe, the ability to tell SymPy that `a**2==2`, without explicitly solving for `a`. Leaving it as XFAIL for now.
By looking at [`is_commutative` and `is_associative`](https://github.com/sympy/sympy/pull/1633/files#L9R8), I understand that `Compound.op` is a class (like `Add` and `Mul`).  Therefore, neither `x.op` nor `y.op` is a `Variable`, a `CondVariable`, a `Compound`, or an `is_args` type.  But then this function call will never do anything useful and I'm obviously missing something huge.  Could you point out what exactly escapes my attention?

(Stopping here for today, will continue tomorrow.)
If it's possible, I am actively voting for dropping `_mat` entirely.  Three-letter names usually make me feel nervous :-)
actually, rather just `\,`
Explanation sounds unclear: please add the description for array translator option.
WHat if there's more to their AppBlade URL than host and port. What if they're hosting the appblade service on some other server that is running many services and have to move the appblade service to hostname:port/appblade or hostname:port/mdm, etc?
Actually lucassus is a friend of mine, so hmmm... I don't expect him to hate me for that ;-)
"継承しており" is correct.
Should we keep the XML in sync too, i.e. add parsing logic to the XML parser module?
prefer the alternate.
This is a function: 'run' is precisely the correct verb.
This looks like it should be `Project:Copyrights` - no leading '/'
If we have a docblock, we might as well explain properly that it's for converting the old 3.0 values to 3.1 class names.
I don't believe php closures or create_function are easier to read.
Since it's a comment over multiple lines I should probably also change it to `/* */`, right?
Then a note should be added in this file that it is not subject to our standard rules.
Some would consider it a cleaner/more straightforward api.
As long as variables are not scoped to different functions than the ones they are used in I will be more or less content.
The docs are wrong here. Lock acquisition does not fail, it blocks forever.
I got that. ;)
Hmm, didn't quite get what you mean. Both methods return a object in the same form of {moduleName: res}, in the case of yuiRess, they are fake "resources".
I think the answer is yes. We have open bugs/pr's for this if I read the context correctly: https://github.com/yahoo/mojito/pull/285
I just tried that, and using Y.Test lead to the tests not being run.
What is "prc"?
>     I would decouple the asciidoc upgrade, except that flactag needs asciidoc to render manpages during install.

We have the latest version of asciidoc in Nixpkgs; I've committed an update a few days ago.

>     I would like a stanza to include in my .profile that would run all the setupHooks of all of the packages I've installed in my ~/.nix-profile.

Yes, on some occasions having that mechanism available would be quite useful. In general, however, the setup-hooks create an environment suitable for *building* the package. That is not necessarily an environment suitable for *running* the package.

>     I'll update makeWrapper and add a -setup-hooks flag that will call the setup hooks of the buildInputs to be called in the wrapper before executing the command.

Right now, the only `buildInput` of the asciidoc package is python. So, as far as I can tell, there are no hooks that would set up $XML_CATALOGS, etc. How do you plan to deal with that issue?
Can we use Util.dateTime(time, 0) here?
> (The best solution would be for coord_dims() to return a copy of the array)

The best solution would be for it to return a tuple would it not?
What about partials?
dimName， dimValue是不是不太好理解？能不能简化？
maybe it was changed by accident. can you change it back?
This method would be clearer and more efficient if further re-factored:
    	Don't return a token from parse / don't use it as a success indicator -- indicate success by boolean return from parse or BETTER YET just return void and indicate failure by exposing the HSQLException that caused it.  This avoids building the parseToken when all we need is a "parse success flag", would remove one case of m_recentErrorMsg hack, and enable the next step...

    	Don't include the parameterize flag/behavior in parse -- have a separate parameterize() method that converts the m_xmlSQL to m_parameterizedXmlSQL or (on failure) leaves the m_parameterizedXmlSQL null  -- parameterize() only needs to be called (optionally?) by PlannerTool, not StatementCompiler, clarifying the simpler StatementCompiler code path.

    	Return the parseToken via a createParseToken() accessor only when it is needed for interfacing with the cache (i.e. when "cacheable" after successful return from parse). The accessor would transparently operate on m_parameterizedXmlSQL or, if it is null , on m_xmlSQL.
Please drop all of these `self.fail` calls, they don't really add anything (a comment is much more useful) and they obscure tracebacks.
Use `$(..)` vs. '${...}' for variables.
should use logger errors
Use letfn
why declare without assign?
Just pushed my work-in-progress onto branch avital-pr-572. I'm going to rename the accounts_github.css, etc files and then I think I'm done.
Well I just merged my fix, shouldn't have this error get to here anymore, so you can remove your extra code.
That could work, but I need to import the socketio basenamespace because the WsNamespace class is based on it, so I already import socketio, and via that gevent. Or is it possible to first create the class and at do the basenamespace stuff at runtime?
Strike that--these templates use 2-space indent and should be 4.
Emacs lines things up based on level. So the 1 character indent is because 'title' is right after the {.

I could change this to:

```
return render_to_response(
    'admin/search_admin_view.html', {
        'title': 'Search',
        'mapping_type_stats': stats,
        'indexes': indexes,
        'index': get_index(),
        'error_messages': error_messages,
        'now': datetime.now(),
        },
    RequestContext(request, {}))
```

Mostly I just used whatever Emacs does indentation-wise.
Buildtime dependencies (deps which aren't required after the formula is installed) should be marked with `:build`:

```ruby
depends_on 'cmake' => :build
```
Yes,  configure fails:

configure: error: parallel-netcdf requires an mpi compiler. Please specify
	the location of one either with the MPICC environment variable or the
	--with-mpi configure flag

I assumed that `depends_on MPIDependency.new` was enough, but setting both the environment variables and using `--env=std` (or `env :userpaths`) is required or configure fails.
This needs to either (a) test that the software works or (b) be removed.
>>  try:
>>      from traits.ui.api import View, Item, VSplit, HSplit, Group
>>  except ImportError:
>> -    from enthought.traits.ui.api import View, Item, VSplit, HSplit, Group
>
> I think we actually want this the other way around, since traitsui is the newest version?

whatever works :) but +1 yes
C'est pas une très bonne idée de rajouter des caractére. On peut très bien trouver un autre groupe de 2 lettre plutot non?
Oui c'est sûr (pourquoi ce commentaire ici ? :p)
Why can't we move the `attach_boolean` call into the MusicSetupVBox?
i love strict mode ...
We need a check for the odd case that this returns None.
Component-wise maybe? 
```
map(int, riakasaurus.VERSION.split('.')) >= [1, 0, 6]
```
This looks good from the perspective that it follows the migration system rules, but we might want another member of the Pulp team to review this migration to ensure it does the intended thing, as I am not yet familiar enough to know our DB structure and what not.
i18n lesson time :smile: Don't "build up" translatable strings like this. Just create one message:

`message = _("comparing revisions from %(date_1)s and %(date_2)s") % {'date_1': timesince(version.date), 'date_2': timesince(version2.date)}`

You'll also notice that the format args are now named. This is generally required so that the translator can reorder the inputs (in this case, it really wouldn't matter, but the toolchain will still bark at us).
ThingJsonTemplate is for wrapped things as far as I know, I will need to look into the difference.
Nothing wrong with nit-picking. Consistency never hurt anyone. Have you considered adding rules like this to your checkstyles rules?
Why are there two checks for Memcache PECL?

Also, shouldn't those `if`s be `elseif`s?
Line break before this line.
please use @wrapAccessor for this
This could probably be its own method, like `clearPromises`.
We don't need this line any more. This is causing issue #1383 and pull request #1445 moved this line of code to line 298.
On my MBA, I did 5 runs of app startup on each branch and saw my sprint14 branch at ~1.2s and master at ~1.3s. I'm guessing it's negligible.
Not sure why, but I wasn't seeing the change.
Maybe here or later in the JSON export workflow we should add ``BuildInfoUtils`` to tag this data with the branch and SHA.
Same as for the options() function above. This isn't necessary.
This isn't a super huge deal, but code like this is very procedural... I wonder if we can get some more objects up in here. ;)
I still pretty strongly disagree with changing the default on this. Documentation has always been "without remorse", signifying that a `SIGKILL` would be sent. We've demonstrated that the worst that could happen now that we're properly resetting the traps is that a `SignalException` would be raised, but even this could wreak havoc in the event a runaway-job gets this raised somewhere that it gets caught, if the user is expecting this to be "without remorse".
Tiny thing. People differ on whether this is necessary, but our JS style is to always put semicolons at the end of statements. I think PyCharm will generally warn about this.
What if I had CaseDisplay as a normal class in outer scope that takes report in as an argument, and then have this property instantiate one? To me that'd be more intuitive.
same for this ID
Is this necessary? It looks to me like we could can safely assume that if SelectedSeason is null, foundSavedSeason is false. Am I wrong in that assumption?
This happens and should be fixed everywhere in the submitted files.
I do not understand the question above. What means native tags without new template? Why new template?
It is written in documentation of [django-pushserver](http://readthedocs.org/docs/django-pushserver/en/latest/usage.html):

```
from django import dispatch

from pushserver import signals

@dispatch.receiver(signals.channel_subscribe)
def process_channel_subscribe(sender, request, channel_id, **kwargs):
    print "Subscribed", request.user, channel_id

@dispatch.receiver(signals.channel_unsubscribe)
def process_channel_unsubscribe(sender, request, channel_id, **kwargs):
    print "Unsubscribed", request.user, channel_id
```
Probably spacing.
more commented out lines left in
Looks like a comma's missing here before " + popcornOptions"
ohhh man.
Ah good call, ignore this then
the `text.join('')` performed only once in UI layer. however but we are using the push to and get items from text and dirs in multiple locations. I would say we store the text and dir in one object and use array. We can provide the utility methods to combine the text (or just override `toString`)
logic here is missing fontCharsToUnicode or additional manipulations with `chunk
Macht dass sinn falls vor z.b. Ein post request vorrausgegangen ist??
Was this change intentional?  Just asking, since I've seen the 'unless params' logic used in multiple places w/in the app.
See http://www.hanselman.com/blog/OnTheNightmareThatIsJSONDatesPlusJSONNETAndASPNETWebAPI.aspx
lots of unused properties here
Usual guideline in JavaScript is to use camelCase
My only concern about "all" is not knowing which database it used--what about allowing one to specify a single database, defaulting to all?
I could easily imagine wanting to catch this exception (or any of the other 3 times something like this is raised below), so perhaps it should be a more specific exception type than just `Exception`?  It doesn't obviously fit any builtin types, so perhaps just put ``class LoggingError(Exception): pass`` up at the top of this module?
No need to zero it explicitly. It's an object with constructor (std::pair) and not a POD ("Plain Old Data") type. See  http://stackoverflow.com/questions/9025792/does-the-default-constructor-of-stdpair-set-basic-types-int-etc-to-zero
Remove "static" in this file, and add to util.h:
```C++
extern const int64 nClientStartupTime;
```
I would think it would be better to handle any valid URIs and ignore invalid ones if there are valid ones present, but I dont really think many OSs will give a list of URIs unless you are dragging a folder full of files, and in that case, none of them will be bitcoin:, so it probably doesnt matter.
Did you mean TA0CCTL2?
Not all the msp430's have 3 CCR's. Check for __MSP430_HAS_TA3__ to prevent compiler error for those devices.
Grammar question - to me 'a URL' reads more naturally than 'an URL', because I think of it as spelling yew-ar-el, and I would refer to 'a yew tree'.
Thanks. I really should know better.
no idea, prob inherited form the archetype.
Yes. I mean to isolate call w/input and output for base64 into a test which
isolates the usage desired which isn't present in the 3 other base64 impls
:)
 On Nov 4, 2012 10:21 AM, "David Ribeiro Alves" <notifications@github.com>
wrote:

> In
> labs/oauth/src/test/java/org/jclouds/oauth/v2/json/JWTTokenRequestFormatTest.java:
>
> > +import org.jclouds.oauth.v2.domain.ClaimSet;
> > +import org.jclouds.oauth.v2.domain.Header;
> > +import org.jclouds.oauth.v2.domain.TokenRequest;
> > +import org.jclouds.oauth.v2.domain.TokenRequestFormat;
> > +import org.jclouds.util.Strings2;
> > +import org.testng.annotations.Test;
> > +
> > +import java.io.IOException;
> > +
> > +import static org.testng.Assert.assertTrue;
> > +
> > +/**
> > + * @author David Alves
> > + */
> > +@Test(groups = "unit", testName = "OAuthErrorHandlerTest")
> > +public class JWTTokenRequestFormatTest {
>
> not sure what you mean. you mean testing the
> org.apache.commons.codec.binary.Base64 directly?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/920/files#r2025322>.
>
>
Ayuuup. I fixed quite a few of these mistakes with a static analyzer.
And nvm this one either.
Interesting. I didn't know emails required CRLF.
I decided that the key in redis should be `...::{slug}::{locale}::lock`, where `slug` is the English slug (or, more particularly, the wiki default language). The above few lines are intended to get the English slug, even if the document is localized. Is there a better way? This seems kind of clumsy, and I think it is causing some of the errors.
Should be indented two more spaces.
missing semicolon at the end of this line
hmm, it had seemed like it wasn't working that way at one point, but it must have been due to another error.  I like the $(this) thing.  using that.  thanks!
if this is to bypass the fragment loading you can add `'/ecosystem/'` to the ["blacklist"](https://github.com/mozilla/zamboni/blob/master/media/js/mkt/fragments.js#L17)
This is nicely done.
you could probably skip the "or"

`secure = tag.attr['secure']` should suffice
Yes, my mistake. Fixed in 8d6c89c
nit: this doesn't read right?
@stof Do you want me to reformulate this to:

```
created `ValidatorInterface` and moved the @api-tags from `Validator` there
```

?
It was not needed indeed. I think it was a 'leftover' from when there was no `BundleInterface` yet (?).
keeping them for BC is useless: if someone typehints a FilterDataEvent in the listener, it will fail when passing a FormEvent
@eventhorizonpl Keep in mind that trying to get 100% coverage for the sake of it is not a good goal. We only test for things that actually matter.
There is no render method on the kernel
I'm -1 for the introduction of a `::create()` method in general and I think it does not make sense to add it only on some exceptions.
"To create a Finagle Thrift service, Finagle requiers you to generate, in addition to the regular Thrift `Iface` interface, a `ServiceIface` interface that wraps all return values in a `Future`. Use either <a href="https://github.com/twitter/scrooge">scrooge</a> or the <a href="https://github.com/harrah/xsbt">sbt</a> extension <a href="">sbt-scrooge</a> to compile your Thrift IDLs.

**Note:** scrooge and sbt-scrooge must build with the <a href="https://github.com/twitter/finagle/blob/master/sbt">correct version of sbt</a>."

Something like this? Or should the scrooge/sbt-scrooge install instructions reference the script instead?
Oops, missed that when copying the conditional down.
I believe I tried putting the .pgpass file in /var/lib/postgresql, but that
was unsuccessful.

We had to shelve our "upgrade to Rubber 2.x" effort for other reasons, but
I'll try your suggestion later this week and see if that works.

Nick

On Tue, Jun 12, 2012 at 8:11 AM, Matt Conway <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,5 @@
> > +<%
> > +  @path = "/root/.pgpass"
>
> If you put this in the postgres home directory (/var/lib/postgresql on
> recent 12.04 instance) then it will work for the postgres user.
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/wr0ngway/rubber/pull/151/files#r967625
>



-- 
Nick Messick
nmessick@gmail.com
I agree with the setup/delivery split, although we have a constructor already so two "setups" feels like a half-step.

I have become fond of the `initialize` then the `go`-type of method. I used to do it all in the constructor but that seems weird now.
only swapping tests. Isn't it useless?
这一小节，下面的原先的所有内容都是参考自别的模板，如果觉得不合适的话可以直接改掉的~
竟然用单引号。。。
trebuie, pentru ca, coloana published_on a ramas in tabela tasks, Alex a facut migrare mai sus pentru a adauga reported_for dar de sters published_on inca nu era.
It's not an example file but a test file. 

By the way, something should be automatically tested (e.g. equality between two ranges).
Parse exceptions happen pretty frequently and can flood the logs. Does the laconic filter apply to the exception logging level?
I expect this functionality will be under development for some time, so as I said it's not very urgent. There's also a check is element first or not. And it's always makes iteration over "for" to look ugly. So you can treat my comment as side note for future)
Why have the "wms_" prefix when it's already in a "wms" module?
uuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuuu
Oh, you're totally right, your use case makes it clear.

Let's see how can we get around that callback madness :)
@kselden @wagenet thanks for the notes. I'll adapt the PR.

One more thing - what about this case:

```javascript
App = Ember.Application.create({ rootElement: '.yoyoyo' });
Ember.View.create({ ... }).append();
```

Shall it add this view to the first available application or should I keep additionally the `defaultApplication` stuff?

And for performance reasons: I guess the most case will be a single `Ember.Application` on a page. Wouldn't caching this be faster than *always* check the `Ember.Namespace.NAMESPACES` ... ? So something like:

```
if (only 1 application instance available) {
    append to this
} else {
    check Ember.Namespace.NAMESPACES and try to find out under which Namespace this view lives
}
CS (whitespace missing between if and open parenthesis)
Should be Catalogue Service for the Web (CSW)
You probably want a null check here, otherwise you will get a NPE if the EE subsystem is not installed
There are two spaces after the colon for some reason (happened above too).
The same here (about the article):  with function/methods the javascript auto-semicolon-fail does never happen (as far as i know), so i would like keeping the former syntax that's (always IMHO) more readable...
тогда уж -2 и она отрубит три последние буквы. по факту у нас trueMaxLength = maxLength + 3 иногда :]
We're going to get an event any time a file is added or deleted.  With pictures as the media type this will wake up this app every time the user takes a picture.  So change to "movies" maybe, should be less churn there.

I wonder if you could just register this device storage change listener when the settings app becomes visible and then unregister it when the app is hidden.  That would be the most efficient thing.  grep for 'mozvisiblitychange' to find out how to do that.
in this case 'this' is the dom element that receives the call to addEventListener, I could change it by 'node'
> The biggest change is an alternative way to unlock the screen. For touch users, there will be no difference. Screen reader users get an unlock (and camera) button they could activate.

I am just going to believe what you said and not to test this part of the code.
did you `gjslint` you code?
This is only readable to you (and me) in this one diff only, but not the future :)
We discussed it in previous pull. I've been talking with Fernando and he will create this functionality in other way, avoiding 'anonymous' function if is not necessary.
Hi ;-) Yes, indeed that is what the UX team wanted ;-) Please, check https://jirapdi.tid.es/browse/OWD-11787 (also kind of described in the Bugzilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=806368 )

Anyhow, I do agree with you, but UX guys are the bosses on this stuff... :-)
`getAllContacts`
I will add it! Thx!
why use a `data-*` attribute here?
`settings.createLock()`, please also update many `getLock()` within this file.
I think this part can be done entirely in CSS like assigning the disappearing notification with a class name to have all the notification follows matches to a static CSS transition rule written in style sheet.
Why do you need to reset this._timeSMenuFromScreenOn first?
I tried, but modernizr's docs say it needs to load before css. It's the only one though.
I think you need to use aq_base here to prevent false positives from the acquisition chain. Also, hasattr seems to better describe the intent.

    from Acquisition import aq_base
    ...
    if hasattr(aq_base(obj), ATTRIBUTE_NAME):
```
12-20 16:28:52 <@alindeman> myronmarston: Do you think that nuking `red` and `green` and such (which were `protected`) is a breaking change for custom (third-party) formatters?
12-20 16:29:33 <+myronmarston> alindeman: hmm
12-20 16:29:35 <+myronmarston> alindeman: I hadn't thought about that
12-20 16:29:57 <+myronmarston> alindeman: given that they were not documented as part of the public API, I feel a bit better about it
12-20 16:30:14 <+myronmarston> alindeman: but if it's not difficult, it'd probably be good to add back deprecated red/green methods that delegate to the new ones
12-20 16:30:22 <+myronmarston> alindeman: and then we can remove them in soon in rspec 3
12-20 16:30:26 <@alindeman> myronmarston: That was my thought exactly
```

Does this make sense? Maybe clump them together so they can be easily removed later.
My understanding is that `kill(0, pid)` is fast and reliable and the best way to do a pure process exists check. Use it if you need it. Agreed `EPIPE` looks like it makes it unnecessary though.
I think it's unnecessary to add the extension to the filename *and* specify `format`. Also, you should create the filename once then reuse:
```python
savename = os.path.join(dir, filename)
```
And this would be passed to `plt.savefig` and to `print`. Note: using `os.path.join` is preferred and the check for the trailing backslash is no longer necessary.
I would prefer that you restore this to the original

        call feedkeys(r . cnt, 'n')
        call feedkeys(s)

Register and count should not be affected by user mappings (unlike as they are), only the sequence itself must be.
Help for the CLI needs to be redone like how we discussed on IRC.
Why not write `arguments.length > 2`?
Return the return value of `bindIfOrIfNot` and you can remove this line.
Then we should add the limit, but enforce it when we generate BBCode. That's better also because of it allows admin to change the setting later and enforce it for every existing signature.

And in the end <textarea maxlength="10"> doesn't fix the issue as I can easily remove the limit from FireBug. Settings should never be enforced in client side, they should be enforced in server. Of course something like this is needed to make the feature more convenient to the user. But it doesn't fix the issue.
`if (dest == 'stdout') {`
I think it'd be better to rename it to `to: (type, data) ->`
you can do `gqq` in vim to do this for you.
And in order to leave tags available for other purpose, I think it'd make the most sense to get the tag id's before `thd()` begins.
@StormTide Do you have any links/resources about the fingerprint forgery you mentioned on twitter? Trying to think of how to improve the approach used in Sslurp. Seems to be quite a chicken-or-the-egg problem.
the phpdoc should be on the class, not on the use statement
Looks like you mixed something here. STATUSLED_EMS_TX_SUPPORT is used twice (TX and HB). Not a good idea.
specify strict version is good practice. If you will have merge conflict in Gemfile.lock it can be very tricky to solve it sometimes. If you have strict specify version you can regenerate Gemfile.lock with no problems. Do you agree with me?
Do we want this to always print out?
since this is only conditionally set, I guess checking for null is the correct thing to do to make sure a vhost should be applied?

if (cc) user->ChangeDisplayedHost(...)?
Hi Johnny, 
i thought a header banner is a good real Life example for the fallback block, but the members fallback illustrates the concept and syntax as well.
I think it's probably less hussle to go with the member sidebar, so I'm fine with that..
Can you please document the regular expressions used here and in line 81? They are amazingly complicated and I'm honestly a little worried about the support burden they introduce.
I noticed that converting it back to JSON after creating the correct json event hash is quite redundant when writing this.
But I wanted to avoid replicating the code in to_event(), which adds the type, tags and additional fields.
Maybe that part could be factored into a different method in base, so extending classes can call that?

(Mostly this code:

event.type ||= @type

    @add_field.each do |field, value|
       event[field] ||= []
       event[field] = [event[field]] if !event[field].is_a?(Array)
       event[field] << event.sprintf(value)
    end

    logger.debug(["Received new event", {:source => source, :event => event}])

)
This line is a little on the long side.
We need some JavaDocs here as well.
A few too many attributes have been promoted too high out of text-input. E.g. checkbox does not allow a number of these attrs http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#checkbox-state-(type=checkbox)

> The following content attributes must not be specified and do not apply to the element: accept, alt, autocomplete, dirname, formaction, formenctype, formmethod, formnovalidate, formtarget, height, inputmode, list, max, maxlength, min, multiple, pattern, placeholder, readonly, size, src, step, and width.
I would not put that much of a details I'd rather just say, this implementation is associated with a firefox so in order to avoid naming conflict between addons we prefix them, or something like this.
> I'd say that pseudo modules shouldn't be normalized in first place.

Maybe but, I think it's better than keeping list of exception cases, also via `modules` you don't only pass pseudo-modules but you could also overlay system modules, which go with else branch at initialization but enter if branch at resolution.
@lloyd - As a further change - the GitHub link is now empty content that displays a link to MDN - might as well update here as well - https://developer.mozilla.org/en/BrowserID/Quick_Setup is the MDN link.
process.nextTick here?
As above, there seem to be multiple pages here. Perhaps it's overkill to treat them as such.
The problem you are having is because the call to '''community_page.find_tag_link.click()''' does not return an instance of the TagResultsPage object. What you likely want to do is define a method in community.py which can be used to click on a tag and which returns an instance of the TagResultsPage object. I will add another comment to the code for community.py with an example.
It has been renamed `SchemaReader`
What is a "confinement" ?
This changes it to silently not propagate file and line information if the given error doesn't have that. Do you really want to do this? It seems like this method should blow up if it can't achieve its goal.
@vrthra need `split("\n")`
Again, please observe the coding style. Comparisons to None should always be done with `is` or `is not`.

Also, there will never be more than one binary we're watching with the current setup, so why store its name? We can always do something like `self.fileWatcher.removePath(self.fileWatcher.files()[0])` (NB: untested).
I might be wrong here, but wouldn't it make more sense to connect ``enableButtons`` to the ``inferiorIsRunning`` or ``inferiorStoppedNormally`` signal of ``self.signalproxy`` and drop this function?
hm nope, seems to work fine…
Sure. A la http://stackoverflow.com/a/2308157/709537 . Just make it work! ;)
Hmm, why is `portnumber` commented out? In other code it is used as `qeth_configure -n $PORTNUMBER …`. And that reminds me that the AY parameters are not documented.
Why do we have a diff on the entire file here? It looks like you are using the wrong line endings (should be unix style "\n"). Also verify the other files you modified.
This bracket must be go inline with the if
I meant the comment. Not sure on the latest status of the annotation (I'm assuming either one of you know ;))
`fanne l'escape` -> `usa l'escaping`
Add a space between the "if" and opening paren.
Probably is best do `return parent::setHydrator(...)`
I am new at github, and I don't now how to edit/add multiple files at once. I've got this file created. If someone can tell me how to edit/add more than one file, please tell me.
Hah! This is what happens when the only hacking you do all week is on Sunday night after a beer or two. Thanks!
It's PHPStorm fault :'( It _fixed_ this without my knowledge =)
It looks like some dead whitespace snuck in. If you use Eclipse, it's auto-formatter is pretty good for this sort of thing.
EntityDamageEvent is an event in SpoutAPI, not Vanilla
Brunch 1.4 apps are compatible with brunch plugins 1.0, 1.1, 1.2, 1.3, 1.4. That’s just a convention, like in rails. Plugins aren’t upgraded as often as brunch etc.
https://github.com/azavea/OpenTreeMap/blob/80f911f1224c4d8c4031d9c554d7768094d31e86/treemap/views.py#L1487
Adds the "present=True" filters.

Speaking of edge cases, I wonder what happens if a plot is marked "not present" but a tree isn't?
you should **never** flush from a listener as the listeners are called during the flush.
The second line of the description should probably be aligned with the first one here. Aligning it with the ``@return`` tag itself makes it less readable IMO
``->getIterator()`` is not needed here thanks to ``\IteratorAggregate`` on the collection
this code was again copied from CouchDB /cc @beberlei
The value of the constant ``HYDRATE_PHPCR_NODE`` is the same as ``HYDRATE_NONE``, its an alias. My reasoning is that we don't do any hydration on when we return a raw PHPCR node, so ``NONE`` makes sense there, but then again its nice to be explicit. But i don't like having two constants that mean the same thing. Maybe better to keep ``PHPCR_NODE`` and drop ``NONE``?
A few comments about this:

* The Ruby idiom for a method like this that returns truthy or falsy would be to append a `?` to the method name.  Based on that, this would become `voted_on?(votable)`.
* Since you're asking `Vote` to get a list of entities this user has voted on, you should look at pushing this logic to the `Vote` class -- an API like `User.first.votes.contains?(Article.first)` is possible here.
* This query is inefficient -- you have to load a bunch of objects into memory to select the one you want -- a better implementation would be to use a specific where clause and use COUNT in SQL.

I can help you refine this if you get stuck.
Session is part of the request object, which is contained in `$event`, so no need to use the container here.
I would rather generate a ul list if the field is configured to store multiple countries and keep on generating a paragraph when only one country is expected (like what is currently done for ezselection for instance)
This would give something like (not tested):
```twig
{% block ezcountry_field %}
{% spaceless %}
    {% if fieldSettings.isMultiple and field.value.countries|length > 0 %}
        <ul {{ block( 'field_attributes' ) }}>
        {% for country in field.value.countries %}
            <li>{{ country['Name'] }}</li>
        {% endfor %}
        </ul>
    {% else if field.value.countries|length() == 1 %}
        <p {{ block( 'field_attributes' ) }}>
        {% for country in field.value.countries %}
            {{ country['Name'] }}
        {% endfor %}
        </p>
    {% endif %}
{% endspaceless %}
{% endblock %}
```
tab used here? please only use indentation with spaces
import graphviz has been moved, only performed when needed now

I'll only output files that are requested, is better imho
I don't really like that there's a version string right here. It allows for the possibility for it to fall out of sync with the version in `package.json`. Is there a good solution for this?
No `<label>`?
Spaces after the colon plz.
Created #411 to deal with this. A subsequent pull request breaks out the LESS into separate files, so the change will most easily be made after getting that merged.
Can you update the above array usage to be consistent?

The previous usage might be incorrect, so the solution might be to change the old way to look like the new one you added. I am not picky, because they both look good to me.
I already migrated this file in a previous pull
removed dup method.
isinstance(top_left, (list, tuple))
The use of `self.context` here is a little confusing.

I think it blurs the algo context which would be populated when an algorithm uses the interface provided by https://www.quantopian.com

i.e. if you're keeping track of something with the algorithm, I think it's best to just assign to `self`, for now, to keep with the current zipline algorithm paradigm.

Though down this line this might be a way to bring both interfaces inline.
Do we really want this? liq files are not garbage. Sure, there shouldn't be any in src for now, but that's true of many folders.
the validation in ssh provisioning is what pulls in the image_uuid variable, so I duplicated that here.  I was uncertain where else I could add it.  The reason it needs to happen in both is that a compute resource  can be provisioned without needing ssh to bring it live.
Sorry, I thought I had deleted the extra entries here back when I deleted the "pra|prb|prc..." part in APS.js as well but apparently not.
A simple illustration of the aforementioned bug:

```
~/C/C/CocoaPods [croach-clean-paths-fix] » irb
>> Dir.glob('foo', [File::FNM_DOTMATCH, File::FNM_CASEFOLD])
TypeError: can't convert Array into Integer
	from (irb):1:in `glob'
	from (irb):1
```
What is URL. Is this the islandora URL? I would have thought it would be the Fedora URL?
yup, good catch - replaced with 'xslt' now
I think these look better when they are not bolded, because it makes the numbers a bit more obvious.
We're working on figuring out the best way for say to handle arbitrary tables of strings, or if that even belongs in say; this will be refactored out at some point.
`most people` -> `a lot of people`; you haven't spoken to them all.
D'oh!  should have constructed this check better.  Robot fingers, you know...
since this is a shared utility, this text should probably come from a django setting with a much more generic default.
а какой именно великий русский поэт удаляет итераторы?
у тебя в этой функции утекло просто бесконечно памяти
You can avoid the second join by using a left outer join and setting a flag for whether or not there was a rhs
same this this on 1919
Sorry, where are we waiting for the login page to be loaded? I don't see that.
this English doesn't really make sense. It should be `sorted_by` or somesuch.
/s/gox/fox
What is this needed/intended for?
`item` is pretty generic.  If we're renaming things anyways, can we rename them for clarity and make this `get_video_data`?
So, yeah, this function seems to just be returning `nil` if we get a valid (but not successful) http response.  It might be better to do something more here, like log the error code or response or something?  I didn't change it because this is how the code has been working all along and I'm not 100% sure if it buys us anything to change it... but I'd be happy to if anyone has a strong opinion.
Not sure I follow you here.  If they pass a keyword for `fn` I want this to fail...
I added `(.*)?` but then it wouldn't match anything so pattern is not regexp.
You feel so confident to not add a wildcard case? :-)
i have some vague recollection we did this sometimes and had to remove it because during route generating, things explode with the standard symfony router. did you try if generate still works properly even if the route object is in there?
not in symfony2.2 current master....

but indeed we should check the version. if we have 2.1, we can: 

* create a new UrlMatcher instance with the right parameters
* or hack around with introspection to chagne the private property

what sounds better? create a UrlMatcher that we proxy to?
I was wrong, you look up to date enough. You shouldn't use a regex though, use `mrjob.parse.is_s3_uri()` instead.
Waarom dit?
Use just 1 tab for separation (after removing `@access` lines it's pointless to try to align to them anyway).
@savenko сам преподаватель к одной из работ указал, что в этот метод мы передаём проценты, а то, что у нас 100 элементов - счастливая случайность.
Учтено, что не будет произведена замена одного и того же элемента в массиве, но не учтено, что элемент может замениться на такой же. Например, `@"A"` может замениться на `@"A"`. Как следствие будет заменено меньшее число элементов, чем требовалось.
Здесь создается NSArray с нуклеотидами при каждом вызове метода, т.е. при инициализации объекта Cell это происходит 100 раз. Чтобы этого избежать можно, например, создать RO поле nucleotides, заполнять его в init и выбирать случайный элемент каждый раз из этого массива.
readonly-свойство создаст только геттер.
Нет проверки, что заменили не на тот же самый символ.
Я к тому, что это плохо-читаемый код, имхо.
а почему именно здесь эффективнее использовать _DNA ? в коде других людей, я видел комментарии, когда писали, что лучше использовать self.DNA вместо _DNA так как это вызывает сеттер (или геттер, я запутался).
Логично
IMHO, в данной задаче такой задел на будущее скорее всего не нужен и выглядит некоторым излишеством
Лучше генерировать исключение, да. Но это не влияет на оценку. :)
Да, обращаться можно только внутри класса Cell, по имени класса т.е. [Cell generateRandomGen];. В main метод не виден не через экземпляр, не через класс.
Как быть если длина ДНК в объектах будет разной?
Освободит. Но при этом будет выделять память, которую не будет использовать. 
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
Please try to respect 80 chars limitation on lines :)
This is supposed to set the durability...
Can you just add your @author Cindy Li right under the previous tag and not adding it to new comment block?  Thanks!