labofsahil/github-event-dataset-2012 huggingface dataset:
> Is this even what you meant?

yeah!

So,

 - Change the gu.prefs 'module' to listen for things happening and stashing them as preferences?
 - Make it a module (so we can pass it in to each module if we want it - Eg, so we can read preferences).
 - Refactor the commonJavaScriptSetup and article

On that last note, the reason why the localstorage stuff was stuck there was that it needed to happen *before* everything else.

In wondering,

 - Use [https://github.com/jrburke/almond](Almond) to define any non-domready javascript inline (or an external blocking call?)
 - Keep the current bootstrapping process for the bulk of the application.
Not in the current version of universal_robot. We can submit a patch but have to handle it like this for now.
I guess i was assuming that the only people who could even see the ticket is the person who created the ticket and the admin, so I didn't think we needed a permission check. But couldn't hurt. But certainly the link should only be there for authenticated users, not people with the secret URL.
I'm not sure why I thought we shouldn't create a link if the admin created the ticket---i guess i was imagining cases where an admin creates a ticket for somebody else. That said, I don't know that I've ever done that in nest.
Tab should cleanup after itself.
Cool, I didn't know about this function.

Playing around, I don't see what side-effect it has. err.stack will be populated after line 81.

No good docs on `captureStackTrace`, maybe it's needed if you use prototype inheritance with Error.

It doesn't hurt anything to call captureStackTrace, so this is a really minor knit pick and trolling for good links on it.
@shane-tomlinson - test to make sure signup/signin/add email works with a primary user.
fixed in 1270c66ccda15f2995af77a823f02d80187f5f17
yes.  <process_name>_url are *internal* urls, how different processes can reach each other.

public_<purpose>_url are *public* urls.  things that will actually get served outside of our data center to users.
Oops, that was a debug statement I left in unintentionally. I can update the pull request tomorrow.
Looks like this hasn't been addressed yet?
You can't save Chuck Norris. It's Chuck Norris who saves you. :)
使用getInteger
Can you change this to something more descriptive, like ``max_kernels``?
a `0` is missing. It should be `sudo('mkdir -p {0}'.format(logging_path))`
written consecutively to a file.
You don't need to prefix with "\" for constants; PHP will look in the global namespace if there is no matching constant in the current namespace.
I like this a lot. :)
@b-durand We removed the FirePHP writer and added a new one only with RC1. The new one proxies directly to FirePHP, and really, as @jmikola says, does not require a formatter -- it simply takes the log event and passes it to FirePHP.
Make this:
```php
} elseif ($values instanceof \Zend\View\Model\ModelInterface) {
    $values = $values->getVariables();
} elseif (is_object($values)) {
   ... 
```
(importing ModelInterface, of course). The reason being that we can't count on a View Model implementation implementing the various bits that the next conditional looks at, but we can count on getVariables().
Yeah. I agree with your comment on the configuration board post, "I would say that this is a place we should provide reinforcement in code somehow. Most, but not all, components will need both a base path and/or datastores", and think that baking these conventions into the "simple" ways to do things is a good way to reinforce this. (see SimpleComponent->registerRoutes, same goes for SimpleComponent->startDataStores.)
Yes, in my tests, I got a UnicodeEncodeError while running this.
`checked{{/if}}>`
note, that since you're joining to Edition (/NewsArticle) as well, you'll need to define that model object as well, and the association between EditionMinisterialRole and NewsArticle. There's some hassle with single table inheritance inside of migrations. I worked around this previously by defining just the type I cared about like this:

```
class NewsArticle < ActiveRecord::Base
  self.table_name = "editions"
end
```

there might be a better way however...
Missing space between `if` and `(`.
Vyskusaj radsej -noconsolecontrols.
Clarify docstring

"
Expected input format (txt): 'host1/cpuid+host2/cpuid' 
num (optional): number of nodes to return
"
two empty lines before function def outside classes
use http download URLs, if possible
Creates ... 

Provide some info on the types of the arguments and their usage
As with ejb-security, you need to use a verb to start each item in a list that starts "to"
There's another indentation problem on these two lines.
this does not look safe at all
part a - line 34-46
s/test_navbarsand_headings/test_navbars_and_headings
I would indent this over one more character, personally.
If you find it cleaner, the algorithm could be rewritten as so:

* read ini file
* for each section..
** pull off all the known platform=foo type entries, -delete them from the dict-
** iterate through everything that's left w/ the simpler regex, assuming anything left is a version

That way if there's a version that's pure alpha later it can be handled as long as it doesn't collide with one of the metadata keys. I'm also unsure if the dict from the ini parser is safe to modify, so you may end up having to copy into a working dict first.
I understand, but this change is not related to enabling tinderbox builds so don't see how it's more appropriate to that pull.
user is not the username, but an identifier in the YAML file, so this message may be misleading
If the service has been started but `self.process_definition_id` has still not been initialized then bootstrap has not been run and the resource needs to be created before operations can continue successfully.
Shouldn't that be:

```python
exclude = ('archive_time',)
```

otherwise it's just a `str` instance.
This stuff doesn't seem like it belongs here. How about an internal wiki page?
Could you comment a bit on what's going on here? Looks like `author.textContent` can be cleaned up before calling `ZU.cleanAuthor` to make it return what you want. This would make the code easier to understand.
Honestly, I introduced the bug... the previous code was good.
Should this be normalStyle and highlightStyle to be consistent?
I added a 'startShutdown()' method to RepositoryCache that basically marks each WorkspaceCache as closed (via an existing field), but does nothing else.
Btw, read something about MVC. You're mixing logic, HTTP requests processing, HTTP responsing and other stuff that should be sepated.
You might as well interpolate `__dirname` here as well.
I agree in general about underscores, with the exception that dashes are typically used when gems are variants or extensions of one project. This is explained in [this post](http://blog.segment7.net/2009/05/20/a-project-naming-recommendation) and discussed [here](https://github.com/svenfuchs/gem-release/issues/11) and is followed for gems such as coffee-rails, jquery-rails, rspec-rails, etc.

So, I wouldn't go so far as "shocking", just mildly surprising with no reason to change :)
Basically, I want to tie all our classes to the current `Middleman::Base` instance to make reloading (and cross-thread crap) easier. A lot of our complicated extensions wrap their methods in a class, so I was being consistent. Ideas?
there are two opening `<sub>` on this line
That means it will happen.
You can just do `ConfigAPI.initializeConfig(callback);` here
User visibility has been tested in the "Members Search" tests, which is the only place users are returned to "unprivileged" users.
@bdarcus : Thanks for your comment. The goal of the design was that a contentId can be used as the target in case it is a general comment, or contentId#targetIdentifier can be used in case of an annotation. This is quite a common way of storing things in Cassandra. Once we need to store more metadata about the target, we can split that off into a separate Column Family, but I don't think that's necessary yet.

:+1: on renaming contentId to target though.
This should not be a multi-get. Its a paging query on a single row.
Perhaps the basic user profile shouldn't be extendable, and we offload that functionality into profile sections?

If we do need "extra" properties, I am not a big fan of extra_<name> columns as far as modelling goes, but it makes the most sense when you consider updating individual "extra" properties without having to read / persist the whole thing on update. In addition, I'd rather the user post it as a JSON object as well (e.g., &extra={"myProp":...}), rather than have to maintain black-lists.
Perhaps an else statement that fires the callback with an error message?
Looks like there is no TODO here.
Implement the classof method (w.r.t. PragmaHicudaInfo).
@AlexanderSviridov в задании сказано, что метод mutate должен изменить **строго х% последовательности**. Думаю, как проверить, сами знаете - в main.m выводим ДНК, вызываем метод mutate:56%, выводим изменённую ДНК, и тупо считаем, сколько процентов изменилось. Изменилось меньше 56%? Тогда метод работает не так, как предусмотрено ТЗ.
Как вариант, еще можно использовать диретиву препроцессора #DEFINE DNA_SIZE 100,  конечно уже непосредственно в m файле...
А почему ты переменную определил именно здесь?
Нужны ли эти пустые скобки?
hmmm, wierd...
okay I'll change that part.
Should this be a TODO or WARNING?
I can definitely change it back.

I actually only changed it away from using signals once I got a proper prototype with the signals done because it was so complicated.
Because of how the signals are transformed, there's no 1-to-1 relation between the original values and the transformed values, so the only way to know which version a transformed value has is to create a new subscriber for each original value, and give it that information. This way even if a transformed signals sends 0 or more than 2 values, the resulting values have the correct version counter to resolve update collisions.

I think using signal transformations can be very useful for certain use cases, especially since by filtering you can selectively validate binding values, but I wasn't sure if they were worth this added complexity and performance hit.

But, as I said at the start, I can change the interface back if you guys were looking forward to it.
Als ge het niet gebruikt, smijt het weg ;-)
restrict the stim correction to data channels with:

picks = mne.fiff.pick_types(raw.info, meg=True, eeg=True)
raw[picks, event_start[k] - raw.first_samp - s_start: event_start[k] - raw.first_samp + s_end] = ...
evoked_ts
On Thu, Dec 6, 2012 at 3:47 PM, Martin Luessi <notifications@github.com>wrote:

> In mne/epochs.py:
>
> > @@ -610,7 +663,7 @@ def crop(self, tmin=None, tmax=None, copy=False):
> >          tmask = (self.times >= tmin) & (self.times <= tmax)
> >          tidx = np.where(tmask)[0]
>
> But Epochs doesn't do anything to Raw, it just reads from it. So never
> copying it should be perfectly fine..
>

Ok, convinced.


>  The danger with introducing too many switches like this is that there is
> an increasing number of combinations that can result in a failure and
> testing every one of them becomes a combinatorial nightmare.
>

Yes, totally agree, before switching to Haskell let's keep up good
programming practice ;-)


Wo we will write an epochs.copy that does not copy the raw. Is this what we
converge on?

>  —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2335533>.
>
>
mention residual
But Epochs doesn't do anything to Raw, it just reads from it. So never copying it should be perfectly fine.. 

The danger with introducing too many switches like this is that there is an increasing number of combinations that can result in a failure and testing every one of them becomes a combinatorial nightmare.
This is an intermediate solution. We could make this pass the mappings and deprecate or add another high-level mapping_getter_function. Wdyt?
I think this will read better as a list comprehension, but see review patch for a possible different approach as well.
I'm sorry I don't understand what you mean here
you should add a note explaining that the return value of this method is ignored, to avoid confusing users
OK. I'll leave as Future[Unit].
I in fact should not be. Also, I'm missing a <div> tag because of that.  

I'll update the pull request.

Thanks
Code can be removed.
Hmm, how?  My reading of the with_connection method is that it does NO checkout of the connection itself -- all it does is check to see if there already is an active connection, and then yield.  If the yielded block does any AR activity _then_ a connection will be checked out, automatically by #collection. If the yielded block does NOT do any AR activity, it won't check out a connection.  

This works becuase #release_connection after the yield is 'idempotent', it no-ops just fine if there's no checked out connection. 

Am I missing something, are you sure?  Did you run the test before the change to make sure it failed before the change?

You know the code better than me so I'm probably wrong -- but what am I missing, where does the checkout happen in with_connection if it doesn't happen in the yielded block?
if (i, pw) not in d:
  w, r = divmod(pw, 2)
  if r == 0 and (i, w) in d:
    d[(i, pw)] = d[(i, w)]**2
  elif (i, pw - 1) in d:
    d[(i, pw)] = d[(i, pw - 1)]*d[(i, 1)]
  else: etc,,,
The same divmod refactoring can go here, too.
These state transition do not do anything, nor are they documented as what who is supposed to do with them.
Está dentro del `. bootstrap-scope` (el parche que hice para compatibilizar bootstrap con lo que teníamos)

```
.bootstrap-scope {
//
// Scaffolding
// --------------------------------------------------


// Body reset
// -------------------------

margin: 0;
font-family: @baseFontFamily;
font-size: @baseFontSize;
line-height: @baseLineHeight;
color: @textColor;
background-color: @bodyBackground;
```
here too :3
This is not translated
As your bug is fixed, we could probably revert this one and activate it on demand as in the first version ?
Will this return a 400 or 500? I think a 400 makes more sense.
NO, it starts transaction before each test
Then clean after each test
 (which means rollback as we are using transaction strategy)
NGHUTPR
Unnecessary import.
Probably good to keep that here for the short-term, but the next time we visit this we should probably either knock this off or to apply the i18n wrapper.
I added a test for Map/Reduce; have a look at BaseWordCountMapReduceTest#testInvokeMapperCancellation().
Yeah I basically hated every signature I came up with for this. That said I think "diff old tree with new tree" reads better than your suggestion.
But this property represents a low-level value. It makes sense to use a low-level type for it. Otherwise, we're just adding to the confusion.
Is there any reason not to use a `SenTestCase` subclass and real methods for this functionality?
this test says that duplicate crawls are eliminated, pls document it as such
Perhaps another temporary variable to store the output of `self.inaxes.transData.inverted()`?
If we're deprecating this in 1.2, should this PR be targeting the v1.2.x instead?
Well spotted @zacc. Do you have an update on this, @bebef1987?
I'd rather remove it, yes.
by Board? Should be a board or the board. Happens in a few other places too.
This class should be blissfully unaware of the existence of a template.  Those assignments should be done in either A) the controller or B) extend `PSU\Template` and have a method in _there_ that does those assignments.
right now, this will fail:

```clojure
(shorten-ts [1 2 3] (shorten-ts [1 2 3] [1 2 3 4 5]))
```

which isn't right.
Hey James, I'm not really sure which way would be more efficient but I think it's good practice to avoid selecting children as the layout might change at some point in time, which would break this line.
@gsilver Could you make sure there is a space after each `,`?

So
`'resizable=yes, toolbar=no, scrollbars=yes, width=800, height=600'`
instead of
`'resizable=yes,toolbar=no,scrollbars=yes, width=800,height=600'`
This method now includes Session, Authorizable and the offset and size parameters. These were the things that were being obtained from SlingHttpServletRequest (for the most part).
what is so difficult in using shogun's CTime class?

CTime time;
///do sth
time.cur_time_diff_sec(true); // for wall clock time diff
time.cur_runtime_diff_sec(true); // for cpu time diff
this -num ... +num check and +=num_elements could be in an extra function
> Are you still want to buy a car with all available options? 

Of course not :). I will not even try to design a class that predict every possible use of it or every need of extending it.

> Why not to ensure that you can install any option at any moment?

I see your point. I even agree with it. But there are options that I know they can be installed now with 0 cost, maintenance in the future is also 0 cost or close to 0. And installing it in the future will not be 0 cost because there will be many places where they are accessed or extended.
In my opinion making GitComandName as a public method is safe and it is 0 cost now and in the future.
Já bych moc rád uvedl v život jeden test na timer, který jsem si udělal na začátku. Ale brání mi v tom ten problém s tim kompilovánim. Resp. by mi pomohly ty asserty. Možná bude lepší, když to dnes necháš být a já to snad zítra rozchodim.
No worries, like I said I'll just put it in Pro blocks so its out of the CE code base
I realized that this test now depends on the fact that `monospace` will have a different width than the last resort fallback font for the string `"iii"`. Based on the data from your test page, are we pretty confident that that will be the case on all platforms?

I do like your choice of test string though, since `"iii"` is likely to be very narrow in non-monospace fonts and much wider in a monospace font. Clever.

Can we maybe add a note in the comment about the assumptions that make this test work and why the test string was chosen, just so that our assumptions are documented?
I don't think that works.

We have to set two fields, WT_EVICT_ENTRY.btree and WT_EVICT_ENTRY.page, and if we set page, and then sleep, the eviction thread might find an entry with page set and a NULL WT_EVICT_ENTRY.btree value.

Random idea (that I'm not going to pursue), we could change forced page eviction to look like flush operations, that is, each session could have a forced page eviction slot (or array?), that way we wouldn't have to do this locking.   That feels more complicated than we need, and I don't think forced page eviction should be a common event, and worth optimizing, but just throwing it out there.

The change I made was to give the eviction request queue it's own spinlock -- this code should only rarely be executed, I don't think there's any need for a complicated solution.

That said: in an application with lots of sessions, the eviction server is walking a (relative large?) array on every loop, just to detect that there are no page eviction requests.   Should we play the same game with forced eviction requests that we're playing with flush operations, that is, a scheduled count and a completed count, and eviction only looks at the array if the two counts differ?
@width is not valid HTML5
`up the layer tree until` ... until what?
Let's just change this to `if split_min and split_max` ? A bit more readable I think
`array_reverse` is just to ensure that even if the ext js helper is called too late, it's still on top of the loaded js/css files
shouldnt it be:
```ruby
if acquire_lock!(object)
  begin
    result = yield
  ensure
     unlock!(object)
  end
end
```
Not a big deal but this could be simplified a bit to something like

```python
if any(feed_url.find("origanizations/%s" % org) >= 0 for org in self.list_blacklist_organizations):
    return []
```
We use Sentence case for headers, so this should be: Narrowing in
Oops, don't insert code *before* the docstring. Put the docstring back to the top and add the code afterwards.
Yeah that's what I thought. Thanks!
"...default to setTimeFormat" -- I don't understand what that means.
I thought it looked better, but I guess it looks good without it too. I have removed it  and added .align_to_label_width just to few elements (buttons, errors), maybe this would be more informative what this class does.
There is difference between your:

```
$('pass1').removeClass('input_ok input_error').addClass('input_ok'));
```

and


```
$(pass1).removeClass('input_ok input_error').addClass('input_ok'));
```
I was never sure why we need both `button` and `span`?
Nice function, didn't know it. :)
This is how you do it through Django tutorials(unless they've updated it in the last 4 months) :). I knew you won't like them. Will try to do it with class based views.
Both are ugly. And not really. Because `{% if field.label == old_password %}` at least explains what/why are you doing it.
@timmywil has some perf tests somewhere that show `typeof ` comparisons performing better then coerced values
I think we can remove this test now
Delete those extra parenthesis
add go_ prefix
Gibts noch keine schicke Variante um Queryparameter mit Res.getURI anzuhängen?
I think we could just do a "pass" in the exception here, and allow the control flow to follow to the bottom of the method where the 500 response is returned, just to avoid two identical return statements.
Just a sanity check for myself: it's not currently possible to have metadata in a POST/PUT response on the platform right?
typo: "database"
Shouldn't we rename this to "execute_node_command" or something similar?
Yeah make sense, will fix.
"The same here", I assume you mean making these into two actual functions and just decide which one to pass to map. Changing to that. I think I sometimes try to avoid making that many named functions, but I understand it's more efficient than making the function every time.

Passing this to the map call makes sense, done that too.
Fine with me - for now.
I also worried about the effect on readability. We can look at it again when we actually get a ZINegativeBinomial.

readability is also lost with "D" which should be a boolean (?) with a name. ?
If you **have** to read the source to understand, then something is lacking in the naming and documentation. (Although, I often still prefer to read the source since it's often still more informative.)

(My well known preference for greek letter and one letter names :)
the super calls should have NegativeBinomial as first argument, it should be the self.__class__

my interpretation is that this doesn't call the CountModel methods, and the wrapper call is in CountModel fit
Need to  call validate() to make sure app is configured properly.
yozioProperties should be null here
So embarrassing. 

Pro tip: Don't code on NyQuil.
example.com and example.org are guaranteed per RFC not to route anywhere.  They are bogus domains.
-> pull-request #16
I'm confused here.  Your err_msg and comments indicate that you are testing for "unit" variance.  But the test looks like it's testing for var1 ~= 0.01.  Not var1 ~= 1.0.  What am I missing?
Some people might not install for whatever reason.  Might mention that in that case,
../bin/galsim_yaml demo1.yaml
will do the job?
Index seems redundant, however I'm inclined to leave it as we are just returning additional information, not taking anything away (from the original impl).
Can make this final
generally for deprecated we say when it is deprecated (v0.4.0) and what the alternative is.
obvious here -- by package name, but just for future reference...
We improved the class to add the footer view as a subview in the property setter a couple months ago. We found that the old footer view wasn't being removed when a new one was being set. I obviously missed this line when I did that conversion.
Good idea. I'm totally going to make you do a review of all this once you've got some time - I've tried to make it so that we can easily get hydrogen dumps of the runs via node's v8 opts, though I haven't tested that yet. The benchmark.js runner can do whatever it wants to the methods before they run, too, if we need to inject big comment blocks/etc.
Actually, I just noticed that this was already broken before too, but it should be fixed.
That just feels wrong. The option name itself is case insensitive, but the boolean value - which by nature of php is case insensitive - is case senstive?
self.handler?
This text should be in the test that is checking for it because it is expected data.
дефолтне значення можна задати тут
Why isn't this implemented here?  The ``models.py`` modules are supposed to be as bare as possible but the notification ones have method implementations and foreign keys assigned... that seems wrong.
Can you make this `### File managed with puppet ###` so it matches the other headers?
insertAlbums() and insertArtists() should be shared somehow w/ PlaylistModel as well
"print" is bit of a misnomer,  "stackTraceToString" would be more accurate
@stof you really need to open a blog yes
'video' was a bad name, 'viewfinder' sounds a bad name too. What about 'display'?
You're right, I overlooked it right here
This could have more test coverage. You should probably test to see if the Page
saved in the database. For example:
```
...
new Page(bob, "testPage1", "this is a test").save();
Page bobsPage = Page.find("byTitle", "testPage1");  // probably incorrect syntax...
...
```

Regardless, thanks for including a test case!
Please don't apply the indentation to every file in the project. Just your sources.
Why not make this a variable-time-timer?
no need for the () at the end here. Also, you might just name this `#random_quote`, prefixing w/ get or set or w/e is not particularly idiomatic.
Could this be updated to say there are 4 options instead of 3? I guess something like this:

`This is simply the list of compilers. The module comes with a JS, SCSS, and CouchApp compiler but allows you to add or replace any other compiler. All compilers have 4 options defined. The `pattern` to match for the compiler, the `class` that handles compiling the files, the custom `options` to pass into that compiler, and an optional item called `order` that allows you to specify the order in which the different compilers are run.`
Изменять данные некорректно. Надо использовать String.CASE_INSENSITIVE_ORDER
Uneasy about this status code.
Comment to a line
This needed to be renamed.  It was confusing to call both the browserid verifier and the email verifier a "verifier".
Will this fail due to the file being `files/default/haproxy-default.erb`? The source line does not have an extension.
nit pick alert: pep8 will complain about missing spaces after commas
I'm not sure if it's related, but I found [this blog post](http://theperfectmixture.wordpress.com/2012/03/28/clahe-in-opencv-removing-the-seg-fault/) documenting how to correct a segfault in the C code (upon which I believe this contribution is partially based)
I'd say 
```
:class:`DecisionTreeRegressor`
```
with 

```
.. currentmodule:: sklearn.tree
```

somewhere just before it... then it'll link straight to that module for if the user wants to know more about the routine
A 'neural_network', or 'neural' module sounds really good.

@ogrisel Yes, Contractive Autoencoders are to follow! :)

@amueller There's a nice paper this year that makes MLPs much simpler to use, they show how to automatically tune the learning rate (http://arxiv.org/pdf/1206.1106v1). That only leaves the n_components hyper-parameter!
no objections. let me check tomorrow.
Can't stick a variable inside the translation function... they'll need to be translated outside.
Fixed by renaming file to all lowercase
Won't this allocate too much memory? d_name is a char[256] so sizeof(dirent) should report the correct size. Running https://gist.github.com/3778961 gave me 1024 bytes on OS X 10.8 and 280 bytes on Ubuntu 12.04.
Why abstract? If the reason is you don't want people to create one, you should add a comment.

It can be a good idea to add a private constructor as well, that combined with `abstract` literally locks down the class.
Then its ready to be pulled
It is used to retrieve the value of the <thorlog>, <thorlog2>, ... from (legacy) wu xml file.
Why does it have to go through so many steps, rather than just translating path separators correctly when ouputPath is created above?
having this method in the interface is weird as there is no common interface for th return value. Same for all methods returning a QueryBuilder or a Query (in the case of the ORM)
Use `$.each(products, function(j, product) { ...`
In hindsight. Just land it as is actually. We can go to .min.js when we upgrade to jquery 1.8.
"compatability" is misspelled. It should be "compatibility".
This code is correct, but entirely non-obvious to me.
There may be a missing comma and some word between `functions` and `return`.
Like ... `callback` functions, we return ...
Okay I changed this, I agree it's more readable.
serviceName, or storage account name?
Results :

Tests run: 15, Failures: 0, Errors: 0, Skipped: 0
This file should be reverted cause there is no real change.
> The method there represents the addons count from several pages

That's the problem. A page object represents a single page.
columns << '*' if datastore['FIELDS'].nil?
new_ic
Let's make sure that the ccache command exists before enabling/using it. My machines don't have it, for example.
Romoved. Also removed my WIP FormExtension tests. That way we can make this PR as concise as possible, get it merged, then I can create a PR for my FormExtension work.
@bagnell can discuss these with you, but for (2), I'm not sure that this is actually a ray/sphere intersection.
Well, uncaught exceptions are "seen" by becoming an error in the console as per usual.  But Kevin is right that throwing an exception is worse than logging, since no one would be able to catch the exception we'd be throwing.
This is OK for now, but the best practice is going to be to keep the object literal as a private member and not allocate it on return.  No need to change this now since this is going to change significantly as we move forward with the DDR.
Creating new instances is a slow operation no matter what, so constructor functions can use defaultValue without performance concerns and object reuse will eliminate the need for creating new instances all of the time. If performance is a concern in an area of code, the right thing to do is use "bar = typeof foo === 'undefind' ? value : foo;"
Doesn't make much sense.  How about "Returns the index of the interval in the collection that contains the specified date."
Moving the viewport to the render state is a big win - the API is nicer and it is much less code.
Please use lowercase for all HTML elements. Consistency is always good, and in this case, strangely enough, this might cause problems with some of our doc build scripts.

Also, tags all need to be closed, XHTML style.

Our table formatting kind of sucks in the JSDuck output. I've created a bug to improve it by adding  some new CSS classes for tables defined in the API docs.

So, here's what you want to put in:

```
    <table class="doc-table" summary="This table gives the order of events fired when the app is in normal state.">
    <caption><b>Lifecycle events fired during different interruptions</b></caption>
    <tr><th colspan="2">Type of Interruption<th colspan="2">Going into Background<th colspan="2">Coming into  Foreground</tr>
    <tr><th colspan="2" align="left">Home Button (backgrounding)<td align="center">pause<td align="center">paused<td align="center"> resume<td align="center">resumed</tr>
    <tr><th colspan="2" align = "left">Fast Switching (switching between apps)<td align="center">pause</td><td align="center"></td><td align="center"> </td><td align="center">resumed</td></tr>
    <tr><th rowspan="2" align="left">Sleep/Wake Button</th><td> iOS 4.X</td><td align="center">pause</td><td  align="center"><td align="center"><td align="center"> resumed</tr >
    <tr><td>iOS 5.0 +</td><td align="center">pause</td><td align="center">paused</td><td align="center">resume<td align="center">resumed</td></tr></table>
```
Please correct all @Kroll.getProperty method names
Is it possible for this to be something other than TiBaseActivity or a descendant?
SSL Context is initialized with an array of trust managers and key Managers. So we should be maintaining corresponding arrays in our client.
VAR1 ?  мб startEvent? Хотя это временная переменная...
Старайся использовать `/**/` только для больших коментариев. То что у тебя влезет и в строчный комент `//`
You can also do _canvasCopy.context2d
I think the style guide says that filenames should be like_this.dart.
Instead of 
"The `-[HTDelegateProxy delegates]` property is intentionally mutable"
how about
"The HTDelegateProxy class is intentionally immutable"
I fixed this in Module by specifically creating a set out of the paths.
I agree. Regular and Async is pretty darn clear.
Please make "element" more specific.  "category_element" or "category_list_element."
First, why haven't you already discussed you no-ref proposal for current `object.destroy `?
Second, I don't understand it at all:
> All it takes is having what you're looking to destroy be returned from a function (e.g. the object that had ownership of it is handing it off to you). If you force ref, then that would have to be assigned to a variable instead of just fed directly to destroy/destruct.

Why not just give an example?
Please add some unit tests. `isWhite` is distinctly lacking them, and now there are two functions here instead of one, making testing that much more important.
Thank you, Arjen, for your time and your excellent work.
I'll discuss with @markfisher about 3.1 or 3.2 or some other workaround for Spring Integration
Might want to keep this call to commandOptions().  The next checkin has a bunch of shared commandOptions between our tools (e.g., --verbose, --show-warnings, etc).
looks a little bit destroyed
IMHO the EDBPostCommitHook shouldn't be able to let the EDBCommit fail, since the commit is already performed in that stage. Currently it is implemented like this:
Every ServiceUnavailableException is ignored since the hooks can come and go dynamically.

EDBStartCommitHook: if an exception is thrown, this exception is logged and ignored. I think that here it should also possible that the commit fails, so I will add the case that if an EDBException is thrown, the commit is aborted.

EDBPreCommit: If an EDBException is thrown, this exception is saved and later forwarded to the EDBErrorHook as cause for the exception. Every other exception is logged and ignored.

EDBErrorHook: If an EDBException is thrown, this exception overrides the cause for the fail and the new exception is returned to the user instead of the old cause. Every other exception is logged and ignored.

EDBPostCommitHook: Every exception is logged and ignored.

WDYT?
`if platform_family?("debian")`
> I think though someone more familiar with PMS internals should write it 

Like I said, I'm working on it.
My thinking was, that there should be more list items anyway (like "delete node", "unpublish node", "publish node" etc. pp.) 
So it would grow fairly large, if al page types would be listed underneath as well (like in your screenshot ... ).
You mean like sql sanitization? If there's an easy library or something for it I'd say yeah, otherwise I wouldn't worry about it
Yeah, it removes HTML entity numbers from the string such as:
```&#60;```
You should use iscallable. It is more pythonic
tab !
This should be reverted, especially now that it is not needed.
if `options[:description] == nil` the name is not set. Do we want that?
this comment is not really necessary because it's a dependency and it's installed with the gem.
Fixing this now unless you have an objection to window.location.replace, this also means we longer need the data-confirmed-remove attribute right?
Removed custom type mappers for DateTime as custom type mappers behave erratically. Instead manually mapping Datetime to a timestamp field which is persisted to database. DateTime is set to transient.
Je ne comprends pas, c'est justement le but recherché.
Il faut que tous les assertTrue soient validés pour que le test soit validé, et si un seul assertTrue échoue le test échoue.
C'est justement ce qu'on veut il me semble...
That will be part of a larger unused keys cleanup
I suspect that this "Pull" may have affected the behavior of ZoomBox, my copy of the February 27 still draws the box and changes the cursor.

Try on current http://www.openlayers.org/dev/examples/controls.html oops! lack the box and the cursor is inadequate.

(Before I put the comment in the wrong place)
isn't there something in std lib for this ?
That was why I though about a global variable, but your approach seems to be better.
range slider JS. Adds jquery slider, flot graph and helper functions to interact between the two.
Do you mean "will log a warning **and** fall back to pre-2.2"
Duh - of course, there is no consumer endpoint factory bean to apply the advice - this would need work in the chain handler itself.

Maybe we just document this restriction for now, and we could address it in 3.0 if this becomes an issue for anyone.
I agree and that was kind of the point
Ok, i'll wait for your update.
All of those ideas make sense to me. Maybe part of it can still go out as M2 though? If not, I agree... it should push to M3 to give it another day or two for those changes.
Ok, will update to prevailing style.
Awesome, didn't know :)
Thank you!
Just push to the same branch.
May I suggest changing this to example.com? Using localhost.localdomain is considered best-practice because it's commonly used by spammers.
Well, those are only supposed to show up if the test bombs anyway, and the test isn't bombing.
Really, I don't need those anymore anyway.
Does this need to come from incuna? It's not open-sourced
the select should be executed inside the transaction and should also add a "FOR UPDATE" this will not prevent all concurrency issues .. but should prevent issues in most cases ...
Hmm -- I thought this had a `TestCase` suffix.  Let me change that.
What are other exceptions that can be thrown?
Ya pas moyen de faire plus joli pour l'affichage du code (prettify ?) ou au moins une bordure pour encadrer?
We can make them copy properties and avoid copying here
Oh and please use `SessionInterface` introduced with #20.
I tend to think using timedelta directly is easier to read because its explicit. In cases like this factoring it out doesn't save much but I did notice it is a convention in other tests so I will preserve it here.
This comment refers to a workaround I had to do for IPy, please update or remove the comment as appropriate.
this is overkill. i don't see what we can learn from having someone implement session handling.
line to remove
i like using a pattern like this to abstract away loading the config file so that callers don't need to worry about the details and just access the config and it lazy loads the file when needed.

```ruby
def config
  @config ||= begin
     if config_file.exist?
       YAML.load_file(config_file)
     else
       {}
     end
end

def config_file
  ENV['SCGITX_CONFIG_PATH'] || Pathname([Dir.pwd, '/config/scgitx.yml']).join
end

def review_buddies
  config['review_buddies'] || []
end
```
Remove ENSURE_UI_THREAD MACRO
This is a Proxy representation of the Android Service type:
http://developer.android.com/reference/android/app/Service.html
I agree with ikd on this one
The problem with this is that we use Code Analysis. There are few warnings that can't be fixed, but generally we try to fix CA warnings.
(question)  What happens when no color specified? I assume that the runtime uses the default method for picking a color?
I've removed this, it seemed to be the culprit for the API regressions issue, webworks didn't like it.
Do we still have item unfolding?
There are conflicts between items overflow and item unfolding when setting overflow-y of contextmenuContent
Is the extension ".jpeg" allowed as well?
Where is this called from?
I see, also I should have read the deprecated note for the getChild method better.