labofsahil/github-event-dataset-2012 huggingface dataset:
@zonedabone We prevent the name space STARTING with org.spout...org.getspout...etc.

Unless you OWN that namespace, you cannot use it period. I don't see the issue here...

We do not block namespaces after the starting with that contain spout...
I didn't see anything on there that seemed bad. I think it would be ok for users to see edit their own information. Is there anything specific you want to see in those pages?
I wanted a make tools to rebuild the framework if required.
the utfgrid spec has been split out from mbtiles (because it does not depend on schema or tile storage), so please link to this: https://github.com/mapbox/utfgrid-spec
We do more or less the same thing for facets, ranking and relation, so at this point I was just being consistent ;)
Hmmm thanks... fixed and POG removed :)
Why adding a space here ?
Just some thought, if we want to put venue applicants are member in our member database, we don't need information of student here, just write down the memberID, the rest of information can be retrieved from member database.
On Fri, Mar 09, 2012 at 05:45:17AM -0800, Greg Weber wrote:
> Looks pretty straightforward, thanks! I am wondering if the argument
> position helped you curry. Cxt could be the last argument so that
> way the function can be called with a trailing empty list.

For my application it looks like it does not matter.  I might be
misunderstanding it: Did you mean that we export only the more general
version, i.e the primed version (with the Cxt being the last argument)
instead of exporting the both mkResourceInstance and
mkResourceInstance'. That way if one wants the old behaviour just call
the the function with a trailing []. Sounds good but it might break a
lot of code in yesod. I wanted to send a pull request that less
serious: a offer that you cannot reject :-).

Regards

ppk
@Ablu:
The client part is described in issue: http://bugs.manasource.org/view.php?id=422

Do I have a review for the server part?
i gonna check this and remove them
Fix for [issue #238](https://github.com/brianmario/mysql2/issues/238), "Solaris 11 MySQL binary uses /usr/mysql as main directory".
crash probably can be solved by
void dtNavMesh::calcTileLoc(const float* pos, int* tx, int* ty) const
{
+    if (!pos)
+        return;
+
 *tx = (int)floorf((pos[0]-m_orig[0]) / m_tileWidth);
 *ty = (int)floorf((pos[2]-m_orig[2]) / m_tileHeight);
}
I'm sorry but I did not make the connection from guest_kernel_kernel_path with this. Maybe that was because of the missing configuration file. Would you care to send a patch fixing those configuration entries?

Also, I think it makes sense to have a shared config file that will be included by two other different configuration files, but in that case, config.cfg is badly named. guest-kernel.cfg or something like that would be more appropriate.
Combine with previous line -- `rows << row.upcase`
This commit broke `grails create-app` with error `module not found: org.grails#grails-datastore-gorm;1.0.0.BUILD-SNAPSHOT`.  The GrailsCoreDependencies.java class has the datastoreVersion hardcoded.  I updated this and did a pull request https://github.com/grails/grails-core/pull/151/files.

Btw, not sure for simple things like this if pull request or just a comment are preferred, I don't mean to spam your pull request queue. :)  But figured since I needed to fix it to test some things I'd just submit a pull.
This, if still valid, seems to explain the problem:

  http://www.ruby-forum.com/topic/192573#839948
hashem jan baz ke dari too fork khodet kar mikoni
plz in fork ro delete kon va ye clone az 1devs/1schools-ws begir va roo oon kar kon
man yek bare dige forketo too proje merg mikonam.
Yes, I'm convinced it's a bug not how we were using it.

On Jan 18, 2012, at 5:26 PM, Luke Melia<reply@reply.github.com> wrote:

> Cool. Should be try to get this back into master?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/yappbox/sproutcore/commit/f85a79898e69ed3d17352c94e890a0b85e26e889#commitcomment-880433
For consistency, please use <email> (<real name>) format for author strings.
Maybe using the "blame" command, we can investigate if there ever was a time where that ini parameter was not in the default settings set?

I agree that checking for existence of default ini variables is just a waste of time (brain time of developers and maintainers) - we should only check for variables that are not in the default set. And of course for the validity of the data in those variables (eg invalid dir for logging audit data)
I am removing this folder from the repository. You can do another commit with the same folder, once your view and templates are complete.
With dummy can't reproduce. 

But this maybe happening because dummy has from the begining all contacts's statuses resolved. 
And there is no call to update_contact(), in order to change from offline to online. 

I have almost 300 contacts in the real msn session.
Better make it a warning. In this way we will never find out if it ever happens to someone. If you make it a warning it will show up even with verbose output enabled. Maybe add some more information if possible.
Just re-applying the last commit since I messed up the commit message (should have been pull request #2 not #1).
yup homesick blows up complaining about the existing bashrc.
changed default radius, not tolerance!
This was more a test than anything else. The exclamation mark is to add emphasis on the sentence so people don't change it :P
+1

You literally saved my day.
I don't really understand why we need to do it this way. You comment that we've crossed the line into being a framework, which I know you don't want. Having to have the one.application namespace seems to be at the root of that problem to me. But the only things in there are the config object and a function. Those could be passed around rather than having to specify that they live in a particular namespace. I could see where that might be a bit of a pain, but it seems like the tradeoff might be worth it.

Then again, I've only just looked at this for the first time this morning. Perhaps I'm missing something. Am I off base?
Can't tell what changed on this one either (because of outdated file imported from Google Code).

I give up.  How do I merge these two touch changes into the Master branch?
ah, then you want to throw if the state is STATE_NEW || **STATE_MODIFIED** :-)
lukas created a FactoryInterface for this, please use it (you might have used something we missed in that update as a template, if so can you also fix there?)
Can you change the style from "Combine()" to "Combine ()"?
Also, if only two paths need to be combined, you can just use Path.Combine (I saw one instance of this).

I'll merge it after that, thanks! :)
This commit doesn't apply to the latest sources. Thanks. :)
Makes sense. 

But would $key not need escaping? I cannot see where it comes from exactly with all the hooks involved. On a normal clean install it would come directly from the taxonomy_term_reference field table, but any sort of module can be inbetween: hence this can be considered an untrusted source. not?
Нет, ты немного не понял задания. Нужно переписать метод find_line, используя метод file_sandwich. У тебя вместо этого вариант метода count_line.
Replace this part with $copy{$map->{upload_id} } = $id;
Mono Compile
Will this create a (slow) memory leak by dynamically constructing symbols based on the call ID?
struct v4l2_mbus_framefmt mbus_fmt;
Will be switching from the load_tenplate to a locate_template and include over time.
Hi Aslak,

not a problem, it was good to do just for the experience and learning
how cucumber works under the covers.

Shall I continue with skip or wait until you finish your current set of changes?

Rakesh

On 24 February 2012 09:47, Aslak Hellesøy
<reply@reply.github.com>
wrote:
> I'm currently working on #160 and you can see the changes [here](https://github.com/cucumber/cucumber-jvm/compare/master...160-options)
>
> That work is in direct conflict with the changes you have made here, so they are not likely to get merged back in I'm afraid.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/FinalFive/cucumber-jvm/commit/b7e76c1115ed03160e7e25a2f6a9564d0094d56c#commitcomment-1006694
is keeping a variable PlayingTest necessary ? 
couldn't the isPlayingTest() function return whatever state the dispatcher is in ?
Please review this code. WEB-3350
No, you didn't. I thought if you left anything that wasn't doing anything functionally it returned...?
It's so hard to write English correctly...
Hey, nice job!  :-)

I would love to pull your changes later when you're done but somehow line breaks got all messed up so it's difficult to see the actual changes.  Would you mind to fix them up?  That would be awesome.
It looks like this is the best fix for #65 on github (compare https://github.com/loopj/jquery-tokeninput/pull/177), but it doesn't look like there was ever a pull request initiated to get this into the main repo. Is that something under consideration? It'd be nice if a fix for this were in the official repo.

I looked at the list of special chars in this commit, and it looks good. A few comments, though it's mostly nit-picking:

It seems like regexp escaping should be build into javascript. But it's not, as far as I know.

Comparing to http://stackoverflow.com/questions/2593637/how-to-escape-regular-expression-in-javascript, I wonder if it's necessary to escape "#" and "\s" actually need to be escaped. But it seems just as likely that the regexp given there is incorrect.

Looking at the ECMAScript spec (http://www.ecma-international.org/publications/files/ECMA-ST/ECMA-262%20edition%205.1,%20June%202011.pdf, section 5.10) makes me wonder if "!" and "=" also should be escaped,to deal with certain edge cases. I haven't dug into this, though.
and guess what

we dont care.
Won't this prevent collapsing of whitespace in labels (which unlike in textareas and pre elements is insignificant)?
isWidgetInitialized might be a more descriptive name.
Looks like your editor is 'fixing' the mix of tabs/spaces from upstream. Other than this issue, you should submit a pull request.
非同期でよければ今度チャレンジしてみますよー
I think the special-casing of the well known secret has made this code a little more complicated than it needs to be.  A user can always get well known secret by using mode==sha1 and then secret=string of zeros.
Confirmed this. writes after the startBackup() call goes to a new jdb file.
Excellent! cannot wait to try.
`MESSAGE_ID` should be a bit more “complicated”. See [`Intent.putExtra()`](http://developer.android.com/reference/android/content/Intent.html#putExtra(java.lang.String, android.os.Bundle)) reference.
Thanks for submitting but I've already implemented a fix for this as part of the validation work being done on a separate branch. It will get pulled into master at some point this week.
Toxins burn chamber stuff.
`respond_with` will handle all of this as well. Just save the location and call `respond_with`

The `responders` gem will also take care of the flash messages for you https://github.com/plataformatec/responders

Otherwise you might need to pass the flash message into `respond_with` (just check the docs for all the options)
don't you want to fix you text editor?
pff.. I was affraid you will quit forever
A typo here. liblsvm should be libsvm
I had it once running with JRuby, but I don't know what the current status is.
yea, let the GC do his thing. This isnt C++. The only thing which need to be looked for are static classes/variables which exist after being used and therefore reserving useless memory
Ah, shit, you're right, this causes problems in that scenario. I'll look into it immediately!
Would prefer just `.resource = <class>` and `.get_resource()` - consistent with rest of codebase.
We need to do the same for parsers, renderers etc.
I don't quite understand the question.

If you're actually asking "what is all this `ContentProviderClient` stuff?" — it avoids Android having to do a lookup by URI for every call, and I will eventually switch the rest of the codebase to do this, too.
Thanks Spacy, this is the most useful pull request we had on nwmethodwrapper yet!
> Maybe some tests would be good considering all the crypto magic being done here :)
> f+ otherwise

This patch is just code reformatting and tidying; no logic changes. If we required test coverage whenever we reformatted code, we'd have a lot of ugly code :)
Since rec is only used once (and apart from its definition) why introduce it?  Do you want the side effect of throwing if we're not given a HistoryRecord right away?
Gunna have to remember to use the diewithError
datum ophalen als UNIX_TIMESTAMP(), nie als DATE()
um, and also, thx! :)
Do we really want to require require from the native side?
Isn't Cordova going to be the object that define require anyway?
Cordova.require(Cordova) ???
root rw = 6
group rw = 6
users r = 4

so it should be 0664 and not 0666
This one also adds display of the user who invited the logged in user, if there is one.
Fixed in https://github.com/ProjectSkyfire/SkyFireEMU_rebase/commit/3bddeb9e8054d3b81fd7e6a86649bf0dedd6be87
applyParticipationStateModifications is a good name, we should use it for event.changeParticipationState
sorry for not peing enough pedantic but that was UI related, should have written that there. otherwise you are correct.
IIRC I thought that that was the one place where it was being saved as unix time, whereas in other places it was being read and written assuming tii timestamp format.
This is the focus listener the focus listener
This line, along with the config setting will allow sub-plugins, such as LDAP, CAS, Mock or Shibboleth to use their own User classes that are not persisted in the database.

This used to work fine.
Tpruvot, sorry first as i don't know where can i ask you the building problem, so write at here
about building your DEFY cm9 base on 2.3 , i repo sync it and found total is 243 projects. 
Are that for defy cm9 ? 
i use 
 repo init -u git://github.com/CyanogenDefy/android.git -b ics
repo sync
i repo n+1 times and got fail around 117 projects.
if i only want to build your defy cm9 what is the min work load of repo sync 
many thanks for your great job
@brianhartsock Noted, and I wouldn't ordinarily use it, but it seemed like a reasonable way to test it without relying on other methods belonging to the object under test. I can make that work a different way though, especially if I create a separate var for storing the metadata as you suggested above.
Maybe some container widgets doesn't need it, such as Page, Collapsible, Div, Header, Footer. To add the events to them will caused to the click callback will trigger to deeper level.

I'm just thinking about the question, you are meaning it's need ?
w itself doesn't, but v refers to attributes allocated in w. Is that a problem?
Items need to be of type %s ?
Isn't it the second element?
Yes, much cleaner.
good, shouldn't be published
we should move the .foreach(_.shutdown()) to after the writeLock has been released.
there is a comment three lines further up which explains this in great detail
what would that mean for the children of the failed actor, or when the failure had been escalated?
My preference would be yes but since the rest of these uses this pattern, let's not change it
```
qa / qa.max()
```
maybe add a comment `/* This is bad code */` in the code example is easier to spot
maybe an example

{delete: 7} bad {'delete':7} good

x.default bad x['default'] good
Mistake.  I added it back.  Not sure why it doesn't show yet.  I left a comment here too.
C/P monster?
should be above the condition
I think your are right. I will rework it.
I always thought that was personal preference, and mrjob hadn't expressed an opinion on it. Moved it to `mrjob.fs.base` because hey why not.
2 things:
- It seems Map could be just supported the same way as primitive types.
- Bag will be generatable (or maybe you should just do it in this patch). That way all tuples are generatable and you don't even need to check for generatability.
Не расстраивайся, я тоже.


2012/12/8 Alexandr Ruchkin <notifications@github.com>

> In srv/src/Snaplet/DbLayer/Triggers/Actions.hs:
>
> > @@ -129,9 +129,8 @@ actions
> >                    let setIfEmpty (name,val)
> >                          | name == "plateNum" = return ()
>
> А, ну да, я идиот.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/f-me/carma/pull/279/files#r2356409>.
>
>
Are there + offset timezones?
    include('2012-01-01T00:00:00')
these magic numbers make this test non-portable. will need to be fixed eventually.
probably best left as it is. use go get -u github.com/bigs/goober to update your library (be sure to have GOPATH set)
To @gonuke 's point, this change to camelCase is contrary to our adherence to the Google C++ style guide http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Variable_Names . I'm going to close this pull request. Please resubmit with this corrected to comply with the style guide.
last thing I need -- a doc comment for the new disabled property
dispatch_once(), right? Got that.
If subclasses are going to modify the drawing (very much presumably by *not* using an `NSSliderCell` to do it), then setting these properties is a waste. My point here is not to re-create an `NSSlider` wrapper over `NSSliderCell`, but to simply use it for graphics rendering, hence `sharedGraphicsRenderer` being a class method. There's only one of these for all `TUIKit` framework existence because I don't want another `NSControl`/`NSCell` mess. If I did, I'd be using AppKit.
Thanks for the comment. I change the doc description into the same as that in readline. I think that there's no actual workaround on this for simulating this with key events through stdin depends on the key assignments by user, so I did not add the additional notes on it.
what are these `<script>` tags for?
fixed. Thanks for your all comments.
What guarantees that `4 + 2 + 32 < frame_len_`?
лучше таймер, счетчик — это как-то ненадежно
We don't need to change this test because the distinct count should work.
We could only handle names and then constantize when they are used (a bit closer to the association/:class_name behavior), but not sure if that's really necessary, I'll play with it a bit in a dev env and see if it works nice with a normal workflow
Will change and squash the commits tomorrow.

Thanks

Sent from my iPhone

On 14 במאי 2012, at 01:27, Rafael Mendonça França<reply@reply.github.com> wrote:

>> @@ -259,16 +260,17 @@ def word_wrap(text, *args)
>>       #   simple_format("<span>I'm allowed!</span> It's true.", {}, :sanitize => false)
>>       #   # => "<p><span>I'm allowed!</span> It's true.</p>"
>>       def simple_format(text, html_options={}, options={})
>> -        text = '' if text.nil?
>> -        text = text.dup
>> -        start_tag = tag('p', html_options, true)
>> -        text = sanitize(text) unless options[:sanitize] == false
>> -        text = text.to_str
>> -        text.gsub!(/\r\n?/, "\n")                    # \r\n and \r -> \n
>> -        text.gsub!(/\n\n+/, "</p>\n\n#{start_tag}")  # 2+ newline  -> paragraph
>> -        text.gsub!(/([^\n]\n)(?=[^\n])/, '\1<br />') # 1 newline   -> br
>> -        text.insert 0, start_tag
>> -        text.html_safe.safe_concat("</p>")
>> +        wrapper_tag = options.delete(:wrapper_tag) || "p"
> 
> Also I think that we don't need to delete the key. Only `options.fetch(:wrapper_tag, :p)` should be fine.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rails/rails/pull/6273/files#r813866
Do we need to put to `$stderr` here? Not sure... If we return the string it'll use `puts` as normal right?
Totally. This is the original code, we just moved it around, so I've missed some easy stuff like this.
Seems fine. I don't think we should normalize the keys.
Yikes.  Is this required?
I prefer `tpe.parents.head` since it makes clear no parents are lost. It's equivalent because we know tpe.parents.nonEmpty
`error_logger:info_msg` knows how to do formatting, so you can just do:

    error_logger:info_msg("Worker checkout failed~n")

That said, I'm inclined to leave such logging to the calling application and just return the error tuple.
Unfortunately, the consequence of using dummies:
```
In [7]: hash(Dummy("A")) == hash(Dummy("A"))
Out[7]: False
```

I'm still reluctant to pull in `Symbol` for just storing a name, though.
Because I must be sure that __call__ is *not* defined in Expr. Otherwise I will get infinite recursion (I think).
Perhaps you could also specify in what way more flexible.  At the moment, `sdm_to_vector()` seems to be exactly the inverse of `sdm_from_vector()`, which makes me thing that `sdm_to_vector()` is quite alright, which is apparently not true.
Oups, right, it should be double-backticks.
moved to immutable
maybe the try..except block is unnecessary, as this is part of sympy, not something that must be installed separately. Could you remove it? Or maybe I am missing something.
Would you be willing to add such an example to the docstring?
or (the following should work?)

```
ap, bq, argument = [i._eval_expand_func(deep=deep, **hints) for i in self.args]
```

I would expect that Tuple would apply the hint to all args when deep is True.
It's now a method and all uses of it have been modified accordingly.
First of all, we should write it just the same in the guide as it is in the original source code, because it's a quoted fragment from the core code of  'framework/gii/generators/model/templates/default/model.php'.
native.os exists because os.name on Windows contains the version ("Windows XP", "Windows 7" etc.). I'll fix that Mac bug.
```
boolean isTTLValid = !KillSwitch.shouldUpdate();

return !StringUtils.isNullOrEmpty(accessToken) && isTTLValid;

```
there is a hard coded validation in
/org.apache.karaf.features.core/src/main/java/org/apache/karaf/features/internal/model/JaxbUtil.java
Sure. I know that in such short context, this doesn't seem to be very useful, still I try to apply this rule as a general rule in the code, with one exception: one-line blocks with curly braces, e.g. ```array.each{|i| p i}```.
dieses flush ist unnötig
What if somebody wants to tweak the existing mailer? I think that's reasonable.
You have to remove space between < and >. I'm sorry, I did that (in my previous comment) because of github.
Look at the other doc entry. (line 22, 24)
looks better not lined with baseline
If you swap this around - i.e. S_ISFIFO, S_ISREG then if (!S_ISSOCK) return; - you save a level of indenting.
pass the error code?
comparing:
DateTimeFormatter dateParser =
    new DateTimeFormatterBuilder().append(null, new DateTimeParser[] { ISODateTimeFormat.date().getParser() }).
      toFormatter().withZone(DateTimeZone.UTC);
with
DateTimeFormatter dateFormatter = ISODateTimeFormat.date().withZoneUTC();
I can't see any behavioural differences, so I'm not sure what the advantage of using the much more wordy first option - any idea?
Ack, good catch thanks
So all this + action mailer for `token_authenticatable`?
This should be in a protected method, e.g. `normalise_query($query)`.
Width and float should go into the stylesheet.
This should be done via autoloading.
Consider factoring this out into a common function.
Remove the last `a`
This file like other purely template files, should not be moved into style directory. So we have the actual template engine in includes/template/
Just use the `.value()` function
Yeah, that is correct. "its" confuses the hell out of me… >_<

>> +	'DISABLE_SUCESS'		=> 'The extension was disabled sucessfully',
>> +	'PURGE_SUCESS'			=> 'The extension was purged sucessfully',
>> +	'DELETE_SUCESS'			=> 'The extension was deleted sucessfully',
>> +
>> +	'ENABLE_FAIL'			=> 'The extension could not be enabled',
>> +	'DISABLE_FAIL'			=> 'The extension could not be disabled',
>> +	'PURGE_FAIL'			=> 'The extension could not be purged',
>> +	'DELETE_FAIL'			=> 'The extension could not be deleted',
>> +
>> +	'EXTENSION_NAME'			=> 'Extension Name',
>> +	'EXTENSION_ACTIONS'			=> 'Actions',
>> +	'EXTENSION_OPTIONS'			=> 'Options',
>> +
>> +	'ENABLE_CONFIRM'			=> 'Are you sure you wish to enable this extension?',
>> +	'DISABLE_CONFIRM'			=> 'Are your sure you wish to disable this extension?',
>> +	'PURGE_CONFIRM'				=> 'Are you sure you wish to purge this extensions data? This cannot be undone.',
> 
> Not not `it's` as it is not `it is`, it is the possession of `it` which is an exception to the rule of possession and apostrophes making it `its`.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/phpbb/phpbb3/pull/608/files#r748619
Include driver name in the message please.
According to http://sqlite.org/datatype3.html sqlite3 does not have mediumtext, although I see this in sqlite2 file also. Does it actually work?
`{` on a new line.
Should probably SELECT the user_id from the bot table instead to make sure we only update bots.
looks like a scope leak
nope, check out line 287
maybe this should be 0xff instead of -1 ?
It might be better to create a separate cmdArgs array, and push things to it as needed.  Something like:
```javascript
var cmdArgs = ['start'];
if (port) {
    cmdArgs.push(port);
}
if (params) {
    cmdArgs.push('--context');
    cmdArgs.push(params);
}
...
p = runCommand(basePath + '/' + path, cwd + "/../bin/mojito", cmdArgs, function () {});
```
I would easier reading code if you'd inlined `toHash` / `fromHash` or maybe just added some comments explaining intents.
Not good practice to set variables in localStorage that don't need to be stored long term.
foreach (for .. in)
Docs for these `Exception` classes?

Which type of exception corresponds to which http response code.
I think... that they're orphaned. The benchmark framework has been removed from the java src... so... I guess we should remove those too? There are a ton of orphaned files in the tools dir in general.
I saw some code with a similar need that creates a copy of SpellEntry, sets it as SpellProto for the current Aura/Spell and modifies it.
I missed that one, thanks. Fixed with new commit.
Close open file-like-objects that were assigned as content, and remove them from the list so they don't get closed more than once.
The `content` property is explicitly defined and raises an `AttributeError` to better help anyone who tries to pass a streaming response through middleware that blindly tries to access its content.
I think it's a bad interaction of the way the test models are set to managed during tests and then unmanaged directly afterwards. I'll look into it later and get this patched out again.
Asserting that two XML docs are equal by checking that their string representations are equal is not a good idea because make the tests to fragile and dependent on the library. Actually, the serialized form of two XML documents that represent the same tree structure of information can be quite different.

A possible alternative is to use lxml to parse the xml docs (both the EXPECTED_XML and the exported_file), convert them to string using the same printer (e.g. etree.tostring with pretty_printer set to True) and then check for string equality.
The user can set the upper bound of the maximum number that can be enqueued by tweaking the variable CURVE_BLOCK_SIZE. It can also choose to not use celery at all by using as task handler the SimpleTaskHandler class.
hard link for linux.
Are we sure here that context can not a instance from another jQuery?
How about `context = context.nodeType ? context : context[0] || context;`?
Oh, that's a good point, it might not be our instance! Your property check is looking a lot prettier now.
Well, we only started enforcing style in the tests about a year or so ago, so there is a lot of cleanup of old stuff ;)
Did we void the rule about single quoted arguments having no surrounding spaces?
OK, that's a good point, but performance trumps compression and I think ID should always get first priority.
Negative value check, too?  What about NaN?
Right. Thanks.  Add Immutable/stable to all the functions in this file. Please help check if they are right. THanks.
``[Ff]ile[name]*`` looks wrong to be, ``Filennnnnnnnaaaaaaaaammmmmmmmmmeeee`` would match for instance...
I don't believe this method is necessary.
It uses the system libpng. It needs this line to get the correct path.
I still think that 99% of the time the stack trace is pointless information, as any errors will almost alway be in Formula#install. I am not commenting on stack traces in general, but in this particular instance.

And it still needs to be cleaned up a bit, the duplicate `Error: ` lines are confusing at best.
Appears to build fine on my Snow Leopard machine---do we get runtime errors if OpenCL 1.1 is missing? Would be nice to have a link to a mailing list post/issue number that explains SL depreciation---can't find anything about it in the GEGL NEWS file and Google searches pull up these pull requests as the top hits.
This kind of double check is questionable - what value are we giving to the user by telling them about an unknown error that they shouldn't have reached?  We're not preventing any kind of actual user data loss, we're just doing a duplicate check.   Removing this improves readability and reduces things you have to test.
You'd need to make sure that `{DAV:}write` is not returned for the principal that's not allowed to change the vcard :). Don't know your API well enough to tell you what to change.

In an ideal world.. nothing in the webdav server should ever be generated on the currently logged in user. This allows you to keep things extremely flexible. The tree and backend classes are built to be completely 'session' independent, only the plugins are aware of the user context and make decisions based on that.

This rule does not absolutely always work out.. There's exceptions and hacks in our system too.
Yeah, that was exactly our consensus as well. Also, it's easier to solve a perceived problem than to retract a bad solution after the fact...
I just checked the Makefile, and unless mistaken, I see no dependency on GNU make.  This Makefile would run on any make.  The $(...) construct and the := construct are not uniformly supported however, that's likely why I avoided them.  Do you have any reason, related to packager support, to change this?
i'm not sure what to use for the prefix: the keyword or the exposed name. 

Options:
1>[dispatcher_name]:keyword:[keyword]    for example 'content_keyword_dispatcher:keyword:keyword1'
2>[dispatcher_name]:exposed_name:[exposed_name]   for example 'content_keyword_dispatcher:exposed_name:worker1'

I would rather go for the keyword (1) because it's make more sense with the dispatcher name. Any preference?
> Предлагаю придерживаться общепринятого в git именования: родитель — более ранний коммит, потомок — построенный на базе родителя более поздний коммит.

Спасибо. Вы правы. Я что-то не осознавал того, что действительно везде именно так идёт обозначение.

> Закоммитил последнюю версию

Ок.
please document why it's needed to send a SIGUSR1 user signal to the process for debug mode
this should be: ``_formatChrome``
As I've pointed out before, our coding guidelines are not the absolute truth, we are not the **GODS** of the JavaScript language and the guidelines we've established covered the use cases we've had at that time. That does not make them complete nor does it make them correct.
We don't need to install anymore, because `make test` will build in-place and execute all tests.
Was that your question?
Isn't this an almost exact duplicate of EmojiGrid?
Agreed! My bad.
It's a little confusing to have a field allocated just to hold a subfield of another field.  Can we inline these two fields?
This change will also have to be applied to the `PolymorphicHasManyAssociation`, right?
This file has some serious and obvious problems. It looks like the only line that changed was 13 and all of this file gets returned in the strava object from /services.
I usually make an object simply for locking to make it's purpose clear, like
```
private object _lockObject ;
```

You certainly can use the `_entities` object since it's private though.

I think it's just a preference thing so we can definitely leave it as is, I just wanted to bring it up.
No. :-D
Is `.component.image-child-nodes a` different than `.component.image-child-nodes li a`?
You should not use `innerHTML` for text. Property `innerHTML` is much too powerful, and slow, and dangerous. You should rather use `textContent`.
String was just moved here: https://github.com/adobe/brackets/pull/1572/files#L5R70
I agree that we can merge it into the above block.Just for the context, it is possible for a case where !hasEndQuote && !quoteChar. Type something like rel=a and hit Ctrl+Space to bring up the attribute hint.
Oops, these are tabs. Should be spaces.
This line doesn't seem to have any effect: even after hitting Enter, the full line is selected (from the setSelection() call in _handleKeyIn() below).
This should also have an "!" since it's required.  Also, I think this one and the below one don't need the parens (the close-paren on the line below is also in the wrong place, so fix that bit if you keep them).
@redmunds Good catches. (I was trying to do focusedEditor == null but JSLint wasn't letting me...I forgot I could just use ! instead :)) Will fix.
don't need two copies of this link. I would remove the one in the title
remove to be?
Indentation off here.
Excuse my question, but what does it means regarding libgit2 (and then rugged) ?

As far as I remember the commit that I proposed, regarding inconsistencies on branche names, was playing with reference and branch names and was manipulating only "standard" C string (i.e. NULL-terminated array of chars).
One `=` too much. Not of Django application, but of PiplMesh *Translation of PiplMesh*
Ah I remember why now, the require is in the body of a method, and you can't do class definitions in the middle of method bodies.

    /Users/tom/.rbenv/versions/1.9.3-p194/lib/ruby/site_ruby/1.9.1/rubygems/custom_require.rb:36:in `require': /Users/tom/Development/jekyll/lib/jekyll/converters/markdown.rb:17: class definition in method body (SyntaxError)
wtf where are the tests what is wrong with this site :beer:
Whata dick bag
don't need to declare these variables, just do pass in the values when you call `createImageDiv`
Although it doesn't matter in this case, since we don't call anything after save, we should put the function re-assignments before we callback. This is really only important for save(), because in the callback we call publish()
I commented on this bit of API a bit below (https://github.com/mozilla/butter/pull/1027/files#L3R25). This isn't bad to have here, but it just might not be necessary unless you want to test this functionality specifically.
This comment isn't relevant anymore
Why the Empty anchor tag? I mean, I suppose this is a "When this stuff is there" kind of thing but, it's not doing anything right now.

Then again, doesn't seem to be causing any harm.
If you're not going to populate these meta elements, drop them.
See my nits about the earlier `form` in this file; they're the same here.
For the majority of purposes, simply removing the last character from a model name will singularize it. Nevertheless, I just realized an inconsistency with my routes. Reading a project requires a request to /projects/1 whereas reading a screen in project 1 requires a request to /project/1/screens/1. I'll just stick with the plural names to be consistent and avoid singularization at all; that is, I'll change reading a screen in project 1 to be /projects/1/screens/1.
oops, " instead of ' on action
please put the english translation of the id in a comment next to this. I've been adding that to all new code I'm writing that uses localisation
This step is really 2 steps, because you have an operation and a verification:
```
When I start the Database 
Then the initial state is creating
```
we discussed this kind of thing on the phone today when going through some other scenarios, so hopefully you can make the appropriate changes to improve these scenarios in similar ways.
There's an inherent race condition here, like virtually all [LBYL](http://docs.python.org/glossary.html#term-lbyl) approaches.
We should add a ``env`` arg that is just an alias for ``bin_env`` and existing code should work correctly.
are you sure? that's suuuuper ugly
Again, this is a hack to workaround issues I kept running into when attempting to generate the view HTML from within the after_filter.
OK faghat khastam NickName khodamo avaz konam :D
This URL seems to be a write access URL, can you change it to use the read-only version? Otherwise people can’t use it :)
Locally removed and commited. I added complete directory for you to use. I don't think it should go into powerdns :)
Arguments 2 and 3, do not make sense, because you are doing all streams always. You can remove them.
`p = ccall(:mkstemp, Int32, (Ptr{Uint8},), b)`
Would it be better here to rely on ActiveRecord throwing an exception when it couldn't find the record? e.g.

`def default_org  
   org_id = self.preferences[:user][:default_org]
   org = Organization.find(org_id)
   return org
rescue RecordNotFound => e
  return nil
end
that is, this.apply would simply erase the "this" and all arguments would pass through.
I'm nitpicking here, so this is optional. The pythonic way to concatenate two strings would be `' '.join([str(second_diff/60), 'minutes ago']`
Ah thanks! :)
This can trigger different actions depending on its context, on the HOME_SCREEN it opens the tab page, on the TABS_SCREEN it creates a new tab, Thats by design in the UX spec but I expect it to change when it gets reviewed, I brought it up with @lco before and while using it it is majorly confusing
Oh, I see.  I think this is very dangerous: this means that if I write a function that assumes degrees are the default (say it's inside a module that has ``set_default_format('deg')`` at the top), and then run a function that sets the default to radians, all of a sudden my old function broke, but it might take me weeks to understand why.  In general, I think changable default *inputs* should be avoided. ("Explicit is better than implicit.")

Custom default outputs, otoh, makes more sense to me because that's usually just for the sake of human-reading. 

(more generally, see my discussion of input formats on astropy-dev)
I think I wrote that, and I think you're right that your way would work - I can test this.
This is what @laanwj had written to this change in the other pull:
"I think it's more consistent to use C++ string handling everywhere instead of strlen() and friends (performance is not an argument here). In most implementations, c_str doesn't perform a copy, but it simply returns a pointer to the internal buffer. Though it'd be better to use .data() if you don't rely on it being zero-terminated like in this case."
Could be better because that better represents the current configuration, but leave that for a later pull.
still not the right spacing here
Extra space after `(` and before `)`
The rest are almost all `integer`, should this one be `integer` as well?
对于这个keytab文件的存放位置和文件名字，最好我们统一一下。
Path:  /home/hadoop/
Name:  keytab.hadoop
@Ocramius couldn't you pass the class name instead of the ClassMetadata (as all you do is ``$class->getName()``) to be independant from Persistence ?
I am not a big fan of this. If we define services like this, they will be scattered over our code base. I would prefer to see global services (db, mail, log,...) to be defined in a central place at the highest level. The code base should use the service without having to call a getDB method. The getDB method could return the database service to support backwards compatibility.

At that central location we would be able to easily add/modify services and these changes would be accessible on the whole code base.

The greatest challenge at the moment is making the Kernel (ie. DIcontainer and HTTPKernel) accessible to our code base.
There are other calls to return for which this applies.
3 * sizeof(float) ?
It might be simplest to drop forcing the `.py` extension - there are valid situations where it's not needed (`.pyw` files, and scripts like `/usr/bin/ipython`). See what the others say about that - I'm not sure what the rationale was for the restriction.

If not, `find_user_code` could be extended. I think it's currently called in two or three places.
This patch showed up in the ML:

~~~~~~~~
--- src/libgit2/src/netops.c
+++ src/libgit2/src/netops.c
@@ -116,11 +116,12 @@

       /* Oops, we couldn't connect to any address */
       error = git__throw(GIT_EOSERR, "Failed to connect: %s", strerror(errno));

 cleanup:
-       freeaddrinfo(info);
+       if(info)
+         freeaddrinfo(info);
       return error;
 }

 int gitno_send(GIT_SOCKET s, const char *msg, size_t len, int flags)
 {
~~~~~~~~

Can you apply it in this PR, so we don't collide much? Cheers
>>> int('0x10')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: invalid literal for int() with base 10: '0x10'
Not something that blocks this but like I mentioned before, it would be nice to look at replacing these `grid_*` with whatever you had suggested (macros?). Maybe something to look at once the major parts have landed.
Oh, right... so the reason I had to add that bit to wiki content is because the "content" fields for other models have the term_vector bit and in order to merge them all down, they all have to have it.

We don't use highlighting for wiki content. Though I'm pretty sure someone's mentioned that maybe we should be.
I vote for 2 because some legacy tags are products and others are topics now. /me adds to TODO
+1, the testing `get_absolute_url` is kind of pointless in most cases.
The prefix is already the build name. Before test_utils was just over writes the ES_INDEXES after es_utils does it's magic.
I added a try block for this.  Tastypie is transactional, so it'll roll back the list if there's a problem.  I tell the user what field is missing in the response.
I think it probably is not since we haven't started doing rapid betas for anything (AFAIK), as long as it doesn't break anything.
@Vader19695: This is pre-Rails 3.0 syntax, which means it's very old.
Would be better to have the `->addCrumb` aligned with others
You can add an `AUTHORS.rst` file or just leave that out.
That's why phpunit.xml should be in the repository root. ;-)
This refers to text added by patches on [#13385](http://trac.sagemath.org/sage_trac/ticket/13385#comment:17).
Can't we just cache this in initGraphicsModes?
Please use the short class name in the phpdoc
could you actually skip in beforeClass ?
Hmmm. So, for `symfony/config` it should stay `self.version`. But what constraint we should put for `symfony/event-dispatcher`? `>=2.1.0`, @stof @fabpot ?
This test covers this case

      36                 :     public static function load($classes, $cacheDir, $name, $autoReload, $adaptive = false, $extension = '.php')                
      37                 :     {                                                                                                                           
      38                 :         // each $name can only be loaded once per PHP process                                                                   
      39               2 :         if (isset(self::$loaded[$name])) {                                                                                      
      40               1 :             return;                                                                                                             
      41                 :         }      

In fact it is not very related to the PR description :)
'date' is how the option is exposed to code setting that option: logly.options({date: true}) but within the module I used a longer datePrefix. If that feels dirty, you can call it 'date' internally as well instead of 'datePrefix'.
Like this:
```ruby
(flash[ftype] += msg).html_safe
```
I like this, however I'd prefer that the Activity posting job were more general as opposed to just for this guy.

Let's discuss.
Ar fi mai restful cu resources :participants și metoda create.
Yup, I like that, will do :) 420ff98
could you rename this variable to `writable_dirs`?
``GNU`` ``sed`` and ``BSD`` ``sed`` doesn't allow in-place file transformations the exact same way:

- ``BSD``:  ``sed -e "my-sed-inline-script" -i '' my-in-place-edited-file``
- ``GNU``: ``sed -e "my-sed-inline-script" -i'' my-in-place-edited-file``
I know I'm being pedantic :-) But the indentation is weird
It looks like this needs to be protected by a lock, as multiple deployments can deploy simultaneously.
Done! ;) Thanks!
I don’t think the `<section><h1 /><section>` makes much sense here. Why not using a `<header>` instead, without any heading?
`var origin = evt.target.dataset.frameOrigin` and use it.
:O where is the `body` tag closing?
and < / script >
Remove this label... there is no such thing as "Ground Mode", at most this should be "Turn Off Airplane Mode"
Why is this needed? You should be able to just link to the page by name.
Maybe use a regular expression with grouping to match these? That will be nicer to handle if it fails and the user messes up the config file format.
providedative?
The `#to_str` and `#to_ary` methods are generally supposed to be used with objects that are interface compatible with `String` and `Array`.
Agreed. Weird, I thought #now was from ActiveSupport.
apple-mobile-web-app-title was introduced in iOS 6
in express 2.x, we use https://github.com/visionmedia/express-messages, but not sure about express 3.x. although tbh we should focus on something that handles both the HTML and the JSON cases.
Due to restful nature of resource describing  - not happening (is this even english?)
It just sets the logger format if there is one.
Use a wrapper for shell calls for easy mocking.
The spacing is preferred, it keeps the variable names on the same column. Easier to read.
Nope, just made it generic as it was before. Probably wants a comment as to why it is as it is. I'll add one.
I will do that as soon as possible. I was planning to do that. There is no harm doing it right away though so i will do that!
&view=review has been deprecated after K1.7.
May I ask how that matters?
the list missing help on every update from git changes.. if new items/objets appears, this line will show (without no faild exit code) the remaining files not packaged inside "deb" files generateds..

this change in rules are very helpfully and important, please merge hurry
I reccomend changing the name of this method as materials already have a method link this and it may confuse people.
This had to move to the bottom to fix some scrolling bugs in older IE versions (if we set the visibility too early it would confuse IE7 when hiding the scrollbar after deleting enough lines out of the editor that it no longer needed to scroll).
The intent is that during the bootjob process, after its loaded `Equipment.yap` into memory and is writing the items to file as JSON objects, it will check for an existing JSON Item_Name.item in the repository/equipment folder.  If such an item exists, it won't save the version from `Equipment.yap`.

The idea was to add in all the 2.5 Errata items into git, and into the build process, so they'd extract during install to the `repository/equipment` folder.

See my comment at the end for more discussion on how to handle these 2.5 items.
If we're sure that branch defaults to self.branch, then yeah.  OTOH, if we're sure, why do the "or 'master'"?  Using 'master' as the fallback is almost certainly wrong here.
again, is this all just an indentation change?
hmm, indeed
you should configure it only when the zip archive exists as it depends on it whereas composer currently does not (it tries to fallback to the system ``unzip``)
shouldn't scripts be in the RootPackageInterface as they are root-only ?
I'm not committed to "use strict" - I just figured it would keep me honest. :)
whitespace missing :)
This also break my virtual host free dev environment, as ->generate() returns /trnsprt.ch/web/c and ->handle() expects /c. I'm not sure if I should just give up my current env or fix this somehow.
@note.project_name is not defined in these codes.