labofsahil/github-event-dataset-2012 huggingface dataset:
the meaning of "together" is vague here. I'd probably kill this bullet as it's not distinguishing, and I might move it down lower in the list regardless.

in some sense, because metadata and content are in different collections, gridfs doesn't *quite* provide "storing metadata and data together," though that might be splitting hairs.
hmm never seen this way of assigning a variable. any reason why we can't have it just mentor_choices ?
Should probably be passed as arguments in the constructor rather then globalising them.
not sure, if here is the only place smilies are wrapped with <img>, but works in every case tested.
You can copy files into a temporary directory and run tests there. Modifying the tree is not acceptable.
hm... Ok then.
This is wrong code. This was deleted later. Due to lots of problems with dealing with git, this, that belongs to another ticket, was mixed up in here.
I recommend adding docs above __cache describing its structure. Whenever I see an unknown complicated variable somewhere else in the code, I always check its definition for structure and invariant comments. (key, payload stuff)
devops json should just parse a full url with port/username/etc instead of doing this all over the codebase.
Many folks like to define all vars at the top of the scope (eg function). Eg, all_stats and ticket_type would be defined directly below all_errors.
Using underscore helps remove incidental vars which is nice.
I'll make that change.  However, according to the grammar rules I learned (or at least, the way I remember it), a sentence can be fully grammatical even without a subject or verb if those can be easily inferred.  As such, don't expect to see "This parameter is" at the beginning of the sentence :wink:
This appears to be mixing apples and oranges.  The `getYUIModuleResources()` method *looks* like it's returning resources, but it really is returning YUI loader config info.  So I think it should either return resources (real or faked), or `yuiRess`, `getYUIModuleResources()`, and the `res` of `res: yuiRess[module]` (later on) should be renamed.
We don't prefix fields with an underscore
Also, startDate should be Util.DateTime(time, 24)
sure. would do that.
Rather, I mean, can we move this? It doesn't have to happen now :), but I can make a ticket for it if it's do-able
RxNorm http://www.nlm.nih.gov/research/umls/rxnorm/
Nathan,

I haven't implemented such a thing but if it works I will let you know.

On Wed, Apr 18, 2012 at 1:10 PM, nathanleiby <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,14 @@
>
> any way we can share more controller + model logic between the Sencha
> Touch and the ExtJS4 implementations?
>
> http://www.sencha.com/forum/showthread.php?181599-Relation-between-SenchaTouch-2-and-ExtJS4
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Raxa/Raxa-JSS/pull/18/files#r699793
>



-- 
Vikas Singh
Senior Undergraduate
Department of Computer Engineering
Institute of Technology
Banaras Hindu University
Varanasi
Ph: +91 9838438152
https://raxaemr.atlassian.net/browse/RAXAJSS-369
Because copy'n'paste is my friend. :-P
Doesn't this method get nuked? Is it just a repeat? Think it can be deleted.
Here I had to introduce a cast to preserve the "grad(*,wrt).type == wrt.type" constraint. This pull request gets rid of that constraint for tensor.grad but tensor.Rop still needs that constraint.
Add test for that error.
This would be slightly easier to understand as separate if blocks returning false?
Take the regular expression out of the routine and compile it.

Also, a nicer way to put it:

```
result = re.match(r'^[a-z]{1}[a-z0-9_]*[a-z0-9]{1}$', data)
return bool(result)
```
nested_commit_on_success everywhere
sorry dude, only super core contributors / proj owners here
Is there any possibility of passing the used cache in parameters for migrations stuff? If that would be possible, then there would be no need to change what "cache" is at all.  Another possibility is to have cache = AppCache(), and then have set_dynamic_cache() and get_dynamic_cache() functions for those use cases where you need a dynamic cache. That is, the cache var would always reference the one true global installed apps cache, and when you need it you have the possibility to use an alternate cache. Not that this is too beautiful either...

So,  the question is: where exactly do you need the dynamic cache references - are they really needed globally? Currently the loading.cache reference doesn't seem to be used that much, so is it really a big problem?
Yes. The indexes are created in ``getPostAlterTableIndexForeignKeySQL`` method. We want to create indexes on renamed table (not on __temp__).
this change is not related to this pull request. So could you make a new one if you think that it should be changed? Thanks.
The change in this function is wrong, but it looks like the function itself is (rightfully, esp given it was duplicating the newline check, heh) not used anywhere, so we can just nuke it.
Why is 'mean' the default? In my opinion, there shouldn't be a default at all. If you're creating aggregate curves, you should be specifying exactly what type, always. The name `create_aggregate_curve` itself does not explicitly have anything to with `mean` curves. It's a bit confusing.
BTW, I'm just going to leave this here:

```
json_encode(array(), JSON_FORCE_OBJECT);
```
here it is: http://bugs.jquery.com/ticket/10617 And here's why we thought it stays at the time: http://bugs.jquery.com/ticket/10617#comment:2

Although, multiplying two strings is unambiguous... I think it may be fine.
Good question. It mimics existing behavior in BigIntArray. I think this method is only called on initialization so it doesn't matter.
cannot find any other destroyed reference in the code with `git grep "destroyed" -- src/`. Seems this variable is not in use?
Hi Kun,

Just making sure that you intentionally meant to store all edge features (from all documents) into one single array.  This one array is duplicated in each row of featuretbl below (lines 213-216).
Label field outside of form
Names like ``../../../../../etc/passwd`` come to mind with the current solution... the file path needs to have have validation and/or sanitation.
cool, I'll try in a minute.
I don't think any ones asking you for said maintenance. The patch won't be merged upstream, and users require it for use with Homebrew, and so the users who maintain the Mac things handle this patch.
Tu n'as pas mis la nouvelle base de donnée dans ton commit
hrm, `vumi.persist.model.Manager` allows this to be set, it defaults to `False` and perhaps the only thing we need to change is swap that for `True` on the `TxRiakManager` ?
I had to read this line twice to figure out what it's actually doing. Maybe something like this would be clearer:
```python
sval = self._data.setdefault(key, set())
old_len = len(sval)
sval.update(map(self._encode, values))
return len(sval) - old_len
```
This should be `http://127.0.0.1:5000/authorize_callback` to be consistent with the URL used later in the document.
ok.. muß mir aber erst noch exception handling en detail durchlesen.. noch keinen echten plan von.. ;)
The 6 bad uses of this star are the 6 observations from these products.
WAListView is generic, this connection shouldn't be here
Why need to login again?
can you just set src here? also, doesn't look like you're using proxy.path anywhere…

```js
src = url.parse(process.env.HTTP_PROXY);
```
Rather than use a local temp, I'd rather refactor so this can be

fail(missingExceptionMessage())
class @YieldStorage ...
why not just callback w/ no frequency in this case since there's a non-custom app involved, so that normal backoff logic will happen? passing back the default one here looks like it'll just lock in to that only then?
it looks like we're putting spaces after and before the :
Fetching updates requires cross-domain XHR requests, which are not allowed by most browsers. In the future, this could be enabled via the proxy server and update the brackets version running on the server that way.
Sorry, I just meant to cache it as a var instead of creating a new jQuery object each time.

```
var $body = $(document.body);
```
Lines 39 through 44 initialize module vars to jQuery objects before ``htmlContentLoadComplete`` fires. Need to move their initialization to this event handler. We should scrub all remaining modules for add queries to the DOM.
Sorry, one last nitpick. These selectors seem over-qualified. Could the 'a' selectors be reduced to ".resizing a"?
The goal of the previous test was just to find out if a simple regex test was faster than a replace when the pattern in the replace yields no hits. It was focused on the subset of data where no unicode chars are found in the selectors. That's why I didn't add any escaped chars.

<code />

In any case, and to be more thorough, I've created a second [test](http://jsperf.com/regex-test-vs-replace-when-hits). In this one, some characters are being randomly substituted with their escaped equivalents. This ensures that the replace code is executed. As expected, the version with the `if(regex.test())` is slightly slower as is executing the same piece of code plus the additional if operator.

<code />

To complete a study on this, I think we'd need some usage statistics of escaped characters in css so that we could model how often this happens (I guess not that often anyway :D). With that data, we could compare the overall impact of this fix and the difference in performance between using or not the first _if_ clause. In any case, I assume using escaped characters in css is pretty rare so I'm confident in using the _test()_ solution based on the results of the first test.
``result`` defined twice in this closure.
Reminder: TODO
These three lines are copy-pasted from above. `get_url_base()` already should never end in a slash—if it does a whole bunch of other things won't work. If you'd like, you can add this check to the `get_url_base` function itself, but it seems wrong to check after every time you call it.
below => above
tag 的樣式可以統一一個 `_tag.scss` 出來
This is broken, if the user doesn't have jQuery this will break.

Instead `@el` should be set to `@el = @el[0] if @el instanceof jQuery`
I also indented .register classes, because I am planning to move them under the #main (I already did, but will put in the another request).
What is wrong with existing `logout_then_login` view?
Span is unnecessary.
oh, yes, sorry, I didn't notice the `_`
Do you mind making this into an `if` block? It's grown past the one-line level of acceptability, I think :P.
Why are the `icon` and `text` properties attached to element instead of just being vars here?
You shouldn't need to do this. `mediacontentchanged` is already fired from `Media` objects.
You also want to add `pickers[ prop ].setAttribute( "disabled", "true" )` to actually disable editing, particularly in Firefox
Here too. I don't think we should keep anything about mortar in here. If people don't change it, we want something generic, not something pointing back to us. I'd take out all mentions of mortar, the github URL, etc. and leave them generic or blank.
Seems isFirefoxExtension is broken, I get setUserData errors, which only occurs in FirefoxCom in Chrome http://minus.com/mDb92dcX5/
It is evaluated relative to the current file.  Like __directory.
changes from line height 12px to 20px
That's true. I've slightly changed the comment  to:
`# Since the controller is the one creating both models: app and database. It's better to test if from the UI.`
field declaration between methods?
500M is too much.
Of course we should allow user use `insert` to inserting the last slide. Maybe it's not obvious but users not always can know what they need to add: last or pre-last slide. We help them.
And yes, we should document this. Will you do it?
This one is a mistake.
Good catch on the debugger, I will remove.
The license header should be the Monolog one. Authorship for classes is handled using the ``@author`` annotation in the phpdoc of the class
No, me being lazy. I reused the tables from the join order test. Anyway, I
created a testunion-ddl.sql and use it there

On Fri, Sep 21, 2012 at 5:28 PM, Paul A Martel <notifications@github.com>wrote:

> In tests/frontend/org/voltdb/planner/TestUnion.java:
>
> > +        catch (Exception ex) {}
> > +        try {
> > +            aide.compile("select A from T1 EXCEPT select B from T2", 0, false, null);
> > +            fail();
> > +        }
> > +        catch (Exception ex) {}
> > +        try {
> > +            aide.compile("select A from T1 EXCEPT ALL select B from T2", 0, false, null);
> > +            fail();
> > +        }
> > +        catch (Exception ex) {}
> > +    }
> > +
> > +    @Override
> > +    protected void setUp() throws Exception {
> > +        aide = new PlannerTestAideDeCamp(TestUnion.class.getResource("testjoinorder-ddl.sql"),
>
> copy/paste error (joinorder?)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1665963>.
>
>
Here and below, the classes are never explicitly imported, so i think it's important to show where they come from and how to import them.
Commenting based on the failing Travis results when turning on `--remote-data` (#491).

```
googlepage.read().decode('utf-8').find('oogle</title>') > -1
```

Travis apparently has a default encoding of `ascii`, so it can't decode the `utf-8`-encoded Google homepage.
This function concerns me, as it duplicates the functionality in the `astropy.config.get_data_*` family of functions, especially the URL handling.  Might it make more sense to port this behavior there, and use that in `io.ascii`?
Fixed :)!
boost::interprocess doesn't use files, except on Windows. Other platforms don't have these internals.
There is no interprocess::ipcdetail on Linux.
if we make this global... `var waitGroup sync.WaitGroup` we wont need to pass it around
More spaces needed here.
Yes, this will always run... The validator will check if the POST is a WS-Federation response. I could add a check in the validator to see if "IdentityProviderUrl" was set. I will have to use the static Kernel to get IApplicationSettings though, something you don't like :)
I could find nothing in the documentation regarding versions of APC. Due to that, this should probably be a change made in 2.3 and not 2.2.x. Alternatively, one could add a constructor which uses function_exists to set a variable function to use for doContains().
what about ``return $lifetime === 0 || $lifetime > time()`` instead of the negation ?
good catch :-)
I haven't changed that, it is commented out, forgot to clean it so it relies on the default as it was. and type is used as part of the composite key that's why it is in joincolumn. But could be that it refers the wrong column (discriminator instead of the one defined in composite key - they have same value thou)
Hey Nicolas, have a look here: https://github.com/enspiral/loomio/blob/master/app/assets/javascripts/main.js.coffee#L8

I think we're accomplishing the same thing, only you just call Application.functionName to access the function. Maybe we should switch this line to doing that method? What do you think?
Well, if we do this, we can simplify a lot the problem as we don't need to wrap the Cookie class anymore. 

I gonna do this to have clean code base and we see later if we have the need to checking expiration at dynamically.
I wonder if this should use the mapper's canonical classname resolution, now that we have it
I agree in principle, but a better way to do this in general would be to track whether or not the package needs to be reloaded, so we can do it a minimal number of times regardless of in what order the functions are called.
Awesome, fonts work now!
No idea for that line of the diff, I didn't even realize it was here.
Either I added it by inattention or my text editor added it by itself. But
it's probably not needed.

2012/11/3 Henrik Rydgård <notifications@github.com>

> In Common/FixedSizeQueue.h:
>
> > @@ -36,7 +38,7 @@ class FixedSizeQueue
> >  	// Make copy constructor private for now.
> >  	FixedSizeQueue(FixedSizeQueue &other) {	}
> >
> > -public:
> > +    public:
>
> This indentation needed? :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hrydgard/ppsspp/pull/4/files#r2024079>.
>
>
Let's call this function something different from the test, to avoid confusion. Also, while we're at it, let's not have 'test' in the name, just in case nose somehow finds it (it attempts to run any function it finds named 'test').
else return unrecognized
Can we do something like `GITERR_CHECK_ALLOC` for structure version checking so that we don't have to repeat this function throughout the codebase?  I'm thinking:

```c
int git__check_version(void *structure, int expected, const char *name)
{
    int actual = *(int *)structure;
    if (actual > 0 && actual <= expected)
        return 0;
    giterr_set(GITERR_INVALID, "Invalid version %d for %s structure", actual, name);
    return -1;
}

#define GITERR_CHECK_VERSION(S,V,N) if (git__check_version(S,V,N) < 0) return -1
```

and then use it as:

```c
GITERR_CHECK_VERSION(opts, GIT_CHECKOUT_OPTS_VERSION, "git_checkout_opts");
```

The same function could be used just about everywhere, I think.
I guess I will try to simplify this "eventually".
shouldn't that be:
```source_list = [x.strip() for x in source_list if x.strip()]```
just in case there are double or extra newlines characters
On Thu, Dec 13, 2012 at 04:57:35PM -0800, Rob Hudson wrote:
>There's `check_review_delete` already that's available to the templates. Do you need to make this?

Ah, I completely missed that.

-- 
Kris Maglione

Beware of "the real world".  A speaker's appeal to it is always an
invitation not to challenge his tacit assumptions.
	--Edsger W. Dijkstra
Yikes! I added a fix
and you should typehint the ContainerBuilder
you should move these to the property declarations
Silly me, they're not used. Forget it.
should it be `array_key_exists` ?
The description was wrong because the route itself does not miss mandatory params which misleadingly sounds like the route definition was wrong.
this must be documented as a BC break in the CHANGELOG and UPGRADE files
nvm, it is done in the parent class
``mixed`` is enough as it already covers the case of closures.
t.references :user というのもありますよ.

あと *_id にはインデックスを貼っておきたい ( see http://rails-bestpractices.com/posts/21-always-add-db-index )
There is a redundant space at the end of line.
It should be removed.
Once the `NSView` animations are implemented as noted above, the `animator` proxy can be removed since we're using implicit animation.
Weren't we limited to doubles because proj4 requires that? Is that still an issue?
A comment here saying the ```(-70, -45)``` is the bottom left x, y and 90, 90 are the width and height in coord system defined by transform keyword arg would help, otherwise it's a bit cryptic.
I am confused to the cactus here...
Looking closely at the ZendeskClient.get_client implementation, won't the callback be "inserted" be called as many times as get_client is invoked? If so, won't errors be handled twice in some situations, now that we're not memoizing the client in the controller? I think that's a failing of the ZendeskClient, rather than this code, but probably worth fixing.
I think we should add the stylesheet, not override it. I'll make the change.
Good suggestion.  Fixed
That's a good idea. I'll try and put this in when I get a chance.
`class TestObject(HasTraits): ...;  test_object = TestObject()`  ?  Probably not worth the effort to change, though;  I suggest merging as-is.
users now have another couch which holds their activity feed. at the moment it is not being replicated to or from, users activities are still in their userdetails
The translation team is not using the message id as a key. See, for example, https://github.com/jbossas/jboss-as/blob/7.1/controller/src/main/resources/org/jboss/as/controller/ControllerLogger.i18n_de.properties.

So this change is equivalent to a new property.
On Wed, Jun 20, 2012 at 11:34 PM, Brian Stansberry
<reply@reply.github.com>
wrote:
>>                          <artifactId>maven-surefire-plugin</artifactId>
>> +                        <!-- TODO remove the version number when the flushing of test output is fixed, version 2.9 works fine -->
>> +                        <version>2.9</version>
>
> Is this absolutely necessary to achieve the goals of this patch? Moving the plugin version back in just one of the many poms in the AS has a bad smell.

No, it's absolutely not necessary, but it's handy. I'm not sure why we
use the surefire-plugin version which has problems with output
flushing (I hope we have a reason for it). It's annoying to run/debug
a single test without having the output log file  for the test.
Nevertheless I can change it back.
I doubt it's possible.  During the transition from START_FAILED to DOWN, the start exception is cleared.
However, we might as well avoid the possibility altogether by only doing the check if the target state is UP.
This attributed is defined only for use in XML processing to pick up and then process the XML <cache name="..." .../> attribute and does not appear in any resource as an attribute.
Updating the dialer.en-US.properties... ;-)
`this.settingGroups.splice(this.settingGroups.indexOf(this.defaultGroup), 1);`

or 

    this.settingGroups.splice(
      this.settingGroups.indexOf(this.defaultGroup), 1);


missing comma, this will not pass gjslint
add a `XXX` note above.
Don't you need to add it to build/permissions.js too?
bugzilla bug number needed
Do we really need the photo of the contact? In the wireframes only refer to String (p8). 
Or should I assume that you use the photo as a temporal mock until UX gives us a design?
Remove dead code! No Zombies! :)
another the comment, why we need here the async storage? If that data has nothing to do with app and is never updated,  shouldn't this be in a JSON config file?
Sorry, from my point of view I like the previous alternative but talking about it with Ricarco, @rafaelrebolleda , etc said to me that it is the correct behavior, 1click -> landing page, more clicks -> stay in landing page
Use window.matchMedia("(orientation: portrait)"); instead of checking it yourself.
I will try to come up with a STR I can't seem to find a bugzilla bug for this but I definitely observed behavior that indicated it was caching through force reloads.
When we're out of the "status bar media query" and `[data-count="1"]` .direction is displayed. I can remove the first par of the selector though.
cstyle -> computedStyle
I tried 1000, 1200, 1500 and 2000
And I find 1200 the best one
For the indentation, I used gjslint, but he couldn't find error.
It's the second time I use it, so maybe I made a mistake.
I use it like this  "gjslint path/to/gaia/ apps/system/js/utility_tray.js"
Maybe there is a style definition file or something else.
Maketplace app
Please remove the testing code :)
Makes sense to me. Would you mind if we do that in a follow-up, e.g. for the 7bit encoding pref for SMS that you’re working on?
I think it would be better to have a "NIMBUS_STORAGE_DIR" config that's always used as the root on the storage system. In the special case of using local storage, then STORM_LOCAL_DIR can be used if NIMBUS_STORAGE_DIR is undefined. Otherwise, we should mandate that NIMBUS_STORAGE_DIR is set for all other storage implementations.
Yea, it would be good to check for this in the TopologyContext. Part of setup-metrics! could be to tell the TopologyContext to stop accepting new registerMetrics invocations.
This is supposed to work on any version of PostgreSQL and does not 
require any optional modules (PostgreSQL 8.4 was desirable since it 
ships with EL 5 and 6). I think BSON/JSON is better than hstore since it 
has richer typing built into it (numbers, strings, hashes, and arrays).

On 2012-10-24 23:53, tjmcs wrote:
>
> In lib/project_razor/persist/postgresplugin.rb:
>
> > +        if @statements.add?(statement_name)
> > +          prepare_on_collection(statement_name, collection_name, 'SELECT value::bytea FROM ' + table_for_collection(collection_name))
> > +        end
> > +        exec_select_on_collection(statement_name, [])
> > +      end
> > +
> > +      # Returns the entry keyed by the uuid of the given object_doc from the specified collection
> > +      #
> > +      # @param object_doc [Hash]
> > +      # @param collection_name [Symbol]
> > +      # @return [Hash] or nil if the object cannot be found
> > +      #
> > +      def object_doc_get_by_uuid(object_doc, collection_name)
> > +        statement_name = "one:#{collection_name}"
> > +        if @statements.add?(statement_name)
> > +          prepare_on_collection(statement_name, collection_name, 'SELECT value::bytea FROM ' + table_for_collection(collection_name) + ' WHERE id = $1::uuid')
>
> OK, so you're creating tables for each collection, then storing a 
> byte-array under that collection's table for each key/value pair...is 
> this better/worse than using the HStore optional module from within 
> PostgreSQL (granted, it's only available in PostgreSQL v9.0 and later) 
> to add similar key/value functionality (or are you specifically trying 
> to put something together here that will work or *any* version of 
> PostgreSQL)?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/puppetlabs/Razor/pull/224/files#r1934843>.
>
Originally state was going to be maintained in the node object in early design. This was replaced with models containing state which allowed for model-defined state machine. #current_state is obsolete and commented out now.
`askOption` needed.
~~~
成否の通知を有効にし、email か webhooks で受信することができます。チェックボックスを有効にしたら通知タイプの欄にすすんでください。
~~~

→

~~~
成否の通知を有効にし、email か webhooks で受信することができます。チェックボックスを有効にしたら通知タイプの欄に進んでください。
~~~
Is there an important difference between 2 or three phases ? it seems like there has to be a different result.. if there is no difference, please use the same amount of phases is both cases...
Do we want to hardcode 2.7.3? Maybe it could be a different version of python 2.7?
Again, this should go into the flavour image and do there the magic. The Amazon image will just pass but the Occi image will gracefully stop.

We need a mechanism to automatically load the image module based on the flavour. It' shouldn't be something like a bunch of nested if's but something that explores the installed modules in the different externsions and tries to load up something based on some naming rules or some CS config. I think I've got something in DIRAC that can help.
This way of add a child in a Node looks strange. 
Since one node can have only one parent, I think we can set its parent in its father's add_child() method. In this way we can just call one method like:
```map(new.add_chlid, old.get_children())```
You're right; I misunderstood your point.  `schedulerid` would make a fine primary key on this table.
s/WithPropeties/WithProperties
Yes, but then your catch gets invoked, and you check the SAN... as written, the first transfer doesnt even try to verify the CN, so will accept anything.
you have trailing whitespaces in your (not really) empty lines
デフォルトの実装の **render** は何もしません。ViewのテンプレートをModelのデータからレンダリングし、新しいHTMLで`this.el`を更新するような、独自のコードで上書きします。よい慣習として、コールチェーンを有効にするため **render** の最後で`return this`します。
Why are you doing with the healthcheck urls? These need to be specific by application.
I like it, but I think the slideUp should still be slow here and on line 131. It seems jarring to have it disappear so fast, which can often be by accident.
podemos colocar o wres.tour como dependência do wres.policy.
It might be worth saying that it doesn't load anything.
I'm not in love with this particular example, and it is more complex than I'd like. But I'm not really sure what you mean by "generic" versus "concrete" - I very much like the idea of it being a real example that does something we might find useful.

I also wondered about stealing Jeff's tab mouseover: https://builder.addons.mozilla.org/addon/1066332/latest/ which has the virtue of avoiding that XPCOM cruft. Do you like that any better, or have any other ideas?
I thought we agreed this was going to be called siteLogo: https://groups.google.com/group/mozilla.dev.identity/browse_thread/thread/d4b1de64ce6cc6e5/3c4fa265a6ab1c9b?lnk=gst&q=siteName#3c4fa265a6ab1c9b
... in `suite.js` too! :)
Nit: Should capitalize Bugzilla.
I removed this second argument from the constructor as it's not used in the constructor anywhere. The constructor signature changed and I have affected the code change everywhere ;)
I've addressed this concern in e5ca9165778e15c6637af3b221ed33b401070fb4 so there's no next actions on your part.
This was copied verbatim from the previous implementation... yeah, it sucks.  sorry.
Should this be `:paths` or something else plural, to indicate the nature of it better?
I presume these tests fail without the fix from above?
Should preserve original whitespace, etc, I think.
raise_missing_default_stub_error sounds better of the lot. I'll make the changes. Thanks.
that works on php 5.3.9, don't know if also on lesser versions.
you can even implement 2 interfaces that have the same methods, which should be forbidden arcording php manual.
as we currently have 5.3.3. as minimum version, i think we MUST remove these lines.
On the other hand, i am +1 for 5.4.x as minium version ;-)
I find the current blocking of the if's clearer to read, the first is interested in casting if appropriate, and the second is interested in failing if anything something other than Sql was passed in.  Unless there is a clear standard that says this is a no-no, I just assume keep it as is.
I would agree on this, but I was unsure, so I added it, because it was public. Shall I remove it or keep it like this? Matthew?
this will nto match because of the requirement. And this action is useless IMO as the job is done by your editAction already
We do not document return voids....
I see.  Good to know, thank you.
I'd still keep the default.
Most reliable languages explode if they can't find an option in a case. PHP "smartly" ignores that and goes out of switch to the next statement.
Even though it's ok because the tool is written in PHP, it is too WTF for anyone reading our code.
A funguje ti to?
```
$ python2 server.py
Traceback (most recent call last):
  File "server.py", line 5, in <module>
    import infoboard
ImportError: No module named infoboard
```
used somewhere? or rename to _logger
This was required to fix the DOLFIN runtime compilation, right? Then you might be right. The build with ictce is working fine, but I haven't tested the runtime yet.

Do you remember how you ran into that this is required? We should add it the command that failed to the sanity check.
Add newline between ## and Copyright
Or just a new branch. It should merge fine.
Oh, I see. I like to keep side effects within as small of a scope as possible. Can you possibly have `parseCallSignature` return a list of `Argument` nodes and then create the `FunCall` node, passing the args as the 4th argument like the previous code? It makes it more explicit of what's going on.

Don't worry too much about it.
this should probably be changed to:
SDL.audio.context.createBufferSource(1,SDL.audio.samples,SDL.audio.freq);
On some browsers like the Chrome, the difference is negligible.  On Firefox, the speed improvement is dramatic.

http://jsperf.com/comparison-of-comparisons

This is not a speed-sensitive section of code, but why would you ever prefer type coercion?  To save eight bits?  (Actually less than eight bits after gzip.)
Ok so the template comment was a bit ambiguous, but what he meant was to have the the email body in a txt file and load and render it.
Roughly like this:

```
from django.shortcuts import render

context = {
    'personal_message': self.message,
    'sender': sender or _('A fellow Mozillian'),
    'link': self.get_url()
}
message = get_template('phonebook/email/invite.txt', context)
```

and in `apps/phonebook/templates/phonebook/email/invite_email.txt`:

```
{% trans sender=sender %}
Hi there. {{ sender }} has invited you to join mozillians.org
the community directory for Mozilla contributors. You
can create a community profile for yourself and search
for other contributors to learn more about them or get 
in touch.
{% endtrans %}
{% if personal_message %}
{{ _("Personal message:") }}
{{ personal_message }}
{% endif %}

{{ _("Join Mozillians:") }} {{ link }}
```
Note: the indention here is terrible because in a text email, whitespace matters. And I am writing this from memory and so it will need some massaging.
The above line, readyState = 4, and the lines to follow:

            timeUpdate();
            media.dispatchEvent( "canplaythrough" );

Should happen inside the fetch duration function, only after it succeeds, and in the correct order. The order was the previous order and is emulating the order the events fire in HTML5 spec. durationChange, loadedmetadata, loadeddata, readystate = 4, canplaythrough, in this order.
hmmm. That may be the case. You are right. In the sync case i would cache the file read nevertheless and I would rename it to 'scriptSync' in this case and add a async version as 'script'  - even when added later but just to be compliant to node.js apis
これ??
```
 OmniAuth.config.test_mode = true
  OmniAuth.config.mock_auth[:google_apps] = {
    provider: 'google_apps',
    info: { email:  'user@example.com' }
  }
```
and probably this can be something like:

@squid_url = SmartProxy.squid_proxy.join(:subnets)where(:subnet => {:id => host.subnet_id}).first if host.subnet_id
I'm going to vote on "no" for this stuff in the core. I'm fine keeping the library smaller/simpler and letting the consumer handle these issues. Or heck, even a separate gem that wraps harvested to provide these friendlier utilities. If this is going to be done, it should probably be handled across the board on the models, and it's making the library feel more ORM-like. For that matter, the fact that we we have `harvested.projects.update(project)` and not `project.save()` was intentional from the get-go.

If you guys want to keep discussing, we can also move this discussion to a new issue instead of keeping it wrapped in this PR.
Change Saving... to Deleting...
Thanks, but I tried a simplified version and

1. It does not ignore README and LICENSE
2. It does not ignore `*.phar`, so I need that in there
3. I want it to explicitly ignore `composer.*` and `phpunit.xml.*` as it still searches in them without explicitly adding those lines
4. Even though the DefaultFinder specifies to exclude `vendor` when I try it, it still seems to search in `vendor` (maybe I have a lack of understanding of the Finder and I need to be using a `->files()` or a `->directories()` somewhere...)

Maybe if you can test your `.php_cs` file and verify that it works that would be cool.
After discuss with @tmartin we have decided to rename the `$literal` variable to `$escaped` which will be less ambiguous...
а зачем писать this-> явно?
Does this still need to account for people turning directory_index on and off via `page` or frontmatter?
We need to check that we're running PG > 8.1, or the GIN index will fail.
Every test should have a block of documentation above it. Can you add these in here, as well as in test-content?
Please indent this JSDoc block properly
You shouldn't need a specific function for this. This should come back as part of the configuration.
What's the reason for the odd parameter name ``_pm``
woops yeah that i++ shouldn't be there, it's covered in the "skip over second half" below.
To make `(.*)` non-greedy, and prevent it to capture \r
В задании чётко сказано, что mutatePercentage - процентный показатель, а это значит, что обрабатывать его нужно соответствующим образом. Обратите на это внимание.
Вру, чуть-чуть вышел, потому что изучил некоторые моменты, которые уже нам преподали, только глубже, то есть изучил то, что нам дали, но более досканально, чем это преподнесли на лекции.
На просторах интернета наткнулся на рассказ о особенности работы данного метода, что в случае когда искомый объект отсутствует в массиве, метод возвращает число, большее чем число элементов в массиве.

Возможно это не так, тогда не могли бы вы объяснить принцип работы метода. Спасибо.
Should add a comment to make this easier to match:
```
#endif  // !defined(AFX_RESOURCE_DLL) || defined(AFX_TARG_ENU)
```
makes the OpenDiamond platform a versatile...
\n is LF; please be consistent.
Why is the default set to new.fi.com ?
```exit 1 unless stack.destroy``` ?
Good catch Joe. The states variables were used to avoid say in a case that two different capabilities were enabled on different bits, and the access patterns from clients can potentially cause some nodes always being skipped. The states were introduced was to avoid those special cases. 

While using set cover, i think the starting location in the nodes, and the greedy algorithm itself (because the requested inputs are random) can be help avoid the corner case above. That's how load was balanced before capability was introduced.
don't you want to return only the score for the selected source? it makes more sense to me.
can live with broken up lines or with .get(x, None) statements? :)
2012/10/18 Martin Luessi <notifications@github.com>

> In mne/fiff/raw.py:
>
> >          List of channels' names
> >
> > -    verbose : bool
> > -        Use verbose output.
> > -
> > -    preload : bool
> > -        Are data preloaded from disk?
> > -
> > -    proj : bool
> > -        Apply or not the SSPs projections taken from info['projs']
> > -        when accessing data.
> > -    """
> > +    projs : list of projectors
> > +        The signal space projectors. Note: Do not manipulate this list
> > +        directly, use the add_proj and del_proj methods.
>
> My idea was to add it so people could easily inspect the projs, similarly
> to ch_names (which shouldn't be modified by users either).
>
> I'm not really opposed to removing it..
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/149/files#r1878131>.
>
>

That's nice. I always wonder why this did not yet exist. + 1
Would be nice if one could toggle between on off.

raw.proj_toggle() or sth like that
Can you make it ConceptDAOTest? There's nothing Hibernate specific about this test. Put @should on a method in the ConceptDAO interface.
I realize that the whisper output uses "Meta data" - in your explanation either use "metadata" the commonly accepted spelling of the word, or "Meta data" the term from the output.
The word "risk" features heavily in this sentence. Any way to make it less risky? :grin:
Yeah, originally I named the method #toggle_item_like, perhaps I should go back to that.
OK, I removed Python 3.
The goal is to explicitly set the attributes and not use mass-assignment? It seems like passing `user_params` to `.new` is unnecessary.

How about something like this?

    def user_from_params
      Clearance.configuration.user_model.new.tap do |user|
        user.email = params[:user].try(:delete, :email)
        user.password = params[:user].try(:delete, :password)
      end
    end
It is more backwards compatibility. We don't want to convert those arguments into POST parameters because they will be named incorrectly
There is a problem with this modification when ticker mode is actived : the result of $outerWrapper.children('.pager') is an empty array while $('.pager', $outerWrapper) returns some items.
Replace function "children" by "find" fix it.
symbols -> the given summation variable over the given limits (or words to that effect)
It deviates quite a bit from the Akka version, and Akka is in RC1 now.

We should sync before it's too late.

https://github.com/jboner/akka/blob/master/akka-actor/src/main/scala/akka/dispatch/Future.scala#L25
`#1` 用不到, 底下的 `#2`,`#3` 也用不到
I think the links between documentation pages should be relative, and even if absolute in no case to the github repo itself.
Trust me, this works. Loading first gives a black screen as optifine doesn't install.
We could also add here criteria, to list only published posts. ;)
```javascript
for (var i = 1; i < count; ++i)
```
shall we delete it if no longer used?
could you keep the positive condition but invert the logic of the then and else blocks instead ? It owuld then be consistent with the way the code is written [in AsseticBundle](https://github.com/symfony/AsseticBundle/blob/master/Templating/AsseticHelper.php#L126)
for readability i would write this as:
```
if ($request->cookies->has($this->localeCookieName)
    && $this->metaValidator->isAllowed($request->cookies->get($this->localeCookieName))
) {
```
That's right -- if the GUI backend implements show, there is no warning.
OK, Thanks. I'll work on the remaining issues tomorrow.
This can also take non-method arguments like attributes and such. I'm not too sure that it's clear that it can, at least, I was confused about that until I read through all the code and found a test that used it that way.
Oh and one other nit - use "not unlock_handle.is_displayed()" instead of directly testing for equality against a boolean.
Should specify the format
Using `childNodes instead of `children` is certainly safer. (http://trac.osgeo.org/openlayers/changeset/10801/)
Maybe add that if an exception key is present, implementors still need to verify that it actually is an exception and cannot rely on this just based on the key (relates to the previous paragraph).
This should be 

```clojure
(when-not ts
   .....)
```

vs (if (nil? ts) nil ......)
+1 Dan I take it you know how code elsewhere might have to change. Or is this not used yet anywhere?
I added documentation for these functions
indent the break ...
Magic number removed.
Is this supposed to be a list of URL resources? if so then shouldn't be "get" omitted here to correspond the actual routing? same for comments
Yeah, but we have simillar in https://wiki.sourcefabric.org/display/CS/Gimme+API+-+Section+-+articles.
I don't now ;/ i like variables and it can be useful in the future. There any info about those things in specyfications?
This spec is required to write in the Japanese site, thank you!
Ook hier moet je een typisch Engelse term die in het Nederlands ook zo gebruikt wordt niet willen vertalen. Cross-selling it is.
Similar to the previous comment, I think we know here that question_form_action is nil (because we are in the else clause).  So you can take this second part out.  At that point, the next line can become:

  <%= will_paginate @questions if !@questions.nil? %>
Seems to be not correct
Here too: `OXT_UNLIKELY(pool == NULL || process->detached())`
node.js' is the correct form
why not just adding assets folder as an asset?  then all it's content would get bundled.

Look at the framework asset in tibbtest for an example of how that is done
Can't test this from here, but this looks wrong - object_index would e.g. be SniperRed, not Sniper. Can someone check whether sniper zoom still works with this code?
Oh, haha. I forgot x was special, and I was trying to be lazy (write everything several times instead of individual things once), but forgot to remove it after not being lazy. I'll fix that.
Is this a debug function? why do you need this?
It would actually be good to replace `$::operatingsystem` with `$::osfamily` in this test.
I see. Not sure if it would work like this. What could work is to define another element that contains the argument to pass, and then pass it using a technique similar to the one shown here: http://cf-learn.info/code/ch05/unit_method_var2.cf.html, something like this:

    "warning" usebundle => $(mycheck[$(check_handle_index)][_usebundle_if_warning])("$(mycheck[$(check_handle_index)][_usebundle_if_warning_arg])"),
      ifvarclass => "$(check_handle_index)__usebundle_if_warning_defined";
IIRC, this is not needed anymore
I thought the same thing. But then realized its just decreasing the value by one. It looks odd because your expecting the single arrow before $this, instead of the de-incriminating operator. Which *should* go after instead. I think.
Should this use WP_DEBUG instead of a separate $debug parameter?
I think we could feature detect this..
Actually not at the end. There is `ShowFor.show_for_class` and the end. So it will be something like `"show_for user[:space:][:space] show_for_class"`
onlyUnstabled ?
Nit: Recommend simply the name `create`. This gives you invocation code that looks like `InputKind.create(...)`.
can support -> supports
good question, I'm not sure.

but I dont mind removing this gem, as we dont run as root by default, so reverting to ping command should be fine.

we were thinking of doing more stuff (e.g. using arp, tcp ping etc) so maybe we should consider using nmap or something instead
It will still display `<li></li>`. No?
Why ID here? Why not another class?
What are direct messages? We want to be able to post twitts in user name. What do we need for that?
If you will have any other problems, feel free to ask for more help.

But this is really a good exercise. :-) Because it is exactly what happens in practice when you do things.
It is. :) fixed.
`element` instead of `value`. This is not ``each` util function.
`contributors` < but you have content for only one contributor here?
What I am saying is to not overwrite anchor just like that. This could be loss of data. Do you really have to specify `action`? :-)
according to this: http://docutils.sourceforge.net/docs/user/rst/quickref.html#bullet-lists it's ok. But if you insist we can change that.
Tab @ EOL
new line after the else.
Ganglia spelled wrong ("Gannglia")
Nm, I'm an idiot.
did you write this? we need something similar on thimble...
duplicate function with line 287 ?
randomPortEnabled? It seems clearer to me.
Please add m_randomPortEnabled(false) to the initialization list instead (2 lines above).
To `.gitignore` too!! and this one is repeated but minified :S
Each time you write "not intended for end user" you should start the method name with an underscore. That's the standard way to indicate that a function is private, so it's clearer and you don't have to write this line in the docs.
Might be out of scope for this review, but why not use an Array here, given that every value here is true?  You could just check indexOf is greater than -1 when checking for options_not_attribtues inclusion.
Why dict? Why not tuple of tuples?
"actual" => "current"
Could we keep it as is, but instead put a comment with the faster / more efficient code, pointing out that it's more obfuscated but perhaps faster in certain cases?
I added a bit more text to explain what it does.
Or use ctrl-v to get a literal tab.  grep '[ctrl-v][tab]'
The [in] and [out] notation also looks useful.
Obviously, this isn't part of the repository. A slight concern that I'm happy to overlook for now...
in the future, can you code this way?

if a:
    then do this
else:
    something else

I find it easier to read and is generally python style (http://www.python.org/dev/peps/pep-0008/)
Can use Runnable to save one line of code; but not worth changing...
Compiler will automatically use StringBuilder if you do `"" + a + b`.
But for code of this complexity I think it will probably not optimise to 
use StringBuilder instead of `String rv`.
Pass the `er` to `cb`?
Teneses changed here, probably just make it all present "Now we open"
That is fine, this is not connecting (connect=false). It just tests the parsing part of it.
this seems to be missing from the docstring of Service, if I understand correctly.
Clients never handled 204s themselves. The difference is that now the job returns immediately and you have to poll isReady. I'm becoming less convinced by this decision all the time.
nit: let's #id { instead of starting a new line (seems to much like old C code!)
CS for the `AS`
Ar trebui folosit doc in loc de doc1.
Trailling space detected. Pode remover?
Egal, kannst nix für - das ist ein kleines Problem mit den gitattributes
Что за комментарий? Либо автоматические части, либо лучше вообще без комментария.