labofsahil/github-event-dataset-2012 huggingface dataset:
Define "must" :)

It only needs to be declared as a readable attribute if an external client wants to call transmitter.ack_ids. As it is, @ack_ids is an internal only concern to be managed by smpp::base.
Please complete the === at the same level of heading so it can render properly
Hmm, seems to me that we have a few different things (and all really awesome!):

* *Compiler Pass documentation* - This is pretty simple - just basically telling someone the idea behind them, showing them `addCompilerPass`, and how a simple compiler would look. I think this could be a quick section (or even document) in the service container component docs. This would not show it being used from inside a bundle, but just `addCompilerPass` being called on the container object.

* *The Definition, Method call, stuff* - This should definitely go in the service container component docs. This is excellent stuff.

* *Setting up a compiler pass inside a bundle* - I think this should be a cookbook article. It'd be pretty short - link to the component docs about the compiler pass, show how to set it up in the bundle, and show the location of where we prefer the compilers to live inside a bundle. This would be pretty "basebones", but I still think we should include all the actual code needed to get it to work so that you can copy things from just this one place

How's that sound to you guys?
Какой файл? Если я подряд запросил два урла на два разных файла, как я
узнаю, что к чему относится?
Да, но / на _ (и обратно) заменяется.
if (!item || !Item2Account_.contains (item))
        return;

же.
Acá también pasó algo raro.
simplify:
```lisp
     (for [col cols] 
         (Column. (:id col)
                           (:span col)
                           (:shown col)
                           (:content col-display)
                           (:custom col-display)))
```
please remove these deprecated doc blocks
That was just a 'leak' of the naming convention I have to use at work... (albeit not for Java I have to admit)
Can not depend on devise. Other auth methods can be used either
PRINTF!
This node (the forwarder) code serialize the command and invokes it remotely. On this node the isForwarded flag has the value FALSE, but on the receiving nodes it must have the value TRUE. So we set the flag to TRUE during command serialization. Alternatively we could build another command instance, but it is not as effective.
@dannygreg This should either be removed or switched to `GTDiffFileFlag` type.
Isn't this the maximum?
Indentation is cray in here.
Tiny style point: backslash line continuations are discouraged; I prefer use of parentheses instead.
This doesn't actually preserve the locators nor the minor formatters, unless I am mistaken. It was for this reason that I proposed the kwarg addition, to avoid you having to copy and paste the four line prefix and suffix to ```set_scale```. Given that we seem to have agreed to not implementing the keyword, I still think you will need to handle the minor formatter, and both locators.
Nice touch trying to launch the app from the back end to check it's not just the icon that's gone :)
Sorry, that was my fault for not being clear in a previous comment.
The app install seems to be changed... Not sure if it's expected or bug....
```clojure
(clojure.string/join File/separator ["path1" "path2"])
```
Please, dont make Java from PHP.
Yeah, it is good idea
Should have defined this as 

```clojure
(def read-strings (cascalog.ops/each #'read-string))
```
Yeah man, I like how you're thinking here. So the `unpack-chunk-location` method expects a `ModisChunkLocation` and calling it with a `DataChunk` obviously throws a `ClassCastException`. The `unpack-chunk-val` unpacks the `LocationProperty` into a `ModisChunkLocation`, but for this we actually want the `LocationProperty`.  

I totally agree that schema is a bit repetitive though. I'm getting a better feel for the different use cases. The API will need to evolve.
@arnodeclercq since we already set the background color to white with the `*` selector, do we still need it here as well?
as already said: this may be done by the TSGDataType struct
You are right. I rewrote them without realizing it ... I'll fix that
I think it was originally separated, because it could be reused. But I'm not sure if we would reuse it anyway...
Oh, wasn't aware of that - no, that's fine to leave in then.

On 10/04/2012, at 10:29 PM, Stig Lindqvist wrote:

>> @@ -36,6 +36,7 @@ static function get_encryptors() {
>> 	 * @param String $class Classname of a {@link PasswordEncryptor} subclass
>> 	 */
>> 	static function register($code, $class) {
>> +		Deprecation::notice('3.0', 'Use the Config system to register Password encryptors');
> 
> I can remove them,  but setting statics still works due to the Config.php still merges statics, see https://github.com/silverstripe/sapphire/blob/master/core/Config.php#L33 
> 
> Leave or scrap the static settings?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/silverstripe/sapphire/pull/290/files#r667548
Should this link to getlocalization?
This should be a margin, not non-breaking spaces
there appears to be a rogue space left at the end now
You're saying we should put something like `if(entry doesn't exist) put true into db` in `is_experiment_enabled`? Also, if we load an experiment for the first time while collecting = false, then that logic won't get run; don't know if this is an issue though.

I agree that is_experiment_enabled? should always return a boolean, but I don't know how we can assert that while the db may hold *any* value (or nil). It seems a little shaky to say that nil = true, or "foos" = true.
Here's the internal checkpoint thread magic: set the no-write flag for the file, then trigger the eviction server and wait for the underlying LRU queue to drain.
The above code is duplicated for the worker and checkpoint thread. I couldn't see how to refactor it nicely. Let me know if I should try harder.
You could use `save_input_as` here.
So ist kein SKIP ohne LIMIT erlaubt, ist das absicht?
I think it's probably best to create a new history object here.
At this point you'd be better of using `%(key)s` format rather than `%s` etc.
I explained it in the commit message: "We don't need a proxy file for JObject since it has always been autoloaded."
alt attribute!
Good catch.

Back in the day, I remember a teammate in a programming competition missing a problem due to building strings in this manner. (The program died on large inputs.)
Should this not be 'MIT.md'?
this is nice test cov thanks :D
Just use:

https://docs.djangoproject.com/en/dev/ref/templates/api/#the-render-to-string-shortcut
Just leave `<li>` empty. Or link to our default avatar image (we have already for Gravatar).
I would add to the end: *user page (profile).*
What? What then if they are settings variables? (And no, not all of them are setting variables.) So grep after one settings variable you see that we are using in templates and see how we are getting it into the template. There is no magic there for settings variables.
No, you use `django.contrib.staticfiles.storage.staticfiles_storage.url(path)`.
Put constants after all imports.
Ah, yes. Also it is useful to add `form` class to this form, so that you can style only that. To not style `form` HTML element, but `form` class. Because form HTML element you often use also for some special forms/buttons/links around the web page.
This is by design, mostly based on [this](https://github.com/AutoFixture/AutoFixture/issues/2#issuecomment-8033873) discussion where there's not so much detail about generating negative numbers. Noted down :)
right, using string() is probably cleaner than c_str() here.
when would the parent folder be empty?
El primer detalle que tuve que para correrlo tenia que estar en el mismo directorio del guión install.sh, para esto declare la variable `${source}`.
Added spaces at the end to break lines
change the indir/outdir to uniprot
This prevents app output from polluting spec output
That's quite tricky in fact. If '' (empty string) is considered as an identifier, then it HAVE TO be hydrated (and hence having the problem davidwindell hinted). There's no workaround for this (at least I don't see one).

But to be honest I've never seen such an identifier, does it make any sense ? So I agree with this PR, we just should check against null and empty string (as 0 could be a valid identifier this time), so elseif($value) is not enough.
Here, the ExecuteParallel should 'propagate' the runtimeServices' pointer, else the report(), setError() and exceptions logging might not work when there is more than 1 CPU. However that should be easy, the following should work fine:


    {
      ExecuteParallelData data;
      data.stub = stub;
      data.args = args;
      ExecuteParallelKL(
            count,
            RuntimeServices::ExecuteParallelCallback,
            &data,
            false, // mainThreadOnly
            KLRuntimeServices::Get() // current thread should have the services TLS data
           );
    }

I must say that ExecuteParallel has a lot of different meanings in that RuntimeServices class now... it's confusing.
Does this end up preserving the whole path (```/foo/bar/baz.png```) where we actually want the basename (```baz.png```)?
> Infinispan supports transactions and integrates with any standard JTA TransactionManager

Not a comment for a change, just wondering how true this is? So is Infinispan transactional now or not?
http://apidock.com/rails/ActiveRecord/Batches/find_in_batches should simplify this a little
It is just because cmd.Cmd doesn't extends from object and that we need to use __new__ and __init__. So we need to extends from object.
True. Add the throttling in that picture and there is even less chances of seeing this template. I will nuke it.
I would certainly hope they had all the rights info, but yes. on it.
No problem. Just making certain I understand the what's happening.
Um, which part of it??
Well that simple iterative solution I proposed certainly can't beat 1.e-6 in 3 or 4 iterations!  The ODD vs Exponential calculation speed will be a good thing to test in future, will make a mental note.
This footnote can go away now.
In these comments at the tops of the files, there's some inconsistency in capitalization: psf and PSF are both used; I think hdu should be HDU; sometimes the software package is called galsim, sometimes GalSim.  (This comment was prompted by the "psf" in this line, but it's a more general comment across all the examples/*py and examples/*yaml files)
No, we do want to include extended params on a POST... What we want to avoid is including anything that's not an extended param (i.e. like registration) on any call back to the LRS... The standard params should be "consumed", put on the statements themselves, and not included in the requests that go back
don't you mean item here?
the image_tag is the <img> tag of html, it just shows the photo, not a form to upload a photo. And I think uploading profile photo should be done in users/edit
Same as above.. some of these scenarios can be compressed IMHO
I think this could have a more meaningful name, e.g. `addRequestCountEnrichers()`?
But not suggesting we change it in this pull request.
The “Don't push me, I'm close to the edge” sleep.

The value is too short. In a slower machine that test will fail. `sleep 1` is safer.
`getConnectionInfo()`? Or is "info" superfluous. Is there any confusion with `getConnections()`, given that Mongo has typically been synonymous with a single connection? Also, is there any reason this cannot be a static method? That would subtly imply that it really collects information beyond the scope of a single Mongo instance.
antes, res e @Test nos metodos
I want comments !!
I think there already is a function in Django that is used for login views.
Some of the breadcrumb blocks need correcting.
please remove mediaopt branding mo_ from filenames and modules.
CS please. New line for the bracket.
I mean i know u don't need to, but just for consistency
It now lives in the factory methods https://github.com/arturo-c/allplayers.php/blob/cb2dd4c15c7c5168abc3d0cb3c046ff28f52965e/src/AllPlayers/Component/ClientFactory.php#L40
```"{width=300, height=500}"``` vs ```"{width: 300, height: 500}"```
Does this exclude viewing part of the world?
If we had used a hash, this would look like

```ruby
@points[label].first
```
Name the functions `TF_forTab` etc?
This is a feature request from Suhail- we want end users to be able to turn on logging for messages sent to Mixpanel so they can debug. This is called by a public method in MixpanelAPI
全てが該当します。としました。
I think this should be a constant since we are using only in this class
I think we don't need the extend
is the author required? I prefer to omit it because this information is already in git.
Agree with @ogrisel .
patience ;)
Please remove this commented out line.
checking again, there is no way the user can set ``sparse``.
The argument should just be removed!
This docstring deserves to better describe what's happening for the different values of the `class_weight` argument.
`assert_true(True)`? is it necessary for a smoke test? Just put a `# smoke test` before the `fit` call to make it explicit that this is just a smoke test.
Sure, I don't like it either, tell me a preferred format and I will add it :)

------------------------
Sent from my Sega Master System

On 9/04/2012, at 4:44 PM, Mathias Meyer<reply@reply.github.com> wrote:

>> @@ -17,16 +17,32 @@ class App < Sinatra::Base
>> 
>>       # the main endpoint for scm services
>>       post '/' do
>> -        info "## Handling ping ##"
>> -        ping = Request.create_from(params[:payload], token)
>> -        info "## Request created : #{ping.inspect} ##"
>> +        info "## Handling ping for #{credentials.inspect} ##"
>> +        requests.publish(data, :type => 'request')
>> +        debug "## Request created : #{payload.inspect} ##"
> 
> Can you make this logging nicer? The ## really don't do it for me.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/travis-ci/travis-listener/pull/4/files#r660232
Please put the braces on their own lines.
In the event of an unrecognized alignment value, is this the intended behaviour?  Or should the alignment not change instead?
Checked against android platform, e.g. you can clear IntervalTimer with clearTimeout, but the appcelerator documentation says following:

clearInterval( Number timerId )
Cancels an interval timer.

clearTimeout( Number timerId )
Cancels a one-time timer.

I think we should follow apps documentation.
I wonder if we might want to use `lens` for easier traversals of bullets et al, but we can always look at that later. That'd give you something like `cx (bullet ^. position.x.to toValue)`, and you don't need to perform a bunch of pattern matching.
How are these changes related to the rest of the patch?
Why does this involve the theme layer?
I don't want to make this pull extremely complex, but I'm wondering if there is a way to postpone these operations to perform them in the backend.

What I'm thinking is that we have an _async_ option for heavy indexing operations, and with this solution you're going to load PDF files or other heavy stuff for parsing and decoding in the primary thread.

Maybe moving it into the backend as in [1] is too complex or has other problems (didn't think much about it), but in that case as a user I'd expect some other way to make this async?

1 - https://community.jboss.org/wiki/HibernateSearchAndOfflineTextExtraction
Yes , you're right
Yeah, would be good idea, I'll leave for separate commit, have opened issue gh-2815
Yes, that is an unfortunate effect of the legacy flag - since it implicitly imports all definitions in the current directory as root modules.

There is an option to turn legacy on/off for an individual archive.  We could set that on all archives, and convert any legacy ecl files to archives.  It would probably require automating.
I don't understand why you are testing this here. doesn't it depend on whether a dali was supplied on the command line?
I don't like how this massive comment (which is great by the way) is repeated in two places. For instance, does the same comment not apply 5 lines later when the same string replacement happens. I'd rewrite it like this:

```python
    def urlencode_params(self, params):
        """in-place replacement URL encoding parameter values.
        For example, if params == {'foo': 'bar1 bar2'}
        it changes it to == {'foo': 'bar1%20bar2'}
        """
        def quote(value):
               # the special chars %0A (newline char) and %00 (null byte)
                # break the middleware
                # we want to simply remove them from all URLs
               return urllib.quote(value).replace('%0A', '').replace('%00', '')

        for key, value in params.iteritems():
            if isinstance(value, datetime.datetime):
                value = value.strftime(self.default_datetime_format)
            if isinstance(value, datetime.date):
                value = value.strftime(self.default_date_format)
            if isinstance(value, unicode):
                value = value.encode('utf-8')
            if isinstance(value, basestring):
                params[key] = quote(value)
            if isinstance(value, (list, tuple)):
                params[key] = [
                    quote(v)
                    for v in value
                    if isinstance(v, basestring)
                ]
```

(sorry for the indentation, editing in a textarea sucks)
I didn't want to assume that the client's URL accepted a "next" URL parameter. If we wanted to support this, it seems like we'd need to offer it as a setting, to either make it optional, or even let the user specify what the parameter should be. Devolving to something will just bring them back to the app list page seemed like a tolerable alternative.
Yeah I forgot to update original comments from request module.
This is added nowhere else afaik. You can add your name as an `@author` docblock instead.
Any reason for this additional indentation?
I think the description should describe the feature more precisely. For example: "If true, the whole field is automatically selected when the user clicks on it."
@christianv Yup, just removed.
There are problems with deleting model Properties where GAE never cleans them up. Can you just add a comment that this is deprecated, and maybe move it to the bottom of the file?

See https://developers.google.com/appengine/articles/update_schema
i wonder what did this metasm do? :s
```Common#cmd_exec``` does this already
I'd probably use `SymbolSearchResult.parse_list(m)` to be consistent with the rest of the code in this file.
I like it in this project, because we:

1) Use the described class a lot, to get a matcher instance, and
2) The described class name is very long

I think it's nice to use it in this project, and other projects where those 2 conditions hold.
Good idea! Submitted the patch.
this is weird - why are we losing the puplicationTitle here? That doesn't look like it should be affected by anything in your code,  but it's not good. See also l. 984-988 below.
Yeah git can get really confusing. I'm constantly looking at the docs :/ fyi: you'll usually have better luck if you do something like put your repo in dropbox and sync it accross computers. Either that or push to a branch on github before you switch. I guess that's all easier said than done :D
Eventually we might want to remove this comment, but I'll let you off the hook for this one ;)
Yep, I meant the variable.
Android doesn't support this
No gradient.
this needs to be a for loop, not a for-in (use the one you cut)
Can we just early return in these situations? According to the logic here, there is no need to make the checks below this if passed is already false
This can probably safely point to the example above, since most people will be running the included test suite with the provided configs.
You went from 2 space indents to 4 space indents. I understand that this is a different language, however you're editing it from within the same editor. Does it make sense to stick with 2 space indents?
Pretty bold to implement opSlice whithout checking if the range is sliceable first!

This created a compile error regardless of if the user did or did not try to use opSlice.

Now it compiles.
likewise this comment
There's no such thing as a `protected static`. (Or rather, it doesn't do what you might think it means.) Make these either `public` or `private`.
while that one is set/get the concatStringParam is a constant; maybe define it as such public static final String CONCAT_STRING_PARAM
That's weird--I coulda swore I saw a rake task for cucumber.  ...weird :109:
Please fix related tests next time. I'm taking care of that now. Will append the commit to fix this to this branch/pull request.
Yes updating package.xml will be in separate PR
By default it is hidden, the `content_item_header` uses a specific class hierarchy to bring it back when needed.
https://github.com/kalupa/woople-theme/blob/4b2223514b4207484c4fba4e055be3e628c9c310/app/assets/javascripts/woople-theme/organization_dashboard_controller.js#L49
Please use the short class name in the phpdoc here (as done previously)
* flagsという抽象的な名前は避け、変数名から何に利用されるか分かる名前を付けましょう
I wouldn't say "should", but "may" :)
I love it, but can this be moved to a separate pull request?
Can we chain these?

Afaik with the CSS method we can also pass in a object.
We probable don't even need `$el` in here as we can do

```javascript
return $('<div/>').css(...
```
Nonono, fclose isn't trusted. It invalidates memory pointed to by stream.
@WalterBright There are plenty of workarounds in Phobos for stuff like this. They get removed when the compiler bug gets fixed (or should be anyway), but you never know when a bug is going to be fixed (and even if you fix it yourself, you don't know when it'll be merged), so if there's a workaround for a compiler bug, you use the workaround rather than wait for the compiler to be fixed. The key thing to do is make sure that the bug is reported and the workaround commented, which was what was done here. Though I'd suggest putting the word bug there rather than just the number - e.g. something like `@@@BUG@@@ 8675` would be fairly typical.
oops... the exception message still says "doReceive" :)
All that matters here is that two values are equal, so what difference does the order make?
See below for the new asserts
I'll try those changes on Thursday.
After looking into this more - this should just be rails - why is the application_name needed?   We have never split the logging for rails into separate log files based on application.  All rails logging goes to /var/log/rails/* which is a symlink into the ephemeral lvm.
I'm pretty sure that "at least" makes more sense here, because the request will take the 10 "sleep" seconds and then some, due to the processing overhead that comes with every request (although this is very small, of course).

"At most" sounds like it could sometimes take only 8 seconds, which isn't the case.
FYI -- one easy way in ruby to sum an array: 

```
data.inject(:+)
```
val itemsPerPage = mlProposals.length min page.count のがより本質的だと思います。
note to self, this should be changed to $mm->loadModule
should be moved to getInputFormat(). need to use PigContext.resolveClasName() for Pig loaders.
Add a similar constraint for locations.
Use a List<string> and the AddRange method to avoid to avoid turning an amortized O(n) operation into an O(n^2) one.
Does this belong somewhere more general?
refer to the above comment
`create_user` was never called before(!) so changing it shouldn't matter.
addign some validation to be sure that the users choses a unique title or rathe ra nunique pouchname for their new corpus so that there wont be any suprizes when they try to sync and the corpus already exists.
divided User_Profile into to messages to make the user profile page look cleaner... there was too many instructions when we could simply change the title.
thanks… didn't take a close look at the lint settings


On Wed, Oct 3, 2012 at 11:41 AM, Paul Armstrong <notifications@github.com>wrote:

> In config/config-lint.js:
>
> >      css: false,
> >      debug: false,
> >      devel: true,
> > -    eqeqeq: true,
> > -    evil: false,
> > +    eqeq: false,
> > +    es5: true,
> > +    evil: true,
>
> should be false (if you copied this from swig, there's a very good reason
> for allowing it there)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/paularmstrong/node-web-boilerplate/pull/1/files#r1752144>.
>
>
Is there any reason to expect a class and not a module?

Smoke testing suggests this difference is relevant:


`"Enumerable".constantize === Class => false`

I think changing it to `Class, Module` would fix it.
should the method `NestedTreeRepository::getIdExpression()` also be private?
i think for the NestedTreeRepository `protected` would be better.
no need to do a new request. Pushing to the same branch will update this PR.
тыдыдыщь
Do we know why the view isn't being drawn via any kind of google bug reports?  Just curious if there is anymore background info.
I believe this is removed later on. You should try adding my repo as a remote and diffing our HEAD's instead. It will make WAY more sense.
Considering moving the composeFilter + include creation to the Configuration object. This will allow to fail fast if regexp is wrong.

(
I see we can improve this in the ShrinkWrap Filters by Compiling the Pattern on creation and reusing it
https://github.com/shrinkwrap/shrinkwrap/blob/master/impl-base/src/main/java/org/jboss/shrinkwrap/impl/base/filter/IncludeRegExpPaths.java
)
A minor change, but there probably should be a comma after **The Amazing Spider-Man**.
Please add my email: `elnur@elnur.pro`.
Needs to be Array.each to go through all the array members
Change to Assert.hasText()
MOST important question is can we use a submodule, if we can we should use that not directly check this in.

this seems like the source so why not use it as a submodule?
http://github.com/jrburke/almond
typo: javascript_src folder
@rwmtse I guess if anyone wants to use webworks.js in this location they can do so, gaining no benefit.
@jeffheifetz - please fix these, these need to be in the webplatform. 

I am trying get someone from the community to build our whitelist extension but its hard to tell them to do a qnx callExtension

any reason you have left this like this.
debugger??
Looks like this test case handles the local startup page case but there isn't a case for an external startup age (Test 14). I can add these to the ExternalStartup app for testing file access from an external startup page.
Then lets open an issue and mark it tech debt.
Nice catch.  Now fixed
mvn package will run the tests, I'll clarify that.
I was trying to please everyone ;)
Fake :D