labofsahil/github-event-dataset-2012 huggingface dataset:
shouldn't`smart` be declared at the top of the closure
I think the indentation here is wrong.
Ben, git add -A strikes again :)
They might be. I wasn't sure what you were doing here, but if they're not required (no pun intended), I'll remove them here.
There seem to be a few of these in this changeset. Can we remove them all?
You had done the checker-box effect? Did that ever make it into master or did I accidentally clobber it?

Yeah - back to solid colours as part of the design review notes - I likes the transparency too I must say
Ah yes you are right! I didn't see the entire logic is wrapped in the Friend block. Yes I have encountered this, and it's more trouble than it's worth to try to make it work with instance variables so we can keep it as is.
这里如果写死，对于FreeBSD7就不什么都不做，那么不够灵活。比如在FreeBSD里面，你不想使用libc里面自己带的jemalloc的版本, 你想使用一个新版本的jemalloc，这个时候就不行了。而且默认的打包脚本并不一定会打开这个选项。所以我觉得这样写死不是很好。比较好的做法是这里提供机制，至于最终如何选择，由打包脚本根据实际的情况来调整。
Why not use `position` as in previous methods?
Return positively. exit(1) is a failure case
```Julia
for fn in (:dump, :idump)
    @eval ($fn)(io::IOStream, x::AbstractKind, n::Int, indent) = println(io, typeof(x), " ", x)
    # etc...
end
```
`#to_s` is not needed, `details` is containing a String after this change
After talking to @komidore64  and looking closer I withdraw my question.
`rm -f` returns 0 even if the file is missing, it seems like this is not a problem, is it?
What is this namespace? We only us SignalR.Hubs.
parseInt('012');
why have you removed that?
file issues for FIXMEs so we can track them
The different between the output of `get_equivalent_units` and `print_equivalent_units` is that the latter shows it in a nice table format, while the former returns a set of objects. I'm thinking the *table* that `print_equivalent_units` outputs is something that someone might want to use somewhere other than printed at a console.  

In general I instinctively shy away from functions that print data like this because I've had the frustrating experience of wanting to use the printed string programatically, and it's always irritating to have to try to redirect stdout an then put it back again or something like that...

But this is not crucial or anything.
To be consistent with the rest of this file, I think you want double-backticks around the branch name instead of single-backticks.  Similar for the remote names (both ``origin`` on this line and ``upstream`` below)
Technically, the one place that uses `ho_type()` cannot be repair (eg. `send_handoff`). But, there are other places in the code where you use `Type` and `HOType` that don't have specs but are of the spec `ownership_handoff | hinted_handoff | repair`. Example is `#handoff_status.type` noted below, but also the `Type` in `{Type, Opts}` of `riak_core_handoff_sender`.
The indentation should be the same.

*Before*

```js
        for (var i=0, j=md_paths.length; i<j; i++) {
            if(path.existsSync(md_paths[i])) {
                md_path = md_paths[i];
                break;
            }
        }
```

*After*

```js
        for (var i=0, j=md_paths.length; i<j; i++) {
            var _md_path = md_paths[i]
            if(existsSync(_md_path)) {
                md_path = _md_path
                break;
            }
        }
```

I'll add those semicolons.
This (and probably the next one) are #defined somewhere on Windows, breaking the build. Perhaps call it MC_ERROR, if there's really a need for 2 different ERROR values (this and CMD_ERROR).
I don't get it? Standing on the line I guess :-D.
What does TMI mean?
due to the `else` I could not leave the two ifs together - which I had earlier. the tests wouldn't have passed
We should add a test for twitter urls.
what about typehinting the array ?
@cfarrow: It is the length of the intersection of the arrow triangle/wedge with the side of the box.  "gap" arose from me thinking about needing to skip that many pixels at the intersection when drawing the rectangular box.  "arrow_taper" might be better, but i'm inclined to leave it as is (with the ugly "FIXME"), until someone has time to work on making it a useful configurable trait.  Exposing this as part of the API will probably require some experimentation and futzing, and I won't have time for that.
childtypes is not bad, we could use that. About type vs widget: I'm not entirely sure, but I think in create.js terms, collection actually is a widget. Or rather, there are at least two different widgets that can be used for collections. The type key doesn't correspond to an RDF type (i.e. something derived from TypeInterface), so that's what's making it a bit strange. It's true that it's not a widget in the sense of datepicker or tinymce or whatever, but in create.js terms, those are called "editors", if I'm not mistaken. In older versions, I called this key nodeType IIRC, not sure when or why it was changed.
could restructure the above to have the 'if end_time' outside of the two start_time checks. Also, the above misses the (rare) case where start_time == Time.now. It's probably better as

```haml
- if end_time > Time.now.to_i
  - if start_time > Time.now.to_i
    ...
  - else
    ...
```
why only 5 changesets at a time? It seems like it would be nicer for the server if we request more than 5 at a time, and thus make fewer round trips?
I've made a new commit and tested it on a dummy package (minus the texi2pdf step which fails on my machine for some reason). 

PS: I'm off to India + Europe for a month, won't be able to do follow this up
We definetely need to merge this stuff together --- i really like `sites` from `DjangoRole` and generation of files from `DjangoRole2`, also see my issue about creating ROles for common configurations like Django + uWSGI + nginx.
Good find. Somehow I managed to miss that.
We can look at it tonight, there may be a better way to refactor it.
Fair enough, I agree with your reasoning.  But it's good to have this discussion of fairly fine points documented here.
You and I both know `obj != obj` is the way that you test for a a float being `NaN`, but I wonder if it wouldn't be a lot clearer to do:

```
if math.isnan(obj) or math.isinf(obj):
    return repr(obj)
```
change this to Supplier String (note you can make a static inner class, or outer, mark it singleton.  then, you can bind(new TypeLiteral<Supplier<String>>{}).annotatedWith(TemporaryUrlKey.class).to(ReturnOrFetchTemporaryUrlKey.class)
Wait, and shouldn't these be:

~~~~
return $this->validate_before($attribute, $value, $this->attributes[$parameters[0]]);
~~~~

Think I'm missing something.
I need another pair of eyes on this: when running threaded, the pack-objects code segfaults quite regularly inside `try_delta` when calling `git_odb_object_free`, more exact when trying to free `object->raw.data` in`free_odb_object`:

```c
static void free_odb_object(void *o)
{
    git_odb_object *object = (git_odb_object *)o;

    if (object != NULL) {
        git__free(object->raw.data);
        git__free(object);
    }
}
```

Ideas?
Another unnecessary pause check.
Can you add an empty line to differentiate from the b2g redirect?
2 extra spaces here /nit
Yeah, let me revisit this.
you added this id but didn't use it. I am guessing you changed your mind somewhere along the way?
And to add results, just `results[title] = url;`
wrong. this needs to happen *before* the `try:` statement.
Depends how defensive you want to get.

the example clearly shows:


```json
{...
	"ssl": true,
    "plugins":
      [ "Hello", "RestChannels", "GithubNotification", "GithubJenkins" ]
}
```

Which to me suggests that even if it's only one it should still be the only element in an array. The nil case is caught and warned about above.
Why didn't you use the explore result action template for this? That should work for normal search, categories, tags and speakers. This seems like unneccessary duplicate code.
@adamfairholm I negated that change, you can pull now. That will need to be done though. I wil just add a generic pull request to fix it (the Router.php issue).
Is this an error condition if this occurs? Or is this a normal case? Why do we silently skip processing in this case? what if key is something else and the server connection map doesn't contain that key as well?
This looks like an implementation artifact specific for crunch support? Is this really required? Can we go without it?
if this didn't require any other changes in this file, that means it's unused, right?  Remove?
@stof , @Dinduks  ok thanks.
Wrong name. It is ``Symfony\Component\Validator\Mapping\MetadataFactoryInterface``
``$this->container`` needs to be declared
correct @asm89
this is still nopt consistent when you call the macro with an hardcoded argument on line 70 and without the argument at all on line 80
You should check if it's not empty before using it, as an empty value will fail now.
the license header should be before the namespace declaration
String.format is very inefficient. I suggest using a StringBuilder.
probably not a bad idea ... I didn't add anything here, just removed the unused wallet handler
Doing this piecemeal, but yes, this will get moved in also.
I think we can drop the perl-XML-Simple dependency now, I think it's was needed by RegistrationStatus.pm only (but double check that please).
This is breaking our previous convention - as its specifying specific params you can pass in and allowing you to either get all or nothing whereas the API allows optional setting of all three of these for the query parameters.
Why is the primitive name different from the file name?
elif part['type'].startswith('condition')
Did you mean to leave the log line here?
This is what forces cgminer to move on to the next work item. It needs to be before we return a timeout hashrate, or else we keep rescanning the same work over and over (unless the return value is 0xffffffff, which it shouldn't be in most cases).
wtf? ``@contextmanager``? Or at the very least use a new-style class that is camel cased... also: PEP8!
If this is the custom part, it should be highlighted with a nice big comment so we can more easily retain it when we merge in bug fixes.
There needs to be 2 new lines between the last import and the next section of code.

In fact, between all module-level code blocks there needs to be 2 new lines...
but I would use ===
not necessary, but getting in the habit of always using prevents many small mistakes in the long run
This should be replaced with something like:
```java
static final ObjectTypeAttributeDefinition CONFIG_ATTRIBUTE_DEFINITION = new ObjectTypeAttributeDefinition.Builder(CommonAttributes.CONFIGURATION,ModClusterConfigResourceDefinition.ATTRIBUTES)
.build();
```
These message ids have already been published in a release given to customers.
good catch!

But I'm confused now :)
At first, I passed false since none of these operations modify the service controller state. It always remain UP. When the JMS Bridge is stopped, it closes its JMS connections but the service is still up and running.
If I now pass true to these operations, I should also update the service state depending on the operation. and in that case, I don't know what to do about pause operation. This make sense only for the JMS bridge, not its service.

I'm thinking about changing it again and pass always *false* to reflect that none of these operation chage the service state. wdyt?
spacing: `helper.css("top")` and `helper.css("left")`
|else if (evt.type == 'keyboardhide') | and remove the comment
`gjslint` is not going to be happy with it! ;)
Done #2150
Love the name by the way :)
please use single quotes
Yeah I think we want to avoid mentioning nightly firefox as an option in future docs until we get that environment in order.
Theoretically it works great but its confusing to use it only as a test environment but not a dev environment.
Yes, there is only one system-message. Gecko should manage the cache and this system message sent only for non-menu messages.

Please, check my answer in bugzilla :)
On 20/07/2012 18:53, Etienne Segonzac wrote:
>> @@ -552,11 +552,7 @@ var WindowManager = (function() {
>>                         app.manifest.name, app.manifest, app.manifestURL, true);
>>           }
>>   
>> -        // TODO: handle the inline disposition
>> -        if (e.detail.disposition) {
>> -          setDisplayedApp(origin);
>> -        }
>> -
>> +        setDisplayedApp(origin);
> So we do it for all system messages then?
>
> If that's the plan, this PR is ready to merge!

Yep. If Alarm should belong differently it should not be an open-app 
message in this case.
Maybe the ids are a bit long :)
I guess |var target = evt.target;| at top of the function would be nice too.
So far this code segment would serve as just a placeholder to make sure we have handled type="date/time".
I will cowork with Ian and James to rewrite the code to show the actual time/date picker.

If you think it is OK, I would like to keep the code as is.
Thanks.
Ok, let's keep it as it is. Maybe we'll come back to it later.
For me this is a "magic string". If I change the error message for whatever reason I suddenly have a failing test. Although I never broke something.
I agree that it is a good idea to test if it throws the correct exception, but not by having two magic strings in two places.
The ``BossClient`` does not appear to be under version control
return value, changed to ret_val
Find a less vague name for this and the next variable.
IL => inventory line
Do we need to save the whole profile object in the session? The user object is already in the session, which allows us to get to the profile.
Eh, the only production backend for Search currently is merge_index.  I just wanted to hard code that for now to save time.  I think implementing capabilities like in KV might make sense going forward but don't think it is necessary for this first crack.
It wouldn't be difficult to keep support baseURL, while providing a deprecation warning, so that old configurations with it still work.
done (i've ammended commit)
empty array won't trigger other document relative functions
Should retain it?
Because it is released in destructor.
Just from my experience with these bugs, conditional class definition could be problematic. That is mainly because it is very uncommon, and thus not so heavily tested with APC. This might go through code paths which trigger other hidden opcode errors.

Why not use a separate file to define the class and use require_once here?
We don't need to do this as there is already a deck-change listener setup, so when your href is clicked the work is already done for us. Also what was the point of doing .substr(1) ? We also don't need to use the String() function here as this.href already has access to the substr method
Ok, will do.

-- 
Renaud Gaujoux
Computational Biology - University of Cape Town
South Africa


On 20/06/2012 03:26, hadley wickham wrote:
>> @@ -235,7 +235,13 @@ to_html.link<- function(x, package, ...) {
>>     } else {
>>       topic<- to_html.TEXT(x[[1]])
>>       label<- topic
>> -    t_package<- opt
>> +	parts<- str_match(opt, '([^:]+):(.*)')[1,]
>> +	t_package<-
> I really don't like assigning the results of an if statement - it makes for hard to read code.  Could you please do the assignment inside the if?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hadley/staticdocs/pull/22/files#r1014981
add likely maybe?
Oh I see now, it's not 'formatting json' it's changing json into pdx- makes sense.
For practical purposes I'll accept that. But it's not just the two browsers in our conceptual model, there is a server as well and there is no way to listen to _that_ event queue.  I'll say that the event queues provide a partial ordering across the test run, but if you write the tests _correctly_ (I know, right?) you can achieve a complete ordering.
Please either use `addon-kti/tabs` or `../tabs` this is ambiguous. Also if possible move this to the top of the module, if not please submit followup bug and point to it with a comment.
Actually, as there is not documentation on this, C++ code can be considered as a usefull resource to explain why we are doing this.
To me, this piece of code tells that we have to use `nsISupportsInterfacePointer ` in `setTransferData`. 
This C++ code is a pure equivalent of your JS code.
You could have figured this out by reading it, but the hard part is about how to find such piece of code :p 
(I found it by searching for setTransferData usages)
Can you add a test that they special case error for `opening input stream` is handled as expected by creating a file like `boom.js` which throws a `Error('opening input stream')` ?
what guidance have we got on 'Mozilla Persona' vs 'Persona'?  Is there a rule on when to use what?
If we're limiting the set of valid batches, it seems like that info is pretty important and belongs in a more central place than here, perhaps in `datazilla/model/sql/models.py` (which would also allow it to be used to validate that only valid batch names are used in the database).
Can we make this a constant for now? Would be nice to have it even as a preference so it will be customizable by the user.
make sure we don't end up in an infinite loop?
Why should we ignore it? It should not contain environment dependant properties.
Ah ok, yeah, our Hash is written in Ruby and probably not loaded at the point when this class is loaded.
Do you want these categories only, or can we just output all categories that have code points in the BMP? I can tweak the script if needed.
My changes are complete.  Please review.

Thanks for taking the time to review the changes and let me know if there is anything else I can do to help.

--jon





On Thursday, June 14, 2012 at 11:45 PM, Jonathan Stockdill wrote:

> Thanks for the feedback.  I apologize for dropping the ball. 
> 
> I made the recommended changes, except for the refactor to the util.  I am going to tackle it next.
> 
> --jon
> 
> 
> 
> On Thursday, June 14, 2012 at 1:00 AM, TJ Holowaychuk wrote:
> 
> > > + .replace(/\s+\}$/, '');
> > > +
> > > + var spaces = str.match(/^\n?( *)/)[1].length
> > > + , re = new RegExp('^ {' + spaces + '}', 'gm');
> > > +
> > > + str = str.replace(re, '');
> > > +
> > > + return str;
> > > + };
> > > +
> > > + 
> > > + runner.on('test end', function(test){
> > > + tests.push(test);
> > > + });
> > > +
> > > + runner.on('end', function(suite){
> > > 
> > 
> > 
> > unless 100% necessary we should stream the output, instead of collecting an array and outputting at the end. 
> > 
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/visionmedia/mocha/pull/349/files#r982317
> > 
> > 
> > 
> 
>
PR Team: Only this PHP line has been modified
This is ambigous -- are you asserting against a response header or a request header? I'd rename this to `assertResponseHeader`, and, actually, more accurately to `assertHasResponseHeader`.
i think it's over "((" and "))", should be only : 

     if ($connected_host != $host || $this->connected_to[1] != $port) {
It would be better to add a comment like that to the code as well, in that case.
actions are now chained.
I would modify the version of the repo, then have this script do an in place `sed`.

Also, thanks for the explanation about `sudo echo` - TIL!
I like separated lines because we have a different type of operations in each line.
Please revert this =)
No star imports please.
use the bind section for the "actually important" services
this method is already defined in the Common class
@guilhermeblanco I see.

We can use ```return \PDO::PARAM_STR;``` as default instead a empty block ?
missing a space after ``catch``
Note I would write length() and at() similarly as well, just to get rid of the case and have the logic in the function signatures. But that is mostly due to aesthetics.
FYI: As of the updated CS for ezp-next that was made last year, we don't align lines like this anymore, as it makes diffs larger then needed, and makes it harder to do code refactoring. But as you have seen elsewhere not everyone is following it yet.
Yep, my thought was that for the quickstarts we've already done the cleaning up of compile and build errors. First thing people want to do is deploy…

On 1 Apr 2012, at 15:18, sgilda wrote:

>> 
>> -            mvn jboss-as:undeploy
>> -   6. If you want to redeploy a quickstart that uses a database, you should undeploy it first. This ensures the database is cleaned up correctly before the redeploy.
>> +            mvn clean package jboss-as:deploy
>> +
> 
> The reason I put it in this order was because during the development 
> phase, you often don't even start your server. You only build in order 
> to clear up compile and build errors. It's not until you get to the 
> testing phase that you actually deploy. But whatever you think is fine 
> by me.
> 
> On 04/01/2012 06:16 AM, Pete Muir wrote:
>>> 
>>> -            mvn jboss-as:undeploy
>>> -   6. If you want to redeploy a quickstart that uses a database, you should undeploy it first. This ensures the database is cleaned up correctly before the redeploy.
>>> +            mvn clean package jboss-as:deploy
>>> +
>> Probably I swap the order of this  - Build&  Deploy and then Build Only.
>> 
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/jbossas/quickstart/pull/167/files#r630609
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/167/files#r630733
In Redelm, do we eve rod a check to make sure that the Pig schema is complete? In the same vein, do we want to consider adding a flag to Pig that aborts if the StoreFunc isn't given a Schema (ie it gets mangled somewhere along the line)?
We should alphabetize these imports, so `phonebook.helpers` comes before `phonebook.models` which comes before `users.models`.
Hi davidw93,

Thanks for trying this out. It seems to work fine for me the way it is though. Can you cross check  and / or post the error you get? I'm also on irc if you want to ping me there.

Thanks!
This will pave over QUnit's `test()` function
The encoding of the hyphen here does not match the hyphen in the actual text. The error message is `UnicodeDecodeError: 'ascii' codec can't decode byte 0x97 in position 18: ordinal not in range(128)`
@albanlv please, remove this file from the pull request
isinstance takes a tuple of types. Don't use 'or'.
I guess none of these could be null?
Love the woosh effect!!
nit: I would parenthesize R * R here (why would I? not completely sure…) but it's not necessary.
extra spaces unchanged?
Didn't understand why it was metal
DO not omit the stacktrace here
It makes no sense to use two different names on the potential result.
It confused you a lot, not very much.

You couldn't find any information, not you could find no information.
please don't use the underscore for protected methods
Would it be possible to have all the setup parts (object creation, settings change) in a `setUp()` method and the cleaning/restoring in `tearDown()`?
If you think it would pollute the other tests of this file, then it is maybe better in it's own file.

We have had many misc. problems by not following those best practices, let's not repeat it even if some other legacy tests don't follow them ;-)
у них должна быть логика. изучи кто из них, что делает
We'll probably need some kind of config file where you would define things like the wealth options, what score tracks you're using (here we use destiny and story), etc.
Hey you need to rollback this change or re-merge in the master because this change is back to the old version of browserID.
I'm sorry, I can't accept this change since it is not qhttpserver's job to store the body. qhttpserver should remain a thin wrapper around http-parser providing a nice request response mechanism plugged into signals and slots. But no extra processing.

The security issue is that we can't protect against the user sending too big a file, its application specific.
yes, you're absolutely right.
I wonder if we should store these in a hash as an instance variable for the life of the object?  Not a material concern yet, just thinking out loud.
As long as I'm checking Rails commits regularly I trust the future :)
E-mailinhoud => E-mail inhoud
Bert and I talked about this a bit before. I think in another case we returned null when there was an error. This case is slightly different because there is actual validation here that should trigger the error.

I'm on the fence between throwing an exception with the validation errors, and having a callback. But returning null doesn't seem to be enough.
Theoretically, permissions are checked on actions, not roles. It's very possible in the future we would add actions to roles, and the permissions checks would be actually checked on those. This is just a bridge to that functionality, since we do not need a role -> action relationship yet. I'd prefer to keep the proper concepts embedded in the APIs until then, though.
Do you know that you can merge this into a single line: 

```scala
catch {
  case _: ConnectException | _: SocketException => ()
}
```
```
lol. I see you copy pasted here. That should probably be sce, not pie. :p
We depend on objects with changed `constructor`.  So the above won't work for us. The spec is specifically vague about this:

> 5.1.  type
> ...
> object  Value MUST be an object.

So technically this should be enough: `return (instance && (typeof instance) === 'object')`

But I see the Date and Array problem. Perhaps we should reverse the testing of the instance?

i.e. we decide the "main" type of the instance through a method similar to `testType` (in lib/attribute.js) and compare that against what's in the schema. That way if we move the Date and Array tests above the Object test, Date's and Array's won't validate as Objects.

Anyway I've opened #15 and I want to work on a solution that's suitable for both of us.
And change "un" for "ce"
Agreed, probably via configure option, default to on perhaps?
should be able to do this in a generic way - see https://github.com/brion/WLMMobile/blob/6b321409e224304f012d5abe8ac935a2c6d0191c/assets/www/js/app.js#L936
Monument isn't exported from the module... didn't try models.Monument.
We need to use either "find_by_id!" (exclamation mark) or just "find" so things don't blow up after this line
I'm not sure why your using a .gitattributes, but its causing your changes to change the line endings of the while file, so git-hub thinks the whole file has been modified, making it harder for me to see your changes.
я собственно и имел в виду только экономию на создании char*. Поэтому и написал выше, что в данном случае выгоды нет, т.к. нам нужно использовать nsmutablearray, куда мы помещаем объекты nsstring, которые в данном случае прийдется каждый раз создавать.... Ладно, не суть. Меня давно интересует тема эффективности динамичных контейнеров nsarray в objective C, a именно в сравнении c массивами в C/C++, а также с list и vector из std. Я думаю, это тема собственно не из этой оперы.
Необходимо проверять, не происходила ли уже в этом месте мутация ДНК. В задании это обозначено как "заменять одну ячейку можно максимум один раз". Генератор ПСЧ может повторно выдать то же число.
На нулевом шаге unreplaced_indexes - массив с индексами от 0 до 99.
На каждой итерации из этого массива выбирается случайный элемент, производятся мутация, после чего этот элемент *удаляется* из массива unreplaced_indexes. Таким образом после первого прохода цикла там будет не 100, а 99 элементов, из которых на следующем шаге аналогично выбирается случайный эелемент.

В Вашем примере, если на первом проходе будет выбрано число 10 (к примеру), то будет изменен 10-й элемент. Если в следущей итерации опять выпадет 10, то по этому индексу будет элемент со значением 11.

По поводу стиля да, постараюсь исправить. Просто в основном я пишу на руби, а там другая нотация.
Xcode использует Clang либо llvm-gcc, который фронтендом полностью совместим с GCC 4.2, а следовательно с gcc-objc. Версия компилятора тут только при том, что она определяет, поддерживает ли он определенный стандарт языка. А они оба поддерживают такие конструкции очень давно, так-что о переносимости речь вести немного странно.
Зачем проверять совпадает ли элемент со своей копией?
I was following http://linux.about.com/library/cmd/blcmdl4_console_codes.htm

but now that you mention it, maybe I was misinterpereting the articles own punctuation.
i'll check.
s/listening/receiving messges.

(for the not so TCP-inclined)
This bothers me:

``` javascript
this.options.user.subscribedChannels.role
````

Too many dots. The same thing with

``` javascript
this.options.channel.channel
```

Maybe it's not that bad assign this to the PostView on initialize/constructor method.
should say after notify
Should we use JSON?  It's feature identical to JSON::XS and will use JSON::XS if it's installed.  If it's not installed, then it can fall back to the PP version.
I'm not sure a better way to test the immediacy, since `expect` failures on background threads aren't handled well.
My protoc-gen-go might be outdated (if so, you can file a bug against me to update), but these changes probably shouldn't be included in this pull request just to minimize the number of file touches.
Yes.. having a proper copy method is neat :)
is_power should not be there
def copy(self):

     raw = self.raw.copy()
     del self.raw
     new = deepcopy(self)
     new.raw = raw





On Thu, Dec 6, 2012 at 4:22 PM, Alexandre Gramfort <notifications@github.com
> wrote:

> In mne/epochs.py:
>
> > @@ -463,19 +493,30 @@ def __repr__(self):
> >      def __getitem__(self, key):
> >          """Return an Epochs object with a subset of epochs
> >          """
> > -        if not self._bad_dropped:
> > -            warnings.warn("Bad epochs have not been dropped, indexing will be "
> > -                          "inaccurate. Use drop_bad_epochs() or preload=True")
> > -
> > -        epochs = cp.copy(self)  # XXX : should use deepcopy but breaks ...
> > -        epochs.events = np.atleast_2d(self.events[key])
> > +        epochs = self.copy()
>
> I am always afraid that copy does not do the job. I would hack it with a
> deepcopy after removing the raw attribute...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2335953>.
>
>
Hah, I didn't mean so say it like "I will only work on it if @dengemann won't use it" -- I meant that, if you weren't going to work on implementing it currently or soon, then I could (so that we wouldn't both be working at the same thing, duplicating efforts) :)
Actually it also supports numpy style indexing for the first dimension (events), doesn't it?
Reason why this isn't `private` and `final` like other instance variables?
"1 year worth" should be "1 year's worth". [Quick ref](http://www.grammar-monster.com/lessons/apostrophes_in_time_(temporal)_expressions.htm)
Better use Future.successful for returning a pure Future
i think it is a ' not an upper comma
嗯，这里我疏忽了…… ：）
将...的模块编译到nginx中
逗号换顿号
I think that's enough magic to deserve a comment.
Shouldn't that be a "5", not a "6"? ("http:" is 5 characters)
У меня вся строка Note курсивом
this loop seems useless.
Why `null`?
Debugging leftover? :)
missing extra line
Please store that in a local variable instead of calculating the value twice. We are on smartphones with limited battery. Also please put opening braces at the end of the previous line, that is the agreed style for c:geo sources.
I recommend we use something like this for this:

https://github.com/adzap/validates_timeliness/

Allows us to do things like

```ruby
validates_datetime :finish_time, :after => :start_time
```
You only added the check to AllNodesLogic, shouldn't DistributionLogic have it as well?
k'ay, will do in the next commit
I'm not sure I understand what you mean here. this is not a binary operator
Can we slip in a quick fix to this docstring: 'matplotlib.math.Path' --> 'matplotlib.path.Path'
I like those suggestions.  Maintaining truly bad and/or duplicate colormaps forever is just bad housekeeping, so putting them on a deprecation path makes sense, even if ends up being years before they actually disappear.
I agree that it would be cleaner to eliminate "default" in favor of *None* in this case. @ajdawson is correct that "neither" must be left alone as an option to the original *extend*; I think that @WeatherGod actually meant "default".
No, it is still valid.  I discovered that sphinx chains together the class and constructor docstrings under the constructor heading.  If they are sufficiently different we get away with it (as in the Path class at http://matplotlib.org/api/path_api.html - the constructor docstring begins after the Note), but in this case everything in the constructor docstring is already in the class docstring causing unnecessarily duplication.  I thought the best solution was to remove the constructor docstring.
Should we use the `singular?` pattern here too? The error we're catching could be anything. It'd be better to deal with the error we know about and let any new ones happen so that we actually know about them.
Seems like kind of a bear. If the explanation is this long, is there some way to simplify the underlying function instead?
Anyone know how Postgres is going to handle this? Do we need to plan for downtime? /cc @evanphx @tcopeland
Inconsistent spelling, class is called "tooltip" without a dash elsewhere
I did a search for composite field styling in core and only found file 1 reference to it being styled. But yeah I'll include a note in the upgrading guide about it.
"tab"のほうがベター？
This scares me, to be honest.  The problem is that rollbacks are not side effect free.  In particular, they cause cursors to be closed, so if we made this change it would mean that an application that doesn't handle errors from every WiredTiger call is guaranteed to crash.

Another issue is that we don't actually have deadlocks at the moment.  You argued strongly for using a "deadlock" error code for this case in Berkeley DB, so I went the same way in WiredTiger, but an update conflict is not the same as a deadlock and doesn't always have to abort the transaction (maybe the documentation should say "transactions should *usually* be rolled back...").
I'll move this logic as suggested later.
`optionalInterface` ?
I don't think they should do too much harm. They just let you omit the asInstanceOf in places where the subtype needed can be inferred. They don't do anything different of asInstanceOf then, only trying to give a nicer error message in case that fails. Of course we could omit that special error handling or do some more sophisticated error handling here without having to explicitly do it where we need such casts.

A function would not solve the problem. asInstanceOf already does that (though throwing an error if it's not possible instead of returning None - which is what we probably want in that case, we would have to check for None in lots of places then), this just saves us some writing when inferring the type is possible. Feel free to pull the other commits only if you don't like this one, though, they should not really depend on it.
Should the type for parameter ``$labelPath`` not be ``string|null``?
@schmittjoh it does not seem to know that IteratorAggregate is traversable
0 === count() this is type strick copmarison does not make sense there cause count() alway return integer type, so corect use just ==
The script name is not guaranteed to be `riak` (0.14 and earlier might have `riaksearch`).
s/[*][*]/*/
When reading a cookie with options:

    $.cookie('foo', { path: '/' });

value, the second argument, is indeed options `{ path: '/' }`and thus not undefined. Thus `value !== undefined && (JSON !== undefined || ...)` evaluates to true (in most of modern browsers at least).

Though there is no test for specifically testing this, there are two that would have been broken by your change. Run the tests and you will see.
simulator.bat has to be created as well
Path after / is used to establish unique socket.
I feel like a list of authors that's genuinely too long to display will be pretty rare -- on the same order as, e.g., a package name that's too long to display reasonably. I don't think it's worth worrying about until we actually see it happen.
When would this throw a FiberError? And once again, neck_tick to defer some of the work?
Neat use of WIN32 directly as the default value.

Are there any implications in terms of WIN64 support in using this value?
I'd like us to have some tests that actually get live Splunk results, this will ensure that we remain compliant as things change.
It would undo the commit, but not blow away your changes/files. So if you do 'git status' you'll see what you were working on before the commit (unstaged). It's safer than the --hard option, which wipes away anything you committed.
Wrap this into one div to be more XHTML compliant.
I was waiting for your response. :-) So just go for it.
(Hm, OK, so append moves? And you use remove only for columns?)
You could also not define four different panels, but simply register four times inside the dummy panel. Of course not four times the same, but slightly modified dynamically created classes. ;-)
You can use jQuery `.each` to iterate over all hugs. Or `.grep`.
Spaces around all operators.
`.text`, `unread_counter` does not contain any HTML, no?
Be verbose! Write it out!
Yeh. I blame Bukkit :P. I could work on this later if I have time.
No worries, at least I know I can change things =)
I would use long names again
The problem is in fact in the generation of the usb key, when you try to install xtables-addon-common and xtables-addon-source you can´t compil ipset, it does a dpkg inside a dpkg process
1. Методологически неверно. В теории можно получить как только часть одного пакета, так и пакет с хвостиком от следующих.
Это же касается и последующего кода.
2. Полезно проверять ответы — вдруг там придет что-то не поддерживаемое клиентом
… and we're doing it here anyway for instance
"Would be"?  Is this not happening?
Put in as issue #85.
Unused uniform
Sure.  Fixing now...
...And that was it.
A few of the files have windows line endings, so I assumed it was that.
You mean different contrasts? Yeah, I assumed no one will ever use a non-default contrast outside of ANOVA. This always gives the marginal effect as a comparison with the base level.
i just changed the variable name form sTargetHomeCommunityId to targetHomeCommunityId
You're right.  Do you think this deserves a separate issue (like the SBParse question did) or should I just do it here?
I think it should be POST, not PUT :)

1) Basically, PUT means that you *replace* the resource at the given URL. That is certainly not the case here, you are not replacing a resource at /gelf or /gelf/raw (rather create new resources under the hood).
2) PUT needs to be idempotent. Creating new log entries this way does not seem like an idempotent operation.
Long lines like this are *really* hard to code review.  Pls wrap long lines.
tested comment
Is it really necessary to make everything !important?
Is this a field? Does this work?
je suis pas sur qu'on aie besoin de chiffres si ? par ce que j'ai pas envie de passer du temps a chercher des chiffres la ... Et c'est clair que ;e cine est largement rentable. Quant aux concerts, ca me vient de potes musicos
what is this inspect module? if it's an external dependency, you should add it somewhere (in setup.py or somethin)
See Comment in ExtendedIdentity.
Na realidade a necesidade de alterar o URL para as ações em massa fica a cargo do primeiro nível do path,considerando o modelo envolvido, exemplo:

Imagine que iremos criar um bulk_action para a lista de publishers:

url.py

url(r'^publisher/bulk_action/(?P<action_name>\w+)/(?P<value>\w+)/$', views.generic_bulk_action, {'model': models.Publisher}, name='publisher.bulk_action'),
I've taken it out of being local and put it in splunkd as an app. I've added notes to the README.md about it for the next commit.
What do you mean that you can search the page? What if I want to search for a user, or a Skin? Is page optional?
Thanks for sharing that. I use something very similar. 
In the future this can also be improved to push only the files that have been changed.
What about moving the new constructor arguments at the end so that there is no BC break?
ehhh - I mean 2 space spaces?
Yes. I am reproducing current functionality for this first pull request. Then i'll work at improving.
Yeah, backtrace support was added in PhantomJS 1.6 http://code.google.com/p/phantomjs/issues/detail?id=166
It's  a  pity that it is not updated yet on travis. https://github.com/travis-ci/travis-ci/issues/475
Okay.  Then let's please leave it out here.  In a ``deform`` / ``js.deform`` environment one might want deform's CSS, when using ``deform_bootstrap`` / ``js.deform_bootstrap`` you don't want it.
При ошибках программа должна возвращать ненулевой код возврата.
Did you verify whether this code works in Firefox for Android as well? We need to make sure the change in how tabNavigated is handled doesn't regress Android (or B2G for that matter).
That is a good question. ;-) Should we perhaps sort the list of apps by most recently submitted, before choosing the first free app, which will then cause us to pick up a new app most of the time as other tests are creating apps?
missing indentation level
No more needed in foundation 3
This trailing comma will cause issues with backwards compatibility
This is true, except it really needs to query *h_*students_peoplesoft
This is (and was) incorrect. this is not what StratifiedKFold does. It preserves the class ratios / label distribution within each fold.
interesting usage of structured arrays, I didn't know you could do that.
Fixed in  bc4e8f5
This use statement is unused (it is an abstract class btw)
Fair enough, all in all it doesn't really matter.
Can you rename this to notificationManager as we the majority of the code doesn't use the mXXX naming standard.
added comment to the part 2 jira task. wil implement second param there.
I will put in the ```removeBlock:inRequest:atKey:```` but I don't see that being *too* useful unless someone keeps a local copy of their block that can be compared agains the one in the set . Can blocks even be compared?
-1 is passed if the input meta info indicated that the number of rows is unknown.
Don't get it Chris: if the if is satisfied (= the update failed), an exception is thrown. Otherwise (= the update worked fine), the else block will be executed as it should
I have confirmed this by patching locally:

    def get_addons_results(self, report):
        addon_path = tempfile.mktemp('.addon')
        zipfile.ZipFile(self.testrun.target_addon, "r").extractall(addon_path)
        report['target_addon'] = AddonManager.addon_details(addon_path)

        return report
The reference should be `tags/Smarty_3_1_7/distribution/` to match the dist and version.
This notation raises an error:

```
undefined method `url' for nil:NilClass
```

And in the console output:

```
NoMethodError - undefined method `url' for nil:NilClass:
	/home/jack/Git/leacock-gallery/app/views/artwork/gallery.slim:14:in `block (3 levels) in evaluate_source'
```
Should I change it to the Piffle notation, or are you able to fix the issue?
nth-child 6 is another magic number
Is there any other option to locate this element because I think link text can be changed any point of time then driver would not be able to locate this lement.
missing spaces.

And you could use ``Kernel::VERSION_ID`` for an easier check (available as of 2.0.14 but supporting older 2.0 releases is not needed IMO)
@raydavis @ctweney front-end changes are looking good.
You should always leave whitespace between a function and its parameters:

~~~clojure
(vals (frequencies (map rank hand)))
~~~
Why ? If it's required by your plugin, then the plugin should change the value, otherwise exiting customer will have to review their code.
Oh, I think I see it. We're only copying files that we want to overwrite, and leaving unique files to be loaded as part of the plugin. This is super-special and could definitely use a better comment.
when debugging problems, one just have to uncomment the line, recompile and test. saves times when developping for posix meterpreter
No more than 100 columsn per line in the description pls
PEP8  (no whitespace after `(` and before `)`). There are a few places in the code with such superfluous whitespaces inside brackets, the pep8 script can find them automatically for you.
temporary image lang to pero pakibalik sa /assets
You may want to use `ds)ds{yss"` here instead (delete the parentheses before the curly braces) because if the user does not move the cursor after the previous `yss)`, it will be on the opening parenthesis and `ds{` will not work.

Otherwise advise the user to first move the cursor back onto (or inside) the curly braces.
When materials are build on other materials, they may have the same GLSL function names, e.g., `agi_material`.  The GUID is used to make them unique.  @IanLilleyT, can the solution be as simple as a counter per-material.  This doesn't need to be globally unique, right?

Also, @mramato alludes to a good development principle:  don't comment _what_ you are doing, comment _how_ or _why_ you are doing it.
Not to be nitpicky, but the above var declarations are hard to read.  We tend to use the Eclipse auto-formatter and then tweak by hand as needed.  The above could just be 4 lines, with one var a line.
I think my intent here was to remove all the temporary styling from the canvas, since this function actually returns the canvas to the caller, who shouldn't have to know about the shenanigans that we do in here.  So I think display and visibility should be set back to undefined, leaving the canvas in a default state.
@kring I'd probably remove it.  I was actually pretty confused when I first saw this.
Thanks.  I think I'm going to do that as one big rename in a separate pull, rather than doing each type one at a time.  This way they all end up changing at once and it does introduce noise into this pull request.
This `else` statement is useless.  If `'terms' in original_context` is `True`, you return something, which also means you leave this function.  The `else` is therefore verified each time it is parsed.
Hmm, I think it is valid that a route does not have an exception route, which is why null is being allowed. I'm not fond of returning null either, and perhaps we could perhaps use an Optional from Guava, or perhaps some sort of NullRoute. What do you think?
Yeah probably not needed anymore. I think there was code accessing the "window" before, but it's gone now.
I dont think so. All the activities are either TiBaseActivity or a descendent. There used to be TiTabActivity but that was removed with Josh's refactor.
valueOf(view.children).shouldBeObject()
After talking to Sabil, we think this is the correct information:

```
This value is only useful on iOS. On iOS, you should use the VIDEO_CONTROL_FULLSCREEN when creating a video player that occupies the entire screen. That is:

- The parent window should be a fullscreen window ([fullscreen](Titanium.UI.Window.fullscreen) set to `true`).
- The video player should occupy the entirety of the parent window.

If the user clicks the **Done** button in the fullscreen control bar, the video player pauses playback and generates a [complete](Titanium.Media.VideoPlayer.complete) event. 

Note that if  you create a video player that does *not* occupy the entire screen, and later switch to fullscreen mode, the video controls are switched automatically. That is, if `mediaControlStyle` is set to VIDEO_CONTROL_DEFAULT or VIDEO_CONTROL_EMBEDDED, it is automatically switched to the fullscreen controls when the player enters fullscreen mode. This is true whether the user initiates the mode switch by  clicking the fullscreen button in the embedded controls, or if you programmatically switch to full screen mode (by setting the `fullscreen` property to true).
```
Can we call this "chars" or something? Global isn't very descriptive. Is char a reserved word? If not, we could create a function, char(), that takes a single character string and returns the character code for it. Might already be a function like that...
While I can understand your sentiment, much code in eclipse lacks the @Since tags, and it's impossible to know exactly when an API was introduced. This would require backwards testing. 

But in general we should stick to the major versions. Unfortunately eclipse automatically adds these version restrictions.
implemented in 0d1f63d099ac374978254d64a0a29135232bdd15.