Fix (what appears to be) a minor "off by one" bug in 'for' loop.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45500 f5534014-38df-0310-8fa8-9805f1628bb7
Move proto_register...() and proto_reg_handoff...() to the end of the file as per convention;
Do minor whitespace changes.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45503 f5534014-38df-0310-8fa8-9805f1628bb7
The "rate" field in the CommView NCF format is 1 byte long, not 2 bytes
long; that means we read only one byte into our structure, so make its
"rate" element one byte long, so we don't fill in half the "rate"
element with the read - and the *wrong* half on big-endian machines -
and leave the other half un-set and thus containing some random possibly
non-zero data.

In addition, that's not the full data rate for faster networks; for
Wi-Fi, the one-byte "direction" field is actually the upper 8 bits of
the data rate, so combine them when we fill in the data rate in the
pseudo-header.

#BACKPORT


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45504 f5534014-38df-0310-8fa8-9805f1628bb7
And that also means that we need to split the data rate from the
pseudo-header into two bytes and fill in both the rate and direction
fields when writing CommView NCF files out.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45507 f5534014-38df-0310-8fa8-9805f1628bb7
Do not use private_data from caller dissector as IKEv2 decryption parameters


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45510 f5534014-38df-0310-8fa8-9805f1628bb7
Use seasonal allocation for name resolution. This effectively scrubs our
resolution information between capture files so that we don't leak host
entries from one file to another (e.g. embarassing-host-name.example.com
from file1.pcapng into a name resolution block in file2.pcapng).

host_name_lookup_cleanup and host_name_lookup_init must now be called
after each call to se_free_all. As a result we now end up reading our
various name resolution files much more than we should.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45511 f5534014-38df-0310-8fa8-9805f1628bb7
Add a packet format group box, similar to the packet range group box.
Use it in the new "Export Packet Dissections" dialog.

I'm omitting PostScript exports on purpose. If you *really* need that
feature you can probably get better results than we produce using text +
enscript or print-to-PDF + pdf2ps/pdftops or PSML/PDML + XSL + ...

The Windows code is untested. I'll check in any needed fixes shortly.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45513 f5534014-38df-0310-8fa8-9805f1628bb7
Fix Windows compilation problems from r45513. #ifdef out some non-Windows
code.  Get rid of a few uses of the global cfile.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45514 f5534014-38df-0310-8fa8-9805f1628bb7
Fix initialization order.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45515 f5534014-38df-0310-8fa8-9805f1628bb7
Add missing arguments.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45516 f5534014-38df-0310-8fa8-9805f1628bb7
Fix compilation with GCC:
- initialization order
- unused and uninitialized local print_args_t
- missing comment on #endif


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45517 f5534014-38df-0310-8fa8-9805f1628bb7
Reduce variable scopes where possible.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45518 f5534014-38df-0310-8fa8-9805f1628bb7
Always initiailize member variables in constructors, even if it's just to NULL.
Use C++'s initializer syntax more.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45519 f5534014-38df-0310-8fa8-9805f1628bb7
Enhancements to the CppCheck script:
- make html output a flag (-h), instead of what happens when you
  specify no files
- add flag (-j) for job count, like make et al.
- add flag (-a) to ignore the suppressions file and report all issues
- require /bin/bash instead of just /bin/sh in order to get arithmetic $(())
- add mode-lines


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45520 f5534014-38df-0310-8fa8-9805f1628bb7
Don't add FT_UINTn values with proto_tree_add_int().  (The fields in
question are 4-byte header fields containing bitfields, so "unsigned" is
appropriate here.)


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45521 f5534014-38df-0310-8fa8-9805f1628bb7
Add 2 new file extension associations, and restore alphabetical order.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45522 f5534014-38df-0310-8fa8-9805f1628bb7
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7857 :
Fix an infinite loop in WaveAgent dissector


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45523 f5534014-38df-0310-8fa8-9805f1628bb7
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7858

Use a full 32-bit literal instead of just a 16-bit one. Fixes case where
the value we're &-ing with just slips over 2^16, making us get stuck
in an infinite loop.

I'm not sure this matches the iscsi spec anymore, the comment in the code
about padding bytes is ambiguous as to whether they're leading or trailing.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45524 f5534014-38df-0310-8fa8-9805f1628bb7
The Interface Name field of the Interface Name sub-object of the
Interface Information object for ICMP is *NOT* null-terminated.  Use
tvb_format_text() for now, to properly null-terminate the display string
and to cope with non-ASCII data.  (It should ultimately be a named field
with an encoding of UTF-8.)


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45525 f5534014-38df-0310-8fa8-9805f1628bb7
*Always* create a new data source when we decompress an IPv6 header.

Label the data sources for them as "6LoWPAN xxx", where "xxx" is the
type of compression, and label the data sources for reassembled
fragments as "Reassembled 6LoWPAN".

Fix the capitalization of "6LoWPAN".

Note that if reassembly fails, continuing dissection is not the right
thing to do, at least not if it failed because we don't *yet* have all
the fragments.


git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@45527 f5534014-38df-0310-8fa8-9805f1628bb7