fast/html/marquee-alternate.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=94130

Patch by Jessie Berlin <jberlin@apple.com> on 2012-09-02
Reviewed by Simon Fraser.

Disable the test because it is flakey on so many platforms. Remove it from the Skipped and
TestExpectations files so that run-webkit-tests doesn't go looking for it.

* fast/html/marquee-alternate.html-disabled: Renamed from LayoutTests/fast/html/marquee-alternate.html.
* platform/chromium/TestExpectations:
* platform/efl/Skipped:
* platform/qt-arm/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Add missing semicolon at the end of some lines.
https://bugs.webkit.org/show_bug.cgi?id=95640

Patch by Byungwoo Lee <bw80.lee@gmail.com> on 2012-09-02
Reviewed by Gyuyoung Kim.

EWK_VIEW_PRIV_GET_OR_RETURN macro and other related macro can be used
without semicolon, because it ends with a semicolon or complete block.
This can make a human mistake about missing semicolon.

Fixed the macros to require semicolon, and added missing semicolons.

* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_initialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Build is broken when SVG is disabled.
https://bugs.webkit.org/show_bug.cgi?id=95653

Patch by Mike West <mkwst@chromium.org> on 2012-09-02
Reviewed by Dirk Schulze.

Adding CSSPropertyWebkitClipPath to the massive switch statement in StyleResolver.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Improve the way we use convertedSpaceString() in convertHTMLTextToInterchangeFormat()
https://bugs.webkit.org/show_bug.cgi?id=95301

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-02
Reviewed by Darin Adler.

The static string convertedSpaceString() had a couple of annoying side effects:
-The string was 16bits due to noBreakSpace, which forced any input to be converted to 16bits.
-The string was kept in the heap for no particular reason.

This patch redefines convertedSpaceString as a constant literal so that we can use it efficiently.

The patch also make the binary a tiny bit smaller (700 bytes).

* editing/HTMLInterchange.cpp:
(WebCore::convertHTMLTextToInterchangeFormat):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Refactored scope chain opcodes to support optimization for named function expressions
https://bugs.webkit.org/show_bug.cgi?id=95658

Reviewed by Sam Weinig.

Renamed
    push_scope => push_with_scope
    push_new_scope => push_name_scope
to clarify the difference between them.

Changed push_with_scope and push_name_scope not to save the new scope in
a temporary register, since doing so made optimization harder.

(The old behavior was a hold-over from when the scope chain wasn't
a GC object, and wouldn't be marked otherwise. Now, the scope chain is
marked because it is a GC object pointed to by the call frame.)

Changed push_name_scope to accept an operand specifying the attributes
for the named property, instead of assuming DontDelete, because a named
function expression needs ReadOnly|DontDelete.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::highestUsedRegister): Removed this function,
which used to be related to preserving saved scope object temporaries,
because it had no callers.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fixed failures seen on Linux bots.

* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_push_with_scope):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_push_with_scope):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h: push_*_scope doesn't have a destination operand anymore.
Accordingly, update these places in the baseline JIT, which I missed in my last patch.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed test expectation update after r127362

* platform/chromium/TestExpectations: Moved
fast/notifications/notifications-event-listener-crash.html to
http/tests/notifications.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Tests] fast/forms/time-multiple-fields/time-multiple-fields-appearance-*.html should dump text instead of render tree
https://bugs.webkit.org/show_bug.cgi?id=95545

Reviewed by Kent Tamura.

This patch changes test expectations to text output and pixel images
instead of structure of render tree and pixel images for multiple
fields time input UI. This patch helps us to avoid rebaseline when
we change DOM structure but keep appearance.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

* fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic.html: Changed to call testRunner.dumpAsText().
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly.html: Changed to call testRunner.dumpAsText().
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes.html: Changed to call testRunner.dumpAsText().
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html: Changed to call testRunner.dumpAsText().
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Added.
* fast/forms/time-multiple-fields/time-multiple-fields-appearance-style.html: Changed to call testRunner.dumpAsText().
* platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
* platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
* platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.txt: Removed.
* platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
* platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.txt: Removed.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.txt: Removed.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][WK2] Keep activePopupMenu to call valueChangedForPopupMenu() outside showPopupMenu()
https://bugs.webkit.org/show_bug.cgi?id=95355

Reviewed by Gyuyoung Kim.

Efl does not have a proper way to support nested loop so that applications
may change value after showPopupMenu() is finished.

* UIProcess/API/efl/tests/test_ewk2_view.cpp: Improved test case to cover this bug.
(selectItemAfterDelayed):
(showPopupMenu):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showPopupMenu):
Guard with !PLATFORM(EFL) to keep the activePopupMenu valid to call valueChangedForPopupMenu
outside showPopupMenu().


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Forms] AM/PM field of multiple fields time input UI should be fixed width
https://bugs.webkit.org/show_bug.cgi?id=95542

Reviewed by Kent Tamura.

This patch changes width of AM/PM field of multiple field time input
UI fixed as maximum width of labels or "--".

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.

* css/html.css:
(input::-webkit-datetime-edit-ampm-field): Added "display" property to "inline-block" for setting width.
Added "text-align" property to "center".
* html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement): Changed to call setHasCustomCallback().
(WebCore::DateTimeSymbolicFieldElement::customStyleForRenderer): Added for setting field with from maximum width of labels.
* html/shadow/DateTimeSymbolicFieldElement.h:
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Added for using visible empty value in customStyleForRenderer() and visibleValue().
(WebCore::DateTimeSymbolicFieldElement::visibleValue): Changed to call visibleEmptyValue() instead of using literal "--".
(DateTimeSymbolicFieldElement): Added a declaration of customStyleForRenderer().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Unreviewed test expectation update after r127398

* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
* platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Forms] Empty visible value of AM/PM field of multiple fields time input UI should display variable number of "-" based on maximum number of labels
https://bugs.webkit.org/show_bug.cgi?id=95660

Reviewed by Kent Tamura.

This patch changes visible empty value of AM/PM field in multiple
fields time input UI to "-", "--", "---", and so on based on maximum
length of AM/PM labels. In current implementation, it is always "--"
regardless locale, although on Arabic, AM/PM are represented in one
character.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.

* html/shadow/DateTimeSymbolicFieldElement.cpp:
(makeVisibleEmptyValue): Build visible empty value from maximum length
of labels.
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Changed to
use m_visibleEmptyValue.
* html/shadow/DateTimeSymbolicFieldElement.h:
(WebCore::DateTimeSymbolicFieldElement): Added new member variable
m_visibleEmptyValue to hold visible empty value.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
WK2: Build failure on SnowLeopard after r127384
https://bugs.webkit.org/show_bug.cgi?id=95665

Reviewed by Dan Bernstein.

Add SandboxExtension::consumePermanently(const Handle&) for !ENABLE(WEB_PROCESS_SANDBOX) to fix link error.

* Shared/SandboxExtension.h:
(WebKit::SandboxExtension::consumePermanently):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL] Update TestExpectations for 2 fast/block tests
https://bugs.webkit.org/show_bug.cgi?id=95666

Unreviewed EFL gardening.

Update TestExpectations for 2 fast/block tests to
indicate that we expect TEXT only diff on the bot
since we don't run pixel tests.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-03

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][WK2] Mark several inspector test as flaky
https://bugs.webkit.org/show_bug.cgi?id=95667

Unreviewed EFL gardening.

Mark several inspector test cases as flaky on
WebKit2 EFL.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-03

* platform/efl-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK][EFL] 'dictIter' iterator is not initialized for an inner loop
https://bugs.webkit.org/show_bug.cgi?id=95436

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

The 'checkSpellingOfString' method assumes that the given string is concatenation of words.
To properly handle spellchecking of each word we need to iterate over the all available
dictionaries ('dictIter').

To allow spellchecking for multiple words, 'dictIter' should be initialized at the beginning
of vector while spellchecking of the word. This ensures performing of spelling for word based on
at least one dictionary.

* platform/text/enchant/TextCheckerEnchant.cpp:
(TextCheckerEnchant::checkSpellingOfString): Moved initialization of 'dictIter' to an inner loop.

LayoutTests:

'checkSpellingOfString' from the TextCheckerEnchant class can not mark multiplie words that are misspelled.
It's possible to mark misspeled string only by defining its location and length.

* platform/gtk/TestExpectations: Added spelling-backspace-between-lines.html to TestExpectations.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][WK2] Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage API test
https://bugs.webkit.org/show_bug.cgi?id=95671

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-03
Reviewed by Kenneth Rohde Christiansen.

Skip EWK2UnitTestBase.ewk_cookie_manager_permanent_storage
API test since it is flaky on the bots.

* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed rebaseline for bug 94287.
Update Chromium-Mac and Chromium-Win images for multiple field time input UI.

* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Added.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r127406.
http://trac.webkit.org/changeset/127406
https://bugs.webkit.org/show_bug.cgi?id=95674

Expectation images are missing (Requested by yosin1 on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-03

* platform/chromium-mac-snowleopard/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
* platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png: Removed.
* platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.txt: Removed.
* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Build fix for ENABLE(CLASSIC_INTERPRETER) after r127393.

* interpreter/Interpreter.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127408 268f45cc-cd09-0410-ab3c-d52691b4dbfc